- 17 Mar, 2020 40 commits
-
-
Anand K. Mistry authored
This delegate will be used to implement server-side copy/move, and to intercept certain operations (eg. read directory) to provide UI in error cases. Bug: 1054704, 1054689 Change-Id: I506a8e606c3fdf40d9a0016dfde1b9954c1b4f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106039Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#751180}
-
John Budorick authored
This reverts commit 4b6040f2. Reason for revert: not responsible for breakage. Original change's description: > Revert "Add CertProvisioningWorker class" > > This reverts commit d8c37dee. > > Reason for revert: spec revert for https://bugs.chromium.org/p/chromium/issues/detail?id=1062423 > > Original change's description: > > Add CertProvisioningWorker class > > > > CertProvisioningWorker class implements core logic for building > > a CSR with DM server and importing corresponding certificate. > > > > Bug: 1045895 > > Test: CertProvisioningWorkerTest.* > > Change-Id: Ida540f2b330d0dac9e86f53568f29287559a1ad8 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078582 > > Commit-Queue: Michael Ershov <miersh@google.com> > > Reviewed-by: Pavol Marko <pmarko@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#750986} > > TBR=achuith@chromium.org,pmarko@chromium.org,miersh@google.com > > Change-Id: I06d5c2889f05563980a20b42ff00c635da5677db > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1045895 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107394 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751138} TBR=achuith@chromium.org,pmarko@chromium.org,jbudorick@chromium.org,miersh@google.com Change-Id: I0e1010a22b003d7e91f3bf1cba46f2b8d66c8de3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108063Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#751179}
-
George Steel authored
Move computed_style_property_map.cc::ComputedTransformComponent() to ComputedStylePropertyMap::ValueForTransformOperation() in preparation for its upcoming use by animations code. It has been moved verbatim except for renaming it according to current conventions. Add ValueForMatrixTransform to COmputedStyleUtils class. It previously had no declaration in the header. This causes no behavioral change. Change-Id: I94faea6fac02a2ee37b88d32fed326142c0ec01e Bug: 933761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106497Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#751178}
-
Swapnil authored
Change AddExtension method in ManifestFetchData class so that it accepts the Manifest::Location instead of std::string as we would need it in case of offline installation from cache in https://crbug.com/1051870. Bug: 1061402 Change-Id: I336e240d659095f94796d3aec06c51f4b577d6ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100820 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#751177}
-
Xida Chen authored
Right now in the ReportMainFrameCausedNoDamage, we set the begin_main_frame_data_.previous_sequence to 0 only if the frame args is the same as the current main-frame args. This CL turns the if statement into a DCHECK. It basically means: if the no-damage report comes, it must come before the next ReportBeginMainFrame. Bug: None Change-Id: I6c02855c5fac4721a430cd03610c8ead17d8a411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105400 Auto-Submit: Xida Chen <xidachen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#751176}
-
Scott Violet authored
Instead of an error. BUG=none TEST=none Change-Id: Idb16fdbc6171c4481adbcfe2ab88f7b17aa5b5a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108062Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#751175}
-
Scott Violet authored
Previously a script (testing/scripts/run_android_wpt.py) was writing the commandline to a file, but that isn't the right place as it meant any arguments from wpt were effectively dropped. This makes chromedriver write the commandline flags to a file for webview as it does for weblayer and clank. BUG=1059990 TEST=test only change Change-Id: I221bee623066712607395b50c50a70d156a24560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108000Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#751174}
-
Becca Hughes authored
Fix the flaky test which was waiting for the URL which we didn't actually need. BUG=1060626 Change-Id: Ib29ebabf9c0ff0bf803fbc7f2af5c1dde7ac525d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106970Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#751173}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e6420a421590..56686c32e743 git log e6420a421590..56686c32e743 --date=short --first-parent --format='%ad %ae %s' 2020-03-17 thestig@chromium.org Fix some typos in fpdf_formfill.h. 2020-03-17 tsepez@chromium.org Remove another usage of CFXJSE_Value from CFXJSE_Class. 2020-03-17 tsepez@chromium.org Replace CFXJSE_Value with CFXJSE_HostObject in FormCalc JS. 2020-03-17 nigi@chromium.org Roll third_party/depot_tools/ 816c2b354..8cf12290b (116 commits; 21 trivial rolls) 2020-03-16 tsepez@chromium.org Remove use of CFXJSE_Value to return formcalc JS results. Created with: gclient setdep -r src/third_party/pdfium@56686c32e743 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I26757531320761012bb03af99fcada0fadbe04c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107789Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751172}
-
Toby Huang authored
We are reverting crrev.com/c/2017646c and crrev.com/c/2018501. We decided that blocking mature extensions and themes is better implemented on the Chrome Web Store server side. The MatureExtensionChecker has already been removed in crrev.com/c/2099237. Since the MatureExtensionChecker was the only mechanism for adding disable reason BLOCKED_MATURE, we can now remove this disable reason in Chrome. Moreover, since the mature extensions tool-tip only shows when disable reason BLOCKED_MATURE is present, we can remove the tool-tip as well. Bug: 1060451 Change-Id: I5b702b61a14b8ab515ce6718d590415ce6933cb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101849Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#751171}
-
Austin Tankiang authored
This function is only used to migrate legacy drive paths, so hide it from being used by others. Also change IsUnderDriveMountPoint() to work with DriveFS paths instead. The function is used in places where there is no profile object easily available, so avoid using DriveIntegrationService to implement it. Bug: 1003238 Change-Id: Ia50f6df50e195ea246b3adf000777fa5d2151101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105666 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#751170}
-
Sara Kato authored
Android version of a11y_helper.mojom is version 20, update Chrome version to match this. Rename eventText to event_text, to ensure consistency among other variables in mojom file. Bug: none Test: build passes Change-Id: I4899a59adb0553803e109319e155a89e4b91bb18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102993Reviewed-by:
Hiroki Sato <hirokisato@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#751169}
-
Xinghui Lu authored
In crrev.com/c/2092697, a memory upper threshold was introduced to control real time URL check. However, it turns out the change won't work because high-end and low-end devices are still being controlled by the same flag "kRealTimeUrlLookupEnabled". Once high-end devices are launched, finch will warn us with "both high-end and low-end studies apply to the same feature flag and affects the same population." See the warning in cl/300834155. To avoid the conflict, it might be easier if we revert the change in crrev.com/c/2092697, and add a new flag named "kRealTimeUrlLookupEnabledForAllAndroidDevices". The new flag will be independent of the old flag, so it won't be affected by the high-end devices launch. Bug: 1014202 Change-Id: Id7c0ef84a0ba8f45ea5628fcec472a678450445b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2104869 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#751168}
-
rbpotter authored
Bug: 1026426 Change-Id: I7ab64f81a48d400e8bab92c4d977d0ea0d50a11e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107233 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#751167}
-
Eric Orth authored
Bug: 1037961 Change-Id: I8a81e4c1295dc15c373846694c165eacdba71843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099085Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#751166}
-
Caleb Rouleau authored
NOTRY=true R=ulan@chromium.org TBR=ulan@chromium.org Bug: 1062438 Change-Id: If81aed43750d93d5c61b02e22c8e40b9f2acec81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108060Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#751165}
-
Becca Hughes authored
Do not save data if the SavingBrowserHistoryDisabled pref/policy is enabled. BUG=1051239 Change-Id: I81f64b1bb257039e7c6d5081ad94572986b9f674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106465Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#751164}
-
rbpotter authored
Migrating contents of site_settings individually based on elements with tests, to avoid extremely large CLs. Bug: 1026426 Change-Id: I6f62a6b36bf049398464ea803cfcd382b8137747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103753 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#751163}
-
Wenyu Fu authored
Moving Homepage related settings code to homepage.settings package Change-Id: Iaf198f4a25cc03b32a1de997577d466916470437 Bug: 1052060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095468 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#751162}
-
Sebastien Lalancette authored
Take 2 of the change, original CL was reverted due to tests flakiness: https://chromium-review.googlesource.com/c/chromium/src/+/2102542 In this new change, we're making less drastic changes to existing tests. Rather, we add a new test case which covers exactly the bug's symptoms - making sure its fix won't be regressed in the future. Tests flakiness was occurring in the iphone-device builder. I've tested this new patch against that builder ~3 times now and it looks much better than when using the previous patch. Bug: 1058388 Change-Id: I459f8c3f66e7ac2d6c11232a75ad95b8c6026cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106802 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#751161}
-
dpapad authored
The latter is a better name for the contents of that file, as it is no longer a Polymer behavior. Also re-running clang-format. Bug: None Change-Id: I1e638271b5d973c426d392ee3fc9dbd7e0114bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107055 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#751160}
-
Sahir Vellani authored
In order to correctly snap box sizes to pixels using SnapSizeToPixel, the function FragmentData::PaintOffset() needs to be used. This function provides an accurate location/offset of the box in question. However, this the paint offset is determined in the PrePaint lifecycle phase. To accommodate this, LocalFrameView::NotifyResizeObservers is moved to LocalFrameView::UpdateLifecyclePhasesInternal. In addition, UpdateLifecyclePhasesInternal is refactored so that all lifecycle steps prior to paint are run in a loop. The loop is broken when one of the following 3 conditions are met: 1) the target state < kPaintClean 2) No changes to layout are pending 3) Resize observer loop limit is reached Resize Observer can now observe changes to the device pixel content box. ResizeObserverEntry now reports the dimensions of the pixel snapped content box. Bug: 1055579 Change-Id: Ibc7b2e4e0a8468f9af74c8cfaadd02e4f0bcfc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071575Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Cr-Commit-Position: refs/heads/master@{#751159}
-
yilkal authored
This cl adds a space after "set for Chrome." in the per app time limit interstitial error page. Bug: 1061620 Change-Id: Ib84175aeb057ae31b7b45259d1cb81e984477821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107813Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#751158}
-
mark a. foltz authored
This patch closes a Cast virtual connection between a client and a session in two cases: 1. The corresponding PresentationConnection is closed by the renderer. 2. The client sends a "leave session" message. Case #2 could be implemented by #1, but for now, they are both supported for backwards compatibility. Bug: 1059053 Change-Id: I4bfaf5fd4a49adc16980f9ef12b2502c308c1770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099606Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#751157}
-
Mary Ruthven authored
BUG=b:151657331 TEST=None Signed-off-by:
Mary Ruthven <mruthven@chromium.org> Change-Id: Ibf54fae72625c2e769bf518ba221c298ac74eaf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107804Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#751156}
-
Eugene Zemtsov authored
1. Testing that VideoRendererAlgorithm sets frame duration metadata 2. Testing VideoFrameSubmitter correctly calls VideoPlaybackRoughnessReporter This is a follow-up CL for the 2 previous CLs related to the same bug. Bug: 1042111 Change-Id: I47bb5804549dacb9e613ab40f0859cc618e489c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107174Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#751155}
-
Chong Gu authored
Bug: 1058255 Change-Id: I0a8063778458788eceaea0ef036453d42a83aeb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107606Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#751154}
-
Antonio Gomes authored
The target interface is the newly added blink.mojom.FrameWidget (//third_party/blink/public/mojom/page/widget.mojom), chosen after analyzing the call stack of RenderViewHostImpl::SetBackgroundOpaque(). BUG=1047469 R=dtapuska@chromium.org Change-Id: I0ed21a4da2d2d28734ae98990840578098683613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102510 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#751153}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/beefcb9d38c0..56015e01150e git log beefcb9d38c0..56015e01150e --date=short --first-parent --format='%ad %ae %s' 2020-03-17 fmalita@chromium.org SkStrikeCache: only validate post-purge 2020-03-17 csmartdalton@google.com Remove DynamicStateArrays from GrProgramInfo and GrPipeline 2020-03-17 csmartdalton@google.com Migrate GrFillRectOp and GrTextureOp to the new bind/draw API 2020-03-17 kjlubick@google.com Add fiddle demonstrating alpha when used on saveLayer Created with: gclient setdep -r src/third_party/skia@56015e01150e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: egdaniel@google.com Change-Id: I36f6124e0e56fe3f34c25b10f0dd34bd20871ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107788Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751152}
-
Vasilii Sukhanov authored
Mocks: https://docs.google.com/presentation/d/1yWuZO-fjXhdRp64nWRbnHEyzpFd1KOMS3u1_1XMdGuA/edit#slide=id.g76725620de_2_26 Bug: 1049200 Change-Id: I6383aca4cf0e7abc8552d0f83072440f7384e43b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106054Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#751151}
-
Danyao Wang authored
The feature was landed a while ago. This CL adds missing browsertests. Bug: 922683 Change-Id: I798bcea5acee34c55c887464509684827a05b6eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103442Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#751150}
-
Rainhard Findling authored
Replaces all instances of |#| as the numeric placeholder in pluralization strings with the new |{NUM_...}| format, as outlined in go/icu-message-migration. Change-Id: I2c5fb78cc93369b0e7f6e0365d7edef8eea32368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106171 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Auto-Submit: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#751149}
-
Kevin Marshall authored
Implements the class which reads changes from base::Histograms and serializes the differences as FIDL data (fuchsia::legacymetrics::Histogram). Bug: 1060768 Change-Id: I961e5dc3d05b898426c5159512de8c90f155a653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100938 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751148}
-
Robbie McElrath authored
This is a reland of b2882c21 with changes so Clank doesn't break. Original change's description: > [WebLayer] Move browserservices.Origin to //components/embedder_support > > browserservices.Origin is used by Chrome's site settings page, which > is being componentized so it can be used by WebLayer. This CL moves > the class to //components/embedder_support. > > Bug: 1058597 > Change-Id: Ic47da47f372d1c27238efd2fee8d7bdcba6eb63d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090875 > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Bo <boliu@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750294} TBR: twellington@chromium.org, jdoerrie@chromium.org Bug: 1058597 Change-Id: If7a301e851d8f8eca963532cada83dadbc6622e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105398 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#751147}
-
Yue Zhang authored
This reverts commit fb08e564. Reason for revert: Workaround introduced didn't fix the crash. Original change's description: > Fix a crash in pop-up tab strip > > In the popup TabStrip used by Duet-TabStrip integration, there is a > crash in RecycleView when user very intensively clicks on the TabStrip > favicon to close multiple tabs. The stack indicates that the > recyclerView is trying to remove the same ViewHolder in two consecutive > remove operations, and the second call would crash. The fix introduced > in this CL is to early end the animation if we know for sure that this > item is going to be removed. This should help with better identifying > the ViewHolder to remove. > > This fix is inspired by the discussion here: > https://b.corp.google.com/issues/34184109 > and the CL here: > https://critique.corp.google.com/#review/188055979/depot/google3/java/com/google/android/apps/play/music/app/ui/common/MediaListRecyclerFragment.java > Even though we early end the animation, there should be no visible > animation change from the UI perspective. > > Bug: 1045944 > Change-Id: I0d8a7b098e17cdc86c4ae3227cd9dc1ba37b2adc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036874 > Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738392} TBR=yusufo@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1045944 Change-Id: I733bc7729f9118808999e59695ae01b7194ef0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107120Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#751146}
-
rbpotter authored
- Add lazy_load.js for Polymer 3 settings and an ensure_lazy_loaded.js file to perform the import. - Update build rules to generate multiple modules - Update tests to import lazy_load.js as appropriate - Add rewrites to BUILD rules to import correctly, and add a dummy ensure_lazy_loaded.html so that the import can be generated by the autogenerator. Bug: 1026426 Change-Id: I6ed01d9a414f8a464d88a5d88aa8f63f7233899d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102082Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#751145}
-
Tricia Crichton authored
When getting cookies, Convert cookie expiration to int64 for compatibility with SetCookie, which rejects an expiration set as a double. Bug: chromedriver:3331 Change-Id: I911ff6169ec9ed5efaaa01ff76f7a846733d7f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106736Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#751144}
-
Rouslan Solomakhin authored
Before this patch, "Lollipop Phone Tester" bot running on Nexus 5 timed out while firing the "paymentrequest" event as seen in the error log attached to the https://crbug.com/1061574. This patch disables the minimal UI confirm test on Android L. After this patch, the minimal UI confirm test passes on Android P and K bots, Android Q Pixel 3 local physical device, and Android K emulator. The test also passes on desktop, but that's because Chrome on desktop triggers a skip-UI flow and the payment handler returns the response without showing its own UI. Bug: 1061574 Change-Id: I7be60e761061285170efdcdb30a3f562133e6530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105774Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#751143}
-
Jonah Ryan-Davis authored
Chrome expects libvulkan to be statically linked within ANGLE, so these tests were failing. Wait until we update the build to statically link before we re-enable these tests. Bug: angleproject:4477 Change-Id: Ia5f5f3ac6dd0f210b7770be2863b4d1174143cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106566 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#751142}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/639a4bf5ff46..5efb965c1b4d $ git log 639a4bf5f..5efb965c1 --date=short --no-merges --format='%ad %ae %s' 2020-03-17 dschinazi Do not use iterators in ParsedQuicVersionIsValid 2020-03-17 dschinazi Improve QUIC TLS error logging 2020-03-17 bnc Add test for default return value of QuicSpdySession::server_push_enabled(). 2020-03-16 bnc gfe-relnote: Switch from closing the connection to QUIC_BUG in two ShouldCreateIncomingStream() overrides when called with locally initiated stream ID. Protected by gfe2_reloadable_flag_quic_create_incoming_stream_bug. 2020-03-16 wub gfe-relnote: In QuicBandwidth::FromBytesAndTimeDelta,do multiplication before division to make rounding error less likely. Not protected. 2020-03-16 dschinazi Have ParsedQuicVersionIsValid also validate transport versions 2020-03-16 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_batch_writer_flush_after_mtu_probe. 2020-03-16 dschinazi Prevent crash when trying to serialize packet with missing encryption key 2020-03-16 bnc gfe-relnote: Disable server push. Protected by gfe2_reloadable_flag_quic_enable_version_draft_25_v3 and gfe2_reloadable_flag_quic_enable_version_draft_27. 2020-03-16 quiche-dev gfe-relnote: reset has_non_app_limited_sample in QuicConnectionStats to false once handshake is complete. Logging only change, not protected. 2020-03-16 dschinazi Fix QuicVersion MSVC compilation for Envoy 2020-03-16 wub gfe-relnote: (n/a) Add 2 connection options for BBRv2 to disable 1) adding ack height in queueing threshold, and 2) avoiding unnecessary PROBE_RTTs. Not protected, just more switches for already existing behaviors. 2020-03-16 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_check_handshake_timeout_before_idle_timeout. 2020-03-16 wub gfe-relnote: (n/a) Deprecate --gfe2_reloadable_flag_quic_set_send_algorithm_noop_if_cc_type_unchanged. 2020-03-16 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_no_window_update_if_disconnected. 2020-03-16 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_neuter_unencrypted_control_frames. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src add/delete flags R=zhongyi@chromium.org Change-Id: I990459757848577d6f839306a8fec48d389fb6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106555Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#751141}
-