- 31 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/841b01678c49..6946043676e7 git log 841b01678c49..6946043676e7 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 7e2cba6a5241..618ee509421f (3 commits) Created with: gclient setdep -r src/third_party/angle@6946043676e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: chromium:None Change-Id: Ifd9bc93f8590d99e5e601ceb1c766feee3bd0903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892559Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711184}
-
Marina Sakai authored
This CL removes macro-generated functions for private properties of MessageChannel by using the new API GetSymbol created in CL1877490. Bug: 715418 Change-Id: I913997334d77807bedc5d2cc8022788c0daa80fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888616 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#711183}
-
Caleb Rouleau authored
The possible_browser is not used. The skipping is done later when you try to run the story (in story_runner.py), so skipping here is unnecessary. This change saves ~2 seconds per Android test. The tests seem to run in parallel, so it is unclear how much real time this will save. Bug: 944909 Change-Id: I7e89d7692a79afefcb2706fbaa4d9ce6c1af21e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887873 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#711182}
-
Mihai Sardarescu authored
Re-enable SigninSyncConfirmationTest and ProfileMenuViewExtensionsTestWithScopedAccountConsistency tests. This CLs removes chrome/test/data/webui/signin_browsertest.{h|cc} as they are now obsolete. And it also re-enables SigninSyncConfirmationTest.Dialog test as it should be working now. Bug: 862573 Change-Id: I2de61f71ad7ba3935a358ea0d4d8a1864199e1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890077 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#711181}
-
Tobias Sargeant authored
Enable Crashpad collection of minidumps on Android. Other platforms are skipped because the concept of the user data directory is OS-specific. On Android specifically crashes are written to [app-data-dir]/cache/Crashpad. Test: manual Test: Check current crash count with: Test: adb shell ls '/data/data/org.chromium.weblayer.shell/cache/Crashpad/pending/*.dmp' | wc -l Test: load chrome://crash or chrome://inducebrowsercrashforrealz Test: Check crash count has increased by 1 Change-Id: I9718754dc4218e7e2f2e7737de420db83d4de14b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883653 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#711180}
-
Michael Lippautz authored
This removes - the inline vector arena as they are no different then normal vectors - all but a single vector arena as the heuristics for promptly freeing no longer apply and having multiple arenas causes fragmentation issues Bug: 1014932 Change-Id: I7b5cbd9c2f617bedb921cd5e83cb115bd97bdd9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863804Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#711179}
-
Yi Su authored
Extend the expiration date of 2 metrics for iOS copy image feature: ContextMenu.iOS.GetImageDataByJsResult ContextMenu.iOS.CopyImage Also add gambard@ as backup owner of some metrics. Bug: 1018791 Change-Id: I297f01e1430cb0457b59a11dd22b19de8acd5a95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890052Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#711178}
-
Armando Miraglia authored
TBR=mmoskvitin Bug: 1020070 Change-Id: I2c5f2790ec98ed7587f73cc15a88eeb059303809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891193Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#711177}
-
henrika authored
These changes will make it possible to track down issues related to audio input streams (create/open/close) using native logs. Focusing on AudioServiceAudioStreams since old streams are going away. Tbr: olka Bug: 1017219 Change-Id: Iffbc1880d9eea1868ce1a5e17e298c03328949e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886676 Commit-Queue: Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#711176}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/7a52be2a83..c7284e19a2 TBR=aerotwist@chromium.org Change-Id: Iea2aa69554eeb2b3b5012f4006abcfd8b4673acc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891293Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711175}
-
Leon Han authored
This CL introduces a new record type 'absolute-url' based on the spec change: https://github.com/w3c/web-nfc/pull/373 Now we read/write records containing urls like: 'absolute-url' --> TNF_ABSOLUTE_URI 'url' --> TNF_WELL_KNOWN and RTD_URI BUG=520391 Change-Id: I7b7a57c613eb1581efa01fd148c6083b26cd078a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881786Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#711174}
-
Peter E Conn authored
One fewer TWA specific classes in the Verifier. Bug: 1017114 Change-Id: Ie4602b9b120f9e39efe1bd0cca2b9e9b76c104c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890430Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#711173}
-
Mikel Astiz authored
This reverts commit 38ebe59c. Reason for revert: likely culprit for flakiness in SingleClientUserEventsSyncTest.Encryption. Bug: 1020070 Original change's description: > Rewrite sync tests to use custom passphrase logic > > SingleClientUserEventsSyncTest.Encryption and > TwoClientSessionsSyncTest.NoHistoryIfEncryptionEnabled used > EnableEncryption(), which only works with Directory implementation of > Nigori and outdated. They were rewritten to enable custom passphrase > instead. > > Bug: 922900 > Change-Id: Ia5fedeae5b7c7071c1ecc82063e5742934caf2e0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890316 > Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710839} TBR=mastiz@chromium.org,mmoskvitin@google.com Change-Id: Ie1e8e934c34678b5c96d7a42e293faaefc117c70 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 922900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891172Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#711172}
-
Anastasiia Nikolaienko authored
Project Beaker on Chrome OS is going to allow child users the addition of secondary accounts, but it's going to be limited to web only. - If user has transitioned from child account to regular - TriggerAccountsPushToArc will add accounts to ARC on startup. - If user has transitioned from regular account to child - HandleSupervisionTransition will remove all secondary accounts from ARC. Update is going to be executed on startup, since to transition to another type, user need to sign-out and sign-in again (I think). ARC CL: http://ag/9615344 Bug: 1017160 Change-Id: I323a18aca9c9f63e6a3869d9b9dd4dd34432c31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876089Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#711171}
-
Vlad Tsyrklevich authored
base::ProtectedMemory is being deprecated because it's not widely used enough to make a security impact and justify its maintenance burden. Replace use of base::ProtectedMemory with raw function pointers. The indirect call here is already unchecked due to the blacklist entry added in https://crrev.com/c/1888716 Bug: 1018834 Change-Id: I68dc018737be985e0bf968d37d117321f53d86ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890986 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#711170}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7677c2ab05a0..9de9e749612a git log 7677c2ab05a0..9de9e749612a --date=short --no-merges --format='%ad %ae %s' 2019-10-31 sanikak@chromium.org auto_updater: Restructuring Transfer Abstract Base Class Created with: gclient setdep -r src/third_party/chromite@9de9e749612a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Id778285b5f3d4c652ece02e1366103c2e9ca03ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892065Reviewed-by:
-
Sigurd Schneider authored
This CL also adds more tests to test not only per block, but also per function coverage. This CL effectively reverts the commit: [devtools] Disable tests that (implicitly) test per-block coverage This reverts commit 495e3645. crrev.com/c/1879455 Bug: chromium:1004203, chromium:1009396 Change-Id: I99373bdd1aa4457b727cfac82c9186717a1d6134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883570Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 5f85f630. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" f701be68 "[css-pseudo] Restrict the properties allowed in ::marker" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I6a9a0cc4c366888607f99899398aac4f22e07491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891552Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711167}
-
Yang Guo authored
Bug: 1011259 Change-Id: I97cb5b2956e2f847a534356ab66bc5b02cac27e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881552 Auto-Submit: Yang Guo <yangguo@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#711166}
-
Miyoung Shin authored
This CL converts TextSuggestionHost mojom interface client in blink to use BrowserInterfaceBroker. Since TextSuggestionHostAndroid life cycle is managed by RenderWidgetHostConnector, this CL gets its object from RenderWidgetHostViewAndroid to register its binder. Bug: 936482 Change-Id: Iccce03e58d9b79ccc8a5f8c011b8ca58e9ed41ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885866 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#711165}
-
Alexey Baskakov authored
This is a reland of 5a0adcbe Let's exclude Win platform for now. This is a useful finding which requires investigation. Original change's description: > WebApp: Check pixel at the center of the generated icon. > > We generate an icon placeholder using a letter with some solid > background color. > > Let the test check if letter_color is actually presented in the icon. > > This is a follow up test enhancement for the previous CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1888234 > > Bug: 1019102 > Change-Id: I10e196926dff78032dcd8f00e93e24715d1be913 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891816 > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711143} Bug: 1019102 Change-Id: I2d01c2a9f5eb94107a4dfc4fea041bdb18871fc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892651 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#711164}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/809ec77893be..9c82eb913f44 git log 809ec77893be..9c82eb913f44 --date=short --no-merges --format='%ad %ae %s' 2019-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 bb35bb4e5379..841b01678c49 (4 commits) Created with: gclient setdep -r src/third_party/skia@9c82eb913f44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:None Change-Id: I7d074be24a8e09a7cb5a826d3e65e60575efb3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892554Reviewed-by:
-
Yoshifumi Inoue authored
This patch introduces workaround to check invalid selection for avoiding crash in |ComputeRangeForSerialization()| called by |FrameSelection::SelectedText()|. When selection is none, both selection base and extent should be null. However, we have invalid selection, one of base and extent is null, by some reasons. Background: Bug: 1019152 Change-Id: I38717ede505eebb9c59229d5d2e14d75b50f24a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891819 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#711162}
-
Adam Rice authored
Log new histograms Blink.Compression.CompressionStream.Format and Blink.Compression.DecompressionStream.Format indicating the format that was passed to the constructor. Also consolidate format enums into a new one named "CompressionStream" and add a common LookupCompressionFormat() function to convert a string to an enum value. Also put back some copyright headers that had gone missing. Bug: 999091 Change-Id: If77623f7bee7fc78f0996dc10d1bac68c01bb77a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886532 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#711161}
-
Fergal Daly authored
R=rakina@chromium.org Change-Id: I0382e7ac771a43a1fb67a02cb8150118bc2ebf49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892632Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#711160}
-
Yura Yaroshevich authored
Bug: None Change-Id: I1d1483197acf0f3d61c8e747dd860e77d373bdda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888931Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com> Cr-Commit-Position: refs/heads/master@{#711159}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/56981910bb85..0a260d789fe9 git log 56981910bb85..0a260d789fe9 --date=short --no-merges --format='%ad %ae %s' 2019-10-30 rharrison@google.com Refactor file reading code into common utility method (#852) Created with: gclient setdep -r src/third_party/shaderc/src@0a260d789fe9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I78cc3f347958c59ce7e66166f375d53efe00bd01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892011Reviewed-by:
-
Marina Sakai authored
This CL removes macro-generated functions for private properties of CustomElement and replaces them with the new GetSymbol function, which uses an instance of V8PrivateProperty::SymbolKey as a key. Bug: 715418 Change-Id: I0b1a28d2c28a89c6d2b163f1ff2c04c017dc311c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885867Reviewed-by:
-
Joel Hockey authored
Created a new class CrostiniStartupStatus which shows a progress bar and spinner, and adds color and emojis. Full status is shown when the terminal starts and the container is not running. Otherwise no status is shown if the container is already running. TBR=benwells@chromium.org Bug: 1016680 Change-Id: I726d9d721937f74a40bba646339a3e9fd97e5a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888239 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#711156}
-
Mikhail Atuchin authored
If SW was restarted and the same process could be used. Update UIThreadWorkerResponseCallbackWrapper to not store worker_thread_id in it and instead use the correct worker_thread_id per callback returned via CreateCallback. Change-Id: I5caead02f2d45fbac967b9e5d42e0e1ef5d970fc Bug: 1019677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879258 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Auto-Submit: Mikhail Atuchin <atuchin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#711155}
-
Findit authored
This reverts commit 5a0adcbe. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 711143 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzVhMGFkY2JlOGYxZGE2OTlmMDBhMDljODYzMjJhNTU4MDAyZjBhMDYM Sample Failed Build: https://ci.chromium.org/b/8898108792770719008 Sample Failed Step: unit_tests Original change's description: > WebApp: Check pixel at the center of the generated icon. > > We generate an icon placeholder using a letter with some solid > background color. > > Let the test check if letter_color is actually presented in the icon. > > This is a follow up test enhancement for the previous CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1888234 > > Bug: 1019102 > Change-Id: I10e196926dff78032dcd8f00e93e24715d1be913 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1891816 > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711143} Change-Id: I7e555cad166437e3d004e77526dad06656d2a2b9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1019102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892127 Cr-Commit-Position: refs/heads/master@{#711154}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/549325c87e9d..809ec77893be git log 549325c87e9d..809ec77893be --date=short --no-merges --format='%ad %ae %s' 2019-10-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e1cda3916cee..fda994c63075 (2 commits) Created with: gclient setdep -r src/third_party/skia@809ec77893be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: chromium:None Change-Id: I5357d10cd9312d49d4fb1b0455e0f7f817d75b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892066Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |LayoutInline::LinesVisualOverflowBoundingBox| to utilize |NGInlineCursor| instead of |NGPaintFragment| for prepration of migrating to |NFragmentItem|. This patch also gets rid of |InlineFragmentsIncludingCulledFor()| in |NGPaintFragment| because it is called only from |LinesVisualOverflowBoundingBox()|. Bug: 982194 Change-Id: Ic6a1fe3b63c810b09d93edd19786b19a6133979c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888623 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Greg Thompson authored
The ScopedTempDir must outlive anything that holds file(s) open within it; otherwise, it is unable to delete itself. BUG=546640 R=sky@chromium.org Change-Id: I38e4e947e48e1d2b6ac8d72c6bdd59264a2e8885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890435Reviewed-by:
-
Anand K. Mistry authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/8014da0ebf8c..fc6c45f78316 $ git log 8014da0eb..fc6c45f78 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 amistry system_api: Add D-Bus constants for smbfs IPC bootstrap service 2019-10-24 bgeffon system_api: debugd: add missing SwapSetParameter constant 2019-09-30 louiscollard system_api: Add WebAuthn DBus Interface Protos Created with: roll-dep src/third_party/cros_system_api Bug: 939235 Change-Id: I7a47cee9903d15ac2abeb70883a77a0ea063c55f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890398 Auto-Submit: Anand Mistry <amistry@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#711150}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6276f9ca394..26f97a5e96ce Created with: gclient setdep -r src-internal@26f97a5e96ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I0523245ef94791e5dd94f6879bb71282794431b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892064Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#711149}
-
Hirokazu Honda authored
At V4L2VEA::Destroy(), encoder thread process all the pending tasks. If PumpBitstreamBuffers() is in the pending tasks, Enqueue() is posted and processed after DestroyTask(). That leads |input_queue_| and |output_queue_| are nullptr and causes SIGSEGV. This fixes the issue by posting tasks to encoder_thread_.task_runner() with WeakPtr of this. This makes V4L2VEA not execute any tasks posted to the task runner after DestroyTask() because the WeakPtr is invalidated in DestroyTask(). Bug: 1019437 Test: VEA unittest on guado with dcheck_always_on=true Change-Id: Ie2e43d1dd9c74114cbd0d2b51e260213b60136e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890462 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#711148}
-
Alice Boxhall authored
TBR=dtapuska@chromium.org Bug: 1020036 Change-Id: I5add7fa7b57e7ace63e84599ca3b120a71a933a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890463Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#711147}
-
Tsuyoshi Horo authored
This class will be used to read partial body data of a web bundle response from server. Bug: 1018640 Change-Id: Ib945b9152527be2dfd2fc43dc1e6ef8fcc09b12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886271Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#711146}
-
Gauthier Ambard authored
This CL create the EG2 target for Showcase and also convert the Content Suggestions TestCase. Change-Id: Iee84c298746b1a8da8d455b5214ea61eb5e0ea6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873750 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#711145}
-
