- 24 Jul, 2018 40 commits
-
-
Dmitry Gozman authored
Only renderer-inititated navigations go through DecidePolicyForNavigation now, so there should be no |pending_navigation_params_| or |extra_data|. This patch removes previous CHECKs and refactors code assuming there is no extra_data and pending_navigation_params_. Bug: 789577 Change-Id: I8ac67b5735e2f4b8976347df593877e0b1d61292 Reviewed-on: https://chromium-review.googlesource.com/1139024 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#577612}
-
Mark Pearson authored
This is important for desktop, as >1% of events emitted are hitting the max. By my estimates from looking at the distribution, it's probably safe to change the max to more like 6-10 hours to have fewer than 1% of emits on desktop in the overflow bucket. I decided to use one day as the max simply because it will make it easier to identify possible issues in the future with this metric. (E.g., we should not see two emits to the overflow bucket on a single day, otherwise something is wrong.) While at it, revise Session.TotalDuration description to explain how it changed in M68. BUG=856467 Change-Id: If0fcead52a15af24899618448b9c72bb87fb3e2b Reviewed-on: https://chromium-review.googlesource.com/1147210Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#577611}
-
Daniel Nicoara authored
DRM legacy is never used with overlays due to a lack of synchronization during page flip. Remove the complexity behing trying to page flip overlays on legacy. Also move tests that deal with overlays to use atomic configuration. BUG=822853 TEST=Ran unittests TEST=Ran chrome on Samus to validate legacy path still works TEST=Ran chrome on Eve to ensure atomic path hasn't regressed Change-Id: Ibc82aafd367c8d12106d3a0e835a3b4b38e0161a Reviewed-on: https://chromium-review.googlesource.com/1120692Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#577610}
-
Xiyuan Xia authored
Lock screen via SessionController so that it also works on dev box. Bug: 745006 Change-Id: Ic269926063741be5d876dcbc9188eee7da12604f Reviewed-on: https://chromium-review.googlesource.com/1148654 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#577609}
-
Anna Malova authored
Bug: 849861 Change-Id: Ia09b1c41f7a631502e14cf29509d6908d8eb7eac Reviewed-on: https://chromium-review.googlesource.com/1092747 Commit-Queue: Anna Malova <amalova@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#577608}
-
Daniel Nicoara authored
Video overlays on the Cast platform follow a special path handled by the hardware via a separate API. The Cast overlay strategy was updated in 3737028e to accept the overlay rather than relying on the Ozone platform to make the decision. The logging was moved in OverlayStrategyUnderlayCast and VideoPlaneController. Bug: None Test: Compiled cast_shell Change-Id: Ide14380ad626d7bcd9ba00cb7f74daab292f2f80 Reviewed-on: https://chromium-review.googlesource.com/1134495Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#577607}
-
Andrey Kosyakov authored
Change-Id: Ibbcdcb6f036ee0ab185558bb437542f556658176 Reviewed-on: https://chromium-review.googlesource.com/1148644Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#577606}
-
Scott Chen authored
Bug: 855205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I424db425db97b90c7374e9bc8c3504d1dbb32b01 Reviewed-on: https://chromium-review.googlesource.com/1147086 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#577605}
-
Evan Stade authored
This avoids some recalculations (chances for bugs) in BrowserNonClientFrameViewAsh. The bounds are horizontally inverted (i.e. they are relative to the top right of the frame) to minimize the number of times they need to be updated when resizing the window and the likelihood of ephemeral inconsistencies. Also fix the registered type of kRestoreBoundsOverrideKey. Since it was registered as a primitive, the address itself would get copied across processes. Bug: 854704 Change-Id: Iedd4eb4dfb2172f7a9ba66bbc542db33633aaf77 Reviewed-on: https://chromium-review.googlesource.com/1144058Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#577604}
-
Eric Karl authored
Currently, the OOP-R transfer cache has a 4MB cache on low-end. As the primary use of this cache turned out to be images, with only small additional colorspace and path caches, we should make this more closely match the discardable image cache's low-end size (512KB). Chosing 768KB to allow for small amounts of additional cache items. R=khushalsagar Bug: 866737 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2f04ce5bac3d2d94bb73bfd877169947d7aae64d Reviewed-on: https://chromium-review.googlesource.com/1147759Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#577603}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ca2b32c84463..d269b0e87d1e git log ca2b32c84463..d269b0e87d1e --date=short --no-merges --format='%ad %ae %s' 2018-07-24 anthonyalridge@google.com Initial files for plotting a simple line graph. Created with: gclient setdep -r src/third_party/catapult@d269b0e87d1e The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: I6d810da1512eea82945a307c7dc749e8b733e3b5 Reviewed-on: https://chromium-review.googlesource.com/1147958Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577602}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/aa5072898003..c9f1234b1982 git log aa5072898003..c9f1234b1982 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 tsepez@chromium.org Remove lpClass argument from FXJSE_RetrieveObjectBinding() Created with: gclient setdep -r src/third_party/pdfium@c9f1234b1982 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib4c1758146d0caf43dc203af81e48afeaf1da5e0 Reviewed-on: https://chromium-review.googlesource.com/1147957Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577601}
-
Chris Palmer authored
Bug: None Change-Id: I1d6d5f22162f7ea9bb54fb942a2c72183ad62071 Reviewed-on: https://chromium-review.googlesource.com/1148555 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
-
Theresa authored
Fix the tabswitcher overlay when both the EoC and incognito toolbar buttons are shown. Previously, when the incognito toggle button was shown in the toolbar button container the EoC button was incorrectly offset in the tabswitcher animation overlay. The two buttons are now contained in a single FrameLayout and the tabswitcher animation overlay draw logic is adjusted to properly translate to the experimental button. BUG=863819 Change-Id: I4a60f6f15b516f2a7933c3cde4e7a4a23831b0f7 Reviewed-on: https://chromium-review.googlesource.com/1148585Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#577599}
-
Mathieu Perreault authored
Bug: 866736 Change-Id: I2ead391e93eb64a4622ad94d75d34755e831c50f Reviewed-on: https://chromium-review.googlesource.com/1147756Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#577598}
-
Dan Elphick authored
V8TypeAsString was passing nullptr to the ConvertFromV8 function, so now we always pass the isolate. Also adds a DCHECK to ensure that V8ToString to ConvertFromV8 to ensure it's always passed a non-null Isolate. Bug: 866767 Change-Id: I715396f309a0c49e4c6bc6ade14b5f0aad8befec Reviewed-on: https://chromium-review.googlesource.com/1148209Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#577597}
-
Derek Cheng authored
It's been flaking heavily since https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Fuchsia%20x64/14471. TBR=sahel@chromium.org Bug: 866946 Change-Id: Iadbf5f330b9775d10dc5969d36f3fef8ad19a205 Reviewed-on: https://chromium-review.googlesource.com/1148597Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#577596}
-
Matt Menke authored
This is so that I can try increasing the media cache size in experiments without increasing Chrome's profile size (Except possibly for profiles that have never been used to play video). This is a relant of https://chromium-review.googlesource.com/c/chromium/src/+/1130162, with re-worked tests. Bug: 789657 Change-Id: I057e2e657572e21732610aefc468550e58fabf77 Reviewed-on: https://chromium-review.googlesource.com/1145137Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#577595}
-
Mounir Lamouri authored
When the internal object is destroyed, notify the controller so it can reset its internal state. It allows the user to close the window via any system/window manager UI. Bug: 863842 Change-Id: Ica84f4ffee2578658a60e0ae708a4e327d293077 Reviewed-on: https://chromium-review.googlesource.com/1147252Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#577594}
-
Philip Rogers authored
This patch stops culling out painting of svg images and svg shapes in the presence of transform styles. This was done for containers in crrev.com/575855 but needs to apply to all svg painting. SVGModelObjectPainter has been introduced so the cull rect optimization can be shared by shapes, images, and containers. A lengthy comment has been added in SVGModelObjectPainter::CullRectSkipsPainting describing why. While we're in the area and thinking about sharing code, the common outline painting code for has also been unified (SVGModelObjectPainter::PaintOutline). Bug: 865965, 862318 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5bb3d43ae089d4bd6c617957abf9c401dfb89e0c Reviewed-on: https://chromium-review.googlesource.com/1146147 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#577593}
-
Jan Krcal authored
This CL introduces new UMA histograms that record types of commits and updates processed by the sync engine. For each datatype there is a separate histogram so that the data can indicate bugs or regression in individual data types. Bug: 859859 Change-Id: Iaeaa7a657ebe7d9d6fbbd329152162c5acaadc01 Reviewed-on: https://chromium-review.googlesource.com/1131507 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#577592}
-
Mike Frysinger authored
Newer pylint warns when files have trailing blank lines. Trim them. Bug: 866772 Change-Id: Ib0f353d83dd0b86ac0b304c5704a9725867846b2 Reviewed-on: https://chromium-review.googlesource.com/1147719Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#577591}
-
Sidney San Martín authored
This is a reland of 94b94d9e Original change's description: > Simplify how the FSLP background rect is chosen. > > Before, the background size was reconstituted from the layer tree by > taking the union of of black and video layers. Now, the actual size is > plumbed through. > > Change-Id: I0cb643b350ef7e4fca06e3bfd419e24861a2e3c6 > Reviewed-on: https://chromium-review.googlesource.com/1142962 > Reviewed-by: ccameron <ccameron@chromium.org> > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576521} Change-Id: Idf5199a2aeb8be08b34e0594142c33b3ebed5b78 Reviewed-on: https://chromium-review.googlesource.com/1143960Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#577590}
-
Nicolas Ouellet-payeur authored
We were using a magic number for what is technically a platform-specific constant, which hurts readability & portability. Bug: 816389 Change-Id: I9be8d32d08f2e1f224e04a594269b1e1d73fbade Reviewed-on: https://chromium-review.googlesource.com/1146996Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#577589}
-
Victor Costan authored
Change-Id: Ib1ad967c2a331323b59f6bc40114f4a1a296eab4 Reviewed-on: https://chromium-review.googlesource.com/1148221 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#577588}
-
Tommy C. Li authored
This is a reland of 26399bca It simplifies the layer creation-and-destruction lifecycle, because that aspect seemed the most suspicious for causing crashes. Original change's description: > Match security chip visibility with focus ring > > Instantly hides or shows the IconLabelBubbleView separator when focus > rings are available to prevent showing the separator when a focus ring > overlaps it. > > Bug: chromium:865029 > Change-Id: I21a4c296c1da06b81dc91d66101d46e8ad52ad99 > Reviewed-on: https://chromium-review.googlesource.com/1142442 > Commit-Queue: Peter Boström <pbos@chromium.org> > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576358} Bug: chromium:865029 Change-Id: I7b5b597a6e6ec114faf4888b62da1f8751e64646 Reviewed-on: https://chromium-review.googlesource.com/1147361Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#577587}
-
Andreas Haas authored
This is the blink side CL to refactor WebAssembly.instantiateStreaming to make it spec compliant again. The design doc where the whole change is discussed is available in the tracking bug. The tracking bug also references prototype implementations of the whole change, which includes the changes in this CL. Note that most of the changes in this CL are copied from the existing implementation which uses the old API. I added a regression test but disable it until the V8 change landed. Bug: chromium:860637 Change-Id: Iba75dc4e187aad5891084e5e7dcc3f759e86f706 Reviewed-on: https://chromium-review.googlesource.com/1081947 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Jan Krcal authored
The problem came with CL https://chromium-review.googlesource.com/c/chromium/src/+/1129140. Bug: 866876 Change-Id: I00c6a6464b6cd8a879c0c7bb72c03bc221137043 Reviewed-on: https://chromium-review.googlesource.com/1148388Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#577585}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8afa86c63713..734b2a859784 git log 8afa86c63713..734b2a859784 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 ethannicholas@google.com Revert "removed SkSLLayoutLexer" 2018-07-24 herb@google.com Clean up bitmap path 2018-07-24 egdaniel@google.com Add new vulkan headers to third_party/vulkan. 2018-07-24 jvanverth@google.com Some more SkPolyUtils optimizations and clean up. 2018-07-24 ethannicholas@google.com removed SkSLLayoutLexer 2018-07-24 robertphillips@google.com Address fuzzer issue 2018-07-24 caryclark@skia.org fix bookmaker bot Created with: gclient setdep -r src/third_party/skia@734b2a859784 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866775 TBR=benjaminwagner@chromium.org Change-Id: I72064c967a9348238014399d855b79c164b6d713 Reviewed-on: https://chromium-review.googlesource.com/1147910Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577584}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3bf99f3a4746..43ee74f7bd72 git log 3bf99f3a4746..43ee74f7bd72 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 hjd@google.com Merge "Implement Track Registry" 2018-07-24 dproy@google.com Implement Track Registry Created with: gclient setdep -r src/third_party/perfetto@43ee74f7bd72 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:111540363 TBR=perfetto-bugs@google.com Change-Id: I01da6d5dea361c380caee36c73d1db87769c4968 Reviewed-on: https://chromium-review.googlesource.com/1147951 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577583}
-
Mike Frysinger authored
Newer pylint warns when files have trailing blank lines. Trim them. Bug: 866772 Change-Id: I20739c2086c1fac0a802c07e9f4baa5f8bbf4291 Reviewed-on: https://chromium-review.googlesource.com/1148000Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#577582}
-
Gabriel Charette authored
Revert "[TaskScheduler] Temporarily disable heartbeat latency metrics on Android to bisect power regression" This reverts commit 548db201. Reason for revert: regression had recovered on its own and this CL doesn't seem to help further : https://chromeperf.appspot.com/group_report?sid=3b04a394179538536eb72ebc4c7a33913ff5dcc85145d95666f5aea61823d770 Original change's description: > [TaskScheduler] Temporarily disable heartbeat latency metrics on Android to bisect power regression > > R=fdoray@chromium.org > > Bug: 848255 > Change-Id: Ic47d338fb15e0bf3579ecd9d1acca67099c6d570 > Reviewed-on: https://chromium-review.googlesource.com/1137849 > Reviewed-by: Robert Liao <robliao@chromium.org> > Commit-Queue: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576158} TBR=gab@chromium.org,robliao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 848255 Change-Id: Ie402a1ec2381f296863522bcf9ba7c387648df6d Reviewed-on: https://chromium-review.googlesource.com/1148481Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4ac42e42..696e3951 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6a08f97213fc5ccdb0205004dde2117e887b897 Reviewed-on: https://chromium-review.googlesource.com/1148549Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577580}
-
rbpotter authored
Make sure the promo close button is in the tab order, and shows the correct image when focused with the keyboard. Bug: 866420 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id8054203f5917fc72f187c33a826d29817fd3b18 Reviewed-on: https://chromium-review.googlesource.com/1147254 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Mathieu Perreault authored
Web Store will have an icon now! Bug: 853349 Test: out/Default/ntp_render_browsertests Change-Id: I46182b509b08d2772cb2a439f60f0a3313e5cb81 Reviewed-on: https://chromium-review.googlesource.com/1147105Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#577578}
-
Dave Tapuska authored
gc_info_index was widen to be a size_t in some areas. Whereas the effective gc_index is restricted to be in the range 1 << 14. It is more appropriate to use a uint32_t to store this value as opposed to using a size_t. BUG=596846 Change-Id: I3eac5fadabe82bbadeb315b3c3d8f1d4cf5a62a3 Reviewed-on: https://chromium-review.googlesource.com/1145232Reviewed-by:
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/62e2a5e8c2cd..dad47a9531e4 git log 62e2a5e8c2cd..dad47a9531e4 --date=short --no-merges --format='%ad %ae %s' 2018-07-24 cmtice@google.com Enable CFI on peach_pit and kevin release builders. Created with: gclient setdep -r src/third_party/chromite@dad47a9531e4 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If51a517a4f3993b214629fcd9aacd654b976c07e Reviewed-on: https://chromium-review.googlesource.com/1147955Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#577576}
-
David 'Digit' Turner authored
This CL introduces a new Python script providing various functions to deal with symbolization of crash back traces, stack traces, and memory map sections, as they appear in logcat and tombstone files on Android. They also rely on the classes introduced by the previous CL at [1] - HostLibraryFind() is used to locate unstripped version of native libraries on the host, based on their device path as it appears in tombstones / logcat. - SymbolResolver, and its derived classes, are used to turn a library (path, offset) into a symbol info string. - MemoryMap is used to model the memory map as it appears in a tombstone file, which can be used to symbolize random addresses that appear in the stack. - BackTraceTranslator is used to parse and symbolize back traces as they appear in logcat and tombstones. - StackTranslator is used to parse and symbolize stacks as they appear in tombstones. BUG=755225 R=agrieve@chromium.org, jbudorick@chromium.org, pasko@chromium.org, lizeb@chromium.org [1] https://chromium-review.googlesource.com/c/chromium/src/+/1047211 Change-Id: Ie6d5e8ad395c8953fc6c88948a761ecd2fda8092 Reviewed-on: https://chromium-review.googlesource.com/1138323 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#577575}
-
Oksana Zhuravlova authored
Bug: 855308 Change-Id: I712a91bb7e344827e26cea38d92829871aee9b02 Reviewed-on: https://chromium-review.googlesource.com/1147660Reviewed-by:
-
Andrew Grieve authored
Bug: 855726 Change-Id: I451b9cc0d68982a9cf3deba0af3d7146e8beb14b Reviewed-on: https://chromium-review.googlesource.com/1114348Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#577573}
-
