- 22 Feb, 2019 1 commit
-
-
Sandra Sun authored
As specified in the spec, when the snap-area has scroll-snap-stop: always, we should not pass its snap position when scrolling with an intended direction. This patch implements this feature by adding another round of search for the IntendedEndAndDirectionStrategy. This second round searches for the snap position with scroll-snap-stop: always that's closest to the scroll's start position. It then compares with the result from the first round of search, which is the snap position closest to the scroll's target position. The comparison selects the area closest to the scroll's start position ensuring a an area with snap stop is never bypassed. Bug: 823998 Change-Id: Ic40f82263ced85f8a72c8f5a82d4fb76e403398f Reviewed-on: https://chromium-review.googlesource.com/c/1460875Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#634421}
-
- 21 Feb, 2019 39 commits
-
-
Kristi Park authored
This reverts commit 1f82384a. Reason for revert: SurfaceSynchronizationTest.ChildNotThrottledWhenParentBlocked1 failing on multiple builders Original change's description: > Fix deadlock due to child throttling > > A child should not be throttled if the parent is blocked on it. > Otherwise the parent is guaranteed to hit the deadline, causing jank. > > Bug: 933610 > Change-Id: Id4cc7bcf6d942a2413a63986e9f10377543fb089 > Reviewed-on: https://chromium-review.googlesource.com/c/1479427 > Reviewed-by: kylechar <kylechar@chromium.org> > Commit-Queue: Saman Sami <samans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634329} TBR=kylechar@chromium.org,samans@chromium.org Change-Id: I285c1fd9deaa65ae584df5ab67c17b747f8a5e25 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 933610,934536 Reviewed-on: https://chromium-review.googlesource.com/c/1481958Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#634420}
-
Sadrul Habib Chowdhury authored
Fix running smoke tests after changes in catapult: https://chromium-review.googlesource.com/c/catapult/+/1474597 After that change, it is necessary to update the target platforms for the browser from the benchmark's supported platforms. BUG=932409 Change-Id: I7cddec057d987e342890d180485f54f927c61f7a Reviewed-on: https://chromium-review.googlesource.com/c/1481742 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#634419}
-
Michael Lippautz authored
GetExecutionContext is used for iterating roots during unified heap. Ternary operator results in using a copy constructor which invokes the write barrier, effectively making the object strong. Bug: 928781,843903 Change-Id: Ie6a4cb52a01ac347d6654c760601f254cdc48d65 Reviewed-on: https://chromium-review.googlesource.com/c/1480006 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#634418}
-
Greg Kerr authored
This adds XPC services to the GPU sandbox profile: - com.apple.coremedia.videodecoder - com.apple.coremedia.videoencoder - *apple-extension-service* Bug: 915934 Change-Id: Ibdbf903497af00af4a0b241e65b49cc646b10937 Reviewed-on: https://chromium-review.googlesource.com/c/1481903Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#634417}
-
Yann Dago authored
Bug: 934021 Change-Id: Ia514689aeb8ded0108150841fb5ac55f766d5e57 Reviewed-on: https://chromium-review.googlesource.com/c/1479937 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#634416}
-
Kyle Williams authored
This CL allows the Flare touch device to be recognized as a primary touch device on during the OOBE screen, by white-listing it for OOBE use and blacklisting additional unused interfaces. Bug: b/124839645 Test: manually Signed-off-by:
Kyle Williams <kdgwill@chromium.org> Change-Id: I5f088c27b43eb2a3a3efb69c2ea2b4bb42800b81 Reviewed-on: https://chromium-review.googlesource.com/c/1479635Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#634415}
-
Yi Gu authored
Currently AnimationWorkletProxyClient only mutates the stateful global scope. This patch adds the support of mutating both global scopes with appropriate predicates. Bug: 914918 Change-Id: I0a204f4857ed866511eab2bf03d4f2189a1428dc Reviewed-on: https://chromium-review.googlesource.com/c/1474685 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#634414}
-
Robert Sesek authored
It's created on the IO thread, and the FdWatchController it creates should be deleted on the IO thread as well. Bug: 932175 Change-Id: Icaa2af08846e33de94dacf31f03d64cd7496c4d0 Reviewed-on: https://chromium-review.googlesource.com/c/1481474Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#634413}
-
James Lissiak authored
- Test that both DomContentLoaded and Load events fire correctly on page navigations Change-Id: I4c2e04b49ca76c31e1202584eaa63aa1c57c2696 Reviewed-on: https://chromium-review.googlesource.com/c/1479639Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: James Lissiak <jalissia@microsoft.com> Cr-Commit-Position: refs/heads/master@{#634412}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/84d35339f3bf..4022be40d9f1 git log 84d35339f3bf..4022be40d9f1 --date=short --no-merges --format='%ad %ae %s' 2019-02-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@4022be40d9f1 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Icf4ce1e879fed3e9af826143b19e4d043d3bac6c Reviewed-on: https://chromium-review.googlesource.com/c/1481871Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634411}
-
Céline O'Neil authored
Tests the SubmitCompositorFrame IPC interface of CompositorFrameSink by submitting a CompositorFrame constructed from a fuzzed protobuf. This frame is embedded in a CompositorFrame displayed by a mock browser. The CompositorFrame contains exactly one DrawQuad of the type SolidColorDrawQuad. This CL sets up the framework needed for further, more thorough fuzzing of the SubmitCompositorFrame interface, and isn't expected to have thorough coverage just yet. R=kylechar Bug: 923088 Change-Id: Ie6ecc0526c6e524c8e1e54e76fa32ec7dd410211 Reviewed-on: https://chromium-review.googlesource.com/c/1456864 Commit-Queue: Céline O'Neil <celineo@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#634410}
-
Ethan Jimenez authored
1. Completing `ISelectionProvider` methods `GetSelection`, which was previously partially implemented, and `get_IsSelectionRequired`. 2. Adding unit tests for the `ISelectionProvider` methods. 3. Removing unnecessary `AddRef` call before `SafeArrayPutElement` in `AXPlatformNodeWin::CreateUIAElementsArrayFromIdVector`. Bug: 847971 Change-Id: Ic2d2b458812baffeb2777a259fe10369670b0f92 Reviewed-on: https://chromium-review.googlesource.com/c/1479852 Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#634409}
-
Mike Wittman authored
Changes ModuleCache::Module from a value type to a reference type, with ModuleCache maintaining ownership of the Module. ModuleCache needs to own its Modules to properly support Windows, which reference counts its modules. ModuleCache is retained as a struct to minimize the size of this change, but will be changed to a class in a later CL. Bug: 931418 Change-Id: Ifa5bb0e763de14d91c1663ba01aeb3bab09447be Reviewed-on: https://chromium-review.googlesource.com/c/1477817Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#634408}
-
Aga Wronska authored
Bug: 934303 Test: ParentAccessViewTest Change-Id: Ia073de5cd123a3babbd058d3326a02a95e582d57 Reviewed-on: https://chromium-review.googlesource.com/c/1481577Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#634407}
-
Charlie Harrison authored
Bug: 926235 Change-Id: I7af92cb206981a1585c601633431e57f3266b50c Reviewed-on: https://chromium-review.googlesource.com/c/1481910 Auto-Submit: Charlie Harrison <csharrison@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#634406}
-
Yue Li authored
No longer need to wait for Assistant restart when toggle Hotword. Bug: b/123363474 Test: Manual Test Change-Id: Ibc89f44e52c4dab2b18a95cf53c2d7d8b4b1109b Reviewed-on: https://chromium-review.googlesource.com/c/1480815Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#634405}
-
Yi Gu authored
wpt/web-animations/timing-model/animations/set-the-animation-start-time.html was renamed in [1] but the name change was not reflected elsewhere. In addition, the expectation file for the test on Android seems unnecessary. [1] https://chromium.googlesource.com/chromium/src/+/bf6c3b061813db88ca12c59690cece60d0b672f7 Change-Id: I6a640c3d56203380ad19ca3b1bb1278cc6971bd8 Reviewed-on: https://chromium-review.googlesource.com/c/1477938Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#634404}
-
tby authored
The previous CL [0], implementing an adaptive ranker for search results, was reverted due to an uninitialised member in a test class. This CL fixes the error, and is identical except for the following diff: --- a/chrome/browser/ui/app_list/search/tests/mixer_unittest.cc +++ b/chrome/browser/ui/app_list/search/tests/mixer_unittest.cc @@ -68,6 +68,7 @@ class TestSearchProvider : public SearchProvider { : prefix_(prefix), count_(0), bad_relevance_range_(false), + small_relevance_range_(false), display_type_(ash::SearchResultDisplayType::kList [0] https://chromium-review.googlesource.com/c/chromium/src/+/1474966 Bug: 931149 Change-Id: Id079f664b2eba64f88108b8133be7bf1f8087d2d Reviewed-on: https://chromium-review.googlesource.com/c/1481138Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#634403}
-
Aga Wronska authored
Ignore 'Parent access' shelf button click if parent access view is already shown. Bug: 934301 Test: Manually Change-Id: I42d8e032f4f076ee352393aced342e153222e005 Reviewed-on: https://chromium-review.googlesource.com/c/1481572 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#634402}
-
Mitsuru Oshima authored
For Exo windows, the initial gesture target is set to an ExoSurface. If the client (Android) requests a drag-move or drag-resize, then Exo calls AttemptToStartDrag, and provides the ExoShellSurface as the target. Then, ToplevelWindowEventHandler will transfer the events to the new target. However, WmToplevelWindowEventHandler won't update the gesture target. This means all events will be ignored later in WmToplevelWindowEventHandler::OnGestureEvent because it believes they are events for the client which need to not be delivered. Bug: b/124026845 Test: Drag-to-move via touch of a PIP window no longer lags. Change-Id: I6e7bca73561fdab1bf357dd86de2a5d4e9a4bddc Reviewed-on: https://chromium-review.googlesource.com/c/1477452Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#634401}
-
Jia authored
This method's default impl is to return -1. The subclasses overriding it are expected to return a meaningful +ve value. Bug: 931149 Change-Id: I6c91e8d92b5c3bfca8a4ccd3a2223d928fe13eb7 Reviewed-on: https://chromium-review.googlesource.com/c/1481277 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#634400}
-
mrefaat authored
Also while at it remove some of tab.webState calls and tabModel usages and use WebStateList instead. Bug: 914975, 931852, 914967 Change-Id: I9486994950847c157ed0b5d5177ad62e5da0c16b Reviewed-on: https://chromium-review.googlesource.com/c/1481028 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#634399}
-
CJ DiMeglio authored
This CL gives the MenuItem role to each othe overflow menu entries. This makes it so that positioning information will be readback by ChromeVox. Bug: 836997 Change-Id: I8e4fad3f9b31d579728c306516e09d887c1390f4 Reviewed-on: https://chromium-review.googlesource.com/c/1392283Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#634398}
-
Maggie Cai authored
Currently the favicon shown for etld+1 is simply using the favicon of the first origin. This CL implement heuristic for finding a good favicon. The rules are: 1. Find the origin with format "www.etld+1". 2. If there is no origin with format "www.etld+1", find the origin with largest storage, and use the number of cookies as tie breaker. BUG=930626,835712 Change-Id: I374e079568020a7a6df6ec80e65736c29eead9ba Reviewed-on: https://chromium-review.googlesource.com/c/1475561Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#634397}
-
Denis Kuznetsov authored
Also changed a way the MockEnterpiseEnrollmentHelper is created/configured. Bug: 912704 Change-Id: I66756c147c8e25dcf9655da92a89d7c6b124b74e Reviewed-on: https://chromium-review.googlesource.com/c/1477235 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#634396}
-
Antonio Gomes authored
BUG=891908 Change-Id: I16d05f7adfb60be24d53942dc0a63a6189a2a806 Reviewed-on: https://chromium-review.googlesource.com/c/1481473 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#634395}
-
Michael Crouse authored
Add rounded SiteEngagementScore for the navigation URL to the UKM. The SiteEngagementScore is obtained in from the SiteEngagementService, rounded up/down to nearest multiple of 10, and added to the UKM during TimingMetricsReporting. Needed to understand how first contentful paint (FCP) varies with SiteEngagementScore, and if it’s possible to predict slow page loads using SiteEngagementScore. Bug: 930999 Change-Id: I0f4231d4b9e41da972b2c5b8ed7abff11064ce11 Reviewed-on: https://chromium-review.googlesource.com/c/1471334Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#634394}
-
Oriol Brufau authored
When writing text inside a scroll container with fixed height, the cursor eventually moves outside the visible area. At that point it's scrolled back into view. Before this patch it was moved as much as possible into the center of the visible area, the problem with this was when writing text at the end of a container with bottom padding. When the cursor was overflowing the content area but still in the padding area, it was still into view, so no scroll happened. But after leaving the padding area, the scrollbar was scrolled to the bottom, moving the cursor into the content area. This behavior seemed inconsistent, giving the impression that sometimes it was trying to keep the cursor inside the content area and sometimes not caring that the cursor was in the padding area. After this patch, a hidden cursor is only scrolled into the nearest edge of the visible area. This aligns Chromium with Firefox and Edge. BUG=931838 TEST=editing/input/caret-at-the-edge-of-contenteditable.html TEST=editing/input/caret-at-the-edge-of-input.html TEST=editing/input/reveal-caret-of-multiline-contenteditable.html TEST=editing/input/reveal-caret-of-multiline-input.html TEST=editing/input/reveal-contenteditable-on-input-vertically.html TEST=editing/input/reveal-edit-on-input-vertically.html TEST=fast/forms/text/input-text-scroll-left-on-blur.html Change-Id: I584e9c85d3eabd4ace1b694906cd6f7649c58443 Reviewed-on: https://chromium-review.googlesource.com/c/1477255Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#634393}
-
Andrew Luo authored
Bug: 933946 Change-Id: I85395a7064b26d6bc0598272e1e57edd04170d61 Reviewed-on: https://chromium-review.googlesource.com/c/1480391Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#634392}
-
Henrique Ferreiro authored
Replace uses of SnapContainerData from third_party/blink/renderer/platform/scroll_snap_data.h with the unwrapped type from cc/input/scroll_snap_data.h. This is part of a series of CLs to remove platform/scroll. Bug: 922111 Change-Id: Id900c7fc7cbe1a50e16fdffcd0ff78e031548ba1 Reviewed-on: https://chromium-review.googlesource.com/c/1479994 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#634391}
-
Julie Jeongeun Kim authored
This CL moves SharedBufferChunkReader and SerializedResource to platform/mhtml. Bug: 933887 Change-Id: I41a4077c29186f26037beab146ee27f2d7301bc1 Reviewed-on: https://chromium-review.googlesource.com/c/1481274Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#634390}
-
Julie Jeongeun Kim authored
This CL moves blink::DragImage to core/page without ResizeAndOrientImage. The API is moved to platform/graphics/image.{h,cc}. It also cleans up including unused headers. Bug: 933888 Change-Id: I886efd42e7b6b76015a5e3b52d38be8ba585199b Reviewed-on: https://chromium-review.googlesource.com/c/1481272Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#634389}
-
James Cook authored
aura::TopLevelAllocator::NotifyServerOfLocalSurfaceId() needs to pass bounds in DIPs, not pixels. Also clarify dips vs. pixels in some function parameters and member variables. TBR=tsepez@chromium.org Bug: 934180 Change-Id: I28b0331f9d430e195f37b9a73061fc831b40f44f Reviewed-on: https://chromium-review.googlesource.com/c/1479889Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#634388}
-
Robert Liao authored
BUG=927180 Change-Id: I1617453d53c9fda86db53ed5672e740ab4fb58af Reviewed-on: https://chromium-review.googlesource.com/c/1481850 Auto-Submit: Robert Liao <robliao@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#634387}
-
Henrique Ferreiro authored
Replace uses of SnapAreaData from third_party/blink/renderer/platform/scroll_snap_data.h with the unwrapped type from cc/input/scroll_snap_data.h. This is part of a series of CLs to remove platform/scroll. Bug: 922111 Change-Id: Id93a2f8fdb8c15dceb94d5d4d3d7c3ffdfb04256 Reviewed-on: https://chromium-review.googlesource.com/c/1480459 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#634386}
-
Eric Stevenson authored
These were pulled in because trichrome uses monochrome templates. Since Trichrome still shares the same native library logic with monochrome it makes sense to continue using monochrome templates, but using a variable |is_trichrome| to differentiate trichrome from monochrome. This CL removes Java deps, some Java resource deps, and webview's locale pak files from TrichromeChrome.apk. Validated CL changes by: * Building the 3 trichrome apks and their downstream variants * Installing/launching TrichromeChrome.apk * Manually inspecting the .build_config and "unzip -l" changes | old (c)| new (c)| diff (c)| total| 24.8 MiB| 23.6 MiB| -1.2 MiB| dex| 6.8 MiB| 6.4 MiB| -392.1 KiB| arsc| 4.9 MiB| 4.8 MiB| -101.8 KiB| xml| 344.9 KiB| 344.9 KiB| -6 B| res| 912.3 KiB| 908.2 KiB| -4.1 KiB| native| 254.6 KiB| 254.6 KiB| +0 B| asset| 11.1 MiB| 10.4 MiB| -698.0 KiB| misc| 145.3 KiB| 142.4 KiB| -2.9 KiB| Bug: 932253 Change-Id: Iedb427aa5ec05ad3bc905ac61b23f615349d579e Reviewed-on: https://chromium-review.googlesource.com/c/1481019 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#634385}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 514c84e0. With Chromium commits locally applied on WPT: 14c11107 "Implement `Sec-CH-Lang`" df760ab0 "Don't skip past auto-height flexboxes in quirks mode." cd40220a "Fix as=fetch preload where preload is used before response arrives" 1d89521e "[LayoutNG] Force relayout when constraint spaces change." c326c82a "Surface dtlsTransport via state-surfacer" 98e7141b "Fix 2_tracks, 3_tracks wpt/webvtt tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I462cc03771c9186999d480e8e4e98d4acff89631 Reviewed-on: https://chromium-review.googlesource.com/c/1481586Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634384}
-
Daniel Bratell authored
In some build experiments, the compiler emitted an object assignment of StdStringCanonOutput which did not link because the operator= was not exported from the url.dll in component builds. This makes the class explicitly not copyable and removes the copy to avoid that kind of (hard to debug) problems. Change-Id: I92988b5799e4229d1fb0379f9897727c1bac20de Reviewed-on: https://chromium-review.googlesource.com/c/1477602Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#634383}
-
Henrique Ferreiro authored
Replace uses of ScrollSnapAlign from third_party/blink/renderer/platform/scroll_snap_data.h with the unwrapped type from cc/input/scroll_snap_data.h. This is part of a series of CLs to remove platform/scroll. Bug: 922111 Change-Id: If90f64169884a54f6ee29545a157a03e23db8900 Reviewed-on: https://chromium-review.googlesource.com/c/1480514 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#634382}
-