- 15 Oct, 2019 40 commits
-
-
Caroline Rising authored
Update an extension's position when it moves past the midway point between extensions. Bug: 1008538 Change-Id: I302bc0f4b50bb37999ce5c164a171ccd2eeeee39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863509Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#706163}
-
Peter Kasting authored
I couldn't actually get this to trigger in practice; on trunk the button seems to snap between widths. That also seems like reasonable behavior and results in noticeably simpler code. Finally, when converting the result view to use layout managers, I couldn't find a way to produce an animation-based behavior anyway. Bug: none Change-Id: I4d2750b675de4bda8758eac2f530ee8b1467dd0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854533 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706162}
-
Parastoo Geranmayeh authored
SitePerProcessNonIntegerScaleFactorHitTestBrowserTest ::NestedSurfaceHitTestTest is flaky. TBR=kenrb@chromium.org Bug: 1014602 Change-Id: If7c69bcf4a50c8e7b2646ec8826ea0115018cca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862663 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#706161}
-
Samuel Huang authored
Previously, class DevUiModuleProvider consists of static functions {ModuleInstalled(), InstallModule(), LoadModule} that are called directly. Unfortunately, these cannot be mocked for testing. This CL makes DevUiModuleProvider a singleton class that's accessed via GetInstance(). SetTestInstance() is added to allow a test to override DevUiModuleProvider functions, and inject a test instance that replaces the original singleton obtained from GetInstance(). Bug: 927131 TBR: yfriedman@chromium.org Change-Id: Ifee6899ebf67be17ad2ed15103b9c7b6d8e322a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863553Reviewed-by:Samuel Huang <huangs@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#706160}
-
Maksim Moskvitin authored
IMPLICIT_PASSPHRASE treated as a passphrase type, which requires user-provided passphrase for decryption. We support it because we still have some users with very old Nigori's. This CL doesn't introduce support for keystore migration, setting up or changing implicit passphrase. Bug: 922900 Change-Id: I3cb6e0119f141ab1bd4fce2cc1db7c70f2d2cc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860415 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#706159}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4ccba5fc7b22..0fba1fdff325 git log 4ccba5fc7b22..0fba1fdff325 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 vapier@chromium.org repo_util: use utf-8 output 2019-10-15 vapier@chromium.org paygen: import test modules from autotest Created with: gclient setdep -r src/third_party/chromite@0fba1fdff325 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I0ce972d6ad9555a1bd088c4d62550315e5b23f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863114Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706158}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 74cefac7. With Chromium commits locally applied on WPT: d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/IndexedDB kojii@chromium.org: external/wpt/css/css-writing-modes NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I4ca1df0c61151ee7b83864569dd3d340c0cf1945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863431Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706157}
-
Rob Schonberger authored
This can be tested and enabled in conjunction with other features and experiments for users in the future. Default behavior is completely unchanged, and unit test thoroughly tests new behavior. Bug: 1009290 Change-Id: I57076270b2272831376c9b5ee787d9eecfa8d28f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861914Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#706156}
-
Sammie Quon authored
It's possible to get to this state by scrolling a bit, then rotating a couple times. Not entirely reproducible (depends on num windows and how much scrolling and display size), but added a test case which repros 100% without this fix. Test: Added test Bug: 1013224 Change-Id: I15a4bcdcda83ccac4346727342108b0c295fd151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853130 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#706155}
-
Lei Zhang authored
Make it more obvious "rm -rf" is happening. Bug: 1009837 Change-Id: I3b39b4ecc7625ad38c93fac34be7fa233520fb4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861502Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#706154}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6841d25d45ac..af0aa0977370 git log 6841d25d45ac..af0aa0977370 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 88a7a882..1c1107d4 (705863:705985) 2019-10-15 danilchap@webrtc.org Replace RtpPacketizerH264::Fragment struct with rtc::ArrayView 2019-10-15 orphis@webrtc.org Update the header extensions capabilities with mid, rid and rrid 2019-10-15 srte@webrtc.org Cleanup: Propagating BitrateAllocationUpdate to RtpVideoSender Created with: gclient setdep -r src/third_party/webrtc@af0aa0977370 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:1007894 Change-Id: Icb019d008ff5d03679698e4ff2a5a2a525d2af71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863113Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/65c6e8ed..f18342d8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6991932167a6330e6c53133351f78cccbc511c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863433Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706152}
-
Patti authored
Add a new flag HelpApp (--enable-features=HelpApp) for the new Chrome OS help app, disabled by default. If this flag is turned on, the old help app (called the Genius app) will not be shown in the launcher. BUG=1012578 Change-Id: I093bb905b856aeb9c8a4c629cd5909d53162ac90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855538Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Patti <patricialor@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706151}
-
Oystein Eftevaag authored
These were previously disabled for webview, but are flaky for non-webview android as well. TBR=crouleau@chromium.org NOTRY=true Bug: 1013618 Change-Id: Ia08c92b4563e93c63859c8d3ffc0001d3af1eebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863126Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#706150}
-
Michael Ludwig authored
This does not actually change the current logic of what DrawQuads are drawn directly by skia_renderer or gl_renderer. It just makes it possible at the direct_renderer level for subclasses to have more flexibility in how they bypass RenderPasses. Bug: 1013735 Change-Id: I4a82155b57ce58a40ca68ccc2b05875e84d625e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860103Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Michael Ludwig <michaelludwig@google.com> Cr-Commit-Position: refs/heads/master@{#706149}
-
Vladislav Kaznacheev authored
When an app is being dragged from app list to shelf, a new shelf item is created and made hidden by setting its size to (0,0). It is supposed to stay at this size until the drag is complete. However, if a drag started very soon after some other shelf manipulation (e.g. drag leaving the shelf and re-entering quickly), it is possible for AnimateToIdealBounds to be called asynchronously. The hidden item's bounds will be animated to full size, resulting in a visible icon. This CL makes AnimateToIdealBounds ignore shelf items with (0,0) size. Bug: 985631 Test: manual Change-Id: Ieb23beb6ecf635ae60613f5f6217219f7963999b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862507 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#706148}
-
Matt Reynolds authored
In an earlier CL, new metrics were added for navigator.getGamepads when called from a cross-origin subframe or an insecure context (WebFeature::kGetGamepadsFromCrossOriginSubFrame and WebFeature::kGetGamepadsFromInsecureContext). This CL enables UKM for the general case of calling navigator.getGamepads from any context (WebFeature::kGetGamepads). BUG=1014608 Change-Id: I276cc1fd23525e4e7ddeb1f3b7f5ea1f48fc387b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863354Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#706147}
-
Doug Arnett authored
For the preview types: LitePageServerPreviews, DeferAllScript, ResourceLoadingHints, and NoScript, this adds a 2nd Feature for each one that will be used to control whether the preview is enabled when a new EligibleForUserConsistentStudy Feature is enabled. This is meant to be used to allow a user-consistent experiment for a preview to be run without conflict with other preview experiments (notably CoinFlip ones) that are controlled by the Previews.gcl config. For example, when EligibleForUserConsistentStudy is enabled (targeting the that for the Default group of the Previews field trial), whether to allow LitePageServerPreviews on whether a new base::Feature's "LightPageServerPreviewsUserConsistentStudy" is enabled and then further whether the parameter "user_consistent_preview_enabled" is enabled or not. See also: https://docs.google.com/document/d/1Fj7KX_wKDIm3gwxaDMj_jhFDOJXzMJ6kYXWG-lDvLLw/edit?usp=sharing Bug: 1007523 Change-Id: Ia8c014566b2c0bda8d1488a482cf521f4dc7e362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823755Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#706146}
-
Kai Ninomiya authored
This reverts commit 9d6a01ba. Reason for revert: Breaking GPU tests on GPU FYI waterfall and on ANGLE's CQ. Bug: 1014659 Original change's description: > Add field trial testing config for BoostThreadPriorityOnLibraryLoadingAndBackgroundMode. > > This experiment enables: > - Use THREAD_MODE_BACKGROUND_BEGIN/END to set the priority of > background threads. This affects memory and IO priority in addition > to CPU priority. > - Increase thread priority to "normal" in scopes where background > threads load modules. > > The expectation is that this will improve responsiveness of Chrome > (input delay, first contentful paint), without regressing jank. > > We are adding the testing config in preparation for enabling this > via Finch in M79. > > Bug: 973868 > Change-Id: I467cae12503e3ad724b665f3aebdaeb94e1325c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835023 > Commit-Queue: Robert Kaplow <rkaplow@chromium.org> > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > Auto-Submit: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705960} TBR=fdoray@chromium.org,rkaplow@chromium.org Change-Id: I509cbe39c2d4f91859f5e8614d7d8f8d819d3a7d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 973868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862858Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#706145}
-
Oystein Eftevaag authored
TBR=croleau@chromium.org NOTRY=true Bug: 1014655 Change-Id: Ibf5e367a218502b2d46f8d4dac838355344c6f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862853 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
-
David Tseng authored
Bug: b:141606892 Change-Id: Ia67acf9d6218f5da33649561da4fed8a60298081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845234 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#706143}
-
Istiaque Ahmed authored
Update ExtensionsClient to use that constant. Also, fix tests using channel overrides to use the more specific channel: canary instead of trunk. This is done by providing an override channel class called ScopedExtensionAPIEnabledInServiceWorkersChannel. Bug: None Change-Id: I890a738c66522d4541e24c61761b82aa1bff1ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841932Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#706142}
-
Torne (Richard Coles) authored
Fetch shared library file data from the implementation package to construct the correct asset path when using a Trichrome APK. Change-Id: Id7bd259e5be182d6b13828235636d41b812ffdbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829867 Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#706141}
-
dpapad authored
Before r705637, these images were inlined with Grit's flattenhtml attribute. After that CL, flattenhtml was removed, but the images were not registered with the corresponding WebUIDataSource, resulting in a broken URL request for chrome://sync-confirmation/images/sync_confirmation_illustration.svg Fixing by individually registering those images with the WebUIDataSource. Fixes: 1014447 Change-Id: I198b99030f46fccc7dc38ad6d80a7a89da2a9ac3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863350 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#706140}
-
Min Qin authored
Today if a parallel request is interrupted, the download will get immediately interrupted if the request's slice is not recoverable. This is causing issues that a failed parallel request may block the download from auto resuming due to its interrupt reasons. And for poor networks, each request can contribute to download interruption, and causing the http handshake to start over and over again. This CL addresses the above issue by letting non-failed request to keep going until they finish their slice. Once a slice is completed, it will interrupt the download with a CONTENT_LENGTH_MISMATCH error if all other parallel requests have terminated, so that the download can be automatically resumed afterwards. BUG=1011427 Change-Id: Iee1a02e7b45f79b4e8383942405e9f09d29f6e92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850773 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#706139}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb6a1abe4567..c594e6269813 git log fb6a1abe4567..c594e6269813 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 egdaniel@google.com Plumb GrColorType through all ops/processors that sample textures. 2019-10-15 brianosman@google.com Add interactive demo to particle gallery Created with: gclient setdep -r src/third_party/skia@c594e6269813 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: Ia6c904246ab5898b0fd2c9f57948f0b0eb838a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863566Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/14df22429d27..43253cb0a391 Created with: gclient setdep -r src-internal@43253cb0a391 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:140584925 Change-Id: I2b4d525a3901463decfb843d5717bbf7e8da8f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863565Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706137}
-
Michael Ludwig authored
Pages like web_tests/compositing/overflow/nested-render-surfaces-with-rotation.html create RenderPasses (and SharedQuadStates) that have layer rects offset from (0, 0). This seems connected to the border width of the owning DOM element. Regardless, these edges are not clipped and DrawQuads should be anti-aliased if they line up with the non-zero edges. Bug: 1013735 Change-Id: Ib97e6f9a0f7f56f4926d1a209365d3c3f11a6e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860098Reviewed-by:
-
Vladimir Levin authored
This patch saves the unconstrained intrinsic box size during the block layout algorithm in order to use it for overflow calculation in the node. Since we can override the intrinsic size with css-content-size, we may cause scrollbars to appear. By using unconstrained size, we retain correct behavior in which scrollbars only depend on the child content, and not on content-size override. R=chrishtr@chromium.org, ikilpatrick@chromium.org Bug: 991096 Change-Id: I0d9cb270ee710b759f93202497f69bf72544f81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833074Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706135}
-
Frank Kastenholz authored
https://quiche.googlesource.com/quiche.git/+log/f76cf2ae5e7a..abb67699b6e2 $ git log f76cf2ae5..abb67699b --date=short --no-merges --format='%ad %ae %s' 2019-10-15 fkastenholz Remove unneeded "#ifdef undefined" code. 2019-10-15 wub Add quic_framer_process_data_packet_fuzzer, a fuzz test for QuicFramer::ProcessPacket where the packet has a valid public header, is decryptable, and contains random QUIC payload. 2019-10-14 dschinazi Verify receipt of connection_close in quic_client_interop 2019-10-14 renjietang Remove virtual keyword for unoverridden QuicSession::IsCryptoHandshakeConfirmed(). 2019-10-14 dschinazi Refactor interop result D in quic_client_interop_test 2019-10-14 dschinazi Add retry support to quic_client_interop_test 2019-10-14 dschinazi Allow passing URL to quic_client_interop_test 2019-10-14 renjietang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_active_streams_never_negative Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Idd25c7192f33c94da9b67a04f03b39706b9530b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862657 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#706134}
-
Daniel McArdle authored
Bug: 830786 Change-Id: I6f8318f871bbded0a7bc4787e921b6b190a5da77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847793 Auto-Submit: Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#706133}
-
Jimmy Gong authored
- This CL is in anticipation of the Show More feature to be implemented for Saved printers. - The behavior of CupsPrintersEntryList will soon have customized features for saved printers. - CupsSavedPrinters and CupsNearbyPrinters will now have their own list to manage. Bug: 993822 Test: end to end manual, browsertest Change-Id: I58d9f4a9920decbb5f4eab23505be52d962e90a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835703Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#706132}
-
Lukasz Anforowicz authored
Some CORB tests run in parallel, because they use `async_test`. See https://web-platform-tests.org/writing-tests/testharness-api.html#asynchronous-tests: "Keep in mind that other tests could start executing before an Asynchronous Test is finished." This CL fixes such tests, to make sure that they either migrate to `promise_test` [1] or avoid using shared/global state. [1] https://web-platform-tests.org/writing-tests/testharness-api.html#promise-tests says "Unlike Asynchronous Tests, Promise Tests don’t start running until after the previous Promise Test finishes. Under rare circumstances, the next test may begin to execute before the returned promise has settled. Use add_cleanup to register any necessary cleanup actions such as resetting global state that need to happen consistently before the next test starts." Bug: 1011410 Change-Id: Ib369e6cd07aed2daaf6347ae5d6f777a2c0835db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841898 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#706131}
-
Maksim Sisov authored
These tests have been stable and run for quite a long time. So, it's safe to remove the experiment now. Bug: 700309 Change-Id: Ic9138013913dfd841cbb9ffa23fc27d3e790bf84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862462Reviewed-by:
-
Maks Orlovich authored
The cookies used in the test don't explicitly specify SameSite attribute, so eventually they'll be interpreted as 1st-party only. Adjust the code in tests that queries them to delcare itself as 1st party so it can actually see them. Bug: 1006816 Change-Id: Ied26333b46fa76142580fbb0dabdcb0df25a08e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856887Reviewed-by:
-
Chris Dalton authored
Change-Id: Ib6a0f9829dfe781c9d66c9d62fb950f92b9a1c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860497Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
-
Daniel Hosseinian authored
Bug: 989978 Change-Id: I8b943250012cdc6e1a253905aa5dc8e65690ece6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856920Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#706127}
-
Drew Davenport authored
Only one ScopedFeatureList::InitXXX function should be called on a particular ScopedFeatureList instance. If any Init functions are called more than once, it will hit DCHECK(!init_called_) in ScopedFeatureList::InitWithFeaturesImpl. Refactor feature enabling so that the desired features are sent as a vector of features in one call to ScopedFeatureList::InitWithFeatures TEST=video_encode_accelerator_unittest does not hit DCHECK BUG=none Change-Id: I445ea51740b93361c771450e47cd31300ae13c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862257Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Drew Davenport <ddavenport@chromium.org> Cr-Commit-Position: refs/heads/master@{#706126}
-
Morten Stenshorne authored
It may be the wrong year to do this, but fixing 22 tests with such a tiny effort still seems worth it. :) Bug: 829028 Change-Id: I5e34fc18edcb063d125933aac9174ff08a5acc40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860421 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706125}
-
Alex Keng authored
This change updates the position of the slider ticks to be below the slider (overlapping the thumb by 1 pixel) and shortens the ticks by 2 pixels (from 6 to 4) Bug: 1014373 Change-Id: I498e8f76259f677378f6ec5af4780e74653c8a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860513 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#706124}
-
