- 10 Sep, 2020 40 commits
-
-
Kent Tamura authored
It has a circular dependency with platform/loader:loader. This CL adds allow_circular_includes_from to platform/loader:loader. This CL has no behavior changes. Bug: 800764 Change-Id: Ib511a3c8628e1e39b6c458cd51d0dd9a8598bd9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400588 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#805624}
-
Gang Wu authored
Bug:1043329 Change-Id: I82c109cc0ded499cbcb77e74026152844ac21136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387120Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805623}
-
Joel Hockey authored
Bug: b/154140429 Change-Id: I4cee76ea773233b5e01a00a6d198ac3e8aedf673 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400790 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#805622}
-
Kent Tamura authored
This CL changes the default visibility of "blink_platform_sources" template so that it is exposed to all of targets under renderer/platform/ including its sub-directories. This CL has no behavior changes. Bug: 800764 Change-Id: I046766a226b5e95917ca7ba8a89550db5dc9c219 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400788Reviewed-by:
-
Joel Hockey authored
Download for most URLs will already set WakeLock in ResourceDownloader, but for Drive downloads, and then for the post-download installation we want to set the WakeLock to avoid the devices sleeping. Bug: b/155345403 Change-Id: I62a1b6abdc25c0f90ec26df4d5152e7e07d5414d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398747Reviewed-by:
-
Kent Tamura authored
* It has circular dependencies with platform:platform, platform/instrumentation:instrumentation, and platform/scheduler:scheduler. This CL updates |allow_circular_includes_from|s for them. * Change visibility of platform:platform_export to be used by platform/heap:heap_unsanitized. This CL has no behavior changes. Bug: 800764 Change-Id: Iba08daca769d5c41f20fd678ef2d3cbc3c72e3ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400782Reviewed-by:
-
Kent Tamura authored
Tbr: peria@chromium.org Fixed: 1126777 No-Try: true Change-Id: Ia905b0c4ff7f9deb568c49655dd934e53f8032af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402558Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#805618}
-
Ryo Hashimoto authored
BUG=b:166087457 TEST=Login Change-Id: Ic135bf97543c755686fe40ad7219cd02aaa8f9bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392187Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#805617}
-
Trent Apted authored
The current approach isn't maintainable, and a new param is needed for better coverage of incognito and guest mode profiles. Bug: b/166730281 Change-Id: Iea8b7ec6ced3867d83fc5224499830db9c6f53bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397982 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#805616}
-
Joel Hockey authored
Bug: 1081595 Change-Id: I81ed14a06d79799f14e43a3d91444a645d9f430e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400555 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9a7b0a2dc5a3..cbbf9587645f 2020-09-10 courtneygo@google.com Fix ASAN issue with accessing application name If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: I19b6d3d7a76530430ae451eadc37cd16e2fe5575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402418Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805614}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 800764 Change-Id: I2d3c4b1ee953d4cc7581db2c5d0c0ebbeb7f7123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400583 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Prabir Pradhan authored
When the display's device_scale_factor changes in tablet mode, we expect that the app does not change its position on the screen, event in split-screen mode. However, when this happens, the bounds of the app in DP will change, since the display size in DP changes. We need to ensure that the scale in ClientControlledShellSurface gets updated before the DP bounds of the surface changes, so that when the client is notified of the bounds change, it will be scaled with the new scale factor. The client's bounds changes in OnDeviceScaleFactorChanged(), which gets called before the surface's OnDisplayMetricsChanged(). To ensure the scale is updated before the bounds change, we set the scale in both methods. BUG=b:163424969 TEST=Change display scale with client app open in split-screen mode; observe that the client app remains in the expected position. Change-Id: I09ffccc9994357fdeba794041c2abf9274ef986b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391658Reviewed-by:
Mitsuru Oshima (Slow: gardener) <oshima@chromium.org> Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org> Cr-Commit-Position: refs/heads/master@{#805612}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/97b880e6ff82..87f25134a8c1 2020-09-10 jiawei.shao@intel.com Vulkan: Combine all the barriers before dispatch() in one call 2020-09-09 cwallez@chromium.org ShaderModule: Add support for multiple entryPoints 2020-09-09 cwallez@chromium.org D3D12: Make HLSL generation per-entrypoint. 2020-09-09 cwallez@chromium.org OpenGL: Make GLSL generation per-entrypoint. 2020-09-09 cwallez@chromium.org Metal: Use ShaderModule reflection when possible. 2020-09-09 cwallez@chromium.org Make ShaderModuleBase use its own spirv_cross for reflection. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iab5e3fb61e76576436ce2d0f459a1fad260285cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401731Reviewed-by:
-
My Nguyen authored
Follow mock at http://go/cros-lang-settings-ux-slide#slide=23 Will add other components in following CLs. Current view enabled by policy: http://screen/37LZsEYnjeA5qLk When spell check is disabled: http://screen/7xgUwHJz82HMMpK View when no spell check language: http://screen/Aedx2EsgeFKUFys Note: All strings are not finalised so they are translateable false and no screenshots required. Bug: 1113439 Change-Id: I1ce9110f3f1d5a295ccc815ae346de3460a340f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360093 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#805610}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/66e88206d65d..2f11d877efaa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC peria@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099982,chromium:1109276,chromium:1122882,chromium:1126658 Tbr: peria@google.com Change-Id: Ic7c582f4789f989bd76e5cd33a8160801159b6a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402394Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805609}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/70f34e0b8eaa..210e1beae78c 2020-09-09 dberris@chromium.org [chromeperf] Add WebRTC owners If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: rmhasan@google.com Change-Id: I7a0c0be700821a863d9de02cdfa9dc82b6c72eac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402391Reviewed-by:
-
Kenichi Ishibashi authored
We still want to see the number. Bug: 1125764 Change-Id: I711c13c386f9beefcf1c269055a1ca8e8a5da399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396197Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#805607}
-
Rachel Carpenter authored
Bug: b/156308432 Change-Id: I8634b4dcffe616f9ce950a6d9500e957f4e83867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400587 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
-
Min Qin authored
This CL fixes an issue in DownloadFileWithError that when injecting an error on a write offset, we should check if the offset is overwritten by a write operation, rather than just the beginning offset. And then we use this fix to fix the flaky MiddleSliceDelayedError as the same offset will be overwritten twice by 2 streams. BUG=1105429, 1106059 Change-Id: Iff9b9d796ed5d86c68b24667096e2089564c4c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401312Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805605}
-
Findit authored
This reverts commit 4ccb6508. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 805598 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRjY2I2NTA4MDBjZDdkZTgzYWUzY2RiNzFkMzNiZmQ5N2NmZTBkOWYM Sample Failed Build: https://ci.chromium.org/b/8869579849484323600 Sample Failed Step: compile Original change's description: > Files SWA: Moving to a new directory. > > Bug: 1111229 > Change-Id: Id0509caf9d1d9de8efa293344e682610cf1a8699 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381330 > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Jiewei Qian <qjw@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Bo Majewski <majewski@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805598} Change-Id: Iaced93329ca1f5e37d6cec4f9e3fdf6b5ae8664f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1111229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401927 Cr-Commit-Position: refs/heads/master@{#805604}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Iba02761d0858ff1087f77809e3e15ff6d9e881c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402193Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805603}
-
My Nguyen authored
These functions dealt with input methods, which is only used for Chrome OS. Will move all the Chrome OS only logic into a separate file in chromeos once the migration is over as these are linked with languages preference and still shared with Chrome OS's browser. Bug: 1113439 Change-Id: Ia90d82506d5517e9f74b32d47415a4ed89f2faf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398440Reviewed-by:
-
Zentaro Kavanagh authored
- This is already the default and was previously removed from all components. See [1]. [1] - crbug.com/1068407 Bug: 1125150 Test: None Change-Id: I486944d6c6a5c0a8ffad04fd5da94a2a3c62fc0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401586 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#805601}
-
Zhenyao Mo authored
BUG=711140 TEST=manual R=sunnyps@chromium.org,rafael.cintron@microsoft.com Change-Id: I407e1ff43b5788819e54acce6358b0ff4ed1bfd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399842Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#805600}
-
Sven Zheng authored
The flakiness was introduced by this CL https://crrev.com/c/2397715 which was a reland of CL that was reverted because it made this test flaky. Bug: 1111979 Change-Id: I3153d0a27a85f36b282406f3cf15c6661d060dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402160Reviewed-by:
-
Bo Majewski authored
Bug: 1111229 Change-Id: Id0509caf9d1d9de8efa293344e682610cf1a8699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381330Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Richard Chui authored
Make the close desk button visible and navigable for switch access users. Switch access users are unable to execute keyboard commands through their physical switch devices, rendering them unable to close virtual spaces without the close buttons being visible. Test: manual Change-Id: I8624783a586424307971f0a27ba9c80456fa788b Fixed: 997011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391594 Commit-Queue: Richard Chui <richui@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#805597}
-
Daniil Lunev authored
Bug: b:151176984 Change-Id: I21cdb37edcc8880c86660393c7e4ed620e70fe89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397984Reviewed-by:
-
Solomon Kinard authored
References: crrev.com/c/2368147 & testing_api.md#use-promises. Bug: 1119846 Change-Id: Id7e603c415f8d2c6fee00a615b97078e486fe6f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382888 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#805595}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599551854-84903541b1ee77a3a0a009f1d73fc84d0ed1091a.profdata to chrome-win32-master-1599659830-8ef8811788e74327dac6ace27b47b5f70375bbf0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I5223de08a550548ab8ee808194055cf85b58b1bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401870Reviewed-by:
-
David Van Cleve authored
Looks like this has been failing flakily on Windows and Mac for a while; most recently, it's caused the Mac10.13 Tests (dbg) builder to fail: https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29 Tbr: gtsteel@chromium.org Bug: 1126649 Change-Id: Ib3313cdcee9351d1e2bb1b4553456b2bc6c6e5d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401973 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#805593}
-
Keren Zhu authored
* Add MdIPHBubbleButton, a transparent MD button with optional white border. * Add snoozable option to IPH bubble. Disable auto-dismiss for snoozable button. UX spec: https://docs.google.com/presentation/d/1l19RBFdJjsLIO2KPVANY-ObfwmUCkpQ1Lj8IeLAqJZM/edit#slide=id.g92aa3ae4f7_1_43 Screenshot: https://screenshot.googleplex.com/5brgyBvGcaoMeEP Bug: 1121399 Change-Id: Ic3ca76b6edcb52bdc9d856aa6ee11476e018218d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394157Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805592}
-
Lukasz Anforowicz authored
This CL introduces DataURLLoaderFactory::Create static method that allows creating an DataURLLoaderFactory that is owned by its |receivers_| and will self-delete when the last receiver disconnects. This CL removes the ability to directly construct and own a std::unique_ptr<DataURLLoaderFactory>, because this ability means that the factory can be destructed while receivers bound via the Clone method are still alive (see the associated bug). In particular, this CL stops exposing DataURLLoaderFactory constructor as a public member, which forces construction to go via the new Create static methods. This CL mostly just follows the pattern established earlier by https://crrev.com/c/2337411. Bug: 1106995 Change-Id: I173ce25efbdb95442c9978856a93163e9f067495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357618 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#805591}
-
Raphael Kubo da Costa authored
Point to https://w3c.github.io/screen-wake-lock rather than https://w3c.github.io/wake-lock. While the latter redirects to the former, anchors are broken in the redirection. Change-Id: I2eca3e236c0105af8017a09af872935dadd43bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395718 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#805590}
-
Zentaro Kavanagh authored
- It was accidentally deleted here [1] [1] - https://chromium-review.googlesource.com/c/chromium/src/+/2224346/24/chromeos/components/print_management/resources/print_management.html Bug: None Test: None Change-Id: Ifeed774ca437c29bc38582ce4e5c18ac71619efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402287Reviewed-by:
-
Seokho Song authored
The input validation has only been considered underflow or overflow. If min and max values are equal and the user input value is different, we should show a message that the values does not match. In this CL, InputType will calculate 'value != min && min == max' to check it must be same. Bug: 1073923 Change-Id: Ia7e1e5e9ece70cd31034f3bda2c833dd36ed1d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389281 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
Shrek Shao authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1788138, these tests were enabled on Android. But flakes are seen on Nexus 6: https://ci.chromium.org/p/chromium/builders/ci/Android%20FYI%20Release%20%28Nexus%206%29/33613 Following the similar pattern of skipping them as in: https://chromium-review.googlesource.com/c/chromium/src/+/1808584 https://chromium-review.googlesource.com/c/chromium/src/+/1628391 TBR=kbr@chromium.org Bug: 609629 Change-Id: Icd07a38c4e3a5ff8c12c791bdf0f6b066014e726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401708Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#805587}
-
Tom Anderson authored
This fixes a regression where accelerators like Ctrl+T would not work after changing the keyboard layout after [1]. XKB internally selects and handles NewKeyboardNotify events, which get fired when changing the keyboard layout. This CL fixes the issue by manually selecting and responding to these events. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2317767 R=sky CC=nickdiego Bug: 1125886 Change-Id: Ie8b84e1947da2deb527cd572f7a646b4f833b3ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402301 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Tom Anderson authored
After [1], gfx::GetXDisplay() returns a different display for each thread. This introduces a race condition since |g_handler| is shared across all threads. Since X11ErrorHandler will be removed soon anyway (since XProto uses a different error-handling mechanism), this CL simply removes the DCHECK(). [1] https://chromium-review.googlesource.com/c/chromium/src/+/2343314 BUG=1122006 R=sky Change-Id: I1101a3456f4609481a1f204634102dac89bad0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402304 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
