GitLab

Messages which track the progress of discovery are VLOG(2) and unusual events are VLOG(1).

We can use this to diagnose failures in test automation with release builds.

BUG=394082

Review URL: https://codereview.chromium.org/394383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283924 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394836
NOTRY=true

Review URL: https://codereview.chromium.org/400803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283912 0039d316-1c4b-4281-b951-d872f2087c98

This change implements a high priority packet list in PacedSender. In
practice the order of packet priority is:
1. RTCP
2. Audio
3. Video

The reason for doing this such that audio packets can interleave between
video packets even if the audio packets has a greater value of
timestamp. This characteristic of interleaving packets will facilitate
better bandwidth estimation by looking at audio send and ACK pairs.

cast_simulator shows no ill effect but a slight improvement:
Before
Audio frame count received: 17978
Video frame count received: 5169

After
Audio frame count received: 17989
Video frame count received: 5174

BUG=394191

Review URL: https://codereview.chromium.org/399743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283911 0039d316-1c4b-4281-b951-d872f2087c98

have been used.

This will be used as part of a resource/permission manager which will allow users to more easily see and modify which permissions are being granted to which websites.

Design Doc: https://docs.google.com/document/d/1oQwmj3AU4QYhTyGrYEGr6zaZhHUfx-wqUgEcQGbUU-U/edit?usp=sharing

BUG=372607

Review URL: https://codereview.chromium.org/356543003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283909 0039d316-1c4b-4281-b951-d872f2087c98

Private function HasAttachmentNotOnServer is now tested (albeit
indirectly) by directory_commit_contribution_unittest.cc via
DirectoryCommitContribution::Build.

When displayed in about:sync, SyncEntity instances will now show any
attachment ids they contain.

This CL depends on issue 395913003.

BUG=356266,394023

Review URL: https://codereview.chromium.org/393083004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283908 0039d316-1c4b-4281-b951-d872f2087c98

BUG=346956
TEST=tools/telemetry/run_tests && tools/perf/run_tests && content/test/gpu/run_unittests
R=kbr@chromium.org, nednguyen@google.com, tonyg@chromium.org

Review URL: https://codereview.chromium.org/382433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283907 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392280
TEST=built with chromeos==1 use_ozone==1 & ran egltest on X11
NOTRY=true

Review URL: https://codereview.chromium.org/387943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283906 0039d316-1c4b-4281-b951-d872f2087c98

When this field trial is enabled and the data reduction proxy is
enabled, all UI elements will indicate that the proxy is enabled,
but the proxy will not be used.

BUG=357793, 394541

Review URL: https://codereview.chromium.org/388663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283905 0039d316-1c4b-4281-b951-d872f2087c98

This isn't necessary because the test environment set up includes Blink
creating an isolate holder.

Review URL: https://codereview.chromium.org/402553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283904 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394186

Review URL: https://codereview.chromium.org/396063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283903 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392319
NOTRY=True

Review URL: https://codereview.chromium.org/386443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283899 0039d316-1c4b-4281-b951-d872f2087c98

Finally enabling Clang requires openssl and hunspell rolls. This should
fix everything else.

R=dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/402683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283894 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283892 0039d316-1c4b-4281-b951-d872f2087c98

This will mark hunspell as not chromium code to make Clang happy.

R=scottmg@chromium.org
TBR=scottmg

Review URL: https://codereview.chromium.org/402703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283891 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise if the devices are gone lots of tests will just fail.

Already fixed this for recipe based builders in crbug.com/393681

I don't know how to test this, but happy to write one if shown.

BUG=393681
NOTRY=True

Review URL: https://codereview.chromium.org/390993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283890 0039d316-1c4b-4281-b951-d872f2087c98

Seems to be ocassionally crashing when accessing the mapped PBO
on at least certain Adreno 330 w/Android 4.2.2 configs.

BUG=394510

Review URL: https://codereview.chromium.org/397353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283889 0039d316-1c4b-4281-b951-d872f2087c98

The new comments specify requirements instead of defining behavior
operationally using a particular implementation (and isn't consistent
with, e.g., the standalone implementation, which uses
mojo/public/cpp/utility/run_loop.*).

Note that this doesn't actually fix bugs or make things conform to these
requirements. See crbug.com/394884, crbug.com/394883, crbug.com/394886.

R=darin@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/405513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283888 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394898
NOTRY=true
R=aurimas@chromium.org

Review URL: https://codereview.chromium.org/397363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283887 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349211
TEST=Existing tests pass.

Review URL: https://codereview.chromium.org/397953007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283886 0039d316-1c4b-4281-b951-d872f2087c98

Consolidating all the mocked components in DriWrapper for easier
testability of the DRI platform. This should also simplify unittesting
since there won't be a need for interfaces and factories for the sake of
testing.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/402773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283885 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/399133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283884 0039d316-1c4b-4281-b951-d872f2087c98

R=yzshen@chromium.org

Review URL: https://codereview.chromium.org/405433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283881 0039d316-1c4b-4281-b951-d872f2087c98

This allows other clients to use the external serialization utils.

R=bsimonnet@chromium.org,isherman@chromium.org,asvitkine@chromium.org
BUG=343624

Review URL: https://codereview.chromium.org/394093003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283880 0039d316-1c4b-4281-b951-d872f2087c98

Because we listen to XInput2 events on AllDevices, we receive an event from
the slave device, followed by an event from the master device. It is not
necessary to process the events from the slave device, so ignore them.

BUG=368750
R=kpschoedel@chromium.org

Review URL: https://codereview.chromium.org/402763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283879 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283878 0039d316-1c4b-4281-b951-d872f2087c98

This includes the following changes:
a1851e8  Fixes for re-enabling more MSVC level 4 warnings: angle/ edition
6518fe2  Moved TextureStorage and Image into d3d
d4cfa57  Move more draw call validation to the API.
f6d38b0  Fix CollectVariablesTest GCC/Clang compile errors.
4e1fd41  Store a map of interface block registers.
829e89e  Add a default constructor to sh::ShaderVariable.
d5512cd  Collect shader outputs and interface block information.
0b7e5d8  Fix 64-bit warnings.
c0b9ef4  Split Caps into Caps, Extensions and TextureFormatCaps.
57f9b6d  Clean up generatemip.h.
86846e2  Clean up the functions in loadimage.h/cpp.
2a6564e  Fix build errors in validationES.cpp.
e92a354  Remove redundant FBO query methods.
55ec3b1  Refactor common attachment validation to base method.
23a8a43b  Store compact and expanded shader variables.
aae65a4  Add caps for texture size limits and other caps in the 6.28 table.
77f7485  Add a GetVariableInfo helper method.
93455eb  Add missing limits include to angleutils.h
4667c45  Refactor style in VariableInfo.cpp.
53cb14d  Share ArrayString and Str helper methods.
b23375f  Fixed an issue with Streaming Vertex data overflowing it's buffer.
aa7e166  Improve the const correctness.
b447227  Add a ValidateAttachmentTarget helper method.
570f7c8  Add helper methods for FBO attachment validation.
a328d56  Removed sampler state getters and setters from gl::Texture

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/399733006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283877 0039d316-1c4b-4281-b951-d872f2087c98

A test window is just a path to write an image file to. Each window has
a unique image path.

BUG=392280
TEST=built with chromeos==1 use_ozone==1 & ran test platform
NOTRY=true

depends on https://codereview.chromium.org/375053002/

Review URL: https://codereview.chromium.org/377973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283875 0039d316-1c4b-4281-b951-d872f2087c98

Initialize the input-method using ui::InitializeInputMethodForTesting()
before creating the input method.

BUG=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/400713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283874 0039d316-1c4b-4281-b951-d872f2087c98

In overscroll mode, any window with web contents that overlaps the virtual keyboard has insets in order to facilitate scrolling to the bottom of the document.  These insets are updated whenever the keyboard is shown or hidden.  This patch adds another update in the event that a window moves while the keyboard is visible.  This case can occur after a screen rotation while the keyboard is shown.


BUG=391337

Review URL: https://codereview.chromium.org/368323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283873 0039d316-1c4b-4281-b951-d872f2087c98

There is an unused implementation of this method,
which can be removed.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/397283004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283871 0039d316-1c4b-4281-b951-d872f2087c98

Now only --disable-threaded-compositing exists, which is only present
for layout tests. The --enable-threaded-compositing flag moves to
become a content shell flag only, as it's only used for DumpRenderTree.

Change any checks in the renderer process for kEnableThreadedCompositing
to instead be !kDisableThreadedCompositing since that is the only
flag left.

Remove the whole threaded compositing thing from about:gpu and
about:flags.

R=piman
BUG=384381,346363

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278151

Review URL: https://codereview.chromium.org/337783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283870 0039d316-1c4b-4281-b951-d872f2087c98

File paths take too long to look up. Instead, use the file id versions.

BUG=385307

Review URL: https://codereview.chromium.org/378263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283869 0039d316-1c4b-4281-b951-d872f2087c98

UserNetworkConfigurationUpdater::SetSkipCertificateImporterCreationForTest
is not needed anymore, so it's safe to remove it and cleanup tests
using it.

BUG=None

Review URL: https://codereview.chromium.org/325313004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283868 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372843

Review URL: https://codereview.chromium.org/383023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283866 0039d316-1c4b-4281-b951-d872f2087c98

We will need this for networkingPrivate so that we can notify observers
when Device properties of a Cellular network change.

BUG=none

Review URL: https://codereview.chromium.org/395523004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283863 0039d316-1c4b-4281-b951-d872f2087c98

Setting a layer-hosting NSView's CALayer's geometry flipping has a lot
of unexpected side-effects, and is proving unsafe, especially if that
NSView will have sub-views.

Add a level of indirection where the hosted layer is not flipped, but it
has a sub-layer that is flipped, off of which the layers for composited
content are attached.

BUG=392952

Review URL: https://codereview.chromium.org/392143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283862 0039d316-1c4b-4281-b951-d872f2087c98

We'll want to break up ppb_nacl_private_impl.cc instead of lumping things into
one large file. This change makes the method for getting CPU feature attributes
easier to reuse, and renames the sandbox_arch.{cc,h} files in the process.

This is split off from a larger change to remove FileDownloader in the trusted
plugin.

BUG=370556
R=bbudge@chromium.org

Review URL: https://codereview.chromium.org/399983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386785

Review URL: https://codereview.chromium.org/394353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283860 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 93a9886b.

This CL makes mean_input_event_latency crazy.

BUG=394889
TBR=skyostil
NOTRY=true

Review URL: https://codereview.chromium.org/400533006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283859 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392280
TEST=built with chromeos==1 use_ozone==1 & ran caca on X11
NOTRY=true

Review URL: https://codereview.chromium.org/387953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283858 0039d316-1c4b-4281-b951-d872f2087c98