GitLab

Bug: 1119656
Change-Id: Ibf8518900f9d4866ff900b8f7f8eccf089c14c40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372813
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803666}

None of these classes are interface mocks. Rename them to be more
appropriate of what they are providing.

R=avi@chromium.org

Bug: 866140
Change-Id: I2ca0fd49b8b1a375d2be8c2e08bb99bab554fa42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388346
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803665}

PermissionCombobox used ModelChanged() incorrectly to propagate a
change to the SizeToLargestLabel property. The real fix updates
Combobox to correctly invalidate the preferred size on such a
change and updates the method name in PermissionCombobox.

Fixed: 1116750
Change-Id: I5bc8f3efe292e94cbfc1c94a2a5149b8b1514da4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388889
Commit-Queue: Robert Liao <robliao@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803664}

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I2fccd171a4d970bc1cf29ec4314e63c8656fd3e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382596Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803663}

Bug: 1116644
Change-Id: I2607ded4d277328067b79f5127664c7a457ba09e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383092Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803662}

This reverts commit 3cf58053.

Reason for revert:
There are 3 new performance regressions related to this change :
[1] https://bugs.chromium.org/p/chromium/issues/detail?id=1123547
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=1123235
[3] https://bugs.chromium.org/p/chromium/issues/detail?id=1123254

Very likely caused AccessibilityIpcErrorBrowserTest.ResetBrowserAccessibilityManager consistently fail on android x86 builders since:
* https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2007
* https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel/1102

It has been verified that this test
* passed with earlier revision: https://chromium-swarm.appspot.com/task?id=4e5ebf09d330cd10
* failed with this revision: https://chromium-swarm.appspot.com/task?id=4e5eb98aba040310

Original change's description:
> Reland "Fix Role::kButton name invalidation when descendant text is modified"
>
> This is a reland of 8f92c37d
>
> Revert CL :
> https://chromium-review.googlesource.com/c/chromium/src/+/2346996
>
> Reason for revert: causing build failure:
> https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/15547?
>
> Original change's description:
> > Fix Role::kButton name invalidation when descendant text is modified
> >
> > This CL addresses a bug where Role::kButton, and possibly other roles
> > that derive their name from descendant contents, were not firing
> > Text Changed when a descendant Node.TEXT_NODE modifies its text |data|.
> >
> > ax_object_cache_impl.cc :
> > - When firing a text changed event, also fire a text changed event for
> >   the first ancestor that derives its name from descendant contents.
> >   This ensures the nodes are invalidated, send appropriate text changed
> >   events, and the changes are serialized to the browser process AXTree.
> >
> > browser_accessibility_manager_win.cc :
> > - FireUiaTextContainerEvent made it possible to fire text events more
> >   than once for a given text provider so it has been removed.
> > - Instead, populate a set |text_changed_events_| which contains the
> >   text providers via |GetUiaTextPatternProvider| and fire the UIA text
> >   events in BrowserAccessibilityManagerWin::FinalizeAccessibilityEvents
> > - |text_selection_changed_events_| could also potentially end up with
> >   the same double-event problem, so it uses GetUiaTextPatternProvider
> >   now as well.
> > - Removing usage of std::unordered_set based on the guidance in
> >   base/containers/README.md. In general these sets shouldn't grow large
> >   enough to benefit from being unordered.
> >
> > AX-Relnotes: Fix bug where after updating the content of complex button might not notify ATs, causing the wrong accessible name to be announced.
> > Bug: 1105262
> > Change-Id: I02dc7798686b09f780c90af52aeb2e36fe8fe048
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296564
> > Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
> > Reviewed-by: Nektarios Paisios <nektar@chromium.org>
> > Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#796464}
>
> Bug: 1105262
> Change-Id: Idfafd2e7f886d4d27b735d143ceaa0f33607f7c5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346933
> Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
> Reviewed-by: Wez <wez@chromium.org>
> Reviewed-by: Nektarios Paisios <nektar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#802730}

TBR=wez@chromium.org,nektar@chromium.org,aleventhal@chromium.org,kbabbitt@microsoft.com,kschmi@microsoft.com,Adam.Ettenberger@microsoft.com,yangsharon@chromium.org


Bug: 1105262
Change-Id: I01dfe88c964c907331c4497f7e789e2ad59e14f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388361Reviewed-by: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#803661}

To avoid changing the meanings of long-standing metrics, this patch
adds two new metrics:
* appcache.UpdateJob.ExistingResourceOnlyCorrupt
* appcache.UpdateJob.ExistingResourceOnlyNotCorrupt

These only are emitted for corrupt or non-corrupt resources, vs the
previous metrics which also emitted a "0-bucket" for the opposite.
This will allow us to use these metrics more clearly in Finch.

This also changes the meaning of the currently unused
appcache.UpdateJob.ExistingResourceCorruptionRecovery to
behave in this same way.

Bug: 1033703,989611
Change-Id: Iac9575de286db19102d9586866606e31d9c0bae0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376571
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803660}

Bug: 1122955
Change-Id: I0d31e92fedfa8cbaf52445b1d727bb19401369c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381255Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Eugene Zemtsov <eugene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803659}

Bug: 1123858
Change-Id: Ide486d795a4b0c244e082e04ab3e9da02b0ff157
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387621Reviewed-by: Yusuf Sengul <yusufsn@google.com>
Commit-Queue: Robin Lewis <wrlewis@google.com>
Cr-Commit-Position: refs/heads/master@{#803658}

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I30ef2ad1444a2d21e59da4a590c8da1df4952668
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382071Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803657}

Aside from the compositorLatency.type which reports for every frame, two aggregate subcategories are added to track when there is any or no interaction active.

Bug: 1122140
Change-Id: Ia44a8324eb09d86bdc67c6794446a86d94c99fb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380423
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803656}

This is a follow-up to the following CL: https://crrev.com/c/2252950.
Remove TODOs to remove calls stripping Non-Breaking Spaces.

Change-Id: I9f56378be2091dadb2e5b732d8573e4b8c254eda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295795Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803655}

IsNull and SetToNull aren't needed as the STL string type doesn't use
nullable_is_same_type.

Change-Id: I0770b42e275e3026749c5409015c4b79941ea56f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386744Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Cr-Commit-Position: refs/heads/master@{#803654}

Bug: 1119632
Change-Id: I8814e259146b50144ec422b89732f15a6f677129
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381053
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803653}

https://android.googlesource.com/platform/external/perfetto.git/+log/816506e1c600..000948ecdba8

2020-09-01 treehugger-gerrit@google.com Merge "trace_processor: Dedup proto files and definitions"
2020-09-01 lalitm@google.com Merge "tp: use unique port by default"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ia2b484d1c2e81b040b6126f8da7c6db3ba837e9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388803Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803652}

Bug: b:158658869
Change-Id: Ic523b315c8fcffd8f47d8ef517d4f365b2e6b3df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386801
Commit-Queue: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Mahmoud Gawad <mgawad@google.com>
Cr-Commit-Position: refs/heads/master@{#803651}

This reverts commit bdc3ad55.

Reason for revert: Bidi handling caused bugs for non-bidi URLs, for the time being this will be reverted while those are fixed, and a CL disabling elision experiments for bidi URLs will be merged to 86.

Original change's description:
> Fix elision for bidirectional URLs
> 
> URLs where the TLD is separate from the host, which can happen for URLs
> of the form http://LTR.RTL/RTL, were displayed with a blank spot when
> elision was enabled. This CL changes this so the in between section,
> which is not elided in this case, is also not colored transparent.
> 
> Bug: 1117631
> Change-Id: I9bba2d2c0d494a4021b8c8edaacc87084e040964
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368458
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Reviewed-by: Emily Stark <estark@chromium.org>
> Commit-Queue: Carlos IL <carlosil@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#801559}

TBR=tommycli@chromium.org,estark@chromium.org,carlosil@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1117631
Change-Id: Idc2ac1d682b1ec5ca1c5d8efc60dad70e0f203d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387483Reviewed-by: Carlos IL <carlosil@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803650}

https://skia.googlesource.com/skia.git/+log/928a02b1527d..f48dfd985712

2020-09-01 mtklein@google.com Revert "debug LSAN failures"
2020-09-01 herb@google.com fix unsigned compare against zero
2020-09-01 reed@google.com plumb cubic params into gpu backend
2020-09-01 bsalomon@google.com Separate our use of sampler object from GL support.
2020-09-01 herb@google.com maintain the page index in AtlasLocator

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC michaelludwig@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: michaelludwig@google.com
Change-Id: I615b479f340c3d771b3e278053e44ca4ef9c8762
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388860Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803649}

Bug: b:158658869
Change-Id: Ie366422199576e352185d9f8877a8944dbdcad8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387645
Commit-Queue: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Mahmoud Gawad <mgawad@google.com>
Cr-Commit-Position: refs/heads/master@{#803648}

https://webrtc.googlesource.com/src.git/+log/2bca0089149c..2597a1b22c0a

2020-09-01 ssilkin@webrtc.org Set initial decoder resolution from field trial.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I1c8ccd65f534bf4266e784ada9f96c85bb0f89ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388802Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803647}

Previously, a couple of bugs went uncredited and didn't attract CVEs
because this label wasn't added. This may help a little.

Change-Id: I7208168a8cd8bae523bdfe00118ae70d3c901836
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387416Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Adrian Taylor <adetaylor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803646}

Thumbnail capturing is a hidden capturer which should not have
side-effect. It should not prefer the capture size.

This CL is self-contained and tests by itself with the DCHECK in
WebContentsImpl::IncrementCapturerCount(). I've verified that all
callers now meet the requirement.

Also verified programatically that the thumbnail capturing won't cause
side effect of page rendering.

Bug: 1112607
Change-Id: I9f9618e75568cec02d48ddb4b73c43b6233b7fa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380884Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803645}

Re-organize (ChromeDriver) http server into its own class so that
http handler can be a friend of http server. Then we can handle
the http server methods by posting on cmd thread to call
http handler methods. The reason to post on cmd thread is
that we can ensure thread safety when manipulating session map.

Also, pass cmd task runner and pointer to session map to
InitSessionParams so that session_commands can manipulate
the session map upon ExecuteInitSession.

Will make follow up CL to add condition check before manipulating the
session map. Follow up CL will also need to parse user WebSocketUrl
parameter.

There is also pending discussion about the behavior WebSocket connection
if the session terminates in the CL code review comments.

Bug: chromedriver:3588
Change-Id: Ibbd8b12842cf2e5b93d67bf68e1b869bb93f20c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382299
Commit-Queue: Shengfa Lin <shengfa@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803644}

Bug: b:158658869
Change-Id: I46bfbe9c0f3776be67c45c4d3541fcaaf3381ffe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386727
Commit-Queue: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Mahmoud Gawad <mgawad@google.com>
Cr-Commit-Position: refs/heads/master@{#803643}

Bug: chromium:1124018
Change-Id: Ib9e9f3a5bcb93d9dc094e1daee7217c3e01d8922
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388603
Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org>
Reviewed-by: Amr Aboelkher <amraboelkher@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803642}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f2e5606d..9822be5c

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ia2bde5a44c2eb6cce380b6dcc79a4ff3315d30d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388481Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#803641}

Bug: b:158658869
Change-Id: Ifce5a5fe750ed57e3c1f2d7bb647309cc0e58c3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386800
Commit-Queue: Oleh Lamzin <lamzin@google.com>
Reviewed-by: Mahmoud Gawad <mgawad@google.com>
Cr-Commit-Position: refs/heads/master@{#803640}

Previously tables ignored the given fixed-inline-size. However due to
a fix for grid/flex:
https://chromium.googlesource.com/chromium/src/+/a0b54e201c5ae7f2a5d2a769531adb9c47ff54ba
they started respecting them.

The uncovered a bug in the NG out-of-flow calculation, (given that these
set a fixed-inline-size on children).

An OOF table with "table-layout: fixed", and a %-width will force its
max-content size to infinity, consuming all available space.

This patch only performs this adjustment if the table *isn't* OOF.

Bug: 1123475
Change-Id: I8784eb3ce4294132f6e6b7cb95ad71464c2380f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388266Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803639}

This is a reland of 95cff9e7

What was broken in the first CL:
  device_unittests failed because of:
    -NintendoDataFetcherTest.AddAndRemoveSwitchPro
    -NintendoDataFetcherTest.UnsupportedDeviceIsIgnored
  services_unittests failed because of:
    -HidManagerTest.TestHidConnectionInterface
    -HidManagerTest.GetDevicesAndSetClient
    -HidManagerTest.GetDevicesOnly
The unit test failed because the mock_hid_service is set in the
unittest code but we din't bind it in the device service.

In this CL, I add IsHidServiceTesting to check the testing status.
It would bind the mock_hid_service when the HidService instance is
set by SetHidServiceForTesting().

Original change's description:
> lacros: gnubby support for LaCrOS (hid_manager)
>
> Because Gnubby and power gnubby in chromium would be considered as
> HID devices, and this CL would enable HID devices support for LaCrOS.
>
> Before this CL: Lacros would try to access /dev/hidraw*, but the
> permission of it is root:hidraw 660, and lacros is running in chronos
> user permission. By the way, CrOS it is using dbus to access the
> permission_broker, and permission_broker would access these files for CrOS.
>
> In this CL: Open a HidManager mojo between ash-chrome service and lacros service.
> Lacros would use AddReceiver to add a receiver to ash-chrome's HidManager.
> And the HidManager on ash-chrome would use permission_broker to access
> /dev/hidraw* files. In this solution, we wouldn't need to compile the
> permission_broker into lacros.
>
> BUG=chromium:1109621
> TEST=tested gnubby manually on soraka
>
> Change-Id: I18cfe9b5e93e260b9347df4b57ebe12a621f44a8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319089
> Commit-Queue: joe Chou <yich@google.com>
> Reviewed-by: Greg Kerr <kerrnel@chromium.org>
> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#800003}

Bug: chromium:1109621
Change-Id: I15e77c7e7ccf8ea26bef6f7c65f36c5cafbf743c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367572Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Auto-Submit: joe Chou <yich@google.com>
Commit-Queue: joe Chou <yich@google.com>
Cr-Commit-Position: refs/heads/master@{#803638}

This patch changes the behavior of willstart- an didfinish- lifecycle
callbacks, as well as when the start of lifecycle tasks are run.

Previously, they would run on any call to the lifecycle update.
However, the intent of this is to document when the main frame
lifecycle runs (ie to PaintClean).

R=szager@chromium.org, chrishtr@chromium.org

Fixed: 1121965
Change-Id: I83bfa7142ca3fc9a94adbd0e5dfbe0245da3c9be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386222Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803637}

Removing this histogram logging call as it is no longer needed.

Bug: 1112388
Change-Id: Idea744669b9e2d1b9be4bb0ecd37f529e3657603
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386596Reviewed-by: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Tim Judkins <tjudkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803636}

As suggested in previous review [1], this change makes it more clear
that the concrete attachment being renamed here is the same-thread
version, since later changes will introduce a cross-thread version.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2380571/comment/7c8dd1e5_df26fa86/

BUG=878133

Change-Id: I74c8d1dce6f1d17095f8c71f84628c4a49c52413
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388435
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#803635}

Collapse the 2 remaining methods onto WebTestControlHost, so all
renderer->browser comms go to the same place for web test control.
The browser can track which renderer the message came from for these
two messages, which was the old purpose of the WebTestClientImpl.

R=avi@chromium.org, kenrb@chromium.org

Bug: 866140
Change-Id: Id5bd17283c807f3a44bea1ad14b2b3524465c1ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388401
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803634}

This change moves the majority of the "same site" logic that was in
RenderFrameHostManager into SiteInstanceImpl. This consolidates all
of the "same site" logic in one place and makes it more of an internal
implementation detail of SiteInstanceImpl. This also allows us to make
several SiteInstanceImpl methods private which will help avoid
confusion about which "same site" functions external code should call.
This change also makes it more explicit what factors are actually
required to make a "same site" determination.

Bug: 1085275
Change-Id: I7df28090f4956f5f9ca4c2baf75762f1ca03da16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336231
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803633}

Bug: b:158658869
Change-Id: I175ff7d28ae71d3f2d5d85e2f453fe74d692e92d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387644Reviewed-by: Mahmoud Gawad <mgawad@google.com>
Commit-Queue: Oleh Lamzin <lamzin@google.com>
Cr-Commit-Position: refs/heads/master@{#803632}

This is a reland of 7456a5e0

Use a custom lambda instead of implementing PrintTo(SkBlendMode).

Original change's description:
> Add names to tuple-parameterized tests
>
> Test names can only contain alphanumeric characters, plus underscores.
> testing::PrintToStringParamName() stringifies tuples using characters
> that aren't valid for test names.
>
> Add a similar function which joins each element using underscores. This
> will generate valid names for test parameterization, provided each
> element of the tuple can be written using valid characters.
>
> Bug: 1092945, 1117587
> Change-Id: I868b1d4040a93bdbf763dbb45b94ff15f181dd18
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376882
> Reviewed-by: kylechar <kylechar@chromium.org>
> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#803182}

Bug: 1092945, 1117587, 1123758
Change-Id: I4b3614bae62b557ac5da011f0dd5be1cb3256afb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386388
Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803631}

This change adds support for move-only types to
base::test::RunOnceCallback. If a move-only type is passed to the
constructor of RunOnceCallback, it will later be passed by move to
the OnceCallback that should be run. This invalidates the action,
and running it twice will result in a run-time crash.

Bug: 752720
Change-Id: I43ca5e81e9323c7c374e67de14be2637fbfea589
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379840
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803630}

Bug: b:158658869
Change-Id: Ic920541850a6e29f9db04b84e333709cb74d5827
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387642Reviewed-by: Mahmoud Gawad <mgawad@google.com>
Commit-Queue: Oleh Lamzin <lamzin@google.com>
Cr-Commit-Position: refs/heads/master@{#803629}

Android is moving to the UI launched on other platforms. Also add a
disabled provider to better match the in-use configuration.

Change-Id: Id7bae5694a3d34cdbdec9bae28f1488282cea7f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388147
Commit-Queue: Eric Orth <ericorth@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Auto-Submit: Eric Orth <ericorth@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803628}

Support a shorthand to use the variant's name to format the generated
histogram's summary when the variant's summary attribute is omitted.

Bug: 758782
Change-Id: I38d8659be97cdc26d3f0e0eb692bf423aded82b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387205
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Auto-Submit: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803627}