- 01 Jul, 2020 40 commits
-
-
Jesse McKenna authored
This change removes the SlowDCTimerInterruptsWin experiment and makes its behavior the default, lowering the raised timer-interrupt frequency to 125 Hz when on battery power. This is expected to result in a ~4% system power savings (per crbug.com/927165). The SlowDCTimerInterruptsWin experiment has been gradually rolled out through the Canary, Dev, Beta, and Stable channels, and has currently been active on 50% of the Stable channel for four weeks. It has shown no regression to its guardrail metric, FirstContentfulPaint.OnBattery. Background: Chrome frequently raises the system's global timer-interrupt frequency in order to increase responsiveness for timers. Windows handles timers by checking whether the timer has finished on a given interval; this is called the 'timer-interrupt frequency'. Increasing the timer-interrupt frequency is done by many programs to increase the granularity at which timers can be set, so waiting processes can be notified more accurately (which in some cases will mean more quickly) when their timers have finished. However, raising the timer-interrupt frequency makes the system consume additional power, so should be done sparingly. Chrome currently sets the following limits for interrupt frequency depending on whether the system is on battery power: Default, not raised: 64 Hz Raised, AC (wall power): 1000 Hz, i.e. kMinTimerIntervalHighResMs = 1 Raised, DC (battery power): 250 Hz, i.e. kMinTimerIntervalLowResMs = 4 This change halves the raised frequency of interrupts when on DC power: Raised, DC (battery power): 125 Hz, i.e. kMinTimerIntervalLowResMs = 8 Bug: 927165 Change-Id: I321599c7ce679671b29804660d5589dc88df6bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265402Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#784294}
-
zhaoyangli authored
This is a reland of 6a309aad Original change's description: > [iOS] Remove all EG1 test targets and related GN components. > > Removed all test targets, EG1 specific test utils in GN files. > Removed gni files to build EG1 targets. > Removed build files in ios/third_party/earl_grey. > > Bug: 1046369 > Change-Id: Iec1d60fa40d10969c4e6e6840f2983b02c3170dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275353 > Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784204} Bug: 1046369 Change-Id: I1690dcd79d4848cf042c06cfe2b479ed37b2df17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276682Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#784293}
-
Will Cassella authored
This CL revamps the way a VideoDecoder or AudioDecoder is selected to decode a given VideoDecoderConfig or AudioDecoderConfig, respectively. The goal is to first filter and rank available decoders based on their high-level attributes ("IsPlatformDecoder", "SupportsDecryption"), rather than attempting to initialize them in the order they're submitted. The result is that an initial decoder is selected more efficiently, and the decoding system can gracefully transition between platform and non-platform decoders if the config changes mid-stream. The full design doc is available at: go/predicate-based-decoder-selection Bug: 684792 Change-Id: I8660e7315881b2bea44bf52afb4505f979a43728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247331 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#784292}
-
Yoshifumi Inoue authored
This patch changes dependency graph of |LayoutNGFragmentItem| to make |ScopedLayoutNGForTest()| to work with both LayoutNG and legacy layout for running blink units for legacy layout tree. When we use "implied_by", |LayoutNGEnabled()| is implemented as: static bool LayoutNGEnabled() { if (LayoutNGFragmentItemEnabled()) return true; ... features in "implied_by". return is_layout_ng_enabled_; } Change-Id: Id65a621bc6b041755b7897f9e5698aff26369370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275952 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#784291}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I03bbba060b79d8597f643dff33c4a5d428232321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276686Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784290}
-
Sophie Chang authored
Bug: 1099371 Change-Id: I5d88c52547f0bcaab082521c0a084ca21bc415d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276759 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#784289}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/947260e25933..465b1021048a 2020-07-01 chrche@microsoft.com [Loc] Fix <LOCKED> and <ex> get removed when messages move across grdps If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1071004 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5340a35f94140c98f685eee2c37a8dc412ab8427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277052Reviewed-by:
-
Istiaque Ahmed authored
This CL makes error in any of "homepage", "search_provider", and "startup_pages" keys correctly point to the specific error, rather than generic "Empty dictionary for 'chrome_settings_overrides'" error message. For chrome_settings_overrides.search_provider key, the sub-keys "name", "keyword", "encoding" and "favicon_url" are mandatory, this CL also clarifies that in error message. Bug: 1088065 Test: Better error messages for missing/invalid keys, see bug for details. Change-Id: I034e62ab8a636a5c65872e8c770798bb5cd4641b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2271887 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784287}
-
Jinsuk Kim authored
Extends the experiments to M90 so the flag options will be visible. Change-Id: Ia838f222146def57691d50c5fd25a27c7dc3033a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275812Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#784286}
-
Sorin Jianu authored
Change-Id: I67566752373601fae9a667811be0d6ea146f2858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276683Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#784285}
-
Jimmy Gong authored
- ChromeVox was announcing ongoing print jobs twice. There seems to be a with ChromeVox and iron-list focusable items. The fix is to remove fow-row-control from the high level row wrapper div and move it down to either the completed status or ongoing status. - A side effect of this is that the cancel print job button will now be focused when tabbing through ongoing print jobs. - Optimize ChromeVox user experience for ongoing print jobs by announcing to users that print jobs can be cancelled by pressing the 'Enter' key. - ChromeVox will now announce when a print job has been cancelled. Bug: 1100789 Change-Id: I8d60e9bc6bed8eeec6eb9003dbf7be4c7de0a8a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275480 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#784284}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/af04ef2a7d2e..fdd2cd6e5fc0 2020-06-30 dpranke@google.com Reland "Add a Str() function to gclient for use in DEPS files." 2020-06-30 dpranke@google.com Add dpranke@google.com to //OWNERS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1099242 Tbr: agable@chromium.org Change-Id: Id0f3db271c6dcb0a718496f0a4bab59a6b1bca44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277050Reviewed-by:
-
Sangwoo Ko authored
Previously, MediaToolbarButton has different image for enabled states on Mac. Please refer to https://chromium-review.googlesource.com/c/chromium/src/+/1815904. But it's not true at this point, so we don't need this calls anymore. This is prework for ToolbarButton refactoring Bug: 1048901 Change-Id: Ife793fe1bc5093fe30cce4fcbd01bcff58799f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275359Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#784282}
-
Liviu Tinta authored
Bug: 989958 Change-Id: I6b22f34ad6b1da138bbd90a905508d9dd789cd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268384Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2e401eea3e9a..3f5d1ca9a8eb 2020-07-01 fancl@chromium.org auto-triage: Only reopen issue when auto-bisect is enabled If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1100716 Tbr: wenbinzhang@google.com Change-Id: If08d91f59fcdd871c01ade1fe36375bf43453513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277203Reviewed-by:
-
Fergal Daly authored
This was fixed in https://crrev.com/c/2246087 and reenabling got lost in some rebasing. Bug: 1064944 Change-Id: I5f1ff9c2135f0861e044590482760708fbe171da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275362Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#784279}
-
Toby Huang authored
Currently, if an extension has permission updates pending the user's approval, non-supervised users such as regular and enterprise users will see the kite icon over the extension on the chrome://extensions page. This CL fixes this UI bug so that only supervised users will see the kite icon. There should be no restrictions on the extension itself for non-supervised users. Bug: 1100395 Change-Id: I2d5a61e92925d093fa3ee4183c427d89dc8988b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273684Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#784278}
-
Rakina Zata Amni authored
This reverts commit e8275717. Reason for revert: Causes ToolbarActionsBarUnitTest.ReuploadExtensionFailed to crash, e.g. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/b8876023303247456768 Original change's description: > [Extensions] Handle reloading an extension that failed to load > > This CL enables ExtensionService::ReloadExtension() to handle reload > failures, where subsequent calls can retry the reload, rather than > immediately giving up. > > Bug: 792277 > Change-Id: I482da093133a1baee7f2f5cad8abbc9c85e9e074 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242642 > Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784037} TBR=rdevlin.cronin@chromium.org,ghazale@chromium.org Change-Id: Id229fde9a694ac3e0a0b8376492604b11f461292 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 792277, 1101189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277366Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#784277}
-
Alex Moshchuk authored
Previously, this was only set from CommitNavigation. Error pages go through FailedNavigation instead of CommitNavigation, so they were never setting this to true. Looking at the use cases of has_committed_any_navigation_, it seems that this is a bug, so this CL fixes it. This is a prerequisite for https://crrev.com/c/2250945, which will avoid BrowsingInstance swaps for browser-initiated navigations if has_committed_any_navigation_ is false, to fix issues with improperly using a spare process for initial RFHs. Doing this also makes the test SitePerProcessBrowserTest.ProcessTransferAfterError fail with RenderDocument for subframes due to https://crbug.com/1068965, so that test is disabled in that mode. Bug: 1094088,1068965 Change-Id: I942fd4046bb1c6941cf5c8aaf1c17b37ed9cdbdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272029 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#784276}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a68d933affcb..fe7e74b3a786 2020-06-30 elliotevans@google.com Add an `experimental_simd` build target to CanvasKit. 2020-06-30 jvanverth@google.com Implement GrFence in D3D. 2020-06-30 jcgregorio@google.com The Pixel 4XLs are doing fine on Tests, so stop running the tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: I13cb17fd4f9e3fc15eccbde7bfb228e2e98ef8d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274191Reviewed-by:
-
Fergal Daly authored
These tests are sensitive to RD's type of changes and several of them needed fixing already. Bug: 1100745,1068965 Change-Id: I1bd93ebac207c502d0dda7f749a4c5f25f4e506b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275459Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c75547d598c4..c1b825219eae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rakina@google.com,davidbienvenu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1046369 Tbr: rakina@google.com,davidbienvenu@google.com Change-Id: I1d1b253e244fee3efeb83d92decc744e2bd79930 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276329Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
David Bienvenu <davidbienvenu@google.com> Reviewed-by:
-
Dale Curtis authored
Due to threading issues with SilentSinkSuspender and the fact that unlike WebAudio we actually have a known volume: just use the volume value instead of trying to detect silence. I.e., start using a fake sink when playback is muted. Only switch to a real sink once playback is unmuted. This does not affect WebAudio or MediaRecorder because they always get the audio data after volume has been applied, so in these cases they will just continue to get silence. This should result in less actual audio output device creations as well as less real physical streams opened; thus saving ~200-300mW of power per measurements by Intel. As part of this change it's necessary to change where we tell the media::Renderer about the volume change. Previously it was done after Initialize() completes, but now is done before Initialize() starts like several other properties that affect Initialize(). Bug: 764133 Change-Id: I4f6e608ab25238e02da24e302bb781e219d12dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268377 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Alice Boxhall authored
This is a proof of concept at this stage. Written cooperatively with meredithl@ and chrishall@ Bug: 1099069 Change-Id: Ib2c7cf94145bf7080973f7f619cc60dc89124931 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264176 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#784271}
-
Peter Kasting authored
This will allow changing the observation method in the future without affecting the callers. This does require changing the pointer type in PageActionIconParams to a concrete type, but that's OK for now; if we really need to later, we could introduce a new abstract class that simply exposes an ObserveButton() method. Bug: none Change-Id: I540905bf89d0d05ecb69806495d9a3618b21a19f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274842 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#784270}
-
Rakina Zata Amni authored
This reverts commit 87f410b6. Reason for revert: Causes compile failures on windows Original change's description: > Public side of Windows fix > > BUG=1099250 > > Change-Id: Ia73ff41012a1e4d9a7a524339ea30e0c327f1fe4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269510 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784168} TBR=beccahughes@chromium.org,steimel@chromium.org Change-Id: I4cc36628a32ecc17062e912264a0385db5108ffd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099250, 1101155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275160Reviewed-by:
-
Noel Gordon authored
Test helper fakeDragAndDrop has an option to hover the drop target and skip the drop and dragend event sending part. The browser thinks drag- drop operations are still active on the page in that case. Add fakeDragLeaveOrDrop helper to terminate drag-drop operations: send a dragleave or drop event to the target, and then send a dragend event to the source. Tbr: adanilo Bug: 1062902 Change-Id: Id2ff6d8addbdcb0bce8625ff3e59b0d28712b94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275974Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#784268}
-
John Z Wu authored
These protocols are moved into components/password_manager/ios to be shared with other objc embedders of PasswordManagerDriver and PasswordManagerClient. Also renamed them to XXXBridge to make it clear the these @protocols are simply used to bridge C++ methods into ObjC methods. Change-Id: I13c11d7abf49482fe1355e6b48d54ec9a90d9483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252856 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#784267}
-
Xing Liu authored
The location dialog title is changed to "Choose where to download" to match the download later dialog's "Choose when to download". The file size is kept, the text could be "Choose where to download 15Kb" when the file size is available. Also does layout polish to make the title and subtitle to match the new download later dialog. Bug: 1101010,1078454 Change-Id: I08c4965ca007afa74b5c23e019d615fbb8fcbc81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276347 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#784266}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/68e60a92ae92..2761f01d68a7 2020-06-30 etienneb@chromium.org Disable the use of chromium worker threads 2020-06-30 lexa.knyazev@gmail.com Fix blendable FP32 texture caps on ES2 contexts 2020-06-30 ianelliott@google.com Vulkan: Fix off-by-1 180/270-rotated CopyTexImage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1091259 Tbr: ianelliott@google.com Test: Test: Test: angle_end2end_tests --gtest_filter=*CopyTexImageTestES3.2DArraySubImage*Vulkan*Test: Test: Test: angle_end2end_tests --gtest_filter=*WebGLReadOutsideFramebufferTest.CopyTexSubImage2D*Vulkan* Change-Id: Ibd94d829cda3aadaf17bec66f1f66bdb3431fcbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274190Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/91904cdfde76..268fe254ec50 2020-06-30 tommek@google.com Added constraints for too large uniform buffer bindings 2020-06-30 bryan.bernhart@intel.com D3D12: Limit QueueWriteBufferTests.ManyWriteBuffer 2020-06-30 cwallez@chromium.org dawn_native: Use correct integer width for SetSubData. 2020-06-30 cwallez@chromium.org dawn_wire/client: Add ToAPI and FromAPI helpers. 2020-06-30 cwallez@chromium.org dawn_wire: Remove client/ApiProcs_autogen.h 2020-06-30 cwallez@chromium.org dawn_wire: Make ApiProcs call into objects directly. 2020-06-30 cwallez@chromium.org dawn_wire/client: Encapsulate all queue/fence-related logic If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1099621 Tbr: cwallez@google.com Change-Id: Ia2ab319bf2efa8604c14abde6a9a92ce0e163fa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276185Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1593539505-1242fb6afac1e074d04c68b7772a687abe4506af.profdata to chrome-mac-master-1593561487-f93d00b844fcb3a1b3a03cdb0ab1966b81282397.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I2b2b394231be77ffafad3d3b05595c8889c77b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276766Reviewed-by:
-
danielng authored
instead Removing the prefs for camera and microphone permissions, as they are now being handled by the Plugin VM manager instead (to remove persistency). Testing: Ran "*PluginVm*" unit tests and tested on DUT locally Bug: 1071872 Change-Id: I9d2aed1715541f2d584349bb411d254a1384ff7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275580 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
David Bienvenu authored
TBR=dfried@chromium.org Bug: 1101156 Change-Id: Ie75cfc36621166578a014b5e8290adf87bfe41dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277181Reviewed-by:
David Bienvenu <davidbienvenu@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#784261}
-
Xing Liu authored
This CL does the following: 1. Implements the checkbox. 2. Implements the edit location text, which triggers location dialog. 3. Make download later dialog owns a date time picker, so other callers can share the glue code between later dialog and date time picker. 4. Lots of tests added, lots of code refactored. TBR=dtrainor@chromium.org Bug: 1099989,1078454 Change-Id: I3dd53c0a0694c91789398382c6deb11fbfe8006d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268467Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |ComputeNGCaretPosition()| to return valid |NGCaretPosition| for inline boxes in RTL and pass the test[1] for enabling EditnigNG. Before this patch, |ComputeNGCaretPosition()| to return position relative to left of inline box of specified DOM position. Example: <div dir=rtl><bdo id=box1 dir=rtl>ABC</bdo>><bdo id=box2 dir=rtl>DEF</bdo> => ComputeNGCaretPosition("ABC"@3) Before: "DEF"@0 After: "ABC@3" [1] editing/caret/caret-height-multi-line.html Bug: 707656 Change-Id: I785f87ca7b18f05a55bd809b6b390d68dac89c8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275742 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: -
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3778c0ae..d0779351 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3014156923af78117858521fa52a0baf98b861e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276483Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784258}
-
David Van Cleve authored
Currently, fetch's request_conversion.cc swaps out the initiators from files and opaque origins, replacing the initiator with a new opaque origin. Switching this to derive an opaque origin will preserve precursor information so that subsequent decisions can be based on, for instance, whether a request came from a file (or whether a request came from an opaque frame with an HTTPS precursor). Bug: 794098 Change-Id: I4f3d6d85e60afd9dda283a54501459705d52d958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242635Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#784257}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: Ifa946ad268b0197368d6f9694a69976eb14d752a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276817 Auto-Submit: Robert Sesek <rsesek@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#784256}
-
Ali Juma authored
This adds SafeBrowsingAvailableOnIOS as one of the features enabled by IOSSSLCommittedInterstitials, to match the way that the features are being rolled out together. Bug: 1034113 Change-Id: If7bd5abadf32277ea8a13c24daee949c2236b3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275486Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#784255}
-
