- 18 Jun, 2018 40 commits
-
-
clamy authored
This CL is part of a serie of CLs to remove usage of the deprecated method NavigationController::GetActiveEntry. Bug: 273710 Change-Id: I28d733a8f7fd7935b2cae8f7bea7d96be5370e00 Reviewed-on: https://chromium-review.googlesource.com/1102500 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#568011}
-
Marc Treib authored
It's mostly failing on "Win7 Tests (dbg)(1)" TBR=rockot@chromium.org Bug: 853733 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I667d434cc382d96a6e5ab37b9697f40e4506a690 Reviewed-on: https://chromium-review.googlesource.com/1104435Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568010}
-
Adam Rice authored
CallExtraOrCrash is a function to call into V8 Extras and crash if it fails. Unfortunately, calling into V8 Extras can fail under normal conditions such as stack overflow and Worker destruction, causing a lot of unnecessary crashes. Remove CallExtraOrCrash. This is a stopgap change designed to be mergable to version 68. It avoids major code restructuring but as a result lacks robust encapsulation. The general strategy is to pass a boolean pointer to functions in ReadableStreamOperations that call into V8 Extras. If the internal call fails, the boolean is set to true, and the call returns a default value. BodyStreamBuffer keeps the boolean as member variable. Once a call to a V8 extra function fails, the boolean is set and no more calls will be made. This is to avoid us taking action based on information that is incorrect. For Tee() and the from-stream version of the BodyStreamBuffer constructor, we use an ExceptionState object instead. In these cases, it is straightforward to pass through ExceptionState object from the Blink bindings. This allows the failure to be propagated safely back to Javascript. Conversely, DefaultReaderRead() has been switched from using ExceptionState to using an error-signalling bool. This is because its callers do not have access to a real ExceptionState object. Previously callers used a NonThrowableExceptionState, but this was not suitable as DefaultReaderRead() can throw. BodyStreamBuffer mostly wraps access to ReadableStreamOperations, so some degree of encapsulation has been retained. 7 new layout tests exercise each of the deterministically reachable crashes, using stack overflows. Because they depend on stack layout and whether DCHECKs are enabled, they only hit the crashes in particular environments. Bug: 829790, 849312 Change-Id: I47481b33a47b418dc6916e3b4311e60b5fd89e3d Reviewed-on: https://chromium-review.googlesource.com/1097047 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#568009}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ae92f3c98fbe..15590d1a9bee git log ae92f3c98fbe..15590d1a9bee --date=short --no-merges --format='%ad %ae %s' 2018-06-18 yueherngl@google.com nami: mark paladin as important (not experiment) 2018-06-18 yueherngl@google.com dragonegg: add new paladin Created with: gclient setdep -r src/third_party/chromite@15590d1a9bee The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=chrome-os-gardeners@chromium.org Change-Id: Ie533bcbdb822b30e8848b47897cfe2dd3c795a0a Reviewed-on: https://chromium-review.googlesource.com/1104397Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568008}
-
Christian Dullweber authored
Make BrowsingDataCookieHelper compatible with the network service by converting it to use CookieManager. Bug: 843995 Change-Id: I92db772d7ab63ca51fbaabd618f6b4d77fd784b3 Reviewed-on: https://chromium-review.googlesource.com/1101022 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#568007}
-
Rune Lillesveen authored
We incorrectly did an override with kForce for ::first-letter recalc when we were already recalculating style for re-attachment (kReattach). This caused crashes in FirstLetterPseudoElement::DidRecalcStyle. Bug: 853621, 853476, 853471, 853470, 853433, 853411 Change-Id: Id34e6bdbaaeb3b4933a3e963b68f0bffcda0e40e Reviewed-on: https://chromium-review.googlesource.com/1104176 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#568006}
-
Justin Donnelly authored
These features (tab switch suggestions, new answer layout and rich entities) all work without the MD Refresh UI, but the layout looks weird. It's not something we'd want to launch. So this change disables them if the MD Refresh UI is not also enabled. The intent in taking this approach (vs. just enabling the correct combination of flags manually or via experiment config) is two-fold: 1. Ensure that when we start experiments on these, if the MD Refresh UI is turned off, these features will automatically be turned off as well for users in the experimental group. 2. Prevent people from enabling the new features without MD Refresh and then filing bugs for a configuration that we don't intend to support. Change-Id: Ie29ba598ae04a4d5e14437d0dd8d5e189815ef40 Reviewed-on: https://chromium-review.googlesource.com/1103152Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#568005}
-
Egor Pasko authored
The http://crbug.com/747130 is fixed, hence URLLoaderInterceptor should work for frame requests - remove the obsolete comment. Also fix a typo in a comment nearby. Seems like a typo to sincerely yours, non-native speaker. Bug: 747130 Change-Id: I7d88a09ce459d69348c3751fae845b5152324dff Reviewed-on: https://chromium-review.googlesource.com/1104431Reviewed-by:
-
Ella Ge authored
This CL adds scroll predictor in compositor thread under flag kResamplingScrollEvents. design doc: https://docs.google.com/document/d/1g6eGYdLZKznF3sCiktc5BbAPeiudWk8xTzx3qdrxowI/edit# Bug: 836352 Change-Id: Iecfad7ad75dd4b871426e00a2f2d542996544b07 Reviewed-on: https://chromium-review.googlesource.com/919662 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568003}
-
Dave Tapuska authored
Add the ability to fetch the stale while revalidate field out of the cache control header. BUG=348877 Change-Id: I7e6132b71c10c462019687a150e259e02fe9c332 Reviewed-on: https://chromium-review.googlesource.com/1101242 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#568002}
-
Balazs Engedy authored
Bug: 847985 Change-Id: Ibc8ac6cda1aaf9bfb519ba44a4ef748cc3891e1f Reviewed-on: https://chromium-review.googlesource.com/1101681Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568001}
-
David Roger authored
This CL converts almost all the remaining code to use AccountConsistencyModeManager. There are a few calls left in tests and debugging code, which will be converted in a follow-up CL. TBR=stevenjb Bug: 777774 Change-Id: Ic2da79f6b332880e2143425c91ab50322b9d542f Reviewed-on: https://chromium-review.googlesource.com/1099069 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#568000}
-
Emily Hanley authored
TBR=charliea@chromium.org NOTRY=true Bug: 853738 Change-Id: I9939821fddae4cdbba93d89fc47a089fbefee842 Reviewed-on: https://chromium-review.googlesource.com/1104307Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#567999}
-
Hans Wennborg authored
Bug: none Change-Id: I3622122b52039f04028627505ca432b154cad4da Reviewed-on: https://chromium-review.googlesource.com/1104345 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#567998}
-
Moe Ahmadi authored
After crrev.com/c/1078871 that updated FormSuggestionView and FormSuggestionLabel to use AutoLayout, the Google Pay logo stopped animating. This CL fixes that regression and also changes the code slightly so that the subviews are more lazily created. Bug: 852890 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5388a3c4a7df2819e14b5772368e07f16c98564e Reviewed-on: https://chromium-review.googlesource.com/1101543 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#567997}
-
Josh Karlin authored
Bug: 853283 Change-Id: I67cd9784a6b4fb7fa3b6279c590b9e4f42ba2e0f Reviewed-on: https://chromium-review.googlesource.com/1104383Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567996}
-
Francois Doray authored
This CL adds a function that determines if a state transition is valid in TabLifecycleUnit. This will help us ensure that things work properly as we add more possible state transitions (e.g. periodic unfreeze). Bug: 775644 Change-Id: I89e90021415f68edbed1aca1d6f0052057cd44e9 Reviewed-on: https://chromium-review.googlesource.com/1097550Reviewed-by:
-
Dominic Farolino authored
This CL removes layout tests for deprecated console methods as well as removes expectation files for failing console WPTs that assert the non-existence of these methods. These need removed so that the v8 auto-roll with the removed console methods don't fail the chromium layout tests. Also this CL removes the test expectations for console WPTs that assert the non-existence of these deprecated methods, but marks the tests as skipped for now, until the v8 changes are in chromium. R=kozyatinskiy@chromium.org Bug: 706804 Change-Id: If11e0c6a26d6ccc29474fb0148900d034cd40b86 Reviewed-on: https://chromium-review.googlesource.com/1103937Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Cr-Commit-Position: refs/heads/master@{#567994}
-
Takuto Ikuta authored
Recently, I saw some tests has large shard duration. http://shortn/_XYVwYNWZJb This CL increases the number of shard so that tests in CQ has 15 minutes average shard duration. Change-Id: If4011de7a6c3c6f98e98bc70ba2fa9a87aca8f90 Reviewed-on: https://chromium-review.googlesource.com/1104277Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#567993}
-
Mustaq Ahmed authored
Bug: 802291 Change-Id: I2b8e7ee5cd61cc31e07bd7d2ed6da69a43743b80 Reviewed-on: https://chromium-review.googlesource.com/1097796Reviewed-by:
-
Marc Treib authored
It's too slow and times out. TBR=fukino@chromium.org Bug: 851988 Change-Id: I868d846e3fae5f7dd16b2a2c7203602008221396 Reviewed-on: https://chromium-review.googlesource.com/1104424Reviewed-by:
-
Douglas Creager authored
This updates the Reporting implementation to include the naming changes in https://github.com/WICG/reporting/issues/72. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2446a8baaf512760949ac5bcaae56088def7d600 Reviewed-on: https://chromium-review.googlesource.com/1073060 Commit-Queue: Douglas Creager <dcreager@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#567990}
-
Daniel Nicoara authored
The curent implementation tries to order one window in a list of potentially unordered windows. The window list is not always ordered since we never order hidden windows. Use stable_sort to order all windows by ID. Between windows with the same ID, promote the window currently becoming visible. BUG=NONE TEST=Verified on device and wrote unittests to cover window ordering. Change-Id: I52a760a6fbb84752a523c89ba39963f443ab4712 Reviewed-on: https://chromium-review.googlesource.com/1103296Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#567989}
-
Bence Béky authored
Bug: 807724 Change-Id: I018eb874f2e9097dba9d8acdf58d6a18c569cc9d Reviewed-on: https://chromium-review.googlesource.com/1100354Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#567988}
-
Jared Saul authored
(Also alphabetized the autofill category) Change-Id: I18f03d1404c166ce5d46c8abd7db935aff360615 Reviewed-on: https://chromium-review.googlesource.com/1103587 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#567987}
-
Marc Treib authored
TBR=minch@chromium.org NOTRY=true Bug: 838756 Change-Id: I3cf207f31b7063f64c87d7cc0d8a93e6299ed5cd Reviewed-on: https://chromium-review.googlesource.com/1104418Reviewed-by:
-
Ioana Pandele authored
This dialog is prompted when the user taps the password generation button in the keyboard accessory or in the accessory sheet and is meant to replace the password generation popup. It is currently made to display the generated password and 2 buttons to accept and reject it. It will (not included in this CL) also display the explanatory text that is currently present in the generation popup. Bug:835234 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I98107745678c153819f00555ebdb61917121606a Reviewed-on: https://chromium-review.googlesource.com/1064611 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#567985}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f3ce003c2baa..d994c8643744 git log f3ce003c2baa..d994c8643744 --date=short --no-merges --format='%ad %ae %s' 2018-06-18 perezju@chromium.org [soundwave] Include request made in RequestError Created with: gclient setdep -r src/third_party/catapult@d994c8643744 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2bc78ab8bff01d5f9f281569a33c67d23d6690d1 Reviewed-on: https://chromium-review.googlesource.com/1104097Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567984}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I422994c678006f6b009bf50fbe9fee8645be0cfe Reviewed-on: https://chromium-review.googlesource.com/1104297 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567983}
-
Mohamed Amir Yosef authored
This CL adds support for importing and exporting sync metadata to the BookmarkModelTypeProcessor. Sync metadata are compiled into BookmarkModelMetadata proto. This proto is used to communicate the sync metadata out and into the processor. This CL prepares for another CL that would actually persist/load the sync metadata to/from disk. Bug: 516866 Change-Id: I0a4af54383ac336a759c0504e4feee1ff1bda7c1 Reviewed-on: https://chromium-review.googlesource.com/1098918 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#567982}
-
Taiju Tsuiki authored
This reverts commit c4662e1a. Reason for revert: This seems to gain the binary size by 0.3~0.9% on mac and win. Original change's description: > Oilpan: Reduce the size of heap_page.h. > > heap_page.h is used in 6,000+ compilation units, and this CL reduces its > estimated expanded size from 1.72MB to 1.40MB. > > Bug: 242216 > Change-Id: I0f53c3f57511378289a841b89c6e01c4a2748d4a > Reviewed-on: https://chromium-review.googlesource.com/1104080 > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567972} TBR=keishi@chromium.org,tkent@chromium.org Change-Id: I54c95f8102aadf8459a833db0d27b970d291eb93 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 242216, 853703 Reviewed-on: https://chromium-review.googlesource.com/1104357Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#567981}
-
clamy authored
This CL is part of a serie of CLs to remove usage of the deprecated method NavigationController::GetActiveEntry. Bug: 273710 Change-Id: I98d76530c98b62f9c1a5cdd729aea52d39b13575 Reviewed-on: https://chromium-review.googlesource.com/1102679Reviewed-by:
-
Florent Castelli authored
RangeErrors are not DOMException and the function we used to translate them to DOMException couldn't handle anything else. Using an ExceptionState, we can properly reject the promises with the right type of exception. Bug: 849214 Change-Id: I14ad11ba43910a83770d66c6976509c0feba3408 Reviewed-on: https://chromium-review.googlesource.com/1097325 Commit-Queue: Florent Castelli <orphis@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
-
Dave Tapuska authored
This reverts commit 7223839e. Reason for revert: Possibly per regression: https://bugs.chromium.org/p/chromium/issues/detail?id=852988 Original change's description: > Silence 64 to 32 bit truncation errors on WTF strings. > > strlen returns size_t which can be 64 bits yet all of the WTF strings > use 32 storage lengths. Add a helper function string_unsigned which > returns the strlen with a SafeCast to unsigned. Place it in an > implementation file to avoid increase in binary size due to inlining. > > BUG=588506 > > Change-Id: I3b5025c1fee9b1eda9cd017af6bdfc66d808e802 > Reviewed-on: https://chromium-review.googlesource.com/1096133 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuta Kitamura <yutak@chromium.org> > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566415} TBR=yutak@chromium.org,haraken@chromium.org,dtapuska@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 588506 Change-Id: I85d200afa3816ffefdbfa34ad86f8bddc168ccb1 Reviewed-on: https://chromium-review.googlesource.com/1101761Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#567978}
-
Thiemo Nagel authored
Also add a privacy subfolder and an OWNERS file. BUG=853154 Change-Id: I1b527c9a7244eb932677897a46774463409ac4c0 Reviewed-on: https://chromium-review.googlesource.com/1102418 Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#567977}
-
Matt Falkenhagen authored
It was using two data members to determine if there was a controller. It only needs one. Minor cleanup for the linked bug. Bug: 850839 Change-Id: I1d816453047721d79503d47defc8f8cb3e25c7d9 Reviewed-on: https://chromium-review.googlesource.com/1103981 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/16e54609..f2bcc477 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I18c46bb079d50642dfeb5e38f6bfb1d5777dc186 Reviewed-on: https://chromium-review.googlesource.com/1103943Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567975}
-
Dave Tapuska authored
The implementation isn't there yet but this flag controls whether the eventual implementation should do something or not. BUG=348877 Change-Id: I72a5a0eb2873d0a06ae5ce84c494b4d24b91434d Reviewed-on: https://chromium-review.googlesource.com/1100942 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Balazs Engedy authored
AuthenticatorRequestSheetView defines the basic structure of sheets shown in the authenticator request dialog. Each sheet corresponds to a certain step of the authentication flow, and encapsulates the controls above the Ok/Cancel buttons, namely: -- an optional `back icon`, -- the title of the current step, -- the description of the current step, and -- a view with step-specific content, filling the rest of the space. AuthenticatorRequestSheetModel will be subclassed for each step of the authenticator request UX flow, and, for each step, the subclass is going to encapsulate: (1) knowledge of the set of actions possible to the user at that step, (2) pieces of data required by views to visualise the sheet: (a) strings to use on labels/buttons rendered by the SheetView and the AuthenticatorRequestDialogView, and the state of the buttons, (b) data for additional step-specific contents rendered by SheetView subclasses, if any, (3) logic to handle user interactions with: (a) the `Back`, `Accept`, `Cancel`, buttons, even though the latter two are actually rendered by the AuthenticatorRequestDialogView, (b) the step-specific contents, if any. For now, only a sheet with the original static content is shown. Bug: 849323 Change-Id: I8b92f180a3dc3abc901dcb2ad0200e45271416a3 Reviewed-on: https://chromium-review.googlesource.com/1097321 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:Trent Apted <tapted@chromium.org> Reviewed-by:
-
Kent Tamura authored
heap_page.h is used in 6,000+ compilation units, and this CL reduces its estimated expanded size from 1.72MB to 1.40MB. Bug: 242216 Change-Id: I0f53c3f57511378289a841b89c6e01c4a2748d4a Reviewed-on: https://chromium-review.googlesource.com/1104080Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#567972}
-
