GitLab

The StopNonTimersInBackground flag is used by scheduler to initialize
the freezable bits for tasks. This happens before Blink initialization,
so the flag wasn't set yet when initializing QueueTraits. This CL moves
the flag from runtime enabled features to blink features, which are
initialized earlier and can be checked directly during QueueTraits
initialization.

BUG: 859963

Change-Id: I62e9896cd3c75a04d23372b44e9697432d109088
Reviewed-on: https://chromium-review.googlesource.com/1159205Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Scott Haseley <shaseley@google.com>
Cr-Commit-Position: refs/heads/master@{#580540}

The recently added mocked controller delegate eliminated the need of a
deadzone to get quiescence in the scene. However, some tests where not
using it, and thus fail.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I7826885ab9a2900421b7bb2dbd49c1fbe5de4e33
Reviewed-on: https://chromium-review.googlesource.com/1161042
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580539}

Bug: 803461
Change-Id: Id66716d9aaef95c6c5cff6d549588d77037dfbbb
Reviewed-on: https://chromium-review.googlesource.com/1160761Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580538}

Change-Id: Ic00b45ead72fcaa0ec0d90d2188a9447e8bf6e02
Reviewed-on: https://chromium-review.googlesource.com/1160782Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580537}

When a unified consent child service is disabled on startup, unified
consent gets disabled.

This is a follow up to crrev.com/c/1151324.

Bug: 867480
Change-Id: Ic7cf4fdd0ebafa648954a401162ed649e1e2f40d
Reviewed-on: https://chromium-review.googlesource.com/1162160
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580536}

https://chromium.googlesource.com/angle/angle.git/+log/81f891d043cb..d69a5f124d9b


git log 81f891d043cb..d69a5f124d9b --date=short --no-merges --format='%ad %ae %s'
2018-08-03 jmadill@chromium.org Cache VertexArray::hasMappedBuffer.


Created with:
  gclient setdep -r src/third_party/angle@d69a5f124d9b

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: I962ce37ecdc021ef982ed0b8696d6666c34e7248
Reviewed-on: https://chromium-review.googlesource.com/1162102Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580535}

If a child dialog is focused, do not pass key events to the main
Print Preview page.

Bug: 869317
Change-Id: I0fd24ff715f92d39fc0f1f51a02688d630a8d219
Reviewed-on: https://chromium-review.googlesource.com/1159527
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580534}

Change-Id: I05b9c19cba0130bae74cc57f45c735d40a515c20
Reviewed-on: https://chromium-review.googlesource.com/1160856Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580533}

A refactor to enable us to fix some bugs in the interaction between
screenreader mode (TouchExplorationController) and system gestures.

  - Break the SideSwipeDetector out and instantiate it separately from
    the CastSystemGestureEventHandler.
  - Make the CastSystemGestureEventHandler responsible only for
    TAP/TAP_DOWN gestures.
  - Provide a separate dispatcher class to allow classes other than
    CastSystemGestureEventHandler and SideSwipeDetector to call it
    (for internal b/112073530)
  - Move gesture handling (including triple-tap) into a separate
    directory for cleanliness.

Bug: internal b/112073530
Bug: internal b/112073644
Test: unit tests, manual on device

Change-Id: I6593851cd1a10ee287de2dc1feaf98a5caad21f1
Reviewed-on: https://chromium-review.googlesource.com/1158615Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Ryan Daum <rdaum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580532}

We are using touch events to handle pen inputs, and when we convert
ui::touchevent to WebTouchEvent, some of the pointer properties are not
carried to WebPointerProperties. Because ui::touchevent are converted
to MotionEvent first, which does not have these attributes. Now we are
adding them to MotionEvent to pass these values to WebTouchEvent.

Bug: 867612

Change-Id: I44a262f0810791169cf2dae45c9131b8bb708927
Reviewed-on: https://chromium-review.googlesource.com/1150578
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580531}

This is a reland of 9a6c55fc

In order to address the CFI failures [1,2] causing the revert of the
initial CL, this change also de-virtualizes BluetoothUUID. BluetoothUUID
has no subclasses and is meant to use as a value type, which is why a virtual
destructor does not make sense.

[1] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/9368
[2] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2352

Original change's description:
> [Bluetooth] Make BluetoothDevice::UUIDSet a base::flat_set
>
> BluetoothDevice::DeviceUUIDs::UpdateDeviceUUIDs() makes use of
> std::set_union in order to merge advertised uuids and service uuids.
> However, std::set_union requires sorted ranges as input, which wasn't
> necessarily guaranteed before this change. When using a
> std::unordered_set the order of elements is not specified and
> std::set_union is not guaranteed to work correctly. Using a
> base::flat_set for UUIDSet instead fixes this issue. In order to prevent
> future regressions this change also replaces the usage of std::set_union
> with base::STLSetUnion performing an explicit IsSorted() check in Debug
> builds.
>
> Bug: 821766, 870208
> Change-Id: Id25711e6acf77ded9eebb6c80db5bcb2ed8a63e0
> Reviewed-on: https://chromium-review.googlesource.com/1159374
> Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580198}

TBR=ortuno@chromium.org

Bug: 821766, 870208
Change-Id: I3fc55939ff5b8b136db0d45978c5b19083adb1d9
Reviewed-on: https://chromium-review.googlesource.com/1161883Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580530}

This reverts commit 104d9bf8.

Reason for revert: Causes crashes, see https://crbug.com/870567,
https://crbug.com/870629, https://crbug.com/870643, https://crbug.com/870682. Based on the stack traces, they're all the same kind of crash, but reverting just to be safe.

Original change's description:
> Mojofy FileSystem
> 
> - Mojofies and removes all messages in file_system_messages.h.
> - Replaces FileAPIMessageFilter with FileSystemDispatcherHost.
> - Adds mojom types for FileSystemInfo and FileSystemType and adds
>   type converters to convert these types to storage::FileSystemInfo
>   and storage FileSystemInfo respectively. The storage types will be
>   replaced with the mojom types in follow up CLs.
> 
> Change-Id: I82aaf9dcb04149880e68238540766f21771d2b21
> Bug: 787281
> Reviewed-on: https://chromium-review.googlesource.com/1125316
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Victor Costan <pwnall@chromium.org>
> Reviewed-by: Joshua Bell <jsbell@chromium.org>
> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580346}

TBR=jsbell@chromium.org,kinuko@chromium.org,pwnall@chromium.org,adithyas@chromium.org

Change-Id: Id955ec9f01f6201e4de92fbdfb400f3f00109496
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 787281
Reviewed-on: https://chromium-review.googlesource.com/1162201Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580529}

This CL makes sure the ConsentBump buttons are correctly updated based
on the screen currently displayed.

Bug: 866506
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id40cee04d6b07f4556b54867344f23d88324c0e3
Reviewed-on: https://chromium-review.googlesource.com/1161864
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580528}

Bug: 829077
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I04213a57ef018e7e448974f71c0cd07d65c328ef
Reviewed-on: https://chromium-review.googlesource.com/1161107
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580527}

For instance:
$ tools/android/native_lib_memory/java_code_pages_pss.py
    --chrome-package com.android.chrome
    --app-package com.google.android.gms --verbose

to get GMSCore memory footprint inside Chrome.

Bug: 870698
Change-Id: I276a2cd7bdaee4bc6c23b978d95cc0d0ec74c6e9
Reviewed-on: https://chromium-review.googlesource.com/1162164
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580526}

This reverts commit 5dc35e99.

Reason for revert:

Causes content_browsertests / WebRtcDataBrowserTest.CanSetupLegacyCall
to run on a DCHECK failure on fake_audio_input_stream.cc:69.

Original change's description:
> Convert P2P IPCs to Mojo.
>
> Bug: 800212
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: I5d200862e81809af793d28b7751729a1824be76c
> Reviewed-on: https://chromium-review.googlesource.com/1156566
> Commit-Queue: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580378}

Bug: 870633
TBR=nasko@chromium.org,jam@chromium.org,sergeyu@chromium.org

Change-Id: I6b2e278433dc18f8fa49281bf0f7e2bf2c278cd2
Bug: 800212
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1162021Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580525}

This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1160849.
The tests are not to be merged back to M69.

Bug: 870217
Change-Id: I0bc691bb8168c9a3887ef572f1bfa15d2e5cb68f
Reviewed-on: https://chromium-review.googlesource.com/1160851
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580524}

Unlike CloudPrintProxyPolicyStartupTest, which similarly is a unit test
running in the browser_tests binary, DeviceStatusCollectorTest does not
initialize a ContentClient or a BrowserContentClient. This is causing
tests to fail while trying to land crrev.com/c/1157704, where a new
AfterStartupTask that eventually calls into a nullptr
BrowserContentClient while running this seemingly unrelated test.

BUG=None

Change-Id: Ibb4c4a9d4b8d8ecf2e243a81158341824ef4cda1
Reviewed-on: https://chromium-review.googlesource.com/1160072
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580523}

This CL simplifies and refactors a bit the GN templates
used to build the [mono]chrome[_modern]_public_XXX templates
(including APKs and bundles).

- Add build/android/docs/android_app_bundles.md to better
  explain what is going on here.

- Unsynchronized proguarding of application bundles was
  broken by the CL that introduced synchronized proguarding.
  This CL fixes it by simply making synchronized proguarding
  the default for all app bundles (when proguard_enabled is
  true). It doesn't really make sense to support regular
  proguarding, since the chances that something wrong will
  happen are too high.

  This also reduces the number of build state variants that
  need to be supported for an individual bundle module.

- The chrome_public_apk_tmpl_shared() GN template defined in
  chrome/android/BUILD.gn was not very useful and only serves
  to add some dependencies. Remove it and adjust all callers
  to add the equivalent dependency list to their |deps|
  variable instead, to simplify things.

- Remove chrome_modern_public_apk_or_module_tmpl() entirely.
  Instead, add an |is_modern| variable to
  chrome_public_apk_or_module_tmpl() that takes care of adding
  the necessary declarations corresponding to modern builds
  to the template.

- Hard-code version_name to chrome_version in
  chrome_public_apk_or_module_tmpl() since all callers define
  it to |chrome_version| anyway.

- rules.gni: Add missing variable forward, required for
  the clank/ targets only.

- Rename chrome_public_apk_tmpl() to
  chrome_public_common_apk_or_module_tmpl() to match its
  intended usage. Note that chrome_public_apk_tmpl()
  wrappers are still available to ensure the clank/ build
  doesn't break.

  Similarly, define monochrome_public_common_apk_or_module_tmpl()
  (yes, a bit long, but really only internal).

- Add documentation to various intermediate GN templates to
  make it easier to understand what's going on.

BUG=865108
R=agrieve@chromium.org, tiborg@chromium.org, yfriedman@chromium.org

Change-Id: Ia4f79429a8e32c97630c90ce126362eb7534252c
Reviewed-on: https://chromium-review.googlesource.com/1154979
Commit-Queue: David Turner <digit@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580522}

https://skia.googlesource.com/skia.git/+log/434a112d2537..da77c7f91f1d


git log 434a112d2537..da77c7f91f1d --date=short --no-merges --format='%ad %ae %s'
2018-08-03 recipe-roller@chromium.org Roll recipe dependencies (nontrivial).


Created with:
  gclient setdep -r src/third_party/skia@da77c7f91f1d

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I4cd08bc8b2dbe5e51362f89f0221eb9b567fdcc0
Reviewed-on: https://chromium-review.googlesource.com/1162101Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580521}

I've confirmed that we need to set recalc flag definitely here.
Without that, a lot of crashes would happen.

Change-Id: I6fad0f9587b3c16d92dd848eae961d7bdac49f38
Reviewed-on: https://chromium-review.googlesource.com/1161842Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580520}

Another step on the path to deprecating SigninManager. This method
replaces SigninManager::SignOut*(). See design discussion here:
https://groups.google.com/a/chromium.org/d/msg/identity-service-dev/hNrtJ_nIXJ4/6nMXfIcVBwAJ

Bug: 806781
Test: New unit tests

Change-Id: I39fe49925c980362b0cdf58db2ce961e107241b6
Reviewed-on: https://chromium-review.googlesource.com/1154985
Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580519}

The descriptions of password suggestions are now loaded and read by
Talkback (e.g. "Password for m.park@gmail.com") to uniquely identify the
single list entries.

The key icon now indicates that it toggles the password bottom sheet.

Bug: 870627
Change-Id: I2efce0c5eea06cab16702cc817f0c081af459aa6
Reviewed-on: https://chromium-review.googlesource.com/1161909Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580518}

Adds a check for the URL length and only disables clipping on URLs
longer than 800 characters.

Bug: 860790
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Idf7ccf4582a107ca61e384451dd1415b63337dc0
Reviewed-on: https://chromium-review.googlesource.com/1160491
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580517}

It's questionable whether the popup should move back to the generation state.
Curently for automatic generation it does and the bug isn't observed. For
manual generation it doesn't and therefore the editing prompt remains open.
The CL fixes that.

Bug: 870217
Change-Id: Ib9758f87208d82fd8bd52cdcd1aef664d4f2cba5
Reviewed-on: https://chromium-review.googlesource.com/1160849Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580516}

Change-Id: Iac4be6a4a32ca598f9e90a0033a651fc8a43eb62
Reviewed-on: https://chromium-review.googlesource.com/1160722Reviewed-by: Lutz Justen <ljusten@chromium.org>
Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com>
Cr-Commit-Position: refs/heads/master@{#580515}

When building using jumbo, files gets merged and
functions with the same name may end up in the same
namespace/scope and conflict. This happens for the
function UpdateMetadataForUsage.

This commit solves the issue by moving the function
to a shared util file.

Bug: 869381
Change-Id: I57b8f9c96c785a3bbfc8250f0edbe7690c3b3ff7
Reviewed-on: https://chromium-review.googlesource.com/1160482
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580514}

This Chrome flag is only for debug purpose, and it is not meant
to be turned on by default.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ib52d02611f383114e302e2e600da9397d7ff6641
Reviewed-on: https://chromium-review.googlesource.com/1158827
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580513}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7f2df29563db41980615d9b8949de9bf6479f87e
Reviewed-on: https://chromium-review.googlesource.com/1161918Reviewed-by: Elodie Banel <lod@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580512}

Update DirectoryModel.clearAndScan_ to stop requesting previous
directory's content metadata, that caused issue 867974 where we were
sending too many metadata requests.

However we still need to fetch metadata for the currently selected
directory so is available to use by menu/commands.

Change the File Manager CommandHandler to update all commands
when the metadata gets updated. This fixes the commands that should be
disabled based on metadata properties canCopy, canCut, can*.

Bug: 867974
Change-Id: I5254f70b8993a6e9b536f53543d1f3ed2ca0d87f
Reviewed-on: https://chromium-review.googlesource.com/1161843Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580511}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/091fee47..e82ab695

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I9c5ed337a080fc5a0759ea1c31e9987b3292def7
Reviewed-on: https://chromium-review.googlesource.com/1161981Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580510}

This reverts commit a445460b.

Reason for revert:

MSAN warning in USS/TwoClientBookmarksSyncTestIncludingUssTests.CreateSyncedBookmarks

See:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/11051
https://chromium-swarm.appspot.com/task?id=3f17cf427082ec10&refresh=10&show_raw=1

Original change's description:
> Reland "[Sync::USS] Bookmark sync conflict resolution"
>
> This is a reland of 553ec6da
>
> Original change's description:
> > [Sync::USS] Bookmark sync conflict resolution
> >
> > This patch addresses the problem of conflict in bookmarks upon
> > receiving a remote update for a node that has local changes.
> >
> > The general polic that is implemented is that server wins except in
> > case of deletion.
> >
> > Bug: 516866
> > Change-Id: I50a85bde068dd9414e4e22bc1a33529fb3dfffa1
> > Reviewed-on: https://chromium-review.googlesource.com/1157006
> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580436}
>
> Bug: 516866
> Change-Id: I73bb31e143aa7baadd5fa8c0afd3d91554c9aa6e
> Reviewed-on: https://chromium-review.googlesource.com/1161861
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580496}

TBR=mastiz@chromium.org,mamir@chromium.org

Change-Id: I22a2a0f518fdbefe7baa3c4840884090459e62a3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 516866, 870668
Reviewed-on: https://chromium-review.googlesource.com/1161884
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580509}

With this patch, a node rendered by LayoutNG will be highlighted with
a different color when you hover over the node in the inspector.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I648d7cfa6bfd93a7829ffb480fe029b7e64a67c9
Reviewed-on: https://chromium-review.googlesource.com/1158391
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580508}

In cases where arguments are checked using arg->Is*Type*, convert
Values using arg.As<Type>()->Value() instead of the deprecated
parameterless *Type*Value() methods.

In other cases where the type is not guaranteed coerce the conversion
uses *Type*Value(Local<Context>). Since these functions return a Maybe,
use FromMaybe() on the return value to guarantee a return value even if
the conversion could throw an exception.

Change-Id: If14cf9d4b4698bb1f24d42a6d3258121d2939d82
Reviewed-on: https://chromium-review.googlesource.com/1153247
Commit-Queue: Dan Elphick <delphick@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580507}

Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ANnafFBhReY/1Xdr53KxBAAJ

Bug: 588931
Change-Id: I6dc296734ea6b1fdf1478bea7a1e80ca8afe38ac
Reviewed-on: https://chromium-review.googlesource.com/1160644
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580506}

Previously, only V8EventListener were handled in the helper. With
crrev.com/579347 this changed and all types of V8 event listeners use
this mechanism. Their common superclass is V8AbstractEventListener which
is returned here.

Bug: chromium:870351, chromium:843903
Change-Id: I4407cf5abfddf10d644c3fd7e1add86dbfa5d5f9
Reviewed-on: https://chromium-review.googlesource.com/1161907
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580505}

In general, V8 uses some random numbers not to make their environment
non-deterministic. However, it prevents us from caching
v8_context_snapshot.bin in test runs.

This CL sets "--predictable" flag in the snapshot generator to fix
the random seed and generate identical snapshot files in every run.


Bug: 870584
Change-Id: I90e60d9636cbd31263658a6fa19c942d89442568
Reviewed-on: https://chromium-review.googlesource.com/1161853
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580504}

Bug: 856179
Change-Id: I67e4265709e034febff732cab339ae6ef19b24b7
Reviewed-on: https://chromium-review.googlesource.com/1161917Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580503}

Splitting this out of review
https://chromium-review.googlesource.com/c/chromium/src/+/1154985

Bug: 806781
Change-Id: I0221d901537e39e2c2d66adca254b3ff77df4823
Reviewed-on: https://chromium-review.googlesource.com/1160497Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580502}

R=kouhei, ksakamoto

Bug: 803774
Change-Id: Ia0543486846c137fef02f230b804e3d613c29875
Reviewed-on: https://chromium-review.googlesource.com/1161851Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580501}