- 12 Jun, 2017 40 commits
-
-
chrome://tracingsullivan authored
Compiling locally, resources.pak goes from 16744913 bytes to 14952341 (nearly 1.8MiB savings). Review-Url: https://codereview.chromium.org/2933483005 Cr-Commit-Position: refs/heads/master@{#478678}
-
yusufo authored
- Disable contextual search before we go through the search engine promo check - On a WebSearch from selection, first show the search engine promo and only after that send the search intent. BUG=728891 Review-Url: https://codereview.chromium.org/2926413002 Cr-Commit-Position: refs/heads/master@{#478677}
-
marq authored
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2935713002 Cr-Commit-Position: refs/heads/master@{#478676}
-
nednguyen authored
Revert of Remove find_dependencies script (patchset #1 id:1 of https://codereview.chromium.org/2932213002/ ) Reason for revert: find_dependencies is still used. Original issue's description: > Remove find_dependencies script > > BUG=chromium:728177 > > Review-Url: https://codereview.chromium.org/2932213002 > Cr-Commit-Position: refs/heads/master@{#478658} > Committed: https://chromium.googlesource.com/chromium/src/+/e5ee4f9d1a7815c320dadb315675449a710c19aa TBR=charliea@chromium.org,stevenjb@chromium.org,achuith@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:728177 Review-Url: https://codereview.chromium.org/2933163002 Cr-Commit-Position: refs/heads/master@{#478675}
-
Eugene Ostroukhov authored
These tests were never ran as they were stashed to a folder named resources. Bug: Change-Id: I8b8c7bd426ce3b25b3a4a623ad5a1fed4800e1c9 Reviewed-on: https://chromium-review.googlesource.com/529904 Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#478674}
-
chaopeng authored
SetViewportStyle(kMobile) gives tests default Android viewport style setting. This makes Blink fallback to the 980px layout width in the absence of a viewport meta tag. BUG= Review-Url: https://codereview.chromium.org/2934853002 Cr-Commit-Position: refs/heads/master@{#478673}
-
Marc Treib authored
Semi-related cleanup: Merge the DefaultSearchProviderIsGoogle implementations between search.cc and local_ntp_source.cc. Bug: 583292 Change-Id: I47f0a2b1eeb2dfd6e117e81b332a44f09b7e8ee8 Reviewed-on: https://chromium-review.googlesource.com/527437Reviewed-by:
Chris Pickel <sfiera@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#478672}
-
Theresa Wellington authored
If BottomSheet#setSheetState() is called with SHEET_STATE_HALF on a small screen, change the target state to SHEET_STATE_FULL since half state is not valid. BUG=726012 Change-Id: Ie14738718954e4ac77273708ae5c2f3a610a2603 Reviewed-on: https://chromium-review.googlesource.com/531345 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#478671}
-
Theresa Wellington authored
When toggling accessibility mode, if the overview mode is showing we hide it and then open a new tab (see ChromeTabbedActivity#onAccessibilityModeChanged()). In Chrome Home, if the NTP UI is showing then the overview mode is technically showing. Prior to this patch, when ChromeTabbedActivity tried to open a new tab, we would "show" the bottom sheet new tab UI but since the bottom sheet was already opened we never finished showing the new UI (which currently consists of showing the regular toolbar). This patch updates the logic in BottomSheetNewTabController to finishing showing the NTP UI immediately if the bottom sheet is already open when BottomSheetNewTabController#displayNewTabUi() is called. BUG=731147 Change-Id: Ief2d8c738f2c96f34f293ea29e41d8a0ab69b275 Reviewed-on: https://chromium-review.googlesource.com/530077 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#478670}
-
nrpeter authored
Origional CL (2495353003) was rolled back by sheriff due to flaky test. This initial patchet is a direct patch of 2495353003. Second patchset contains the fix. chrome.webRequest support for ExtensionSettings -If URL or Origin matches an ExtensionSettings protected host, the event will not be dispatched to that extension / app. BUG=731269 patch from issue 2495353003 at patchset 400001 (http://crrev.com/2495353003#ps400001) Review-Url: https://codereview.chromium.org/2934583002 Cr-Commit-Position: refs/heads/master@{#478669}
-
Jeremy Roman authored
It is already in use in base, and is the standard replacement for our similar atomic operations in base and wtf. Because the C++ memory order is subtle, I'd suggest that classes should seldom use it directly, but it seems like it's no worse than base/atomicops.h and wtf/Atomics.h in this regard. Change-Id: I09f4b7448d4724c42a4813acd88f2f00e467bed5 Reviewed-on: https://chromium-review.googlesource.com/523122Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#478668}
-
Evan Stade authored
Bug: 731688 Change-Id: I4c42adc0e5a11dae0486824fc7c0754413f601c8 Reviewed-on: https://chromium-review.googlesource.com/530066Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#478667}
-
shivanisha authored
Screenshot attached in the bug. BUG=689992 Review-Url: https://codereview.chromium.org/2930753002 Cr-Commit-Position: refs/heads/master@{#478666}
-
newcomer authored
UI tests are not yet implemented, waiting on final behavior from UX. Enable the new launcher with --enable-features=EnableFullscreenAppList BUG=721781 Review-Url: https://codereview.chromium.org/2898743002 Cr-Original-Commit-Position: refs/heads/master@{#478372} Committed: https://chromium.googlesource.com/chromium/src/+/01b3ff8dd7b21723108b7802164f3a8fa64dabce Review-Url: https://codereview.chromium.org/2898743002 Cr-Commit-Position: refs/heads/master@{#478665}
-
droger authored
This is a refactoring/cleanup, to prepare for DICE response handling. BUG=730589 Review-Url: https://codereview.chromium.org/2925083002 Cr-Commit-Position: refs/heads/master@{#478664}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1c02d65fcbf3..a5ece949fa04 $ git log 1c02d65fc..a5ece949f --date=short --no-merges --format='%ad %ae %s' 2017-06-12 nednguyen Move Annie to emeritus OWNER Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I6eecc5acf7f6b0e02f6b379a9caf845a02d1661f Reviewed-on: https://chromium-review.googlesource.com/531107 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#478663}
-
floppymaster authored
Update instructions to generate ICU header lists Update header list for unbundling ICU 59 Bug: https://bugs.gentoo.org/619796#c2 Review-Url: https://codereview.chromium.org/2935603002 Cr-Commit-Position: refs/heads/master@{#478662}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5143f2f3763b..fc3341632fc0 $ git log 5143f2f37..fc3341632 --date=short --no-merges --format='%ad %ae %s' 2017-06-12 mtklein port encode_bitmap_for_png() to SkRasterPipeline 2017-05-15 halcanary SkPDF: consolodate glyph runs on BUILD_FOR_WIN 2017-06-09 ethannicholas added SPIR-V RelaxedPrecision 2017-06-09 ethannicholas fixed issue with SkSL dead code elimination 2017-06-12 mtklein only SkHalfToFloat_finite_ftz(uint64_t hs) is called Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: Ic832bc9bbf5c0ca20b9b6cd57a3b34d4a07a368c Reviewed-on: https://chromium-review.googlesource.com/531264Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#478661}
-
domlaskowski authored
The cursor scale and rotation must be updated on pointer enter, even though neither the surface nor the hotspot changed. BUG=730843 TEST=caroline: Cursor is not stale on pointer enter. Review-Url: https://codereview.chromium.org/2935753002 Cr-Commit-Position: refs/heads/master@{#478660}
-
marq authored
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2932333002 Cr-Commit-Position: refs/heads/master@{#478659}
-
nednguyen authored
BUG=chromium:728177 Review-Url: https://codereview.chromium.org/2932213002 Cr-Commit-Position: refs/heads/master@{#478658}
-
khushalsagar authored
We already skip these layers during UpdateDrawProperties to prevent crashes. Mark these layers as non-drawing so they are skipped by the rest of the system. BUG=730020 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2925213002 Cr-Commit-Position: refs/heads/master@{#478657}
-
Geoff Lang authored
https://chromium.googlesource.com/angle/angle.git/+log/982f6e0..0492d44 BUG= TBR=jmadill@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ie238aa7b0f34193e94a5c86da50bcb9b9764d971 Reviewed-on: https://chromium-review.googlesource.com/531106Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#478656}
-
Mike Baxley authored
A lot of underlying helpers have been updated. I ran this 150 times locally with no failures. Setting to FLAKY_ to confirm on the bots. Bug: 631078 Change-Id: I12667d8dd2751c7fe2e8472b94c5f8386f259a1d Reviewed-on: https://chromium-review.googlesource.com/530097Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#478655}
-
horo authored
BUG= Review-Url: https://codereview.chromium.org/2936543002 Cr-Commit-Position: refs/heads/master@{#478654}
-
Dave Tapuska authored
Ensure implementations that cast InputRouter to InputRouterImpl are only doing it where necessary. Add an additional virtual interface to InputRouter so the touch action can be accessed without a cast to the implementation class. The LegacyInputRouterImpl is largely tied to Chrome IPC. With moving Input messages to be based on mojo messages this class needs to be rewritten. BUG=722928 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I97496956bb1547bff5abb145a1a015fec8d0fcb1 Reviewed-on: https://chromium-review.googlesource.com/529408 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#478653}
-
sebmarchand authored
BUG=689520 Review-Url: https://codereview.chromium.org/2888743002 Cr-Commit-Position: refs/heads/master@{#478652}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4a77d640..f1ec7517 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2928403002 Cr-Commit-Position: refs/heads/master@{#478651}
-
stkhapugin authored
Returning scoped_nsobjects is against the philosophy of autoreleased objects being passed around. Refactoring methods and functions vending scoped_nsobjects allows for a cleaner transition to ARC later. This is CL 1/5. BUG=None TEST=None Review-Url: https://codereview.chromium.org/2934843002 Cr-Commit-Position: refs/heads/master@{#478650}
-
Luke Zielinski authored
TriggerManager will now store ThreatDetails that it creates in a map keyed by the WebContents that data collection is happening on. In the future this map will be multi-level, so other types of data collectors can run on a given tab. Also added unit tests for trigger manager BUG=730646 Change-Id: Iec6ef3c59fcd7b838f929fc7fe43e99c3c745cc7 Reviewed-on: https://chromium-review.googlesource.com/525854 Commit-Queue: Luke Z <lpz@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Paweł Hajdan Jr. <phajdan.jr@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#478649}
-
Javier Fernandez authored
We need to add a new case for breaking out empy list items when they are at the start of an editable area. Since list items can be also inside table cells, we need to consider this kind of elements as well. Bug: 731621 Change-Id: If2cfc2bd926dc30004e92b18712d8167db7241fe Reviewed-on: https://chromium-review.googlesource.com/530224 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#478648}
-
jinho.bang authored
According to the spec[1], |methodData| and |modifiers| attributes should be FrozenArray instead of sequence. [1] https://w3c.github.io/payment-handler/#the-paymentrequestevent BUG=661608,720027 Review-Url: https://codereview.chromium.org/2934703002 Cr-Commit-Position: refs/heads/master@{#478647}
-
tzik authored
This CL flips `use_once_callback` flag on the Mojo code generator, and fixes all compile errors after it. After this CL, Mojo interfaces in //url starts using base::OnceCallback instead of base::Callback on its return value handling. The migration recipe was: - Convert pass-by-ref callback objects to pass-by-value. - Use std::move() to forward it to other consumer, or to invoke it with Callback::Run(). - Handle wherever copies are required manually. - Check if the conversion doesn't change the semantics. As the transfer and invocation clobber the callback object, care about use-after-move. It's considered safe to consume almost scoped-out callback. Bug: 714018 Change-Id: Ic41ddd3bae3a566e27ab0035e55d7a4f479d81a0 Reviewed-on: https://chromium-review.googlesource.com/527838Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#478646}
-
hlundin authored
The feature has been launched. BUG=672476 Review-Url: https://codereview.chromium.org/2931083002 Cr-Commit-Position: refs/heads/master@{#478645}
-
Ben Wagner authored
Set the SK_FREETYPE_MINIMUM_RUNTIME_VERSION build flag when the use_system_freetype gn flag is false. Currently the build flag is only set when is_win or is_mac, but this needs to be set any time it is known that FreeType will be built into the resulting binary. In particular this is desired for Android and WebView, but also for desktop Linux. BUG=chromium:715429 Change-Id: Ie5e425b0b347caf51400c5522a42e8a88605c147 Reviewed-on: https://chromium-review.googlesource.com/524185Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#478644}
-
Devlin authored
This reverts commit 51e98fac. Reason for revert: New tests (MediaStreamConstraintsUtilAudioTest.ValidGeometry) are failing: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.win%2FWin7_Tests__dbg__1_%2F60774%2F%2B%2Frecipes%2Fsteps%2Fcontent_unittests%2F0%2Flogs%2FMediaStreamConstraintsUtilAudioTest.ValidGeometry__x2f_0%2F0 Original change's description: > SelectSettings algorithm for audio constraints. > > This is intended to be used in getUserMedia to implement spec-compliant > audio constraints processing. > > BUG=657733 > > Change-Id: Ida1bc5561b16b0c5ac1628c19c71fb8f0b5a33fd > Reviewed-on: https://chromium-review.googlesource.com/517782 > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Henrik Boström <hbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#478607} TBR=miu@chromium.org,hbos@chromium.org,guidou@chromium.org,jochen@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=657733 Change-Id: I9c9e9f6a9b0ad464c550443e273409feb4bd6ec7 Reviewed-on: https://chromium-review.googlesource.com/531126Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#478643}
-
Luke Halliwell authored
CHECK macro strings are dropped in official builds to save space. BUG=594632 Change-Id: Ic53faaa7480fa3c72a75e9af9c4a658cf05b4cc4 Reviewed-on: https://chromium-review.googlesource.com/530103Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#478642}
-
olka authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/5c4d199..f75b6fa $ git log 5c4d199..f75b6fa --date=short --no-merges --format=%ad %ae %s 2017-06-12 danilchap@webrtc.org Use rtp_header_extension_map.h instead of rtp_header_extension.h 2017-06-08 danilchap@webrtc.org Update expectation of OneBitrateObserverTwoRtcpObservers test: Use different media ssrcs for different RtcpBandwidthObservers 2017-06-12 henrik.lundin@webrtc.org ACM tests: separate checksums for Android ARM64 clang and non-clang 2017-06-12 perkj@webrtc.org Split rtc_task_queue target. Add separate target for sequenced_task_checker and weak_ptr. This is to make it possible to override the rtc_task_queue target only. 2017-06-09 andersc@webrtc.org List all device resolutions in AppRTCMobile settings 2017-06-07 magjed@webrtc.org Update Android video buffers to new VideoFrameBuffer interface 2017-06-12 eladalon@webrtc.org s/WebRtcVideoChannel2/WebRtcVideoChannel and s/WebRtcVideoEngine2/WebRtcVideoEngine 2017-06-12 ilnik@webrtc.org Make rtc_event_log2text output header extensions 2017-06-11 tschumim@webrtc.org Reland Refactored incoming bitrate estimator. 2017-06-07 magjed@webrtc.org Update webrtc/test to new VideoFrameBuffer interface 2017-06-10 magjed@webrtc.org Revert "Revert "Update video_coding/codecs to new VideoFrameBuffer interface"" 2017-06-09 kjellander@webrtc.org Enable webrtc_nonparallel_tests on iOS simulator 2017-06-08 aleloi@webrtc.org Remove default impl of Attach/DetachAecDump. 2017-06-09 ossu@webrtc.org Fix Channel::GetSendCodec when used together with SetEncoder. 2017-06-09 magjed@webrtc.org ObjC: Rename VideoToolbox/decoder.cc to VideoToolbox/decoder.mm 2017-06-09 stefan@webrtc.org Use the configured remote ssrc instead of relying on the first received packet RtpStreamReceiver. 2017-06-09 adam.fedor@gmail.com Ensure the openGLContext is current before trying to reshape the viewport 2017-06-09 nisse@webrtc.org Rename class RtpStreamReceiver --> RtpVideoStreamReceiver. 2017-06-09 kthelgason@webrtc.org Create a UIApplication when running tests on iOS. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2933843002 Cr-Commit-Position: refs/heads/master@{#478641}
-
Alexander Timin authored
Turn on ExpensiveBackgroundTimerThrottling by default, but leave the ability to turn it off quickly via Finch. This patch also removes now-unneeded plumbing, given that now we can access field trial parameters from a renderer process. BUG=639852 R=jochen@chromium.org,haraken@chromium.org,alexclarke@chromium.org,skyostil@chromium.org Change-Id: I8e3e342dd5f15a7f011fbe5d815f83b6fa46e124 Reviewed-on: https://chromium-review.googlesource.com/529109Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#478640}
-
rsleevi authored
As noted on https://groups.google.com/a/chromium.org/forum/#!topic/ct-policy/M-rhwDQ1h9E , the log has failed to abide by the uptime requirement. BUG=731836 TBR=eroman@chromium.org Review-Url: https://codereview.chromium.org/2932093002 Cr-Commit-Position: refs/heads/master@{#478639}
-