- 18 May, 2020 40 commits
-
-
Jiewei Qian authored
The original CL that introduced the install duration metric contains one typo, which cause the reported value to be the additive inverse of the actual time. Because UMA clamps this value to be within 1 millisecond and 3 minutes, we always see 1 second in the UMA dashboard (and contradicting metrics that some installation times out). Fixed: 1083894 Change-Id: I7529bfb90fc737016d7c9948a7b8b6325ecb24a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207375 Auto-Submit: Jiewei Qian <qjw@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#769909}
-
Yusuke Sato authored
They are no longer used. This CL depends on https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2206261 BUG=b:155128030 TEST=try, arc.Boot.vm Change-Id: Iec89dac8bb9f16f7bcf3c4379261b1b8830dcbe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206496Reviewed-by:
Long Cheng <lgcheng@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#769908}
-
Sinan Sahin authored
TBR=nsatragno,manasverma Bug: 1083360 Change-Id: I7ea0d8d27b8241a171fec6452056c957cb4cc3cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207989 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#769907}
-
My Nguyen authored
As an enterprise policy is required for emoji suggest addition, adding preference's value first. Bug: 1077629 Change-Id: I4a55ddc861c4c2216742c92cd90bd0c892ae0bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2175762 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#769906}
-
Anders Hartvoll Ruud authored
This CL adds functionality which collects the observed dependencies for a given ComputedStyle. This is currently collected in three cases: - When "inherit" is applied for non-inherited properties. - When any property depending on direction/writing-mode is observed (i.e. css-logical properties). - When any CustomProperty is referenced. The properties observed in the above cases are stored in a HashSet on StyleResolverState, which is then later propagated to the MPC when the entry is added. The functionality is added behind a flag 'MPCDependencies'. Bug: 1057072 Change-Id: I59fc8d9faa7f9c417e0df0e37639840166869976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2193587Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#769905}
-
Thomas Lukaszewicz authored
This reverts commit cfba7924. Reason for revert: Tests failing on the Linux ChromiumOS MSan Tests bot: - BrailleDisplayPrivateApiTest.WriteDots - BrailleDisplayPrivateApiTest.KeyEvents https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/19188 Original change's description: > Reland: Plumb through an api to get display cell size from brltty > > |cell_size| was not initialized during the test which expected it to be. The parameter is optional according to idl, but in this context, it probably should be initialized. > > Original change > https://chromium-review.googlesource.com/c/chromium/src/+/2206198 > > TBR=dtseng@chromium.org > > Change-Id: I744c7b567cf2c4d27653f4368edc9c0f635d7d8d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207412 > Reviewed-by: David Tseng <dtseng@chromium.org> > Commit-Queue: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#769736} TBR=dtseng@chromium.org Change-Id: I07143ad331dcb627ddd4a768525c1caf5330a70c No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208103Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#769904}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/540b89ce7c0d..4d12fe258b55 git log 540b89ce7c0d..4d12fe258b55 --date=short --first-parent --format='%ad %ae %s' 2020-05-18 bsheedy@chromium.org [Devil] Parse ports with regex Created with: gclient setdep -r src/third_party/catapult@4d12fe258b55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1038789 Tbr: oysteine@google.com Change-Id: I762e0c19f8ac40ba3a8edbfc64fe7f1f8b165a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207903Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769903}
-
Lei Zhang authored
They do not appear to be used on Chrome OS, so basically revert https://crrev.com/486235 and move them back to android_chrome_strings.grd. Change-Id: Iccc3045f476c7c1f3568080acc3e1268fe0cb072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133122Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#769902}
-
David Lechner authored
This deprecates the current implementation of WriteRemoteCharacteristic. This implementation has been found to have issues when dealing with writing with response vs. writing without response. For example, most platforms look at characteristic properties to determine which to use and prefer writing with response if both are available while Android uses the OS default without looking the properties. Furthermore, there is currently no way to explicitly select writing with or without response. WriteRemoteCharacteristic will be replaced by a new implementation in crrev.com/c/2191232. However, to maintain backward compatibility we need to keep the current implementation as-is. So, we rename it to DeprecatedWriteRemoteCharacteristic. Unit tests that test this method are also renamed accordingly. Ref: https://github.com/WebBluetoothCG/web-bluetooth/issues/238 Also fix spelling of "already" in a comment while we are touching this code. Bug: 672648 Change-Id: I4469a51de960e2b6215b8f402318ee901ba5c335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191231 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#769901}
-
Reilly Grant authored
On issue 1082862 I noticed that the function IsDomainJoined() is holding the library loader lock from a background thread while a number of other threads are trying to load libraries and have gotten stuck. This macro temporarily boosts the priority of the background thread in order to prevent this kind of jank. Bug: 973868 Change-Id: Ife748cc7d42fa50525e6ddc5edf4ef95d23f10d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203234 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#769900}
-
Shu-yu Guo authored
Bug: v8:10516 Change-Id: Id26b70b70836a015d9c532b82211d63ef1b999b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2189975 Commit-Queue: Shu-yu Guo <syg@chromium.org> Auto-Submit: Shu-yu Guo <syg@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#769899}
-
Thomas Lukaszewicz authored
Disabled due to flaky timeouts. TBR=ssid@chromium.org Bug: 806988 Change-Id: I434fe809dc296ef3af2e47b6978bda8b96e7c681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208080Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#769898}
-
Rohit Rao authored
Some iOS devices enable pointer authentication, which uses the higher-order bits of pointers to store a signature. This CL strips the signature off of frame pointers before attempting to compute a module offset. The iOS documentation recommends using the ptrauth_strip() macro, but for now we will simply use a static mask. BUG=1084257 Change-Id: I760056a00cb698b3efd5370149b5b1ea77a199a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207961 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#769897}
-
Xianzhu Wang authored
Previously the test flakily failed because of the video might be empty when the test ended. Convert the test into a testharness test to avoid the flakiness. As this test just ensures it doesn't crash, we just expect the test finishes without crash. Bug: 1082820 Change-Id: I846b8cb2f66641759f8a349ef864747c1b95cb1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204830 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#769896}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/170d0709bfc1..e4ad8580e0f5 git log 170d0709bfc1..e4ad8580e0f5 --date=short --first-parent --format='%ad %ae %s' 2020-05-18 bpastene@chromium.org remote_access: Fix TypeErrors in ChromiumOSDevice. 2020-05-18 kimjae@chromium.org cros_deploy: dlcservice_util takes single id 2020-05-18 jiajia.qin@intel.com deploy_chrome: Copy libEGL.so and libGLESv2.so optionally 2020-05-18 kevinptt@chromium.org Drallion: Add factory branch builder 2020-05-18 saklein@chromium.org lib/firmware/: Update documentation and add config template. 2020-05-18 dburger@chromium.org chromeos_config update: Skip overrides if config not found. 2020-05-18 saklein@chromium.org artifacts: Fix pinned image endpoint. 2020-05-18 engeg@google.com cbuildbot: really stop retrying builds 2020-05-18 morg@google.com Raise Android PFQ time out limit to 8 hours Created with: gclient setdep -r src/third_party/chromite@e4ad8580e0f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com,bpastene@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com,bpastene@google.com Change-Id: I8d4399a5afa44ffd6fd9401e472635cdac9c4825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207902Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769895}
-
Jesse Schettler authored
Update FetchFakeFullCrosHealthdData() to create TelemetryInfo fields piecewise. This allows TelemetryInfo fields that DeviceStatusCollector does not request to be automatically excluded. Bug: None Change-Id: I271a7e94663b11ebdf368926bfb839ae3779f87f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207798 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#769894}
-
Chris Harrelson authored
Change-Id: I89470e839cd82361fe7e74d7ed3c27992b3b11eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207949Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#769893}
-
Ahmed Mehfooz authored
For dual internal mic devices, the internal mic entry in the ui is a stub. Need to tweak the visibility logic to make sure the slider for the stub internal mic shows up correctly. Bug: 1083040 Change-Id: I14d2ef7733142539ae9432bec6a265b553c62d6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205980Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#769892}
-
Vincent Boisselle authored
Bug: 1082282 Change-Id: I866ccd14c7e7661c81f50ae9d276fdb8872e0ada Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203230 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#769891}
-
David Worsham authored
Multiple presentations are deprecated, and all Fuchsia clients should move to this API. We also use the updated ViewTokenPair::New() API while in the neighborhood. :) Bug: 41929 Test: fx test root_presenter_tests; manual launch of Chromium Change-Id: I989a0c50b26aa8eedef3acc03f6ac2660f04dbad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203222Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: David Worsham <dworsham@google.com> Cr-Commit-Position: refs/heads/master@{#769890}
-
Yuke Liao authored
TBR=thakis@chromium.org Cq-Include-Trybots: chrome/try:mac-chrome Cq-Include-Trybots: chrome/try:win-chrome Cq-Include-Trybots: chrome/try:win64-chrome Bug: 1071576 Change-Id: Id9bceba48cb9644abeea38ff410adad73df2fd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208171Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#769889}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/72f39d314b92..3a999dcd95fd git log 72f39d314b92..3a999dcd95fd --date=short --first-parent --format='%ad %ae %s' 2020-05-18 kahinds@microsoft.com Fix Network Panel's throttle option dropdown background color Created with: gclient setdep -r src/third_party/devtools-frontend/src@3a999dcd95fd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1071784 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6a8a604671564bc5ea643c32f1b8001b8dd19494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207993Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769888}
-
Austin Eng authored
Bug: dawn:412 Change-Id: Ie540b95080a18af64baffe23879023159e4a15c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203709 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#769887}
-
Thomas Lukaszewicz authored
Updated expectations for the following blink_web_test on Mac: http/tests/security/offscreencanvas-placeholder-read-blocked-no-crossorigin.html TBR=chrishtr@chromium.org Bug: 1084276 Change-Id: Iaafb7d43a8f09ac6a1e8e975af96b1ccfa519d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207983 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#769886}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/8963f6066333..281f7a98285d $ git log 8963f6066..281f7a982 --date=short --no-merges --format='%ad %ae %s' 2020-05-18 fayang Deprecate gfe2_reloadable_flag_quic_bbr_use_available_min_rtt. 2020-05-18 fayang Internal QUICHE change 2020-05-15 dschinazi Remove unused kMaxReasonableInitialPacketNumber Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I6fba2c699578e3d44e38e9c8d3cb79cb6b38b2a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207623 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Bence Béky <bnc@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#769885}
-
Becca Hughes authored
If the cookie name matches then we should reset on any cookie change with that name. If there is no filter then we are limited to expiration and/or deletion. BUG=1084233 Change-Id: I55d4546547d5525f16f5cb941c1264360df2e775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207940 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#769884}
-
Yao Xiao authored
This allows computing the id from the history, as part of the FloC project (I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/DpZZG5K1PWs) The new component federated_learning contains data types (e.g. FlocID) that other layers could access (e.g. chrome/browser, services/network). Some iOS specific work are expected in the future, and will also be put into this component. Bug: 1062736 Change-Id: I3d15c9972e7712043a61cec8be8637bef190a2ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2184209 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#769883}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/75cebbe5d303..293e1d8f8ba7 git log 75cebbe5d303..293e1d8f8ba7 --date=short --first-parent --format='%ad %ae %s' 2020-05-18 johnstiles@google.com Clarify doc comments to document the meaning of 'hairline'. 2020-05-18 bungeman@google.com Cache hb_face. Created with: gclient setdep -r src/third_party/skia@293e1d8f8ba7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I57b6ec7fc80932ee45e44cd3b2769f571fecb38a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207899Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#769882}
-
David Benjamin authored
No need to allocate a new std::string everywhere. Additionally, since we're taking a suffix of the string, using substr with the default second parameter avoids having to calculate the suffix length. Bug: none Change-Id: I49919eec8b04a9bf72e435c4ffab783ba13951eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207946 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#769881}
-
Kurt Horimoto authored
This observer class allows objects to observe changes in allow list decision state. Additionally, this CL introduces a Policy enum that is used to describe the allow list decision state and updates the implementation of the allow list to use this enum. The allow list's public interface will be updated in a follow-up CL to minimize the number of files touched in this CL. Bug: 1083557 Change-Id: I003d07dfc00c12eb473656e23b8b5157cda5cb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205005 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#769880}
-
Toby Huang authored
Currently, when the parent has the "Permissions for sites, apps and extensions" toggle off, and the supervised user tries to enable an extension that requires custodian approval or has permissions increase on the chrome://extensions page, nothing happens. This CL adds an error tooltip, so the supervised user knows why the extension is force-disabled. Bug: 1068655 Change-Id: I6dcbd6cd6505c86f6b3469931172a017ccaa0923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167511 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#769879}
-
Toni Barzic authored
We're disabling the buttons on 83 to mitigate concerns with issues where users have reported that their devices unintentionally enter tablet mode (even though they're physically in clamshell). Not showing home and overview button in those cases would make the issue even worse. The exception is kukui. BUG=1084226 Change-Id: I390315dfe8f130a562e085abd51958a649581773 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207020Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#769878}
-
Shakti Sahu authored
This CL fixes the query tile section tests and reenables them. Bug: 1083182 Change-Id: I060672de4de4436f7c5a1ef591e529f658b824c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205321 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#769877}
-
Bryan Clark authored
This can be used alongside 'use_alsa = false' to build cast_shell for desktop based platforms without alsa. Bug: b/151360165 Change-Id: I21f9177009ec9665acca5ef8a5c8c8cbd7d4834a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208077 Auto-Submit: Bryan Clark <bryanclark@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#769876}
-
Martin Kreichgauer authored
This adds a map of credential registrations of FakeWinWebAuthnApi and has AuthenticatorGetAssertion() return real assertions from these credentials. This makes it simpler to write end-to-end tests that pass basic response validation. Previously, assertion responses had to be mocked, which made testing more realistic/complex responses rather arduous. Fixed: 1081450 Change-Id: I49b00eec898f734669a376715d45ac8e45d3bc3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2197475 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#769875}
-
Jian Li authored
Bug: 1081214 Change-Id: I88c24f7ca3f700c994623ee172a675798651770f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207954Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#769874}
-
Toni Barzic authored
AppsGridView creates app list item layers when handling item drag, and destroys them when they're not longer necessary (for performance). The bounds animations are started in AnimateToIdealBounds, but in certain cases, no bounds animations are run. If that is not the case, AnimateToIdealBounds should run OnBoundsAnimatorDone, to ensure the layers are destroyed if no longer necessary (if drag is not in progress). BUG=1083942 Change-Id: Ie6c71db8955aa3194727925e49c3680b36df8649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207953 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#769873}
-
Becca Hughes authored
Adds a "cookieNameFilter" feed property that will allow filtering of the cookie name that invalidates the feed. The cookie invalidation logic will be updated in a follow up CL. BUG=1084233 Change-Id: Ide7edc38ffd0690fe46e651fd305aa47e3875155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207974Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#769872}
-
Scott Violet authored
While ViewAndroidDelegate takes a ViewGroup, all other places should not be using ViewGroup, but rather View. This is because the container-view is a ContentView, and ContentView should not have children other than those added by ViewAndroidDelegate. BUG=1075585 TEST=none Change-Id: I9ba6e1b3aad6d1c780b9383de78f73e5cdebfd28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191379 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#769871}
-
Roman Arora authored
Fixed: 1076769 Change-Id: Iff73aef6e88000421be8d68cdb1d021b933341ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2176692Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#769870}
-