- 20 Oct, 2020 40 commits
-
-
Kevin McNee authored
Input largely operates in terms of RenderWidgetHosts which is what these tests actually use. We remove some uses of RenderViewHost for clarity. Bug: None Change-Id: Ifd235d21379f0f69190125a93f1b23a2c2129fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485640Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#819020}
-
Henrique Nakashima authored
This is a reland of 7002dd78 Original change's description: > Log tab switch latency histograms through RecordHistogram > > Remove JNI calls that do only that and record through the Java API. > > Bug: 1139081 > Change-Id: I6f22bca96f8e3bd2de125d6e302d12eadb5e4301 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473042 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818043} Bug: 1139081 Change-Id: I61e6b53b2acca3bd70555fceed1c2da7de0ce0a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485541Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#819019}
-
Caitlin Fischer authored
Bug: 1126640, 953480 Change-Id: I2ec62130c4fbe6d2160d8d3ee57e530111b0bce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485515Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#819018}
-
Elly Fong-Jones authored
Currently clients of the SetCan{Maximize,Minimize,Resize} setters need to remember to call Widget::OnSizeConstraintsChanged afterwards, which is obviously dangerous. Just call it from inside the setters, and then we can stop calling it everywhere else. OnSizeConstraintsChanged is idempotent (though a bit expensive) so temporarily having two calls to it won't hurt anything. This change also fixes ViewEventTestBase::GetWidget() to tolerate being called early in the object's lifecycle. Bug: 1075649 Change-Id: I11dcf39e6b1ad86f8d5f5adfa973e5fd339dd36f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485195 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#819017}
-
Patrick Noland authored
This lets us easily wire necessary dependencies to its constructor, which then lets us remove several LocationBar interface methods. ToolbarPhone/ToolbarTablet now have their coordinator set rather than instantiating it themselves. Change-Id: I8983b9c898c5676c1bdc7034de9cde2bb5de351a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472467 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
who/bttk <bttk@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#819016}
-
Anthony Cui authored
TranslateUtils.canTranslateCurrentTab performs URL checks that overlap with TranslateService::IsTranslatableURL. Consolidate the logic in these two places. Some of these checks are Android-specific. However, it is still preferable to move them to a single, shared location. This is also important for supporting logging of manual translate availability from menus, which is added in this change https://chromium-review.googlesource.com/c/chromium/src/+/2468796 Bug: 1127094 Change-Id: Ifd626f2f9c7d6c7c929e36d07c420f87314d8bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444549 Commit-Queue: Anthony Cui <cuianthony@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#819015}
-
Tarun Bansal authored
Add flag for manual testing. Bug: 1115259 Change-Id: I1fad3de254c8504edcb80659caf72c97beb2d69b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485565Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#819014}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/de50d966..e874380d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I33b0ba8c02b51d551ff8440aecd0049817821d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487360Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819013}
-
Liquan (Max) Gu authored
Bug: 1137006 Change-Id: Ib1401949fe60d0c3b6b459bdd8507bea983c40c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485641Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#819012}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1d0e7b6bbe17..7bc3356fbcb9 2020-10-20 saza@webrtc.org AEC3: Stop reporting obsolete metrics If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1140067,chromium:1140071,chromium:1140073 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie6289a90a246c1f9ab9aabd42a11d9fbf35d93af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487169Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819011}
-
Benoit Lize authored
mallinfo() is used by MallocDumpProvider, and ProcessMemoryMetrics. The first one can also use the extended API of PartitionAlloc to report data, but the second one uses mallinfo(). To support both, implement mallinfo(). Bug: 998048 Change-Id: I9d71cd3a7bbf5c766cfc3771907c2f51ac17cace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426708Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#819010}
-
manukh authored
Adds configs for: - entity latency - dynamic max suggest - URL bubble max suggest Change-Id: Ideaf90a3ca9ffcdc05f7a89f2a2ddf9f755f72d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486398Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#819009}
-
Jose Dapena Paz authored
Fix GCC compilation issue: ../../components/media_message_center/media_notification_item.h:69:22: error: declaration of ‘virtual media_message_center::SourceType media_message_center::MediaNotificationItem::SourceType()’ changes meaning of ‘SourceType’ [-fpermissive] 69 | virtual SourceType SourceType() = 0; | ^~~~~~~~~~ ../../components/media_message_center/media_notification_item.h:19:12: note: ‘SourceType’ declared here as ‘enum class media_message_center::SourceType’ 19 | enum class SourceType { | ^~~~~~~~~~ To avoid the type clash, add explicit namespace in the declaration of the return type. Bug: 819294 Change-Id: I2d1e2f1feb5ddcb210c7df7a3762ae962d90167e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485175Reviewed-by:Becca Hughes <beccahughes@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#819008}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I66077b046579a788b236adaced07d208d09722e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487400Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5f6b5e4dbaf5..be6747613d78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1bc171572e34354b2a9570ede194b6b1226febf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487067Reviewed-by:
-
Dale Curtis authored
No one is able to repro, so for now disable the tests. R=tguilbert Bug: 1128458 Change-Id: I50a66a7892a6e0d3e01cf4788d0b6072e66ed308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485340 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#819005}
-
Ken Rockot authored
This is a reland of ea79bdd2 Fix is in the delta from PS1 -> PS3 Original change's description: > Mojo JS: Use BigInt consistently for 64-bit int fields > > This changes 64-bit integer fields to be deserialized as > BigInt values consistently, rather than sometimes being > BigInts and sometimes being Numbers. > > Fixed: 1102217,1009262 > Change-Id: I9cc8d767058938e9c39f62f139737e512f47cdb2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466398 > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Shik Chen <shik@chromium.org> > Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#818611} Change-Id: I393a33b44b1a3e1746f7b9ee021dbe06c3ff7b07 Tbr: shik@chromium.org Tbr: fdoray@chromium.org Tbr: ryansturm@chromium.org Tbr: mahmadi@chromium.org Tbr: beccahughes@chromium.org Tbr: oksamyt@chromium.org Tbr: ortuno@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485749Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
Olivier Robin authored
This histogram report the time incognito profile is on screen. Change-Id: Idef5b1602b941ae98dabad406ca81fd246d7bf8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470573 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#819003}
-
behdad authored
CSS_value_type_shadow story has been flaky on mac (representative perf tests) To prevent flakiness the story is tagged as experimental Bug: 1139155 Change-Id: If8329af22bb3b8b11b768ecc5620d8ba0919c5cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485782 Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#819002}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 80e56645. With Chromium commits locally applied on WPT: c31f15ed "WebMediaPlayerImpl: err if no A/V in ::OnMetadata" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I57e6b17fc9d94e1fb44fde72fc4dfff76ba98a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486193Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819001}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/edbb06059588..3fc3588cdf37 2020-10-20 sadrul@chromium.org [uma metric] Show the name of the metric on error. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1139460 Tbr: skyostil@google.com Change-Id: I87ac9afeae3a6991b2efd10f8d4c8557491d950b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487212Reviewed-by:
-
Lei Zhang authored
Bug: 646113 Change-Id: I2c2077217023325eb49a9a6ff79acadc37c507f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473452Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#818999}
-
Sonny Sasaka authored
This changes the color of "Connected" subtext from GoogleGreenDark600 to kTextColorPositive which resolves to GoogleGreen300 in dark mode. Bug: 1134227 Change-Id: I6946e86b50fe9428164341e6f907bb64616e59ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485337Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#818998}
-
Mark Yacoub authored
(reverted on crrev.com/c/2460807) 1. Set all props for CRTC, Connector and Plane to Plane Manager to Commit. 2. Maintain a consolidated path to modeset both Atomic and Legacy. 3. Simplify CRTC Controller by removing all modeset operations and maintain its state from PlaneManager::CrtcState. 4. This makes all CRTCs on the same hardware display controller to be modeset at the same time. BUG=1082882,1015104 Change-Id: I5c04747d1801b4e023458def29ad7a34863d8558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461039Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Gil Dekel <gildekel@chromium.org> Commit-Queue: Mark Yacoub <markyacoub@google.com> Auto-Submit: Mark Yacoub <markyacoub@google.com> Cr-Commit-Position: refs/heads/master@{#818997}
-
Evan Stade authored
Without this change, only media-fling works. Even with these flags removed, the APIs are still disabled for clients that don't explicitly enable Media Router functionality. Bug: 1057099, 1057100 Change-Id: I7f63dd36798a499011ddd722ebeb682532f7ddda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486455 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#818996}
-
Fredrik Söderqvist authored
Mark external/wpt/html/semantics/embedded-content/media-elements/track/track-element/track-webvtt-two-cue-layout-after-first-end.html flaky Tbr: mlamouri@chromium.org Bug: 1093188 Change-Id: I04de0550e232bbf6e0ff5d6a72540bb864b2b125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485795Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#818995}
-
Filip Filmar authored
A cosmetic change that brings the Chromium tests closer to what is being used in production in Fuchsia today. - Brings the unit test paths in sync with the correct path in Fuchsia: https://cs.opensource.google/fuchsia/fuchsia/+/master:src/lib/icu/tzdata/icu_tzdata_config_data.gni;l=11 - The loader code in icu_util.cc has been changed before to use the correct path, so no changes are required there. - The content of the tzdata directory is adjusted to match the contents that are provided by Fuchsia. This includes the newly introduced file revision.txt, which contains an assertion about what revision of tzdata is supposed to be packaged. Bug: 1139410 Change-Id: I80707a3daa0e492d747e9542b64593bf41a545c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480891Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Filip Filmar <fmil@google.com> Cr-Commit-Position: refs/heads/master@{#818994}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 32 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2021-01-18. TBR=chromium-metrics-reviews@google.com Change-Id: I40292736c72dd8378d28ff0d341b491e73609191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485643Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#818993}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/954fbcfe8ee7..3169c31f1f0e 2020-10-20 mmortensen@google.com Update requirements.txt for google-cloud-logging and deps. 2020-10-19 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-19 chrome-bot@chromium.org Update config settings by config-updater. 2020-10-19 kimjae@chromium.org chromite: Remove use of offensive term from codebase 2020-10-19 evgreen@chromium.org chromeos_config: Remove hw test override for dedede 2020-10-19 inglorion@chromium.org cros_setup_toolchains: add dev-lang/rust-bootstrap 2020-10-19 bmgordon@chromium.org cbuildbot: Explicitly request chroot image type If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I587472982d022c8e102d996a23fb86f16cc7577e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487215Reviewed-by:
-
Peter Kasting authored
Bug: 772945 Change-Id: Ic64283bf7d01aa919b47df2c31fe62db1ba3e146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472440 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#818991}
-
Fergal Daly authored
It appears to be causing crashing in canary. Bug: 1072817,1139104 Change-Id: I3d149aa338f6c11f5e5f9b65fd56aea55cda760e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486532 Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#818990}
-
evliu authored
This CL adds a speech recognition availability observer that will notify the Chrome speech recognition client when the user pref enabling the Live Caption feature changes. This will allow the feature to be enabled and disabled midstream without having to refresh the page. Bug: 1137086 Change-Id: Id9409b1666c74e2c835c65c311334b98ee56335b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469439Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#818989}
-
Chris Lu authored
If Smooth Scrolling is on, then the scrollview's origin is the same as the header's origin. Thus, |self.initialHeaderInset| is added to track the actual offset dragged by the user from the top of the page. When Smooth Scrolling is off, the scrollview's origin is the bottom left of the header, so adding that inset is unnecessary. Before refactoring fullscreen for MultiWindow, the ContentView's contentInset was set, but it is no longer needed and |self.initialHeaderInset| is the same value. Thus, not adding anything to contentOffsetFromTheTop is sufficient when Smooth Scrolling is off. Bug: 1128444 Change-Id: I5ada9f5cca5f8450572e0df6e689bd0f4cef47ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446782Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#818988}
-
Peter Kasting authored
Some of this cleanup will facilitate replacing ButtonListener with callbacks in a future CL. Bug: none Change-Id: Ieefc3be0238bdaa95fc171b7ee7c55e4f8e41a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472899 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/afa4d14527b8..615063999dd2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mcnee@google.com,andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1140394 Tbr: mcnee@google.com,andypaicu@google.com Change-Id: I01cfa6d34af57d641afee1dc59f8fc85a36efcd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487166Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#818986}
-
Sean Kau authored
Currently, we're clearing the printers list anytime we get a network change event. This is fine, except this can include completing connection to a network and a change in signal strength. This can get out-of-sync with the ZeroconfPrinterDetector and cause our list of printers to be in an invalid state. Manifests as entries in settings that are reported as having "disappeared". Bug: 1137999 Change-Id: Ic89ce0e3e65a70d98a027019cd8b4e1fd626946a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480825Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#818985}
-
Danyao Wang authored
Verbose logging messages can be turned on with the following flags: --enable-logging=stderr --vmodule=*/payments/*=2 Bug: 1130768 Change-Id: I9a76a9e7705d69a1f388ec3680b19ce1a46e261f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485538Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010200700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/rzh7SSCNO_IMmZv7t7OIlOy_7XIZejdnXpj-Uh3IeGwC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/169509246,b/170910313 Tbr: help-app@grotations.appspotmail.com Change-Id: I4c36081ae90186ae9f810ecb65a3075f9b05afe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487167Reviewed-by:
-
Erik Staab authored
Bug: 1135716 Change-Id: I8c77e6587d40aaa4e9a331f99ed40af5569d6e6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485886 Auto-Submit: Erik Staab <estaab@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
-
Hui Yingst authored
- Move SetSelectedText() and SetLinkUnderCursor() to PDFEngine::Client. - Remove SetSelectedTextFunction since TestClient implements SetSelectedText() and SetLinkUnderCursor() as no-ops. Bug: 1113919 Change-Id: I788d08d850bcec80047f4869bf044ebec3a050d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469403Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Hui Yingst <nigi@chromium.org> Cr-Commit-Position: refs/heads/master@{#818981}
-
