GitLab

The function WaitForHitTestDataChange() only waits for transform change.
The best place to wait for all types of data change in hit test should
be HitTestRegionObserver::WaitForHitTestData().

Bug: None
Change-Id: I51832e0ac133e59f4e58f09f4061f8d6d45c4241
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692191Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676094}

On Chrome OS, with Mirror account reconciliation enabled, it is possible
that an account's session expires server-side without Chrome detecting
it. In these cases, Gaia sends us a re-authentication header message
with the account's email that needs re-authentication.

Currently, Chrome OS displays the Account Manager Settings page for
these messages. Fix it to show a re-authentication dialog.

Bug: b/136640443
Change-Id: I9a88a3115908a663ac0b9f895656782ff0fb8923
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695351Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676093}

use await instead of promise chaining for activity log history browser
tests. This should make the tests more readable and it reduces nesting.

Bug: 945422
Change-Id: I75ed11a26c952ca72db305f48637d9d2bc7178af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694266Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676092}

Change-Id: Ic5b0507a794a4d83bdc84bd77386e389def6f1d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692171Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Matthew Cary (CET) <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676091}

The SendDocument function in cups_printer which calls
cupsStartDestDocument in CUPS had the logic backwards for passing the
"last_document" argument. This was causing CUPS to behave strangely and
mishandle printing multiple copies of documents for printers which did
not support the copies IPP attribute.

Bug: chromium:897275
Test: Tested manually using elm device and virtual USB printer
Change-Id: I313965bfe4c281adf071ef8c14a022df4e0c2c12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695693
Auto-Submit: David Valleau <valleau@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: David Valleau <valleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676090}

TBR=rtoy

Bug: 972733
Change-Id: Iee1148c9d9172378cdf6120a1b2461c1d100e679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693907Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676089}

This CL removes unnecessary blank option in site settings on Android
when Bluetooth Scanning API is not enabled.

Bug: 980075
Change-Id: I70c39634e161cbcc28b805b12d7facfdcf2d5fb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693766Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676088}

This updates the FakeXRDeviceInterface to support newly added methods in
the webxr-test-api:
* simulateVisibilityChange
* setBoundsGeometry
* setLocalToFloorLevelTransform
* clearLocalToFloorLevelTransform

and supports the setting of boundsCoordinates and
localToFloorLevelTransform in FakeXRDeviceInit.

The Bounds and LocalToFloorLevelTransform functions already existed on
internal tests, and as such a few of the tests that were ready were
ported to external wpts.

Note that simulateInputSourceConnection and disconnect will be
implemented by future work.

Bug: 979316
Change-Id: Idfb8bb631bfc1f1cb13b571a90b1a41b4a6fe518
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692038
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676087}

As a proof of concept for the separation of layout generation and
application, this CL reimplements FlexLayout using GetProposedLayout(),
with significant code savings. The new layout has almost the same
programming interface, and passes all existing unit tests.

(Note that this also removes some of the explicit caching in
FlexLayout but it can always be added back in later if we determine
it's needed.)

For more information on the separation, see this upstream CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1653898

And this design doc (internal only for now):
https://docs.google.com/document/d/1fZOg120fswUdaV7tfZh8cXIlcvAL1Gg70GVrsQVXl3g/edit

Next steps:
 - (optional) Expand FlexLayout with some features that make it
   friendlier to use, especially in interpolating layouts.
 - Implement AnimatingLayout (extending LayoutManager) with basic layout
   animations, analogous to those supported by Cocoa's Core Animation
   library.
 - Move toolbar, bookmarks, and tab handles to an animating layout.

Follow-ups:
 - Combine LayoutManager and LayoutManagerBase
 - Update Box, Grid, and Fill layouts
 - Ensure other one-off layouts work with the new framework

Change-Id: I1bbd739e1b2f5e45d92c8d3a38473319c4b6806f
Bug: 898632
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656249
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676086}

There were a few tests related to size containment and select elements
marked as failure in TestExpectations, but they're actually passing.

Change-Id: I562b63be72ddf192ed78b3995033c8d35ab345fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695546Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676085}

Bug: 969139
Change-Id: I0bf080b7e8e9f461cd3a6da4bc0da9261976ce2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676545
Commit-Queue: Joe Mason <joenotcharles@google.com>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: proberge <proberge@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676084}

DirectSharedImageVideoProvider was in video_frame_factory_impl.cc,
mostly so that review of the refactor would be simpler.  This CL
moves it into separate files.  There is very little functional
change, except that TextureOwner creation is now moved out of the
SharedImageVideoProvider, and into VideoFrameFactoryImpl.  It's
still somewhat hacky, but at least it's hacky closer to where it
should actually be done.

This CL also adds more unittests for VideoFrameFactoryImpl, since
it's now much easier to inject mocks for everything.  It doesn't add
any tests for DirectSharedImageVideoProvider, since that depends on
a refactor to move codec output buffer management out of CodecImage.

Change-Id: I521fec5c9c03d00878bd4ff4844304f5f893a3f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646901
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676083}

Bug: 982116
Change-Id: Iadb2047405fce29a3b3d4eb3f1e5443732b21dab
Tbr: caseq@chromium.org
No-Try: true
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696207Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676082}

Bug: 981974
Change-Id: I60bec6931fcdeca44692ff5bac2e7c5fed9845b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692492
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676081}

After the switch from stand-alone GCs to unified heap GCs reporting we lack
reporting of the atomic phase.

- Adds THSC::atomic_phase_time() and tests
- Adds BlinkGC.AtomicPhase which captures the atomic phase for stand-alone as
  well as unified heap GCs.
- Adds expiration milestones for more GC histograms
- Deprecates BlinkGC.TimeForCoalesce

Bug: 948807
Change-Id: Icb14fb720811fb4ac6323b07f02ead80a746a4f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695343Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676080}

This patch refactors so that:
a. Clarify which of the or-ed DCHECK fail.
b. If |line_layout_item| is a |LayoutBlockFlow| that is not
   |this|, degrades SECURITY_DCHECK to DCHECK. We have wrong
   object, but it's not a bad cast.
c. If |line_layout_item| is neither |LayoutInline| nor
   |LayoutBlockFlow|, the |LineLayoutBlockFlow| constructor
   has SECURITY_DCHECK.

This is a speculative fix as I was unable to reproduce.

Bug: 979373
Change-Id: Ib148009f8bdea7b599be160af72a48c86bc73d7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695123
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676079}

An M69 change broke an edge case for multi-instance tab model merging
(see http://crrev.com/c/1153438). This CL updates TabWindowManager to
merge tabs into ChromeTabbedActivity2 when creating a new
TabPersistencePolicy iff there are no other currently assigned tab model
selectors and the activity is not in multi-window mode.

Also adds a test to help prevent future regressions.

BUG=982305

Change-Id: Ib43b1de13aea654d0f2a2e5c14021ee09713ab66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693129Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676078}

This patch fixes |ShapingLineBreaker| to handle an edge case
to reshape the line end.

When reshaping the line end is needed, and the line overflows
due to the reshape, |ShapingLineBreaker| tries the previous
break opportunity until it fits.

It is possible that the opportunity is moved back more than
|first_safe|, in which caes |ShapingLineBreaker| calls
|HarfBuzzShaper| with |start > end|. This patch avoids such
case.

This is a speculative fix.

Bug: 981308
Change-Id: I3020ad79e925af5bd5d78bdf3202893117a9f279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694884Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676077}

Latency component INPUT_EVENT_LATENCY_SCROLL_UPDATE_RAF_TIME_COMPONENT
was added to record EventTimeToRAFTime and RAFTimeToFrameSwapEnd metrics
to measure how much we need to resample/predict.
In the previous CL, we change the scroll resampling to use
BeginFrameArgs.frame_time, which makes this component same as
INPUT_EVENT_LATENCY_RENDERING_*.

This CL changes EventTimeToRAFTime and RAFTimeToFrameSwapEnd metrics to
use INPUT_EVENT_LATENCY_RENDERING_* and only record compositor thread
scroll.

Bug: 969697
Change-Id: I90959862a10f281dbffb83e3577ffe4b632549c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1685406Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676076}

This change affects the Clear Browsing Data and Passwords settings
screens, removing the default preference item animations.

These animations would occur on preference changes, and were
unintentionally introduced with the migration to Support Library
preferences, which are contained in a RecyclerView with default item
animations. Because these settings screens had preference changes occur
quickly (but asynchronously) as the fragment loaded, the animations
appeared janky.

Bug: 979598, 980076
Change-Id: Ida7cafe862641c98547cbc815989bf86d250e0f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692198Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676075}

This is a reland of 1189f593

This fixes the problems on official Windows, and also moves
the LLD assertion into if-statement, so that for the cases that
don't want to use the orderfile, LLD guarantee is not needed.

Bug: chromium:950627, chromium:982179
Test: Chrome OS, Android are tested locally. Official windows is tested on Linux.

Original change's description:
> Add GN args for using orderfile for Chrome OS
>
> This patch adds GN args to use an orderfile for linking Chrome.
> By default, it's pointing a path will be updated by autoroller.
> Chrome ebuild can also override the path to test a custom orderfile.
>
> This patch also consolidates the efforts across Android and Windows,
> to have a configuration of using orderfile in build/config/compiler.
>
> Bug: chromium:950627
> Test: Chrome builds locally on Chrome OS. Android and Windows is not tested.
>
> Change-Id: If9fd06368da81e02488cb991c3b7490e6ed91363
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672231
> Commit-Queue: Tiancong Wang <tcwang@google.com>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#675412}

Change-Id: Id1ebf193bdd0dcc9c7e1776fa2029500b915cc6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693201Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Tiancong Wang <tcwang@google.com>
Auto-Submit: Tiancong Wang <tcwang@google.com>
Cr-Commit-Position: refs/heads/master@{#676074}

This reverts commit c2d3f186.

Reason for revert: Suspecting this CL for test failures in Linux CFI
https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI

See first test failure of AdsPageLoadMetricsObserverResourceBrowserTest.AdFrameSizeInterventionMediaStatusPlayed here:
https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/14253

Suspecting this CL since it was the only one that touched code in t/p/b/r/c/html for that blamelist and crash shows blink::HTMLParserScheduler::ScheduleForUnpause within stack trace.

Original change's description:
> Replace use of std containers with WTF's equivalents in html_slot_element.h
> 
> This CL replaces the use of std::array of std containers with WTF::Vector
> and introduces LCSArray struct in html_slot_element.h.
> 
> Bug: 952716
> Change-Id: I45d0dcbb63aed5198440bd7b94c5c693a05bd6fd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694801
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Miyoung Shin <myid.shin@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#675985}

TBR=haraken@chromium.org,myid.shin@igalia.com

Change-Id: Ibf0a3bb5b4d4f579085986b941a5d6e710d0e6fc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 952716
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696007Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676073}

Records the custom response status code for the intercepted requests where
input stream is null. The data is recorded only when the status codes and
reason phrases are actually valid. This is recorded regardless of whether
the network service is enabled or disabled.

The UMA is useful to see if there is any significant usage for this type
of interception. This type of interception has been originally mentioned
in crbug.com/965608, where it results in behavior different to the old
(non-network service) code path. Also see crbug.com/974273 for more
details.

Note on reland:
The original patch caused issues in dev/canary due to a side-effect of
AwWebResourceResponse::GetInputStream, which returns a unique_ptr and
which also closes the original java stream when destroyed. Current patch
avoids using unique_ptr, and instead introduces a new HasInputStream()
method, which does not have side-effects. Verified with the gmail app
(as in crbug.com/980223).

BUG=974273,965608

TBR=isherman@chromium.org

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660657Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#673362}
Change-Id: I3032c1b0485f2aa5a4495e7ba783dfda0f1fd737
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689798
Cr-Commit-Position: refs/heads/master@{#676072}

Also modernize some of the surrounding code, and pass ownership of
strings rather than just a reference, removing some copies.

Change-Id: Ib53ba2c6acab5a6196ef58dd6067daea1d4d9edd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695298Reviewed-by: Richard Knoll <knollr@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676071}

Exchanged storing WebFormElements and WebFormControlElements by storing only their unique renderer ids.

Change-Id: I9ca873a285d327001e4f29a828c0eb02e97fe48d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663414
Commit-Queue: Matthias Körber <koerber@google.com>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676070}

The color calculated for a custom background should only
be updated if the image hasn't changed in the meantime.
Check this by saving the timestamp when a background is set
and checking that it still matches once the color calculation
is complete.

When possible use the thumbnail url |fetch_image| for the calculation,
the full-sized image was always being used.

Fix a copy-paste error in the definition for onlocalbackgroundselected.

Bug: 982215
Change-Id: Ib02f000add27f10eb23fb50051b44744a4b53323
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693389Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676069}

Only CSSNumericLiteralValue sets the |numeric_literal_unit_type_| enum,
and is therefore the only clas where |GetType()| makes sense. So this
patch moves |GetType()| to the correct place.

Bug: 979895
Change-Id: I83a48de866f2ccfdace9eb7b6d48ad4e8e531e5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693949Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676068}

Bug: 377410
Change-Id: I78f9c9013b5f6287016353b6e6771f7a5d5c0c9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690968Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Commit-Queue: Ivana Zuzic <izuzic@google.com>
Cr-Commit-Position: refs/heads/master@{#676067}

For example cr_view_manager.js is such a case.

Bug: 965770
Change-Id: I4d54ae037258bb322f5b00aeb8a8d2bf15c7892b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694243Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676066}

Bug: 982357
Change-Id: Idea7394705b9421a0ce4837e79da7e4a8b2fe529
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694143Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676065}

The existing code relies on the document body's class list following a
specific format. This CL allows for an arbitrary class list, which in
turn makes it easier to update the theme on other elements. (This will
be needed for the appearance settings, assuming the settings are put in
the web contents.)

This CL also reworks how the JS font/theme maps to the CSS font/theme.
The JS and CSS strings are always the same, so we can just verify that
the JS string is one of the expected ones before returning it.

The associated browser tests are also modified to no longer expect a
specific class order. Monospace is used instead of serif to make
substring matching less complicated.

Bug: 952034
Change-Id: I99d61dd3a3edcfe66f52169309105d1e235b937a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1684251Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#676064}

As a follow-up to
https://chromium-review.googlesource.com/c/chromium/src/+/1686776/14/base/test/scoped_task_environment.cc#366

Doing so I realized that a thread_annotations bug I'd also hit in
TaskTracker is OS_NACL specific. Fixed in
https://chromium-review.googlesource.com/c/chromium/src/+/1695681
and re-enabling proper safety checks in TaskTracker here.

R=alexclarke@chromium.org

Bug: 946657, 982423
Change-Id: Ibbee23cd855f9c124bb41dfd8d2381b03a020132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692826
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676063}

Bug: 982211
Change-Id: I5334461f171986da8e23fe88af21abefe13599a3
Tbr: eae@chromium.org
No-Try: true
No-Presubmit: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696162Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676062}

This reverts commit b050ee2d.

Reason for revert: The test still fails.

Original change's description:
> Re-enable VariationsHttpHeadersBrowserTest tests on ChromeOS.
> 
> I can't reproduce flakes locally, so I'm going to re-enable them and see
> if we've fixed them in the last couple months. I also added additional
> assertions to the test so we'll get more information about why they fail
> if they do.
> 
> Bug: 964338
> Change-Id: I4a864101de6cfb1b434c3b2157d2323d8e6e522a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693704
> Reviewed-by: Eric Roman <eroman@chromium.org>
> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#675871}

TBR=eroman@chromium.org,rmcelrath@chromium.org

Change-Id: I22e9da1c789c903fe895cfbf45e47a4971b48c83
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 964338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696084Reviewed-by: Robbie McElrath <rmcelrath@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676061}

Most integration tests don't work well on kitkat since they rely on
native code which might not be held in the main DEX file, so this CL
disables them.

It also makes waiting functions return more specific errors which helps
to identify the actual failing conditions from trybot logs.

Last but not least, it resolves two common timing issues:
1. Setting a fixed viewport prevents the zoom-on-focus animation which
delays UI stability until the animation ends.
2. Autofill chips might be slightly delayed compared to other filling UI
elements. Therefore, added and used an option to wait for these chips.

Bug: 979182
Change-Id: I1dd08123a08f985c9464e781d12b6f7f2bb77314
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695548
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676060}

This CL makes addIceCandidate() return a resolved promise when an empty
candidate is given instead of rejecting the promise (which occurred due
to a parsing failure).
This does not implement proper handling of such candidates, but avoids
the rejected promise.

Bug: 978582
Change-Id: I78249d471e3b4417b00eeb430951dbf8ab63769d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692176Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676059}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ef089bcde1e6..9b7fc04d3edb


Created with:
  gclient setdep -r src-internal@9b7fc04d3edb

The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=hcarmona@google.com,hajimehoshi@google.com,jbroman@google.com

Change-Id: Ifb504402bfc285a351715adfc0c3f21c65d13dd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695827Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#676058}

Currently, LargestTextPaint and LargestImagePaint uses node_id as the
secondary ranking key. This means when two records have the same size,
the node_id will be used to decide which one is the largest. However,
the order of node_id can be affected by factors out of LCP. So it's
potentially indeterministic. To make the result more deterministic, we
can use the insertion order as the secondary ranking key.

This CL reflects the above change.

Bug: 959984

Change-Id: Id42a32f05593f649f59fcb74fd3c57fa0e2f5fa1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693036
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676057}

This reverts commit bfaee63b.

Changes:
  * Move ContentShell changes to application class for consistency
  * Support Chrome browser tests (from http://crrev.com/c/1680511)
  * Remove //ui dep from //testing (which breaks repos that only depend on //testing)

Original change's description:
  Trichrome Proguard: Fix locale pak selection.

  This CL moves the arrays of locale pak files out of BuildConfig.java
  into a new file, LocaleConfig.java.

  This file is generated with a unique package which allows Chrome
  and Webview to have different versions in Trichrome.

TBR=dtrainor@chromium.org,torne@chromium.org,agrieve@chromium.org,estevenson@chromium.org,tedchoc@chromium.org

Change-Id: I11281fafc3ae6db9260722e95f9c0c81a2ae20c1
Bug: 960025
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682047Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676056}

Before:
E  153.473s Main  Unrecognized error occurred.
Traceback (most recent call last):
  File "bin/../../../build/android/test_runner.py", line 952, in main
    return RunTestsCommand(args)
...
  File "/usr/local/google/code/clankium1/src/build/android/pylib/instrumentation/instrumentation_test_instance.py", line 262, in FilterTests
    raise MissingSizeAnnotationError(GetTestName(t))
MissingSizeAnnotationError: org.chromium.net.smoke.MissingNativeLibraryTest#initializationError: Test method is missing required size annotation. Add one of: @LargeTest, @Manual, @FlakyTest, @DisabledTest, @MediumTest, @SmallTest, @IntegrationTest, @EnormousTest

E    4.321s list_tests(86TX00E9L)  Unexpected output while listing tests:
E    4.322s list_tests(86TX00E9L)    Fatal exception when running tests
E    4.322s list_tests(86TX00E9L)    java.lang.RuntimeException: Failed on initializationError(org.chromium.net.smoke.MissingNativeLibraryTest)
E    4.322s list_tests(86TX00E9L)       at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.listTests(BaseChromiumAndroidJUnitRunner.java:208)
E    4.322s list_tests(86TX00E9L)       at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:150)
E    4.322s list_tests(86TX00E9L)       at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:2189)
E    4.322s list_tests(86TX00E9L)    Caused by: java.lang.Exception: Custom runner class AndroidJUnit4ClassRunner should have a public constructor with signature AndroidJUnit4ClassRunner(Class testClass)
E    4.322s list_tests(86TX00E9L)       at org.junit.internal.builders.AnnotatedBuilder.buildRunner(AnnotatedBuilder.java:111)
...

After: 
Change-Id: Ib6b304fbf675c205ca2d0e23bace17b81f2e18a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691081Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676055}