- 12 Nov, 2019 40 commits
-
-
Elly Fong-Jones authored
Whether this control creates a footnote view or not (and the state of the footnote view if it does create one) depends on several pieces of state in the controller, some of which are only present after the controller's ShowPrompt method is called. This change therefore: 1) Changes ShowPrompt to take a factory callback that manufactures the concrete View class 2) Invokes that factory callback once all the state needed for the View is ready 3) Moves creation of the View's footnote view into the View's constructor, now that all the needed state is guaranteed to be available. This change exposed a bug in the tests: the production code passed ownership of a raw pointer in for the View, but the tests instead retain ownership and pass in a weak raw pointer. This happens to work because View tolerates being destroyed while still parented, but this behavior of View is deprecated. I have not fixed this test behavior in this CL to keep the size down. Bug: 1011446 Change-Id: I1ad6f12cc59b2f77c75ac81b13f41eae67738205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907069 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#714625}
-
Scott Violet authored
moves weblayer/shell/android/javatests to weblayer/browser/android/javatests My plan is to move weblayer/browser/java into this directory next. BUG=none TEST=none Change-Id: If442c9ebe6204a26038585e4fa53875c866a1fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910814 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#714624}
-
Mike Dougherty authored
Additionally add a boolean parameter to [ChromeEarlGrey reload] to make the wait after the reload optional based on the parameter value. Bug: 987646 Change-Id: I2d6aecf5ed34274b256c66a0b9504cd9a2799992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909710 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#714623}
-
Elly Fong-Jones authored
This change: 1) has FlagsState take (and internally store) its set of FeatureEntry as a base::span<FeatureEntry> rather than a (FeatureEntry*, size_t) pair, and rewrites all iterations over the set of FeatureEntry to use new-style for loops. 2) introduces FlagsState::Delegate for users of the component to customize the behavior of FlagsState, and replaces existing uses of the exclude predicate with uses of this delegate. This is a preparatory refactor for the work to show flag expiration milestones within the flags UI. As that work proceeds FlagsState::Delegate will gain new methods. Bug: 1020637 Change-Id: Ia61abb4ba7fe42df874a9089531be69f5b076fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912419Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#714622}
-
Lambros Lambrou authored
This adds a PermissionWizard::Delegate implementation which runs the Me2Me or IT2Me binary with a command-line for checking permissions. This can be used to create a PermissionWizard which checks the permissions on either the ME2ME or IT2ME host. Bug: 1015201 Change-Id: I24f24e5b1928608bbf310b33a6802db86c9f80bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903934Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#714621}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3f647b1bf9a4..4f023f565a61 git log 3f647b1bf9a4..4f023f565a61 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 syoussefi@chromium.org Enable passing end2end test Created with: gclient setdep -r src/third_party/angle@4f023f565a61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: None Change-Id: Iefb86174c64e27f4aa840c26ddded31fdabfb86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912680Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714620}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/197a5725f2fe..e2f83aa33d88 git log 197a5725f2fe..e2f83aa33d88 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 bclayton@google.com Regres: Add workaround for Khronos Gitlab issues Created with: gclient setdep -r src/third_party/swiftshader@e2f83aa33d88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: I90b9bc330d5c4eaa1e129037a1db0a63fade4c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911706Reviewed-by:
-
Bettina authored
Renaming leaked credentials table to compromised table because password protection will be using the same table to store phished saved passwords. This depends on cr/1888392. Bug: 1015671 Change-Id: I394c2d4e722bb43d146df815de70fe2040e08f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888782 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#714618}
-
Daniel Rubery authored
This CL extends the following metrics: SafeBrowsing.FileTypeUpdate.ResourceBundleResult SafeBrowsing.FileTypeUpdate.DynamicUpdateResult These have been added to Chirp alerts, since they indicate problems with the FileTypePolicies rollout. In order to debug these alerts, the following metrics have also been extended: SafeBrowsing.FileTypeUpdate.ResourceBundleVersion SafeBrowsing.FileTypeUpdate.DynamicUpdateVersion The following metrics were obsoleted, since they are not being used, and are not useful in case of an alert: SafeBrowsing.FileTypeUpdate.ResourceBundleTypeCount SafeBrowsing.FileTypeUpdate.DynamicUpdateTypeCount Fixed: 988663 Change-Id: I0ff456bf2fbbbe018781c39824fa3aa59b711252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895387Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#714617}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/cfc9c6e322f4..eac7382eb232 git log cfc9c6e322f4..eac7382eb232 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 rharrison@chromium.org Rolling 4 dependencies Created with: gclient setdep -r src/third_party/dawn@eac7382eb232 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I48444a9347eb83e7c3db923408a32805e8f46888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911665Reviewed-by:
-
Aga Wronska authored
Status reporting refactoring that landed recently makes it only relevant for child users. Rename to ChildStatusReportingService to reflect that. Bug: 1022231 Change-Id: I6a6763fc977eaf572bee9ec27eb90b76030c75a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910700Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#714615}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 82 histograms that show frequent access in the past 90 days. These are the 80% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-05-10. Change-Id: If195f3ab7c1a13f8adb22add5a9e0f3aff7e1bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911104 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#714614}
-
Oksana Zhuravlova authored
Change-Id: I38f6d8e4756e9da69f733e0b6a356ef9a7cd9082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909816Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#714613}
-
Christoph Schwering authored
* Removed autofill-inl.h. * Moved FindByContents() from autofill-inl.h to personal_data_manager.cc. * Replaced functor structs with lambdas: - IsEmptyFunctor - FormGroupMatchesByGUIDFunctor - FormGroupMatchesByCompareFunctor * Fixed that IsEmptyFunctor, FormGroupMatchesByGUIDFunctor used copies instead of references to std::string. Since FormGroupMatchesByGUIDFunctor was instantiated for each element, this should save many unneeded allocations. Bug: 1007974 Change-Id: I68bdced7819cb439dd9c6f5af9d67304f1c19ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900995 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#714612}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c85c137c5de6..1afa8b609752 git log c85c137c5de6..1afa8b609752 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 nigi@chromium.org Fix rendering issue regarding Type2 CIDFont with illegal CIDToCIDMap. 2019-11-12 nigi@chromium.org Add a pixel test for PDF with illegal CIDToGIDMap stream. Created with: gclient setdep -r src/third_party/pdfium@1afa8b609752 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I2bf09dc30eb122f5a6987dc7065dd9794e64a3f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912679Reviewed-by:
-
Regan Hsu authored
Currently, when the device screen width is too small, associated preview wallpaper buttons are chopped. This CL ensures that they are not, and keeps the preview navbar centered with css instead of js. Before screenshot- https://screenshot.googleplex.com/GEmgWH8EPu3 After screenshot- https://screenshot.googleplex.com/e3icCqdwX3J Bug: 1022743 Change-Id: I92f77c682a0395996066cb148d14428b21d487c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907709 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#714610}
-
Robbie McElrath authored
This was accidentally removed in crrev.com/c/1880070, and causes a crash when launching the license activity. I tested the aforementioned CL by selecting "System WebView licenses" in the Settings UI, but it turns out that launches the first android.settings.WEBVIEW_LICENSE activity it finds in the system image, so it wasn't actually testing my change. This also removes an about_ui_android dependency from //aw:libwebviewchromium since that's already in //aw:apk where it belongs. Test: adb shell am start -n com.google.android.apps.chrome/org.chromium.android_webview.app.LicenseActivity Bug: 934152 Change-Id: I8115d6bd5291249da0b6c625c5f210b0d953c62b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904615 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714609}
-
Dmitry Torokhov authored
This change implements PluginVmProcessTask responsible for handling Plugin VM processes form the task manager, and teaches VM task provider how to identify Plugin VMs. As pert of this Crostini's task provider implementation was moved into .../vm sub-directory, and intermediate VmProcessTask class was factored out, and CrostiniProcessTaskProvider was renamed to VmProcessTaskProvider in preparation to adding handling of Plugin VMs. Also the Plugin VM manager class was adjusted to accept VM name when stopping a Plugin VM. Bug: b:144190453 Change-Id: I23f6cef063e4877dcdb2498fbd7064d93a766f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907711Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#714608}
-
Yuchen Liu authored
Disable the test to unblock PoG. Bug: internal b/143135800 Test: None Change-Id: I61b63dde2177dbcb687dce97d08fb0b2cd68f18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913051 Commit-Queue: Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Auto-Submit: Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#714607}
-
Min Qin authored
Setup() is called on each test and it will set the global NetworkChangeNotifierFactory multiple times, causing a CHECK failure in NetworkChangeNotifier::SetFactory(). This CL fixes the issue by not setting the factory if it is already set. BUG=1023050 Change-Id: I61e2ca89e0c2409bdd8f8725c2e96bf706618da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909810Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714606}
-
John Lee authored
To mimic the native tab strip, the title of the tab will now either have a placeholder title indicating the tab is still loading or one indicating that the tab is untitled. Bug: 989131 Change-Id: I30acc3b973c573fd8b6721093c52fa31efc49c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907565 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#714605}
-
John Budorick authored
Follow-up to crrev.com/c/1155788. Bug: 865373, 1022533 Change-Id: Iccd0f182ac850eebc7d32c0230c15c33b4d387a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904815 Auto-Submit: John Budorick <jbudorick@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#714604}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1f5e1d17. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 15c6f4fb "Add Web Platform Tests for the Split Cache" 88d98fda "Add more scroll to text WPTs" 0b97fceb "Capture frame policy at the beginning of navigation" 0b0e2c2a "[LayoutNGFragmentPaint] Fix containing-block of OOF-positioned objects." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ifceefe9cedcb725fe7e1f281b7aa97678d603af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911246Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714603}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/c9d5be6b0170..e46010f01da9 git log c9d5be6b0170..e46010f01da9 --date=short --no-merges --format='%ad %ae %s' 2019-11-12 rharrison@google.com Rolling 5 dependencies and updating expectations (#879) Created with: gclient setdep -r src/third_party/shaderc/src@e46010f01da9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Ib382b1ec21796a701a38bf02769223ff65b5017c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912160Reviewed-by:
-
Nikita Podguzov authored
This will be used in chrome.printing API to expose printer status to the extension. Bug: 996785 Change-Id: I2b653f423e374e8bb17bb5b85e9d94f821d50d8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906669 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#714601}
-
Joe DeBlasio authored
This CL swaps the default parameter values for lookalike heuristics in Safety Tips to default to enabled. This mitigates an issue in metrics recording where we were not identifying lookalike sites in the control group, since their parameters were enabled. This is not a user-visible change. Bug: 1022016 Change-Id: Ie1373ce1543a2916de1a442ccc2371f485427cb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910844 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#714600}
-
Piotr Bialecki authored
Hit test options are redundant on XRHitTestSource since hit test source can only be created by passing XRHitTestOptionsInit. Change-Id: I13f2a5d398a8c524d967bee14a7a20025b222c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907708 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#714599}
-
Mei Liang authored
This CL adds a close action to TabSelectionEditorActionProvider. In addition, this CL provides an constructor for customized process selected tabs action. Change-Id: Ia5ae7902641055f3bd30e7351f5e2df2a0822ab1 Bug: 1004570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907307Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#714598}
-
Thomas Lukaszewicz authored
Added the access operator to the color mixer class, updated existing code and tests. Changed AddMixer() to return a mixer by reference. Bug: 1887666 Change-Id: Ic62f9399f377a9ecb98eb49e2a5ae42a7785a490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912659 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#714597}
-
Moe Ahmadi authored
This CL prevents matches from requiring inline autocompletion when user is deleting text in the realbox. It does so by forwarding that information to the backend and setting |prevent_inline_autocomplete| on AutocompleteInput. Previously the inline autocompletion was being ignored when user was deleting text in the realbox but the backend was unaware, and therefore matches requiring inline autocompletion were not being demoted. Bug: 1021791 Change-Id: I0d49e0d726762f63fdfd048252c30c2f51c256a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904527Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#714596}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/89863242a428..9577daf6673d git log 89863242a428..9577daf6673d --date=short --no-merges --format='%ad %ae %s' 2019-11-12 ehmaldonado@chromium.org depot_tools: Don't add a python3 shim to depot_tools on bootstrap. Created with: gclient setdep -r src/third_party/depot_tools@9577daf6673d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1017812 Change-Id: I0e755eb41330fcd5a3e3f2bc2db3e33c62638e9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912440Reviewed-by:
-
John Lee authored
Previously, if a user swiped up the full 200px and released, the animation would re-play from the very beginning. Bug: 1014679 Change-Id: I6810fd371d375b812e206b9e6e8067a5644bf86e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910872Reviewed-by:
-
Rohit Agarwal authored
The default credentials state was passed until the HttpAuthController via ctor to enable/disable ambient authentication. The HttpAuthController should be agnostic to this and the ambient authentication check should be delegated to its respective HttpAuthHandler. The refactoring follows the guidelines mentioned here [1]. [1] : https://docs.google.com/document/d/14k7zPjXLC9nZFnAofO1jYgEUBaapKY8eDjJybhWEVOU/edit# Bug: 458508 Change-Id: Ib8e0e33cc97703f105318a13b9a009ca707a944f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882323Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#714593}
-
Toby Huang authored
Currently, ParentAccessServiceTest uses LoginPolicyTestBase to log in as child user for tests. We should deprecate LoginPolicyTestBase in favor of LoggedInUserMixin instead. This CL converts ParentAccessServiceTest to replace LoginPolicyTestBase with LoggedInUserMixin for logging in as child user for tests. Bug: 1014663 Change-Id: I66f8c308e87efd49945ac322d969d162104ff130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1909273Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#714592}
-
Sigurdur Asgeirsson authored
This CL implements mojo::internal::MessageQuotaChecker, that allows unread message quota checking to be performed at send-time in IPC::ChannelProxy. This in turn allows generating crash dumps with the abusive producer on the call stack, red handed. Bug: 1017827 Change-Id: Ib0a7f5cde2c9df00c89bb79834c1cffa211fa6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899909Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#714591}
-
John Rosasco authored
A pending change to skia will delineate GL-only sources from multi-GPU interface source lists in the build configuration. This change serializes the integration of that change between the two repos. Change-Id: I12bdc14228fbc9bd56214301fa7ab02eff5b2efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910870 Commit-Queue: John Rosasco <rosasco@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by:
Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#714590}
-
Mikhail Khokhlov authored
This CL restores the accidentally deleted fix for repeated --output-format arguments. Bug: 1023796 Change-Id: I247332772af7feb308d00564766b0ca898904cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911790 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#714589}
-
Sharon Yang authored
This change adds functionality to the Accessibility Bridge: * Listens for change in AccessibilityMode from Fuchsia * Gets the semantic tree from Chrome accessibility and sends it to the SemanticsManager * Sends live updates when nodes are added, updated or removed To send updates, this change includes the following: * Creates a ViewRefPair and registers it with the SemanticsManager * Initialize an AccessibilityBridge * Listen for changes in the Chrome Accessibility tree, serializes them to Fuchsia data structures and sends that data to the Fuchsia SemanticsManager Testing: Added AccessibilityBridge browsertests. Bug: 973095 Change-Id: I89658288b846b6b9ce84a04e49434ec266b84dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787171 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#714588}
-
Lan Wei authored
When we calculate the element's central location, we need to consider about the overflow case that the element's view area is less than its actually area. For the drop down menu bar, the drop down menu list's parent is the menu bar, which does not have any overlap with the menu item, so we should consider about the parent's boundary when there is no overlap between the element's area and the parent's area. Bug: chromedriver:3205 Change-Id: I39c8292dc730cf23a562ed206ddaccb09a5b36c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908057 Commit-Queue: Lan Wei <lanwei@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#714587}
-
Demetrios Papadopoulos authored
Specifically enable: - clang-format for JS files - Various HTML/CSS/JS checks including ESLint checks. - SVG optimization checks Fixed: 1019312 Change-Id: I01628b5faae9ff95dc5eebefec2a0c4956ed3664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888151 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
