GitLab

The current value for this policy indicates that it applies to all ChromeOS versions after M84, however this wasn't right as that policy was not released by then: it was ready after a change I made in M86. This CL updates the 'supported_on' value to match what the product actually supports.

BYPASS_POLICY_COMPATIBILITY_CHECK=The previous value was incorrect but
setting the correct value causes the policy checker to complain.

Bug: b/169582602
Change-Id: I9c4d27a73f2ab78d13a95d6ab49dabc7d65c200d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435098
Commit-Queue: Thomas Tellier <tellier@google.com>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Auto-Submit: Thomas Tellier <tellier@google.com>
Cr-Commit-Position: refs/heads/master@{#812716}

Previously the contents of the QR code changed because the keys were
continually rotated. The latency of BLE adverts turned out to be
significant however, so the acceptance window grew to the point where it
wasn't providing very much security.

The contents of the QR code no longer changes so this change animates
the QR code by rotating the masking function applied.

BUG=1002262

Change-Id: I5d1a179d0400b35e3840bf9fce356a038e5c2ead
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441300Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812715}

This reverts commit dc61429b.

Reason for revert: Speculative revert, see crbug.com/1133102

Original change's description:
> [Payments][Metrics] Extend expiry for ever-green metrics.
>
> Also updated ownership.
>
> Bug: 1128111
> Change-Id: Iba6ba54d4a47e02579faa69ff7078ba6ab012333
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426977
> Commit-Queue: Danyao Wang <danyao@chromium.org>
> Reviewed-by: Mark Pearson <mpearson@chromium.org>
> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
> Reviewed-by: Sahel Sharify <sahel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#811232}

TBR=mpearson@chromium.org,nhiroki@chromium.org,danyao@chromium.org,sahel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1128111,1133102
Change-Id: Ib9e0eba5421247c1d9b556fbe4fd82b2408b4a86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442793Reviewed-by: Danyao Wang <danyao@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812714}

This should make the tests more reliable since waitForAnimationEnd
simply rAFs x frames. In web_tests, rAF intervals are artificially made
much shorter than in the real world so this doesn't actually wait very
long.

The time based version waits using rAFs but breaks based on the wall
clock time (currently 200ms without a change) so it doesn't depend on
the rAF interval time.

Bug: 915926
Change-Id: I052cede0a3712911a9bd385929bec56d987af7a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442350
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Liviu Tinta <liviutinta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812713}

This adds the non-implemented (or deprecated) actions from
the backend to the list of reserved fields.

Bug: none
Change-Id: Id77bffb0da81c2d17362cf7a0e383fa810250528
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440669
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Auto-Submit: Sandro Maggi <sandromaggi@google.com>
Reviewed-by: Clemens Arbesser <arbesser@google.com>
Cr-Commit-Position: refs/heads/master@{#812712}

https://screenshot.googleplex.com/4HWAicLVp6pnhNp

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: I5f53c37dd5e99631438b736eed8211214292d70b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436953
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812711}

https://webrtc.googlesource.com/src.git/+log/59f1d1e36d26..281fb1ed7ba9

2020-10-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 97f841d7..2cdb2cb6 (812293:812617)
2020-10-01 philipp.hancke@googlemail.com stop sending x-peer-id in peerconnection_server
2020-09-30 glahiru@webrtc.org Replace one use of sigslot with RoboCaller

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ie7651293284447a1dd64711116bab8b06ae9165a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442715Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812710}

Previous OWNERS file was not located in the top level folder for the
given feature. This causes the ownership checks for DEPS rule changes to
fall back to the parent folder, and in this case, to //chrome/, which is
probably not what was intended.

Change-Id: Ica17765d2e5a974ee1b27b0a6d733cddf2dd37b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440972Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812709}

The user_education feature was recently moved from //chrome/android/ to
//chrome/browser/, see https://crrev.com/c/2422060. Because of the top
level -chrome DEPS rule, all of the places that previously used the
user_education feature are now in violation. Current usages are in the
following directories:

* //chrome/android/feed/
* //chrome/android/java/
* //chrome/android/junit/

Bug: 1127732
Change-Id: I57ab4659d420fa791774269badd370534279e7bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441670Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812708}

  EXPECT_FALSE(CFRangeToNSRange(CFRangeMake(LONG_MAX, LONG_MAX), &range_out));

is failing with a new clang roll, there may be some existing undefined
behavior due to signed integer overflow.

Bug: 1133974
Change-Id: I5a1de0db2753fcb9f325e0dfaa2c228268417e9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441736
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812707}

A column spanner essentially overrides the rules in
https://www.w3.org/TR/css-break-3/#unforced-breaks ; e.g. if a block has
a spanner as its first child, it's perfectly okay to break right before
the spanner, even if this means that we're not really breaking *between*
stuff (class A breakpoints only occur *between* siblings). So set break
appeal to perfect, or it'd be a last-resort breakpoint.

Bug: 829028
Change-Id: I34cb1853febe38a766cc74ebbc5efff61aee653c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440528Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812706}

This CL separates functions interacting with the PrefService from
KeyPermissionsService so that these functions can be used by other
components (such as KeyPermissionsManager see crbug.com/1127284) without
depending on KeyPermissionsService.

Bug: 1127284
Change-Id: I79120c1f05cc2582755ec596eebc4eedfff80e03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440475
Commit-Queue: Omar Morsi <omorsi@google.com>
Reviewed-by: Omar Morsi <omorsi@google.com>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812705}

Roll Chrome Linux PGO profile from chrome-linux-master-1601531335-92722dc44bbb5dcb3fdddbecff6eb0d1b4a38ee3.profdata to chrome-linux-master-1601553580-367c6f76c3cbdd1ced1ecc49db85241195c30ea6.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-linux-chromium
Please CC liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chrome
Tbr: liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com
Change-Id: I2b47ffdf2c6d4d0cfe46bc46f6a59285d4c35dbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442716
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#812704}

So that task with more workers yield to other tasks.
This works by recording both |priority| and |worker_count| the
same way we did for |min_allowed_priority_|

Change-Id: Ife315ad2304f4b417f85ebd338138354176fe013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390943Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812703}

This regression was caused by crrev.com/c/2339282, which suppresses with
a bad condition. The fix is to check for existing malware verdicts
before suppressing the metadata check verdict instead of just checking
if an async scan took place.

Bug: 1127454
Change-Id: Id23eb4e26124ea823b0687f9bbfe7f562d0fe7dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441281Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812702}

This CL adds TargetApi annotation for the incognito notification tests
which uses method that is available only from M.

Bug: 1134054
Change-Id: Ic0e91ac3438d69589a28a6dab20c09e70f5e3753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442015Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812701}

This will allow WebrtcVideoFrameAdapter to set feedback.
Currently, it may get a wrapped frame in some cases.
WebrtcVideoFrameAdapter is a logical place to attach feedback, since it's
the wrapper of VideoFrame available inside WebRTC.

Bug: chromium:1134073
Change-Id: Id955609dc00d4555294cd39192b55db66ac8f72a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440513
Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812700}

The OPEN IN.. toolbar wasn't displayed correctly when the "Fullscreen
Smooth Scrolling" feature was disabled.
To correct this, a top constraint has been added to the bottomMargin view
and the height calculation of the toolbar has been updated.


Bug: 1130529, 1133280
Change-Id: I5e60e1e63db70f5ca2f3b6ab79f32105d1ca1a2f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438132
Commit-Queue: Ewann Pellé <ewannpv@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812699}

PSA: https://groups.google.com/a/chromium.org/d/msg/blink-dev/sIGNgOAC0oc/TFST-dJxAwAJ

When srcset selects images, it takes the screen density into account,
but beyond a certain density, that can result in excessive downloaded
images.

Currently, when adding `w` descriptors to srcset, developers run a
risk that large `w` descriptor images will be used on small screens
with very-high density values.

For example, when defining
`<img srcset="300.jpg 300w,
              600.jpg 600w,
              1200.jpg 1200w,
              2400.jpg 2400w">`,
developers that define the 2400px wide image typically intend for it
to be used for very large screens (e.g. a 32" 2x screen), but it often
ends up also being used on small screens (e.g. a phone with 4x DPR and
viewport width of 600+px) .

Research[1] shows that density above 2-2.2x is not visible by most
people, and therefore we could avoid wasting those bytes and avoid
the related slowdown.

See https://github.com/whatwg/html/issues/4421 for full discussion

Change-Id: I52afd505b023767883088a939083f9f835e7fa14

BUG: 1125973

[1] https://observablehq.com/@eeeps/visual-acuity-and-device-pixel-ratio

Change-Id: I52afd505b023767883088a939083f9f835e7fa14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395619Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Yoav Weiss <yoavweiss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812698}

This eliminates the remaining target in the embedder directory by
merging its only interesting definition back into
content/public/common.

All references to the directory are removed here, including some stray
DEPS.

Bug: 977637
Change-Id: I43f77e0c9122289c82e9c24e851714cbeb3c6e38
Tbr: boliu@chromium.org
Tbr: thestig@chromium.org
Tbr: yucliu@chromium.org
Tbr: lazyboy@chromium.org
Tbr: kvitekp@chromium.org
Tbr: mbarbella@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441727
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812697}

ThemeColorProvider deals with colors on toolbar for a
suitable theme. It is mainly used within toolbar/, only by
a few outside the package(namely task.tab_management). This
CL moves the class to toolbar/ which it can be justified to
be a part of.

Bug: 1127732
Change-Id: I4730f3eab566e165b62e1a60ecf737eeb4c8c31a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423829
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812696}

PasswordAccepted.

Having this check ensures there is no nullptr dereference in case the
driver is deleted and the browser process is not aware of it (i.e.
in case when the renderer is compromised).

Bug: 1133635
Change-Id: Ieee8c2200a4b323af39f730011e733b74e8bc911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440095
Commit-Queue: Maria Kazinova <kazinova@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812695}

This reverts commit 71c10e67.

Reason for revert: Breaking Dawn's CQ. This CL likely needs to
update webgpu_blink_web_tests as well.

Original change's description:
> Change blink_web_tests and blink_python_tests test types.
>
> This CL changes the GN blink_web_tests and blink_python_tests
> targets to use a new script_test() GN template.
>
> A script_test is a kind of test target that implements the
> [test executable API](//docs/testing/test_executable_api.md)
> via a Python script (rather than being an executable target).
>
> :blink_web_tests, :blink_python_tests are examples of this type
> of test; other targets will be switched over in future CLs as well.
>
> Most importantly, using script_test() will ensure that
> the $root_build_dir/bin/run_$target_name test wrappers are
> generated with all of the appropriate arguments, simplifying the
> invocation of the test both for devs and for the bots.
>
> Bug: 816629
> Change-Id: Ib4bfd2342d762db24cdef75b64ed5dd7fbf3c10e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380936
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Robert Ma <robertma@chromium.org>
> Reviewed-by: Rakib Hasan <rmhasan@google.com>
> Cr-Commit-Position: refs/heads/master@{#812523}

TBR=dpranke@google.com,robertma@chromium.org,rmhasan@google.com

Change-Id: I16c0d8bfaebbeabbeee7dd98a0f4bb083403444f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 816629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442872Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812694}

When performing column layout, we need to tell the builder that it's to
generate a column box, as this determines the behavior when finishing
fragmentation; see IsFragmentainerBoxType() check in
FinalizeForFragmentation() in NGBlockLayoutAlgorithm). The other
entry points to column layout already take care of this, but it was
missing for the initial column balancing pass.

Bug: 829028
Change-Id: I60914b7adead19e4efa441d05733d4bd819dafd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440527
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812693}

This CL adds :
1 - Mediator unit tests for the video player.

Bug: 1117157
Change-Id: I27e000e63e6e528f7480caa0b26932fd89d5300e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430688
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812692}

Otherwise, for a selector such as ':is(:host(.a), .b) .c', the tree-
boundary crossing flag will be set when processing :host(.a), and then
incorrectly carry over to subsequent list items (i.e. .b).

Bug: 568705
Change-Id: I2a8eb5735c0fc44242d7c0e089b85814e6080b44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435190
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812691}

code.google.com redirects no longer work. This CL replaces links in /native_client_sdk/src/doc
to source.chromium.org equivalent.
This CL was uploaded by git cl split.

Change-Id: Iaa8ac8df6920e9ccfcf4a04ee09c4c36d32e6581
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392709Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Cr-Commit-Position: refs/heads/master@{#812690}

This Mojo pipe disconnects once the WebSocket handshake has completed,
but we want to carry on and use the WebSocket. So, instead, switch to
watching the pipe that carries frame information once the handshake
callback is complete.

BUG=1002262

Change-Id: I4586dd12cbf2051e3ee9bc461d239dcdd6a3fde8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441299
Auto-Submit: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#812689}

Given top: 0; bottom: 0; width: auto; aspect-ratio: 1/1;, we should
compute the width from the height.

R=ikilpatrick@chromium.org, mstensho@chromium.org

Bug: 1083010
Change-Id: I2ea7a791f827dc42ca07e0aaa1238584bfc47a32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442368
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812688}

An NTP is normally created for a new empty window. However, this
is not necessary when dragging and dropping a tab into a new
window.

Bug: 1132293
Change-Id: I720979235fdb447a5270f81a4b0c8451343ce773
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438941
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Auto-Submit: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812687}

This makes network reports and ReportingObserver's report similar.

Bug: 1090273
Change-Id: I0fce6f0a25153e6f32feaeaf713d44ab081c1a97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436533Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812686}

This stat will be used by the team working on the WebUI
tab strip to determine how much of a real world problem
failure of touch drag of tabs in the tab strip is.

Failure is detected by ::DoDragDrop blocking for more than one second
and only calling QueryContinueDrag once.

Bug: 1126230
Change-Id: I75b9d3a95912b8ef2ec049fcd32ed4700e4ca51d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437485
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812685}

This CL ensures that if an ideal or max frame rate is requested
via constraints in getUserMedia(), the requested rate will be
enforced using frame-rate adjustment, if necessary. Even if the
requested rate equals the reported native frame rate being used
by the device.

In practice, it has been reported that actual frame rates sometimes
exceed the rate reported by the device, so this ensures that
explicitly requested rates are produced in practice.

Prior to this CL, if the requested rate matched the rate reported
by the device, no attempts to adjust the frame rate were made.

Fixed: 1133796
Change-Id: If0699f97292b3bccc69205f861f059660355cc11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440758
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Auto-Submit: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812684}

The raw sim-hash values are needed by the server to calculate the
sorting-lsh cutting points and/or blocklist. We should always log it
regardless of the final result after applying the blocklist or (the
upcoming) sorting-lsh.

Removed the NotifyFlocUpdated method, as we no longer need to notify
floc update event (which could be useful for the header. we can add it
back later if we want the header).

Bug: 1062736
Change-Id: I50bba6a1f1945c7b1c57dfc01724c8375da89d2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438483
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812683}

When the intent launching code determines that a tab should be closed
(e.g., because the initial navigation resulted in the launch of an
intent), it posts a task to the embedder to asynchronously close the
tab. We are seeing crashes in WebLayer indicating that in the interim
the tab is being closed for another reason. TabImpl does not guard
against its destroy() method being called multiple times, and the crash
results due to members being invoked and then nulled out in that method.

This CL adds a targeted fix for this flow, changing //weblayer's
InterceptNavigationDelegateClientImpl to short-circuit out of its
closeTab() method if it has already been destroyed. I avoided changing
TabImpl#destroy() to guard against multiple invocations as in general
we would regard any such flows as errors that should be detected and
fixed (like this one).

I investigated making a test for this case but so far have been unable
to program a flow where I can cause a tab opened via an intent launch
to be destroyed in the interim between the navigation starting and the
intent launching code destroying the tab. It is worth pointing out that
I still don't know what use case would result in this flow in production,
so this is a speculative fix. Nonetheless, it is a good change to make
in any case.

Bug: 1132983
Change-Id: I2b3c5a1598f6f13887f70bff90d822afbbd3f3d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442626Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812682}

This CL continue the effort starting from [1], which converted to using
SharedRemote for Bluetooth operations. This fixes potential deadlock
issues when accessing WebRTC on different threads.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2440981

Bug: 1130069
Change-Id: I1debebdf4b8144f134b0ab4b27fc835fbf8236b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441489
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Richard Knoll <knollr@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#812681}

This was exposed when building code against libstdc++ instead of bundled
libcxx. The code uses memchr function, but fails to include string.h
declaring it. My guess is libcxx somehow pulls this indirectly for us.

Bug: 957519
Change-Id: If9b1253bf0c78a2784a74839dc11291de2490113
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440617Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Piotr Tworek <ptworek@vewd.com>
Cr-Commit-Position: refs/heads/master@{#812680}

This change is not strictly necessary to clean up the address space
computation logic currently spread around third_party/blink/renderer,
but it offended my sensibilities that we would represent an IP address
as a string :)

Bug: chromium:1124358, chromium:955213
Change-Id: Ica9957042d5cf222a9e0a053714f4ad7ed7c3cdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421891Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Auto-Submit: Titouan Rigoudy <titouan@chromium.org>
Commit-Queue: Titouan Rigoudy <titouan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812679}

Fuchsia is transitioning from UTC time being tracked in the kernel,
to userspace UTC clock handles.

This preserves the existing behavior that each chromium process
has access to the global UTC clock.

Bug: 1133580, fuchsia:61060
Change-Id: I8ff3d3033a47814dac1a1dd5946ca1fe872ead13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440983
Commit-Queue: Wez <wez@chromium.org>
Auto-Submit: Adam Lesinski <adamlesinski@google.com>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812678}

This CL proposes refactoring Init/DoInit methods by moving the overlay
and frontend parameters to the constructor to avoid confusion about
at what time they are set on a tool. Also, it removes DoInit/Init methods
and moves the ScreenshotTool's init to the constructor as well.

Change-Id: I246c1383c66f6977c0b69fd82938a6c7baa192e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428926Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812677}