GitLab

Change-Id: I1ad110c817b75e62116dfcb0fabe17eb9f40088f
Reviewed-on: https://chromium-review.googlesource.com/c/1351598Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611006}

 - change ProgressCenter externs file to be an @interface class
 - rename background page ProgressCenter to ProgressCenterImpl,
   and make it @implement the {ProgressCenter} interface
 - use ProgressCenterImpl as the implementation for Files App.
 - make MockProgressCenter @implement ProgressCenter for tests
 - add missing ProgressCenter methods to MockProgressCenter to
   make it Closure compile.
 - BUILD rules for progress_center, and mock_progress_center,
   were added in CL:1349139, and CL:1349147, respectively.

No change in test behavior, no new tests.

Bug: 908379
Change-Id: I087b72abce9221d464761724e3fcf2ccdb2dfad5
Reviewed-on: https://chromium-review.googlesource.com/c/1350563Reviewed-by: Stuart Langley <slangley@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611005}

Bug: 907693
Change-Id: I3514c9aa5aacf68e7b9964b637ac79c5fbe29b50
Reviewed-on: https://chromium-review.googlesource.com/c/1351286Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611004}

Bug: 908573
Change-Id: I13cbff6aae855aebe0194e71308b0c97faed3680
Reviewed-on: https://chromium-review.googlesource.com/c/1351505Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611003}

https://chromium.googlesource.com/angle/angle.git/+log/15992bef28d8..5552cdf032dd


git log 15992bef28d8..5552cdf032dd --date=short --no-merges --format='%ad %ae %s'
2018-11-26 syoussefi@chromium.org Vulkan: Create buffer view for BufferHelper
2018-11-26 geofflang@chromium.org Vulkan: Implement ANGLE_translated_shader_source
2018-11-26 syoussefi@chromium.org Vulkan: Implement vk::BufferView
2018-11-26 jmadill@chromium.org Update clang-format settings.
2018-11-26 geofflang@chromium.org GL: Work around Qualcomm sRGB ReadPixels driver bug.
2018-11-26 geofflang@chromium.org GL: Implement GL_NV_fence on top of GLsync objects.
2018-11-26 matavenrath@nvidia.com Don't generate TypeInfo objects as static objects within GetTypeInfo function
2018-11-26 tobine@google.com Debug: Add Systrace Markers


Created with:
  gclient setdep -r src/third_party/angle@5552cdf032dd

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:882580
TBR=fjhenigman@chromium.org

Change-Id: Ifb31c9d8ba778ce1fa9528b3981749391828e293
Reviewed-on: https://chromium-review.googlesource.com/c/1351471Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611002}

Bug: none
Change-Id: I698f0ddd7625b432bbb8ae75f4574181d30f991b
Reviewed-on: https://chromium-review.googlesource.com/c/1351385Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611001}

 - remove device_handler_unittest.html
 - add BUILD rule to auto-generate this unit test
 - add BUILD rule to Closure compile this unit test
 - rename handler -> deviceHander, use mockChrome
   everywhere and also install it during Setup()
 - remove unused timeoutCallbacks var
 - fix Closure errors, js code auto-format

No change in test behavior, no new tests.

Bug: 908673
No-try: true
Change-Id: I46535df1c77a57c488e40f9c410ca4a62ad73ac5
Reviewed-on: https://chromium-review.googlesource.com/c/1351336
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611000}

The first time when FilesApp is started in a session, it should
show a toast displaying the number of folders currently
shared with crostini, and a link to manage sharing.

* Added state to crostini::CrostiniSharePath keyed profile service
for whether the GetPersistedSharedPaths function has been called
in a session.

* Change FileManagerPrivateInternalGetCrostiniSharedPathsFunction
to call file_manager::util::ExtractMountNameAndFullPath which allows
Entry to be set sync rather than async via
file_manager::util::ConvertFileDefinitionListToEntryDefinitionList

* Changed CommandHandler.recordMenuItemSelected to be public to
allow us to record UMA when user selects 'Manage sharing' in the
startup toast.

Bug: 878324
Change-Id: I283eb49b61bafdde414a7d1b7aa0723997687742
Reviewed-on: https://chromium-review.googlesource.com/c/1350375Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610999}

The non-pnacl gcc-based nacl compilers embed absolute paths in their debug info.
This is bad for goma usage and build determinism.  Since I've never
seen a stack in nacl-built code and neither the code nor the toolchain
are changing much anymore, just disable symbols for nacl-built code.
(The same code when built with a non-gcc nacl toolchain of course still
has symbols, including the nacl-clang-built IRT where we archive the symbols for
production builds.)

Bug: 899438,906741,429358
Change-Id: I3062a26f25281759cc240f1967ab670f28e562a6
Reviewed-on: https://chromium-review.googlesource.com/c/1351492Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Derek Schuff <dschuff@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610998}

R=bnc@chromium.org

Change-Id: I4645a737b8554c86ab4f21361e44cadae84f2d4b
Reviewed-on: https://chromium-review.googlesource.com/c/1347213Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610997}

ExploreSitesService is a lightweight object that lazily initiates heavier resources on demand.
Currently, it is created by UI (NTP page being open), however it starts subsequent
background activities (refreshing the catalog of sites, and collectingusage statistics)
so it should be started even if UI does not require it. This CL adds the service to dependency
manager list so it is created early in the initialization of Profile.

Bug: 905120
Change-Id: I63c30decd2bc9e70729438cc06a596089efcd585
Reviewed-on: https://chromium-review.googlesource.com/c/1334936
Commit-Queue: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610996}

-Change VLOG(1) and VLOG(2) to LOG(INFO).
-Change VLOG(3) and VLOG(4) to DVLOG.
-Remove the usage of CMALOG(kLogControl)

BUG=internal b/73490388

Test=locally build.

Change-Id: I27976d42ef57346c348b496690a79b870655e9d1
Reviewed-on: https://chromium-review.googlesource.com/c/1343560Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
Commit-Queue: Ziyang Cheng <ziyangch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610995}

The out-of-flow code assumed that all fragments for a
LayoutInline has the same height, but the change for
crbug.com/903578 (WIP CL:1251142) breaks the assumption.

This patch fixes by computing the rect and uniting them,
instead of taking the max of heights.

No behavior changes until the WIP CL lands.

Change-Id: I9fe6b35d25836fde10dd88dd90ca2a810f5c9863
Bug: 636993, 903578
Reviewed-on: https://chromium-review.googlesource.com/c/1351189Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610994}

This domain was submitted via hstspreload.org, but since it's in the
Google section of the preload list, I'm processing it manually.

Bug: b/67939706, crbug.com/867024
Change-Id: I9007c6bf02b5e2871a4e398dc1388b5cf37932bb
Reviewed-on: https://chromium-review.googlesource.com/c/1345213Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610993}

Cyan device doesn't support 4160*3120 resoltuion, removes this
resolution since not all devices support it.

TEST=ran jpeg encode tests on cyan
BUG=b:119928581

Change-Id: I2593e57f1478cfbd9806e8879b77925e851ccf23
Reviewed-on: https://chromium-review.googlesource.com/c/1350446Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: Hsu Wei-Cheng <mojahsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610992}

Move playout channel selection and mono mixing to StreamMixer to
simplify the logic.

Bug: internal b/118685514
Change-Id: I6c2d871d23958d615c4bf828b5b6013929e3bea0
Reviewed-on: https://chromium-review.googlesource.com/c/1347207Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610991}

This feature is behind the Experimental Web Platform feature flag.

Spec PR: https://github.com/whatwg/html/pull/4048

Bug: 813452
Change-Id: I84c58035789b64a311637cebc4672d16661980c2
Reviewed-on: https://chromium-review.googlesource.com/c/1350558Reviewed-by: Dominic Farolino <domfarolino@gmail.com>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610990}

base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
explicit counterpart.

It should have been replaced by :
 * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
 * base::ScopedAllowBaseSyncPrimitives in non-test files
 * base::ScopedAllowBaseSyncPrimitivesOutsideBlockingScope when it's used on threads
   that don't allow blocking
The last one is strongly frowned upon but this CL aims to document existing
behavior rather than address it. Owners are encouraged to follow-up by fixing
unnecessary waits and more particularly unnecessary waits
outside-blocking-scope.

Note: The non-for-testing versions require friend'ing in thread_restrictions.h
but care was taken to add these friends ahead of git cl split (since it wasn't
possible to do a line-by-line associated CL split).
Refer to the top-level CL if necessary :
https://chromium-review.googlesource.com/c/chromium/src/+/1288533

Please CQ if LGTY!

This CL was uploaded by git cl split.

R=satorux@chromium.org

Bug: 766678
Change-Id: I6855a1ea8732e053ad687cfc2318bf001a9a4b6f
Reviewed-on: https://chromium-review.googlesource.com/c/1325207Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Satoru Takabayashi <satorux@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610989}

`is8_bit` was renamed to `is_8bit` in r610457 (CL:1347430).

This patch matches `webkit.natvis` to the new naming.

Tested with natvis warning enabled in VS2017 15.7.1.

Bug: 834780
Change-Id: I7b4dc417e195c530aa36ec387ed6c5f111782d4a
Reviewed-on: https://chromium-review.googlesource.com/c/1350387Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610988}

Should consider whether the dragged window can be snapped when trying
to get the snap position on the drag position. Then in multi-tabs drag,
drag one tab out of the source window will not put the source window to
the snapped window's position during drag. Note, browser window may
can't be snapped on different display bounds or scales.

Bug: 905924
Change-Id: I9166092af4252ca44b221da082be1fdb0297f034
Reviewed-on: https://chromium-review.googlesource.com/c/1345425Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610987}

Since we expect this feature has positive impact, so it would
better to not asking again and again.

Bug: 806868
Change-Id: I4dd50a60a9dc350cb0710d333f1489d3a4967a5d
Reviewed-on: https://chromium-review.googlesource.com/c/1351582Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610986}

Change-Id: I0ee5281937ff58104acc3a1edab1926728cce020
Reviewed-on: https://chromium-review.googlesource.com/c/1345410Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610985}

Bug: 907562
Change-Id: Iffe499a9329501cf0a1e439be29f606c746737a6
Reviewed-on: https://chromium-review.googlesource.com/c/1351096Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610984}

Reland of https://chromium-review.googlesource.com/1330903
with renaming due to crbug/906964.

Bug: 835717, 880027, 906964
Change-Id: I0eeca00cc7a0db2cb2efb16588b0cf52c14883f0
Reviewed-on: https://chromium-review.googlesource.com/c/1344434
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610983}

This reverts commit 66794d00.

Reason for revert: This breaks mash_browsertests. See https://crbug.com/908623

Original change's description:
> Start gpu channel and compositor mojo pipe collection eagerly
> 
> When a RenderWidget is frozen, its compositor is stopped. However when
> the main frame is being navigated, we want to start requesting mojo
> pipes for the gpu and display compositor immediately so that it can
> happen in parallel with the navigation loading.
> 
> Previously, we just always did this when creating a RenderWidget, and
> left them active when freezing the RenderWidget. After 678f025f
> however, we don't, and this causes time-to-first-pixels regressions
> on navigation.
> 
> So we add a WarmupCompositor() method to RenderWidget, and call this
> from RenderFrameImpl::CreateFrame() when it makes the provisional
> frame, and the WebFrameWidget, since we expect to make use of the
> main frame RenderWidget shortly.
> 
> Then, if RenderFrameImpl::FrameDetached() occurs, due to the
> navigation failing, we will AbortWarmupCompositor() to drop the
> mojo pipes instead of holding onto them indefinitely.
> 
> This recovers the loading regressions introduced, while also not
> allocating mojo channels for frozen RenderWidgets indefinitely.
> 
> In order to do this reasonably, we drop the "callback" from the
> request to RenderThreadImpl::RequestNewLayerTreeFrameSink so that
> it always returns something immediately. This way RenderWidget
> does not need to worry about having a task run to collect the
> new frame sink, and ordering with tasks from the compositor to
> collect it.
> 
> R=​piman@chromium.org
> 
> Change-Id: I6007e26e1622006652ce3619cdd080539d11e7b0
> Bug: 905191
> Reviewed-on: https://chromium-review.googlesource.com/c/1341073
> Commit-Queue: danakj <danakj@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Antoine Labour <piman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610909}

TBR=danakj@chromium.org,dcheng@chromium.org,sergeyu@chromium.org,piman@chromium.org

Change-Id: Ifadae837dd5dbd8c1c31212704c6ee88843bd0d1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 905191
Reviewed-on: https://chromium-review.googlesource.com/c/1351808Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610982}

We have the Performance class and the PerformanceUserTiming class. The
Performance is used to connect different performance APIs, one of which is the
UserTiming's mark API. The PerformanceUserTiming should be the main part to
deal with UserTiming logic. Currently, too much UserTiming logic is stored in
Performance. We should move them to PerformanceUserTiming.

This CL is intended for the refactoring.

Bug: 738685
Change-Id: I77c3b685a1a7f6df49539f6661c41492f0a44b7f
Reviewed-on: https://chromium-review.googlesource.com/c/1348865Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610981}

For an unknown reason, the a11y tests currently miss these failures. These are
triggered somehow by the changes in an upcoming CL (1324915), maybe indicating
a timing issue in a11y tests (should be investigated separately,
filed crbug.com/907676).

Tests that are fixed:
 - SettingsAccessibilityTest.ABOUT_image_alt
 - SettingsAccessibilityTest.ABOUT_region
 - SettingsA11ySignOut.SIGN_OUT_button_name

This CL is in preparation of removing neon-animation from Settings WebUI.

Bug: 907333
Change-Id: I9fd7c03a5f1f6105b144403aa3fc358fcd4333e2
Reviewed-on: https://chromium-review.googlesource.com/c/1345127
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610980}

CL also partially needed to touch bits on signin_ui_util.cc|h
and people_handler.cc, both files properly listed on the BUG=
line below.

BUG=907486,898810,890796

Change-Id: Ic0d39cb14e100ae10375f66ca51fd526f3b2d64a
Reviewed-on: https://chromium-review.googlesource.com/c/1348674Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#610979}

Change-Id: Iaeb902e565ad0dd695cbf70bad7a801d6fd8f34b
Reviewed-on: https://chromium-review.googlesource.com/c/1351381Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610978}

The code checking for problemating floating point math should not be
part of the M72 beta/stable releases so removing it for now.  It will
likely be restored in some form after the branch occurs.

Bug: 836238
Change-Id: Id6f95382589de7e3d5a05cefa09087e2e598e4ad
Reviewed-on: https://chromium-review.googlesource.com/c/1351091Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610977}

TBR=miu@chromium.org

Bug: 908611
Change-Id: I301ab697a2ec894067f62d95beada1fa5f45ba75
Reviewed-on: https://chromium-review.googlesource.com/c/1351800Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610976}

New versions of protoc require a java lite plugin to generate lite
protos. That will be added to the checkout inside
third_party/protoc_javalite using cipd.

Bug: 782237
Change-Id: I808b0acc14832c80e5efc4baacffb3323bc98653
Reviewed-on: https://chromium-review.googlesource.com/c/1338207
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Grace Kloba <klobag@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610975}

This reverts commit 7149ab70.
https://chromium-review.googlesource.com/c/chromium/src/+/1300038

TBR=nednguyen@google.com

Bug: 908515
Change-Id: I08a2b7adbf9fa20c8ccc2d8b6573981f0828c12d
Reviewed-on: https://chromium-review.googlesource.com/c/1351501Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610974}

This is a partial re-land of:
https://chromium-review.googlesource.com/c/1344097
"Read master preferences before create variations to allow
to migrate variations from master preferences to Local State"

That CL's diff is in patchset 1.

However, that CL caused a crash on first run in official builds
due to official build first run logic relying on ResourceBundle
being initialized.

That CL tried to move all first run master prefs import logic to
be earlier. This CL partially reverts that and only moves the
logic specific to variations' first run (which does not depend on
ResourceBundle) earlier, while keeping the rest of first run
import in the same place as before.

Confirmed that this fixes the crash on official builds while
still fixing variations first run.

Also adds a CHECK about ResourceBundle being initialized in the
non-official build codepath too, to match what official build
does.

TBR=cpu@chromium.org

Bug: 907434
Change-Id: I6ae4be40e376d61dd043e37fc4e35bce59473af0
Reviewed-on: https://chromium-review.googlesource.com/c/1351090
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610973}

Bug found coding/testing
https://chromium-review.googlesource.com/c/chromium/src/+/1350375

Bug: 878324
Change-Id: I800bf263f17370d43c7b8413cd6af9cd819bfd0c
Reviewed-on: https://chromium-review.googlesource.com/c/1350421Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610972}

Before this patch, entering an existing card into Payment Request sheet
would show an error "This card is already used". This happened for both
local cards, which are visible in Payment Request sheet, and for server
cards, which can be accessed only in tokenized form through Google Pay.

This patch allows re-entering existing cards.

After this patch, entering an existing card into Payment Request sheet
is allowed. This sheet may display two identical cards after the user
added the card. Autofill will deduplicate two identical local cards, so
the consequent autofill popups and Payment Request sheets will display
the card at most once. In settings, the user will see the card twice
only if one card is local (entered through Payment Request sheet) and
the other card is from the server (synced down from Google Payments
account).

Android already behaves this way.

Bug: 905396
Change-Id: I587e682855075f7035573f89dfd77711b45879ac
Reviewed-on: https://chromium-review.googlesource.com/c/1340377Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610971}

Adds the --output-dir option to sizes.py, which specifies a directory to
dump collected data to in the HistogramSet format. This is the first
step to getting the sizes step working on LUCI, which can't use the
older CharJSON data format for uploading due to it being tied to IP
whitelisting for authentication.

Bug: 906685
Change-Id: Ic4169c34c20d456144af5b15e50acb303affed4c
Reviewed-on: https://chromium-review.googlesource.com/c/1343344Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610970}

When the filter option is selected, matches (rows) which do not match the search query are hidden; when the highlight option is selected, matches which do match the search query are highlighted (light blue).

Bug: 891303
Change-Id: I4c34dae1a1cef2c7baeffdd6de0355ef7ea53f0a
Reviewed-on: https://chromium-review.googlesource.com/c/1340904Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610969}

This splits out the python style guide from the root directory and
allows a better way to facilitate discussions surrounding python style.

This is especially useful as we are now starting to use the yapf
formatter. To reduce the delta from original doc, no mention of yapf was
added, but it will be added here in the future when it is turned on by
default.

Bug: None
Change-Id: Ib524512459cdc4e4872246457e414e0636979dc1
Reviewed-on: https://chromium-review.googlesource.com/c/1347029
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610968}

BUG=907805

Change-Id: I519ba858fdca946ba5541000b2b74359969a697d
Reviewed-on: https://chromium-review.googlesource.com/c/1350980Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610967}