- 11 Mar, 2020 40 commits
-
-
Chris Hall authored
- specifying types of constants. - clarifying comment references to functions and variables. - adding `using` aliases to shorten long library type names. - adding explicit type for value returned from library. These changes came out of suggestions from thestig@ on crrev.com/c/1949807 R=thestig, akihiroota, dmazzoni Change-Id: I25fc99843c27f7a41403f15e3e82d688fd5b44fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096417 Commit-Queue: Chris Hall <chrishall@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#749064}
-
Eric Willigers authored
We no longer use Extensions APIs to configure the web app to open in a window. Bug: 1054116 Change-Id: I0f05d939d3109eef7bf5de25ae452c52f3361b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096422 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#749063}
-
Hirokazu Honda authored
This reverts commit d47ac572. Reason for revert: Cause gpu hang on octopus (b/150964098) Original change's description: > media/gpu/vaapiVEA: Manage VASurfaceID by ScopedID > > VaapiVEA manages VA Surfaces with the ids. They need to be destroyed > by vaDestroySurface(). The ids are pooled for recycling. Some > ids has not returned to the pool, so that they are never > destroyed. This CL fixes the leakage by managing VASurfaceID > by ScopedID. > > Bug: b:143957628 > Test: video.EncodeAccel.* > Test: Open & Record & Close CCA multiple times > Change-Id: I86743fe80973fc3e850d543e38dcfe2764b2a710 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060388 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745351} TBR=mcasas@chromium.org,hiroh@chromium.org,andrescj@chromium.org,wtlee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:143957628, b:150964098 Change-Id: I1bddc70915287d93e1e38ed8a2c8b79ad36f8bae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097779Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#749062}
-
Koji Ishii authored
This patch rebaselines the last two remaining failures in paint/invalidation. These two tests invalidates more than |NGPaintFragment| does, but are equivalent to the legacy. TBR=wangxianzhu@chromium.org, yosin@chromium.org Bug: 982194 Change-Id: I016043e2c1440319fee9cfaa4011e2014e6e4981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096405Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749061}
-
Noel Gordon authored
Class is cool but attributes are too: when they are concise as here so reader does not have to read so much, and fewer bytes on the wire. Bug: 1035691 Change-Id: I77ed2fdc0e51526719a57f4fc1b168a986320ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097680Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#749060}
-
Julie Jeongeun Kim authored
These macros are used when implementing GObject interfaces to help mitigate accidental misuse of the API. We were using them, but not consistently in the AuraLinux accessibility implementation. This change makes their use more consistent. The original author of this CL is Martin Robinson<mrobinson@igalia.com> Bug: 1032019 Change-Id: I75ee57eea79ab11202924f9b04bd1def78dd5fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096167 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#749059}
-
nancy authored
https://ci.chromium.org/p/chromium/builders/ci/Libfuzzer%20Upload%20Chrome%20OS%20ASan/29774 TBR=sky@chromium.org TBR=agawronska@chromium.org BUG=1060430 Change-Id: I0608315ef2b4d8991e6deacd8282a88efc7b4e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096333Reviewed-by:
-
Yoichi Osato authored
This CL fixes the redirect bug that crrev.com/c/2059889 introduced. It removed body copy at redirect in renderer but when OOB-CORS is disabled, we still need body. third_party\blink\web_tests> $ python.exe ..\tools\run_web_tests.py --additional-driver-flag=--disable-features=OutOfBlinkCors external/wpt/xhr/event-upload-progress-crossorigin.any.html .. Fixed: 1059776 Test: Change-Id: I9516719c1e18d8cedcf4e621d8ab3e0157d10844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096161Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#749057}
-
Kent Tamura authored
This improves code readability. This CL has no behavior changes. Bug: 1052232 Change-Id: Ib4b1ed17cc84ac5a29af15003527bed66e5273a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096329Reviewed-by:
-
Fergus Dall authored
Bug: 1024693 Change-Id: I6b6db68ae72ed7eca908706e922092a553e57192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089181Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#749055}
-
John Palmer authored
Bug: 1060433 Change-Id: I8f3dfc2d7d9c56fc6373475a46da7b0cbfa029f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094914 Auto-Submit: John Palmer <jopalmer@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#749054}
-
Yutaka Hirano authored
Bug: 1011392 Change-Id: Id4bf79d0d2c69566465d73c1cfc42cb47e62c858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096323Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#749053}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3fc1f900e63d4a1a760e7ab857ae38677e16e703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094633Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749052}
-
Takashi Toyoshima authored
These tests inherit CrSettingsV3BrowserTest and override featureList getter. This results in ignoring the network::features::kOutOfBlinkCors enabed in the super class, and causes failing in BlinkCORS fyi bots. TBR=rbpotter@chromium.org Bug: 1026426 Change-Id: Ib194b6ca402af196d5f701cd3bd2cefd920ee6a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097676Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#749051}
-
Ramin Halavati authored
The following preferences are removed from persistent preferences in incognito mode: - metrics::prefs::kInstallDate/kUnisntall* - metrics::prefs::kMetrics* - metrics::prefs::kStability* - metrics::prefs::k*CellDataUse After this change, if these preferences are written to an incognito profile, they would not be persisted in their regular profile. All of these preferences are already written to local state. Bug: 861722 Change-Id: Iad0df3d31462a8373432d38a591a131ea8e27679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095718 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#749050}
-
Yoshifumi Inoue authored
This patch changes |TextSuggestionController::HandlePotentialSuggestionTap()| not to use null settings from |LocalFrame| for avoiding crash. Note: This is an experimental patch, because we are not sure actual reason about |TextSuggestionController::HandlePotentialSuggestionTap()| is called for document without frame. Bug: 1054955 Change-Id: If852d2e4dcf4cda40303dfea581e79efc3921642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096160 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/430e4a09e0ca..ed678386b4ac git log 430e4a09e0ca..ed678386b4ac --date=short --first-parent --format='%ad %ae %s' 2020-03-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision ad5dd080..9a91e044 (748920:749020) 2020-03-10 kron@webrtc.org Add RTC_EXPORT to webrtc::Clock 2020-03-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4fa1454b..ad5dd080 (748775:748920) Created with: gclient setdep -r src/third_party/webrtc@ed678386b4ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011581 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I077a473095a7acb3bd3687c33db7189cf1f078b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096711Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1003942d..fd848c18 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7662520313283cb0e42c967fba72e948f85523df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097636Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749047}
-
Shimi Zhang authored
Found by Tricium in http://crrev/c/2097537 Bug: None Change-Id: I53fedefb2f763bfc57080588eb95c8d07a7ba973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097529 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Auto-Submit: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#749046}
-
Takumi Fujimoto authored
Record the following metrics for the native Cast MediaRouteProvider: MediaRouter.CastStreaming.Session.Launch MediaRouter.CastStreaming.Session.Length MediaRouter.CastStreaming.Start.Failure.Native MediaRouter.CastStreaming.Start.Success These metrics are already being recorded by the Cast MRP in the component extension (MediaRouter.CastStreaming.Start.Failure is recorded instead of MediaRouter.CastStreaming.Start.Failure.Native in the extension because their enums are different). Bug: 954565 Change-Id: I476fdf417ccf085d3d122dc10d8ff976c8f8450f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080703Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#749045}
-
Rob Schonberger authored
- Palm Detection when the touchscreen reports the max radius - Palm Detection when the touchscreeen reports a palm itself Both are experimental features and documented as such, and or on by default already, etc. Bug: 1060051 Change-Id: I130c466a03b9a295c1b2777589ffc8a3ea8a5be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094908 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Sean O'Brien <seobrien@chromium.org> Cr-Commit-Position: refs/heads/master@{#749044}
-
Jinsuk Kim authored
Permission UI requires a ModalDialogaManager from the associated WindowAndroid instance, which was not available on Preview Tab. This CL overrides |ActivityWindowAndroid.getModalDialogManager| passed to the ThinWebView object of Preview Tab so that the permission UI can be displayed. Verified on a local device that this fixes the reported crash, and shows the permission UI as expected. Bug: 1057951 Change-Id: Ic7745d40edbea466ab1fef2de176743c3fda675d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094386Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#749043}
-
Jeevan Shikaram authored
UseLocalPrediction/LoadingPredictorBrowserTestWithOptimizationGuide. NavigationHasLocalPredictionNoOptimizationHint/0 is failing deterministically on linux-chromeos-rel. TBR=tbansal@chromium.org Bug: 1060426 Change-Id: I2c9b0b9781d1d51de8911f34aa7d1bb689416996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097618Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#749042}
-
Xiaocheng Hu authored
The function is only used by FontFallbackList::GetShapeCache(). This CL changes it into a private function for better code health. Change-Id: Ic1bcdf1393395bd527d971462b65383196d8a28b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097151 Auto-Submit: Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Jeevan Shikaram authored
This reverts commit c7695f63. Reason for revert: Possible reason for win10_chromium_x64_rel_ng failing builds with error: lld-link: error: undefined symbol: __llvm_profile_dump >>> referenced by .\..\..\base\test\clang_profiling.cc:23 >>> obj/base\base/clang_profiling.obj:(void __cdecl base::WriteClangProfilingProfile(void)) Original change's description: > Make the coverage config reusable for generic profiling. > > Most of the coverage configuration can be re-used for general > Clang-based profiling (e.g. the profiling step of a PGO build). > This changes most of the |use_clang_coverage| checks to > |use_clang_profiling|. > > The toolchain opt-out option is still limited to the coverage > builds (grep for "toolchain_use_clang_coverage" in CodeSearch). > I.e. targets built simply with |use_clang_profiling=true| won't > be opted out by the clang_code_coverage_wrapper.py script. > > This CL is a pure refactoring with no functional change. > Getting profiling information from the sandboxed renderers work > this way: > - After creating a new child process the browser will open a > profiling file for this process and pass the handle to the > child via the SetProfilingProfile Mojo call (see change in > content/browser/renderer_host/render_process_host_impl.cc). > - This process will used by the LLVM instrumentation to record > profiling information. > - When terminating, child processes will call > WriteClangProfilingProfile to write the data to the profiling > data file. > - Once all the raw profile data files have been collected, > they'll be merged (via the "llvm-profdata" tool) and used. > > Note that this isn't meant to be enabled into any build that > will be shipped to users (a profiling build is usually 10x > bigger than a normal build anyway, not really shippable). > > The goal of this refactoring is to make it possible to reuse > this mechanism for the instrumentation step of PGO builds. > > Bug: 1058979 > Change-Id: If8321234f6b6f86befd81f6e9e068a342728d605 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090493 > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Sajjad Mirza <sajjadm@chromium.org> > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749015} TBR=sky@chromium.org,thakis@chromium.org,wfh@chromium.org,sebmarchand@chromium.org,liaoyuke@chromium.org,sajjadm@chromium.org Change-Id: I6aaf638f6385afe35c488575aac84e3e952b76a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1058979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096332Reviewed-by:
-
John Budorick authored
waitForTabToFinishRestore currently checks whether there's *exactly one* existing navigation entry that matches the expected url. If it doesn't, they wait for *any* subsequent navigation that matches the expected url. Tab restoration appears to trigger navigations to about:blank and then the expected url; if we check after both navigations have been received, we'll wind up waiting on the latch until it times out. This CL updates waitForTabToFinishRestore to check for any previous or future navigation entry that matches the expected url, which should avoid that race. Bug: 1060317 Change-Id: I6fa584ff4537af74ee1ceafdfca57fdc6485fa84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097246Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#749039}
-
Anand K. Mistry authored
This only changes the base::Value API usage to the new style, and avoids changing functions signatures, except for private helper functions. Bug: 646113 Change-Id: I5dcd6d5c7df7dd185f7fc84d4563da82394fca9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089438 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#749038}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3e192165cb65..c2fe5ee2b3a1 git log 3e192165cb65..c2fe5ee2b3a1 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 reed@google.com refactor where we wrap clipshaders, in prep for gpu backend 2020-03-11 mtklein@google.com simplify skvm clip shaders 2020-03-11 mtklein@google.com skvm clip shader support 2020-03-11 mtklein@google.com skvm local matrix shader Created with: gclient setdep -r src/third_party/skia@c2fe5ee2b3a1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: brianosman@google.com Change-Id: Ice3644fcbdaa1371b2eb0478b21732b5f391fef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097524Reviewed-by:
-
Lukasz Anforowicz authored
This CL avoids sending |page_url| and |frame_url| as a payload of FrameHostMsg_ContextMenu. The CL accomplishes this by splitting the old ContextMenuParams struct into: 1. UntrustworthyContextMenuParams: - Sent over IPC. - Doesn't include |frame_url| nor |page_url|. 2. ContextMenuParams: - Never sent over IPC (no IPC traits are defined). - Includes |frame_url| and |page_url| which are populated based on browser-side data (rather than IPC-based data). - Cannot be copy-constructed directly from UntrustworthyContextMenuParams, except by RenderFrameHostImpl. Fixed: 534561, 1059083 Change-Id: I80239532aa693a0cb80aab29dcf4824bbb971e13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091921Reviewed-by:Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#749036}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I83dd721bdc015497f807c406e3dbc10263a30617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097499Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749035}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/52d0627d5607..421684f9438d git log 52d0627d5607..421684f9438d --date=short --first-parent --format='%ad %ae %s' 2020-03-11 jiawei.shao@intel.com Support Storage Textures as Valid Binding Types Created with: gclient setdep -r src/third_party/dawn@421684f9438d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iea6b9e75a37cf4a486e3270461bead2d8a38ed9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097523Reviewed-by:
-
Joel Hockey authored
TerminalSource moved in crrev.com/c/2077318 without updating OWNERS. //chrome/browser/ui/webui/chromeos/terminal was empty except for OWNERS file which is deleted in this CL. Change-Id: I37a77eb1bc96a92a546c1cefc0d40e93e702dfae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096173 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#749033}
-
Joel Hockey authored
Step 2 of 2 to disallow terminal from spawning crosh. * crrev.com/c/2094066 * crrev.com/c/2089558 Adds a new terminalPrivate.openVmshellProcess function which is to be used by terminal. This function can open vmshell, but not crosh. Terminal CL must be landed first which supports calling either openVmshellProcess or openTerminalProcess. Bug: 1056049 Change-Id: I0e4b54741aafcb3d6683f8ec668e94eaeec78ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089558Reviewed-by:
Jason Lin <lxj@google.com> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/fe6381e8e366..dbb6fcdf4353 git log fe6381e8e366..dbb6fcdf4353 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 tsepez@chromium.org Fix indexing in CFXJSE_FormCalcContext::concat_fm_object(). 2020-03-11 tsepez@chromium.org Use WideStringViews in CPDF_InteractiveForm. 2020-03-10 tsepez@chromium.org Fix faulty indexing CFXJSE_FormCalcContext::unfoldArgs(). Created with: gclient setdep -r src/third_party/pdfium@dbb6fcdf4353 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1004106 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I08d130b1dcf9f28185533945ebbe082a6ea91deb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097518Reviewed-by:
-
sauski authored
This is a reland of 01d497a6 Original change's description: > Safebrowsing radio toggle addition to the security page > > Adding a new collapsible radio toggle to the security page that includes a third safebrowsing option (enhanced), with more thorough explanations for this third option and the already available standard and disabled options. > > Bug: 1032584 > Change-Id: I6e4732ae464120d3d264b141dbb172aa125f9824 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088851 > Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> > Auto-Submit: Sean Harrison <harrisonsean@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#748394} Bug: 1032584 Change-Id: I4a61ba4b0b17615c4e88553c102cf435af352979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096091 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#749030}
-
Alex Danilo authored
Clicking on the application to move focus away from the search box should collapse it. Change the collapse listener to trigger on event capture phase so that any calls to preventDefault in other UI components won't block the event and collapse will happen. Note, that clicking on UI elements such as the splitter bar and moving it does not take focus, so the search box will not collapse. Bug: 1058547 Change-Id: I145c5c1f0dda09b21175cf715c5f6d9960f05649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097615Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/1bdc5980b3a4..cbf7f5178da6 git log 1bdc5980b3a4..cbf7f5178da6 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 rwkeane@google.com Platform: Add Operator < to IPAddress Created with: gclient setdep -r src/third_party/openscreen/src@cbf7f5178da6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I0238407c5b3f468baa0a3b7ee6bfe9b2a015a199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097522Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8bf3aecd3335..a8e510a1a6cb git log 8bf3aecd3335..a8e510a1a6cb --date=short --first-parent --format='%ad %ae %s' 2020-03-11 abennetts@google.com Fix minor errors in example command lines in bq_export README. 2020-03-10 phoglund@google.com Remove the proto test driver. 2020-03-10 phoglund@google.com Add a small proto->JSON tool. Created with: gclient setdep -r src/third_party/catapult@a8e510a1a6cb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1029452 Tbr: eseckler@google.com Change-Id: I0b07061056783c46f40ac2c9625908bae6663e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095108Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9e263aa8a4e6..c5b3cbdb4502 git log 9e263aa8a4e6..c5b3cbdb4502 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 cclao@google.com Vulkan: Use VK_FORMAT_D24_UNORM_S8_UINT for 24 bit depth if available 2020-03-10 tikuta@chromium.org use go swarming client in trigger.py Created with: gclient setdep -r src/third_party/angle@c5b3cbdb4502 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: I44aa9c7371615fde48d25eb5f35fdb90f5e460e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097471Reviewed-by:
-
David authored
chrome://media-app uses a postMessage API to communicate between its trusted and untrusted contexts to gain access to privileged functionality such as opening the feedback dialog. Use an object (Message) to indicate the action being communicated across the postMessage API instead of strings which are more error prone. Bug: 996088, b/138961540 Change-Id: I17185bdde143f8fb061ec2000075dd4a463cd7cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096057 Commit-Queue: David Lei <dlei@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#749025}
-
