- 12 Aug, 2020 40 commits
-
-
Naoki Fukino authored
The histograms are important to know how many users needs the feature and it affect how we support this feature in future ARC versions. Let me extend the expiracy for 1 year. Bug: 1109809 Test: none Change-Id: Id715954e2a8a5ce38dc592da21627bfa424bebdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344328 Auto-Submit: Naoki Fukino <fukino@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#797102}
-
Jiawei Li authored
Changes to use std:string as ScriptId type which has been changed to base::StringPiece on CastWebContents. Using base::StringPiece breaks the normal behavior of injecting JS bindings and the browsertest. Changing it back to std::string fixed the problem. Bug: internal b/163431947, b/132986916 Test: cast_shell_internal_browsertest, CQ Change-Id: I2a4cef5f208880816a4be3068e4e460dd9cf9fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350314Reviewed-by:
Sean Topping <seantopping@chromium.org> Auto-Submit: Jiawei Li <lijiawei@chromium.org> Commit-Queue: Jiawei Li <lijiawei@chromium.org> Cr-Commit-Position: refs/heads/master@{#797101}
-
Bettina authored
The plural message is the same as the non-plural message so there's no need for this. Bug: 1038797 Change-Id: I77b9a6a558fd4cfa4ceb70fb1ae98473d6c6a68d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350344 Auto-Submit: Bettina Dea <bdea@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797100}
-
Gavin Williams authored
Using a switch statement better represents the fact that the PrinterQueryResult enum only contains 3 possible options: SUCCESS, UNREACHABLE, or UNKNOWN_FAILURE. Bug: 1059607 Change-Id: I0887d532a9f2bc67f63ba218401480ae7e7b8762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349986 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#797099}
-
Chris Cunningham authored
Bug: 1105258 Change-Id: I48e2b4fc4737eef90f0cdc68b2c775c8d6c8efa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346824 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I76d833dd4cbb7b0c7109d1fb43f90849ea83b7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350016Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797097}
-
Regan Hsu authored
Previously, the user click count inside settings was not being recorded. Fixed: 1105551 Change-Id: I7c662a5727141f4b1730184be2e155c0dc8835dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349908Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#797096}
-
Ian Wells authored
Bug: 1044139 Change-Id: I9afeba55bbe9b42c47073ac1801ab2ddb5d7b6bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348546 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#797095}
-
Erik Chen authored
crashpad_handler needs to know where to put crashes. By default it uses the default UserDataDir and does not have support for --user-data-dir. If the default UserDataDir is not writable, then lacros fails to launch. This CL sets --breakpad-dump-location when launching lacros, effectively overriding the default. Change-Id: I9e31bc14ed721a3984f42f30f94d4214d672daa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350124 Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#797094}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I981cb1a2310d28d603e401ff403a427dafc9eb17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351462Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797093}
-
Piotr Bialecki authored
Change-Id: I90ddb990333b1616887834a094b11a3aad25e0bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350740 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#797092}
-
Devlin Cronin authored
Bug: None Change-Id: Ice4ea067d91f45c485e357728899b74c60ba8c9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343313 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#797091}
-
Dave Tapuska authored
This moves the setting of the page scale factor into blink part of the UpdateVisualProperties flow. BUG=1097816 Change-Id: Idac6921d93556c1ba4d942bce6abed000b398716 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320891 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#797090}
-
Thomas Guilbert authored
This CL adds the necessary logic to allow serializing blink::VideoFrames. It only copies a reference to the underlying media::VideoFrame. Bug: 1096715 Change-Id: Iade841ebd4b2525035b3e81a3f384a0735a57d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317822 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#797089}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ae8f8fdcda03..db1dd1b60d1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC slightlyoff@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917,chromium:1112941,chromium:1114729,chromium:1115022,chromium:1115073 Tbr: slightlyoff@google.com Change-Id: Ie70132a38ada362adba20c215d73f1bc7469f608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350019Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797088}
-
Yi Gu authored
Bug: None Change-Id: I8e79eb0c1a5d0394dc056a0d742b8704eb2ff988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350245Reviewed-by:
Sam Goto <goto@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797087}
-
Ian Kilpatrick authored
TBR: dgrogan@chromium.org Bug: 1114013 Change-Id: I41b8e08e80f1d8a6ecd9e293a12a5e8f83c2bec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348205 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#797086}
-
wutao authored
This patch adds the photo preview for album selection. Preview images are downloaded at the C++ side and converted to png url blob, and sent to JS side for display. The Google Photos and Art gallery have different CSS. ss: https://screenshot.googleplex.com/siwcThKwwp5 ss: https://screenshot.googleplex.com/9YTwncEZ8n0 Bug: b/161484670 Test: Added new js tests Change-Id: Ib8ba71c89ba90ac222b5c627ec1da3115a8b7ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336634 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#797085}
-
Jonathan Chavez authored
This CL removes the should_suppress_mixed_content_warning flag from SecurityState, which was originally added to support an enterprise policy that has since been removed. Bug: 1110090 Change-Id: I6b36f2c8edd18c9eb36f00d8dc5558a6cfde42f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343570Reviewed-by:
Carlos IL <carlosil@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Jonathan Chávez <tabaresj@google.com> Cr-Commit-Position: refs/heads/master@{#797084}
-
Sharon Yang authored
Support scrolling an offscreen node to be visible for screen reader use. Clean up unused param in DeleteSubtree. Test: AccessibilityBridgeTest.PerformScrollToMakeVisible Bug: fuchsia:55864 Change-Id: I3ab468e1cfb3084ee7517f6cf45e8cc0e3e8da1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142740 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#797083}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/97adc5795ed2..9981690ea644 2020-08-11 saagarsanghavi@google.com New approach for timing lower-level checks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I8486f3bbe0155b92e2f14b0db3d3aa50c89929fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350197Reviewed-by:
-
Alex Moshchuk authored
Although we now have a form of site isolation on Android, we're likely to be doing work to expand coverage to more devices and more sites, so it's still important to have an easily accessible opt-out switch to check for OOPIF issues. Change-Id: I9d9ee4fbcdbffffeda05b11b714d41918bf24d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350493Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#797081}
-
Brian Sheedy authored
This reverts commit 4edc0503. Reason for revert: Breaks minidump generation on Windows Original change's description: > Add dbghelp.dll to delay load list > > Currently, many of the binaries have a static dependency on dbghelp.dll. > This results in dbghelp getting loaded in all chrome processes. Upon > inspection, dbghelp.dll is only necessary for stack sampling and mini > dump handing in crashpad. Stack sampling is only enabled by default on > unofficial builds of dev and canary. All other times we are needlessly > loading this module which brings in 300k of image file refset and 60k > of Copy on Write costs per process. This change adds it to the delay > load list. > > Change-Id: I13da0ce0735431c5c51cdbc9ba2cfea0cc3cded7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336541 > Commit-Queue: Chris Davis <chrdavis@microsoft.com> > Reviewed-by: Cliff Smolinsky <cliffsmo@microsoft.com> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796707} TBR=thakis@chromium.org,brucedawson@chromium.org,cliffsmo@microsoft.com,chrdavis@microsoft.com Change-Id: I6051562e22eaa9e778b7077c3efab1129bdfd77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350744 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#797080}
-
Austin Eng authored
Bug: 1114781 Change-Id: I0e320c83772818bb487ded6af37c042c53804554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347426 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#797079}
-
Noel Gordon authored
Test files come from //media/test/data. Change apitest C++ to copy the files to the 'testing' Volume before starting tests. id3_png_test.mp3: audio file with embedded album artwork image 90rotation.mp4: h264 video, with 90 degree rotation, no images Add test JS helpers to read the files from the 'testing' volume / file system and convert them to Blobs before starting the tests. Add fileManagerPrivate.getContentMimeType mime sniffing tests: testGetContentMimeTypeEmpty - input is an empty blob, returns undefined mimeType result testGetContentMimeTypeImage - input is an image file blob, sniff image/gif testGetContentMimeTypeAudio - input is an audio file blob, sniff audio/mpeg testGetContentMimeTypeVideo - input is a video file blob, sniff video/mp4 testGetContentMimeTypeUnknownMimeTypeError - net::mime_sniffer fails, sets chrome.runtime.LastError Add fileManagerPrivate.getContentMetadata metadata extraction tests: testGetContentMetadataEmpty - input is an empty blob, returns undefined MediaMetadata testGetContentMetadataAudioTags - extract tags only into the MediaMetadata result - vet result with JS verifyExpectedAudioMetadata() helper testGetContentMetadataAudioTagsImages - extract tags and images into the MediaMetadata result - vet result with JS verifyExpectedAudioMetadata() helper testGetContentMetadataVideoTagsImages - extract tags and images into the MediaMetadata result - vet result with verifyExpectedVideoMetadata() helper testGetContentMetadataRetainsInputMimeType - input mime type is copied through to MediaMetadata.mimeType testGetContentMetadataVideoResetsAudioMime - audio mime is changed to video if there is width and height testGetContentMetadataUnsupportedMimetypeError - input mime not video or audio, sets chrome.runtime.LastError Bug: 1114622 Change-Id: Ic96ce7faa409ae25d6b3c956666bbfd7db362f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345936 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#797078}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/398a874c9b85..48d951e22d45 2020-08-11 jmadill@chromium.org Perf Tests: Handle logError callback. 2020-08-11 ianelliott@google.com Vulkan: tell ContextVk when swapchain is re-created 2020-08-11 jmadill@chromium.org Vulkan: Optimize resource tracking in CommandBufferHelper. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: angle_perftests, *vulkan_null_index_buffer_changed_ushortTest: Test: run_angle_perftests --gtest_filter=TracePerfTest.Run/vulkan_angry*:*vulkan_candy* --verbose --local-output Change-Id: I62339c4f81491850d3cea67ad134c5eb50b62b88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350489Reviewed-by:
-
Xiaocheng Hu authored
After launching crbug.com/1040632, we disallow a 'font-display:optional' font from being used if it doesn't load before the first rendering cycle begins, so that it won't cause any relayout. This turns out to be too stringent. This patches allows using the font as long as we have never rendered fallback for it. In this way, we still guarantee no layout shifting, and the font can be used in more circumstances. Bug: 1114314 Change-Id: Id521e97b8882e2e3d1fb13c09e040c8e2fd3d47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343643 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#797076}
-
Maciej Malinowski authored
The MemoryDumpMapConverter is converting between the Chromium type MemoryDumpMap and Perfetto RawProcessMemoryNode. Using this class it is possible to process produced in Chromium MemoryDumpMap by Perfetto GraphProcessor. See crbug.com/1095982 for more details. Bug: 1095982 Change-Id: If7e852017c8efa51cd99b4f648c4a32e8fe0b8fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299223 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#797075}
-
Nate Fischer authored
No change to logic. This exposes gpu_switches to Java with java_cpp_strings. Fixed: 1112006 Test: autoninja -C out/Default system_webview_apk Change-Id: I84fb22671a6ce42c288b2772f3d49722ccc79f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343776 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
rajendrant authored
Change-Id: I4d74b36ecce4a905aa3ef922cd71080651fa7a3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349987Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#797073}
-
James Hollyer authored
The capture region that held the mouse inside the chrome window was the full size of the window. This caused issues while when the invisible mouse hit the edge of the window it could fire certain events and cause strange things to happen. For example the linked bug discusses an "x" appearing when you are also in fullscreen. There are also some dual monitor setups that have consistently proven that the mouse moves just out of the window and onto the other monitor while in fullscreen. To solve this this CL is adding a 5 pixel border to the edge of the capture region to give some wiggle room for the small Windows errors and to stop events from firing when the mouse hits the edge of the window. Bug: 1107507 Change-Id: Ia2314f7726b5a18d96800a9efcd990bace564ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343005 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#797072}
-
Sophey Dong authored
Screenshots: http://dr/file/d/1IZSgjgsQ-scrCra7BLA1eM1JTpVo3YPO/view http://dr/file/d/10QwrglqYlD0dgtnhE33-43mq-cuAFFzj/view Bug: 1112882 Change-Id: I26afb6efef56d02ca19a0ea274ce2dd71d9c3331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343783Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#797071}
-
Ce Chen authored
suggest Incognito feature launch. Note we intended to share these params across non-Incognito & Incognito features, but now find out this is not supported by Finch. Bug: 925072 Change-Id: Ib43e8f4f6cc3124871beb7c68aa47b42bef1d480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346691Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Ce Chen <cch@chromium.org> Cr-Commit-Position: refs/heads/master@{#797070}
-
Jeremie Boulic authored
When a mounting operation failed for an archive, we displayed the errors in a dialog: - as part of the error message, the raw error code was included, without translation. - only one error dialog could be displayed at a time. We're now using visual signals instead. Bug: chromium:1058689 Change-Id: I789663d226c5376db0327b809d9e39af1289ca4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336096 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#797069}
-
Nate Fischer authored
No change to logic. This updates commandline-flags.md to explain switches are now autogenerated with java_cpp_strings. This is a follow-up to https://crrev.com/c/2343951. Bug: 956803 Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ic808e5301a57681246fd98910cf76c4f805b5f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350392 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
-
Toni Barzic authored
The app menu command may end up deleting the menu adapter, so it's not safe to use AppMenuModelAdapter after a context menu command execution is done. For example, if the menu is shown for app list search result, executing the command may open an app window, causing the app list to close and reset the search state. This may delete the search result that owns the adapter. In this case, attempt to record the execution histogram after ExecuteCommand will crash calling GetCommandIdForHistograms, which has been made virtual in CL:2258902. This changes AppMenuModelAdapter::ExecuteCommand to record the execute command histogram before executing the command. Also, removes RecordExecuteCommandHistogram from AppListMenuModelAdapter::ExecuteCommand - this calls into the base implementation in AppMenuModelAdapter, which records the same histogram. BUG=1115020 Change-Id: I4231f1b15404405891f392c0c2e4628ba9673efc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350235Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#797067}
-
Ali Juma authored
This CL initializes SafeBrowsingServiceImpl's SharedURLLoaderFactory in Initialize(), rather than two thread hops after Initialize(). This ensures that GetURLLoaderFactory() has a non-null return value when called shortly after Initialize(). This fixes crashes that occur when CreateUrlChecker() is called soon after Initialize(), resulting in the creation of a RealTimeUrlLookupService that has a null URLLoaderFactory and crashes when it tries to use it. Bug: 1114706 Change-Id: I9142c82979954a272f351c14db20246730f720db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346862 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#797066}
-
Raymond Toy authored
Move the core routine that handles the complicated case where the play back rate is not 1 or interpolation/extrapolation is needed. Then break out that routine into two new routines for computing the indices and for computing the output so that we can optimize each independently. A slight function difference occurred because we changed the interpolation formula from using (1-f)*x0+f*x1 to x0+f*(x1-x0). This is mathematically equivalent and but not in floating point. This shows up in the one test needing the threshold to be updated slightly. Bug: 1104371 Change-Id: Id299fb9471d01edad8d9c9da73084af9a53533f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342136Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#797065}
-
Marc Treib authored
Bug: 1113713 Change-Id: Ibcaf5cb39b4f7b961847219547e61adc87608083 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345310 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#797064}
-
Wenhan (Han) Zhang authored
Second step in migrating to a more flexible histogram naming syntax using tokens and variants and instead of suffixes. Changed another histogram to using token instead of suffixes where the suffixes group is obsolete. Made corresponding changes and tests in the model and extract_histograms.py. Change-Id: I3dfb389633e5d90b79e64a1dfb9d46a8fce88d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334586 Commit-Queue: Wenhan (Han) Zhang <zwenhan@google.com> Reviewed-by:
-
