- 18 Jun, 2020 40 commits
-
-
Jochen Eisinger authored
Don't assume that time doesn't proceed between two calls to updateNewUrlLoading. Bug: 1096237 Change-Id: Id6e4089b94f6c4dd3c89d321430faf54fc6c9272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250041Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#779787}
-
François Beaufort authored
This CL makes sure we're testing the value of pan_tilt_zoom_supported() when checking VideoCaptureDeviceDescriptors on macOS. Bug: 1095718 Change-Id: I5d3502b571735dd5f1f305f9face2217235944aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247728 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#779786}
-
Philipp Hancke authored
which need an extra parenthesis since this should be an object as shown in https://w3c.github.io/webrtc-pc/#rtcrtpencodingspatialsim-example* Noticed in https://github.com/fippo/simulcast-playground/pull/7 BUG=None Change-Id: I176a2919a3dbd3e6b065dca9dcef357a1e2adc01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247035Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#779785}
-
Michele Mancina authored
[Autofill Assistant] Create label for profile if null, this only happens for those profiles that are created within the CollectUserData action. Bug: b/158464101 Change-Id: Ia5df15a8d5244d981f42ad08588710d30b5e9067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246155 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#779784}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592452187-d8b5060216a94a83da3c0624280c3c37a480cfb4.profdata to chrome-win64-master-1592474334-e0477f022b6eb5a61c43375c0dcd8da0fde9e8a1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I35cb025a19b74cef6be6ae72b75760a7edac91db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251728Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779783}
-
Nektarios Paisios authored
This enhances readability when debugging. AX-Relnotes: n/a. TBR=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I4e0bcf1ccb7ded6b0204b9c06b9965bde76b05f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249934Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#779782}
-
Oriol Brufau authored
Some functions check whether a LayoutObject is anonymous, and then they exclude it if it's a list marker. However, since r745012, list markers can never be anonymous, they are always generated by a ::marker pseudo- element. Therefore, the condition is useless and can be removed. BUG=457718 Change-Id: I5e2636f68fab483838e8a5227ccace34b6de22cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250102Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#779781}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8d02a81b1877..1b2c5e463ebe 2020-06-18 mathias@chromium.org Enable stylelint on presubmit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083142 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie70ebeab1963f01641a31af0c6b2ef0a436d89d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251727Reviewed-by:
-
Sebastien Marchand authored
This will let us use the Finch dashboards to evaluate the performance gains of ThinLTO. Bug: 1057737 Change-Id: I9ddaeb869a8aed369a7b5ca7af5994344dddf525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249085Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#779779}
-
Marc-André (MAD) Decoste authored
Bug: 1088082 Change-Id: I3c8e3907d09ffd2f5f7c3f5652fafb1f0d47374b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248606 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#779778}
-
Victor Hugo Vianna Silva authored
This CL addresses a few design issues with PasswordListItem that predate the introduction of PasswordsListHandler. - PasswordListItem would refer to a "menu" even though it knows nothing about such menu, which is actually provided by the embedder. This CL replaces mentions to passwordMenu in the component with what it actually represents: the "more actions" button. - The event fired by clicking the button was not documented in the file overview. Moreover, the typedef for the event lived in the embedder. Now the file exports the typedef. - Tests that simulated clicks on the button would use the $$('#id') syntax instead of the $.id one. This is now fixed. Bug: None Change-Id: Ie815237134236468c639e73831bdb3eb7db36f98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248561 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#779777}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fa3d64bf72d6..57f137d71cdf 2020-06-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 763957e6b4fc to 7a1d99d0be42 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: I6cfffdc86d76f8b38bc9409763f88c1aeaac1e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251725Reviewed-by:
-
Rohit Rao authored
BUG=None Change-Id: I9d075a81676196ee885e0d7fa9be55b2c4e59bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248728Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#779775}
-
Ewann authored
This CL presents views related to page info using FormSheet. Bug: 1095644 Change-Id: I58f2f2d343a16912f9effb78ff4ad26a42b569a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249778Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#779774}
-
Ewann authored
This CL rephrases the cookies status "Block Third-Party in Incognito" in "Block in Incognito". Bug: 1063824 Change-Id: I550a63a1608c981bd2af30121f4ff5508f653c43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251619Reviewed-by:
-
Colin Blundell authored
This CL sets up the infrastructure for private instrumentation tests of WebLayer's infobars and adds an initial test: that addition of an infobar impacts the visual state of the infobar container as expected. BUG=1093846 Change-Id: Id5cdc73f02a4eadb46b3733451541fbd1f796441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247836 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#779772}
-
Friedrich Horschig authored
With larger (or smaller font) the absolute pixel sizes for the spinner change the relative center of the animation which leads to an uneven rotation. To prevent this, the spinner now has a size relative to the font size which is identical for the current size on normal scaling but scales with larger/smaller sizes to keep the animation intact. Since a large/small spinner looks wrong for a static status icon, the icons also scale with the font size to match the spinner (which is not a problem for the vector graphics). Bug: 1096397 Change-Id: Ice9300cafdd2ef4877f28dd08c0a5b432588ddfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250203Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#779771}
-
Saurabh Nijhara authored
As per product requirements of minimum chrome version policy, it is required to show notifications (for update required in case of network limitations and to return the device in case of end-of-life) on login if it is the last day to reach the deadline. Like other notifications of this policy, this notification on sign in is also only applicable to managed users to maintain consistency. This behaviour helps to curb the problem of notification being missed if policy is received when un-managed user is signed in and later a managed user signs in. Only the last day notification is shown on managed user sign in to avoid too much spamming. Bug: 1048607 Change-Id: I01a8d52bbc4a003d5e1323140885881887211176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248567Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Saurabh Nijhara <snijhara@google.com> Cr-Commit-Position: refs/heads/master@{#779770}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c6d6e06a5c45..2c9d76a4eb0f 2020-06-18 eshr@google.com Use DataRates in QualityRampUpExperimentHelper If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I508024aa1d86877043bc2e6aa2714a0b582faab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251726Reviewed-by:
-
Austin Tankiang authored
PreferenceWatcher is private to DriveIntegrationService, so there's no point having it be passed in. Bug: 1096355 Change-Id: I753c1c452d6873768f89d25f6737732624cc8b98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251268Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#779768}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592459911-c43358934a37f46ea56775cef711f664e7b25ffd.profdata to chrome-win32-master-1592467151-bf53acbeb3a2f5db843a60a3b97cc31d9344243a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I70e7206f3b2e61f72f3e27b116d48bc91b30dd26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251723Reviewed-by:
-
Hans Wennborg authored
Add direct includes for things provided transitively by logging.h (or by other headers including logging.h). This is in preparation for cleaning up unnecessary includes of logging.h in header files (so if something depends on logging.h, it needs include it explicitly), and for when logging.h no longer includes check.h, check_op.h, and notreached.h. Bug: 1031540 Change-Id: I2b34d25846b971723bacb00e495ed219faa02e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249761 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#779766}
-
Anatoliy Potapchuk authored
Bug: 1015383 Change-Id: I271647c5c47b568805ee1623c24823f92574737d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246562 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
-
Ewann authored
This CL adds a footer to cookies settings, explaining to the user how to apply the new cookies setting. Bug: 1063824 Change-Id: Ib683b385115f30f6b46eceb7a30741ca0a0a99d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248563 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
After recent fixes to the underlying blocking bug crbug.com/968222, it's worth giving those test another shot. Bug: 1044038,1054629 Change-Id: Idd2317c028c1cc7bb2ebee0e312c19456be57482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249981Reviewed-by:
-
Benoit Lize authored
PartitionAllocator can be used as the malloc() implementation. In this context, a (D)CHECK() which fires causes allocations, which creates reentrency issues when used inside PartitionAlloc. To avoid that, use PA_(D)CHECK() in base/allocator/partition_allocator/, which is identical to the unprefixed version if PartitionAlloc is not the malloc() implementation. Otherwise it uses simplified versions. This doesn't necessarily cover all the code reached from PartitionAlloc. This is not a correctness issue, as Chrome would still crash when a (D)CHECK() fires, but a debugability one. As a consequence, limiting the changes to the directory (rather than all code called from it) is sufficient. Bug: 998048 Change-Id: I171be3e6bac35cf09a29400c4254adc6f995739b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249739 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#779762}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4ccff505fbf79918af792ac5e9e1f699cfe7f9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251724Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a7112d544b2e..99651228b238 2020-06-17 vasniktel@gmail.com Add RemoveParameter method (#3437) 2020-06-17 vasniktel@gmail.com Fix return type (#3435) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: Ibb9c19488b31b545fec8cc3a1a87441a48fbaef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251469Reviewed-by:
-
Maksim Ivanov authored
Replace the custom handwritten compareBuffers() tool with the commonly used and more bulletproof chrome.test.assertEq(). Bug: 1078761 Change-Id: Ic30bb450f6922a2fa69297cc60010f4661a4c0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246683Reviewed-by:
Omar Morsi <omorsi@google.com> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#779759}
-
Victor Hugo Vianna Silva authored
Blacklists that are unsynced at the time a b4p user signs out should not be offered for fallback saving in the profile store. Bug: 1060132 Change-Id: Iac615a525e92f7c60055bfbd00957bb819b6c7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250108Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#779758}
-
Victor Hugo Vianna Silva authored
This CL starts displaying the dialog from crrev.com/c/2248180. Moreover, RemovePasswordBehavior is deprecated. The more elaborate logic of removing different copies of a password can live directly in the dialog, while PasswordsListHandler can use simple logic for the case when a single copy must be removed. In particular, it felt strange that PasswordListItem has this Polymer behavior but never used any of its functionalities (it was PasswordsListHandler that used it instead). We also use the occasion to fix an aspect of crrev.com/c/2235850. If the entry is moved, there's no element to reset the focus to, so the focusWithoutInk() call is removed. The same is done for removal dialog. Bug: 1049141 Change-Id: I06fe35b8bd14ee27873b6a56849e755c02cbc1bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246157 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
Koji Ishii authored
|NGLineTruncator| was originally designed to compute and trunate |NGPhysicalTextFragment|. This patch changes it to work on |NGLogicalLineItem| instead. This is yet another effort to reduce the usage of |NGPhysicalTextFragment|, following r778837 and r779021. This saves creating intermediate |NGPhysicalTextFragment| when FragmentItem is enabled, and reduces dependency on |NGPhysicalTextFragment| for the removal when the switch to FragmentItem was completed. Bug: 982194 Change-Id: I3742fa1ea33648e2151f7d3cbf83e977928c6715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230583 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779756}
-
Kent Tamura authored
web_tests depends on third_party/test_fonts since this CL. This CL has no behavior changes in production. Bug: 1082087 Change-Id: Ibe1dde711426c7b0f0ed2dad4b2435e820648dd1 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249272Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Kent Tamura authored
The LayoutNG behavior looks correct with the current ruby architecture. The light-blue box is a child of <rt>, and it should not overlap with the ruby base text. Bug: 1069817 Change-Id: Id6eef5444a5c77a4e55c3451c52cb12d2b0d842d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249214Reviewed-by:
-
Anatoliy Potapchuk authored
This will make us able to create a generic controller to control all kiosks. There is still an issue with arc kiosk though, which will require additional refactoring. Bug: 1015383 Change-Id: I5766a58ca68f623c639115a298d9a0e0338cbe87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245140Reviewed-by:
-
Alex Ilin authored
The information about which call site triggered reauth is needed for tailoring UI strings for specific call sites as well as for metrics recording. This CL only does plumbing from all call sites which already touches many files. Actual usage will be added in following CLs. Bug: 1045515 Change-Id: I85de7fefda83f5bcf2896c5aae153311d812a937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249800 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#779752}
-
Anders Hartvoll Ruud authored
This CL adds: - Parser support for the @scroll-timeline rule itself. - Parser support for the associated descriptors. - A partial CSSOM API for the @scroll-timeline rule. It's currently not possible to add parser support for @scroll-timeline without also adding the CSSOM wrapper, hence this is done in the same CL. Parsing a @scroll-timeline rule emits a StyleRuleScrollTimeline object, whereas the CSSOM API is implemented via CSSScrollTimelineRule, which wraps the StyleRuleScrollTimeline object. Since this CL is big enough already, the following has been postponed to later CLs: - StyleEngine integration. (Adding StyleRuleScrollTimeline to RuleSet, cascading @scroll-timeline rules, etc). - CSSScrollTimelineRule::cssText() (full-rule serialization). Bug: 1074052 Change-Id: Id5a51b3c7c269b852cb2e6de5414db44c710a87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240852 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#779751}
-
Tom Anderson authored
BUG=1066670 R=sky Change-Id: Icb955af0161e3e4b2dbdcd0c283a2aa631c4f799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249389 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
-
Nidhi Jaju authored
Upon investigation of a recent bug reporting the Chrome browser hanging during startup, it was found that ServiceWorkerStorage::GetAll Registrations() is called which may take a considerable amount of time. Hence, by removing this call and just getting Registered Origins instead of all registrations, this issue should be resolved. The call to the ServiceWorkerContextWatcher class was also removed from ServiceWorkerContextWrapper, along with GetAllRegistrations() being replaced with GetRegisteredOrigins(). Bug: 807440 Change-Id: I99ef9895ca28dd5ba8977fe422a3d92099527765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239590 Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#779749}
-
Mikel Astiz authored
This logically reverts the old https://codereview.chromium.org/551843003 because meanwhile the Sync Directory has been deprecated in favor of a new codepath, Unified Sync and Storage (USS). Change-Id: I80e66c304b76a8d9edffe1a4657ba0c2513f2ff4 Bug: 923287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250042Reviewed-by:
-
