- 22 Nov, 2018 40 commits
-
-
Sam McNally authored
This is a reland of fa8a5d39 Original change's description: > Fix selection jumping around when removing multiple items in cr-list. > > Previously, when the selected item is removed, the selection is changed > to the index after where the old lead index was. When multiple items are > removed, the logical next item may move multiple positions. Avoid this > by moving to the item that hasn't been removed from prior to the > permutation - using its position after the permutation. > > Bug: 708299 > Change-Id: I9393c9f00d5453ef3c3d5378758bb63ed29c43b7 > Reviewed-on: https://chromium-review.googlesource.com/c/1345709 > Reviewed-by: calamity <calamity@chromium.org> > Commit-Queue: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610019} Bug: 708299 Tbr: calamity@chromium.org Change-Id: I4de9726b919f88a1efe98f036687de07b23715c2 Reviewed-on: https://chromium-review.googlesource.com/c/1347630Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610358}
-
Andreas Haas authored
This flag does not need to be in about:flags anymore. We do not expect an end user to disable WebAssembly anymore. R=titzer@chromium.org, ellyjones@chromium.org Bug: chromium:907408 Change-Id: I2653d806194caf88c5e4501f84ae76421f4c2449 Reviewed-on: https://chromium-review.googlesource.com/c/1345972Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#610357}
-
Matt Falkenhagen authored
This adds a test that does the following: - Writes to a canvas with a cors same-origin image - Writes to a canvas with a cors cross-origin image from the same URL - Tests that the canvas is tainted after the second step. Bug: 907047 Change-Id: Ie231b442eb9b55c642b3957c065555e6f4997a83 Reviewed-on: https://chromium-review.googlesource.com/c/1347952 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#610356}
-
Yutaka Hirano authored
Bug: 907073 Change-Id: I86883cc5326ba3a31a588fc1e1e3d7779cbf1df9 Reviewed-on: https://chromium-review.googlesource.com/c/1347960Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#610355}
-
Alex Clarke authored
Bug: 863341, 891670 Change-Id: If583048e9efcc14ab1456153480d1ab2847eb869 Reviewed-on: https://chromium-review.googlesource.com/c/1347271 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#610354}
-
Andreas Haas authored
NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I691fff46ceb59f935f12b352a1f34b081728e302 Reviewed-on: https://chromium-review.googlesource.com/c/1345971Reviewed-by:
-
Ken Rockot authored
Migrates three services (media, cdm, and shape_detection) away from some deprecated service APIs and onto new ones. Namely ServiceBinding and ServiceKeepalive are used in lieu of ServiceContext and ServiceContextRef, and regular unit tests are used instead of the deprecated ServiceTest framework. Bug: 891780,906239 Change-Id: I3302f35747702ae8cf39f6f1e33b416e3ec180b2 Reviewed-on: https://chromium-review.googlesource.com/c/1344882 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#610352}
-
Sam McNally authored
When the directory contents is replaced, the selection is informed, and thus it clears check select mode. Once the new contents is swapped in, the check select state is lost. If check select mode was enabled and there was a selection, re-enable check select mode once the directory contents replacement is complete. Bug: 773989 Change-Id: I5859ece283dd10aca03310389174726fd18110e2 Reviewed-on: https://chromium-review.googlesource.com/c/1347964Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610351}
-
Hayato Ito authored
This reverts commit 6cd7b732. Reason for revert: See https://crbug.com/907758 Findit found culprit 610287 with 75% confidence. Original change's description: > Add default sanitizer options for Windows. > > strip_path_prefix is needed for Predator to work on ClusterFuzz. > > R=ochang@chromium.org > CC=metzman@chromium.org > > Change-Id: Ib800a54c5f95176ef4acd292f935d6405529cf8f > Reviewed-on: https://chromium-review.googlesource.com/c/1345570 > Reviewed-by: Alexander Potapenko <glider@chromium.org> > Reviewed-by: Evgeniy Stepanov <eugenis@chromium.org> > Reviewed-by: Oliver Chang <ochang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610287} TBR=eugenis@chromium.org,glider@chromium.org,inferno@chromium.org,ochang@chromium.org Change-Id: I4a72cbced73bd0ef1d5c9fe723f28e45fab2fd24 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1347965Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#610350}
-
Eric Seckler authored
The share trace notification now has an action. Given that the test doesn't test the action (and any future ones), this removes the expectation that there aren't any. TBR=twellington@chromium.org Bug: 907659 Change-Id: Ieb5b9f450e605e47cd068f4d99c1c98708961260 Reviewed-on: https://chromium-review.googlesource.com/c/1347250 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#610349}
-
Alice Boxhall authored
Bug: 907359 Change-Id: I1e44e7b452e5713b854da68669a72e9e3aa79326 Reviewed-on: https://chromium-review.googlesource.com/c/1345757Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#610348}
-
Charles Zhao authored
In order to do query time logging, WindowFeatures and MRUFeatures have to be merged into current TabFeatures. Which also leads to modify three other places: (1) how TabFeatures is calculated in TabActivityWatcher. (2) how TabFeatures is used in CalculateReactivationScore. (3) how TabFeatures is logged to ukm. To be more specific of the change: (1) Extending TabFeatures: chrome/browser/resource_coordinator/tab_ranker/tab_features.h chrome/browser/resource_coordinator/tab_ranker/tab_features.cc chrome/browser/resource_coordinator/tab_ranker/tab_features_unittest.cc 6 extra fields is added to TabFeatures (4 from WindowFeatures, 2 from MRUFeatures). 2 helper functions are added PopulateTabFeaturesToRankerExample (for inference) PopulateTabFeaturesToUkmEntry (for logging) 2) tab_score_predictor tab_score_predictor can simply take TabFeatures as input. chrome/browser/resource_coordinator/tab_ranker/tab_score_predictor.h chrome/browser/resource_coordinator/tab_ranker/tab_score_predictor.cc chrome/browser/resource_coordinator/tab_ranker/tab_score_predictor_unittest.cc (3) For slight different logging. chrome/browser/resource_coordinator/tab_metrics_logger.h chrome/browser/resource_coordinator/tab_metrics_logger.cc chrome/browser/resource_coordinator/tab_metrics_logger_unittest.cc LogBackgroundTab is changed to LogTabMetrics which basically logs a full TabFeatures. LogBackgroundTabShown and LogBackgroundTabClosed are also unified as LogForegroundedOrClosedMetrics to avoid getting more and more parameters. (4) For Triggering of logging. chrome/browser/resource_coordinator/tab_activity_watcher.h chrome/browser/resource_coordinator/tab_activity_watcher.cc chrome/browser/resource_coordinator/tab_activity_watcher_browsertest.cc The triggering logic is not changed. Only two helper functions are added: GetTabFeatures (returns TabFeatures of current tab) LogForegroundedOrClosedMetrics (gets ForegroundedOrClosed metrics of current tab and logs to ukm.) 5) tools/metrics/ukm/ukm.xml 8 extra metrics are added to "TabManager.TabMetrics", among which: "MRUIndex", "TotalTabCount", "TimeFromBackgrounded" are moved from ForegroundedOrClosed event. "WindowIsActive", "WindowShowState", "WindowTabCount", "WindowType" are moved from WindowMetrics event. "NumReactivationBefore" is the only newly added event which is currently estimated offline based on TabMetrics; now we can have more precise value by directly logging it. Bug: 900454 Change-Id: I705c1c144be4c3df0d5b67a7fe5f2d1afa10f2c9 Reviewed-on: https://chromium-review.googlesource.com/c/1337139Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#610347}
-
Mikel Astiz authored
Recent patches have fixed the observed DCHECK issue, so the flakiness is believed to be gone. Bug: 873494 Change-Id: I9821f879b0be1c0ffb11004be2ae69182b6fd342 Reviewed-on: https://chromium-review.googlesource.com/c/1347357Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#610346}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1b079a6aacab..0d55bcab63be git log 1b079a6aacab..0d55bcab63be --date=short --no-merges --format='%ad %ae %s' 2018-11-22 dburger@chromium.org Add chromeos-infra-unittests-pre-cq to list of pre-cq builders 2018-11-22 lamontjones@chromium.org Add README.md to chromite/signing. 2018-11-22 lamontjones@chromium.org signing: add support for key.versions 2018-11-22 lamontjones@chromium.org signing: refactor Keyset and Keypair for buildtarget-specific keys Created with: gclient setdep -r src/third_party/chromite@0d55bcab63be The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ief16bc25e0209125b25d14db6660b6a5ff34a47e Reviewed-on: https://chromium-review.googlesource.com/c/1347724Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610345}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/99673869a3cd..f701a90597fc git log 99673869a3cd..f701a90597fc --date=short --no-merges --format='%ad %ae %s' 2018-11-22 efoo@chromium.org Update commit queue for Nacl try builders 2018-11-21 efoo@chromium.org Whitespage change to force a CL Created with: gclient setdep -r src/native_client@f701a90597fc The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:868204 TBR=mseaborn@chromium.org Change-Id: Ifec7587e58047b83db25036d4bfad517bf739bbb Reviewed-on: https://chromium-review.googlesource.com/c/1347910Reviewed-by:
-
Noel Gordon authored
QuickView involves <webview> and they're secure, chrome extension-only elements. QuickView is now covered by integration tests which use real <webview> elements and run with full chrome security. The UI test framework does not support <webview> and runs without full chrome security (--disable-web-security) as discussed in [1]. [1] https://bit.ly/2AUVGvK Bug: 891150 Change-Id: I0bc55495d781b353d8284adfad7ef5877cda9ffa Reviewed-on: https://chromium-review.googlesource.com/c/1328625Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#610343}
-
Hayato Ito authored
Chromium Sheriff TBR=luoe@chromium.org Bug: 907736 Change-Id: I00571640c46263961369a397ca1fc59066bccd2e Reviewed-on: https://chromium-review.googlesource.com/c/1347959Reviewed-by:
-
Eliot Courtney authored
Now that we have a WM transition event for PIP, we can use it directly to set PIP window states in tests. Bug: None Test: ash_unittests Change-Id: I1c8033bf8b8df1b2a4b599d52f574097807457b2 Reviewed-on: https://chromium-review.googlesource.com/c/1345956Reviewed-by:
Mitsuru Oshima (OOO till 11/26) <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#610341}
-
Ken Rockot authored
Migrates pdf_compositor from ServiceContext to ServiceBinding and makes its tests regular unit tests instead of using the deprecated ServiceTest framework. TBR=thestig@chromium.org Bug: 891780,906239 Change-Id: Ia2485320e71352b3263108544fbea06c6b8ca6ef Reviewed-on: https://chromium-review.googlesource.com/c/1343506Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#610340}
-
Esmael El-Moslimany authored
The audio player's progress slider uses sliders in a different way from other sliders in settings. The value of the slider is updated frequently when playing. While the knob is being dragged, audio playback is paused and is resumed when the drag completes. Previously the audio player was using the immediate-value-changed and value-changed events to determine if the knob was being dragged. A couple changes were required to support the audio player progress slider. When the |dragging| property is changed, the |dragging-changed| event is dispatched. And the slider |value| is updated after dragging has started and before dragging has completed. This allows the audio player to pause playback, ignore any subsequent updates to the progress and accept changes to progress during dragging. When dragging is done, the audio player has access to the most up-to-date value of the slider so it can update the time of playback then resume playing. Inverting the direction of ArrowRight/ArrowLeft keybindings when the direction is RTL. Bug: 902873 Change-Id: I898889fc882ef0b1459ceabf8d27ed5ad62267c0 Reviewed-on: https://chromium-review.googlesource.com/c/1325012Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#610339}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e4cccae29941..8b5d9d865088 git log e4cccae29941..8b5d9d865088 --date=short --no-merges --format='%ad %ae %s' 2018-11-22 ouj@fb.com Remove the audio/video split for the RTCP report intervals. 2018-11-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5825fead..6931f4c0 (610108:610209) 2018-11-21 srte@webrtc.org Adds OnReceivedUplinkAllocation method to AudioEncoder. 2018-11-21 srte@webrtc.org Moves BitrateAllocationUpdate to api. 2018-11-21 srte@webrtc.org Using unit classes in BitrateAllocationUpdate struct. Created with: gclient setdep -r src/third_party/webrtc@8b5d9d865088 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I10a8aad5cf010665abc2bc36771ad1ec0b2288f5 Reviewed-on: https://chromium-review.googlesource.com/c/1347909Reviewed-by:
-
Sam McNally authored
BUG=b:119283909 Change-Id: I21d1cce7c43d904d6c32d0191263c133becc227b Reviewed-on: https://chromium-review.googlesource.com/c/1343459Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#610337}
-
Anand K. Mistry authored
BUG=808300 Change-Id: Ib37a53399efd57a9306e4b47630391c265825b90 Reviewed-on: https://chromium-review.googlesource.com/c/1345692 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
Note: We should expose it out of WebAppDataRetriver if we want to reuse WebAppDataRetriver for legacy extensions-based installations (a replacement for BookmarkAppHelper). Bug: 901226 Change-Id: I4192600cfdbe0f57da7d3ea56b14f8626072a3a5 Reviewed-on: https://chromium-review.googlesource.com/c/1345678 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#610335}
-
Koji Ishii authored
Following bot results are included. 12012 12014 12017 12018 12021 12026 12030 12036 12037 12038 1 lines were removed and 8 lines were deflaked by consecutive results since 12003. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I94de2f150aea46c588f8c85750955e05784ae28b Reviewed-on: https://chromium-review.googlesource.com/c/1345696 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#610334}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2ed782097044..4bff78e57c54 git log 2ed782097044..4bff78e57c54 --date=short --no-merges --format='%ad %ae %s' 2018-11-22 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 6aab06e0e5d4..dc65c5bd8452 (2 commits) 2018-11-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader dcb803a7af64..18a84258b13d (3 commits) 2018-11-21 fmalita@chromium.org [sksg] Expose SkFont::Edging in TextNode 2018-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e2ecf37519d2..dcb803a7af64 (1 commits) 2018-11-21 fmalita@chromium.org Allow null typefaces in SkFont::textToGlyphs() 2018-11-21 brianosman@google.com Fix sampling location for dashed circle in p3_ovals 2018-11-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader b16f9897a868..e2ecf37519d2 (2 commits) Created with: gclient setdep -r src/third_party/skia@4bff78e57c54 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I0ef74681f3b7f112de20533f1c3b427f3264f443 Reviewed-on: https://chromium-review.googlesource.com/c/1347082Reviewed-by:
-
Shao-Chuan Lee authored
Bug: 904282 Change-Id: I5dfaed91060891069f317cf9eb3140f58c4d5c2f Reviewed-on: https://chromium-review.googlesource.com/c/1331095 Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Maajid <maajid@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#610332}
-
Hans Wennborg authored
The classes may not actually be copyable, copy-assignable, etc. Previously the compiler would not complain until trying to *use* the defaulted ctor/operator, but the new -Wdefaulted-function-deleted warning warns about this up front. (As a concrete example, ExtensionMsg_TabConnectionInfo isn't copy-assignable because of base::DictionaryValue member, which is a base::Value, which can't be copied.) To ensure these structs are still movable, remove the user-declared destructor. This is also a simplification in that it removes all the code that was necessary to define that destructor out-of-line. Bug: 890307 Change-Id: I27ec3a0639bdeb94776acdd78b173791d0b8162d Reviewed-on: https://chromium-review.googlesource.com/c/1261082Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#610331}
-
rbpotter authored
Error messages currently appear cut off for large fonts and languages that cause the messages to wrap onto more than 2 lines. Size error messages to the full height of the text content and update styling so that the labels stay aligned with the input when error messages appear. Bug: 898802, 887992 Change-Id: I07036adc127cd9fa95ddede51c44790c867e31ba Reviewed-on: https://chromium-review.googlesource.com/c/1345544Reviewed-by:
-
Zhenyao Mo authored
Currently we initialize it too soon, so on multi-GPU system, the workaround |disable_direct_composition| may not be correctly applied. BUG=907684 TEST=manual R=piman@chromium.org,sunnyps@chromium.org Change-Id: Id30e09f2229b4229b82ee9330523426b470b7c5d Reviewed-on: https://chromium-review.googlesource.com/c/1346998 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Alex Danilo authored
Selecting a file, then tabbing to the selection menu button should hide the tooltip if the menu is activated from the keyboard. This change explicitly hides the tooltip on menu activation. behaviour is correct on desktop and real device. Bug: 752035 Test: Ran all FilesApp browser tests. Manually verified Change-Id: I8c13364748773da2521129e95d7edb29c4032edd Reviewed-on: https://chromium-review.googlesource.com/c/1347958Reviewed-by: -
Dale Curtis authored
We should be able to avoid this with careful use of a trampoline through the media thread after PipelineImpl::Stop() completes. BUG=905506 TEST=passes cq. Change-Id: I6a9c1a0e578c48a66af85588879346d26009d2ab Reviewed-on: https://chromium-review.googlesource.com/c/1336659Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#610327}
-
Joel Hockey authored
* Added quickview integration test pressEnterOnInfoBoxToOpenClose. * Updated test.util.sync.deepQueryAllElements to accept targetQuery as either string or !Array<string>. * Changed RemoteCall waitForElement* functions to call deepQueryAllElements to allow for usage with nested elements. * Updated javadoc on RemoteCall functions to show which already support query as string|!Array<string>. Bug: 893093 Change-Id: I7c542e7a2bc914e16fa8142fb696f5b3fe370752 Reviewed-on: https://chromium-review.googlesource.com/c/1345693Reviewed-by:
-
Jinsuk Kim authored
Initial implementation of ephemeral tab based on overlay panel. See go/ephemeral for the design. Final design may be subject to change. and there are many TODO's still left. non-trivial amount of time trying to reduce its number of methods. Bug: 894619 Change-Id: I2833c6aaf820d9cf40be4d465ef135f5d5f8a9f6 Binary-Size: Increase needed to implement a feature, and I've already spent a Reviewed-on: https://chromium-review.googlesource.com/c/1282043 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:Ted Choc <tedchoc@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#610325}
-
Joel Hockey authored
Remove the 'toolbar-menu' class when menu closing animation is complete to avoid flicker. Bug: 862926 Change-Id: I8b52b86297a5f629d00b8cf43bce3c537a6ef323 Reviewed-on: https://chromium-review.googlesource.com/c/1347957Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#610324}
-
Matt Giuca authored
Instead of two separate code paths for when the Desktop PWAs flag is enabled/disabled, it's now a single code path that makes a few behavioural changes depending on the status of that flag. Bug: 907298 Change-Id: I6b449fd65390d631098b2bc58e6c1ea668d5fd41 Reviewed-on: https://chromium-review.googlesource.com/c/1345753Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#610323}
-
Rakina Zata Amni authored
We previously used ComputedStyle::Create when creating ComputedStyle for invisible elements, but the ComputedStyle made with that lacks some setup needed for it to actually be usable correctly. Example case is the style's font fallback list is not set, leading to some crashes. Bug: 904791 Change-Id: I512082af6dcf7a5076eb033a2f9a78b83020e47e Reviewed-on: https://chromium-review.googlesource.com/c/1345952 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#610322}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d66dad7fc2c3..25c4fce2cebb git log d66dad7fc2c3..25c4fce2cebb --date=short --no-merges --format='%ad %ae %s' 2018-11-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@25c4fce2cebb The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I9b719f59b87f305ed9cc5cdf422e9f0b3e811e72 Reviewed-on: https://chromium-review.googlesource.com/c/1347911Reviewed-by:
-
Mike Frysinger authored
This makes `grit build --help` work too. Bug: 747171 Change-Id: I5297019a34446196e625635318f2373620ffd87f Reviewed-on: https://chromium-review.googlesource.com/c/1339341 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
-
Xi Cheng authored
Change-Id: Ia542a4fdc9ee86b06b23a20a8d01ea0ae562224f Reviewed-on: https://chromium-review.googlesource.com/c/1347041Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#610319}
-
