- 28 Oct, 2020 40 commits
-
-
Viktor Semeniuk authored
This change adds "Signed in with" row for federation credential on the Password Details screen. Bug: 1137807 Change-Id: Ie9e6d8b78eef253098111904306fbffe4262f897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467937 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#821660}
-
Kushagra Sinha authored
Move `AccountManagerFacade` from //chromeos/components/account_manager to //components/account_manager_core so that it can be depended on by ash-chrome and lacros-chrome both. Bug: 1117466 Change-Id: I475c0b18d8ce50698c085d841a014f33016e5a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494938Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#821659}
-
Dominic Farolino authored
This CL removes the temporary fetch() UseCounters introduced in crrev.com/c/2242205 to help with metrics collection for ServiceWorker folks. R=kinuko@chromium.org, yhirano@chromium.org Bug: 1072350 Change-Id: Id3327fe1ed9792a9ed8fd3e7333c08293cca1f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503188 Auto-Submit: Dominic Farolino <dom@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#821658}
-
Alexander Dunaev authored
The UserInputMonitorLinux depends on X11 directly and cannot be used by Ozone platforms because of that. This CL introduces a new platform interface for the user input monitor, and moves the X11 implementation to //ui/base/x. The UserInputMonitorLinux now uses either the X11 implementation directly (when X11 is enabled but Ozone is not) or requests the platform implementation when Ozone is enabled. Bug: 1116414 Change-Id: I0a21074f2fe028fea13c7efb33ddf9d102c9f35c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489863 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#821657}
-
Maggie Cai authored
Currently if we open the link in a new tab (e.g. ctrl + click, context menu, from another app), the intent picker icon will not show up even there are apps that can handle that URL. This is because: 1. We check the browser for the web contents in navigation throttle before the adding the web contents to tab strip model for new tab case. 2. When open new tab from new-tab page, the starting URL is empty. This CL fixes this issue by moving these checks to only check for automatically pop up the bubble or automatically launch the app, but still show the icon if there are app found. BUG=1141049, b/171260488 Change-Id: Idcf4b07c34304bf6664f874142128ceddb6d6569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500974Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#821656}
-
Titouan Rigoudy authored
These tests prove that no additional handling is required to block insecure private network requests targeting `file:` URLs. Indeed these requests are already blocked for a different reason: pages loaded over http and https are forbidden from accessing `file:` URLs. Bug: chromium:1142505 Change-Id: I606672978c286d450cdee796aa821c07c7911c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498526Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Hemery <ahemery@chromium.org> Commit-Queue: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#821655}
-
Anders Hartvoll Ruud authored
Bug: 1074052 Change-Id: I180f5c8822803ea14ec4b37850165322ab3082d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502340Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#821654}
-
Stefan Holmer authored
Bug: 1123584 Change-Id: Id90a5a6b76eb8fcfe62684015366abe9a64f9dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485110 Commit-Queue: Stefan Holmer <holmer@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#821653}
-
Tomasz Moniuszko authored
This follows up removing the sources assignment filter. Bug: 1018739 Change-Id: I70b19a5d47145c1b231946c503fe28d9e4695fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502181 Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#821652}
-
dpapad authored
These grit() targets traditionally were placed in c/b/r/BUILD.gn, but it is more appropriate to move them to within the corresponding WebUI subfolder. In this CL only moving grit() targets for folders where generate_grd() is used. Bug: 1132403 Change-Id: I52c86feca0f20cc819240068a38e1c3d39b6acab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503189 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#821651}
-
Rune Lillesveen authored
Preparing for ::target-text pseudo style painting. Bug: 1136817 Change-Id: I72127c4b1042535e1c4b6cc2435a49ba3d9c9c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484801Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#821650}
-
Kent Tamura authored
The test doesn't need to handle strings consisted of control characters. This CL makes the test 4x faster in debug build. This CL has no behavior changes. Bug: 1143185 Change-Id: I82c252ae3b182514cb11543a3c305a589a6366d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503763 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821649}
-
Yoichi Osato authored
This CL adds fetch uploading 150Mbytes arraybuffer test. Since similar layouttest was so slow, I decided to test it in browser test. Bug: 919361 Change-Id: I693e67666e71b999276f25cfe0c0ff56436c4369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490964 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#821648}
-
Takashi Sakamoto authored
Bug: 1086388 Change-Id: Ie0ddb53e5910fb4ee32592531fbb4ea5f4a794c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500972Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#821647}
-
Finnur Thorarinsson authored
This CL moves AppBanner* code from: chrome/android/banners ... to ... chrome/browser/banners/android ... and modularizes it in the process. Bug: 1135551 Change-Id: I8773b293e55f03ca66da15551e27a06e26e2ae96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489917 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#821646}
-
Kushagra Sinha authored
This is in preparation for Lacros. Data structures like `Account` and `AccountKey` need to be accessible from Lacros. But Lacros should not have any knowledge of `AccountManager`. Extract these data structures from `AccountManager` into their own build target - account_manager_core. Bug: 1117466 Test: chromeos_components_unittests --gtest_filter="*AccountManager*Test*" Change-Id: I38cff45ceb1ca3cc058b6b26d1dafbd4f048b0d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483830Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#821645}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603842982-a956b2994ae58c7a5e5be7f92daab364455a7a77.profdata to chrome-linux-master-1603864709-80e0b66faf89b1f5bb0f1645a135a447551ec59a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibee39a0917f120a4c3816e3792dcf6ae12eb0a6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505113Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821644}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1603842982-f4d76b0dbc68c465997b53b2b1abd32fd48f8f3c.profdata to chrome-mac-master-1603864709-845b29927599ab12682abdf7fcfbf1ec60b2364e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ief323df650a11dc54a4304fcc5bfeaa211963d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505111Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821643}
-
Rob Schonberger authored
Change-Id: Icffa98b8adf72e2cb9bfca3b7aec2fba5042827f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497781 Auto-Submit: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#821642}
-
Austin Tankiang authored
This reverts commit a42b2a30. Reason for revert: Causing failures on linux-chromeos-dbg and linux-chromeos-chrome - see https://crbug.com/1143173 Original change's description: > [CrOS PhoneHub] Mark tether ineligible if SIM has no reception. > > TetherControllerImpl will now mark the tether feature ineligible if > it is notified by the PhoneModel that the SIM state has changed to > anything other than kSimWithReception. > > Fixed: 1140812 > Bug: 1106937 > Change-Id: Ia18c5e06c57805541b03b29afea1762e85b8304f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500182 > Commit-Queue: Regan Hsu <hsuregan@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821493} TBR=khorimoto@chromium.org,hsuregan@chromium.org Change-Id: Id0ae4601f07b125f8e1e11b99b2de81ab0344bfd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106937, 1143173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504857Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#821641}
-
Hidehiko Abe authored
This CL refactors UTF{8,16}CharIterator by using StringPiece{,16}. - Unify constructors to just StringPiece. - Changed the index type from int32_t to size_t. - Accessor methods are also updated. - UTF16CharIterator::char_offset() is kept int32_t intentionally because it is not the index within the underlying array. - Update example to use for-statement. - Update clients to adapt with the new constructors/accessor methods. Bug: 1140536 Test: Ran trybots. Change-Id: Ib29ca5ae4190217dcd39d665f6aedbca0a0b4df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492481 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#821640}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I151cdba58e32725c5da40506395906eccec7b077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504981Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821639}
-
Alan Cutter authored
This CL updates how a web app's launch URL is computed given a launch_query_params configuration. If the launch_query_params are already present in the start_url then they are not appended a second time. Bug: 1142701 Change-Id: I394c8d96ee5e6a3776ed0c3555167b672b5e50b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501107 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#821638}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1603680975-76e0bcad480e2e9cf63aee149b7c46a4d88220b4.profdata to chrome-win32-master-1603831993-ad45cd294d298c80e2b0aad0e49861b0d50b053b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1a9742da89b29016de420bb1f43826f5bc679984 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504693Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821637}
-
Sara Kato authored
Internal cleanup to remove deprecated code. Bug: 1110585 Test: None Change-Id: I3574a6578233b71654bcefc1c6b638321de1f993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465896Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#821636}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: If4d755c5d9584f8924539fe774cde25e1918566c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503619Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821635}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d9d752771b77..e6112e17b371 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shend@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shend@google.com Change-Id: I09af0770dd4906be33190c756838e87cffe72e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504979Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821634}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/784ac915d427..7b14f2f6e971 2020-10-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 98c5ff6b49b3 to ee4e0866cb85 (17 revisions) 2020-10-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 6d5913ce to 0b545254 (537 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Test: Test: Test: Manual verification with angle_perftestsTest: Test: Texture2DTestES3::ChangeTexSizeWithTexStorage Change-Id: Ie21602194c6c54156201931c3ed7c7e0e1b6e3cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504980Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821633}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 88-4296.0-1603705354-benchmark-88.0.4304.0-r1 to 88-4296.0-1603705354-benchmark-88.0.4305.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Icc2d51d8769674566302193ce1f79f241f54b8ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504988Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821632}
-
Tom Anderson authored
R=sky BUG=1066670 Change-Id: I5c97675cd5c8e2257f326c6beb0d9b8efe0f05cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477656 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#821631}
-
Josiah K authored
AX-Relnotes: n/a. Change-Id: Ib818ea7014ecc5b9ff857a289bfe0fe03e9c994f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496190 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#821630}
-
Glen Robertson authored
This matches the explainer and makes it more explicit that the service was not available intentionally. Bug: 1131747 Change-Id: I9afca606f000d969b05b1e5cff9f95b124617b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497944Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#821629}
-
Leo Lai authored
Now we are using AttestationClient directly instead of passing through CryptohomeClient. BUG=b:158955123 TEST=build ok. Change-Id: I38e0cb370cfeb93a4388d62c09040faf4203af58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467639 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#821628}
-
Maggie Cai authored
This CL: 1. Fix the issue where preferred app found metrics is not logged in CommonAppsNavigationThrottle. 2. Delete the destination platform getter and the unittests in ChromeosAppsNavigationThrottle, which is never used. 3. Fix the issue where for preferred app found picker action, the destination platform is never recorded. 4. Add PWA preferred pressed enum. 5. Add specific destination enum for preferred app found case. 6. Fix the unit tests. BUG=853604 Change-Id: I269c2d93b6bf3996c2c9e4c97293ed6904437b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501582 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#821627}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 88-4296.0-1603709458-benchmark-88.0.4304.0-r1 to 88-4296.0-1603709458-benchmark-88.0.4305.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I2d34e2795ec64e50a171302a0a7ae85cbdcb754b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504986Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821626}
-
Austin Tankiang authored
Bug: None Change-Id: If7ec7f8f9bbc7d5cb10bbe02eece69eb57d7be74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497782 Commit-Queue: Austin Tankiang <austinct@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#821625}
-
Hidehiko Abe authored
Bug: 1140537 Test: Ran Lacros with enabling IME locally with JP IME. Change-Id: Ie4c4533f3352fdfbfb57047bde7176047c311ba9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487740 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#821624}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fa425033..11223a39 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I709249c3a0a903f98b3a82fff063b49bd1987d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503855Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821623}
-
Swapnil authored
We store detailed reason if the extension installation fails due to unpacking failure. We want to add unpacker failure reason event to the existing events for the event based reporting for force installed extensions so that detailed reason can be reported. Bug: 1048640 Change-Id: I4cdd9592920411bb2b12a290708d99ce2ba1c469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489992Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#821622}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2acd43d7c9ba..784ac915d427 2020-10-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 41c24933da1e to 47ee61679da0 (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I1b6d43a63eb04f365b6d567baef2c8f0d0fae8fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504974Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821621}
-