- 01 Oct, 2020 40 commits
-
-
Akihiro Ota authored
This change fixes a regression that was introduced by adding in-page link support for ChromeVox. The issue is that when the panel is collapsed, a scrolled_to_anchor event is fired, which was causing us to always place focus on the Panel root web area upon collapsing the menus. To fix the issue, we ignore scrolled_to_anchor events if the root of the target differs from the root of the current range. Fixed: 1133548 AX-Relnotes: N/A Change-Id: I43e99452ea27cd190bd53c62b5fb06593a5bf6b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442899 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#813000}
-
bttk authored
LocationBarPhone and LocationBarTablet independently implement method setUrlFocusChangePercent(float) which modified a protected LocationBarLayout field. This is one of the simplest changes that reduces the differences between Phone and Tablet LocationBar APIs. Bug: 1133482 Change-Id: I4e9379786bb20009a10be2f812c15323d2c5c1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438883 Commit-Queue: who/bttk <bttk@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#812999}
-
Anastasia Helfinstein authored
AX-Relnotes: n/a. Bug: 897365 Change-Id: I9ca877042531bc7d2b57fd27c390a113c63f58b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391383Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#812998}
-
Nnamdi Theodore Johnson-Kanu authored
Requirements: - https://docs.google.com/presentation/d/1Mfk5ZMEmeHwSbadUbyRU0Si5k6XDIvw-j4u7TUaCIGY/edit#slide=id.g7dc3c1fe01_5_125 Screenshot: - https://screenshot.googleplex.com/7S9tRak4yYCiP2a.png Bug: 1093185 Change-Id: I6f71cbf42be9780ea1f5341c31c9b36a2219583f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441271 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#812997}
-
Kenichi Ishibashi authored
Bug: 1117369 Change-Id: I72f5277b8d7e57a648b5d14cec4318e7488f6636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440329Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812996}
-
Khushal Sagar authored
The only remaining platform is linux which doesn't ship GPU raster currently. This change switches any test code using GPU raster on linux to OOPR. R=sunnyps@chromium.org Bug:757605 Change-Id: I5c14c9d7bc423307156e3ca6b091d263036ac4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439895 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#812995}
-
Findit authored
This reverts commit 6ff69d8a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 812968 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZmZjY5ZDhhNTk3M2RjNDRjMDVkZjQzZGFlYWIxNGM0YjY2ZWJlZDIM Sample Failed Build: https://ci.chromium.org/b/8867600652610457968 Sample Failed Step: compile Original change's description: > Move SODA client unit test to Chromium repo > > This CL moves the SodaClientUnitTest from the internal SODA repo to the > Chromium repo. > > Bug: 1124873 > Change-Id: Ib2dabb242f21817a117f379fb0a1b017dd5bcffc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443218 > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Evan Liu <evliu@google.com> > Cr-Commit-Position: refs/heads/master@{#812968} Change-Id: I654d24caca240a531da7dac1c8dc8225ef523e73 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1124873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444233 Cr-Commit-Position: refs/heads/master@{#812994}
-
Alan Screen authored
Adding support for PrintBackend queries to happen out of the browser process requires related data structures to be made available via a Mojo interface. These are moved into their own mojom file separate from the common definition in printing/mojom since they are specific to a new process being introduced and do not need to be encumbered by the dependencies which exist for print.mojom. Starting with the historically most prolific cause of browser crashes from printing (GetPrinterSemanticCapsAndDefaults), work towards having support definitions to enable that query to be moved out-of-process. Add a mojo definition to go with the printing::AdvancedCapability which is needed to support the larger query on ChromeOS. Bug: 809738 Change-Id: I05bbc441873d6f3a88ae57a27c5abe6c7c4be47b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387543 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#812993}
-
Nicolás Peña Moreno authored
Bug: 1133883 Change-Id: Id4aac54f834ca7bcf017e8afbbaa4a151d8492b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441732 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812992}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/29ef556aff96..ab4a49259c0e 2020-10-01 alessiob@webrtc.org GainController2::ToString updated 2020-10-01 alessiob@webrtc.org AGC2: max output noise level now part of config 2020-10-01 eshr@google.com When reconfiguring VP9 restore previous input pixel format 2020-10-01 sprang@webrtc.org Sets VP9 buffer size and speed based on highest active spatial layer. 2020-10-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2cdb2cb6..3211fba0 (812617:812728) 2020-10-01 nisse@webrtc.org Delete AllowBlockingCalls and android_media_codec_common.h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4b8a509e0e50a75aed5a23fd0056fc1108b8774a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443774Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812991}
-
Michael Crouse authored
Bug: 1089314, 1089312,1089310 Change-Id: I3cd2b0113e850e9b3795cea08a011c7060559f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441377 Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#812990}
-
Haiyang Pan authored
This is a reland of f6120650 The original CL was reverted yesterday, to release the resource for the higher build request. Today the build request seems fine so reland this CL Original change's description: > luci: Increase CQ experimental percentage to 80 from 60 for pie-arm64-rel > > After the test suites adjustment in crrev.com/c/2427028, the device > usage looks in a good shape and should be able to hold more traffc: > http://shortn/_E2uBVeObl6 > > Bug: 1111436 > Change-Id: I9bfb44a96feb2bc2d49ec8335afc73324711db5c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429931 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#811298} Bug: 1111436 Change-Id: Iebdc89855816f214f317c0f646a301d87987bd1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444190 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#812989}
-
Mingjing Zhang authored
This CL improves the jank metrics by excluding the delays caused by frames without intended updates and prevents certain outlier cases when a high jank percent is reported on a page with very low percent of dropped frames. Bug: 1133058 Change-Id: If32576e8b528e22b184a0b549161751fcfd976bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417211Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#812988}
-
Findit authored
This reverts commit 3792c739. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 812962 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzM3OTJjNzM5M2NjNTExMzExNzhiMThiZTViMzFlOGU3ODUxMjI1ZWUM Sample Failed Build: https://ci.chromium.org/b/8867601753821372336 Sample Failed Step: compile Original change's description: > Add additional states to FindMyDeviceController > > Fully implements the FindMyDeviceControllerImpl class. This change > also features a new state: kRingingNotAvailable. > This state is only set if the DoNotDisturb is enabled. > > Bug: 1106937 > Test: chromeos_components_unittests > Change-Id: Ifeb4dd88ea19ad6949bad2a92d840f392d7ccd47 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438773 > Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812962} Change-Id: Ieb095886c387c2fbcb8c08aad64f10092098302b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444469 Cr-Commit-Position: refs/heads/master@{#812987}
-
Karan Bhatia authored
This reverts commit 2e1031ec. Reason for revert: Causes compile failure on linux-chromeos-dbg. Original change's description: > [CrOS PhoneHub] Add enable hotspot and locate phone controller to quick > actions UI. > > - Add enable hotspot and locate phone quick actions controllers. > - Connect the controllers to quick actions UI. > - Minor changes in fake tether controller for testing. > > BUG=1106937,1126208 > > Change-Id: I1d4ace03120a4c51fcb351b7c19f33252b3fb81c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428735 > Commit-Queue: Andre Le <leandre@chromium.org> > Reviewed-by: Tim Song <tengs@chromium.org> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812915} TBR=khorimoto@chromium.org,tengs@chromium.org,leandre@chromium.org Change-Id: I431b965f354a2d63bd98e361b8ae3233ba5288e7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1106937 Bug: 1126208 Bug: 1134378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444132Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#812986}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30ea8e724567..110e287f7da0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC aaronhk@google.com,karandeepb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1128599,chromium:1130858,chromium:1132967,chromium:1134248,chromium:912681 Tbr: aaronhk@google.com,karandeepb@google.com Change-Id: I45529cbae30a1ba29492da29506e8c5f9eb66a56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441548Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812985}
-
Matt Wolenetz authored
Instead of manipulating the media element's audio and video tracks directly from the SourceBuffer, this change moves that into the MediaSourceAttachmentSupplement interface. Currently, TrackBase and TrackListBase usage by HTMLMediaElement and SourceBuffer require ownership and operation by the main thread, and further require knowledge of the main-thread-owned media element for use in scheduling events on the main thread. For cross-thread MSE-in- Workers attachments, to prevent regressing BackgroundVideoOptimization, the media element will need knowledge of the worker-MSE audio and video track identifications used by the underlying media pipeline. This change supports future signalling of the media element to add or remove such audio and video tracks via new methods in MediaSourceAttachmentSupplement. Existing same-thread behavior is maintained by new implementations of these methods in the SameThreadMediaSourceAttachment. SourceBuffer is updated to understand which of the methods to use, as until track ownership and operation in worker context is supported, workarounds in SourceBuffer and the attachment will be needed. Later changes will include the cross-thread attachment implementation of the media-element track addition and removal to actually perform the signalling. This change retains the pre-existing experimental AudioVideoTracks ability of MSE in Chrome for same-thread-attachments, but prevents (with a CHECK failure, since IDL prohibits alternatives) retrieval by the app of a SourceBuffer's audioTracks or videoTracks when the MSE is in a worker context. BUG=878133 Change-Id: I209ce61915de2e4182807539013606322ece8f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427566Reviewed-by:
Will Cassella <cassew@google.com> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#812984}
-
Matt Menke authored
This potentially provides a small amount of information that help could identify a user across sites. Bug: 973801 Change-Id: Ie9e16755323a4418b2d3109ce4993bcbe0d36a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443549Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#812983}
-
Haiyang Pan authored
The pool has plenty of 4-cores for extra builds: http://shortn/_Bdez2rvyhe Bug: 997376, 1127110 Change-Id: I04a4a1da5bcd143ba8e653dae52dfd6df8df6419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444050 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#812982}
-
My Nguyen authored
https://crrev.com/c/2436969 introduces variable for clear search icon fill color, using inherit does not work because --cr-icon-button-fill-color is a variable in cr_icon_button. Specify it directly instead. Bug: 1134044 Change-Id: I48ae7bd0a28d8d1505b50759421308feeec2442e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440729 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812981}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d628ffbd8f1d..b677e985297d 2020-10-01 kimstephanie@google.com Reland "Reland "Add optional enforce_fetch kwarg to fetch and refresh git cache"" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1129235 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: Ibc5845711cf9227ff8457c25f7f0681a85ab1d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441385Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812980}
-
Mitsuru Oshima authored
This is a workaround for crbug.com/1134279, but probably better way to handle this particular situation because the animation layer will fade out w/o interruption and a user will see the final state. DefaultFrameHeader.AnimateDuringAnimation Bug: 1132276, 1126857, 1134279 Test: manual (see bug for reprostep), Change-Id: I31c0281983f52a4d181addf8c522e1efa5eeddcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442378Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#812979}
-
Dan Harrington authored
The problem was that we were handing the same view to RecyclerView multiple times. We already wrap views in parent views before handing them off to the recycler view. The fix is to always wrap the child in a new parent. Bug: 1131975 Change-Id: I6f1a92e3d8201d4395d9c5208d8289e961f450b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436420 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#812978}
-
harrisonsean authored
Adds new default strings to safety check so that rows don't resize. Running state keeps the same detail text as the previous state. Bug: 1078782 Change-Id: Iffa246a5baca2b2cf8051e87cc10a1d6d80f6c2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443729Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#812977}
-
Xiaoqian Dai authored
In window capture mode, the user should be able to interactively select a window to capture. when the to-be-captured window's bounds or state is changed, we should update the capture region to reflect the change as well. Other changes that is worth mentioning in this CL: - Window stacking order or activation order will not be changed by the capture window selection change - If current selected is closed/minimized or becomes invisible, we automatically select another window under mouse/touch event location. and if there is no such window, do nothing. - If another window is activated when a window is selected, if the activated window is under mouse/touch event location, it will be focused instead. - When a mouse moved over a selectable window, change its cursor to either capture icon or recording icon Bug: 1127526 Change-Id: Icfdbed419dadfe0301b60da693f01010f4a2da2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421090Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#812976}
-
Rahul Arakeri authored
This CL fixes an issue where in if a user flings the scroller while diagonally overscrolled, the scroller never comes out of the overscroll and instead, plays a forward animation that takes the scroller to the end. This happens because ElasticOverscrollController::Animate keeps supplying zero time deltas to StretchAmountForTimeDelta and that leads to the animation never ending. The time deltas are zero due to momentum_animation_reset_at_next_frame_ wrongly getting reset every frame while diagonally overscrolled. The comment for momentum_animation_reset_at_next_frame_ claims that it was put in place to handle programmatic scrolls while overscrolled. However, after deleting this code and doing some tests, I don't see any difference in how programmatic scrolls are handled while overscrolled. This is code was carried over as a part of the overscroll refactor (crrev.com/c/2231254). The code was originally at least 5 years old and seems to be no longer needed. Getting rid of the code fixes the bug too. Bug: 1122482 Change-Id: Idb78a735d023e40151fba4a69e2191d1117cf95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377235 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#812975}
-
Mustafa Camurcu authored
Updated list of apps traced for runtime performance: - Replaced Candy Crush with Gacha Club. - Added PUBG Mobile. See: https://docs.google.com/document/d/1cqSY6kxB9uRX5GoyUavgC20YDAXspZKO84HUO1Zyg8U BUG=b:168800826 TEST=Run targeted app on device and see tracing results on /var/log/chrome/chrome Change-Id: I8ffa8c74462e4e64db126922fbf1656afe22794f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424981 Commit-Queue: Mustafa Camurcu <camurcu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Auto-Submit: Mustafa Camurcu <camurcu@chromium.org> Cr-Commit-Position: refs/heads/master@{#812974}
-
Andrew Comminos authored
Intent to ship approved here: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8Vt2atMrNNs Bug: 910421 Change-Id: Ie399046d6a0116d76e86b0daa2bddce306f1c24a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443493Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Auto-Submit: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#812973}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/64eb64a034cb..b09f16ee7aeb 2020-10-01 jmadill@chromium.org Don't pull in Vulkan headers in Skia standalone. 2020-10-01 cnorthrop@google.com Capture/Replay: Minor fixes for MEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Test: Test: angle_perftests --gtest_filter="*Trace*" Change-Id: I4fc2997d9854b1702466186c7f5a95b5c1a69c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443273Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812972}
-
Ella Ge authored
We got a large number of digital asset link failure on Beta/Dev/Canary: https://docs.google.com/document/d/1pbIEGFjvd_En9PQJnO7mhcGZ96CGe3CQsQkOihRDwLs/ This CL makes TWA not close the Activity when failing digital asset link if the client app has no installer name (is installed from adb instead of from a store). Also add an additional UMA metric to record the quality enforcement violations when a crash actually happened. Bug: 1109609 Change-Id: I09fefde367e804d85063fd35270d547ff3864b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440290Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#812971}
-
evliu authored
This CL defines the browser tests to be run by the Speech On-Device API (SODA) builder. Bug: 1122784 Change-Id: I3a5c7aa283b827940a51eaf92047fb97a20cbd32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443547Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#812970}
-
George Steel authored
This particular case was reversing its progress. Rewrite TransformOperationsTest::InterpolatedTransformBlendIdentityTest to check interpolation in both directions. Bug: 1132480 Change-Id: Ib81db414353961acb401b3805417417e1d8073f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432761Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#812969}
-
evliu authored
This CL moves the SodaClientUnitTest from the internal SODA repo to the Chromium repo. Bug: 1124873 Change-Id: Ib2dabb242f21817a117f379fb0a1b017dd5bcffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443218Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#812968}
-
Kenneth Russell authored
Some recent devices use this chipset series, including even the previously-problematic Adreno 330, but apparently with newer graphics drivers that pass OpenGL ES 3.0 conformance. Have tested successfully on a Nokia 1.3 (Adreno 308) with the WebGL 2.0.0 conformance suite. Starting with Android 10, remove the earlier graphics driver bug workarounds, and enable WebGL 2.0 on these devices. Bug: 1042214 Change-Id: Ie1290cf42900891357ceae1cef2709db43a87d52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443399Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#812967}
-
Andrew Comminos authored
Ensure that when shipping isInputPending, we don't ship isFramePending as collateral. Bug: 910421 Change-Id: Iddfc0ba927a9b61a90e99da18e12bb7513c93b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443213 Commit-Queue: Andrew Comminos <acomminos@fb.com> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Auto-Submit: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#812966}
-
Olivier Yiptong authored
This is a reland of 404b7cc4 The original CL failed some tests because the code assumes that platform-specific APIs called returned unique data. This was a false assumption. This reland follows another CL: https://crrev.com/c/2438875, which ensures that fonts are not duplicated. Original change's description: > FontAccess: Sort fonts in lexicographical order > > This change ensures fonts are sorted before being cached. This change is > due to a concern about fingerprinting: > https://github.com/w3ctag/design-reviews/issues/399#issuecomment-530679815 > > This change ensures that fonts are sorted in lexicographical order. > > Bug: 1043306 > Change-Id: Ia3acf2a45cb473124df4e489683bdc7bac15dde4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427040 > Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810519} Bug: 1043306 Change-Id: Ic3d70744661a838d82349c017a1cb0e8c23a3654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432815 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#812965}
-
siashah authored
Currently we're populating the item tag only for the autofill popup. We'll populate for the autofill keyboard accessory as a follow up after implementing the UI for the keyboard accessory. Bug: 1093057 Change-Id: I909569e16ccaced0bc3dde01e0f03d9de3204706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436862 Commit-Queue: Siddharth Shah <siashah@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#812964}
-
Xi Han authored
With this CL, we don't suppress bottom sheet in Start Surface any more. Bug: 1129746 Change-Id: Ie1b1b2b3e29c6a77c1f24ea651a7f1030d60171b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431545Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812963}
-
Jimmy Gong authored
Fully implements the FindMyDeviceControllerImpl class. This change also features a new state: kRingingNotAvailable. This state is only set if the DoNotDisturb is enabled. Bug: 1106937 Test: chromeos_components_unittests Change-Id: Ifeb4dd88ea19ad6949bad2a92d840f392d7ccd47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438773 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812962}
-
Peter Kotwicz authored
Design doc: https://docs.google.com/document/d/1SNrFzWCXb4KaegXH8nokilOHGSkTFvLfhK75ZwmIKaE/edit?usp=sharing This CL introduces //third_party/androidx/fetch_all_androidx.py which retrieves androidx dependencies from snapshots in https://androidx.dev/snapshots/latest/artifacts and runs //third_party/android_deps/fetch_all.py The version of the androidx dependencies is generated based on information in https://androidx.dev/snapshots/latest/artifacts/BUILD_INFO The CL also: - Fixes fetch_all.py --ignore-vulnerabilities command line parameter to skip 'dependencyCheckAnalyze' step. - Adds the 'useDedicatedAndroidxDir' parameter to build.gradle to replace androidx dependencies in //third_party/android_deps with a java_group() which points to the target declaration in //third_party/androidx BUG=1064277 Change-Id: I652e56a9721154487c10fafaa2008fc728b9d8b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399773 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#812961}
-