- 27 Mar, 2020 40 commits
-
-
Matt Mueller authored
Bug: 634484, 1040681 Change-Id: I38a15bf4aa52ee6106a782237ca579938aa6886c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947630 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#754216}
-
Lei Zhang authored
Rename it to setLoadCompleteCallback, since its behavior changed over time and this is what it does now. Rename some related variables to be consistent and do a couple random cleanups along the way. Change-Id: Ibb6571923e0dc6e5f7198df91123b663a176b899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124212Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#754215}
-
Matt Mueller authored
This makes it clear that this is just a chrome netlog invention and not some standard. Change-Id: I2585ba02121eb604e97b08449502ddfdb31408cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124238Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#754214}
-
Chris Harrelson authored
Non-lazy images don't show this icon. It's incorrect to show such an icon just because an image is loading. In addition, it messes up the intrinsic sizing heuristics for aspect ratio. Both lazy and non-lazy images still show a broken image icon when images fail to load via HTTP failure. Bug: 997606, 1045745 Change-Id: I5dc6bac50a1c43395057e37547864e9e3fc13b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109330 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
rajendrant <rajendrant@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#754213}
-
Jordan Taylor authored
This change makes it easier for timelines to compare against previous timeline values. It also allows timelines to produce a phase in addition to a current time. Timeline phase allows animations to correctly apply fill modes. Spec issue discussion: https://github.com/w3c/csswg-drafts/issues/4325 Bug: 1046833 Change-Id: I1354f69afd04efe498a53b2f8839a83b8d6153c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112586Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Jordan Taylor <jortaylo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#754212}
-
Lei Zhang authored
Convert all implementations and callers. Simplify some surrounding code along the way. Change-Id: Icee22f3802e634180f8c6ad0eab23bad81965ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124107Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#754211}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3ca41df3d3ba..de3f38a72c48 git log 3ca41df3d3ba..de3f38a72c48 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 sugoi@google.com Fix Android.bp following the SPIRV-Tools update 2020-03-27 bclayton@google.com Regres: Switch to building with LLVM 10 Created with: gclient setdep -r src/third_party/swiftshader@de3f38a72c48 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I1a0f05383100ab16d6180da2da9b89a56bcb90ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125169Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754210}
-
Nektarios Paisios authored
Blink doesn't always remove all deleted whitespace at the end of a textarea even though it will have adjusted its value attribute, because any extra layout objects that might happen to exist in its layout tree are invisible. Similarly, the value attribute is not updated when an autocomplete popup is visible in a native text field. Therefore, We stop relying on the value attribute for hypertext and text boundary calculations when a text field originates from Blink and use its inner text instead. We detect this by checking if the text field has descendants in the internal accessibility tree. For finding the next / previous text boundary, e.g. the next line start, we need to access the inline text boxes that represent each text span. Similarly, for exposing the text on a node on Windows IA2 and Linux ATK, including the value of an autocomplete popup we rely on hypertext calculation. Before this patch and in the case of a web-based native text field, the text in the field was retrieved from the HTML value attribute. This could cause a mismatch, if the text that is produced by concadenating all the inline text boxes was different from the contents of the value attribute. With this patch, we switch to BrowserAccessibility/AXPlatformNodeBase::GetInnerText to compute the inner text of a subtree. To do this, we need to correct GetInnerText to collect text from all leaf nodes, and not only text-only objects. For example, <button aria-label="button"></button> will have no text-only children, but will still need to expose the text of its label in AtkText and IAccessibleText. This patch surfaced an issue with placeholder text in <textarea> and <input> fields which was not previously exposed in hypertext. Split off from: https://chromium-review.googlesource.com/c/chromium/src/+/2110471/18 when there is a blank line at the end of a textarea. R=dmazzoni@chromium.org, aleventhal@chromium.org Relnotes: Screen reader correctly announces "blank", instead of a random character, Bug: 1044410 Change-Id: I64ad2502c729076858fe52fc64d1ed1fda3cff1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122718 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#754209}
-
Scott Violet authored
This also changes the client library to throw (runtime) exceptions in certain scenarios. This is an incompatible change to the client library, but prior to this we would have hit DCHECKs, and Alihan agreed with this change, so I'm going for it. BUG=none TEST=none Change-Id: I9ee43b8c61c999245ab5a8bd4e90a21b8aca42e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124299Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#754208}
-
Internal Frameworks Autoroller authored
TBR=bling-p10-rolls@google.com Change-Id: I62bbeb997ac53d694463c585b3229183020a7888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124074 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754207}
-
rbpotter authored
cr.define and function(() calls can't be used in the same file when autogenerating Polymer 3 code. Move the Callback enum to the browser proxy, and delete the Component enum as it is unused. Bug: 1026426 Change-Id: Ib44c7c9f83eca07b03abca2167b47da93f24e97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125017Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#754206}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d94f8ea2b545..b3e593c1ba1e git log d94f8ea2b545..b3e593c1ba1e --date=short --first-parent --format='%ad %ae %s' 2020-03-27 sokcevic@google.com Escape AST string before writing to tokens 2020-03-27 sokcevic@google.com Enable test for git_rebase_update on Windows Created with: gclient setdep -r src/third_party/depot_tools@b3e593c1ba1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I9ae8983ebd5b2551f5cdc19b0379d7f128e84583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125168Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754205}
-
Robert Sesek authored
The network_service_test_helper_ is created conditionally in the constructor, and it's undefined behavior to dereference a null pointer. Bug: 1064609 Change-Id: Ic9c79ef049225d1172e568c39d14c9528e3e78d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124538 Auto-Submit: Robert Sesek <rsesek@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#754204}
-
Peng Huang authored
Bug: 1065499 Change-Id: I6384dec15c652aa0bbbb9f52e9c6381d07dbd23a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124976Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754203}
-
Becca Hughes authored
This is a reland of 25e37730 The fix is to loosen the assertion on the time fields which have a different format on win7. Original change's description: > Reland "[Media Feeds] Add feed items to WebUI" > > This is a reland of 0bbf0f94 > > Original change's description: > > [Media Feeds] Add feed items to WebUI > > > > This adds the feed items to the WebUI. You > > can select a feed to show the content. > > > > BUG=1058187 > > > > Change-Id: I5051f77b68cb3da6710a547d50109cb95a7b890f > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118758 > > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > > Reviewed-by: Tommy Steimel <steimel@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#753441} > > Bug: 1058187 > Change-Id: I7ec8a25ba03d192341e6d02eccfba991b4156504 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121450 > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753712} Bug: 1058187 Change-Id: I69f0f6dbe336d7a46b2c3d2e4e251256d37390d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124630Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#754202}
-
Tom Anderson authored
Tab dragging interacts poorly with tiling WMs since the window is constrained by the WM, which will ignore move/resize requests from Chrome. To address this, this CL makes the window unmanaged for the duration of the tab drag, so that the WM will not intercept our move requests. BUG=416119 R=sky CC=msisov,nickdiego Change-Id: Ida494a80fc0fca86171bd493d6d0e7a424c326b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119756 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#754201}
-
Tommy C. Li authored
This feature surfaces an X button next to deletable suggestions in the omnibox. Enable this flag by default for rollout with M83. Bug: 1205 Change-Id: Ic3f18d20aeef3959b8ff3f7ab1338bb17db1ca33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124907Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#754200}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4502a6360996..dd82c211fcb5 git log 4502a6360996..dd82c211fcb5 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 treehugger-gerrit@google.com Merge "traced_perf: mallopt(M_PURGE) when going quiescent" Created with: gclient setdep -r src/third_party/perfetto@dd82c211fcb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I04059e061d7cdff5f53b7f3068577da8ed944999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124060Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754199}
-
Tim Judkins authored
Adds histogram logging to extension navigations caused by tabs.create, tabs.update, windows.create and browser.openTab (the latter only being used by apps), detecting if the URLs passed to those functions have the devtools scheme. Bug: 1049265 Change-Id: I7ac97e66ecf31d01d571936614a2d509deb6af9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102784Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Tim Judkins <tjudkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#754198}
-
Peng Huang authored
Right now, the vulkan_tests can only run with X11. This CL make it work with android. Note: vulkan_tests is not running on any bots right now. Bug: 1065499 Change-Id: Ie8f9c452d2a77beb8e3c8d4c1fa715a8b708c2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125009 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Chris Blume <cblume@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#754197}
-
Livvie Lin authored
Fixes the case where a full HTTP URL will show in the omnibox, but get removed when clicking into the omnibox to edit. This patch will retain the HTTP scheme so that it's easier to add an 's' to attempt navigation to HTTPS. Bug: 1061576 Change-Id: I94d96bcb89b20a8c8bf2fc63dd5825d25f799907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122861 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#754196}
-
Marijn Kruisselbrink authored
Color should be different in for example dark mode, so make sure to get the color from the current theme. Bug: 1065451 Change-Id: I581605d4f4c52f2ca2a50126e1a20d9ec865c2d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125034 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Auto-Submit: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#754195}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 83-4085.6-1584956258-benchmark-83.0.4091.0-r2 to 83-4085.6-1584956258-benchmark-83.0.4094.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ie79981394a2c345a7f729494c39b6935ec3d04f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125111Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754194}
-
edchin authored
In recent CL: crrev.com/c/2122820, EXPECT_EQ was inadvertently changed to ASSERT_EQ. This CL fixes that recent mistake. Change-Id: I239e980a7ae7b24ae709faeff3e57be3078c2b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125018 Commit-Queue: edchin <edchin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Auto-Submit: edchin <edchin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754193}
-
Robert Ogden authored
Bug: 1023485 Change-Id: I8581e00f867b04e5312df0ea1fabdb06690c4d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121086Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#754192}
-
Robert Ogden authored
This CL actually makes a working feature out of Isolated Prerender. Now, prefetches done by the tab helper will be taken and used by the navigation interceptor and replayed over mojo channels via FromString Loader. For ease of manual testing, this CL also adds some command line flags: * override proxy hosts * set unlimited number of prefetches per SRP Additionally, the following changes are also made: * remove the FromSRP feature flag, consolidating under kIsolatePrerenders * testing for probing moves to browser tests instead of unittests * isolation of prerenders support removed, but code stubs left in place since that support will be re-added soon * small mojo receiver leak fixed * added prefetch timeout Bug: 1023485 Change-Id: I7b4d9e30a3e125b525b7b10ce5151b82570c84f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118397 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#754191}
-
Robert Sesek authored
This reverts commit 1b8f4946. Reason for revert: This was just a bandaid. Internal change has rolled in. Original change's description: > Temporarily restore CustomTabsConnection.extractCreatorPackage. > > An internal class apparently overrides this method, and now > is broken because it is marked @Override. > > Tbr: wychen@chromium.org > No-Try: true > Bug: 1065440, 832124 > Change-Id: I0a8e1bf64c99c004dfa3a9a4cee91da71112bd37 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124232 > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754079} TBR=wychen@chromium.org,rsesek@chromium.org Change-Id: I1164c811f506ebbd0d93dd22ab6bff4c11d193b7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1065428, 832124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124061Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#754190}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/774019051243..baf491f249db Created with: gclient setdep -r src-internal@baf491f249db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1013783,chromium:832124 Tbr: jbudorick@google.com Change-Id: I27d4ff34291c43408481e0e1d27c0bcb989cecd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124043Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754189}
-
Sergey Ulanov authored
Previously WebEngine was implementing RequestMediaAccessPermission(), but not CheckMediaAccessPermission(). Check*() is called when a page tries to enumerates devices. It returns deviceIDs for audioinput devices only when the page can access microphone and that functionality didn't work properly. Bug: 1064813 Change-Id: I9dc37d5e35eee0c3ddd02c8e6c852763f0ec3cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121446Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#754188}
-
Peter Kasting authored
This means callers only need to call TearDown() if they need to do something between teardown and destruction, which most don't; and they cannot fail to call TearDown() (and thus leave objects alive). So it's both simpler and safer. Bug: none Change-Id: Ia7c8088df6475af28e37e81215ee704dd8e5650f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125187 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#754187}
-
Dana Fried authored
Now if the available size of a layout has changed, its children will be re-laid-out to ensure that they can react (in this case by animating). Solves a bug where: - An animating layout is embedded in a flex layout - The animating layout can drop to zero size/drop out - The flex layout is created at a very small size and then resized larger This happened with the extensions container in PWA windows under very specific conditions but could affect animating layouts elsewhere as well. Bug: 1057901 Change-Id: Ie18da24284dadf538d641ad5c2c15fc55d2b3b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123107 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#754186}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/2e33129995df..e928c969dbb5 git log 2e33129995df..e928c969dbb5 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 rwkeane@google.com mDNS: Add Service Type Enumeration 2020-03-27 btolsch@chromium.org Make all sockets go through select() 2020-03-27 miu@chromium.org Cast Streaming Standalone Sender: Congestion control, and video. 2020-03-27 rwkeane@google.com mDNS: Cap Cache Size in MdnsQuerier Created with: gclient setdep -r src/third_party/openscreen/src@e928c969dbb5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Iab3fda277ffbdb154b9508676fbe3400f466f3aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125170Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754185}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 83-4044.62-1584958487-benchmark-83.0.4091.0-r2 to 83-4044.62-1584958487-benchmark-83.0.4094.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I538268691e8b9f02da6c09f8ec5ac070865b9de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125176Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754184}
-
Matt Jones authored
Bug: 952703 Change-Id: I5040d4a1aff5227c8fe825acb62f5e1bd865b081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124970Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#754183}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f95a35fb706f..07e5b8f0edb6 git log f95a35fb706f..07e5b8f0edb6 --date=short --first-parent --format='%ad %ae %s' 2020-03-27 csmartdalton@google.com Rename TessellatingPathRendererTests.cpp -> "Triangulating" 2020-03-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 02e15b249b12..3ca41df3d3ba (10 commits) Created with: gclient setdep -r src/third_party/skia@07e5b8f0edb6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Ia41dc81b9c762d489b62d1f9c214232e5ab29b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124046Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754182}
-
Eugene But authored
Old target created zip archive, while new target simply copies the directory. Creating zip archive requires to list every file in the archive, which is hard to maintain. Copying the directory would work fine because compression can be done on the build bot. Bug: 1064181 Change-Id: I92825cb56f614e328052987f4d6fa86602b41972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125014 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#754181}
-
Ian Wells authored
This is a reland of f2033302 Original change's description: > Add tests for FeedStore > > Bug: 1044139 > Change-Id: I1a72a48c438c53299397a161dfcaabeae0501452 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109258 > Commit-Queue: Ian Wells <iwells@chromium.org> > Reviewed-by: Dan H <harringtond@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753844} Bug: 1044139 Change-Id: I1d48e4cb18d313230b18ac1205d782458dbf2e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123641 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#754180}
-
Alexander Cooper authored
When including the device/vr/test target into content there is a name collision with FakeSensorProvider from fake_sensor_and_provider under //services. In order to enable the device/vr version to have whatever changes the device/vr tests need, this change renames this class from FakeSensorProvider to FakeXRSensorProvider Change-Id: Id07ff9371f9bb30c85ae9a33be46e37ea44c8140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124533 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#754179}
-
Josh Horwich authored
Remove code form ARC graphics tracing related to NYC-based SurfaceFlinger ReleaseBuffer event detection, since ARC no longer uses Android N. BUG=b:151958629 TEST=chrome://arc-graphics-tracing Change-Id: I126a71321fcf4b778eb732c169302ed5015b1c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125188Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Josh Horwich <jhorwich@chromium.org> Cr-Commit-Position: refs/heads/master@{#754178}
-
Danan S authored
This will allow SupervisedUserInitiatedExtensionInstall, which is already enabled by default, to take effect, which will enable the parent permission dialog for supervised users to install extensions. Bug: 957832 Change-Id: If851c79f07817d6f044ed3ca1b634516f8cbcbd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123410Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#754177}
-