- 20 Aug, 2020 34 commits
-
-
Emily Stark authored
In the hide-on-interaction field trial, we were previously handling navigations only in DidFinishNavigation(). That is, when a navigation began, we didn’t change the elision state until it commited in DidFinishNavigation(). This worked well for renderer-initiated navigations, where the visible URL doesn’t update until the navigation commits. But it didn’t work for browser-initiated navigations, where the URL would update at the very beginning of the navigation and inherit the elision state of the previous navigation until DidFinishNavigation (see screencast in crbug.com/1111665). The fix for this is rather tricky and not perfect. For a browser-initiated navigation, the order of events is as follows: - URL is updated (triggering EmphasizeURLComponents) - DidStartNavigation - DidFinishNavigation Because the URL is updated at the first step, we need to set the elision state in EmphasizeURLComponents. Even setting in DidStartNavigation would be too late, as we could still get a flash of the new URL with the previous navigation’s elision applied to it. The problem, though, is that we don’t know if we should elide the URL until the navigation finishes, because the elision logic depends on whether the navigation was same-document and if it changed the visible URL’s path. (In particular, for same-document navigations that only change the fragment, we ignore those and don’t have them change the elision state at all.) Therefore, in EmphasizeURLComponents(), we don’t know for sure whether we should leave the URL elided if it already is elided, or if we should unelide and reset to the on-page-load state. I wasn’t able to think up a perfect solution for this, but the best I can come up with is to make our best guess how to elide in EmphasizeURLComponents(), and then fix it up as we get more information in DidStartNavigation() and DidFinishNavigation(). Specifically, EmphasizeURLComponents() elides to the simplified domain if the URL had already been elided, and shows the full URL otherwise. DidStartNavigation() then fully resets to the on-page-load state for cross-document navigations, and DidFinishNavigation() fully resets to the on-page-load state for same-document navigations that changed the path (which we don't know until the navigation commits). There remains a weirdness where a browser-initiated navigation will initially briefly show the simplified domain of the destination before updating to the full URL in DidStartNavigation(), but I think this is far better than briefly showing the destination URL truncated where the previous page’s URL was truncated. Bug: 1111665, 1109778 Change-Id: Ia1528254b8203dee93bd0964666b76d4b15bfd46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360803 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#799914}
-
Chris Lu authored
Now that all Infobars have been converted to the Overlay framework, DCHECKs can replace early returns to ensure that infrastructure exists for all Infobars. Bug: 1030357 Change-Id: I293755ae96b4f9eba763ffb1158f5e2260d3306b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363324 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#799913}
-
Robert Liao authored
BUG=1108460 Change-Id: Ie5eb700075a15cc1cec52f500831115a161f100c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364080Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#799912}
-
Haoyue Wang authored
https://quiche.googlesource.com/quiche.git/+log/58468984dc04..8607b29d7b55 $ git log 58468984d..8607b29d7 --date=short --no-merges --format='%ad %ae %s' 2020-08-19 fayang Log handshake completion time in quic_connection_stats. Logging only. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I841c661b04d19a245616b17d0d111ac23165ab58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363220 Commit-Queue: Haoyue Wang <haoyuewang@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Haoyue Wang <haoyuewang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#799911}
-
Joey Arhar authored
Bug: 1117589 Change-Id: Id2e0e344553189018324ebfe30418419944400c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363434 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#799910}
-
Dirk Pranke authored
As one of the first steps in making the build work with Python 3, we will need a way to indicate which actions still require Python 2 to run (most work fine under Python 3 already, but some do not). This CL introduces a python2_action() template, which works just like a regular action() rule, but ensures that the script runs under Python 2 instead of whichever Python version you happen to be running. This CL also switches //tools/metrics:histograms_xml to use it (because it seems to need it) as a proof that it works correctly and does not regress in a normal (python 2) build. Bug: 941669, 1118214 Change-Id: I98fbc073cf9443acece3caaae2ed35f9d60c38e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363655 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#799909}
-
Wan-Teh Chang authored
Change the AVIF matrix coefficients default to 6 (BT.601). This is specified in the draft MIAF Amendment 2. Bug: 1119465 Change-Id: I2aa6a07e709327fd1f776effc5767c887928c660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364026 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#799908}
-
Sangwoo authored
When using Korean as display language, web test runner doesn't work. Let people know this with error string. Bug: None Change-Id: I96e2454699db827c3e8f373a401658082de2a095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364345 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#799907}
-
David Bienvenu authored
Other miscellaneous cleanup, no functional changes. Bug: 1010217 Change-Id: I6b86bf6467d360d2e8a7732f350b4c4a9b8427f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363671 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#799906}
-
Mike Dougherty authored
Changes being made in crrev.com/c/2353092 are breaking these cookie tests when using web::HttpServer. Since net::http_server::EmbeddedTestServer supports setting cookie, these tests can be updated to use the now recommended EmbeddedTestServer and default handlers. Bug: 891834 Change-Id: I08bdb620ad15b640c0beae22d712cca9fc5c7407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363390Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799905}
-
Rachel Carpenter authored
Conditional on the feature being enabled. Icon created following process at https://chromium.googlesource.com/chromium/src/+/refs/heads/master/components/vector_icons/README.md Feature enabled: http://screen/62b743f6-671f-4810-be87-53d1fc2e7a35.png Feature disabled: http://screen/PbaSenAign5.png Change-Id: I2384977b098737a40aff16de23ed8186beab75e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355352Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#799904}
-
Vidhan authored
Bug: 1080468 Change-Id: Ia85c3a27edd63a03ba17089d1fbfc2b3210f268d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362659 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#799903}
-
Will Cassella authored
This CL changes the "ResolutionBasedDecoderPriority" feature to be disabled by default, so that the remaining issues can be resolved before launch. Bug: 1110395 Change-Id: Id47f023850f2f082cb7338d87ec4949f122656d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364962 Commit-Queue: Will Cassella <cassew@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799902}
-
Zhenyao Mo authored
On Intel GPUs where YUV hardware overlays are supported, BRGA8 overlays seem to be supported, but the system fails to report that. BUG=1119491 TEST=manual, gpu_unittests R=magchen@chromium.org Change-Id: I304aef3731f142c13c945ca22ce0df81afbcd21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364580 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#799901}
-
Joshua Bell authored
Now that Blink can talk directly to Mojo (it's only been what... 3 years?) remove the WebIDBFactory cruft and have blink::IDBFactory make calls directly to the backend mojom::blink::IDBFactory. No functional changes. Bug: 843764,717812 Change-Id: I7f8370570a21fd19c5a98b2b1d5d8e31db702a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363176 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#799900}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4978cb248d45e82f58fdd92b53a93f4c5fffc2c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365232Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799899}
-
Orin Jaworski authored
This CL adds one last language that was previously excluded due to pak file versus spreadsheet-data naming mismatch: hu vs. hu-HU. Bug: 893183 Change-Id: I3443fe36588d4c91d217b019d324313235e07fcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364582 Commit-Queue: Orin Jaworski <orinj@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Auto-Submit: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#799898}
-
Kyle Horimoto authored
Change-Id: I160b4cde304ef843070e0dc60fda9c60799cec18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365675 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#799897}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I0a8bf0b805057659f5f1678b6b38174b892d690f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364084Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#799896}
-
Chris Hall authored
R=meredithl Change-Id: Iacf878aea64518ad9e66a661589c7e11f55cc66e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362382Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799895}
-
Salvador Guerrero authored
The following tests are failing on builder "android-bfcache-rel" CoopReportingOriginTrialBrowserTest.AccessReportingWithToken CoopReportingOriginTrialBrowserTest.CoopStateWithToken TBR=arthursonzogni@chromium.org Bug: 1119555 Change-Id: I3cf6acde50f9ea42773a92f5b2d4229d59433722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365362Reviewed-by:
Salvador Guerrero <salg@google.com> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#799894}
-
Ian Kilpatrick authored
There was only one caller for this within: ThemePainterDefault::PaintInnerSpinButton This replaces that one caller with the equivilent logic. Removes other auxillary methods only used within ControlStatesForNode, e.g. LayoutTheme::IsFocused There should be no behaviour change. Change-Id: I0717e4fe9dd5c0ec9448f916e38671b2a37b8539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363325Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#799893}
-
Shakti Sahu authored
This CL moves ThinWebView to components/thin_webview so that features such as payments can use it while being on components. Bug: 1116770 Change-Id: Ie412a88f2ef630739b2bf5828b89b3c1c5e4c44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358994Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#799892}
-
Miguel Casas authored
Original CL was reverted because it wrongly removed the line va_buffers_.erase(buffer_id); Reland changes in crrev.com/c/2363833/1..2/media/gpu/vaapi/vaapi_wrapper.cc Original CL description ------------------------------------------------ media/gpu/vaapi: use new |va_buffer_for_vpp_| for Vpp/BlitSurface() ToT VaapiWrapper uses |va_buffers_| for internal Vpp uses and also for external VEA/JEA use. This CL starts refactoring these VABufferIDs lifetime, by splitting the Vpp VABufferID out of |va_buffers_| and into a ScopedID |va_buffer_for_vpp_|. Bug: b:162962069 Change-Id: Id377ebb44b6add14eb9227d1450c68a24eaee42b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352522 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#799410} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363833 Cr-Commit-Position: refs/heads/master@{#799891}
-
Andre Le authored
Add the logic to update visibility for "Clear all" button depends on the count of total and unpinned notification. BUG=1111167 Change-Id: Ie609ae1225c0041e3c45815b1f4c2550136ace77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339942 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#799890}
-
Avi Drissman authored
Bug: 1119479 Change-Id: I889ae0f4f01e5e4a79d48fca1172b920a1393a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363363Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#799889}
-
Wan-Teh Chang authored
These test images were added in commit ea65e680: https://crrev.com/c/2321307 Bug: 1108626 Change-Id: I35f7b58ab9b38d308744513c77b617e271fcd47b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365220Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#799888}
-
Ian Kilpatrick authored
Removes a combination of unused methods, or methods which only returned one possible value. There should be no behaviour change. Change-Id: Iabc747262dcf46dc514b361890a85adc171754fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363659Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#799887}
-
Roman Arora authored
Mojo bindings and API to show the feedback page. Bug: 1099917 Change-Id: Ie1fd176f67d069b1eb7b9bed1db79751ea4c6df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356971Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#799886}
-
rajendrant authored
static_cast<TabWebContentsDelegateAndroid> maybe a problem if different delegate got used. So using a different method to check for isCustomTab Bug: 1117533 Change-Id: Ibf5fde78e77bfaa407538880c181c713e176cb0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363215Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#799885}
-
Adam Langley authored
This code matches up with the Android accessory device code recently added on the desktop side. It is not yet wired into anything on the phone side. BUG=1002262 Change-Id: I802eb6a0275a71744b374589003f5a0675bbb58d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341033 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#799884}
-
minch authored
The root window and root_location of the event are still based on the original display while dragging a window across displays. This makes the magnifier will not be activated in the display that the window has been dragged to until the drag be released. This cl updates the root window and root location during drag to make sure the magnifier can be activated at corresponding display immediately while drag a window across displays. Bug: 1082392 Change-Id: Ie3feb7679c29e1e9c0b4f8811ae98bd0f170ade0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354997Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#799883}
-
Timothy Loh authored
The path for vm disks recently changed so we need to correspondingly update the code here. This is a follow-up to http://crrev.com/c/2362163 which fixed detection of crosvm processes for Crostini. A tast test will be added in http://crrev.com/i/3186385 once this has uprevved. Bug: chromium:1114826 Change-Id: I97a7fb93fa18f54121ab9ca384281181b7ea0f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364148Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#799882}
-
Mustafa Emre Acer authored
When Delayed Warnings feature detects and delays an interstitial, Client Side Detection could send another phishy verdict for the same URL. This causes the interstitial to be undelayed immediately. This CL changes the CSD behavior so that it never checks if a Delayed Warning observer is attached to a tab which only happens if a warning is being delayed. This is manually tested to work both on official and non-official builds. A follow up CL will add browser tests. Bug: 1118192 Test: Manual Change-Id: I418910c35ec692ef23e4295a6b59092cb55d5968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364213Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#799881}
-
- 19 Aug, 2020 6 commits
-
-
Dirk Pranke authored
This reverts commit cd69e8f5. Reason for revert: re-landing with a fix. Original change's description: > Revert "Rework generated_script handling in MB." > > This reverts commit b05d8793. > > Reason for revert: Broke ios full_configs bot. See: > https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-full-configs/25885 > > Doesn't look like this change triggered the full_config bots on try. > > Original change's description: > > Rework generated_script handling in MB. > > > > It turns out the work I did on the "wrapped_*" targets in > > gn_isolate_map was somewhat overlapping with the already-existing > > iOS work to declare things as "generated_scripts". However, the > > generated_scripts did not include test_env.py. > > > > So, this CL rearranges things so that the generated script will call > > test_env.py, and then we can share logic between the generated_script > > targets (and every target on iOS and LaCrOS) and use that as the > > basis for the rest of the work going forward. > > > > Bug: 816629 > > Change-Id: I9d55c3f1587defcb599ddf1df838dd9ed5b6a12c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357917 > > Reviewed-by: Erik Staab <estaab@chromium.org> > > Commit-Queue: Dirk Pranke <dpranke@google.com> > > Cr-Commit-Position: refs/heads/master@{#799171} > > TBR=dpranke@google.com,estaab@chromium.org,jeffyoon@chromium.org > > Change-Id: I94597d58417f7aa76320579ca282293e6b643811 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 816629 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364014 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799629} TBR=dpranke@google.com,justincohen@chromium.org,estaab@chromium.org,jeffyoon@chromium.org # Not skipping CQ checks because this is a reland. Bug: 816629 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs Change-Id: I1f481f23ff1f1de991b13f3e5aadf967818c2763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364696 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#799880}
-
zhaoyangli authored
This is required from Xcode 12 which is rolled to main builders today. No-try: true Bug: 1119510 Change-Id: I7db1dcfdb3dde77d692bfc978ba6502db7592813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365432 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#799879}
-
Tommy Steimel authored
Bug: b:154517281 Change-Id: I4dbdbfb787db3d6436def3f77a2d19b0052a26ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361044 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#799878}
-
Yuke Liao authored
This reverts commit 66870c32. Reason for revert: 1. The root cause is not lacros, symptom is generally seen across all builders. 2. #pending tasks is ~0 now: https://chromium-swarm.appspot.com/task?id=4e21b13cf27db110&o=true&w=true. 3. 400 VMs were temporarily added to the pool to mitigate the outage. Original change's description: > Revert "[lacros] Enable linux-lacros-rel by default" > > This reverts commit ac7726b8. > > Reason for revert: reverting to shed load on CQ, crbug.com/1119483 > > Original change's description: > > [lacros] Enable linux-lacros-rel by default > > > > This CL enables linux-lacros-rel on CQ by default. > > > > Bug: 1116180 > > Change-Id: I67bf89a5eefd7382bbd2886f416bc38c411213bf > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360496 > > Reviewed-by: Erik Staab <estaab@chromium.org> > > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#799123} > > TBR=estaab@chromium.org,liaoyuke@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1116180, 1119483 > Change-Id: I2be0017d3af1e863ec15efaa3c3cdf1ff1764911 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364140 > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799798} TBR=estaab@chromium.org,liaoyuke@chromium.org,bpastene@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1116180 Bug: 1119483 Change-Id: Ib9211794c4eb92e3e5c721c77f4821dda49d8a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365223Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#799877}
-
Kevin McNee authored
These tests crash under android asan. Tbr: asvitkine@chromium.org Bug: 1102747 Change-Id: If26aff18beacc1108e0617b4ba04d66ac3197709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365152Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#799876}
-
Arthur Eubanks authored
Bug: 1114873 Change-Id: Idc828b72f08583ab336c706c1bd8843e076bf573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357457Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799875}
-