- 07 Aug, 2018 20 commits
-
-
Sky Malice authored
Also fixed lint and presubmit errors. Change-Id: I559d8eed024d84b6fdc0bcc0e7d6019dadb4b5f2 Reviewed-on: https://chromium-review.googlesource.com/1162275Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Yafei Duan <romax@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#581063}
-
Trent Apted authored
Since https://crbug.com/732993 was fixed, gn now supports a `friend` property which the ui/views/ test targets can use. This means "internal" headers only used (also) in tests no longer need to be repeated in test targets inside views/BUILD.gn. So, declare other targets in views/BUILD.gn as friends, remove those repeated headers, and mark some things internal. Start with ui/views/cocoa. Currently 3 headers are used in mac browser code (for OS-specific fullscreen/native frame, and touchbar things). Bug: 871123 Change-Id: I5e5a260dd200f1bffc4f6fb8456d6e854fe19c52 Reviewed-on: https://chromium-review.googlesource.com/1163351 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#581062}
-
Tom Anderson authored
BUG=853841 R=pkasting Change-Id: Iac25d17618487e03aac7bfa6f54e98848ce47c24 Reviewed-on: https://chromium-review.googlesource.com/1159385 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#581061}
-
Reilly Grant authored
This change ports UploadJobImpl from net::URLFetcher to SimpleURLLoader. Since this request does not make use of the response a new method has been added to SimpleURLLoader, DownloadToNull. This download mode still reads the response body from the network but does not save it anywhere. This is useful for requests which upload data and would otherwise have to specify an arbitrary |max_body_size|. A maximum may still be set if the caller wants to limit the amount of data transferred over the network. Bug: 773295 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iee1fdc6f7406066ced8c91122e22cd51ddcb1c5f Reviewed-on: https://chromium-review.googlesource.com/1161551 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#581060}
-
Lukasz Anforowicz authored
This CL removes not_site_per_process_browser_tests from the bots, because: - Site Isolation has shipped to the stable channel in Chrome 67. Currently //chrome layer defaults to site-per-process mode (see r552589 and testing/variations/fieldtrial_testing_config.json). - After recent changes (see https://crbug.com/671734 and https://crbug.com/824962) no known tests are skipped when run in site-per-process mode. Bug: 870761 Change-Id: I158e8980846077c2d1ef03bf03f3b80c8191ca81 Reviewed-on: https://chromium-review.googlesource.com/1164172Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#581059}
-
Clark DuVall authored
This is a reland of c9cbab07 request_completed_ was being set unnecessarily after RemoveRequest was called. Original change's description: > Fix ExtensionWebRequestApiTest.WebRequestUnloadImmediately with network service > > The error event was not being sent when the client was reset. > > Bug: 721414 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I951422061022d50644d8453900af14be27bb9eaf > Reviewed-on: https://chromium-review.googlesource.com/1150403 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580911} TBR=jam@chromium.org Bug: 721414 Change-Id: I48769a4b86d2a18acbe5fbcedb9de3ed478e4c54 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1164209Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#581058}
-
Yafei Duan authored
Adding flag for live page sharing of Offline Pages. Bug: 870895 Change-Id: Id34ae2ebcc1c83e736505f69a9d78055d3aec94e Reviewed-on: https://chromium-review.googlesource.com/1162824 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#581057}
-
Takuto Ikuta authored
This does not allow arbitrary files are included in isolated input from fontconfig_caches directory. Bug: 870622 Change-Id: I69bc8993800f263d7e3d7679ed85f9c79a380a0b Reviewed-on: https://chromium-review.googlesource.com/1163596Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
-
James Cook authored
Chrome OS supports the concept of a "root window for new windows", which allows new windows to be automatically placed on the correct display. This knowledge lives in ash, currently inside the browser process. Remote processes that use views::Widget (e.g. the shortcut viewer app) sometimes need to know what window they are going to open on, for example to do initial bounds computations. Change Screen to provide set and get for the display for new windows. Use mojo to send the information to other processes via ScreenProvider (on the ash side) and ScreenMus (on the remote side). Send the display id as part of display updates so that ScreenMus gets it on startup, and also so updates are atomic with other display changes. Once this lands we'll be able to port browser windows to use this mechanism and delete the ash::ShellState / chrome ShellStateClient code I built as a one-off for browser windows under mash. Bug: 867559, 764009, 826569 Test: added unit tests Change-Id: I6b5beb2610243f30072c3d73180b3ce21a310ca6 Reviewed-on: https://chromium-review.googlesource.com/1162980Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#581055}
-
Eric Willigers authored
ResizeObserver shipped to stable in M64 https://chromium-review.googlesource.com/754562 https://www.chromestatus.com/features/5705346022637568 BUG=612962 Change-Id: I8b323722c3bf8caa028ec5d14964b43dc13d1faa Reviewed-on: https://chromium-review.googlesource.com/1163060Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Yoav Weiss <yoav@yoav.ws> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#581054}
-
Kenichi Ishibashi authored
Bug: N/A Change-Id: I81c242020af0121c6876704839f1a89a751d5b97 Reviewed-on: https://chromium-review.googlesource.com/1163233Reviewed-by:
-
Ramya Nagarajan authored
Records metrics for availability (or unavailability) of background and shortcuts customization. Also records interactions with aspects of these features. See go/ntp-metrics-doc. Bug: 855935 Change-Id: I24b376c0752adb4077e9f48dd10ab23ff6253d68 Reviewed-on: https://chromium-review.googlesource.com/1158800Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#581052}
-
Ned Nguyen authored
Bug: 870905 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: Ic558eb8ce497bda92a8956b498c999ca06bc1a05 Reviewed-on: https://chromium-review.googlesource.com/1163126Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Reviewed-by:
David Tu <dtu@chromium.org> Commit-Queue: David Tu <dtu@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#581051}
-
Robert Liao authored
BUG= Change-Id: I91c108d80a9418b9447ae394ceb9a56e4c9c48a9 Reviewed-on: https://chromium-review.googlesource.com/1164395 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Chris Palmer authored
Bug: 680657 Change-Id: I2d879f5b28c392a083fbd867a3eb05568d19dc67 Reviewed-on: https://chromium-review.googlesource.com/1164252Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#581049}
-
Xiaoqian Dai authored
The new selector item's window and its |item_widget_| should be placed below the dragged window. Bug: 871580 Change-Id: I48d5705c687b4b75518d5ec47c71b8f746f22587 Reviewed-on: https://chromium-review.googlesource.com/1164525Reviewed-by:
Min Chen <minch@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#581048}
-
Sheng-Hao Tsao authored
This CL does 2 things: 1. Hide legacy camera app icon 2. Launch legacy camera app (com.android.camera2) when com.google.android.GoogleCameraArc is not available. Sometimes when devices are upgraded from version with Camera2 installed, GCA still has com.android.camera2 as the package name. That's why this CL is needed. Bug: b:112121210 Test: Tested on nautilus that after this CL, the legacy camera app icon Change-Id: I16e4d29d4cb538bd2ad6607456bcf4667be1f188 Reviewed-on: https://chromium-review.googlesource.com/1127899Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Cr-Commit-Position: refs/heads/master@{#581047}
-
Ted Choc authored
Turns out this line matters: https://chromium-review.googlesource.com/c/chromium/src/+/1148680/16/chrome/android/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java#b226 BUG=871131 Change-Id: I3b37cb9b97f58b7f9bcb14b29107c82d79721b44 Reviewed-on: https://chromium-review.googlesource.com/1164382Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#581046}
-
Shakti Sahu authored
1- Modified the mutator logic to maintain the items in a date/section ordered hierarchical form 2- The mutator will add views for sections, section separators and date separators. Several other smaller details such as : 1 - First section should have less spacing between the preceding date. 2 - The last date/section shouldn't have a separator. Bug: 866307 Change-Id: I6eca116c26f403760160d016655fad3c05278c3a Reviewed-on: https://chromium-review.googlesource.com/1151062 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#581045}
-
Peter Kasting authored
This reverts commit a9dac60b. Reason for revert: May have broken compile on https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/35014 Original change's description: > Generate deterministic zip file for remoting > > build_utils.ZipDir uses fixed timestamp and this makes zipped file deterministic. > > This is a part of effort to utilize cache of test execution on swarming. > > Bug: 870611 > Change-Id: Ie370f1f5a3e08834c6280b0088f90b31d038e3be > Reviewed-on: https://chromium-review.googlesource.com/1163349 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581034} TBR=jamiewalch@chromium.org,thakis@chromium.org,yuweih@chromium.org,tikuta@chromium.org Change-Id: I54ed04c00775bd7b0818e10e3bfc9df0619b828b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870611 Reviewed-on: https://chromium-review.googlesource.com/1164129Reviewed-by:
-
- 06 Aug, 2018 20 commits
-
-
Nico Weber authored
Bug: 549140 Change-Id: Ie0dfb2c1983fe1d587e9c959eff72b1c46506a68 Reviewed-on: https://chromium-review.googlesource.com/1163314Reviewed-by:
-
Theresa authored
Use the old dark action bar color and status bar color for the ManageSpaceActivity. On some versions of Android, a white icon is shown in the ManageSpaceActivity task in Android recents. When the primary activity color is white, this causes the icon to disappear. BUG=871193 Change-Id: I6e5bd0c2fe59b64d20367b22254683a8998744c7 Reviewed-on: https://chromium-review.googlesource.com/1163830Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#581042}
-
Matt Wolenetz authored
Adds a UseCounter for tracking usage of SourceBuffer.changeType(), retains gating that method's visibility to those in chrome://flags/#enable-experimental-web-platform-features, and lets origin trial framework also enable visibility of the method using feature name "MediaSourceChangeType" for increased experimentation. BUG=605134 Change-Id: Iaf6e1ca58b579cd09b7c07573fb817ec1e69ad82 Reviewed-on: https://chromium-review.googlesource.com/1162583Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#581041}
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iafcb5b0a0671f1f73fcd52f7c7f7b34fa98045b1 Reviewed-on: https://chromium-review.googlesource.com/1164396Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#581040}
-
Weidong Guo authored
Bug: 871448 Change-Id: I3f8b2c4c9e22065c6615db7d3fab8c8c6b1a7e20 Reviewed-on: https://chromium-review.googlesource.com/1164245Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#581039}
-
Daniel Erat authored
Remove power_prefs.h and power_prefs_unittest.cc files that I think were accidentally missed when r549765 moved code from //chrome to //ash. Bug: 812504 Change-Id: Ic83f1d400742321756b09f9f2cc9cc738883f2bd Reviewed-on: https://chromium-review.googlesource.com/1164410Reviewed-by:
-
Joel Hockey authored
The absolute path for the mount point of Linux files is long and not user friendly. We should replace the path with the "Linux files" label, which we use in Files app UI. Moved all existing code for sanitizing path display names into file_manager/path_util.cc where it can reuse the existing path naming for consistency. Bug: 863616 Change-Id: Ie4dd57937840760e8468d37182efe64cd3059438 Reviewed-on: https://chromium-review.googlesource.com/1160831Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#581037}
-
David Black authored
Previously, the SuggestionContainerView was the footer of the AssistantMainStage. Now, I've added AssistantFooterView which is the new footer of AssistantMainStage. AssistantFooterView will have two children: - SuggestionContainerView - AssistantOptInView When the user is opted out, SuggestionContainerView will be hidden and the AssistantOptInView will be visible. This CL adds the AssistantFooterView but not the AssistantOptInView. That will be added in a follow up CL. See bug for mock. Bug: b:112236931 Change-Id: Ie95a78639777f6cc009ce59ebffe4acc2e1d09dc Reviewed-on: https://chromium-review.googlesource.com/1163216 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#581036}
-
Lukasz Anforowicz authored
Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I8e39681139d273c16bc93cd58506bae2314fadd6 Bug: 846839 Reviewed-on: https://chromium-review.googlesource.com/1072645 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#581035}
-
Takuto Ikuta authored
build_utils.ZipDir uses fixed timestamp and this makes zipped file deterministic. This is a part of effort to utilize cache of test execution on swarming. Bug: 870611 Change-Id: Ie370f1f5a3e08834c6280b0088f90b31d038e3be Reviewed-on: https://chromium-review.googlesource.com/1163349 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#581034}
-
Johannes Henkel authored
There's just one enabled_ field here, a bool. Bug: 851762 Change-Id: I25247dc0d0333ea48ce2cf06c3fdf633ef2c1662 Reviewed-on: https://chromium-review.googlesource.com/1163998Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#581033}
-
Takuto Ikuta authored
This fixes exception happening on Windows deterministic builder like below. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Windows%20deterministic/9666 Change-Id: Iff309dabe5753fa1633366d6bc6716505aaf18c5 Reviewed-on: https://chromium-review.googlesource.com/1164144 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Ben Pastene authored
And add a few test suites that need that arg to run. Bug: 840967 Change-Id: I9954a08cc22f7237b0e0d2093214b544b6f3d897 Reviewed-on: https://chromium-review.googlesource.com/1162863Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#581031}
-
Alex Newcomer authored
There is a bug where users can keep their clamshell mode context menu open by detaching the keyboard. This allows users to have a side shelf in tablet mode, and they may get stuck in this state. This CL prevents this from happening by ignoring the clamshell options if they are somehow executed in tablet mode. Bug: 870469 Change-Id: Ifb9638c3ae705bd58a2e785edc5ca84d698651d2 Reviewed-on: https://chromium-review.googlesource.com/1161387Reviewed-by:
-
Manas Verma authored
This change fixes the Manage Cards button, in the Manage Cards prompt, to link to chrome://settings/payments instead of chrome://settings/autofill bug: 855186 Change-Id: I3d274367deae5d04c7a3029db8e5eec3aa852cc1 Reviewed-on: https://chromium-review.googlesource.com/1163743 Commit-Queue: Manas Verma <manasverma@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
-
Jun Cai authored
This CL updates the currently disabled browser tests for setting x-frame-options headers to web store requests. Bug: 852877 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I8e131848a37a8fbf5b9f4bdb53bcbb225440330d Reviewed-on: https://chromium-review.googlesource.com/1155931Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
-
Weidong Guo authored
Background: When screen is rotated to portrait, only half of the background shield is shown because mask layer bounds is incorrectly updated. 1. Remove mask layer used to create corner radius for background shield and, instead, draw rounded corner background on Canvas. 2. As a side effect, this improves dragging smoothness. Bug: 869622 Change-Id: Ia3b8ce30e0f76f27cdc90ab674504915a79cfb99 Reviewed-on: https://chromium-review.googlesource.com/1164178 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
-
Paul Miller authored
Change-Id: I68ee67d5c0f498e04ca3a892043557b6ce0289f5 Reviewed-on: https://chromium-review.googlesource.com/1164068 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#581026}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/58bf2845eb4d..e19516b87bb1 git log 58bf2845eb4d..e19516b87bb1 --date=short --no-merges --format='%ad %ae %s' 2018-08-06 eakuefner@chromium.org [Dashboard] Halve max concurrent histogram tasks Created with: gclient setdep -r src/third_party/catapult@e19516b87bb1 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:867379 TBR=sullivan@chromium.org Change-Id: Ie7b7d0e7b92b17e8cbae75271929f2e05e0f982b Reviewed-on: https://chromium-review.googlesource.com/1164282Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581025}
-
Ross Wang authored
Garnet no longer produces an SDK manifest; switch to topaz. Bug: None Change-Id: I43ef7d7d1cc64a57ec546c046379af381c4dcdb5 Reviewed-on: https://chromium-review.googlesource.com/1164397 Commit-Queue: Ross Wang <rosswang@google.com> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#581024}
-
