- 16 Mar, 2018 40 commits
-
-
Daniel Nicoara authored
This format is better supported and is the default format used for scanout buffer allocation. Bug: b/74993970 Test: Ran on device and ensured buffer allocation doesn't fail. Change-Id: I8743c9166e6ad41588418d10059fe2bac34fce35 Reviewed-on: https://chromium-review.googlesource.com/964893Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#543758}
-
https://webrtc.googlesource.com/src.git/+log/af9e87b8c5bb..bf3dbb4a692f $ git log af9e87b8c..bf3dbb4a6 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5c59e5cc263d132e2431ec05da2f66bfdfaa0086 Reviewed-on: https://chromium-review.googlesource.com/966593Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543757}
-
chaopeng authored
This issue is caused by we create vertical overlay scrollbar for <select> but not call ShowOverlayScrollbar since it does not need it. But we set the scrollbars hidden to false in ScrollableArea ctor which is not correct for overlay scrollbars. Overlay scrollbars (include Android, Aura, Mac) are hidden when creation. In this patch, we set scrollbars_hidden_if_overlay_ true in ScrollableArea ctor. It would not affect to non overlay scrollbars since we check for UsesOverlayScrollbars() before read scrollbars_hidden_if_overlay_. This patch also rename scrollbars_hidden_ to scrollbars_hidden_if_overlay_. Bug: 816714 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I5256fb99750cd3e7b7081231eada87572817bfe3 Reviewed-on: https://chromium-review.googlesource.com/957480 Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#543756}
-
Brian White authored
This reverts commit f17d7a0c. Reason for revert the revert: revert did not fix problem so re-landing Original change's description: > Revert "media: Use BindOnce everywhere in GMBVFP." > > This reverts commit f35e389b. > > Reason for revert: This CL is suspicious in Android WebKit test failures: > > The first failure: > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Android%20%28Nexus4%29/75367 > > Error message: > virtual/media-gpu-accelerated/external/wpt/media-source/mediasource-config-change-mp4-av-framesize.html failed unexpectedly (gpu crashed) > > Error log: > https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Android__Nexus4_%2F75367%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests%2F0%2Fstdout > > Original change's description: > > media: Use BindOnce everywhere in GMBVFP. > > > > Changes the use of Bind and Closure to BindOnce and OnceClosure in > > GpuMemoryBufferVideoFramePool. > > > > It additionally introduces a trampoline in MailboxHoldersReleased so > > that if the callback is called on media_thread it can skip going trough > > the message loop. > > Previous the callback would be bound to the media_thread loop. > > > > Two DCHECKs have also be added to check thread expectations. > > > > Change-Id: Ie704f6f6bdc4b7d9b8dd0f5ffec4675cd060d5e2 > > Reviewed-on: https://chromium-review.googlesource.com/959382 > > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > > Reviewed-by: Miguel Casas <mcasas@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#543609} > > TBR=dalecurtis@chromium.org,mcasas@chromium.org,dcastagna@chromium.org > > Change-Id: I600ddbf046ad44d4d80bf93ea81543e29dd8d46b > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/966321 > Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> > Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543667} TBR=dalecurtis@chromium.org,mcasas@chromium.org,dcastagna@chromium.org,dvadym@chromium.org Change-Id: I0293daf17496e6eeeb132c74fcd74fda97a38203 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/966688Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#543755}
-
Michael Giuffrida authored
Crash intentionally, e.g. to test out the crash reporter. Example: $ ./out/rel/app_shell --crash_test --enable-reporting DevTools listening on ws://127.0.0.1:37703/devtools/browser/ef324347-b8b4-4660-9270-aca50d1fb9d8 Redirecting output to ‘wget-log’. Crash dump id: d920a038bd86b598 zsh: illegal hardware instruction ./out/rel/app_shell Bug: None Change-Id: I3f69080f19a81b2661cce4b7ee867378ea166b13 Reviewed-on: https://chromium-review.googlesource.com/966545Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#543754}
-
David Black authored
Bug: b:75033730 Change-Id: I164d8798d4587a816cb11ccecb6027a2b8eec695 Reviewed-on: https://chromium-review.googlesource.com/964615 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#543753}
-
Steven Bennetts authored
Bug: none Change-Id: I23f0200f68aae38baeccb266b20fffe604128651 Reviewed-on: https://chromium-review.googlesource.com/965622Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#543752}
-
Mark Cogan authored
Bug: 804552 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I183368403e1977c28dd0696532feff849fcbf0df Reviewed-on: https://chromium-review.googlesource.com/966625 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543751}
-
Maks Orlovich authored
... Since there is no longer need for it to implement HttpUserAgentSettings anymore, just to provide some functions related to the language pref. Change-Id: I5afffca7f918e395df874ebddbffa970f2320d5f Reviewed-on: https://chromium-review.googlesource.com/965936 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#543750}
-
Jeremy Roman authored
Just a simplification. Change-Id: I5aea1364540c0ab7b9266dca03884b079468e574 Reviewed-on: https://chromium-review.googlesource.com/964393 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543749}
-
James Cook authored
ShelfController outlives TabletModeController. However, it looks like Shell destruction can trigger display layout changes, which are observed by ShelfController. These may be dependent on screen rotation animation state, and hence are hard to repro. Add a null check to avoid the crash, since this is simple and safe to backport. A followup CL will clean up the shutdown ordering. Bug: 817522 Change-Id: I7d02faf6179768457e56dff8bfdf2a74c8701b4c Reviewed-on: https://chromium-review.googlesource.com/966785Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#543748}
-
https://chromium.googlesource.com/angle/angle.git/+log/5ae6ee457860..6f5444da73ae $ git log 5ae6ee457..6f5444da7 --date=short --no-merges --format='%ad %ae %s' 2018-03-14 jmadill Remove HasIndexRange. 2018-03-15 jiawei.shao Clean up link validations on interface blocks Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Ie5e9f7232d7061a7e5f623c379ae303ead5893ef Reviewed-on: https://chromium-review.googlesource.com/966592 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543747}
-
Tommy Steimel authored
This CL removes the code that created the current time scrubbing popup in the modern media controls. It also changes the CSS to show the button panel during scrubbing. Bug: 817591, 816442 Change-Id: I8ad2bd5a634f0706884ca6648a36f506af620c23 Reviewed-on: https://chromium-review.googlesource.com/964904Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#543746}
-
Hans Wennborg authored
Clang r326867 turned on SafeStack when targeting Fuchsia by default. Turn it off in our build config until all the tests pass. Bug: 817298, 821951 Change-Id: Id2d9f911eb62fe6823365baeba55a4ccc0b484ce Reviewed-on: https://chromium-review.googlesource.com/959003Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#543745}
-
https://skia.googlesource.com/skia.git/+log/6e9a4f6327d1..8b858526faf4 $ git log 6e9a4f632..8b858526f --date=short --no-merges --format='%ad %ae %s' 2018-03-16 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 5ae6ee457..1c08cbb39 (1 commit) 2018-03-16 reed fix nextContour bug 2018-03-16 egdaniel Fix Vulkan Copy as draw shader 2018-03-16 robertphillips Prevent crash when flushing while DDL recording 2018-03-15 brianosman Support GL_OES_EGL_image_external on newer GLSL without essl3 Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I483b6a2403c5cef903b5bed56d30fdea2988c21e Reviewed-on: https://chromium-review.googlesource.com/966586 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543744}
-
Helen Li authored
This test is flaky because the test closes client connection during each for-loop iteration. When server checks whether the connection is still connected using accepted_socket_->GetPeerAddress() in network::TCPServerSocket::OnAcceptCompleted(), it will get net::ERR_SOCKET_NOT_CONNECTED (-15). This test keeps the client sockets alive and delay disconnecting them until server finishes all Accept() callbacks. Bug: 821224 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I7bf12704272f9ccc23c085c6d72db28a3d0dbe67 Reviewed-on: https://chromium-review.googlesource.com/966802Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#543743}
-
Xing Liu authored
Disable ParallelDownloadTest.ResumptionLastSliceFinished because it's flaky on ChromeOS. TBR=dtrainor@chromium.org, qinmin@chromium.org Bug: 822450 Change-Id: I90d737a8397a453af90288d05c7dc6bd8eefe23f Reviewed-on: https://chromium-review.googlesource.com/965569Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#543742}
-
Ramin Halavati authored
This reverts commit 5bea452c. Reason for revert: This CL was for collecting debug data on FYI bot. Data is now collected. Original change's description: > Add debug data for Traffic Annotation FYI bot. > > Traffic annotations FYI bot cannot access some files in build_path/gen. > Some Debug data is added to find out why? > > TBR=msramek > > Bug: 690323 > Change-Id: I4fb716d8b843704bf48cfbb62d5b09a3791eb732 > Reviewed-on: https://chromium-review.googlesource.com/966303 > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Ramin Halavati <rhalavati@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543702} TBR=msramek@chromium.org,rhalavati@chromium.org Change-Id: Ia3c53a938c1f19122e4b82ca77b357502feaeb89 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 690323 Reviewed-on: https://chromium-review.googlesource.com/966762Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#543741}
-
Jeremy Roman authored
A context was erroneously passed where an isolate is now expected. Introduced in: https://chromium.googlesource.com/chromium/src/+/eb8a2f1758cf71197e44bdbd79e59105ad845b51 Change-Id: I1b69c4533c7f607e6813c532eae78a2a0c7d50ca Reviewed-on: https://chromium-review.googlesource.com/964390Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543740}
-
Donn Denman authored
Adds another ContextualSearchManagerTest similar to an existing test that is currently somewhat flaky to see if the flakiness is due to polling on the UI thread vs the Instrumentation thread. BUG=818897 Change-Id: Icb40f34db4de4b1d26a4dc555a3bbf0d01b1090d Reviewed-on: https://chromium-review.googlesource.com/963288Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#543739}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/386975ac..2d6bcd79 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I0b94a7408e3db92f18c935c36fecffa54b7988c2 Reviewed-on: https://chromium-review.googlesource.com/965618Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#543738}
-
Marijn Kruisselbrink authored
Change linear search to binary search by keeping track of offsets of individual blocks of data. Bug: 740595 Change-Id: Ibdb2ebdbf91b6e9c6bda7c04c4ab5f56fec7c876 Reviewed-on: https://chromium-review.googlesource.com/964914Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#543737}
-
Sadrul Habib Chowdhury authored
Instead of delegating back to RenderWidgetHostView* for binding the mojom::CompositorFrameSink requests from the renderer, RenderWidgetHost can bind it itself, since all it needs is the view's FrameSinkId. In order to do this, RenderWidgetHostViewAura needs to initialize the DelegatedFrameHost and DelegatedFrameHostClient earlier than it used to. Change-Id: Iccb450699ee1123d86031c6bfb14af8cc725263d Reviewed-on: https://chromium-review.googlesource.com/965640Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#543736}
-
Julien Isorce authored
Detect the GL_VENDOR string from the default GL implementation. If it is the ATI proprietary driver then do not switch to EGL/GLES2 as there is a known bug and this driver crashes in eglInitialize instead of failing properly. BUG=822716 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I00b883012c31867f938bf3f68440058738bb312b Reviewed-on: https://chromium-review.googlesource.com/966662 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543735}
-
erikchen authored
Although it is not spec compliant, many websites intentionally call Window.print() on display:none iframes. Bug: 819327 Change-Id: I02c2b8c9dad0cb6c8c4601c6104986aceb469bba Reviewed-on: https://chromium-review.googlesource.com/964610Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#543734}
-
Bin Lu authored
Add missing flags to the iframe sandbox supported list, and add tests. Also remove the runtime config for 'allow-top-navigation-by-user-activation' since the feature has shipped a long time ago. Bug: 662506 Change-Id: I458210f6133ddd5e30b507214b003ff0fb596761 Reviewed-on: https://chromium-review.googlesource.com/965843 Commit-Queue: Bin Lu <binlu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#543733}
-
Julia Tuttle authored
Change-Id: I75ecc7e893dfababd7669554433e674d77d95c1a Reviewed-on: https://chromium-review.googlesource.com/953502 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#543732}
-
erikchen authored
The only remaining memory related column will be "Memory Footprint" [and Swapped Memory on CrOS]. For one-pager that was sent to chromium-dev, see: https://docs.google.com/document/d/1fSTVHKl8K7wLpx8755LCxbacnPBes8GiEmyAtHshohU/edit# Bug: 819678 Change-Id: If579b0fb4f9ed8a4ef35010a1f22d00eb780ff7a Reviewed-on: https://chromium-review.googlesource.com/957623 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#543731}
-
Alexander Timin authored
Refactor the scheme where TaskQueueImpl notifies TimeDomain about a delayed wake up and TimeDomain notifies TaskQueueImpl about next wake-up for it. Make TaskQueueImpl be the ground truth for delayed wake-ups for the particular queue and task TimeDomain with aggregating wake-ups across different queues. R=alexclarke@chromium.org,skyostil@chromium.org Change-Id: I7d56d35e9c7b5b2bb1240a6a659d0d9a1f00c473 Reviewed-on: https://chromium-review.googlesource.com/955847Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543730}
-
edchin authored
Bug: 818699 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0d24cfa9617876d313dd0f5cd7a44766b61d2844 Reviewed-on: https://chromium-review.googlesource.com/965382 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#543729}
-
Scott Violet authored
This is needed to handle focus changes correctly. The focus client in this case is extremely minimal. BUG=821602 TEST=covered by test Change-Id: I6e1cbd686edf8e0080b8a21a28c3ddeae4e640a4 Reviewed-on: https://chromium-review.googlesource.com/965445 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543728}
-
Daniele Castagna authored
Changes the use of Bind and Closure to BindOnce and OnceClosure in GpuMemoryBufferVideoFramePool. It additionally introduces a trampoline in MailboxHoldersReleased so that if the callback is called on media_thread it can skip going trough the message loop. Previous the callback would be bound to the media_thread loop. Two DCHECKs have also be added to check thread expectations. TBR=dalecurtis, mcasas Change-Id: I871e5505691b53a1871d2bd3e8a79ab1b75d2e69 Reviewed-on: https://chromium-review.googlesource.com/966583Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#543727}
-
Michael Thiessen authored
The touch selection controller may be null on Android for a few reasons, one of which is that selection is disabled in VR currently. Bug: 822374 Change-Id: Ie19fc8a4b148f64dc0fda391a45e758940d39154 Reviewed-on: https://chromium-review.googlesource.com/963680Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#543726}
-
Philip Rogers authored
This patch adds a mention of OptionalOrNullptr to the optional.md docs. Change-Id: I7d09afa336bcd06a11756b5d655370d162b80318 Reviewed-on: https://chromium-review.googlesource.com/965585Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543725}
-
Raphael Kubo da Costa authored
https://github.com/w3c/web-platform-tests/pull/9986 has introduced some flakiness to the test that is currently blocking WPT imports. TBR=lukebjerring Bug: 822757 Change-Id: Iddc3adf65989506b72fba003a2bbbd8d9cbf062f No-Try: True Reviewed-on: https://chromium-review.googlesource.com/966604Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#543724}
-
Marc Treib authored
This reverts commit a646eeb2. Reason for revert: Turns out the supposedly deprecated field is still widely used on the server. Will clean up those usages first and then reland. I considered manually undoing only those parts that actually touch the protocol, but that seems much more confusing and error-prone. I might reland the local parts of this separately though. Original change's description: > Sync cleanup: Deprecate GetUpdatesCallerInfo.GetUpdatesSource > > This enum deprecated years ago and replaced by GetUpdatesOrigin, > but it was still in use for debug info. Now we're using > GetUpdatesOrigin there too. > Unfortunately GetUpdatesSource is a required field in the > GetUpdatesCallerInfo message, so its definition has to stay. > > Bug: 510165 > Change-Id: Ib5ee13cd46c00e4aecb7af5913ee8c47af32f6c3 > Reviewed-on: https://chromium-review.googlesource.com/911628 > Commit-Queue: Marc Treib <treib@chromium.org> > Reviewed-by: Nicolas Zea (slow) <zea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#541140} TBR=zea@chromium.org,treib@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 510165 Change-Id: Icb680a1071497274a78477be04dc18040483c58c Reviewed-on: https://chromium-review.googlesource.com/966381 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#543723}
-
John Chen authored
TBR=kereliuk@chromium.org Change-Id: I5910c15bcb442cb152f50f75a9008cc7a37887b7 Reviewed-on: https://chromium-review.googlesource.com/966585Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#543722}
-
Eugene But authored
This reverts commit 247dee23. Reason for revert: Failing on iOS 10 32-bit builder. Original change's description: > Log MobileDownloadFileUIInstallGoogleDrive in New Download Manager. > > This CL also changes InstallationNotifier class to be compatible > with OCMock (UIApplication shared instance is not stored in ivar anymore) > and adds resetDispatcher method to allow restoring InstallationNotifier > to its default state. > > Bug: 791806 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: Iaee0d80938639d23862b254732eb49c97ddd4e86 > Reviewed-on: https://chromium-review.googlesource.com/958123 > Commit-Queue: Eugene But <eugenebut@chromium.org> > Reviewed-by: Peter Lee <pkl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543515} TBR=eugenebut@chromium.org,pkl@chromium.org Change-Id: I4c90614507c14322c6ab946ac4f8caeedc214cc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/966682Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#543721}
-
Anita Woodruff authored
This reverts commit b921591d. Reason for revert: Probable cause of WebView segfault in https://crbug.com/822732 Original change's description: > Move websocket.mojom from third_party/WebKit to services/network > > As a preparation to integrate websocket with the network service, this > CL moves the mojom file to /services/network. > > Bug: 721400 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: I1284cbd9dd3292c41d1acba34835c6c6d44d48a3 > Reviewed-on: https://chromium-review.googlesource.com/961173 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543632} TBR=kinuko@chromium.org,jam@chromium.org,yhirano@chromium.org Change-Id: I6062a78052b82364418c9f57ab768c8f001cb549 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 721400,822732 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/966761Reviewed-by:
Anita Woodruff <awdf@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#543720}
-
https://webrtc.googlesource.com/src.git/+log/8870f553f3d0..af9e87b8c5bb $ git log 8870f553f..af9e87b8c --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I052c004ae08b5ff2be6af51bd9a2f5eb1a9fd88a Reviewed-on: https://chromium-review.googlesource.com/965932 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543719}
-