- 03 Sep, 2020 40 commits
-
-
Dominik Röttsches authored
Lookup local() fonts from Android downloadable fonts and the GMS core provider. Instantiate Mojo connection to the Java side, send IPC requests for font lookups this way. Requires https://chromium-review.googlesource.com/c/chromium/src/+/2347916 and https://chromium-review.googlesource.com/c/chromium/src/+/2375329. Bug: 1115064 Change-Id: Ibb0112f9df3f75003a91d880a1476a6f6087a942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387017Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#804471}
-
edchin authored
This reverts commit e413add4. Reason for revert: This approach is wrong. A much simpler approach is now being implemented in https://chromium-review.googlesource.com/c/chromium/src/+/2391798 Original change's description: > [ios] Add ScreenTime overlay modality > > This is one of a series of CLs to implement ScreenTime. > > This CL: > * Adds a new overlay modality above the web content area for the > ScreenTime blocking view overlay > * Adds and integrates no-op supported overlay coordinator classes. > > Bug: 1123704 > Change-Id: Idee3417df9dee7cd15b8fcc93e4ee6944a5e530e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386535 > Reviewed-by: Chris Lu <thegreenfrog@chromium.org> > Commit-Queue: edchin <edchin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803274} TBR=michaeldo@chromium.org,edchin@chromium.org,thegreenfrog@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1123704 Change-Id: If19b96825b7788cbdaa77b8e505278d049807814 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390839Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804470}
-
Morten Stenshorne authored
Storing a purely physical offset was problematic when in vertical-rl writing-mode, if the viewport size changes. We were storing the X coordinate relative to the left edge of the visible contents inside the scrollport. However, in vertical-rl writing-mode the block-start is at the right side of the scrollport. If the viewport width changed, the distance from the left edge to the anchored element would also change, even though the scroll offset remained exactly the same, and we'd mess up the scroll offset. Bug: 1124195 Change-Id: Id91a25012da2d0cbd803e543b6cb02ba66eb20e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390380Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#804469}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c81f39950ebf..583b1e36f36b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC btolsch@google.com,nicolaso@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917,chromium:1101058 Tbr: btolsch@google.com,nicolaso@google.com Change-Id: I31cc4ea9f57f28de55a11a5a65a1a6bfd339b02f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393052Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804468}
-
James Darpinian authored
The ScopedResultPtr returned by GetResultAs<> needs to go out of scope before CheckGLError can be called, when GL_CLIENT_FAIL_GL_ERRORS is set. Bug: 1120712 Change-Id: I5f5c83ba9deb6cb161e875037a4269b67119ab4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391599Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#804467}
-
David Tseng authored
See go/chromevox-touch-gestures R=akihiroota@chromium.org AX-Relnotes: Adds four finger swipe for ChromeVox to move among on-screen panes (launcher, status tray, web page, etc). Bug: 1124454 Test: browser_tests --gtest_filter=ChromeVox*.SwipeLeftRight* Change-Id: Ie8a98c53d456e3a2e632f4307622494f8f82f3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379458 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#804466}
-
Alexander Timin authored
Ensure that the test launcher can run a test multiple times in parallel to enable us finding flaky tests faster. Also add documentation for --gtest-repeat and --gtest-break-on-failure. R=erikchen@chromium.org BUG=976795 Change-Id: I767a618fda6ad8f7424b43b0bf1a06b5238f127a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667313 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#804465}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5383c636752f..f39c62ab1284 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I30f877fbbaf600dfb46b64a051a9e6c55e840b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392627Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804464}
-
Peter Boström authored
Removes |listener_| from the internal implementation, but still providing set_listener() that wraps a ButtonListener* in a callback. Removal of ButtonListener will be piecemeal as there's about 500 references to it, though I intend to continue until it's gone. Bug: 772945 Change-Id: I9ff386b40a75bee58adba5c4ad9a3304a2c69d4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392436 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#804463}
-
Ankit Kumar 🌪️ authored
Update PDFiumEngine to use gfx::Rect instead of pp::Rect. Update callers to expect gfx::Rect as return value instead of pp::Rect. Noteworthy points: - In pp::Rect, Subtract() is a utility methods which takes in two rects and returns the subtracted rect. Whereas in gfx::Rect, Subtract() is a member method which modifies the rect in-place. All usage of Subtract() which are replaced in the CL modify the rect in-place. - In pp::Rect, Intersect() is a utility method which takes in two rects and returns the intersected rect. The counterpart in gfx::Rect is IntersectRects() and not Intersect(). Bug: 1101101 Change-Id: Ib071e3a987c2c234b8e2348744700f9cf07edc96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379397Reviewed-by:
K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#804462} -
Nate Chapin authored
This reverts commit 590a8d43. Reason for revert: Suspect cause of inspector-protocol/emulation/set-vision-deficiency.js failures: https://test-results.appspot.com/data/layout_results/linux-bfcache-rel/8184/blink_web_tests/layout-test-results/results.html Original change's description: > Set SVGExternalDocumentCache::Entry::document_ eagerly in NotifyFinished() > > Currently, we lazily initialize document the first time it is requested > *and* all of the data is loaded (https://crbug.com/1107442 fixed a case > where we would incorrectly initialize the document by creating it before > all of the data had been received). > > It's much clearer to just initialize the document when all of the data > is received, and have GetDocument() be a simple getter. > > Change-Id: I830dca5cc953ca8467fd936f5c783db21cfce051 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316415 > Commit-Queue: Nate Chapin <japhet@chromium.org> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#804325} TBR=fs@opera.com,japhet@chromium.org,kouhei@chromium.org Change-Id: Ib838f8e42475020ceb83f8aa841d1ad077d705bd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393159Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#804461}
-
Gavin Williams authored
This change adds ellipsis and a tooltip to the print preview destination dropdown for long printer names. http://screen/xgSumv9ZVxHzyEo Bug: 1059607 Change-Id: Ic1bacba02737a873550817e261be70345ead0c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391927Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#804460}
-
Philipp Hancke authored
This bot runs WPT so needs H264 enabled as well. BUG=chromium:840659,chromium:1103214 Change-Id: I9962b9f7618c9db663a8a4f26b539801c74b8c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362795Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#804459}
-
Guohui Deng authored
This CL is generated with export script. Bug: internal b/166313191 Test: None Change-Id: Ib76dd0731824f32ec265234c4e160fefc1195008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392915Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Guohui Deng <guohuideng@chromium.org> Cr-Commit-Position: refs/heads/master@{#804458}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d86bb475521a..66d4faca55b5 2020-09-03 changhaohan@chromium.org Refactor away externally adding property onto imported object If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4e74dd01ed40d7f77ec62a4bd0e45966fcdb829d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393140Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804457}
-
Alexis Hetu authored
Attempting to re-enable all WebGL tests associated with fixed ANGLE issues Bug: chromium:1099961, angleproject:3701, angleproject:2103 Bug: angleproject:2909, angleproject:2722 Bug: angleproject:2915, angleproject:2898, angleproject:3766 Bug: angleproject:2046, angleproject:5014, angleproject:1506 Bug: angleproject:4986, angleproject:5015 Change-Id: I9999eef4f7f15282d0fa8abd3d31de52475a7b65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392980Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#804456}
-
Alexander Surkov authored
Port ax_dump_tree tool on mac: generalize LineIndexesMap to reuse it for native mac accessible trees Bug: 1124366 Change-Id: Id0071572ef54856fee9f6ecd1b5d379fdbb3a079 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391468 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#804455}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I1b8ae11a95b384ad0c086c0fe62a2187338f4ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382073Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#804454}
-
Yuwei Huang authored
This CL makes the Linux host service create a symlink to the latest host log file, so that it can be easier to locate. Bug: 1124862 Change-Id: I5a16d530ba3270e2441154f74d4ba543628343af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393058 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#804453}
-
Mason Freed authored
Change-Id: Ic3127de61280166bef9c1e49c37cd9eee4ddac35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392983 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#804452}
-
Brian Sheedy authored
Adds an OpenXR perf runtime and removes the OpenVR/WMR/Oculus ones since the latter are removed or on their way out and the former is becoming the default. Bug: 1124425 Change-Id: Id2c0a03e3d6ff002ce22afe9c1c7e012ee3f04e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392939 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#804451}
-
Josip Sokcevic authored
code.google.com redirects no longer work. This CL replaces links in /net to source.chromium.org equivalent. This CL was uploaded by git cl split. R=asanka@chromium.org Change-Id: Icc06c35261cc393c093e01a360f3e6fd36bd0f96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392710 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#804450}
-
Mark Pearson authored
Change-Id: Icee73109540baba04e1f77cc92e351a9b94f5032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392940Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#804449}
-
Roger McFarlane authored
This CL plumbs a WAA on flag from the feed response metadata, through the FeedStore and FeedStreamApi and across xsurface. It also moves the point in time where the session info is fetched to ensure the correct info is used when logging. Bug: 1122882, 1122175 Change-Id: I1be7c2fdf9587638187da37346646bc1e9912899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381173 Commit-Queue: Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#804448}
-
Kevin McNee authored
When the user manually zooms, any page fitting (e.g. fit-to-width) is unset and subsequent window resizes do not change zoom. This was not being done for the PDF viewer's internal pinch zoom mechanism. Bug: 1123976 Change-Id: Ifcc2b14fb05b7a339a7463d89f9a00c00739a43a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392700Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#804447}
-
Matt Wolenetz authored
Like the recent rename of MediaSourceAttachmentImpl to SameThreadMediaSourceAttachment [1], this change renames MediaSourceTracerImpl to SameThreadMediaSourceTracer. There is no behavior change. This change makes it more clear that the tracer being renamed here is the same-thread version, since later changes will introduce a cross-thread version. [1] https://crrev.com/803635 BUG=878133 Change-Id: I3cfa000db21ca87fe79bf73ea2d2490c1976df32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390966Reviewed-by:
Will Cassella <cassew@google.com> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#804446}
-
My Nguyen authored
Added based on Finch's action in http://cl/329846664 Bug: b/166523259 Change-Id: I8f3bcba929cf5783b453722e572ddac9e132f26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391037 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#804445}
-
Brandon Wylie authored
Replacing a workaround with a less hacky solution. Bug: 1122212,1012436,1121577 Change-Id: I7d3cb641a695d4c8f4a70b982316f38957941cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386344Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#804444}
-
Xing Liu authored
Currently if the user doesn't dismiss the infobar for scheduled download, and scheduled another download in another tab, the new infobar will show in the previous tab. Also, if the user switches to another tab and come back the tab that has shown the infobar, clicking on the "Change" button will show an error page. This CL fixed these 2 issues. If there is more than one scheduled downloads across multiple tabs during the lifetime of the infobar, "X downloads scheduled" should be shown as the infobar text. Bug: 1123924 Change-Id: Ib952c84ba5d6ad358c2d0b3d55238dc85e9ea313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391585Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#804443}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/75690ce7ef4a..2c5b4455854d 2020-09-03 caramelli.devel@gmail.com Minor change in detachImage() for Xcb, Xlib, Wayland WSIs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic809eae44afe3d92f1370571a755fef5a7d1d0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393044Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804442}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/00b2fdbc3c6f..6763a713f957 2020-09-03 brianosman@google.com Limit morphology radius to 100 pixels 2020-09-03 robertphillips@google.com Create cpu-side blurred RRect mask when recording DDLs (take 2) 2020-09-03 bsalomon@google.com Reland "Add idea of DataType to SkYUVAPixmapInfo." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408,chromium:1123035 Tbr: michaelludwig@google.com Change-Id: I9c3602bd3625c06f45f1d1187daa78c7b11129c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804441}
-
Scott Violet authored
As of https://chromium-review.googlesource.com/c/chromium/src/+/2386320 no longer calls onDialogVisibilityChanged() if there were no dialogs. This means the conditional checking for mTab can now be removed. BUG=1121388 TEST=covered by test Change-Id: I1e82d17360f3623200ecf67686a65288b4305020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392744Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#804440}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5383c636752f..f39c62ab1284 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If4b0183a057b4a95feb03cd062af33facbf829ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392626Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804439}
-
Josip Sokcevic authored
code.google.com redirects no longer work. This CL replaces links in /extensions/common/api/networking_private.idl to source.chromium.org equivalent. This CL was uploaded by git cl split. R=karandeepb@chromium.org Change-Id: I9aef715b8de938baeab22c92480cffb3984490fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392749 Auto-Submit: Josip Sokcevic <sokcevic@google.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#804438}
-
Bruce Dawson authored
This ports the abseil .def file generation to Windows, using dumpbin to get the lists of symbols. It also fixes some glitches such as the Chromium-repo detection, and file-endings on export. It works around one dumpbin bug that will be fixed in some future VS release. The results are not identical to those on Linux but this is a solid step in that direction. Bug: 1046390 Change-Id: I37e7055b9b774e4d923e5572dd00268b0d563c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264493Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#804437}
-
Lei Zhang authored
It is apparently reachable, since ConvertEventTypes() in content/renderer/pepper/event_conversion.cc can create input events of type `PP_INPUTEVENT_TYPE_UNDEFINED` for a variety of reasons, and PPAPI does not always send `PP_INPUTEVENT_TYPE_CONTEXTMENU` events through correctly. Bug: 1124478 Change-Id: Id376f948a78ca9d33ee40e825d7f131a11f61ec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392376Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#804436}
-
Devlin Cronin authored
This file was leftover from a time when there were separate implementations for Mac-Views vs other-platforms-views, which is no longer the case. Move the methods from this file into the main .cc file. Note: Technically, we could also move the header and implementation from c/b/ui/extensions/extension_message_bubble_browsertest.* and collapse everything into c/b/ui/views/extension_message_bubble_view_browsertest; this separation pre-dates Mac-Views, and was designed to share code between c/b/ui/views and c/b/ui/cocoa implementations. However, that's a lot more code churn. Start here. Bug: None Change-Id: I98eca6c92ccfa03a50090558c30ecc84e2652828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392697Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804435}
-
Matt Wolenetz authored
Adds a supplemental interface in modules to extend the core MediaSourceAttachment, so common methods in specialized attachments can be defined without requiring them known by core. This reduces complexity of the core side of the attachment interface. Specifically, adds MediaSourceAttachmentSupplement, with a new method (implemented in concrete SameThreadMediaSourceAttachment) to notify the attached element that the duration of the resource has changed. Later specialization in a cross-thread version of the attachment will need to perform this notification asynchronously. Lifts the Unregister() method and the persistent MediaSource OilPan reference member from the concrete implementation into this common modules attachment supplement's implementation, since these are expected to remain the same across all concrete attachment implementations. Updates SameThreadMediaSourceAttachment to give the MediaSource a thread-safe refcounted scoped_refptr for the attachment during StartAttachingToMediaElement(). MediaSource, like HTMLMediaElement does already, is updated to know both the attachment and the MediaSourceTracer while the attachment is active. Starts using NotifyDurationChanged from the MediaSource object via the attachment instead of directly talking to the attached media element from the MediaSource. Further extensions of this attachment interface will come in later changes for similar scenarios, eventually enabling the dropping of the |attached_element_| member from the MediaSource class, with all interactions on the element eventually done via the attachment. BUG=878133 Change-Id: I86206f740b62f9ba6dc6a1b9fd16a44aff21f49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387121Reviewed-by:
Will Cassella <cassew@google.com> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#804434}
-
Devlin Cronin authored
Currently, there there exist chrome.test.runNextTest() and chrome.test.assertBool(). However, these are implementation details of the chrome.test API, and should not be used directly. Instead of exposing them on the API (which is unnecessary), just have them be normal functions in the custom bindings. Bug: None Change-Id: Ia5fc47fe5b357ac9507aed52c76b132ea582a0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391925Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#804433}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c94650d88fd7..d46db9f1523a 2020-09-03 landrey@webrtc.org Remove unused pc level test MediaHelper constructor 2020-09-03 titovartem@webrtc.org pki.google.com has been deprecated in favor of pki.goog 2020-09-03 landrey@webrtc.org Support simulated time in MediaHelper for pc tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If71f229af736adb817752973d6aa04f3126d5f80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393035 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#804432}
-