- 28 Nov, 2018 40 commits
-
-
Denis Kuznetsov authored
TBR: alemate@chromium.org Bug: 854101 Change-Id: I0119223034d6399dfd6fd50d3fb0e4821c356f65 Reviewed-on: https://chromium-review.googlesource.com/c/1243195 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#611671}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/cf714a81c86e..596d6fe00db7 git log cf714a81c86e..596d6fe00db7 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 cwallez@chromium.org Result: Fix documentation and a typo Created with: gclient setdep -r src/third_party/dawn@596d6fe00db7 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Iefbca39f6f500032f47b95bd5d0e051e887c24a2 Reviewed-on: https://chromium-review.googlesource.com/c/1352501Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611670}
-
Tim Volodine authored
The AwSettingsTest.testCacheMode is now passing due to: https://chromium-review.googlesource.com/c/chromium/src/+/1339720 BUG=893570,841556 TBR=ntfschr@chromium.org,cduvall@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo Change-Id: Icd210dcfaf8d5830f1128834e3ea16d58c179569 Reviewed-on: https://chromium-review.googlesource.com/c/1352786 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#611669}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff43a0af6b51..e9e2ac7b3cbb Created with: gclient setdep -r src-internal@e9e2ac7b3cbb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id63d991882e94ca5b1bf999fa9bafd000f8d7b2e Reviewed-on: https://chromium-review.googlesource.com/c/1352499Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611668}
-
Tim Schumann authored
Examples: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/73206 A similar treatment fixed a problem when interacting with the BrowserAccessibilityComWin object for content/browser/accessibility/browser_accessibility_unittest.cc browser_accessibility_win_unittest.cc is facing problems with accessing invalid memory and also interacting with BrowserAccessibilityComWin -- there's a chance these problems are related. Error message: Received fatal exception EXCEPTION_ACCESS_VIOLATION Backtrace: RtlInitUnicodeString [0x77DEE41B+499] RtlFreeHeap [0x77DEE023+126] free_base [0x737CDCF7+39] calloc_base [0x737CAF0B+2875] free_dbg [0x737CD6DC+124] free [0x737CDCA0+32] uprv_free_63 [0x731F1900+80] icu_63::UnicodeSet::releasePattern [0x732C2067+39] icu_63::UnicodeSet::~UnicodeSet [0x732C2026+230] icu_63::UnicodeSet::`scalar deleting destructor' [0x732C11B5+37] std::default_delete<icu_63::UnicodeSet>::operator() [0x725F76C4+52] std::unique_ptr<icu_63::UnicodeSet,std::default_delete<icu_63::UnicodeSet> >::~unique_ptr<icu_63::UnicodeSet,std::default_delete<icu_63::UnicodeSet> > [0x725F763D+61] base::subtle::NoBarrier_Load [0x725F75EB+59] base::subtle::Acquire_Load [0x725F7593+67] base::i18n::NormalizeFileNameEncoding [0x725F7512+818] base::internal::FunctorTraits<void (__cdecl*)(void *),void>::Invoke<void (__cdecl*const &)(void *),void * const &> [0x71605AD7+55] base::internal::InvokeHelper<0,void>::MakeItSo<void (__cdecl*const &)(void *),void * const &> [0x71605A0A+58] base::internal::Invoker<base::internal::BindState<void (__cdecl*)(void *),void *>,void __cdecl(void)>::RunImpl<void (__cdecl*const &)(void *),std::tuple<void *> const &,0> [0x716059CA+74] base::internal::Invoker<base::internal::BindState<void (__cdecl*)(void *),void *>,void __cdecl(void)>::Run [0x7160587F+63] base::RepeatingCallback<void __cdecl(void)>::Run [0x71601F51+49] base::AtExitManager::ProcessCallbacksNow [0x71601951+337] base::AtExitManager::~AtExitManager [0x716012AB+363] std::default_delete<base::AtExitManager>::operator() [0x050F1AA7+39] std::unique_ptr<base::AtExitManager,std::default_delete<base::AtExitManager> >::~unique_ptr<base::AtExitManager,std::default_delete<base::AtExitManager> > [0x050EF57D+61] base::TestSuite::~TestSuite [0x050EF0AB+91] content::ContentTestSuiteBase::~ContentTestSuiteBase [0x050E339F+15] content::ContentTestSuite::~ContentTestSuite [0x050E337E+46] content::ContentTestSuite::`scalar deleting destructor' [0x050E3535+37] std::default_delete<base::TestSuite>::operator() [0x050E3F14+52] std::unique_ptr<base::TestSuite,std::default_delete<base::TestSuite> >::~unique_ptr<base::TestSuite,std::default_delete<base::TestSuite> > [0x050E3C6D+61] content::UnitTestTestSuite::~UnitTestTestSuite [0x050E3B63+115] main [0x050E2B0D+269] invoke_main [0x0510A6DE+30] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:78) __scrt_common_main_seh [0x0510A841+337] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283) __scrt_common_main [0x0510A90D+13] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:326) mainCRTStartup [0x0510A918+8] (f:\dd\vctools\crt\vcstartup\src\startup\exe_main.cpp:17) BaseThreadInitThunk [0x7783337A+18] RtlInitializeExceptionChain [0x77DF92B2+99] RtlInitializeExceptionChain [0x77DF9285+54] TBR=nektar@chromium.org Bug: 909062 Change-Id: Ic5cb5fc26aed105dfebbffa05be06f822d7d14df Reviewed-on: https://chromium-review.googlesource.com/c/1352130Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#611667}
-
Raphael Kubo da Costa authored
This fixes the build with GCC, which was complaining with error messages such as: ../../third_party/blink/renderer/modules/peerconnection/call_setup_state_tracker_unittest.cc:60:13: error: explicit specialization in non-namespace scope ‘class blink::CallSetupStateTrackerTest’ template <> ^ ../../third_party/blink/renderer/modules/peerconnection/call_setup_state_tracker_unittest.cc:65:13: error: explicit specialization in non-namespace scope ‘class blink::CallSetupStateTrackerTest’ template <> ^ ../../third_party/blink/renderer/modules/peerconnection/call_setup_state_tracker_unittest.cc:66:17: error: ‘blink::AnswererState blink::CallSetupStateTrackerTest::current_state() const’ cannot be overloaded with ‘blink::OffererState blink::CallSetupStateTrackerTest::current_state() const’ AnswererState current_state() const { ^~~~~~~~~~~~~ ../../third_party/blink/renderer/modules/peerconnection/call_setup_state_tracker_unittest.cc:61:16: note: previous declaration ‘blink::OffererState blink::CallSetupStateTrackerTest::current_state() const’ OffererState current_state() const { ^~~~~~~~~~~~~ For current_state(), move the template specializations outside of CallSetupStateTrackerTest. Having them in CallSetupStateTrackerTest officially requires C++17 (specifically, C++ DR727). While clang has implemented DR727 for other -std= options, GCC is stricter and only builds that code in C++17 mode. For NoteStateEvent, drop the template bits altogether: the two NoteStateEvent() functions work as regular overloads and do not need any templates. Bug: 819294 Change-Id: I3f839d9a70670de1f52db14efcbd10b3a199b84e Reviewed-on: https://chromium-review.googlesource.com/c/1352256 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#611666}
-
Vaclav Brozek authored
Cleaning TODO(vabr) in the extensions-related code: * removing obsolete ones, and * redirecting others to a bug Bug: 908813, 218451, 121325, 238179 Change-Id: I47fb081201743473d0fdea23bca2a9f5278fa067 Reviewed-on: https://chromium-review.googlesource.com/c/1352162 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#611665}
-
Henrique Grandinetti authored
Bug: 908158 Change-Id: I178b4660b937a675afa865818645af75b2d50cc3 Reviewed-on: https://chromium-review.googlesource.com/c/1349592Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#611664}
-
David Jean authored
Bug: 908776 Change-Id: I14d17f328ae4ebbf158c03a9628c55f7a97f58e8 Reviewed-on: https://chromium-review.googlesource.com/c/1350928 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#611663}
-
Yuta Kitamura authored
This CL rewrites #include lines of web_task_runner.h, which is now deprecated. Instead of web_task_runner.h, new include lines of post_cancellable_task.h and/or post_cross_thread_task.h are inserted, depending on what's used in each file. This CL only touches #include lines and nothing else. Bug: 826203 Change-Id: I931acf1f18af1bc34f4e13b6914f2a054671f1d2 Reviewed-on: https://chromium-review.googlesource.com/c/1351204Reviewed-by:
-
Gauthier Ambard authored
This CL converts the ViewController, keeping the same features. Bug: 894791 Change-Id: I8cd336a878d42d6a69bed10e3b22c56d842e5c0d Reviewed-on: https://chromium-review.googlesource.com/c/1345974 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#611661}
-
David Jean authored
Also refactor gray line separator into cell utils. Change-Id: Ia47aba4717c30510c06979618640967c87fb8f11 Reviewed-on: https://chromium-review.googlesource.com/c/1350913 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Use the MakeGarbageCollected bottleneck to flag objects as being under construction while their constructor is executed. can be recovered once we are done moving to MakeGarbagecollected by opening the scope in the allocator (HoH ctor). Binary-Size: Increase due to adding scope to constructors. Roughly 50% Bug: 843903 Change-Id: I0a5182481534922ba14c6c12ed7138dadbcadea5 Reviewed-on: https://chromium-review.googlesource.com/c/1350128 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#611659}
-
Antonio Gomes authored
BUG=907515 Change-Id: I62fc67e47f53306f3dfcbbe2e3dc19383551d98b Reviewed-on: https://chromium-review.googlesource.com/c/1348672Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#611658}
-
Sami Kyostila authored
Bug: 891670 Change-Id: Ief7d0b3902c23b6037867e64bf74e7899c53ab1d Reviewed-on: https://chromium-review.googlesource.com/c/1350829 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#611657}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ab168019..80526a9b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4187fc9baf4a616704babac61b75ce810e040ac9 Reviewed-on: https://chromium-review.googlesource.com/c/1352982Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611656}
-
Eric Seckler authored
Adds a new DataSource for the CrOS system tracing agent and enables the corresponding TracingController test on CrOS for perfetto. TBR=oysteine@google.com Bug: 900603 Change-Id: I6652ccedc077f2c036ee5e94b68e725d461e656c Reviewed-on: https://chromium-review.googlesource.com/c/1341835Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#611655}
-
John Lin authored
customization on module-managed URLs. Bug: 882404 Change-Id: I8b25e6d50e6ed93d426d387746e11b1d2970ca6e Reviewed-on: https://chromium-review.googlesource.com/c/1350926 Commit-Queue: John Lin <chuanl@google.com> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#611654}
-
Morten Stenshorne authored
They were just off by a pixel here and there. Nothing wrong. Change-Id: I48246aab41197bd0d9829e4dcf1fca9499ee3b02 Reviewed-on: https://chromium-review.googlesource.com/c/1352318 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#611653}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: If0d7602fffae77622cdb1a87d82fc5dbba1b9afb Reviewed-on: https://chromium-review.googlesource.com/c/1352500Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/047cf0724025..ff43a0af6b51 Created with: gclient setdep -r src-internal@ff43a0af6b51 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia78a73b73720e9efe8961d476e0bcbc2523aa557 Reviewed-on: https://chromium-review.googlesource.com/c/1352994Reviewed-by:
-
Tim Schumann authored
This reverts commit afad6853. Reason for revert: Findit detected this with 87.7% confidence to be the culprit of GeolocationServiceUnitTest.GeolocationConfig flakiness. Bug: 909637 Original change's description: > Move device service to new service APIs > > Migrates device service code and tests from deprecated service APIs to > new ones. Namely this phases out its use of ServiceContext and > ServiceTest in favor of ServiceBinding and plain old unit tests. > > Bug: 891780,906239 > Change-Id: I7677134b5d11e7297b162bbb532dfabb810504d2 > Reviewed-on: https://chromium-review.googlesource.com/c/1345124 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611379} TBR=jam@chromium.org,rockot@google.com,blundell@chromium.org,tsepez@chromium.org Change-Id: I3619eef380d3e46736bf0966359d37e2808d97ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891780, 906239 Reviewed-on: https://chromium-review.googlesource.com/c/1352766Reviewed-by:
-
Keishi Hattori authored
Convert V*, W* class allocations from new to MakeGarbageCollected Bug: 757708 Change-Id: I309a04df5892aa4712e0c68984fe71dbba326eeb Reviewed-on: https://chromium-review.googlesource.com/c/1353055Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fb903439b213..af0c7c5e6e24 git log fb903439b213..af0c7c5e6e24 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 taylori@google.com Merge "Allow wildcard to select all events in a group" Created with: gclient setdep -r src/third_party/perfetto@af0c7c5e6e24 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib9de07cd40c5a55d8940ff0922c3c87870290857 Reviewed-on: https://chromium-review.googlesource.com/c/1352498Reviewed-by:
-
Ross McIlroy authored
BUG=v8:7287,v8:8238,v8:7279,v8:7283 Change-Id: I088ba421cd1613616be2e613136ccebc09a900a2 Reviewed-on: https://chromium-review.googlesource.com/c/1349325 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#611647}
-
Marc Treib authored
It has been replaced by SyncUserSettings::SetFirstSetupComplete. Note that *Profile*SyncService::SetFirstSetupComplete still exists for now (it's used by SyncUserSettings). This will be changed in a later CL. Bug: 884159 Change-Id: I0d7b99863b0bf121ff6bf640b6738f156172c084 Reviewed-on: https://chromium-review.googlesource.com/c/1352773Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#611646}
-
Boris Sazonov authored
This CL changes AndroidSyncSettings static methods to be non-static and adds get() method that returns the instance. These changes are made to allow mocking of AndroidSyncSettings in tests for other classes and to simplify the code inside AndroidSyncSettings. Bug: None Change-Id: I0b5c8f5d9fd77e4fd6abf1d8093dd78af84c4030 Reviewed-on: https://chromium-review.googlesource.com/c/1348111Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#611645}
-
Jan Lamecki authored
This view will be used to render Cast WebContents in android.app.Presentation dialog. Test: None. Bug: internal b/112463440. Change-Id: Idb848ac27233f9c2b2ce4200d216b49ae186f34a Reviewed-on: https://chromium-review.googlesource.com/c/1345070Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Jan Lamecki <jachor@google.com> Cr-Commit-Position: refs/heads/master@{#611644}
-
Andy Paicu authored
https://github.com/w3c/webappsec-csp/issues/322 raises an interop issue It appears the issue itself has been fixed since but I've added these tests regardless to ensure there is no regression. Bug: 694525 Change-Id: Icb5502e228b3a96c176cbe23d5b4ce9c5c8640ab Reviewed-on: https://chromium-review.googlesource.com/c/1348054Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#611643}
-
Mihai Sardarescu authored
This reverts commit b04e513f. Reason for revert: This CL contains changes only for Windows, Linux and macOS (if you look at the main changes in signin_util.{h|cc} file, you'll see they are ifdefed out on ChromeOS. Browser test from the same test suite (WebviewClientCertsLoginTest) failed already at the previous build on the same target: * Build that fails a tests from WebviewClientCertsLoginTest and that does not include my CL: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9853 * Build that fails a test from WebviewClientCertsLoginTest and that includes my CL: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9854 Original change's description: > Revert "Clear managed profile on start-up if having a primary account is not allowed." > > This reverts commit e98161eb. > > Reason for revert: Sheriff suspecting this change is responsible for test failures https://crbug.com/909034 -- if not, please reland apologies for the trouble! > > Original change's description: > > Clear managed profile on start-up if having a primary account is not allowed. > > > > This CL clears the profile when it is loaded is the primary account is no longer > > allowed (e.g. profile was marked as a managed profile or the profile). > > > > As this is a very destructive action (the profile directory is removed from disk), > > the user is presented with a permanent browser modal dialog. > > > > Screenshots for each platform: > > Linux: https://drive.google.com/open?id=1HO693VkDnC0qjPxHJdFZr3CPqOs2Hidf > > Windows: https://drive.google.com/open?id=1gvmvt2wUsA42nmcVWTZCB1F5encHJRRH > > > > Design doc [Google internal only]: > > https://docs.google.com/document/d/1QqWoV1I7WgrzeHJwm9agG56ZqXD_Q2L3LB3K7Ck89GI/edit?usp=sharing > > > > Bug: 907474, 887756 > > > > Change-Id: Ib1187d79a45e0829b57768582c5d11126b0a5c46 > > Reviewed-on: https://chromium-review.googlesource.com/c/1288829 > > Commit-Queue: Mihai Sardarescu <msarda@chromium.org> > > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > > Reviewed-by: David Roger <droger@chromium.org> > > Reviewed-by: Owen Min <zmin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#611135} > > TBR=ellyjones@chromium.org,pastarmovj@chromium.org,droger@chromium.org,msarda@chromium.org,zmin@chromium.org > > Change-Id: I0c1468ce16d832ec57de9c456e1642e054fe9cfa > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 907474, 887756 > Reviewed-on: https://chromium-review.googlesource.com/c/1352646 > Reviewed-by: Ken Rockot <rockot@google.com> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#611432} TBR=ellyjones@chromium.org,pastarmovj@chromium.org,droger@chromium.org,rockot@google.com,msarda@chromium.org,zmin@chromium.org Change-Id: I6da34b30e8c740b48da32cba4be3fcac5e5e6ea0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 907474, 887756 Reviewed-on: https://chromium-review.googlesource.com/c/1352360 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#611642}
-
Gauthier Ambard authored
This CL creates the AutofillEditTableVC, to be the replacement of the LegacyAutofillEditCollectionVC. Bug: 894791 Change-Id: I7dfff03765db8c856e52b226905ae4555bde89b4 Reviewed-on: https://chromium-review.googlesource.com/c/1345973 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
Revert "NetworkService: add instrumentation for OnStartLoadingResponseBody crash." This reverts commit 2ba89415. Revert "NetworkService: more instrumentation for OnStartLoadingResponseBody crash" This reverts commit 4f3d5b77. Revert "Add instrumentation to debug a crash in ThrottlingUrlLoader." This reverts commit 709b126d. Bug: 882661 Change-Id: Ic320e60fb84a5008bf18a106476c006bf06ada5a Reviewed-on: https://chromium-review.googlesource.com/c/1350567Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#611640}
-
Tobias Sargeant authored
Existing timeouts for input event ack (5s) and navigation commit (30s) trigger a renderer unresponsive signal that causes the Chrome notification to trigger. This CL connects the current signal to AwContentsClient, in preparation for exposing as a WebView callback. Bug: 907887 Change-Id: I3af8e8b9e6b7f991c951aba73e4c1a1e3af95a67 Reviewed-on: https://chromium-review.googlesource.com/c/1348093 Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#611639}
-
Andy Paicu authored
Added a test for behavior around srcdoc iframes CSP inheritance. This tests the current specified behavior of always inheriting the parent CSP for srcdoc iframes. Bug: 694525 Change-Id: I049ef8c5a9e75c052dc2767ea2d523f54cca497f Reviewed-on: https://chromium-review.googlesource.com/c/1350889Reviewed-by:
-
Douglas Stockwell authored
R=dsinclair@chromium.org, hnakashima@chromium.org Bug: 902646 Change-Id: I896f190feeacededc97355d575b8dc3c26b03879 Reviewed-on: https://chromium-review.googlesource.com/c/1329808Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#611637}
-
Vaclav Brozek authored
This CL replaces <owner> entries for vabr@ with relevant people, to keep the records up to date after vabr@'s departure. The CL also removes gcasto@ from all touched histograms. gcasto@ has not been working on Chromium's password manager for some years now. Similarly, the CL removes yfriedman@ (because yfriedman@ is more active on Chromium, vabr@ checked with yfriedman@ that this removal is OK). The CL does not add new owners to obsolete histograms. Bug: 908813 Change-Id: Ifddb086ab567ec6e7ba2bab39f592715210c9d91 Reviewed-on: https://chromium-review.googlesource.com/c/1352176Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich Horschig [CET] <fhorschig@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
Mohamed Amir Yosef authored
This CL changes Cryptographer::DecryptToString() to return a boolean instead of an empty string to signal failure/success. Change-Id: I12f1f65a177a23648a83d522900fa5c99f60ff4c Reviewed-on: https://chromium-review.googlesource.com/c/1350617 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#611635}
-
Attila Uygun authored
Bug: 908472 Change-Id: I2d67e946f46a83b930a22ace762cb064e73bb8fb Reviewed-on: https://chromium-review.googlesource.com/c/1350894Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Attila Uygun <auygun@opera.com> Cr-Commit-Position: refs/heads/master@{#611634}
-
Christian Dullweber authored
To simplify fixing Clear-Site-Data, I move some of the code that was duplicated for the network_service into a shared location. Bug: 898465 Change-Id: I25eac82e7a6f3481b03ac88946a1e7a6828cbfc9 Reviewed-on: https://chromium-review.googlesource.com/c/1350971 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#611633}
-
Javier Ernesto Flores Robles authored
Sets the background color to white. Changes the preffered height to 360. Bug: 878388, 845472 Change-Id: If4ff0363808af7c373e4f70d9d664196867fdbb6 Reviewed-on: https://chromium-review.googlesource.com/c/1350967Reviewed-by:
Yi Su <mrsuyi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#611632}
-
