- 30 Aug, 2019 40 commits
-
-
Xida Chen authored
We have kFrameSequenceTrackerTypeNames defined in the compositor_frame_reporter.cc and kBuiltinSequences defined in the frame_sequence_tracker.cc, where these two essential represents the same thing. This is problematic, that when we add an entry in one place, the other place must be adding that entry too. This CL defines kFrameSequenceTrackerTypeNames as static in the CompositorFrameReporter class and then FrameSequenceTracker can just use it. No behavior change should be introduced. Bug: None Change-Id: I0dc9e40be82d147615e1aa61afb1a7d8750390e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774831 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#692053}
-
Igor authored
When the device is disabled, we receive from the server RESTORE_MODE_DISABLED mode. The client has no information if the policy forces to re-enroll or not. In the initial implementation it was treated as device not being forced to re-enroll. This change fixes that case, so that the flags from VPD don't get deleted for disabled device. Also with a test image, the install_attributes file is deleted while the checksum remain on disk. This has yet to be investigated, but to avoid any problems when install_attributes file is corrupted, we set the device as being in DEVICE_MODE_ENTERPRISE if auto_enrollment detects the device is disabled. BUG=chromium:996059 TEST=Manual tests and unit tests Change-Id: I8bc30028af043fdb563e6374d7e5db4b30830218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771966Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#692052}
-
Takuto Ikuta authored
Largest file is 11MB in xcode_binaries cipd package, so I think copying these files fine. symlinks point to cipd cache do not work correctly on swarming. This fixes that by using copy. Bug: 988079 Change-Id: I00861c59d637d5931fbf6aa0f7b169b1e80ebe7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777846 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#692051}
-
Huanzhong Huang authored
Follow-up to crrev.com/c/1685382; naming adjustment on cookie controls. Bug: 967668 Change-Id: I34b65d59764d489e390d6dffbe5042a07b20a4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777867 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Commit-Queue: Florian Uunk <feuunk@chromium.org> Reviewed-by:
Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/heads/master@{#692050}
-
Stephen McGruer authored
This is a reland of 6caf7e08. The original patch had a nullptr crash when the Settings was null - this version fixes that. Original change's description: > Hook up animations to ValidationMessageOverlayDelegate > > ValidationMessageOverlayDelegate hosts an internal blink::Page > which is not properly integrated into the normal BeginMainFrame > flow. As such, it needs to be manually prodded in various places. > Integration already existed for layout and paint - this CL adds > animations as well. > > This previously worked because blink::AnimationClock would advance > its own time (against the spec), and so the internal Page would see > advancing time and the animation would keep ticking. When we fixed > blink::AnimationClock to be by the spec, we also broke this. > > This CL also makes sure that the animation used by > ValidationMessageOverlayDelegate is not composited; the internal Page > has no compositor so composited animations will not work. > > Bug: 990680 > Change-Id: I16aaddbfa57eaefadfb557fc9cb435d94672e637 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763162 > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691673} Bug: 990680, 999333 Change-Id: I16c9138b63eefe0b32e66ebc562ffa836181b07c TBR=flackr@chromium.org,pdr@chromium.org Change-Id: I16c9138b63eefe0b32e66ebc562ffa836181b07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777109Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#692049}
-
Sebastien Marchand authored
Bug: 998546 Change-Id: Ibad528d47add2430955af8142aa1372fee5d0648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774792Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#692048}
-
Ilya Bizyaev authored
Implement Ansible playbook generation for APT package management in the Crostini container. The code is not wired up with preferences or policies at this point and accepts strings of JSON input. This code will be used in a handler for an experimental enterprise policy on Chrome OS. Bug: 993321 Change-Id: Ifb07f787a1daf6b2829a8cce73e30b990e25116e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751253 Commit-Queue: Ilya Bizyaev <ilyabiz@google.com> Reviewed-by:
Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#692047}
-
Julie Jeongeun Kim authored
This CL replaces |client_binding_| with |client_receiver_| from WebSocketHandleImpl to use new Mojo types. Bug: 955171, 978694 Change-Id: I3a60e4c4a60b8edb769f006d92f2339ffe32101b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777341Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#692046}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f24c9f2dff49..4c470eee0063 Created with: gclient setdep -r src-internal@4c470eee0063 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If10fc6e3e49fbea8a52320309034dfea0a1ec010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778263Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692045}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/321c5840..66a74a65 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I663a4067e4b7cb5daf39459dfca0ca221e837cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778002Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692044}
-
Philip Rogers authored
In the following example, we do not need to composite the first transform: <div id="first" style="transform: translate(10px, 10px); width: 100px; height: 100px;"> <div id="second" style="will-change: transform; width: 50px; height: 50px;"></div> </div> Pre-BlinkGenPropertyTrees, this was required to ensure a composited cc::TransformNode existed, but this can now happen without a composited cc::Layer. This should reduce memory: On the top 10k pages, 2% of GPU tile memory is due to layers with the kTransformWithCompositedDescendants compositing reason. This was determined using a metrics collection patch on cluster telemetry: https://docs.google.com/spreadsheets/d/1cCFRHDG9Uu0dbGETmHcjM-QI2nMZe8_lfA8Mgm7H23I/edit#gid=2004092469 Bug: 989251 Change-Id: I2b111eb2fe5cdbbfe073846f4e1271fb454bd887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696112Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#692043}
-
Javier Ernesto Flores Robles authored
On iOS 13 the keyboard hierarchy was updated. Composing a layout guide makes it transparent to the current while staying compatible with iOS 12. Bug: 996669 Change-Id: I480c9955f911731ac4a30acc83519c9de03ecfdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765669 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#692042}
-
David Maunder authored
This is a generic component for making GET and POST requests and supports authentication. Error reporting is not included which will be added in a separate patch. Bug: 985015 Change-Id: I42f4ee93c680be26e9bbe388ba52808c915532d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706874 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#692041}
-
Robbie Gibson authored
The root cause here for both tests is that the iPhone SE is short. Using the new modal presentation style on iOS 13 (maybe CL crrev.com/c/1719455), the view the tests are looking for, "First URL" is hidden below the keyboard. Switching to tap on "French URL", a bookmark that is earlier in the list and still on screen, fixes the tests. Bug: 999079, 999080 Change-Id: I78ae1360c264283413aa98cd6b5b50960aa9b9f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776264Reviewed-by:
-
Mark Cogan authored
This CL adds regression tests for some of the PDF snapshot bugs fixed in prior CLs (see http://crbug/981893). Specifically tests are added for: - Switching back and forth quickly between a complex PDF and a regular tab. - Switching back and forth quickly between two PDF tabs. - Opening a PDF and then entering the tab grid and waiting ~5 seconds. A known-crashing PDF (from www.irs.gov) is added to the test data for these tests. Since there's no good single component that "owns" these tests, this CL creates a ui/integration_tests directory. Since this test needs a way to locate the toolbar for swiping to change tabs, this CL adds a utility matcher for that. TEST=I verified that the crashes fixed before could be retriggered by at least one of these tests. The root cause of the crash was that WebKit was calling snapshotting callbacks more than once, and the implementation of the callback was a OnceCallback. The fix was to change this to a RepeatingCallback. I verified that these tests would have found this regression by CHECKing the second time the callback was called. Bug: 993395 Change-Id: Iea130d4ed82017096ad3420161fb59a224d128d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768707 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#692039}
-
sebsg authored
This reverts commit 8caebe30. Reason for revert: WebUsbTest.AddRemoveDevice fails pretty consistently after this CL was landed. See https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/28669 other builds: 28670-28671-28672-... Original change's description: > Convert UsbDeviceManagerClient to new Mojo types > > This CL converts UsbDeviceManagerClient{AssociatedPtr, AssociatedPtrInfo} > in chrome, components, extensions and services to the new Mojo types, > and uses pending_associated_remote<device.mojom.UsbDeviceManagerClient> > in usb_manager.mojom and web_usb_service.mojom.mojom. > > Bug: 955171, 978694 > Change-Id: Ic64f0e43ef60cb184a35b5bf6391a7fb3bc38dd8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772837 > Commit-Queue: Miyoung Shin <myid.shin@igalia.com> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691951} TBR=kinuko@chromium.org,thestig@chromium.org,rockot@google.com,hidehiko@chromium.org,myid.shin@igalia.com Change-Id: I3b7939240adbcb8cede49dcb30ad9e7a6ddc89b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 955171, 978694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778185Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#692038}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d10eb04b772a..e69fbd1b2db5 git log d10eb04b772a..e69fbd1b2db5 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 perezju@chromium.org [Telemetry] Provide --experimental-proto-trace-format command line flag Created with: gclient setdep -r src/third_party/catapult@e69fbd1b2db5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:990304 Change-Id: I732cf6092a17948aeec2d93d904f94e8fdb4cf79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778261Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692037}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7409b73fa546..575699569e91 git log 7409b73fa546..575699569e91 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 brianosman@google.com Update sample particle data in canvaskit demo Created with: gclient setdep -r src/third_party/skia@575699569e91 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: I251e8793c50c9d68f246a5dcc07bceac46711f6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778201Reviewed-by:
-
Vladislav Kuzkokov authored
This reverts commit cae62756. Reason for revert: Breaks build with target_os="chromeos" FAILED: libmedia_gpu.so libmedia_gpu.so.TOC python "../../build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --sofile="./libmedia_gpu.so" --tocfile="./libmedia_gpu.so.TOC" --output="./libmedia_gpu.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,-soname="libmedia_gpu.so" -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--color-diagnostics -m64 -Werror -Wl,--gdb-index -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath=\$ORIGIN -Wl,-rpath=\$ORIGIN -o "./libmedia_gpu.so" @"./libmedia_gpu.so.rsp" ld.lld: error: undefined symbol: media::VideoDecoderPipeline::Create(scoped_refptr<base::SequencedTaskRunner>, std::__Cr::unique_ptr<media::DmabufVideoFramePool, std::__Cr::default_delete<media::DmabufVideoFramePool> >, std::__Cr::unique_ptr<media::VideoFrameConverter, std::__Cr::default_delete<media::VideoFrameConverter> >) >>> referenced by chromeos_video_decoder_factory.cc:54 (../../media/gpu/chromeos/chromeos_video_decoder_factory.cc:54) >>> obj/media/gpu/chromeos/chromeos/chromeos_video_decoder_factory.o:(media::ChromeosVideoDecoderFactory::Create(scoped_refptr<base::SequencedTaskRunner>, std::__Cr::unique_ptr<media::DmabufVideoFramePool, std::__Cr::default_delete<media::DmabufVideoFramePool> >, std::__Cr::unique_ptr<media::VideoFrameConverter, std::__Cr::default_delete<media::VideoFrameConverter> >)) clang: error: linker command failed with exit code 1 (use -v to see invocation) Original change's description: > media/gpu: make VideoDecoderPipeline select VD implementation during Initialize(). > > Some devices select the video decoder implementation by the video > configuration (e.g. codec). VideoDecoderPipeline needs to select a > proper video decoder in Initialize() when a video configuration is > specified. > > This CL implements the mechanism of selecting VD at Initialize() > instead of Create() method. > > BUG=chromium:952730 > TEST=Run video_decode_accelerator_tests on Kevin and Eve > > Change-Id: I76077df0bc1e1eeae730e618a62c6e1049e02500 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708693 > Reviewed-by: David Staessens <dstaessens@chromium.org> > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691946} TBR=deanliao@chromium.org,akahuang@chromium.org,hiroh@chromium.org,acourbot@chromium.org,dstaessens@chromium.org Change-Id: I2edea554734a766fce1d61943297547159c8cbeb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:952730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778048Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Vladislav Kuzkokov <vkuzkokov@chromium.org> Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Cr-Commit-Position: refs/heads/master@{#692035}
-
Fredrik Söderquist authored
This reverts commit d030e251. Reason for revert: Tickled ClusterFuzz Original change's description: > Remove SVGUseElement::target_element_instance_ > > This reference should always be the same as the first child of the > shadow root. Since we don't make heavy use of it though - and it > shouldn't be too slow to access via the ShadowRoot, just get rid of it > to have less state to keep up-to-date. > > Bug: 997176 > Change-Id: I798bbc7ac64934d5eda1250b32150b50b4d2acdb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771960 > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Fredrik Söderquist <fs@opera.com> > Cr-Commit-Position: refs/heads/master@{#691722} TBR=pdr@chromium.org,fs@opera.com Change-Id: Ia7c4b5fde76e97a50e6c670622029750672ca0f0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 997176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777927Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#692034}
-
Roman Sorokin authored
Bug: 954572 Change-Id: Ic682f73b52a24c1acb0e40df200e0724160d2e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774447Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#692033}
-
sebsg authored
This reverts commit f5a9a694. Reason for revert: Findit Identified this as the culprit for consistent failures on Linux ChromiumOS MSan Tests. See https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/14900 as an example: Consistent failures: browser_tests failed because of: LocalNTPCustomBackgroundsThemeTest.CustomBackgroundOverridesThemeAttribution InfoBarsTest.TestInfoBarsCloseOnNewTheme ExtensionInstallUIBrowserTest.TestThemeInstallUndoResetsToPreviousTheme InstantThemeTest.ThemeChangedWhenApplyingNewTheme ...1 more failure(s) (5 total)... non_viz_browser_tests failed because of: LocalNTPCustomBackgroundsThemeTest.CustomBackgroundOverridesThemeAttribution InfoBarsTest.TestInfoBarsCloseOnNewTheme ExtensionInstallUIBrowserTest.TestThemeInstallUndoResetsToPreviousTheme InstantThemeTest.ThemeChangedWhenApplyingNewTheme ...1 more failure(s) (5 total)... content_browsertests failed because of: RenderFrameHostImplBrowserTest.VisibilityScrolledOutOfView Original change's description: > [Cleanup] Move complex color calc out of searchbox_extension.. > > In this CL the logo and shortcut color calculation is split into 2 parts. > The color calculation based on the theme is moved to themes, and > defaults are moved to ThemeProperties. > The logo and shortcut colors can be overridden when custom background is > set. This logic is moved to instant_service. > > NTP text and logo_alternate logic is also moved out of > searchbox_extension. > > Bug: 983717 > Change-Id: I12b938ba8a833bd920cf224171163781889989a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759150 > Reviewed-by: Oliver Chang <ochang@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Commit-Queue: Gayane Petrosyan <gayane@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691869} TBR=pkasting@chromium.org,estade@chromium.org,gayane@chromium.org,ochang@chromium.org Change-Id: I9759af11051eec26d2423acc5c3b88311d309a04 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 983717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778184Reviewed-by:
-
Maksim Ivanov authored
Replace strings hardcoded into the HTML code with the proper i18n calls. Bug: 964069 Change-Id: If9b4de625a52fa32f7bc9c243e376b92fcc7bc1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750162Reviewed-by:
-
Roman Sorokin authored
Failing in ASSERT_TRUE in setup functions does not stop tests. Bug: 995784 Change-Id: I165b3844b8aabeda4c238c722c610913c0c80574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771410 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
redatawfik authored
1- Create a new protocol "CreditCardScannedImageDelegate" which receives an image from Credit Card camera scanner. 2- Create a mediator "CreditCardScannerMediator" which conforms to "CreditCardScannedImageDelegate". 3- Implement "processOutputSampleBuffer" method in the mediator such that it takes an image and process it using text recognition in Vision API. 4- Create helper methods in "CreditCardScannerMediator" to parse text output and extract card number an expiration month and year from it. Bug: 984545 Change-Id: Ib76da1cb0edb0e0fa09b12b4c02ed95a83c53e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760926Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Reda Tawfik <redatawfik@google.com> Cr-Commit-Position: refs/heads/master@{#692029}
-
Andrew Grieve authored
Noticed my test stack wasn't symbolizing when I ran the script with PWD=$SRC/out/Debug Turns out the stack script calls os.chdir() at some point, so need to save --output-directory as an absolute path. Also updated other paths passed as flags to use abspath(). Change-Id: I91fe857fa1af5c94b2783b0f4083f4d4ef927e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776611 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#692028}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aa94b48e0166..f24c9f2dff49 Created with: gclient setdep -r src-internal@f24c9f2dff49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ib70751ec1ff0f12ece916f343ffa45ae0f949cb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777985Reviewed-by:
-
Hirokazu Honda authored
VideoFrameFileWriter cannot save frames in ALLOCATE mode because the video frame cannot be mapped. This CL fixes the failure in FlushAtEndOfStream_Allocate with --output_frames option. Bug: None Test: video_decode_accelerator_tests with --output_frames Change-Id: I9ea023c182d010fa65621c428c6291912ffd6db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777844 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#692026}
-
Hirokazu Honda authored
This CL introduces an option, --save_images, to save processed images in ImageProcessor test. The usage documentation of image_processor_test will also be shown with --help. This CL enables VideoFrameFileWriter to save memory based VideoFrame, not only DmaBuf-backed VideoFrame. Bug: 917951 Test: image_processor_tests --save_images on atlas Change-Id: I4b4d87bb564873fac0f1a0f51f3a4296a2d9bb1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774011 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Skip making the closePinDialog() JavaScript call when the state says that no JavaScript calls are allowed. This may happen inside the GaiaScreenHandler destructor if the security token PIN dialog is active. Before this CL, the implementation was trying to close the active PIN dialog, which was causing a crash. Part of the example stack trace: base::debug::CollectStackTrace() base::debug::StackTrace::StackTrace() base::debug::(anonymous namespace)::StackDumpSignalHandler() <unknown> gsignal abort std::__terminate() __cxxabiv1::failed_throw() __cxa_throw std::__Cr::__throw_length_error() std::__Cr::__vector_base_common<>::__throw_length_error() std::__Cr::vector<>::__emplace_back_slow_path<>() chromeos::BaseWebUIHandler::CallJS<>() chromeos::GaiaScreenHandler::CloseSecurityTokenPinDialog() chromeos::PinDialogManager::CloseActiveDialog() chromeos::PinDialogManager::RemovePinDialogHost() chromeos::GaiaScreenHandler::~GaiaScreenHandler() chromeos::GaiaScreenHandler::~GaiaScreenHandler() content::WebUIImpl::~WebUIImpl() content::WebUIImpl::~WebUIImpl() content::RenderFrameHostManager::ClearWebUIInstances() content::WebContentsImpl::~WebContentsImpl() content::WebContentsImpl::~WebContentsImpl() views::WebView::SetWebContents() views::WebView::~WebView() views::View::~View() chromeos::OobeWebDialogView::~OobeWebDialogView() views::View::DoRemoveChildView() views::View::RemoveAllChildViews() views::Widget::~Widget() views::(anonymous namespace)::BubbleWidget::~BubbleWidget() Bug: 964069 Test: enroll a "target_os=chromeos" build, configure device policies to force-install smart card middleware onto Login Screen, start logging in using a SAML account that uses smart card authentication, wait until PIN dialog appears, close Chrome by clicking "x", check that there was no crash Change-Id: I3f2f927830d71209c61c7e4b66250d16bb1039ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750003 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.IDBDatabase interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: Ifb57fede8ff8e4a97d863c067a068bcb27bccf32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774280 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#692023}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/71acc9d6..321c5840 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2c2d2b700e91fdae4ba036c7cd16f638b3471e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778001Reviewed-by:
-
Dominic Farolino authored
This CL introduces a flag specifically for NetworkIsolationKey changes made to cross-origin main-resource prefetches. We'd like to implement these changes incrementally and not have them enabled implicitly under the SplitCacheByNetworkIsolationKey flag. A future CL will actually put this flag to use, and remove more instances of the SplitCache feature detection. R=kinuko@chromium.org, yhirano@chromium.org Bug: 939317 Change-Id: Ifd465d343b76e6533fffed46cfae1d2486fb078f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775890 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#692021}
-
Mohamed Abdelhalim authored
Remove the manual reset of navigation_handle in NavigationRequest's destructor. Bug: 916537 Change-Id: Iddab8818f172ae1d0679e8e68619895f4ed861d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776057Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Mohamed Abdelhalim <zetamoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#692020}
-
Jan Wilken Dörrie authored
This change makes the TouchToFillController a member variable of the ChromePasswordManagerClient and updates affected code accordingly. Bug: 957532 Change-Id: Ia5aff08a0fb2cf85d4fb30c1e42abcbd4e3230c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737326Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#692019}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.IDBDatabaseCallbacks interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I7bb92e5f5dc5894e33b3fa63edbf893a52c2af61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768589 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
Clemens Arbesser authored
Bug: 806868 Change-Id: I7d39618f9a51680f9de3b747192f93cc4667de08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776035 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#692017}
-
Nico Weber authored
Also mark minimizing a repro case as optional and move it later in the process. Bug: none Change-Id: I23213e22c6635f8f48dae5a9cda85b068005c2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776859 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#692016}
-
Benoît Lizé authored
Anonymous memory can be tagged (on OS X) or named (on Android). Add tags and names for BlinkGC and PartitionAlloc, to ease memory investigations and debugging. Example output on Android, by looking at /proc/[PID]/smaps: 34c02000-34c04000 ---p 00000000 00:00 0 [anon:partition_alloc] Name: [anon:partition_alloc] Size: 8 kB KernelPageSize: 4 kB MMUPageSize: 4 kB Rss: 0 kB Pss: 0 kB Shared_Clean: 0 kB Shared_Dirty: 0 kB Private_Clean: 0 kB Private_Dirty: 0 kB Referenced: 0 kB Anonymous: 0 kB AnonHugePages: 0 kB Swap: 0 kB SwapPss: 0 kB Locked: 0 kB VmFlags: mr mw me ac 34c04000-34dfc000 rw-p 00000000 00:00 0 [anon:partition_alloc] Name: [anon:partition_alloc] Size: 2016 kB KernelPageSize: 4 kB MMUPageSize: 4 kB Rss: 984 kB Pss: 984 kB Shared_Clean: 0 kB Shared_Dirty: 0 kB Private_Clean: 0 kB Private_Dirty: 984 kB Referenced: 980 kB Anonymous: 984 kB AnonHugePages: 0 kB Swap: 0 kB SwapPss: 0 kB Locked: 0 kB VmFlags: rd wr mr mw me ac Bug: 998048 Change-Id: I82b5ccdf5979fec920043aa62169607625aa7dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774286 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#692015}
-
Mario Sanchez Prada authored
Convert both the implementation and clients in the browser and renderer processes for the blink.mojom.IDBCursor interface, and adapt unit tests. Bug: 955171, 978694 Change-Id: I80027402a0bce5dcf568cbbcb4229385cd9d6ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768471 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
-
