- 10 Mar, 2020 40 commits
-
-
Marijn Kruisselbrink authored
In preparation of making these features origin trial controlled, switch to the version of RuntimeEnabledFeatures::FooEnabled calls that accepts a FeatureContext. Bug: 853326 Change-Id: Ie73d4ee810887068b397ed8fa642b73cac98b83f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095401Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#748966}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aee432d7489e..76a104eafd23 Created with: gclient setdep -r src-internal@76a104eafd23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586,chromium:1059369 Tbr: jbudorick@google.com Change-Id: I7ff9e4401d6708fe405483f2412bea3a0c34a523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097317Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748965}
-
Mugdha Lakhani authored
Rename method in BrowserImpl to clarify it's used for tests. Change-Id: I39a2e07333b64540547f0fc164b5dc59788f973d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096583 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#748964}
-
rbpotter authored
Bug: 1026426 Change-Id: Iba4a5b0d69ec72df44c05ba20f6553d75fd7b3f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090883 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#748963}
-
Bettina authored
Bug: 996380 Change-Id: I02739a9c29c50a30c53ff6a156262447403fd9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090625 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#748962}
-
tby authored
We've added jiameng@ as OWNER of many of the search files individually, it might make sense at this point to add her as the ONWER for the whole directory. WDYT? Change-Id: Ie5b3b21961cf4736de6ecd3fe0a8051b0622ddbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089554Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#748961}
-
Nate Fischer authored
This moves the developer-mode check earlier in startup. This has the advantage that we can modify the CommandLine before starting finch work, so the flags UI can support finch flags. Bug: 1059131 Test: Manual - verify browser process sees finch flag updates Change-Id: I8dac1a878f87247a655effd8f43bc5d074eb9878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092953 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#748960}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 82-4044.31-1583749230-benchmark-82.0.4079.0-r1 to 82-4044.31-1583749230-benchmark-82.0.4081.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I94806e58c37ada5c8c14e6408e8a590cbe556078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097334Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#748959}
-
Charles Zhao authored
The logging only happens when: (1) On ChromeOS, (2) TabManagerDelegate::LowMemoryKillImpl is called, (3) process_type >= PROTECTED_BACKGROUND, (4) With maximum 50 tabs as cap. Ranking is not enabled. Bug: 1055664 Change-Id: I607f43b02decb124959b9e4ada0c8d608722d785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071338 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#748958}
-
Nate Fischer authored
This updates the flag UI to show blue dots for non-default features. Per Android best practices, this uses a "compound drawable" (a drawable attached to a TextView). This reuses the same shade of blue as chrome://flags. Bug: 1041600 Test: Manual - toggle flags, restart activity, reset to default, do all Test: of the above in light/dark theme (works as intended) Change-Id: Ie3a61ecd8859488964caa1da9e20bd79756d9c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096118 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#748957}
-
chromium-autoroll authored
Roll silvermont AFDO profile from 82-4072.0-1583746630-benchmark-82.0.4079.0-r1 to 82-4072.0-1583746630-benchmark-82.0.4081.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I38a558de35e2410a71130c8a03d96f161d936aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097455Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4f10b113a191..9e263aa8a4e6 git log 4f10b113a191..9e263aa8a4e6 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 rafael.cintron@microsoft.com Enable allowClearForRobustResourceInit for NVidia hardware Created with: gclient setdep -r src/third_party/angle@9e263aa8a4e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jmadill@google.com Change-Id: Ia67cfd061a56becda14629ec150504d500f93956 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096847Reviewed-by:
-
Sammie Quon authored
Tried to consolidate this with the ChromeOS logic, but it doesn't seem possible at the moment, since they have different APIs and they don't handle back events the same way. Test: manual Bug: 1056939 Change-Id: I91b5dcff620e9bcbaf96d42071724ee807afea34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095612 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#748954}
-
Mila Green authored
Bug: 1059024 Change-Id: I185a9cc7ea40658187da9e145191d28155808720 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091942 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#748953}
-
Noel Gordon authored
Define i18n string "More sub-folders...", and use it as the aria-label of the breadcrumb elider button. Tbr: Lucino Bug: 1035691 Change-Id: Iedcd9e65b56268108f81f40d3430c32475dded5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096324Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#748952}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7cdf69dbbf43..ab98a3792093 git log 7cdf69dbbf43..ab98a3792093 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 Rob.Paveza@microsoft.com Fix for flaky tests: Node re-selection Created with: gclient setdep -r src/third_party/devtools-frontend/src@ab98a3792093 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044425,chromium:1046784 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I111801fea85f1c46114e1b88f3cfa0104e392592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097154Reviewed-by:
-
Alexander Timin authored
We are considering returning nullptr for WebContents::FromRenderFrameHost is the RenderFrameHost is not the current one. This patch adds a behind-the-flag option to start generating crash dumps to allow us to find the places which need to be fixed before that. R=alexmos@chromium.org BUG=1059903 Change-Id: Iaca4f30dfef1d6b6e03194a990bebf3e1649b39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093228Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748950}
-
Josh Nohle authored
RemoteDeviceProvider: Add metrics to measure rough adoption rate of v2 DeviceSync while v1 and v2 DeviceSync are running in parallel. We track the total number of v1 vs. v2 devices as well as the ratio of v2 to v1 devices. We track what percentage of v2 devices already have a decrypted user public key as well as what percentage of v1 devices are replaced by their v2 counterparts that have the same public key. HostVerifier: We track how often a host cannot be verified because it is missing the crypto data needed for secure communication via Bluetooth. This can happen when v2 DeviceSync is enabled, v1 DeviceSync is disabled, and the device metadata has not been decrypted yet. Bug: 951969 Change-Id: I9a44b67bda5cd3dbedee28b106624ab4f1905a8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095934Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#748949}
-
Avi Drissman authored
The _sendItemSelectedNote hack was introduced in 335d78a0 to make menu selection more responsive. 24ab401b was committed not long thereafter which added running in an alternate run loop mode. With that change, this hack was no longer needed, so remove it. This reverts the part of 335d78a0 that deals with the menu controller. Bug: 1047839 Change-Id: I03450759f69a0303566bbbfa03c7ec3ab76a141e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097055 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#748948}
-
Kyle Milka authored
Add user actions for the STTS info flow and for horizontal scrolling on both rows of the sharing hub. Also add a histogram to record the index of the third party apps used from the bottom row. Bug: 1009124 Change-Id: I2f03b9fd2f8d2fa3911ba57702fdefb9e950a3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080571 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dd14a955967b..8332950f4a88 git log dd14a955967b..8332950f4a88 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 29afd4ae..4fa1454b (748637:748775) Created with: gclient setdep -r src/third_party/webrtc@8332950f4a88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1ab3b3ccd8dd14669b4c0716656586d6ba18e47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097319Reviewed-by:
-
Sam Bowen authored
" * Add a validator that removes properties that are not the right type. * Add double, time, and timedelta types in the document metadata mojo structure. * Use the new mojo types in document metadata extractor. " This is a reland of https://crrev.com/c/2062907 which was reverted in https://crrev.com/c/2095670. The substantial changes are two-fold: (1) add build dep on base in schema_org_properties. This should fix the try bot issue which was somehow skipped. (2) Rebase on top of https://crrev.com/c/2073337 which was submitted and contains some changes to the mojo structure. Change-Id: I7f47d74e8833f76d4077028eac0dcb43790a1d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097059Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#748945}
-
David Grogan authored
Relative position offsets are still done in legacy, so we need to teach it about FlexNG's implementation of flexbox's definiteness exceptions. Bug: 845235, 1060346 Change-Id: I3dfc1400efdef1d9601ec0d8762f17d8a9ad64dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093273 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#748944}
-
Bettina authored
SoftwareReporter.ExperimentErrors is logged when software_reporter_tool fails. However, the naming of this metric is confusing as it does not relate to an experiment. It should refer to configuration of the manifest. Bug: 1055870 Fixes: 1055870 Change-Id: I57097d2896a8ac1ab4749c86c230cd9d39df8142 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090595 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
-
Nate Fischer authored
No change to logic. This adds the following minor UX improvements: * Removes duplicate dividers (one horizontal divider is already built into the default Spinner theme), so we have a 1dp divider between flags. * Add back the top-most divider (above the first flag) at the bottom of the header. This is now anchored beneath the "reset" button, rather than to the top of the first flag. * Increases vertical padding and margin for the Spinner. This makes it a bigger tap-able target. Fixed: 1059480 Test: Manual - verify Spinner has more space and is easier to tap Change-Id: I9e492b43c9a1b2c1bc82dbc45b735b7c62c32e9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095923Reviewed-by:
-
Reilly Grant authored
This change enables by default the new WinRT sensors API backend and removes the histograms which were added to measure the impact of this change. They are no longer necessary as the experiment is over. Bug: 1053125, 1019783 Change-Id: I0a1b148f5a1c3de59f132d384020509dc6465f54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091220Reviewed-by:
Jun Cai <juncai@chromium.org> Reviewed-by:
-
Alex Newcomer authored
This histogram continues to be useful to our team, so bump it by a year. Bug: 1052901 Change-Id: Ib5f079b44e000f6c24f385caf9763f9608e15aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085602Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#748940}
-
Jinsuk Kim authored
This CL removes logic/class that handles following obsolete histograms: Tabs.FirstSwitchedToForegroundCreation*Rank: expires after M77 Tab.BackgroundLoadStatus: expires after M77 Tabs.StateTransfer.Time*: expires after 2017-05-08 Tab.SwitchedToForegroundMRURank: expires after 2014-04-14 Bug: 925242 Change-Id: Ic605626cfe375d1a83938f1e3d1a9cc3b4b26d89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094848Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#748939}
-
Kai Ninomiya authored
Previously reviewed on: https://chromium-review.googlesource.com/c/chromium/src/+/2050036 Change-Id: I4dac360647610047b04024ef8cb6c2a12d8f164e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097297Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#748938}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I39b3c02528195d497e76c80e375838aca18e848e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097322Reviewed-by:
-
Rayan Kanso authored
Bug: 1057381 Change-Id: I6e35e6991a96d452c41b9e5eee945948bf630ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093221Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#748936}
-
Henrique Ferreiro authored
ui::Cursor is a superset of content::CursorInfo. Delete the latter and replace all of its uses with the former. Bug: 1040499 Change-Id: I559d463551f616743a25bc4687b12c1d92041b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999201 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#748935}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 78 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-09-06. Change-Id: Idee8bde9832388acf36da0314ac1ddaf8676dc71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093534Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#748934}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/82e00fd235e4..ccdbaf215f0c git log 82e00fd235e4..ccdbaf215f0c --date=short --first-parent --format='%ad %ae %s' 2020-03-10 treehugger-gerrit@google.com Merge "processor: Support TrackEvent counters in importer" Created with: gclient setdep -r src/third_party/perfetto@ccdbaf215f0c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I81b779e74fb6c3deb535052ddc48aa1b6644c1a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097150Reviewed-by:
-
Kent Tamura authored
<select multiple> dispatched unnecessary 'change' event if a user changed nothing on a chooser dialog. This CL fixes it. HTMLSelectElement::SelectMultipleOptionsByPopup() used UpdateSelectedState() to update selection state and prepare for 'change' event. However, it didn't work well mainly because SaveLastSelection() doesn't support menulist <select multiple>. This CL fixes this bug by not using UpdateSelectedState(). SelectMultipleOptionsByPopup() updates selection state and dispatches 'change' event by its own logic. * Add SetDelegatesMenuListRenderingForTesting() to LayoutTheme for ease of testing. This CL affect only Android, but the test is workable on all platforms. Bug: 1060039 Change-Id: I7c9c5ee9bb51ec4aa7b2da21329c9a8d4c0778da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096064 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#748932}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8be72df60462..16ae92a4ee52 git log 8be72df60462..16ae92a4ee52 --date=short --first-parent --format='%ad %ae %s' 2020-03-10 amaiorano@google.com Subzero: fix Call on bool-returning functions Created with: gclient setdep -r src/third_party/swiftshader@16ae92a4ee52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I888c166120b1be6f291d31360a4af09da2e1c732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097141Reviewed-by:
-
Charlie Hu authored
This CL migrates following features from feature policy to document policy: - unoptimized-lossless-images - unoptimized-lossless-images-strict - unoptimized-lossy-images - oversized-images Following tests are being migrated to document policy: - feature-policy-unoptimized-lossless-images - feature-policy-unoptimized-lossless-images-strict - feature-policy-unoptimized-lossy-images - feature-policy-image-policies-with-border-radius - feature-policy-unoptimized-images-cached-image - unoptimized-lossy-images-reporting - unoptimized-lossy-images-reporting-onload - feature-policy-oversized-images - feature-policy-oversized-images-edge-cases - feature-policy-oversized-images-forced-layout - feature-policy-oversized-images-responsive-image - feature-policy-oversized-images-styles - feature-policy-oversized-images-resize - oversizsed-images-reporting Changed the test content of feature-policy-image-policies-with-border-radius. As legacy-image-formats is removed, The bmp image is not expected to be blocked. Previously ekaramad@ removed allow=”legacy-image-formats” in the test but did not update the expected png file in CL( https://chromium-review.googlesource.com/c/chromium/src/+/1548869). Also removed flaky expectations on test feature-policy-image-policies-with-border-radius. Following web tests are removed: - external/wpt/feature-policy/parameters/ Bug: 993790 Change-Id: I10e5c4a646efcfab1cdc757c012ae35e75a42241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058702 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#748930}
-
Marijn Kruisselbrink authored
Also update runtime_features to turn on the new writable streams API when the Native File System specific feature flag is enabled. Bug: 853326 Change-Id: I2c66a6917a9d1cec6074f08aa1c2ef12170d133b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095409Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#748929}
-
behdad authored
BeginMainFrameStartToCommitDuration metric is removed as it is already reported as part of compositor latency metrics (CompositorLatency.SendBeginMainFrameToCommit). Bug: chromium:1050611 Change-Id: I2a5b0b1cacbefe7ced59b7779084c3877467f9c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096110 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#748928}
-
Mason Freed authored
These counters were added in [1], and data was gathered. It turns out that about 7% of all visible radio buttons and 11% of all visible checkboxes are "non-square" - their width != height. With the existing code, these are rendered square, using min(width,height). But the point is that if we relaxed this constraint, 7-11% of page loads would change - a huge web compat problem. Now that data gathering is complete, I'm removing these counters. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1967426 Change-Id: I6f2334d04a2dcd62b71ce428cd2d13c16b5e59c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088334 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
