- 23 Oct, 2018 31 commits
-
-
Xi Cheng authored
This is a reland of b011ab56 In the original change, NotificationImageRetainerTest.CleanupFilesFromPrevSessions and NotificationImageRetainerTest.RegisterTemporaryImage failed on Win and Win64 trunk official.desktop.continuous builders. The root cause is that for some reason, chrome::DIR_USER_DATA used in the test alternated between the chrome-bot directory (i.e., C:/Users/chrome-bot/AppData...) and the full directory (i.e., C:/Users/CHROME~1/AppData). From the test results, they clearly referred to the same file, so the code is working fine in production. However, the mismatch of the two strings failed the string comparison in the tests. This CL attempted to fix it. Original change's description: > Upgrade image file management for Win 10 native notification > > This CL makes the following changes: > 1) Change to run image folder cleanup after Chrome startup using a background > task, rather than running it at Chrome shutdown using a high priority task. > 2) Retain the image folder to avoid deleting and creating it repeatedly. > 3) Remove <subdir> from the full path for the temp file, which is unnecessary. > 4) Delete the temp files in batch. > > These changes have the following benefits: > 1) Fix the issue of Chrome shutdown being blocked by image file IO for some users > as in the current implementation. > 2) Save some disk IO related to the sub-directories in the image folder and the > image folder itself. > 3) Avoid creating a deletion task for each file, otherwise the overhead can be > large when there is a steady stream of notifications coming rapidly. > > Bug: 888276 > Change-Id: I214680aa00bd7f19e84e207e82ada553583a094b > Reviewed-on: https://chromium-review.googlesource.com/c/1260498 > Commit-Queue: Xi Cheng <chengx@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Greg Thompson <grt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601227} TBR=isherman@chromium.org, grt@chromium.org, finnur@chromium.org Bug: 888276, 897352 Change-Id: I9b1bde98be8545f8634473e7540b0a2a3bee7172 Reviewed-on: https://chromium-review.googlesource.com/c/1292894Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#601819}
-
Guohui Deng authored
1. Fix the following problem: When Stopped, CastAudioOutputStream would crash stopping the |io_thread_|, which is also unecessary. 2. Make the unit tests of CastAudioOutputStream and CastAudioManager only test CMABackend implementation of CastAudioOutputStream because they are not ready to test the newer MixerService implementation. Bug: internal b/29571387 Test: 1. Play a lasting sin wave audio on two devices, to make sure the AudioOutputStream plays fine whether or not MixerService is used. 2. Run cast_media_unittests on estelle and all the tests passed. 3. Run internal CQ and the CQ including cast_media_unittests passed. Change-Id: I380991235344348af56293ae214fb8c0e2be80b0 Reviewed-on: https://chromium-review.googlesource.com/c/1294190 Commit-Queue: Guohui Deng <guohuideng@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#601818}
-
Andrey Kosyakov authored
This is network service-only. Bug: 896924 Change-Id: I240d743089735c5a647112fb83c13081b55bd64b Reviewed-on: https://chromium-review.googlesource.com/c/1289962 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#601817}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8241b8e3. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26581 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: If08282d45c0947e9d5d6741856e8000cf3ca504f Reviewed-on: https://chromium-review.googlesource.com/c/1295175 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#601816}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d1868688a387..b4a228b2788a Created with: gclient setdep -r src-internal@b4a228b2788a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8fa506bef62b01e77e3d7ab8c90214416615ff1a Reviewed-on: https://chromium-review.googlesource.com/c/1295409Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601815}
-
Lei Zhang authored
- Initialize members in the header. - Move static members / functions into an anonymous namespace. - Make a const char* array const. Change-Id: Iba2de156748c7618908b08031dca10f5c8ab1fdc Reviewed-on: https://chromium-review.googlesource.com/c/1294846 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#601814}
-
Eric Karl authored
We appear to frequently time-out the GPU channel when the appliction backgrounds (or is already backgrounded) during an attempt to establish a GPU channel. This change causes timeouts to be surpressed while the application is backgrounded Bug: 897272 Change-Id: I3bc6307f737b0847d54525071ea946ce4a92b38c Reviewed-on: https://chromium-review.googlesource.com/c/1292519Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#601813}
-
Timothy Loh authored
This CL adds a details pane in the file manager's .deb install dialog to provide package name, version, and a description of the package. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I43833f2ce83645ea45d6c9a30f7bd3acd89a9cb4 Reviewed-on: https://chromium-review.googlesource.com/c/1167005Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#601812}
-
David Tseng authored
Update the documentation to run brltty on linux as well. This is sometimes hard to [re]discover. Change-Id: Ia6cfefa2af9465762fc31c8077fec7310edca083 Reviewed-on: https://chromium-review.googlesource.com/c/1294512Reviewed-by:
-
Nick Harper authored
TBR=bnc@chromium.org Change-Id: Ie198ab8247aa95cd1a3ead64d79bb94d66a853a0 Reviewed-on: https://chromium-review.googlesource.com/c/1295313Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#601810}
-
Evan Stade authored
This makes ShelfLayoutManager::UpdateVisibilityState correctly update state to SHELF_AUTO_HIDE, which triggers Shelf::AutoHideEventHandler, which already works without updates. Bug: 897968 Change-Id: Id2e5f785dbf24a0999088b13fe4971ee6758e32e Reviewed-on: https://chromium-review.googlesource.com/c/1295176Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#601809}
-
Bret Sepulveda authored
TabStripModel::IsNewTabAtEndOfTabStrip is called during a tab navigation and is intended to prevent the opener relationship of that tab from being forgotten if it returns true. However, GetURL was changed to return the visible URL (i.e. the one being loaded) instead of the last committed URL, so this would always fail. Also updates the associated test, which was not doing a navigation. Bug: 896929 Change-Id: I3f00e3f6f84da2986bab96b85aeb5eb04ef3cb21 Reviewed-on: https://chromium-review.googlesource.com/c/1292003 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
-
Alexei Filippov authored
Do not use Number.p.toLocaleString as it recreates the formatter on every invocation. Change-Id: I5b98ed61e448ca867a1d5317ffc50e0066760b50 Reviewed-on: https://chromium-review.googlesource.com/c/1295311Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#601807}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/36623f65c39c..20f804166944 git log 36623f65c39c..20f804166944 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 tsepez@chromium.org Remove third arg to CFX_DIBitmap::LoadChannel() 2018-10-22 tsepez@chromium.org Consolidate app_*.in tests into app_methods.in Created with: gclient setdep -r src/third_party/pdfium@20f804166944 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I91bc803db8b443ecbaa45a723a99631ddf3d419e Reviewed-on: https://chromium-review.googlesource.com/c/1295289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601806}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d0dc9924c431..98eda2822c18 git log d0dc9924c431..98eda2822c18 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 yshaul@google.com chromeos_config: Move EnsureVmTests config methods to config_test 2018-10-22 yshaul@google.com chromeos_config: Move vmtest_boards to chromeos_config_test 2018-10-22 yshaul@google.com chromeos_config: Move board definitions to separate file. 2018-10-22 dgarrett@google.com chromeos_config: Re-add nocturne/grunt firmwarebranch configs. 2018-10-22 dgarrett@google.com chromeos_config: Sign accessory_rwsig in firmwarebranch. Created with: gclient setdep -r src/third_party/chromite@98eda2822c18 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic16b1f0556dda38e42db9ec27a3eac606acc42be Reviewed-on: https://chromium-review.googlesource.com/c/1295290Reviewed-by:
-
Matt Mueller authored
Bug: 887095 Change-Id: I5556c05c6d8444ffb0a6ebec2ef46396e857fed4 Reviewed-on: https://chromium-review.googlesource.com/c/1286862 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#601804}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/201596f004c8..39feabe35c51 git log 201596f004c8..39feabe35c51 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 benwright@webrtc.org Enables FrameDecryptor to do an initial key request on frame decryption. Created with: gclient setdep -r src/third_party/webrtc@39feabe35c51 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ieb6a99a5728ec7ae7fbbfeee4d1210990b24323f Reviewed-on: https://chromium-review.googlesource.com/c/1295032Reviewed-by:
-
Risan authored
Currently, ArcDownloadsWatcher is used to watch only Downloads directory in ChromeOS and triggers MediaScanner.scanFile when important file changes events happen (for example, file creation, deletion, etc). In exact same way, we want to watch changes under removable media. This CL generalize ArcDownloadsWatcher to watch both paths. BUG=b:69078137 TEST=existing unit test and manually observe logs during runtime Change-Id: I9adce1964eb6b23c2e83ead8462b7a1d8985ae4a Reviewed-on: https://chromium-review.googlesource.com/c/1288160 Commit-Queue: Risan <risan@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Reviewed-by:
-
rbpotter authored
Bug: 896748 Change-Id: I246e47b5791964dde5d7aa926c1c45c40541db03 Reviewed-on: https://chromium-review.googlesource.com/c/1294716 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#601801}
-
Ken Rockot authored
MockWidgetInputHandler destruction may in some cases spin a RunLoop, which in turn may allow certain Mojo objects to do work that (unsafely) modifies the state of that same MockWidgetInputHandler. To prevent this from happening, this CL explicitly closes the handler's Binding before proceeding with the rest of the handler's destruction. Bug: 872063 Change-Id: I9c40455ac0182fbc435a0c2edfcf707aa18c94c8 Reviewed-on: https://chromium-review.googlesource.com/c/1294712Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#601800}
-
Kevin Marshall authored
Finishes the switch from using hand-rolled SDK target definitions to using targets automatically generated from SDK metadata files. A slightly oddball Vulkan copy rule remains intact. * Remove the old targets from fuchsia_sdk/BUILD.gn * Switch existing dependents of fuchsia_sdk:* targets to use fuchsia_sdk/sdk:* instead. * Some "gn format" fixups. TBR=jam@chromium.org Bug: 888753 Change-Id: I3aa9e6aa68cebae343609fc85c9a1c7d0ed1c7aa Reviewed-on: https://chromium-review.googlesource.com/c/1292570Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#601799}
-
Scott Violet authored
It's flaky, but only on ChromeOS, and only with single-process-mash. BUG=897879 TEST=test only change TBR=yigu@chromium.org Change-Id: I26d5e39edc67c16d1334a2279d7f93796746143a Reviewed-on: https://chromium-review.googlesource.com/c/1295188Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601798}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8e270567..20f55e63 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0a53febcde9b02bdc06bb3cc5eaded2b16dfae46 Reviewed-on: https://chromium-review.googlesource.com/c/1294848Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601797}
-
Lei Zhang authored
BUG=897920 Change-Id: I6ff877d4059874e5066baa902aa682401050cabb Reviewed-on: https://chromium-review.googlesource.com/c/1294842 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Bret Sepulveda authored
Disables NavigationRaceFromCrossProcessRenderer and EmbedWithInitialCrossOriginFrame. They are flaky on Windows 7 debug. TBR=ekaramad@chromium.org Bug: 897971 Change-Id: I3616355526307d4420c4176a0b77d17ffac7705e Reviewed-on: https://chromium-review.googlesource.com/c/1295184Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#601795}
-
Erik Luo authored
CompilerScriptMapping assumes that attaching sourcemaps get added to `_contentScriptsBindings` or `_regularBindings`. Blackboxed sources were skipped, for some reason, so detaching would throw an error. In bad cases, navigations will detach sourcemaps, throw errors, and prevent Console from clearing. Bug: 888688 Change-Id: I2c460271a868eca9a6d67371d9097cc552f20b56 Reviewed-on: https://chromium-review.googlesource.com/c/1295310Reviewed-by:
-
Zach Helfinstein authored
Improves the clarity of the codebase, as the AutomationManager's primary responsibility is to handle navigation around the page. Bug: None Change-Id: I897cbab60abdd081a6cb687476c57ff294f9e127 Reviewed-on: https://chromium-review.googlesource.com/c/1294516Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#601793}
-
Joey Arhar authored
Bug: 895081 Change-Id: I49c6131e1cc432e470e4b04353282d3ebebcb063 Reviewed-on: https://chromium-review.googlesource.com/c/1286758Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#601792}
-
Scott Chen authored
Replacing placeholder strings, and move all the add-string calls to under one function. also fixes a path bug for apps/ -> google_apps/ introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1285210 Bug: 874122 Change-Id: Ibd7940c6de71e3a3befc1c5342f6f6097e37de6e Reviewed-on: https://chromium-review.googlesource.com/c/1285325 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#601791}
-
rbpotter authored
Check the internals of the duplex capability, instead of only checking for its existence, to determine whether to display the duplex checkbox. Pull default value from the printer if it is available. Currently a speculative fix, as have not been able to identify a printer which sets the duplex capability field but does not actually support duplex. Bug: 896244 Change-Id: Iebafc3878a1e7658b821465439ee172c479ce413 Reviewed-on: https://chromium-review.googlesource.com/c/1290145 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
Frank Liberato authored
To try to reduce time to first frame regressions, this CL makes D3D11VideoDecoder fall back to VDAVideoDecoder via FallbacKVideoDecoder. This prevents a round trip or two between the GPU and renderer processes. Bug: 832917 Change-Id: I2b3df44805fd950328beb6db88590718550630d1 Reviewed-on: https://chromium-review.googlesource.com/c/1294810 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#601789}
-
- 22 Oct, 2018 9 commits
-
-
Sean Topping authored
Merge-With: eureka-internal/209868 Bug: internal b/117985053 Test: CQ Change-Id: Id10498c6fea52563a8afefc37e6ddd48c1c1bd18 Reviewed-on: https://chromium-review.googlesource.com/c/1292109 Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#601788}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b145370ba063..0339f0866c5f git log b145370ba063..0339f0866c5f --date=short --no-merges --format='%ad %ae %s' 2018-10-22 cbruni@chromium.org [tracing] Do not skip over entries when importing histograms Created with: gclient setdep -r src/third_party/catapult@0339f0866c5f The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:897372 TBR=sullivan@chromium.org Change-Id: I74635f52def221f71e6d35462bd405ddc3ca25dc Reviewed-on: https://chromium-review.googlesource.com/c/1295031Reviewed-by:
-
Mike Wasserman authored
Avoid clearing the text/search on escape key release only. (eg. when a context menu closes, consuming the press event) Bug: NONE Test: KSV search not cleared pressing escape to close a context menu. Change-Id: Iaee63b9e31bf371ec3d95fd9ef4b688c0254b697 Reviewed-on: https://chromium-review.googlesource.com/c/1295171Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#601786}
-
Nico Weber authored
Both bots are red; this improves things a bit (but likely not completely, I only looked at a handful recent builds each). Bug: 897969,897970,330262 Change-Id: I2c399774175e57285eafc1c0de99a6f893e62fea Reviewed-on: https://chromium-review.googlesource.com/c/1295270Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601785}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/099769d5218b..d1868688a387 Created with: gclient setdep -r src-internal@d1868688a387 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ida99e8d2ece7ccbe863dfb15400e06fc3bcf60c2 Reviewed-on: https://chromium-review.googlesource.com/c/1295030Reviewed-by:
-
Aidan Wolter authored
CAOS used to fetch the first 1s of data as quickly as possible and send it to the audio decoder. This was causing the AudioRendererAlgorithm to be unable to fill the entire buffer and AudioRendererMixerInput to fill in the remaining section of the buffer with silence. The user-facing experience is the first second of audio after a resume/seek/skip could have dropouts. To fix this, we remove this rapid-fetch logic, and fetch all data at the same rate specified by the audio_params. Bug: b/116860605 Test: pause/wait for CAOS close/resume 30+ times without reproducing. Change-Id: I00e479f5413d9c737d55839ce5017498a096ffae Reviewed-on: https://chromium-review.googlesource.com/c/1295229Reviewed-by:
-
Victor Vasiliev authored
I am not sure why those were not caught by the presubmit, but I suspect that it's due to code being in net/third_party. R=rch@chromium.org Change-Id: I525e777487d7e376aaa40d956305e5d1a8374bf3 Reviewed-on: https://chromium-review.googlesource.com/c/1294869Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#601782}
-
chrome://net-internals#importchrome://net-export/Eric Roman authored
Bug: 897268 Change-Id: Ic77f0d71d3dccc71b12173aef9cbf567c258036b Reviewed-on: https://chromium-review.googlesource.com/c/1295110Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#601781}
-
Majid Valipour authored
Add two different metrics: - Duration of mutate in dispatcher. This represents the main per-frame cost that is experienced by animation worklet clients. - Duration of mutate in globalscope. This is the main per-frame cost for each global scope. Bug: 780528 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icb7a369534bd0bd8e0e2b9e2cddc5e632eaf50df Reviewed-on: https://chromium-review.googlesource.com/c/951922 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#601780}
-
