- 11 Jan, 2021 40 commits
-
-
Simon Zünd authored
As part of the "First Party Sets" privacy effort, cookies get a new boolean attribute 'SameParty'. The attribute works similarly as 'SameSite' and allows cookies to be sent in same-party, cross-site contexts. This CL adds the attribute to the DevTools protocol, so it can be shown in the various Cookie tables in the DevTools frontend. R=caseq@chromium.org Bug: chromium:1161427 Change-Id: Ica094fcc3acc38e8fb36cada40c198c41ca82262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598846Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#841959}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Icaa1864026b0c7fe0bec6e207f8ea50c34b66056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620841Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841958}
-
Nazerke authored
This CL guards [self.tabStripView screenshotForAnimation] by checking if the flag is disabled. The problem is that in TabStripCoordinator's -view, the coordinator's view controller is cast to UIView<TabStripContaining>. However, the view does not actually conform to this protocol, so calling the protocol method leads to an does not respond to selector issue. This guard will stop the crashes with no current implementation of taking the snapshot. Bug: 1158298,1128249 Change-Id: Ia939e565451f3e705989c0dc0769ba038f45f922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612846 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#841957}
-
Ramin Halavati authored
Two cases are updated for signin intercept to Guest mode: 1- When Guest mode is disabled by policy, this will not be offered. 2- If user opens a Guest profile whie signin intercept is showing, and chooses to go to Guest mode, this will be done. Bug: 1157764 Change-Id: I4116b2c32125a76d893911eebe1c2c31b2284231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620559Reviewed-by:David Roger <droger@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#841956}
-
Shik Chen authored
This CL fixes a regression after we adapt responsive layout. We have |pointer-events: none| on preview-box so we have to re-enable pointer events on barcode chip container. This does not caught by the Tast test because we "click()" the link directly which ignores the pointer-events settings. Bug: b/172879638 Test: Manually Change-Id: I0a7a1a3a755ff1d37a7e7f3f25229a0c97ced16a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619445 Auto-Submit: Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#841955}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/: - drop_effect_and_label.js - empty_folder_controller.js In //ui/file_manager/file_manager/foreground/js/ui/: - empty_folder.js - files_alert_dialog.js Bug: 1133186 Change-Id: I140cc96d9721eb37747216546a5f59fc442342e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620920Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#841954}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a7548393d370..f6c68d018a06 2021-01-11 reed@google.com Cleanup in pictureshader If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: Ie944d47baa19ee09a033da7b214f480bbe61b577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620617Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841953}
-
Jason Lin authored
Bug: b/167491603 Change-Id: If8b20895d281721fb35918ee943e5fadc83e5cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620818 Commit-Queue: Jason Lin <lxj@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Jason Lin <lxj@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#841952}
-
Gabriel Campana authored
Change-Id: I46f18b99c93b6b267a2055d6f0b2d15453438275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613967Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#841951}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4367.0-1609757097-benchmark-89.0.4383.0-r1 to 89-4367.0-1609757097-benchmark-89.0.4384.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I4423fdb7bfbc5867f95078d76dfd0f65fdb5f357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620513Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I0518bf5a5fc3e6c8c599f9afe479fc4cecf82db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620615Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/39974fe062b2..53c34d99574c 2021-01-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: If3bf2cb5dbcd0da138df75a6e37c1985fe342aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620613Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ae0631b5a5df..bca58b67b633 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shimazu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shimazu@google.com Change-Id: I4cc8e2737d9d278df1eeb3d8a5c7cb2282c50316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620508Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841947}
-
Yuheng Huang authored
metrics Bug: 1099917 Change-Id: Ic79d19cd576f97223d01021d1af5d3e0a2579c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612112Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#841946}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610322555-5bf68684dcbb68e2975c9261e4388c601cdf4faa.profdata to chrome-linux-master-1610338418-506ef60e799a83be30c02d3485d0519970a70817.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I598366769c032a4f4a0bf5dd2e5817706f7e4ddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620516Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: If0c112a065fe1c5d197b1a093ce47f819eb2fd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620880Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f3b585e8edf5..84c7d11419c5 2021-01-11 pdfium-autoroll@skia-public.iam.gserviceaccount.com Roll Catapult from 0991ca17bab3 to e174329bab15 (28 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I1962da1514b8b96be3cf1477c89b03ee5ca38aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620506Reviewed-by:
-
Jérémie Boulic authored
directorytree.FILES_NG_ENABLED removed, as it should always be true. As per CL description of https://chromium-review.googlesource.com/c/chromium/src/+/1927431, directorytree.rightIconSetPrefix can now always be set to 'files20'. Bug: 1102263 Change-Id: I0e9a96198444b2136b1aee4db859c7b307f5d9f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620738 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Shik Chen authored
The animation is based on the suggestion from the UX designer. Bug: b/172879638 Test: Manually Change-Id: Iee1dac17d9edac6e6317988c6679025b0c3abf41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619246 Commit-Queue: Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#841941}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610322555-5bda1313c81735158c242e62672a43655918de7e.profdata to chrome-win32-master-1610333688-2ac90a21c191bd1ea4698597daab8949225692c9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia719552aac25c2514f23d5bbc92fca03def0d4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620616Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5d60a181..f8b83eaf Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib419199b65f894db97998cd8e33f8adfc309953c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620523Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841939}
-
Ricky Liang authored
In case a metadata is returned with valid tag but no data, count the metadata entry as invalid. Bug: 1155255 Test: compile and manually verify that camera works on DUT Change-Id: I663ba5cdab177d95c83a77546c70ffd9122157f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620741 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
-
Matt Giuca authored
This test has different expectations depending on whether the DesktopPWAsElidedExtensionsMenu feature is enabled. Previously, the test would fail if that feature was enabled. Bug: 1155421 Change-Id: I0ea5b20db2d7731066541cfdab244a6c06aa7fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620743Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#841937}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4367.0-1609764762-benchmark-89.0.4383.0-r1 to 89-4367.0-1609764762-benchmark-89.0.4384.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I51a2054985970da7413178e7e74b7edb6c3ffff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620514Reviewed-by:
-
Shik Chen authored
CSS variable does not work for animation-timing-function in @keyframes (https://crbug.com/1066798). This CL splits the show/hide banner animation into two animations with different timing function. Bug: 1162044 Test: Manually Change-Id: I15a95b927ca60abb283791e2a2b94cb21b2e3783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612357 Auto-Submit: Shik Chen <shik@chromium.org> Reviewed-by:
-
Clark DuVall authored
This was causing a diff when enabling WebLayer in a split for WebView. Bug: 1105096 Change-Id: I064cb23bb8630af26ed7692191182ebad335e16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617053Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#841934}
-
Clark DuVall authored
This reverts commit 49b7dc5e. Reason for revert: This didn't fix the crash, so might as well revert. Better crash fix coming soon... Original change's description: > Disable vr preload to test crash fix > > It looks like we are getting some crashes on VrModule.getImpl() even in > versions where we use SplitCompatAppComponentFactory. I suspect this is > due to the vr preload, so disabling to see if it stops crashes. If this > works, I'll see if there's anything we can do to prevent crashing with > the preload. > > Bug: 1142589 > Change-Id: I7de6c48edbb9d0a37ee271bff49295912b549d53 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611847 > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#840329} TBR=agrieve@chromium.org,cduvall@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1142589 Change-Id: I6f5f0144b74183ef57d942e5219acbd00e076c82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620938Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#841933}
-
Wei Lee authored
So that it will report error at compile time when we forget to request the lock before accessing the variables. Bug: b/176461326 Test: Build successfully Change-Id: Iac8404fc609ec7a6b2e86bbbdb3e71662e71aa69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602966 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#841932}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e174329bab15..12607ec3c98d 2021-01-11 abennetts@google.com chromeperf: Add sample_values to bq_rows export. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: wenbinzhang@google.com Change-Id: I632a478eefb4beeb063cdc3f4827a27177625cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620507Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610322555-a70eefc496d1545b17a80d3dbb05e5ee869d1bda.profdata to chrome-win64-master-1610333688-1f5858297e8ef0a67e2af96364fce2691e142dbc.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8498b147e2990114e00e6fd292167398ab0486aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620881Reviewed-by:
-
Wei Lee authored
Bug: b/176455103 Test: Manually Change-Id: Ibd8a82441ff9288e59550f690cbbf882eb98b6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620742 Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I50ffbdcd4cf2033edb487e7d274dd9cfb486234e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619682Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841928}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610311594-320b29fe5375389a75bd4c89bfa97b0cd33c2b26.profdata to chrome-win64-master-1610322555-a70eefc496d1545b17a80d3dbb05e5ee869d1bda.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4fbac0b9118075637fc6ba052d730e38eaca0014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620589Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2199cde1f52b..a7548393d370 2021-01-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: I580c37461fcf283247080b34b89fd64c18fee07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620663Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I413bb8e919d348eb3e561f8f723d30bbfe0808fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620644Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841925}
-
Wenbin Zhang authored
This reverts commit aa20f9b8. Reason for revert: Mac builders on perf waterfall are failing after this CL: https://ci.chromium.org/p/chrome/builders/ci/mac-builder-perf Original change's description: > Cache Mac channel information > > Soon, with TargetChannel, an instance of Chrome on the disk > might be upgraded to an instance of Chrome of a different > channel. Cache the channel information on startup, so that > even if it's changed, the channel information of the current > running instance is available. > > Fixed: 1163159 > Change-Id: Ie9ffd98325a0da335778206709f94ea5591e9af0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618041 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841840} TBR=avi@chromium.org,mark@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib6095e36b6c9964693607cfeba5b06e3acd1c42f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620609Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#841924}
-
Joey Arhar authored
The number I used when I just added this use counter, 3745, was already being used by another usecounter that got deleted. You can see that it shows the old name on chromestatus as well: https://chromestatus.com/metrics/feature/timeline/popularity/3745 Bug: 1161163 Change-Id: I341b8727cdfea79539e2cc3448a8ec7076490ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618999 Auto-Submit: Joey Arhar <jarhar@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#841923}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610311594-efd75f7a3a70e07e3e92029af80c214e50282c24.profdata to chrome-win32-master-1610322555-5bda1313c81735158c242e62672a43655918de7e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iff88c90dfb40005712f9f289c6bd6dba4a1a024c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620662Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/42082f9045e7..952be209246a 2021-01-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 256cb7a3..e9fe5946 (841800:841903) 2021-01-10 alessiob@webrtc.org RNN VAD: add missing CPU features to test FC and GRU layers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If941ce05129f776a55632aedf514c5b24cab5d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620587Reviewed-by:
-
Wanming Lin authored
Currently SetTimeout(..., 0) is clamped up to 1ms while which is not supposed to be in the spec. The Speedometer2 performance can boost ~1% on Windows without it based on Pinpoint perf. This CL is intended to fix the DevicePage test that become flaky with https://chromium-review.googlesource.com/c/chromium/src/+/2578703 Flaky test: OSSettingsDevicePageTest.KeyboardTest Fixing it by invoking additional 'flushTasks()' after 'MockInteractions.pressAndReleaseKeyOn' to make sure the 'onKeyUp_()' event in https://source.chromium.org/chromium/chromium/src/+/master:ui/webui/resources/cr_elements/cr_slider/cr_slider.js;l=319 be triggered in time. Bug: 402694 Change-Id: I2bb9c2a3a52861d2d2f3aaf0eff1a5267bc97671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613715Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Wanming Lin <wanming.lin@intel.com> Cr-Commit-Position: refs/heads/master@{#841920}
-
