GitLab

https://pdfium.googlesource.com/pdfium.git/+log/03fdf3a2b5ee..7e7e0b8379c4


git log 03fdf3a2b5ee..7e7e0b8379c4 --date=short --no-merges --format='%ad %ae %s'
2018-08-22 hnakashima@chromium.org Change in/out params in CBC_PDF417Writer::Encode to only out.
2018-08-22 tsepez@chromium.org Use UnownedPtr<> in IJS_Runtime.
2018-08-22 tsepez@chromium.org Use UnownedPtr<> in JBig2_TrdProc, part 2.
2018-08-22 tsepez@chromium.org Use UnownedPtr<> in CPDFSDK_FileWriteAdapter.
2018-08-22 hnakashima@chromium.org Remove unused setters in CBC_BarcodeMatrix and CBC_BarcodeRow.


Created with:
  gclient setdep -r src/third_party/pdfium@7e7e0b8379c4

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: If6a91d8909bcf65b2411a800e46f33aa0d5ed43c
Reviewed-on: https://chromium-review.googlesource.com/1185601Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585259}

This is very similar to http://crbug.com/868220

TBR=dcheng@chromium.org

Bug: 875856
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ifa6e29c60d593f16d154cae551ccef6c12540c4c
Reviewed-on: https://chromium-review.googlesource.com/1184391
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585258}

Bug: 819675, 734095
Change-Id: I9c9ff697d45118c220992b87ccbffe40ffa0bef5
Reviewed-on: https://chromium-review.googlesource.com/1185187Reviewed-by: Xi Cheng <chengx@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585257}

This is to support mojo sockets. With mojo sockets, we always try to read from
mojo data pipes (without caller explictly telling us to read), and we need a way
to cancel pending reads without having buffered data in socket subclasses.

Bug: 875855
Change-Id: I6570c5320c1ae84b6ef1eddd9ed8ba71e1c8a46c
Reviewed-on: https://chromium-review.googlesource.com/1185209Reviewed-by: Bence Béky <bnc@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585256}

Heap reporting suggests that we are wasting memory for them, too.

Bug: 845639
Change-Id: Ib24a6c6e879a96c95689631bcbec222126ffac83
Reviewed-on: https://chromium-review.googlesource.com/1181470
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585255}

This class is intended for use by the owner of the WindowService to
handle embeddings initiated by clients via ScheduleEmbedForExistingClient().
It roughly mirrors that of views::RemoteViewHost. I put this file in ws2 (but
in it's own directly) to reinfoce that it's optional and only for use with
the owner of ws2.

BUG=876513
TEST=covered by test

Change-Id: Ibc837fcb4619eefcfe90ca3c782446c581aef4cd
Reviewed-on: https://chromium-review.googlesource.com/1185362
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585254}

No change to production logic.

This switches every use of BaseJUnit4ClassRunner to AwJUnit4ClassRunner
under android_webview/javatests/. This also adds
@SkipCommandLineParameterization for each change, because the
BaseJUnit4ClassRunner did not run tests in both single & multiprocess
mode, only in single process mode (so we keep the same behavior).

This also adds a presubmit to prevent regressions.

Proposed on: http://shortn/_OS7nGlyaOn
Test: manually test presubmit prevents me from adding a test suite with
      BaseJUnit4ClassRunner
Test: run_webview_instrumentation_test_apk (everything passes, and the
      same number of tests are run as before this CL)

Change-Id: I36c0e549b1987cd1241407d989a2135f4d932a53
Reviewed-on: https://chromium-review.googlesource.com/1184234Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585253}

This pipes the call to GetProperty from ProtoDatabase through to
leveldb_proto LevelDB and finally onto the underlying Level DB, so we
can retrieve the value for tests and metrics.

Bug: 870813
Change-Id: I23f89685017eeae77e19c37847d6399cc8d6085f
Reviewed-on: https://chromium-review.googlesource.com/1169878
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585252}

Bug: 860654, 734095
Change-Id: I4a705377166d9579f27206f92371c02445f2d6bf
Reviewed-on: https://chromium-review.googlesource.com/1185081Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585251}

It's currently using base::WriteInto from string_util.h which it gets
transitively from components/leveldb_proto/proto_database_impl.h.

Change-Id: Ic795ad30ef79b9abf34ab028da202d92123ca249
Reviewed-on: https://chromium-review.googlesource.com/1185365Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585250}

Bug: 876149
Test: Multiselect several tabs in the middle of the strip.  There should be no separator on either end of the selection region.  On Win 7, dragging this set of tabs slightly to one side should show no separator on the end of the stationary tab by the newly-opened gap.
Change-Id: I68ebde9909c14683e50e9995ad9938e2cda6a1b3
Reviewed-on: https://chromium-review.googlesource.com/1185379Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585249}

Did not flake locally.

Bug: 659077
Change-Id: I8770032fb0944b32950987f5674583cf4b4241aa
Reviewed-on: https://chromium-review.googlesource.com/1180513Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585248}

This reverts commit 155b67d6.

Reason for revert: Test fix in latest EG.

Original change's description:
> [ios] Disables failing iOS12 tests while EG team investigates.
> 
> It seems with Xcode 10 items behind the keyboard are appearing as visible.
> This is likely an EG bug.
> 
> Bug: 854847
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I905d4e7809afe6d5d35e240b8e6c815f70cd41df
> Reviewed-on: https://chromium-review.googlesource.com/1109307
> Reviewed-by: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Sergio Collazos <sczs@chromium.org>
> Commit-Queue: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569242}

TBR=rohitrao@chromium.org,justincohen@chromium.org,sczs@chromium.org,gambard@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 854847
Change-Id: I5c1253288d99291fbd5e1677a6a0fb57c3142ffe
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1185801Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585247}

Bug: 112903714
Test: cast_bluetooth_unittests.
Change-Id: Iff20eeb9f2bb2c4b3aec4428eecc3a84980ed190
Reviewed-on: https://chromium-review.googlesource.com/1185525
Commit-Queue: Tiansong Cui <tiansong@google.com>
Reviewed-by: Bailey Forrest <bcf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585246}

Split existing tests for custom backgrounds out from general
SimpleJavascriptTests. These tests were never being run anways,
as they didn't start with 'test'.

Update local_ntp_browsertest.html with changes from local_ntp.html.

Bug: 857256
Change-Id: I251abfdc8aec75d896118d4ce0b251831b2bff43
Reviewed-on: https://chromium-review.googlesource.com/1184143
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585245}

These are more or less promisified versions of the existing FileEntry
and DirectoryEntry interfaces.

Tbr: jbroman@chromium.org
Bug: 872465
Change-Id: Idccd40c4ef3e94bbf12be2d5a1bb6e44019929ab
Reviewed-on: https://chromium-review.googlesource.com/1176555
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585244}

This change uses 'git cl format --full' for gles2_implementation.cc
to facilitate code review in this file. Otherwise, it's hard to
review when we have changes in this file.

Bug: 859249
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I74f04fa47ba4216d656cf96762354ac59057ee5f
Reviewed-on: https://chromium-review.googlesource.com/1184392
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585243}

Reland "MacViews: exit early when trying to drag without a drag image instead of crashing on Mojave"

This reverts commit a9ede579.

Reason for revert: ASAN should be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1185219

Original change's description:
> Revert "MacViews: exit early when trying to drag without a drag image instead of crashing on Mojave"
> 
> This reverts commit 24c96bd0.
> 
> Reason for revert: Mac ASan 64 Tests failing views_unittests, test
> case DragDropClientMacTest.ReleaseCapture,
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20ASan%2064%20Tests%20%281%29/43120
> 
> Original change's description:
> > MacViews: exit early when trying to drag without a drag image instead of crashing on Mojave
> > 
> > This is a temporary patch to merge back to 69 while we figure out the root cause.
> > 
> > Bug: 876201
> > Change-Id: Id87ac81f16b1cd3102c8605691421e8bc53dc401
> > Reviewed-on: https://chromium-review.googlesource.com/1183991
> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> > Commit-Queue: Leonard Grey <lgrey@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#585001}
> 
> TBR=ellyjones@chromium.org,lgrey@chromium.org
> 
> Change-Id: I80ec51eded1f8ba886eebc0c369ba23b96635c90
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 876201
> Reviewed-on: https://chromium-review.googlesource.com/1185142
> Reviewed-by: Sky Malice <skym@chromium.org>
> Commit-Queue: Sky Malice <skym@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#585091}

TBR=ellyjones@chromium.org,skym@chromium.org,lgrey@chromium.org

Change-Id: I5f06f3f13b68acc40cfd2e9b91bf5a4692f5f3a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 876201
Reviewed-on: https://chromium-review.googlesource.com/1185802Reviewed-by: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585242}

These are histograms that have not been viewed in the last 6 months, but still
report data on the Stable channel. Set these histograms to stop being recorded
for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug)
reminding owners about the approaching histogram expiry – initially 30 days
prior to expiry, and also with follow-up alerts. The metrics dashboards will
also display a warning for anyone viewing a soon-to-expire histogram.

Owners and/or users of these histograms: Please comment on this CL if you think
that any affected histogram should not have an expiry date set! This should be
uncommon.

Otherwise, there are a few options going forward:
  * If the histogram is no longer needed, please send a follow-up CL to delete
    the recording code and to mark the histogram as <obsolete>. (You can also
    remove the expiry date in the same CL.)
  * If you want to set a different expiry date, please send a follow-up CL to do
    so.
  * If neither of the above apply, then keep an eye out for Monorail bugs as the
    histogram expiry date approaches.
For more info on how unused histograms are identified, see
https://goto.google.com/uma-unused-histograms-cleanup

Bug: 850539
Change-Id: Ib8f8c0b136f5851e4bd628030bf4b01395bf7e3a
Reviewed-on: https://chromium-review.googlesource.com/1111559Reviewed-by: Ben Chan <benchan@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585241}

Position the ripple container relative to the element instead of the
viewport. This will allow the ripple effect to transition with the
element instead of floating in place.

https://screencast.googleplex.com/cast/NDg3NjY2Njc1Mjk5MTIzMnxlNzNlODU3My1jOQ

Bug: 864823
Change-Id: I4352ff9792d16aaa59f610634d71bb46362141b0
Reviewed-on: https://chromium-review.googlesource.com/1184035
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585240}

Currently, the blink v8 initialization code uses a stack address-taken
variable to read the stack position. This fails with SafeStack because
it reads an address on the unsafe stack. Make it match the code in v8 to
read the stack position safely with either ASAN or SafeStack [1] by
using a compiler intrinsic.

[1] https://crrev.com/c/1162669

Bug: 864705
Change-Id: Ib972540eb0264d9f737eb8bc40c601b8b2cf1ab0
Reviewed-on: https://chromium-review.googlesource.com/1179265Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585239}

Having the content dependency creates various problems for builds and
unit tests.

Bug: internal b/111732331
Bug: internal b/112417856
Bug: internal b/112328895
Test: cast_test_lists for Android
Change-Id: I17ef19c77a8062225e9124d6eef58189dcfc504d
Reviewed-on: https://chromium-review.googlesource.com/1180426Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Sean Topping <seantopping@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585238}

This method uses the NavigationController API to query the committed
navigational state on a Frame.

Bug: 852145
Change-Id: I49f9122753c393ef33d67905353b5ba1afad157a
Reviewed-on: https://chromium-review.googlesource.com/1182507Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585237}

Refactor the MaybeAllowImagePlaceholder() and MaybeAllowLazyLoadingImage()
functions to checks and enable the placeholder request bit separately.

This will help with lazyloading of CSS background images.

This is reland of below CL which had some formatting issues in local_frame.cc
https://chromium-review.googlesource.com/c/chromium/src/+/1178637

Bug: 846170
Change-Id: I9cf76d6e938a798d91b42d265964ad0c981054a1
Reviewed-on: https://chromium-review.googlesource.com/1180597
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585236}

Bug: 862425
Change-Id: I317be9b1cd25e921c04712fe0e04cdd0d77bd27b
Reviewed-on: https://chromium-review.googlesource.com/1185377Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585235}

When we start processing a gesture event, the
OnHasTouchEventHandler(false) IPC message may not yet
be received which means the |scrolling_touch_action_|
has no value and that results a crash.

This CL fixes the problem by call ResetTouchAction()
in TouchActionFilter's constructor. At that moment, the
|has_touch_event_handler_| is default to false which
will set both |allowed_touch_action_| and
|scrolling_touch_action_| to Auto.

Bug: 850238, 851644
Change-Id: I36f3edf2b9292347f184458aa059904af1a2f597
Reviewed-on: https://chromium-review.googlesource.com/1180592
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585234}

These are histograms that have not been viewed in the last 6 months, but still
report data on the Stable channel. Set these histograms to stop being recorded
for Chrome releases after 2018-08-30. We will file bugs via Monorail (crbug)
reminding owners about the approaching histogram expiry – initially 30 days
prior to expiry, and also with follow-up alerts. The metrics dashboards will
also display a warning for anyone viewing a soon-to-expire histogram.

Owners and/or users of these histograms: Please comment on this CL if you think
that any affected histogram should not have an expiry date set! This should be
uncommon.

Otherwise, there are a few options going forward:
  * If the histogram is no longer needed, please send a follow-up CL to delete
    the recording code and to mark the histogram as <obsolete>. (You can also
    remove the expiry date in the same CL.)
  * If you want to set a different expiry date, please send a follow-up CL to do
    so.
  * If neither of the above apply, then keep an eye out for Monorail bugs as the
    histogram expiry date approaches.
For more info on how unused histograms are identified, see
https://goto.google.com/uma-unused-histograms-cleanup

Bug: 850539
Change-Id: Ic888995f3a49848ecfe96c2aea55c1d2d365924c
Reviewed-on: https://chromium-review.googlesource.com/1126328Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585233}

Bug: 857266
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I58c2cb9e7b2ddf90dc9609945e418b27047f1e34
Reviewed-on: https://chromium-review.googlesource.com/1184043
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585232}

Bug: 875936
Change-Id: I27b4e463c128d3dc36fe8e72b47d18db99699410
Reviewed-on: https://chromium-review.googlesource.com/1181778Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585231}

Bug: 876044
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I3c37686f609acdcc479edb18c764e981c32c873c
Reviewed-on: https://chromium-review.googlesource.com/1184147Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585230}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I890952c728f084d643ac05a83b2eba4817fad699
Reviewed-on: https://chromium-review.googlesource.com/1185640
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585229}

Add a unit test that attempts to dynamically set an invisible icon in the toolbar.

Bug: 805600
Change-Id: I7ec07eb6bb3c205a69df0c4afd3b549370d1ef11
Reviewed-on: https://chromium-review.googlesource.com/1157127
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585228}

https://chromium.googlesource.com/catapult.git/+log/bbb04a38bbdb..c67a80df2679


git log bbb04a38bbdb..c67a80df2679 --date=short --no-merges --format='%ad %ae %s'
2018-08-22 anthonyalridge@google.com Fix bug in key selectors.


Created with:
  gclient setdep -r src/third_party/catapult@c67a80df2679

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:866423
TBR=sullivan@chromium.org

Change-Id: I6240d90f1786833df42567cc90901557a8ba1e2f
Reviewed-on: https://chromium-review.googlesource.com/1184869Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585227}

We want to push people to use the Launcher as the modifier everywhere.
This particular Delete shortcut was missing as Launcher+Backspace is
already wired up to be Delete.

Bug: 876774
Change-Id: Ibf1569a5094f819451ce32fe2178ed68fca9e830
Reviewed-on: https://chromium-review.googlesource.com/1185213Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585226}

Bug: 775415
Change-Id: Iceffd5b34d5fdecf3c72486b96e77f4ece2a423d
Reviewed-on: https://chromium-review.googlesource.com/1183907Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585225}

Before this CL, an ad-hoc implementation of FormatBytesWithUnits
was used, rather than call ui::FormatBytesWithUnits().

Bug: 775415
Change-Id: Ieb125023ef50943ef164b3d97246ba7e6fc8ad27
Reviewed-on: https://chromium-review.googlesource.com/1179667
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585224}

//content doesn't expose RefCounted-ness of ServiceWorkerContexts.
This means there's no safe way to run IO thread tasks on a
ServiceWorkerContext that was obtained on UI thread, typically
through StoragePartition::GetServiceWorkerContext.

This CL exposes a static method that takes in a ServiceWorkerContext*
and a OnceCallback and then it add ref-count to the underlying
ServiceWorkerContextWrapper until the OnceCallback is called.

Bug: 875376
Change-Id: I2d5c3bfa605679623e7558f507e31cf425c2804d
Reviewed-on: https://chromium-review.googlesource.com/1176734
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585223}

Bug: 814405
Change-Id: Ia123c66f60e0e941d1a2ccf8e3ae7e5262eebba4
Reviewed-on: https://chromium-review.googlesource.com/1170236
Commit-Queue: Andrew Luo <aluo@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Zhiling Huang <hzl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585222}

If the URLRequest has reported headers to the URLLoader, but there's no
pending body read, URLRequest will report a read error. URLLoader didn't
expect this, since there was no pending read.

This CL adds handling for this case. Ideally, we'd wait until there was
a pending URLRequest read before failing the request, to keep the state
machine of higher levels sane, but that's an issue for another day.

Bug: 875258
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I1ad1eddf590914e8b48379f4da7b3597f5b5158a
Reviewed-on: https://chromium-review.googlesource.com/1185214Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585221}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/4cc579e9d288..ded74c1409ac


git log 4cc579e9d288..ded74c1409ac --date=short --no-merges --format='%ad %ae %s'
2018-08-22 xixuan@chromium.org cbuildbot: Add passed_mins for skylab suites.


Created with:
  gclient setdep -r src/third_party/chromite@ded74c1409ac

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I3895b75e50df0f2e50efb88ff3d6e8cf57724d2b
Reviewed-on: https://chromium-review.googlesource.com/1184866Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#585220}