- 09 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7de9f95df905..8e7d9d6c2326 git log 7de9f95df905..8e7d9d6c2326 --date=short --no-merges --format='%ad %ae %s' 2019-10-09 kbr@chromium.org Add EGL_ANGLE_device_cgl extension. Created with: gclient setdep -r src/third_party/angle@8e7d9d6c2326 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Ieb96b7b38b1e9d172f713dcab0b3a830d12022f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849191Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704087}
-
Manu Cornet authored
As far as I understand, it was introduced in the past because the app list UI used to be outside of ash. As things are currently, this artificial divide creates significant unnecessary complexity within ash/app_list, with functionality spread over several classes with semi-ridiculous names (e.g. app list presenter delegate impl) and a class hierarchy designed to overcome the divide, and a lot of duplication and passing information (between the app list controller, the app list presenter, the app list presenter delegate, each one with its "impl" class) that slows down development and makes understanding the class structure difficult. The historical reasons for this separate namespace are no longer relevant. With everything in the "ash" namespace, the next step will be to start consolidating and reduce over-engineering. There were a few naming conflicts: with SearchResultType, that was resolved by renaming one of them to AppListSearchResultType, one with DialogPlate (one was postfixed with "Deprecated") and another with AssistantMainView (same resolution). This contains no semantic change and doesn't have any expected user-visible implications. Change-Id: I0755476a1fb7a6f0898258dee6e8981b7358c904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838269 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#704086}
-
Ethan Jimenez authored
1. Exposing `AXRange` code for comparing endpoints; this is done since such logic is currently specific to `AXRange::AsForwardRange`, but it could be used elsewhere to ensure text ranges are well-formed. 2. Fixing a bug in `ITextRangeProvider::GetAttributeValue` that caused it to include values from an unexpected anchor if either one of the range's endpoints was located at the start or the end of such anchor without spanning a single character of its text representation. In order to fix this, at the beginning of `GetAttributeValue` we normalize the text range by moving the start and end endpoints to positions located right before and after a character respectively. Note that such normalization may change the position of the endpoints in the `AXTree`, but they should still be equal as text positions. 3. Fixing a bug in `ITextRangeProvider::ExpandToEnclosingUnit` that, after enclosing the last word on a line before a `<li>` element, caused `GetBoundingRectangles` to include the bounding rectangle belonging to the list item marker of the following `<li>`. Similar to #2, the fix for this issue involves normalizing the range's endpoints before returning in `ExpandToEnclosingUnit`. 4. Adding test coverage for the scenarios described in #2 and #3. 5. Fixing some minor issues of validating `ITextRangeProvider` calls. Bug: 928948 Change-Id: I2f40545eca20c53db8d4cbabb36f17a27799e987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838707 Commit-Queue: Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#704085}
-
Hajime Hoshi authored
This adds new metrics for eviction by back-forward navigation: BackForwardCache.EvictedAfterDocumentRestoredReason BackForwardCache.EvictedAfterDocumentRestoredReason records the reason why the page is evicted from back-forward cache e.g., by the race condition with JavaScript. This is separate from a regular eviction metrics because restoring the document happens once. Bug: 1004676 Change-Id: I0d0475022e6f8a7edbcfbb0cd43e634f63292efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828766 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#704084}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0f9dd4eb407b..44e07101f19f git log 0f9dd4eb407b..44e07101f19f --date=short --no-merges --format='%ad %ae %s' 2019-10-09 vapier@chromium.org pylintrc: add isort module settings 2019-10-09 vapier@chromium.org cros lint: fix running under Python 3 2019-10-09 dburger@chromium.org Stop AFDO uprevs by the chrome PFQ. Created with: gclient setdep -r src/third_party/chromite@44e07101f19f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ibf1a041506b8272db86d605b913711de452d66b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849331Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2b1a25a4d324..77dde599c98a git log 2b1a25a4d324..77dde599c98a --date=short --no-merges --format='%ad %ae %s' 2019-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 5c41949c..309b078c (481 commits) Created with: gclient setdep -r src/third_party/skia@77dde599c98a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:None Change-Id: I15e1258b6601768e4c5dc96c2ba500471313a268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849251Reviewed-by:
-
Eric Willigers authored
The proto used by WebAppSyncBridge and WebAppDatabase now contains DisplayMode. TBR=dominickn@chromium.org Bug: 1009909 Change-Id: Ic720d4837f5b6fb15e4f025370bc8d3191a8d2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846634Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#704081}
-
Junyi Xiao authored
Issue: the "more tabs" dropdown button doesn't have enough contrast when hover/keyboard focused in dark theme This change changes the hover/focused color to match the rest tool bar button Screenshots: https://imgur.com/a/TBoOlzR Bug: 963183 Change-Id: I9ff66c3be732cf598d18d71af643d01a7de5ce54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841580Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Junyi Xiao <juxiao@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704080}
-
Anushruth authored
Temporary fix for chrome_all_tast_tests_informational as it takes more than 60 minutes to complete a run. Tast tests cannot be sharded yet (See crbug.com/968262). Also includes a bugfix which replaces use of 'str' to 'encode' as some informational tests use '
🔥 ' '❄ ' characters. Timeout example: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel-hw-tests/15876 Bug: 988581 Change-Id: Idd85797811d722289176565e452d163d6e8bb3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839018 Commit-Queue: Anushruth <anushruth@chromium.org> Reviewed-by:Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#704079}
-
Ramin Halavati authored
Three incognito icon resources are updated to match the new material design. Bug: 997054 Change-Id: I4fd65a6e91992eea88a72f19dc4deeabf41b2b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794862Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#704078}
-
Abhijeet Kandalkar authored
This CL converts usage of |ProducerClientRequest| to |mojo::PendingReceiver<mojom::ProducerClient>| Bug: 955171, 978694 Change-Id: I54d5a576b097e98c9d80bdf966d2f92262d24d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842174Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#704077}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b45c693f..6092f6bc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifdeb051941a7f2cb8c8228ee3b78d56aeab07058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848622Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704076}
-
Shuo-Peng Liao authored
In media/gpu/v4l2/v4l2_device we have V4L2PixFmtToVideoPixelFormat() and VideoPixelFormatToV4L2PixFmt() to convert V4L2PixFmt (fourcc code) to VideoPixelFormat, and vice versa. Also, in media/gpu/vaapi/vaapi_utils, we have VideoPixelFormatToVAFourCC() to convert VideoPixelFormat to VAFourCC (fourcc code). As we plan to use fourcc to replace VideoPixelFormat to represent video format in platform-agnostic class (refer to crbug.com/1005636). However, since the use case right now is restricted to ChromeOS V4L2/VAAPI, we move the converters to media/gpu/chromeos. Also, to break the dependency on platform-specific headers like <linux/videodev2.h> and <va/va.h>, for V4L2 and VAAPI, respectively, we defines a set of commonly used Fourcc enum with value based on V4L2 definition. Then we define a Fourcc class to store fourcc enums and to provide converters Fourcc <-> {VideoPixelFormat, V4L2PixFmt, VAFourcc}. Finally, though many V4L2 and VAAPI fourcc map to the same VideoPixelFormat have the same value, there exists some exception. For example: I420 in V4L2: V4L2_PIX_FMT_YUV420 (Fourcc "YU12") I420 in VAAPI: VA_FOURCC_I420 (Fourcc "I420") BUG=1005636 TEST=Pass CQ Change-Id: Id1099120a86c1964fee9ce7058a3cf2ede6e5ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828763 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#704075}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/955a6a3e261a..e4d6ee0d7320 Created with: gclient setdep -r src-internal@e4d6ee0d7320 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I0312ed0123f82b1cd4163e39fde559e41aadb75d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849091Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704074}
-
Giovanni Ortuño Urquidi authored
Use CONSTANT_CASE for generated constants. Changes all instances that used the incorrect case. Bug: 1009251 Change-Id: I79b856996f543650b4cd20e329978936a12adeae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842976Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#704073}
-
Gyuyoung Kim authored
This CL converts old Mojo types to new Mojo types in ContentDescriptionModule interface. pending_associated_remote and associated_remote are applied to the interface. Bug: 955171 Change-Id: I22ecdae031415d0d14382a58342c68a7535620e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826747Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#704072}
-
Hiroki Nakagawa authored
Module workers have a bit different script loading and context initialization sequence from classic workers, so we should have test cases specific to module workers, too. Bug: 954853 Change-Id: I5d72cd5e962287bbd63560299be0583a44d00cf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847466Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#704071}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5eaaf59c1774..0f9dd4eb407b git log 5eaaf59c1774..0f9dd4eb407b --date=short --no-merges --format='%ad %ae %s' 2019-10-09 dburger@chromium.org Add packages handling to builds call / GetBuildDependency. Created with: gclient setdep -r src/third_party/chromite@0f9dd4eb407b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I3b9eaba167460aa83ecc0363bcdfa26c0579aac6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849011Reviewed-by:
-
nancy authored
For extensions, like Hangouts, since that is not app, it is not added to the AppService, so the icon is not shown on the shelf. Hangouts is a special extension, which shows an window, so it should be added to the AppService to show the icon on the shelf, when launching the hangouts. BUG=10095580 Change-Id: I7cfdbdcba68bb67aa7d70d10ab1a31ab6299bca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846213Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#704069}
-
Julian Watson authored
Change-Id: I1c148eeaa6e63ef62dd78cbc1a3cc514d5e65102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840132 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#704068}
-
Justin Cohen authored
This reverts commit ffcd2de7. Reason for revert: Followup to revert here: https://chromium-review.googlesource.com/c/chromium/src/+/1849135 Which was reverted due to red ios/slimnav bot Original change's description: > Add GetAllCookiesWithAccessSemantics to CookieManager interface > > This CL adds a method, GetAllCookiesWithAccessSemantics, to the mojo > interface CookieManager. This just directly calls > CookieStore::GetAllCookiesWithAccessSemanticsAsync() on the > CookieManager's underlying CookieStore. > > Bug: 978172 > Change-Id: Ic26298caf12d34ffd4de5bcf81058f6984528683 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845803 > Commit-Queue: Lily Chen <chlily@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Martin Barbella <mbarbella@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703916} TBR=mbarbella@chromium.org,morlovich@chromium.org,chlily@chromium.org Change-Id: I72e9457762658e296a7442384f093391a41c4e57 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 978172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849138Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704067}
-
BUG=762641 TBR=xiyuan@chromium.org Change-Id: I359e7376d99b61d626627a99c5d50dcdc0cefe85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848621Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704066}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/df2726ee7a36..2b1a25a4d324 git log df2726ee7a36..2b1a25a4d324 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 joe@bitworking.org Fix Cloud Build for vpython. Created with: gclient setdep -r src/third_party/skia@2b1a25a4d324 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:993053 Change-Id: I32dfeaddfa438b95c8cd677818c3d71f34a0af34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848892Reviewed-by:
-
Justin Cohen authored
This reverts commit 8d1685b9. Reason for revert: Consistently failing on SlimNav-off bot. https://ci.chromium.org/p/chromium/builders/ci/ios-slimnav/8980 Original change's description: > Add CookieStore method to fetch all cookies with their access semantics > > This change adds a CookieStore method, > GetAllCookiesWithAccessSemanticsAsync, which returns a list of all > cookies in the CookieStore along with a list of the > CookieAccessSemantics for each returned cookie. These lists will be in > the same order, so that each cookie in the returned list of cookies has > the access semantics at the same index in the other list. > > This is implemented for CookieMonster only, and other CookieStore > implementations will use the default impl which returns UNKNOWN for > all the cookies. A later CL will additionally expose this method > via the CookieManager interface. > > Bug: 978172 > Change-Id: I8463806f5cc6ce6c8d200bec57bbecba5fe3aec6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846071 > Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Commit-Queue: Lily Chen <chlily@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703824} TBR=mrefaat@chromium.org,morlovich@chromium.org,chlily@chromium.org Change-Id: I2a185de1291efb615aae82b8664116701549055d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 978172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849135Reviewed-by:
-
Rakina Zata Amni authored
Previously we used StyleForElement which is wrong. We should update style to get the up-to-date style value with the correct inheritance etc and also need to update layout because some things in accessibility code requires the layout to be clean (just updating the style & layout tree from IsFocusableStyle might dirty the layout). Bug: 1002416 Change-Id: I7b891cde8861cdcb3c79f43b8fa48f13c163dda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846215 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#704063}
-
Moe Ahmadi authored
Swaps the existing implementation with one that queries the keyword search terms table in the in-memory URLDatabase instead of the URLs table. - This table is smaller so querying it is likely faster. - The step to parse URLs is avoided. - Is more consistent with how SearchProvider offers local search history matches. Also improves and re-enables LocalHistoryZeroSuggestProviderTest.Delete which was failing for Linux ChromiumOS MSAN, likely due to using an uninitialized |history_db_task_id_| which no longer exists. Bug: 996516,1010944 Change-Id: I183fb7367285dcb453fb42e46651550baf0e3036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835182 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#704062}
-
Jinho Bang authored
This is a spec match-up with[1] [1] https://github.com/gpuweb/gpuweb/pull/459 Bug: 877147 Change-Id: I080324cbb083160ae84aa109623e311f24a875cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845132Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#704061}
-
Tim Song authored
Each pop-up is contained in its own Widget, which we need to add to ash's FocusCycler. TEST=manually verified BUG=1007027 Change-Id: I330465bc4a63c5ac26951b8bebfb2ee7f2700327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832669 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#704060}
-
Miyoung Shin authored
This CL removes Authenticator from the frame registery in chrome_content_browser_client.cc because this mojo interface for Java is already bound in browser_interface_binders.cc, and rename ForwardToJavaFrameRegistry and BindAuthenticatorRequest. Bug: 936482 Change-Id: Iee29077fa23b05e2369d08217c7327271946e845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844515 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#704059}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I415a9d2f64f326797876998fd9bdd5f28c14b84f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849132Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704058}
-
Robert Sesek authored
The framework is bundled within the .app, but none of the dependent shared libraries created by the component build are. Those need to be expressed as runtime dependencies of the framework, and by extension the app. But GN does not propagate that across the create_bundle rule so it must be done manually. Bug: 1010347 Change-Id: If4b08329c97e7ef5b0e5073fbb26252b922c50a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846075 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#704057}
-
Julie Jeongeun Kim authored
This CL converts SelectFileDialogRequest and SelectFileDialogPtr to new Mojo types using PendingReceiver, Remote and SelfOwnedReceiver. Bug: 955171 Change-Id: I776fe70be72a02ba451324b6ff0c9b436e8ff56d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846633Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
-
Patrick Monette authored
This is a reland of 7c390807 The fix for the issue that caused the revert is here: https://chromium-review.googlesource.com/c/chromium/src/+/1835164 Original change's description: > [PM] Add SharedWorkerWatcher > > This class observes running shared worker instances, keeps track of > the connection to their client frames and manages the lifetime of > worker nodes in the Performance Manager graph. > > Bug: 993029 > Change-Id: I2e0c7cd9f194a06405293c22fd543a14ff3c6cbc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757283 > Commit-Queue: Patrick Monette <pmonette@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701445} Bug: 993029 Change-Id: Ib77ea36b9cc71ec83ccbe28173fc6053e4a497f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829796 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#704055}
-
Nicholas Hollingum authored
X11 applications have two common ways of bringing their windows to the user's attention: sending NET_ACTIVE_WINDOW and setting the urgency flag in NET_WM_HINTS. These tricks are used by applications to, e.g. refocus their windows when the user opens a file in an already-running app. In crrev.com/c/1824398 we add support to sommelier to identify these requests. We must now add a method to the aura protocol so that we can communicate the request to chrome. For the time being the request will do nothing, as we are awaiting UX input on how to respond to the request. Bug: 899587 Change-Id: I0e8b6e639a389055b6e2adbaeb77d0881dd2c18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824726 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#704054}
-
Nicholas Hollingum authored
Two main changes - Removed "uninstall" from the terminal's menu, which previously would uninstall crostini. This must now be done via settings. - Fixed "uninstall" for shelf apps, which previously did not work. Bug: 1009925 Change-Id: Icba200b4ed054a09a8fe1c5d777362cf353438d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846631 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#704053}
-
Dmitry Gozman authored
Previews state change with a new document load, so it's natural to host this state in the DocumentLoader (as opposed to frame). Drive-by: removed unused LocalFrame::IsUsingDataSavingPreview(). Bug: none Change-Id: Icbb7a335c456ca32c5b0e30f7dfd8ad7c329423d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844431Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#704052}
-
Lindsay Pasricha authored
Bug: 1012488 Change-Id: Ie6a758ea7e90d8f023c9dfc766737e20996157bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848791Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d8955c8337fc..955a6a3e261a Created with: gclient setdep -r src-internal@955a6a3e261a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4492f166061ba948f6d4ca1b3be684235813942f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848457Reviewed-by:
-
Dan Beam authored
Bug: 1003210 Change-Id: I89ed4851798663207098743fd551a378fbd1060b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834231Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#704049}
-
Dana Fried authored
toolbar. This eliminates a lot of complicated math in favor of just finding the offset of the child (bookmarks bar, toolbar) into the background image and painting the view background. Bug: 993502 Change-Id: I0502a1468abfe50ea919de863244f0bd5558d4b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847775 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#704048}
-
