- 21 Jun, 2018 40 commits
-
-
Kyle Horimoto authored
This CL adds a current_rssi field to the mojom::ConnectionMetadata struct and implements fetching this field throughout all classes involved with returning the value. Bug: 844759, 824568, 752273 Change-Id: I663326ceb7bb3c5113289f0b29a2ad9c26fcbfa9 Reviewed-on: https://chromium-review.googlesource.com/1106810Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#569295}
-
Kyle Horimoto authored
This CL separates the logic which controls Mojo bindings from the rest of MultiDeviceSetupImpl. This will allow me to add a follow-up CL which adds an initialization step to this service. Bug: 824568 Change-Id: I5cc870f44f8933b2eee16336e9476684fe6ada85 Reviewed-on: https://chromium-review.googlesource.com/1109276Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#569294}
-
Kyle Horimoto authored
Bug: 824568 Change-Id: I411f838c9082e1dff6f713dec8c99b5e420e3b7f Reviewed-on: https://chromium-review.googlesource.com/1109315Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#569293}
-
Morten Stenshorne authored
Refer to that bug in the test expectations file. TBR=dgrogan@chromium.org,kojii@chromium.org Bug: 855039 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I9eb0827a1d56a7a196e862c6580dedb9fdffad3a Reviewed-on: https://chromium-review.googlesource.com/1110122 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#569292}
-
John Budorick authored
Android P splits some of the old android.test.* classes into what it calls "legacy testing libraries." These need to interact with our build system like the main android.jar does. That jar previously interacted with the build system as a special case, though; this CL generalizes it. Bug: 841695 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie6a61bdafbf4990e6f82d9431ae8d7c2fd6ba709 Reviewed-on: https://chromium-review.googlesource.com/1102915 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#569291}
-
John Abd-El-Malek authored
Also remove some people who left the team. Change-Id: Ib26f8d1f712d4b9955824fa0c548b0539fd8c3d7 Reviewed-on: https://chromium-review.googlesource.com/1110262Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#569290}
-
Gauthier Ambard authored
This CL clips the content of the popup menu's table view to its bounds, making sure its content, including the selection highlight respect the bounds set by the rounded corners. Bug: 850511 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I516224790aed23fd88387ac3236d36861697cde3 Reviewed-on: https://chromium-review.googlesource.com/1110129 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569289}
-
Guido Urdaneta authored
Intent to Ship thread: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/wJwVSo52Dno/CjrUTTuyBAAJ Bug: 731170 Change-Id: I53274b2bf5a622cb50d4b59f521bf56160172b61 Reviewed-on: https://chromium-review.googlesource.com/1100884 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#569288}
-
David Roger authored
The CL https://chromium-review.googlesource.com/c/chromium/src/+/1104682/9/components/signin/core/browser/signin_manager.cc introduced a regression, leading to cookies not being merged correctly. The cookies should be merged in all cases except Mirror, but that CL did the opposite (only merging cookies when Mirror is enabled) Change-Id: Ib3c5454259ff6b7ec82bb2411bcff011bc63f3e1 Bug: 777774 Reviewed-on: https://chromium-review.googlesource.com/1109976Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#569287}
-
Peter E Conn authored
On Samsung Lollipop devices the Intents used to communicate with a foreground WebappActivity were causing a new instance of the WebappActivity to be launched instead of causing onNewIntent of the current Activity to be run. This only occurs when a ChromeTabbedActivity is in the background, when it is not, onNewIntent is called properly. I'm not sure what is special about WebappActivity that causes this - I've been unable to generate a smaller repro. This issue is solved however by making sure both the FLAG_ACTIVITY_NEW_TASK and FLAG_ACTIVITY_NEW_DOCUMENT (which was FLAG_ACTIVITY_CLEAR_WHEN_TASK_RESET in pre-Lollipop) have been set on the Intent and FLAG_ONE_SHOT has been set on the PendingIntent. Bug: 846528 Change-Id: I9602537e68b24a186961d29f4c4b1fb1ae9235b0 Reviewed-on: https://chromium-review.googlesource.com/1107631Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#569286}
-
erikchen authored
The main menu has a built-in 100ms delay. Combined with higher priority for incoming NSEvents compared to chrome tasks, holding down key equivalents [e.g. cmd + w] starves the chrome task queue. The implementation of tab-closing requires the main thread to process the on unload ACK from the renderer before closing the tab [which is a chrome task], so this causes a live-lock. This CL lets reserved keyEquivalents bypass the main menu. This avoids the live-lock indicated above. This also loses the built-in 100ms throttle, so this CL adds a custom 50ms throttle [disabled in tests]. Bug: 836947 Change-Id: Idb88ee84d7aa82da4104893ed85358c75e385ea3 Reviewed-on: https://chromium-review.googlesource.com/1108095 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#569285}
-
kylechar authored
Android WebView had the UseSurfaceLayerForVideo feature enabled unintentionally which was causing a crash. This was fixed in https://crbug.com/853832. Enable WebView perf tests that got disabled due to the crash. Bug: 853204 Change-Id: Ib678a48ec723f40a4ab3be72f6078cafcfc311c6 Reviewed-on: https://chromium-review.googlesource.com/1110018Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#569284}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8a119eb7. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19946 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=robertma No-Export: true Change-Id: Ifa23c23d080a1981f76955170b511f4239fa9396 Reviewed-on: https://chromium-review.googlesource.com/1109743 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#569283}
-
Emily Stark authored
The old Symantec PKI will be fully distrusted in M70 (https://security.googleblog.com/2018/03/distrust-of-symantec-pki-immediate.html). We already have DevTools console messages in place for affected resources, and this CL adds UseCounters so that we know how many page loads will be affected. The counters give us: - % of page visits with an affected main frame main resource - % of page visits with an afected subframe main resource - % of page visits with an affected subresource Note that these buckets can overlap, for example a single page visit can increment all 3 counters. Bug: 853868 Change-Id: I7ae103efcc47a3e4e381b35c6803ef2d8ed4c7fb Reviewed-on: https://chromium-review.googlesource.com/1107841 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#569282}
-
Colin Blundell authored
The next-generation C++ APIs for interacting with the user's Google identities currently do not give the ability to fetch access tokens for arbitrary accounts; rather, there exists only the PrimaryAccountAccessTokenFetcher, which provides user-friendly access token fetching for the primary account. This CL introduces an analogous AccessTokenFetcher class that allows such user-friendly access token fetching for arbitrary accounts. This class is currently built on top of the Token Service, as it remains future work to expose access token fetching APIs on IdentityManager itself. Once that future work is completed, AccessTokenFetcher will be ported to be layered on top of IdentityManager. In the meantime, we introduce IdentityManager::CreateAccessTokenFetcherForAccount() to allow consumers of IdentityManager to create an AccessTokenFetcher. Note that our intention is that even in the long-term consumers will use AccessTokenFetcher and PrimaryAccountAccessTokenFetcher as the interfaces for fetching access tokens, rather than interacting directly with IdentityManager's lower-level APIs. This CL also ports PrimaryAccountAccessTokenFetcher to internally use AccessTokenFetcher rather than directly fetching access tokens from ProfileOAuth2TokenService. API design note: It would be reasonable to build PAATF's idea of an "access token fetching mode" into AccessTokenFetcher: in this context, kWaitUntilAvailable would simply mean waiting until the refresh token was available. This CL does not add such a mode. However, for Sync's use case having the mode will likely be useful (Sync will alternately use the primary account and an arbitrary account, and it would be ergonomic to be able to fetch access tokens in both contexts using AccessTokenFetcher). Hence, followup work will move this mode down into AccessTokenFetcher. Bug: 729547 Change-Id: Id296adcd1567d6cbfbaf6ffd1dafb718c1f01ed7 Reviewed-on: https://chromium-review.googlesource.com/1104118 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#569281}
-
Raymond Toy authored
The IDL tests in the subdirectories aren't really needed anymore since we have webaudio/idlharness.https.html that covers everything in the individual tests. Bug: 854220 Change-Id: I589f4972922dfc15c475ce20e7c4cb664b529920 Reviewed-on: https://chromium-review.googlesource.com/1107120Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#569280}
-
Gauthier Ambard authored
The dispatcher wasn't set for the primary toolbar used by the NTP, leading to bugs where the commands weren't sent to the rest of the application. Bug: 851930 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I17b2e015a307e993e548c4dfcbca599472503d58 Reviewed-on: https://chromium-review.googlesource.com/1110123 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569279}
-
James Wallace-Lee authored
TalkBack should just speak the cell data for cells in table. TBR=avi@chromium.org Bug: 669622 Change-Id: Iecb736acdbe36d106672b97425bb72988eef1efa Reviewed-on: https://chromium-review.googlesource.com/1108920 Commit-Queue: James Wallace-Lee <jamwalla@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#569278}
-
Devlin Cronin authored
We're getting ready to roll extension bindings out to beta, so add a fieldtrial testing config entry for the experiment to have it run by default on the bots. Bug: 763564 Change-Id: Ibdf83e16cbc10e4c62e2304cf14cd7c24377bc31 Reviewed-on: https://chromium-review.googlesource.com/1108192Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569277}
-
Rune Lillesveen authored
Be explicit about when we try to access pseudo style caches instead of uncached. We will remove cached access for computing style for PseudoElement and only use caching for pseudo element style where we don't generate any elements (like ::selection) and for getComputedStyle queries on elements which do not generate pseudo elements. E.g. getComputedStyle(elm, "::before") when elm has no matching ::before rules. Bug: 836126 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2e4436ea78b31bc72f05ada66b2955369ee93f4a Reviewed-on: https://chromium-review.googlesource.com/1109825Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#569276}
-
Mounir Lamouri authored
Bug: 848537 Change-Id: I07e7195991ea350a9b5d17b48682a541ff2ef7a4 Reviewed-on: https://chromium-review.googlesource.com/1081871 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#569275}
-
Samuel Huang authored
This CL moves Zucchini-gen invocation code from zucchini_commands.cc (in target zucchini) to zucchini_integration.cc (in target zucchini_io) to clean up layering in Zucchini API, i.e.: - zucchini_lib: Operates on buffers only. - zucchini_io: Adds files interface, uses memory-mapped I/O. - zucchini: Stand-alone executable that parses command-line arguments. Other changes: - Rename zucchini_lib functions (zuchcini.h), to dedup names and emphasize that these functions operate on buffers: - GenerateEnsemble() -> GenerateBuffer(), - GenerateEnsembleWithImposedMatches() -> GenerateBufferImposed(), - GenerateRaw() -> GenerateBufferRaw(), - Apply() -> ApplyBuffer(). These renames only affect Zucchini and various tests. - Variable renames and parameter reordering in zucchini_integration.cc. - Remove '-dd' param in help text of Zucchini-detect (was never ported from Trunk, and has been recently deleted there as well). - Replace all base::File&& with base::File. - Miscellaneous cleanup for header include. - Update README.md. Change-Id: I835b80d4d3d7b291fa822a7a89dab225bf9171e9 Reviewed-on: https://chromium-review.googlesource.com/1105625Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#569274}
-
Marc Treib authored
This adds a State enum to StartupController and exposes it via GetState(). It's not strictly required right now, but a) it'll help with sanitizing ProfileSyncService's state, b) it makes the tests a bit nicer, now they can use the enum instead of relying on debug strings, and c) it lets us move GetEngineInitializationStateString from StartupController to ProfileSyncService, where it's slightly less out of place (bonus: extra DCHECKs for consistent state). Other semi-related test cleanups: don't call SetFirstSetupComplete from FakeStartBackend (no idea why that call was there), and don't check for the kSyncDisableDeferredStartup cmdline flag (if you run the tests with a custom flag, it's your own fault if they fail). Bug: 839834 Change-Id: I16f83be8ee828024329cbce899be4723241323db Reviewed-on: https://chromium-review.googlesource.com/1109939 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#569273}
-
Peter Beverloo authored
This utility class contained the (custom) interaction of notification permission storage with the HostContentSettingsMap. Instead, fall back to using the HCSM directly where there's no diverging behaviour, and add a NotificationPermissionContext::UpdatePermission() method for the rest. Change-Id: I729d460a5773c691d611285ecfbf7cc97618f304 Reviewed-on: https://chromium-review.googlesource.com/1093091 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#569272}
-
Maks Orlovich authored
URLFetcher will stop working with advent of Network Service, and SimpleURLLoader is the replacement API for most clients. Note that this only covers the code immediately here; the underlying google_apis/gaia code is unchanged. Bug: 844963 Change-Id: I9ba41c0c7cbb3a996db49d437b421d65f7e9c8ee Reviewed-on: https://chromium-review.googlesource.com/1087412 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#569271}
-
Ian Vollick authored
This should take precedent over other environments, even incognito. Bug: 853818 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I001b11ade38415e884d889c4c13c617707cfd8a7 Reviewed-on: https://chromium-review.googlesource.com/1104978Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#569270}
-
Mikel Astiz authored
We refactor and extend the tests to: 1. Add support for USS types (which requires migrating the tests from reading the directory directly). 2. Capture more complex sequences, combining multiple transitions. 3. Add disabled tests that are under investigation, due to flakiness reported on iOS integration tests the exercise analogous transitions. Bug: 854446 Change-Id: Ic6aa9294086a8511255a084af08112f3455f078b Reviewed-on: https://chromium-review.googlesource.com/1110118Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#569269}
-
Matthew Jones authored
This patch renames the questionably named "FadingBackgroundView" to something that makes sense, "ScrimView". All associated interfaces have also been updated. Change-Id: Ib95226264c9f23f3aaa1a0053cf81e44722eb910 Reviewed-on: https://chromium-review.googlesource.com/1005623 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#569268}
-
Oscar Johansson authored
When building using Jumbo namespace aliases with the same name may end up in the same unit, causing a conflict at compilation. This commit removes "using windows" and "using tabs" and instead call the namespace by its full name. This is done to increase the robustness of the code. std::unique_ptr<T>() are removed because of presubmit check errors. Bug: 850484 Change-Id: I91f44728d4b54dd15213bac602176ca8736bb3cd Reviewed-on: https://chromium-review.googlesource.com/1107633Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#569267}
-
Danil Chapovalov authored
So that webrtc/api:optional target can be removed. webrtc version of Optional is gone in favor of absl::optional Chromium already updated not to use rtc::Optional and use absl::optional only when is needed to be set in webrtc structures. Bug: webrtc:9078 Change-Id: I282197cb800e46ece9486bb6b6068d1680a40d2b Reviewed-on: https://chromium-review.googlesource.com/1109830Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Danil Chapovalov <danilchap@chromium.org> Cr-Commit-Position: refs/heads/master@{#569266}
-
Arthur Sonzogni authored
The GURL class upgrades the port from 80 to 443 when asked to replace the URL's scheme from 'http' to 'https'. Doing it manually was pointless. Bug: none. Change-Id: I12aaa7f0a243134a3810ed871e73b7473acfad5a Reviewed-on: https://chromium-review.googlesource.com/1107931Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#569265}
-
Rune Lillesveen authored
We create an unobservable inline box for display:contents pseudo elements storing the original style on the element. Split this code out into a separate method as we will need it for constructing pseudo elements as part of style recalc later. Bug: 836126 Change-Id: I8610ea5cd92ebbefd0428f84ca2ff4e48169b232 Reviewed-on: https://chromium-review.googlesource.com/1109827Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#569264}
-
Dave Tapuska authored
Add additional API to determine if we should revalidate if we are allowing a stale response. Add a test to cover the different intervals of what should be returned by the API. BUG=348877 Change-Id: I69be1c768e4896362406bb80a3dde307edae27d2 Reviewed-on: https://chromium-review.googlesource.com/1102352Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#569263}
-
Jungshik Shin authored
This roll has just one change to fix the timezone detection on Japanese/Korean and other non-English Windows. https://chromium-review.googlesource.com/1094322 In addition, switch to ICU to convert UTC to local time in blink. This is to deal with a cryptic failure of external/wpt/html/dom/doc*/resource*/document-lastModified-01.html parens. Bug: 849724 Test: Set the timezone to Tokyo on Japanese Windows Test: In JS console, 'new Date()' outputs 'Japan Standard Time' in Test: Layout test external/wpt/html/dom/doc*/resource*/document-lastModified-01.html Change-Id: I3037252ff9044a114ae831de2b151df7c652603c Reviewed-on: https://chromium-review.googlesource.com/1100739Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569262}
-
Olivier Robin authored
BUG=852964 Change-Id: Ic47e00858062874ad30eaeeb4bae54d93ae1087d Reviewed-on: https://chromium-review.googlesource.com/1108215 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#569261}
-
Deepanjan Roy authored
Allows specifying cache temperature with --cache-temperature. Values are as defined in telemetry/page/cache_temperature.py. For example: --cache-temperature=warm. Also, changes the default cache temperature for loading_ct to COLD. Change-Id: Ib0210bf2a72d28902bfe653cc01646aae4ccbcff Reviewed-on: https://chromium-review.googlesource.com/1106643 Commit-Queue: Deepanjan Roy <dproy@chromium.org> Reviewed-by:
Ravi Mistry <rmistry@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#569260}
-
Danyao Wang authored
WKBasedNavigationManager needs to create a web view to restore session. The current order causes an CHECK in CRWWebController that prevents the creation of new web view when |_webUsageEnabled| is false. This fixes failure in NavigationTestCase and crashes observed in the wild. Bug: 852847 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia6a7800ca6ec985a2080d0e0acc3a743c8c62c5f Reviewed-on: https://chromium-review.googlesource.com/1108575Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#569259}
-
Martin Šrámek authored
Bug: 854538 Change-Id: I1e33574edf070dc93cf897faab75a0e53df39dd8 TBR: mkwst@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1109959Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#569258}
-
Mustaq Ahmed authored
Bug: 805015 Change-Id: I9b9c8ee0071707220ec9ad1f7966816b055cf655 Reviewed-on: https://chromium-review.googlesource.com/1108438Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#569257}
-
Stuart Langley authored
Rename to --disable-team-drives for disabling. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1103986. sashab@ is on vacation so I am landing her changes in this CL, with fixes for failing unit tests. Bug: 849772 Change-Id: I37260458a60f69d2e95d87afbf87213456131c29 Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1108241Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#569256}
-