GitLab

Metric reports the time a NTP is on screen.
Incognito NTP are not reported.

Bug: 1131209
Change-Id: I25fb6bb004efd89cbef855e2455c71f616986e55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487105
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824131}

Bug: 772945
Change-Id: Ib78e6fbdb96503f4ce6687b07300f0421fb3d26d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519834
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824130}

Change drag and drop to also use callbacks for data fetching like how
clipboard does. Ensure callbacks are only invoked once with data
cached, and pending receive requests managed.

Files drag and drop will require this to allow file sharing to be done
inside FileHandler at the point where a client calls data_offer_receive,
rather than when FileHandler is currently invoked when data is offered.

This change provides performance improvements particularly for when an
image is requested multiple times from the clipboard since we now only
do the encoding once.

Bug: 1144138
Change-Id: I56c7d3b55a3365a591829313462af23e71e172b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509833Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824129}

Explicitly match only on literal . characters instead of any characters.
Add explanatory comment.

Bug: 1078229
Change-Id: I1f248d270ebd22f17aebaad55750d5bed9a275a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519897
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824128}

Bug: 1137962
Change-Id: Id19178ecc46231eef71ccb9e16d27e1aafdd1470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468567
Commit-Queue: John Williams <jrw@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824127}

Test coverage for public MessagePort interface and its interactions with
MessagePort::Receiver. Includes conversion to and from the underlying
platform type of MessagePortCast or MessagePortFuchsia.

Bug: 1135377
Test: //components/cast/message_port:message_port_test added
Change-Id: I5e51aa5e08eb1e3e8957963b033497a94fe0bdac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515208
Commit-Queue: Shawn Quereshi <shawnq@google.com>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824126}

TBR=rmcilroy@chromium.org

Bug: 1145641
Change-Id: I73febb2d64caf8c1c8b678f67e50c6102bcf50df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519580Reviewed-by: Sahel Sharify <sahel@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824125}

This CL removes the last references to webprotect.proto in
SafeBrowsingUI, so the proto file and include statements can be removed.

Bug: 1103390
Change-Id: I8a991c5331b052f6438203bc41a9be6487029c22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510791Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824124}

Also move ScopedObservation into the base namespace. It's an
oversight that it wasn't there in the first place.

Change-Id: I854bc0c96af72dff096894cd3b82cd7710f6add3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519271Reviewed-by: Patrick Monette <pmonette@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824123}

Replace VisualRectInLocalSVGCoordinates() with StrokeBoundingBox()
since they are now returning the same value. Drop the out-of-date
comment for the same reason.
This also means that the special treatment of containers can also be
simplified to just consider if the object bounding box is valid.

Bug: 1028061
Change-Id: Ic0bcdc5376f253980dbf2448a5ad6330fea414b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517527Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#824122}

Bug: 1059779
Test: autoninja -C ${OUT} chrome/test/data/webui:closure_compile
Change-Id: I8b6ea9a5290e7d203344fbd42041332dc4a6fc0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514594
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824121}

Since most resources - markers excepted - no longer influence layout, we
can burn down most of SVGLayoutSupport::LayoutResourcesIfNeeded, only
leaving the essential bits (marker layout). Move the remnant of the
function closer to its single user. Move the |is_in_layout_| member
field from LayoutSVGResourceContainer to its LayoutSVGResourceMarker
subclass.

Bug: 1028061, 1028063
Change-Id: I87188dd6673df3b3eba3e5a49deb61669ce9b249
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517501
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824120}

Bug: 772945
Change-Id: If7c1862ff6b88af98be69d09722e3a086bd030e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516251
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824119}

This CL adds standard mapping functions for Sony DualSense Wireless
Controller on Mac, Windows, Linux, and Chrome OS. (No Android
support is included.)

The device has advanced haptics features that are not yet supported.

BUG=1144906

Change-Id: Id2985d18fe426db93e870fcc55351347cb9de78f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515099Reviewed-by: James Hollyer <jameshollyer@chromium.org>
Commit-Queue: Matt Reynolds <mattreynolds@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824118}

https://dawn.googlesource.com/dawn.git/+log/9d6265bc0725..6564890116fd

2020-11-04 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from de6938789ccb to 77f7bb5b005d (18 revisions)
2020-11-04 cwallez@chromium.org Reenable DepthBias tests on Swiftshader
2020-11-04 enga@chromium.org Support sampling depth and stencil of combined d/s formats

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: Ibeba13c6ff83edefd16bfce4c5e10e5912a5c628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519579Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824117}

This CL replaces the following pieces of custom infrastructure with
standardized pieces.

1. A custom callback pump consisting of ScheduleNextTask(), PushNextTask(),
   and TestFinishedUnwound() is replaced by base::RunLoop and
   base::TaskRunner::PostTask().

2. A custom threading setup consisting of a base::test::TaskEnvironment,
   a base::Thread simulating the IO thread, a base::WaitableEvent, and
   TestFinished() is replaced by content::BrowserTaskEnvironment and
   base::RunLoop::QuitClosure().

This CL also moves the following shared methods from the test area to
the shared methods area.

* WriteOneBlock
* WriteOutBlocks
* ReadInBlocks
* ReadOneBlock
* VerifyOneBlock

Last, this CL moves OnReadInfoComplete() from the shared methods area to
the area of the only test that uses it.

The CL leaves the file's overall structure in place, to facilitate
review by offering anchoring points for the diffing algorithm.

The motivation for this refactoring is that the QuotaClient mojofication
benefits from having this test use a content::BrowserTaskEnvironment.

Bug: 1016065
Change-Id: I10945be179fa705b4048011dfda27be3e696d4d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518726Reviewed-by: enne <enne@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824116}

This CL removes confirmation button on Bluetooth disabled screen to
reflect the spec change.

Screenshot: https://screenshot.googleplex.com/zYMuE9QXvJbEDkr.png

BUG=1145315,1106937

Change-Id: I95f6ea75c9ce0b381467d8515a69faabea42057d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518249Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824115}

This CL makes the cache key for an iframe document different from that
of a sub-resource with the same URL, to mitigate the following cache
attack that can happen due to cross site timing leak.

1) Top-level site a.com loads sub-resource a.com/img. The current cache
key for the resource is (a.com, a.com, a.com/img)
2) If an evil.com iframe on the page then iframes a.com/img, the key for
that iframe's navigation resource will also be (a.com, a.com, a.com/img) even though in step 1) a.com/img was a subresource and in step 2) it was an iframe document resource.

Adding a bit to differentiate the 2 cases will help mitigate the attack
so that evil.com cannot time a.com/img onload handler to see if it was
retrieved from the cache. Note that this attack is possible because the
subresource and it's frame are same-site.

Bug: 1135149
Change-Id: Ic1cabdda72657f5cbcc0109da557c538b2a8b143
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487704
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824114}

The WebUI WebContentsObserver wants to report error messages from the
main frame but not subframes. Add the generating frame to
DidAddMessageToConsole and OnDidAddMessageToConsole to allow us to
determine which frame generated each message.

Bug: chromium:1121816

Change-Id: I7a4ab8f4043f6b7df562505a5fd475cb1e206fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518792Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Auto-Submit: Ian Barkley-Yeung <iby@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824113}

Bug: 772945
Change-Id: I51af3cf1070b81f8458dec3a6e28cb1625944dc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518711
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824112}

The onboarding screen has two separate flows that need to be logged
distinctively for metrics.

BUG=1144056,1106937

Change-Id: If36d91a2f734c1f89f49fe2eae500283151ed184
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519155Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824111}

WebGL2Compute was a prototype of a way to run GPU compute workloads on
the Web but is superseded by the WebGPU API being standardized in the
"GPU for the Web" W3C group. Since WebGPU has been available behind a
flag for a while now, we remove the Blink code for WebGL2Compute that's
essentially dead at this point.

This CL:

 - Removes the WebGL2Compute interfaces and canvas context type.
 - Updates some of the common WebGL code to remove WebGL2Compute
   specific code.
 - Removes the --enable-webgl2-compute-context flag.
 - Updates the WebExposed test with the API's removal.

Note that the CL doesn't remove GLES 3.1 support from
//gpu/command_buffer that's still useful for fuzzing ANGLE. In a
follow-up CL the ability to start a GLES 3.1 command buffer will be put
behind a build flag.

Bug: chromium:1131991
Change-Id: Ib43fbda4da7962a7261b8b8eae36c225b666d795
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505795
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824110}

Stop isolating prebuilt ash-chrome because builders have switched to
build ash-chrome from tot.

Bug: 1129223, 1145628
Change-Id: I3d6894e9359473b415ea40d5511541aed89c5b15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519833
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#824109}

The new oncall is sourced from the internal go/rotations tool.

Bug: 1145319
Change-Id: I39a00cfa579408d5a43bdd81c114fa1aaafa992c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517342
Auto-Submit: Joey Scarr <jsca@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824108}

This is a reland of 1c5d9e6d

This test was flaky due to crbug.com/1139541. The previous mitigation
was to skip the first event, but it turns out this was insufficient.
The flakes we were seeing happened at index 5 (i.e., we were failing
to scrape the last trace event from the browser process). In order to
cope with this, I've changed the deflaking logic to accept either
_COMPLETE or _BEGIN, making the test more robust to unclosed intervals.

Original change's description:
> Add activation-related trace events
>
> Adds trace events to HTMLPortalElement::activate,
> RFHI::OnPortalActivated and PortalHost::OnPortalActivate.
> In order to correlate the flow events, a trace id
> is plumbed through activation flow.
>
> Bug: 1137916
> Change-Id: I8841dff33bfeaf91adc58722311672db8aa59210
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439016
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
> Reviewed-by: Lucas Gadani <lfg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#821749}

Bug: 1137916
Change-Id: Ibeb63993d58105a95ec1a1b724baf627bc867eb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511715
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824107}

The OriginTrialPolicy is not setup on the browser process, on Android,
on tests derived from BrowserTestBase.

This is normally done from ContentMain(). This function is not called
here, but reproduced more or less accurately by BrowserTestBase.

To install an OriginTrialPolicy from the ContentClient, this requires
accessing the ContentClient. So this patch is essentially exposing it
through GetContentClientForTesting() and use it.

Fixed: 1123953,1119555
Bug: 1123953,1119555
Change-Id: I403a391a84e8504c80d8df57212f347381d25c30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505979Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824106}

Adds "Scanning for nearby devices..." in place of the share target
list on the discovery page when the list is empty. Needed because
the only other indication on the screen that something is happening
is the animation, which isn't accessible for screen readers.

Bug: b/163036847
Change-Id: I22cf34025727315bd2a02934fdec7ba179b6b169
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490661
Commit-Queue: Curt Clemens <cclem@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#824105}

This change adds links to additional resources on the last page of
the tutorial. A test to confirm correct behavior is also included.

Fixed: 1144857
AX-Relnotes: N/A
Change-Id: Ic7bd8bb1fbe62a69d7e3ad96d8d96675cdaa8ee5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512293Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824104}

The returned object shouldn't be mutable (and cannot be mutated).

Change-Id: I2213472fe99fb64acc95bf8e3e45307bc895b0ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517727
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824103}

https://skia.googlesource.com/skia.git/+log/a8f4c91114b5..3744b2a36638

2020-11-04 johnstiles@google.com Revert "Re-enable -Wdeprecated-copy-dtor."
2020-11-04 herb@google.com move subrun code to anonymous namespace
2020-11-04 kjlubick@google.com [canvaskit] Add option for readPixels to use pre-malloc'd data
2020-11-04 kjlubick@google.com [canvaskit] Add fast pass for saveLayerPaint
2020-11-04 kjlubick@google.com [canvaskit] Properly expose getLineMetrics
2020-11-04 johnstiles@google.com Re-enable -Wdeprecated-copy-dtor.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC bsalomon@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: bsalomon@google.com
Change-Id: Ia098e695f8ccae4ac7ee416fc553eca306ecab5e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519660Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#824102}

Part 2 of enabling closure compiler for scanning browser tests. Focusing on enabling and making sure it compiles, without optimization to tests themselves.

Intentionally omits registration to the main target webui:closure_compile (to be enabled later).

chrome/test/data/webui:closure_compile

Bug: 1059779
Test: browser_tests --gtest_filter=Scanning* && autoninja -C ${out}
Change-Id: I48f06cfd6776ce6cf3583e7ba2005edce8be0d7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513688
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824101}

This feature is no longer used because it was removed in
crrev.com/a361ec8e part of the flash removal. These testing APIs
can be now removed.

BUG=1143755

Change-Id: I2b4189afb56a8bb16636be198ca258b6d7fc2024
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517379Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824100}

Change-Id: Ifa16441b5010f575bf85cc69b295a801356b4af9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518393
Auto-Submit: Jon Mann <jonmann@chromium.org>
Reviewed-by: Azeem Arshad <azeemarshad@chromium.org>
Commit-Queue: Azeem Arshad <azeemarshad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824099}

The polyfil was added 4 years ago at r403715. It is now supported by
iOS Safari for quite a few versions (10.3+), based on [1]

[1] https://caniuse.com/?search=KeyboardEvent.Key

Bug: None
Change-Id: I7e16c08b5f18f70342d69c270da4ec2f8a96aacd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509929Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824098}

Bug: 1136565
Bug: 1123673
Change-Id: I8804f8057b58464bb380366aa3d5baeb2a2ab160
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518300
Commit-Queue: Gary Tong <gatong@chromium.org>
Auto-Submit: Gary Tong <gatong@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824097}

This reverts commit 8e01fd97.

Reason for revert: crashing in WebView tests https://crbug.com/1145636

Original change's description:
> [cc/metrics] Introduce FrameSorter.
>
> The begin-frames do not always terminate in the same order as they
> start. For example, a frame that does not have any updates can terminate
> earlier than a previous frame that had an update and is awaiting
> presentation. This can make it tricky to measure dropped-frames in a
> sliding window. To make this easier, introduce a FrameSorter, that makes
> sure the sliding-window can process the frames in order, regardless of
> when they are terminated.
>
> BUG=1138552
>
> Change-Id: I2ae0e2413d64d0242aa3ba57f9d1b3d2c1f4354e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441202
> Reviewed-by: Jonathan Ross <jonross@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#822737}

TBR=sadrul@chromium.org,jonross@chromium.org,behdadb@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1138552
Bug: 1145636
Change-Id: I332b00355b258585f5447d0c2b4c0fea8b0a1e56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519717Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824096}

Temporarily using some untranslated English strings for this. When real
strings are nailed down and ready to be translated, will go back to the
{command_id, string_id} table this CL is replacing.

Bug: 1014639
Change-Id: I520ccd5f38f7a2d5d8877161093e92515b766b9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518911Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824095}

Implements more ReadingListModelObserver methods. When sync happens, we
need to sync the in-memory bookmark tree.

Bug: 1133504
Change-Id: I87f7c9ec0f52a73b436d3b44eb8bd3278cda78ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518774Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824094}

The synthethized clip layer should use the current transform instead of
the clip rect's transform.

Bug: 1144473
Change-Id: I6cd7457706d6b82b043a0b4bf20863a8a698d521
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515206
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824093}

This patch adds the infrastructure necessary to display a sign-in
notification following a Gaia cookie restoration event.

Bug: 1145592
Change-Id: Ibbc704a3043ffc8c896e604fd319281100e3149a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519457
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#824092}