GitLab

Before, it used local_ntp_browsertest.html instead, for no good reason.

Bug: 788166
Change-Id: Iba4fe5c06eab1bc9fafebe6f528955c208c24359
Reviewed-on: https://chromium-review.googlesource.com/787897Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519737}

mUseLightColorAssets could be null, which can cause IPH crashes on
tablets if called before it is set.  This just protects against the
value not being ready.

BUG=778033

Change-Id: I057178d966d44ee1d755241be919d48e1e324e37
Reviewed-on: https://chromium-review.googlesource.com/779864
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519736}

Applies the same fix from https://chromium-review.googlesource.com/c/chromium/src/+/783150
to vr_common_perftests, as it is failing for the same reason the
unittests were previously.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I855ce021db6ef8ab83565b7b2ccccd64ebc4b785
Reviewed-on: https://chromium-review.googlesource.com/792391Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519735}

https://chromium.googlesource.com/angle/angle.git/+log/0b684ce3c9f5..df68ca50b310

$ git log 0b684ce3c..df68ca50b --date=short --no-merges --format='%ad %ae %s'
2017-11-27 geofflang Add missing break in StateManagerGL::syncState.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: Ica92fbdbd27167dc47e4e4a1260be121611bbabd
Reviewed-on: https://chromium-review.googlesource.com/794050Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519734}

This reverts commit cc9fb229.

Reason for revert: breaks ios_chrome_settings_egtests

Original change's description:
> [signin] Dice migration: Clear LST tokens when gaia cookies are cleared
> 
> This CL adds ShouldReconcileAccount() function on the
> DiceAccountReconcilor delegate, that is used to revoke the tokens when
> cookies are empty.
> 
> As a cleanup, the chrome_account_ member is changed to a local variable,
> to reduce the amount of state in the AccountReconcilor, making it
> hopefully more readable.
> 
> Bug: 788315
> Change-Id: Id4348a6ae2e524de721d39c84cb4e150adb892b2
> Reviewed-on: https://chromium-review.googlesource.com/789032
> Commit-Queue: David Roger <droger@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519697}

TBR=droger@chromium.org,msarda@chromium.org

Change-Id: I523e02e242bbb48fb978528c4789f73ce562dd28
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 788315
Reviewed-on: https://chromium-review.googlesource.com/794111Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519733}

The WebRTC chromium bots need sound cards, and the drivers for those
sound cards inject themselves into the COM stack, which triggers a
CHECK chromium does to detect precisely this. Therefore, disable
this check on these particular builders.

We will aim to get rid of the sound cards and simplify the tests
in Q1, so hopefully this is just temporary.

Depends on crrev.com/c/753591.

Bug: 737090
Change-Id: I6cc5603e345b0d8b8866b97abfd3db8d4e94e7eb
Reviewed-on: https://chromium-review.googlesource.com/753728Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519732}

To reduce modifications to SecurityContext's SecurityOrigin and
make it easier to make SecurityContext's SecurityOrigin const.
No behavior changes are expected.

Bug: 779730
Change-Id: I64ea74543c989716b6d80ff249489dddb9ace5d1
Reviewed-on: https://chromium-review.googlesource.com/762142
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519731}

This reverts commit cc9fb229.

Reason for revert: This seems to have broken ios_chrome_settings_egtests (iPad Air 2 iOS 10.0) failing on chromium.mac/ios-simulator-full-configs

The AccountCollectionsTestCase/testMDMError test is failing.

See https://uberchromegw.corp.google.com/i/chromium.mac/builders/ios-simulator-full-configs.

Original change's description:
> [signin] Dice migration: Clear LST tokens when gaia cookies are cleared
> 
> This CL adds ShouldReconcileAccount() function on the
> DiceAccountReconcilor delegate, that is used to revoke the tokens when
> cookies are empty.
> 
> As a cleanup, the chrome_account_ member is changed to a local variable,
> to reduce the amount of state in the AccountReconcilor, making it
> hopefully more readable.
> 
> Bug: 788315
> Change-Id: Id4348a6ae2e524de721d39c84cb4e150adb892b2
> Reviewed-on: https://chromium-review.googlesource.com/789032
> Commit-Queue: David Roger <droger@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519697}

TBR=droger@chromium.org,msarda@chromium.org

Change-Id: If4f5e30f574365d1cf7d58e4ca1c41889fa1b0bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 788315
Reviewed-on: https://chromium-review.googlesource.com/794250Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519730}

Do not match capabilities again since it
has been done in ServiceWorkerPaymentAppFactory.

Note that, the capability related matching tests
for getInstruments is not applicable anymore, so
they have been modified to test matching modifiers
which use the same matching rules.

Bug: 777470
Change-Id: Ib01ad930b48b2ab5e78b13aa5b73c1e1fa4cf645
Reviewed-on: https://chromium-review.googlesource.com/788452Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519729}

CL is a first step to untangle ENABLE_MUS from OS_CHROMEOS.

This does not change any ChromeOS behavior, since in ui/base/ui_features.gni
there is

  'enable_mus = is_chromeos'

.. but makes it easier to run Mus on non-ChromeOS builds.

BUG=789043

Change-Id: I0febf99ee8352af9f39c4e3411864e0a1baf3460
Reviewed-on: https://chromium-review.googlesource.com/793952Reviewed-by: Maksim Sisov <msisov@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#519728}

This is a reland of f12be75c
Original change's description:
> Add a utility to format a base::debug::StackTrace for CrashKeyString.
>
> Bug: 598854
> Change-Id: Ie92935f4919e57cae338c33750458c0509a93627
> Reviewed-on: https://chromium-review.googlesource.com/782040
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#518381}

Bug: 598854, 787669
Change-Id: I81fef0cba08240ee288d4e3db3c3bcf4ff130219
Reviewed-on: https://chromium-review.googlesource.com/793930Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519727}

This removes instant_url, search_terms_replacement_key, and
instant_url_post_params from SearchEngineSpecifics.

Bug: 476079
Change-Id: Ib0bed32ba21e11cc90e44234a6c321d97a02522b
Reviewed-on: https://chromium-review.googlesource.com/785910Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519726}

This aligns animations with virtual time progression when
the CompositorController is used to issue BeginFrames.

Also updates VirtualTimeController to use TimeDeltas instead
of millisecond ints and initializes BeginFrameArgs frame_time
to its minimum value by default to support emulated negative
base::TimeTicks values in continuity DCHECKS throughout the
compositor code.

Bug: 646774
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ia28ab131dd1a327907f8570a1f26ce794208d3d4
Reviewed-on: https://chromium-review.googlesource.com/790910
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519725}

WebView should not post onReceivedError when shouldOverrideUrlLoading
returns true for invalid url schemes - with PlzNavigate we do post
onReceivedError when the url checked is a server redirect.
This CL fixes that issue by calling shouldOverrideUrlLoading before
verifying that the scheme of the new target url in the redirect is
valid.

Note: if the url is overridden we still update the state of the
navigation handle to point to the new url, this is to ensure the WebView
(Aw)WebContentsObserver sees the new url.

BUG=788775

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I4ad36e3ae3feaa39a00024282752c02bbe88bd6f
Reviewed-on: https://chromium-review.googlesource.com/790993
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519724}

This CL measures top level UI synchronization duration for both the existing
CompositorResizeLock code path and the new surface synchronization code path.

Bug: 672962
Change-Id: I069e6ad7207722ccda8d80c791b8604ec8bb6335
Reviewed-on: https://chromium-review.googlesource.com/792213
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519723}

This reverts commit add87b2d.

Reason for revert:
This CL was correcting for an issue with the API function in PDFium.
https://pdfium-review.googlesource.com/c/pdfium/+/19350 corrects this
issue in PDFium, so this attempted work around is no longer needed. Once
the PDFium side change lands and is rolled into Chrome this will need to
be landed.

Original change's description:
> Account for string terminator added to FPDFText_GetText strings
>
> The documentation for this function in PDFium explictly calls out that
> the caller needs to pass in a buffer that is number of characters
> desired + 1, to account for the terminator.
>
> The existing implementation does not correctly do this, grabbing count
> characters instead of count - 1 characters. This causes the written
> out string to be count + 1 long due to an added terminator. The
> corrected implementation cannot be rolled in current, since it causes
> the strings being returned to be shorter then expected.
>
> This CL changes the call sites in Chrome to follow the documentated
> behaviour, which works correctly with both the old and new
> implementation of the function. For the old implementation it will
> overallocate by 1, and for the for the new implementation the
> allocation size will be correct.
>
> BUG=chromium:761770,chromium:761626
>
> Change-Id: I874a88d854c2c85c28847ade3d74bcce56d6a876
> Reviewed-on: https://chromium-review.googlesource.com/650650
> Reviewed-by: dsinclair <dsinclair@chromium.org>
> Commit-Queue: Ryan Harrison <rharrison@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#499732}

TBR=rharrison@chromium.org,dsinclair@chromium.org,paulmeyer@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:761770, chromium:761626
Change-Id: Ic608ced5dcf662369e4695118c28794ad3873255
Reviewed-on: https://chromium-review.googlesource.com/788430Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Paul Meyer <paulmeyer@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519722}

This reverts commit 8d71ca83.

Reason for revert: Missed existence of filesystem.mojom.FileError

Original change's description:
> Added a Mojo equivalent to base::File::Error.
> 
> mojo.common.mojom.FileError is the Mojo version of the base::File::Error
> enumeration.
> 
> Added enum traits for base::File::Error ↔ mojo::common::mojom::FileError.
> 
> Bug: 787281
> Change-Id: I12075ed19fd412d0f92b0eccef66ba3832261d8b
> Reviewed-on: https://chromium-review.googlesource.com/786266
> Commit-Queue: Chris Mumford <cmumford@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Oliver Chang <ochang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519407}

TBR=jam@chromium.org,cmumford@chromium.org,ochang@chromium.org

Change-Id: I10ec724c00a3022ef177f4ded3268f0e892c1a69
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 787281
Reviewed-on: https://chromium-review.googlesource.com/794153Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519721}

To properly render the reticle, it needs to be drawn on the element it
is hitting, rather than last in the scene (otherwise, translucent
un-hittable elements may appear to have the reticle instead).  In the
future, we may transition to drawing the reticle last, always, for
simplicity.

However, if we don't do that, we need a way to have the reticle appear
properly on top of composite UI elements - elements made up of
sub-elements in a plane.  Without this change, something like a button
backplane may have the reticle, but portions of the reticle may appear
under a different button foreground element even though it's on the same
plane.  With this change, we traverse the hit element's subtree, and
draw the reticle after the last planar, visible child instead.  This
way, it's guaranteed to render on top of the composed element, unless
the element has hittable children floating in front.

BUG=
R=mthiesse, vollick

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I33a1aef392901b74e3b5814338a4e4c5fb58eac9
Reviewed-on: https://chromium-review.googlesource.com/791151
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519720}

This is a followup to crrev.com/519345, where the disabling was not done
properly for AsyncResourceHandlerBrowserTest. Apologies.

TBR=xhwang@chromium.org,csharrison@chromium.org

Bug: 788748
Change-Id: Ia5397e830a821e6a7f6408416ec6b86da7589947
Reviewed-on: https://chromium-review.googlesource.com/794131Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519719}

Bug: 779590
Change-Id: Ie2897ca6de11a4a84c0b54eb3937b355b46a0f33
Reviewed-on: https://chromium-review.googlesource.com/789536
Commit-Queue: Biao She <bshe@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519718}

mus can delegate managing the gfx::AcceleratedWidget it creates to the
window manager. The window manager (i.e. ash/aura) in this case needs to
support injecting this AcceleratedWidget into its compositor.

BUG=786453

Change-Id: If9de911ab70e84e750728b0b46a8d4470c1e7da8
Reviewed-on: https://chromium-review.googlesource.com/792272Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519717}

This reverts commit 676ba628.

Reason for revert: This breaks archive_webkit_tests

Original change's description:
> Re^3 land Add UKM Document.OutliveTimeAfterShutdown
> 
> This CL is the third trial to add the UKM Document.
> OutliveTimeAfterShutdown. This CL uses the existing Document::
> UKMRecorder() and avoids requesting from content renderer to content
> browser. Actually, I have confirmed that this CL doesn't emit the
> problematic log "Connection InterfaceProviderSpec prevented service:
> content_renderer from binding interface: ukm::mojom::UkmRecorderInterface
> exposed by: content_browser" on my local machine.
> 
> This CL adds a new UKM Document.OutliveTimeAfterShutdown, that is
> recorded when a Document object survives 5, 10, 20 or 50 garbage
> collections after detached. If a document outlives such long time, the
> document might be leaked. The UKM would be very useful to know where such
> leaky documents exist and to fix them.
> 
> Design doc: https://docs.google.com/document/d/1fbs5smdd-pBLLMpq7u8EkyddZILtI7CZPJlo_AA1kak/edit?usp=sharing
> 
> Bug: 757374
> Change-Id: I4615f170626faab7151444b4a898c40761fbb6e1
> Reviewed-on: https://chromium-review.googlesource.com/763187
> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
> Reviewed-by: Steven Holte <holte@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519618}

TBR=hajimehoshi@chromium.org,haraken@chromium.org,holte@chromium.org

Change-Id: I29014cd0266fe2f8d7c0137c3a1c5a8d419c5505
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 757374
Reviewed-on: https://chromium-review.googlesource.com/794152Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Katie Thomas <katthomas@google.com>
Cr-Commit-Position: refs/heads/master@{#519716}

https://pdfium.googlesource.com/pdfium.git/+log/e82af1a845c1..fee749f0a141

$ git log e82af1a84..fee749f0a --date=short --no-merges --format='%ad %ae %s'
2017-11-28 npm Fix PDF fuzzers memory limit

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I1eb49bbcf90ec2e9186cf3103fa43750278c615d
Reviewed-on: https://chromium-review.googlesource.com/793890
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519715}

This CL updates callers of blink::Timer::StartRepeating around the caret
blink preference to use TimeDelta as the time type. Plus, this updates
all call path toward it to use TimeDelta instead of double.

Change-Id: I520e4707dff69a75ed1a0f6b1a198c26d79ed9da
Reviewed-on: https://chromium-review.googlesource.com/784674Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519714}

AutofillInteractiveTest::PopulateForm has flaky timeouts on CrOS.

BUG=516052
TBR=estade@chromium.org

Change-Id: I40c3cfaf2a73488fe309e301d7c58317062cd440
Reviewed-on: https://chromium-review.googlesource.com/794130Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519713}

As SSE and AVX optimizations are quite similar, the new file can be
modified to be useful also for AVX optimizations with altered
preprocessor logic.

This is a preparation for AVX optimization of VectorMath functions.

Bug: 778262
Change-Id: Ic9540e1a17b090020e789db1ca5126ffe141b044
Reviewed-on: https://chromium-review.googlesource.com/738241
Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519712}

...and clarify how the process works. One should get privacy review
on their proposal first, and then code review for the actual
implementation.

The privacy review should not be done on the CL, and the privacy team
can't comment on the technical aspects of the implementation.

Bug: None
Change-Id: Ic5f0c848b9cf2a89c04e2e3e05775bbcb8d624be
Reviewed-on: https://chromium-review.googlesource.com/793731Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519711}

Android is the only Chrome platform that takes into account the alpha
channel. This value is used for CSS Media Queries and Screen object on
the Web Platform.

Bug: 788329
Change-Id: I9f3f20db1b00fcf8fbf2588f23785b695deb6546
Reviewed-on: https://chromium-review.googlesource.com/789333
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519710}

This reverts commit 99a1c15f.

Reason for revert: Build fails on arm64-unpublished-builder and arm64-unpublished-builder-rel. The path to zipalgn updated in the new SDK. See http://crbug.com/789177

Bug: 789177

Original change's description:
> Roll android SDK to O MR1.
> 
> Bug: 782848
> Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I49f3bf6cf68a9d6d5771d5715d65c742bdbb03a3
> Reviewed-on: https://chromium-review.googlesource.com/784235
> Reviewed-by: Misha Efimov <mef@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Commit-Queue: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#519553}

TBR=yfriedman@chromium.org,wnwen@chromium.org,mef@chromium.org,agrieve@chromium.org,jbudorick@chromium.org

Change-Id: Ib4e12b9b29eae8f41bf2a6a1bf1ae45bab43775e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 782848
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/793733Reviewed-by: Egor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519709}

This is the first CL in a series of CLs to add socket tagging support to
URLRequests.  This CL adds the SocketTag class that will be passed
through the net/ stack and applied to sockets used to process URLRequests.
More information can be found in this Intent to Implement:
https://docs.google.com/document/d/10e0B_vdysMS-_lJNh-A80fEnEDMKAhR3W0dxTRfhVO0/edit?usp=sharing

Bug: 520198
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1331eea1cb3727e78cb108226b3447aa47d12801
Reviewed-on: https://chromium-review.googlesource.com/772313
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519708}

The test class does not turn on the controls which forces most tests to
do it. Having them on would match expectations.

Bug: 708980
Change-Id: Ia81e5d27cef30709d01943b2791fe874db0a438f
Reviewed-on: https://chromium-review.googlesource.com/776718
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519707}

This reverts commit 358ed727.

Reason for revert:  Speculative fix didn't fix crashes. See bug for details.

Original change's description:
> Define toolbar button height and width in-line instead of in styles.xml
> 
> Define the layout_height and layout_width for ToolbarButton elements
> in-line rather than in styles.xml. This is a speculative fix for crash
> reports we've received indicating these attributes are missing.
> 
> BUG=779271
> 
> Change-Id: I732ee9b39262aa8bfbc74dea57ea72469cd9e647
> Reviewed-on: https://chromium-review.googlesource.com/764378
> Commit-Queue: Theresa <twellington@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#515966}

TBR=tedchoc@chromium.org,twellington@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 779271
Change-Id: I60d3e400fc77f51c098ebb282e6d037f8242fb9c
Reviewed-on: https://chromium-review.googlesource.com/794011Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519706}

https://skia.googlesource.com/skia.git/+log/7f1b4f8cc39c..9f553932a4a4

$ git log 7f1b4f8cc..9f553932a --date=short --no-merges --format='%ad %ae %s'
2017-11-27 benjaminwagner Switch Coverage GPU bot to Golo.
2017-11-28 kjlubick Don't scale CPU for internal bots

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=allanmac@chromium.org

Change-Id: I4b0008a6552154367c12e06cb09d09fdf498b0db
Reviewed-on: https://chromium-review.googlesource.com/793670Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519705}

For now, this will make little difference, but once the local NTP is
used by default, we'll avoid re-parsing the search provider's NTP URL
twice each time.

Bug: 786035
Change-Id: Ifa7e5095cee881caa943d1308b798cd39b962de6
Reviewed-on: https://chromium-review.googlesource.com/793151Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519704}

https://webrtc.googlesource.com/src.git/+log/2492984441a3..e9619f8f81de

$ git log 249298444..e9619f8f8 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ic09a6f6a1ae2b5229eba1a2ae7786b24542b1e29
Reviewed-on: https://chromium-review.googlesource.com/793770Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519703}

The root view controller is briefly visible during cold start, so give it a
white background to make it look more similar to the splash screen.  This helps
avoid a noticeable flicker of black at startup.

BUG=788746

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic107c831a122caece7efc709bcde008a8ba7edcc
Reviewed-on: https://chromium-review.googlesource.com/791158
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519702}

When a hosted app URL also corresponds to an isolated origin, the
isolated origin takes precedence, and the corresponding SiteInstance
won't use the effective URL for the hosted app.  However, this logic
needs to exclude CWS, which still needs to resolve to its effective
URL, so that the corresponding process ends up in the ProcessMap for
the CWS extension ID.  Otherwise, security checks such as CanCommitURL
won't allow CWS navigations to succeed.

Bug: 788837
Change-Id: I2b8d03d044e72bb9b8f71cb4c3accfba8d907ac4
Reviewed-on: https://chromium-review.googlesource.com/792596Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519701}

This introduces the concept of invocation type, which decides if
a reporter run should start immediately (if started by the user),
and if logs are allowed or disallowed by the user.

This also deprecates behaviour BEHAVIOUR_ALLOW_SEND_REPORTER_LOGS,
which should no longer be enabled by the reporter component
manifest.

To be sent in follow-up CLs:
 - cleaner logs from the scanner process based on user selection;
 - UMA histograms for the new flow;
 - UI changes to enable the new invocation type.

Bug: 776538
Change-Id: I0093826b450dd29625ac22ae5939d932bb04bb86
Reviewed-on: https://chromium-review.googlesource.com/770050Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519700}

MockOverscrollControllerImpl in browser_tests inherits from
OverscrollController in content/browser, but the class was
not exported, causing a build failure with is_component_build.

Change-Id: I9e3b893a23243e292fa94cc4441821631dafcca2
Reviewed-on: https://chromium-review.googlesource.com/788213Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Cr-Commit-Position: refs/heads/master@{#519699}

This class is responsible for cross-platform logic for exporting
passwords.

Bug: 785237
Change-Id: Idc3f77f66ba6211324d82415bb9d42328823b7e5
Reviewed-on: https://chromium-review.googlesource.com/782722
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519698}