- 25 Mar, 2015 40 commits
-
-
jdduke authored
This change was reverted in r322170 due to WebView breakage. The ApplicationStatus dependency has been made optional, allowing WebView to opt-out of its use. Original description: ---------------------------- Currently, when an activity is stopped, we explicitly hide the foreground Tab. This is problematic, as current hiding semantics might clear the visual front buffer before the window is hidden. This in turn causes an unpleasant flickering during activity transitions, e.g., when backgrounding Chrome or locking the screen. Wire Activity onPause/onResume notifications to WindowAndroidObservers, allowing the foreground tab to preserve its front buffer while hiding its web content. If the tab is explicitly hidden, or the root window is lost, the front buffer will be cleared as usual. BUG=462752,434401 Review URL: https://codereview.chromium.org/1001573003 Cr-Commit-Position: refs/heads/master@{#322228}
-
anandc authored
BUG=470158 Review URL: https://codereview.chromium.org/1031213002 Cr-Commit-Position: refs/heads/master@{#322227}
-
tfarina authored
It is more traditional (and recommended) to have GN targets closer to the source files it builds. BUG=432959 TEST=gn gen out-gn && ninja -C out-gn compositor_model_bench R=sievers@chromium.org, dpranke@chromium.org Review URL: https://codereview.chromium.org/1032193002 Cr-Commit-Position: refs/heads/master@{#322226}
-
ananta authored
Proposed fix is to discard all unsupported representations (Read fractional scales) in the Extension icon image when the icon is loaded. This ensures that stale caches are invalidated and the correct icons are loaded when the cache is regenerated. BUG=461958 Review URL: https://codereview.chromium.org/1025513004 Cr-Commit-Position: refs/heads/master@{#322225}
-
earthdok authored
Too flaky. BUG=468980 TBR=hirono@chromium.org Review URL: https://codereview.chromium.org/1034813002 Cr-Commit-Position: refs/heads/master@{#322224}
-
xiyuan authored
- Update ProfileAuthData to transfer cookie from sign-in webview; - Passing back usingSAML flag for auth code authentication and use it to set has_auth_cookie flag when SAML is used; - Update UserCloudPolicyManagerChromeOS to fetch initial policy from correct auth request context; - Enable SAMLPolicyTest for WebView; BUG=461505 Review URL: https://codereview.chromium.org/1021383002 Cr-Commit-Position: refs/heads/master@{#322223}
-
rouslan authored
This re-enables spellcheck feedback by reverting commit http://crrev.com/60f701a, because the server is ready to process the feedback. BUG=466794 Review URL: https://codereview.chromium.org/1006953003 Cr-Commit-Position: refs/heads/master@{#322222}
-
holte authored
BUG=410493 Review URL: https://codereview.chromium.org/993813002 Cr-Commit-Position: refs/heads/master@{#322221}
-
danakj authored
This makes the CullSet check into an early out instead of an if-block wrapping a whole function. It also moves the |visible_| early out to the same place from PaintCommon(). This hints at combining Paint() and PaintCommont(). This also moves the |visible_| early out to the other caller of PaintCommon() which is OnPaintLayer(), and can early out before doing the solid color clear. BUG=466426 Review URL: https://codereview.chromium.org/1037513002 Cr-Commit-Position: refs/heads/master@{#322220}
-
sandersd authored
BUG=442586,460616 Review URL: https://codereview.chromium.org/1005903003 Cr-Commit-Position: refs/heads/master@{#322219}
-
sky authored
I want to keep around a MotionEventGeneric and mutate it over time. Since this class is an implementation detail (public API takes MotionEvent) it seems fine to allow consumers of it to mutate it directly. BUG=none TEST=covered by test R=tdresser@chromium.org Review URL: https://codereview.chromium.org/1035793003 Cr-Commit-Position: refs/heads/master@{#322218}
-
jeremyim authored
- Permit DRP RequestOptions to take auth credentials instead of always internally generating them. - Permit DRP Config to perform a reload of the configuration - Create a new DRP MutableConfigValues class which can have its underlying values updated. - Add a configuration refresh timer to DRP ConfigServiceClient, along with backoff logic. BUG=466753 Review URL: https://codereview.chromium.org/1024553009 Cr-Commit-Position: refs/heads/master@{#322217}
-
bnc authored
Add field trial parameters for independently enabling SPDY/3.1, HTTP/2 draft-14, and HTTP/2 protocols. Add a field trial group prefix to trigger parsing parameters, so that behavior of current field trial groups is preserved. Refactor SPDY parameter parsing code to make it similar to QUIC code, also in tests. Write tests for new functionality, for default behavior, and for command line parsing. BUG=469181 Review URL: https://codereview.chromium.org/1020363003 Cr-Commit-Position: refs/heads/master@{#322216}
-
rtenneti authored
Populate slowstart numbers in stats. Merge internal change: 89048638 https://codereview.chromium.org/1030083002/ Add a QUIC connection option(BWMX) to resume to the max bandwidth instead of the last. Merge internal change: 89046643 https://codereview.chromium.org/1037633002/ Populate RTT info in TransportConnectionStats. Moved RttStatsPeer class into a separate file. Merge internal change: 89043159 https://codereview.chromium.org/1009633003/ Deprecate FLAGS_quic_enable_bandwidth_resumption_experiment. Merge internal change: 89021133 https://codereview.chromium.org/1032483003/ Add an extra newline after "Response:" in quic_client's output. Merge internal change: 88898832 https://codereview.chromium.org/1019793009/ QUIC - small formatting changes to keep code in sync with internal source. Merge internal change: 88795283 https://codereview.chromium.org/1037623002/ Low-impact. Dispatcher now uses QuicServerSession, not QuicSession This is a preparatory step for a group of upcoming changes with regards to Stateless Rejects. For stateless rejects, we'd like the dispatcher to access QuicServerSession server-specific information within the session. In order to do that, we need the dispatcher to contain a QuicServerSession object, rather than just a generic QuicSession object. Merge internal change: 88758328 https://codereview.chromium.org/1028633006/ Limit QUIC's send algorithm max CWND by the peer's receive buffer and disable usage of the receive buffer in QuicSentPacketManager. Flag protected by FLAGS_quic_limit_max_cwnd_to_receive_buffer. Merge internal change: 88747441 https://codereview.chromium.org/1023203004/ Improve tests. Correct things clang_tidy complains about. Make QuicTimeWaitListManager::AddConnectionIdToTimeWait virtual so it can be mocked. Correct things clang_tidy complains about. Make a method virtual so it can be mocked. Merge internal change: 88744988 https://codereview.chromium.org/1029463003/ R=rch@chromium.org Review URL: https://codereview.chromium.org/1037643002 Cr-Commit-Position: refs/heads/master@{#322215}
-
danakj authored
We can then merge Paint and PaintCommon. Subclasses should use OnPaint to override display behaviour. R=sky BUG=466426 Review URL: https://codereview.chromium.org/1029943002 Cr-Commit-Position: refs/heads/master@{#322214}
-
dschuff authored
This pulls in the following Native Client changes: a019a57: (dschuff@chromium.org) Update revision for PNaCl bac8dffa: (stichnot@chromium.org) Add pnacl-translate --sz flag to enable Subzero. 81b0050: (mtrofin@chromium.org) Enable using the toolchain (llvm) provided FileCheck. 3ce68ce: (sbc@chromium.org) Cleanup .gitignore file 7a7bed5: (shinyak@chromium.org) FixPath in CheckObjectSize. 26f4998: (sbc@chromium.org) Remove legacy prep_nacl_sdk.py script 2aa5524: (mtrofin@chromium.org) Updated component revisions. 2d8b0bb: (dschuff@chromium.org) Add lint check for IRT sandbox base address hiding. Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/cc3597c9c13978079ef85a31d78dc4bf7f18000c..2d8b0bb6ffaf871fdc1f902d38778b2df8c6ff0d BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build Review URL: https://codereview.chromium.org/1030213002 Cr-Commit-Position: refs/heads/master@{#322213}
-
rdevlin.cronin authored
Field trials can only be initialized once, so the FactoryGet() method cannot be called each time to check the value of the trial. BUG=470278 Review URL: https://codereview.chromium.org/1023673011 Cr-Commit-Position: refs/heads/master@{#322212}
-
dtu authored
As part of the Telemetry public API refactor, I wrote a tool that sorts imports. The tool will be checked in separately, but here's all the import changes in Telemetry and its dependencies. It'll be easier to test the refactor tool if we do the import sorting in advance, so it doesn't clutter the diffs for the module moves. Style guide rule: "Within each grouping, imports should be sorted lexicographically, ignoring case, according to each module's full package path." BUG=449308 TEST=trybots (tools/telemetry/run_tests; tools/perf/run_tests) Review URL: https://codereview.chromium.org/1029263003 Cr-Commit-Position: refs/heads/master@{#322211}
-
Elliot Glaysher authored
This reverts committ: https://crrev.com/ebbf3c1bf5f41b0133657515302e3b110abedee1 Broke on the Win8 gn bot which doesn't appear to be in the CQ and treats signedness of characters differently than all other configurations. BUG=467176 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1012773009 Cr-Commit-Position: refs/heads/master@{#322210}
-
pcc authored
This saves us from having to build app_mode_common.mm twice, and works around an LTO bug on Mac. BUG=469377 R=jam@chromium.org,jackhou@chromium.org Review URL: https://codereview.chromium.org/1026833004 Cr-Commit-Position: refs/heads/master@{#322209}
-
groakley authored
Adds @UsedByReflection to the CronetUrlRequestContext constructor. This is necessary for UrlRequestContext to instantiate this class after proguarding. BUG= Review URL: https://codereview.chromium.org/1018213007 Cr-Commit-Position: refs/heads/master@{#322208}
-
reveman authored
This cleans up the API a bit and allows the code to be unit tested. This also prevents ftruncate from being used on Android where shared memory is backed by Ashmem. Ashmem doesn't support ftruncate. BUG=466509 TEST=base_unittests --gtest_filter=DiscardableSharedMemoryTest.Shrink Review URL: https://codereview.chromium.org/1018743003 Cr-Commit-Position: refs/heads/master@{#322207}
-
maruel authored
$ git log b61a1802f..53ef01328 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//' 2015-03-20 phajdan.jr Add support for writing swarming.py query results to a file 2015-03-17 maruel Do not throw if the json file is missing or invalid. 2015-03-16 maruel Fix regression from 3c979cb54e which broke run_on_bots.py. 2015-03-13 maruel Handle race condition in terminate(). 2015-03-13 maruel Change subprocess42 maxsize and timeouts arguments to be callable. 2015-03-11 maruel Switch most paths to be unicode and enforce it. 2015-03-10 cmassaro Switching from /content-gs/ to Endpoints API. R=phajdan.jr@chromium.org BUG= Review URL: https://codereview.chromium.org/1028693003 Cr-Commit-Position: refs/heads/master@{#322206}
-
changwan authored
BUG=470116 Review URL: https://codereview.chromium.org/1035603002 Cr-Commit-Position: refs/heads/master@{#322205}
-
stevenjb authored
BUG=433984 For: extensions/common/api/networking_private.json third_party/closure_compiler/externs/chrome_extensions.js TBR=jamescook@chromium.org,dbeam@chromium.org Review URL: https://codereview.chromium.org/987963002 Cr-Commit-Position: refs/heads/master@{#322204}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/6c126cd..7dd2b95 TBR=jchaffraix@chromium.org,loislo@chromium.org Review URL: https://codereview.chromium.org/1029263009 Cr-Commit-Position: refs/heads/master@{#322203}
-
davidben authored
This matches WorkerTest.SharedWorkerTlsClientAuth and inline disables make it clearer a subset of the tests don't run on some platforms. BUG=none Review URL: https://codereview.chromium.org/1032033003 Cr-Commit-Position: refs/heads/master@{#322202}
-
erg authored
Now that the image resources that blink depends on are in the blink repository, we depend on the blink resources directly, delete the ones in the chrome tree, and use these resources in the html_viewer. BUG=467176 Review URL: https://codereview.chromium.org/1033733004 Cr-Commit-Position: refs/heads/master@{#322201}
-
avayvod authored
BUG=None Review URL: https://codereview.chromium.org/1033733007 Cr-Commit-Position: refs/heads/master@{#322200}
-
reveman authored
BUG=470091 Review URL: https://codereview.chromium.org/1031163002 Cr-Commit-Position: refs/heads/master@{#322199}
-
sebmarchand authored
It doesn't change anything to the current official build configuration ! 'size' is already the default value for the 'optimize' variable (https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&l=5411), but we override this value when doing a PGO build, so this is just preventing the mini_installer from being PGO optimized. BUG=309849 Review URL: https://codereview.chromium.org/1037793004 Cr-Commit-Position: refs/heads/master@{#322198}
-
smckay authored
Include certain qualifications in the view names reported to analytics, like 'with-media-dir', or the FSP provider extension id. Background: Note there was a potential race condition relating to sendAppView and other events. In order to qualify events by view, we needed to be certain to send appView before any other activity that might be kicked off by a directory change event (like importing). BUG=None TEST=manual Review URL: https://codereview.chromium.org/1022423005 Cr-Commit-Position: refs/heads/master@{#322197}
-
brettw authored
Previously the condition was reversed. We can only do incremental linking when symbols are disabled. I was hoping it would work for minimal symbols but I tested and it still fails. This patch only does incremental linking when symbols are completely disabled. Review URL: https://codereview.chromium.org/1027543003 Cr-Commit-Position: refs/heads/master@{#322196}
-
rockot authored
BUG= TBR=jamesr@chromium.org Review URL: https://codereview.chromium.org/1032143003 Cr-Commit-Position: refs/heads/master@{#322195}
-
dfalcantara authored
BUG=465201 TBR=cjhopman Review URL: https://codereview.chromium.org/1032203002 Cr-Commit-Position: refs/heads/master@{#322194}
-
dbeam authored
There was an unfortunate bug that swallowed Java stacks. Issues were discovered when Java stacks started surfacing: https://codereview.chromium.org/476453002/ So change the way remoting is built. It doesn't need to be built on all bots by default: they have undefined Java versions and likely weren't working before (and shouldn't differ). Instead, run when run_jscompile=1 is defined in GYP: export GYP_DEFINES=run_jscompile=1 && build/gyp_chromium # or add in ~/.gyp/includes.gypi or $SRC/../chromium.gyp_env # or build/gyp_chromium -Drun_jscompile=1 and on the Closure Compilation Linux FYI bot: http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux This also fixes some GYP inputs problems (if I changed compile_js.gypi or other things in remoting/ ninja wouldn't rebuild anything). R=jamiewalch@chromium.org BUG=none TEST=green bots, remoting runs on Closure Compliation Linux FYI bot Review URL: https://codereview.chromium.org/1037613002 Cr-Commit-Position: refs/heads/master@{#322193}
-
hendrikw authored
We were missing the single-threaded task graph runner, which was required for blink's layout tests that checked for pixels. BUG=468928 Review URL: https://codereview.chromium.org/1036693002 Cr-Commit-Position: refs/heads/master@{#322192}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/698efc0..6c126cd TBR=jchaffraix@chromium.org,loislo@chromium.org Review URL: https://codereview.chromium.org/1024463011 Cr-Commit-Position: refs/heads/master@{#322191}
-
dschuyler authored
BUG=469362 Review URL: https://codereview.chromium.org/1024543006 Cr-Commit-Position: refs/heads/master@{#322190}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/7a01184..e523d4f CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=hcm@google.com Review URL: https://codereview.chromium.org/1033963003 Cr-Commit-Position: refs/heads/master@{#322189}
-