- 05 Oct, 2019 38 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d1f79f968fc0..bd3eecdd8e0a Created with: gclient setdep -r src-internal@bd3eecdd8e0a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8021dfa86da8347ebc9f6654e8e041e9b19508b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842596Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703139}
-
Peter Boström authored
Replaces OnBoundsChanged + FocusRing::SetPath() with either installing a HighlightPathGenerator for the view or installing an overriding one on the FocusRing. It also removes an InkDropView::GetInkDropMask override. This change also adds a PillHighlightPathGenerator which was used both for the location bar and a button inside the Omnibox. Bug: chromium:1007546 Change-Id: I163291c5ee4f8f361d3181b30d0e81f310bb4eab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842115 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703138}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7536bc539500..d21db5d67ac2 git log 7536bc539500..d21db5d67ac2 --date=short --no-merges --format='%ad %ae %s' 2019-10-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e2b55cc5..35431c51 (703005:703133) 2019-10-04 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b5ead1da..e2b55cc5 (702047:703005) 2019-10-04 shyamsadhwani@fb.com Fixed issue with H264 packet buffer where it was not detecting presence of sps/pps for idr frames 2019-10-04 peah@webrtc.org ACM: Adding support for more than 2 channels in the send pipeline 2019-10-04 sprang@webrtc.org Adds RTPSenderVideo::Config struct with red/ulpfec config 2019-10-04 nisse@webrtc.org Delete VCMEncodedFrame::VerifyAndAllocate Created with: gclient setdep -r src/third_party/webrtc@d21db5d67ac2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: I4048c47d21373c9d2dfae151c0804f4dbcbd4080 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842598Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703137}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bd5145058235..ebc7ae7b4de6 git log bd5145058235..ebc7ae7b4de6 --date=short --no-merges --format='%ad %ae %s' 2019-10-05 cjmcdonald@chromium.org Let DepGraphGenerator consider BDEPEND packages Created with: gclient setdep -r src/third_party/chromite@ebc7ae7b4de6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I5c9e912718869e1c8be718db5c6035023280910b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842597Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/14b4bc0d..d59e86ca Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia096d2749e25750451e9bbe0b0f3ee1eae4d55d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842086Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703135}
-
Michael Lippautz authored
Within such a scope we should not finalize garbage collection which may happen when reporting memory to V8. Bug: 1005723 Change-Id: Icdd568143081d954d019265dc4bfc6640f8bf500 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841336 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#703134}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1a911cba955..d1f79f968fc0 Created with: gclient setdep -r src-internal@d1f79f968fc0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ic597209f5f43107953fcc1fb417e074c3d95fa24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842794Reviewed-by:
-
Michael Lippautz authored
The final annotation becomes necessary when TraceWrapperV8ReferenceHolder is not trivially destructible any longer (which will be required temporary). Change-Id: I4030ace34ee1c9ab0a620d36c8e7b800c2cea175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841556 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Greg Thompson authored
Prior to https://crrev.com/643864, they weren't detected for Chromium on account of the way google_brand worked. That CL changed behavior and accidentally started showing the outdated build bubble for Linux Chromium users. BUG=1010592 Change-Id: I069ac36166e2ae720d58b1b9aa85605792be8684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841635Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#703131}
-
BUG=762641 TBR=oshima@chromium.org Change-Id: I1ed88347b225f331da8e1482523fd320ee36b2af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842076Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703130}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/14d80bf47afa..bd5145058235 git log 14d80bf47afa..bd5145058235 --date=short --no-merges --format='%ad %ae %s' 2019-10-05 vapier@chromium.org update path to depot_tools Created with: gclient setdep -r src/third_party/chromite@bd5145058235 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I8fbfd959f4ed18e3743ec8c92bf657955f4ba983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842791Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I0e74fc21c24750ea42eb46119872f42becd33ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842811Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703128}
-
Vlad Tsyrklevich authored
Limit when Android is enabled to when enable_frame_pointers=true. Android doesn't ship unwind tables by default, so otherwise it can't unwind and save alloc/dealloc stack traces. At the moment this is only for AArch64 builds which we don't yet ship. Bug: 973167 Change-Id: I4fe126394819e24875eccc856a0f8ef5cf8a844c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841187Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#703127}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6822e098c873..e1a911cba955 Created with: gclient setdep -r src-internal@e1a911cba955 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If2558712a903222faec26230fbd398140b36bb3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842522Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/37c463fe9c3a..d696f201295e git log 37c463fe9c3a..d696f201295e --date=short --no-merges --format='%ad %ae %s' 2019-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@d696f201295e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I9004034e31201f17ccdb8702fb1eb5af36e538ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842405Reviewed-by:
-
Nate Fischer authored
No change to logic. This swaps android.support.annotation.* for androidx.annotation.* in //android_webview/. Both of these are @Retention(SOURCE), so they'll have no effect on the product's behavior. No BUILD file changes because we were depending on android.support.* transitively (which was a bug we've now fixed) and already depended on androidx.annotation.* (so now our folder is consistent). Test: N/A Change-Id: I9cb65d5eb2cc0d52f56403d804b0b4f6b4acf49d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842614 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703124}
-
Piotr Pawliczek authored
Since M-78, external policies are initialized after CupsPrintersManager. It causes a problem with Enterprise Printers, because BulkPrinterCalculators are created during external policies initialization. Since M-78, EnterprisePrintersProvider (started by CupsPrintersManager) cannot find objects of BulkPrinterCalculators and always returns empty list of printers. This patch solves this problem by changing the lifetime of BulkPrintersCalculator. From now, each BulkPrintersCalculator is created by the first object that asks for it. Some unittests require that BulkPrintersCalculator are deleted at the end of each unittest. The patch solving that problem is in CL:1836660. BUG=chromium:1010289,chromium:1009062 TEST=on nautilus Change-Id: Ie9b06f05a67f028204230b6b84162a058457fbd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838051Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#703123}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/57a5b927de7d..14d80bf47afa git log 57a5b927de7d..14d80bf47afa --date=short --no-merges --format='%ad %ae %s' 2019-10-05 jclinton@chromium.org Increase the timeout for paladins in Legacy CQ to 5 hours Created with: gclient setdep -r src/third_party/chromite@14d80bf47afa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I044594f4c7bf7d66c11b36aee8e2a8199bc62a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842593Reviewed-by:
-
Yun Liu authored
Java 9 is required to run Robolectric tests on Android Q Robolectric release notes: https://github.com/robolectric/robolectric/releases/tag/robolectric-4.3 Adding JDK11 to support it. Bug: 965286, 693079 Change-Id: I122813716df0affa9a4b670751d0f3caa50e9dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831011 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#703121}
-
Xinghui Lu authored
Bug: 1010694 Change-Id: I0e3f989c6952213298e6179a751bc408b258fa1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838621 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#703120}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7f271e7f2645..4c82a9fc83a5 git log 7f271e7f2645..4c82a9fc83a5 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-04 brianosman@google.com Roll third_party/externals/angle2 2328d65ab30d..5549ef0451f9 (8 commits) Created with: gclient setdep -r src/third_party/skia@4c82a9fc83a5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: chromium:None Change-Id: I246784d52bf7dbf8ce49ed60ef40919bc38613c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841247Reviewed-by:
-
Mathieu Binette authored
Moved config from this file: https://chromium.googlesource.com/chromium/src/+/refs/heads/master/chrome/browser/policy/e2e_test/infra/config.pyl No change except config name from 'win-celab' to 'celab_release_bot' for consistency with other names here. This needs to be done in multiple CLs to prevent builder breaks: 1) Move configs to //tools/mb/mb_config.pyl [this change] 2) Recipe change to use the default mb_config_path 3) Delete chrome/browser/policy/e2e_test/infra/config.pyl Verified that we still generate the same build files: https://ci.chromium.org/raw/build/logs.chromium.org/chromium/led/mbinette_google.com/971b834147dd1151b62cfa0ee52308422ec9e0cd6d1b27d8f41dd93e567b8811/+/annotations?server=chromium-swarm.appspot.com (unrelated test failure tracked in https://crbug.com/1008922) Bug: 1011508 Change-Id: Ic1a81ac4b651b4707b10ba64fc97ee2f78c01b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841581Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Mathieu Binette <mbinette@google.com> Cr-Commit-Position: refs/heads/master@{#703118}
-
David Tseng authored
Change-Id: I9bfbf38f64f0a498e71c5cf38ec5908f2b3de03c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827469 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#703117}
-
Hesen Zhang authored
- Fix some lint issues detected by "git cl lint" command. Bug: 1011525 Change-Id: I31cb2d19d847c46d4440cf0280e5d872cd3a4111 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842515 Auto-Submit: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703116}
-
Scott Violet authored
This addresses two problems that triggered CHECKs/use-after-free: LayoutBlock, for -webkit-box, needs to add children to anonymous blocks in some cases. LayoutFlexibleBox should not merge anonymous flex items for -webkit-box. BUG=1010706 TEST=none Change-Id: Ic8cb22f4f031813c1e1447bc23f4bfb930b3caec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838754 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#703115}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/76548ed5..14b4bc0d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0235c73a08eebd876278747feb71a1653a9b8a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842075Reviewed-by:
-
Evan Stade authored
Instead of using NOTIFICATION_PROFILE_CREATED, listen for OnProfileAdded. This will automatically filter out incognito profiles, which are not "added" to the ProfileManager. Also, there's no need to listen for profile destruction as ProfileManager and its profiles are only destroyed after SafeBrowsingService is shut down. Bug: 268984 Change-Id: I73f8163d6488968fec019f878951172d348e9e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836433Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f7ad03aa869b..1ba72546da4c git log f7ad03aa869b..1ba72546da4c --date=short --no-merges --format='%ad %ae %s' 2019-10-04 jmadill@chromium.org GN: Allow building without /build/ folder. Created with: gclient setdep -r src/third_party/angle@1ba72546da4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: None Change-Id: I941e7966ee4857e14ba9dcf3ac3dbe8ce5f80555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842402Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/6ce64248fdc9..57a5b927de7d git log 6ce64248fdc9..57a5b927de7d --date=short --no-merges --format='%ad %ae %s' 2019-10-04 vapier@chromium.org failures_lib: rework handling of Exception.message 2019-10-04 vapier@chromium.org infra_libs: drop unused imports Created with: gclient setdep -r src/third_party/chromite@57a5b927de7d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ic42ffc7359bf31e907990a52750df3a7ed22772b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842401Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ifc08e837d17feb3402cb779a3a18d20e87ff166f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842406Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8151b15c. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" df884b61 "[WPT/referrer-policy] Add worker subresource tests" 86ea3d5b "Renaming fetch/metadata web platform tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4157aa3be40682e2e4a7cadf610cd9d6d8c05e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842074Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703109}
-
Yusuke Sato authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/9b9ccf7ac88a..61297bd64bfd $ git log 9b9ccf7ac..61297bd64 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 yusukes system_api: Add cpus field to StartArcVm proto 2019-07-02 cylai system_api: compile attestation_ca.proto to golang Created with: roll-dep src/third_party/cros_system_api BUG=b:142144019,b:139752657 TEST=try Change-Id: Ib5721ae0d5c0403dfac5880ec04bef4030444389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841897 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Auto-Submit: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#703108}
-
Matt Menke authored
Also turn the ReportingEndpointManager tests into unit tests, so that this is testable without wiring up NetworkIsolationKey through all the reporting code. Bug: 993805 Change-Id: I0d511dd7eb5f1418bf0a29e853198c39b4b4ea97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842131 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#703107}
-
Bettina authored
Bug: 1010764 Change-Id: I0a37a1f275f74860cc4df79747f9df97f7d22be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842503Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#703106}
-
Brandon Wylie authored
Change-Id: I0c52401587eda127ae9e48515fbd20db8b63d41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841582Reviewed-by:
-
chrome://managementdpapad authored
Bug: 965770 Change-Id: Ie978f3b8331275693f883ae6b11058f0a2ad3137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836604 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#703104}
-
Carlos IL authored
Removes the active mixed content shield from the omnibox and adds an 'Insecure Content'content setting to toggle allowing it on a per site basis. Currently behind a default off flag. Bug: 987294 Change-Id: Ic4c5238261eabc9606101a5227c6479a40f6633f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757740 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#703103}
-
kylechar authored
Remove some usage of deprecated callback types in services/viz/*. Where possible convert to the corresponding once type, otherwise replace with the repeating type. Bug: 714018 Change-Id: I241bbfff47b705f448790e13b2089fe10425e280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841235Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Auto-Submit: kylechar <kylechar@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#703102}
-
- 04 Oct, 2019 2 commits
-
-
Benjamin Beaudry authored
When navigating by word or by character with ATs on Windows (i.e. Narrator), links were not announced by the screen reader or were announced one word earlier. This was caused by two different bugs: 1. GetEnclosingElement() used to return the child text node of the link instead of returning the link node. I believe this might cause multiple other bugs related to other controls, such as buttons, and will look into a more general fix soon. This bug as been addressed in CL:1828124. 2. For Narrator to announce links and other control types properly, the |start_| and |end_| endpoints of a range must be in the same anchor for by word and by character navigation. Otherwise, "link" will be announced multiple times where not expected. This CL introduces a fix for the second bug. We reposition the |end_| endpoint to the end of the |start_| anchor if they are not in the same anchor. Bug: 928948 Change-Id: Ie455cdee26d233b6b97347345d0e3cdaa99b9f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825490Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#703101}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/40ba239931e2..6822e098c873 Created with: gclient setdep -r src-internal@6822e098c873 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ibe1b98fb2227f356e93c5573a4754f7682bda6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842398Reviewed-by:
-
