- 04 Jan, 2019 40 commits
-
-
Xida Chen authored
TBR=maxmorin@chromium.org NOTRY=true Bug: 919100 Change-Id: Ie218eb7ea89b447c9f53d303b5d0d73ed9a9b4c3 Reviewed-on: https://chromium-review.googlesource.com/c/1396226Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619958}
-
Max Morin authored
Tbr: charliea Bug: 820282 Change-Id: Ifa750d2c2a1b208b1c07acb1c473c220b7356a44 Reviewed-on: https://chromium-review.googlesource.com/c/1396146Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619957}
-
Morten Stenshorne authored
4 new failing tests. 1 test that used to fail in NG now passes. 12 tests recently marked as failing in legacy, but pass in NG. TBR=atotic@chromium.org, kojii@chromium.org Bug: 864398 Change-Id: I2f39ba62a4162da0834b3a29342315b1c334cd67 Reviewed-on: https://chromium-review.googlesource.com/c/1396028Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#619956}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5df21f21..d16e9a9b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I21ccefd229e0b1e5796131389e7e1e54dfc0b461 Reviewed-on: https://chromium-review.googlesource.com/c/1395993Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619955}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/231bbe3a803d..63707fc2cc12 Created with: gclient setdep -r src-internal@63707fc2cc12 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie0d88abfb402eb8416559976d0cc4448b9b2f74d Reviewed-on: https://chromium-review.googlesource.com/c/1396180Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619954}
-
Xida Chen authored
This reverts commit 873fae30. Reason for revert: This is not the cause of the net_unittests failure, apparent there is crbug.com/869227 Sorry about that. Original change's description: > Revert "Fix incorrect behaviour of settings UI for IP address and name servers." > > This reverts commit 6d16ec71. > > Reason for revert: Suspect causing failure to the net_unittests here: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/38075 > > Original change's description: > > Fix incorrect behaviour of settings UI for IP address and name servers. > > > > * Block IP address and name servers checkboxes and input fields when > > corresponding settings are enforced by policy and not recommended. > > * Correctly show policy indicators for these settings. > > > > Bug: 847429 > > Change-Id: I3db8ad751ebe44dff487cc01721019738f72c4e5 > > Reviewed-on: https://chromium-review.googlesource.com/c/1335487 > > Commit-Queue: Zakhar Voit <voit@google.com> > > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#619929} > > TBR=stevenjb@chromium.org,hendrich@chromium.org,voit@google.com > > Change-Id: I986daf88eb60ac7e1e5113ef9c857b473a7f8d0e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 847429 > Reviewed-on: https://chromium-review.googlesource.com/c/1396219 > Reviewed-by: Xida Chen <xidachen@chromium.org> > Commit-Queue: Xida Chen <xidachen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619947} TBR=stevenjb@chromium.org,xidachen@chromium.org,hendrich@chromium.org,voit@google.com Change-Id: I8e7a192ea6ea63f18d520212ef3792864d2c1068 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 847429 Reviewed-on: https://chromium-review.googlesource.com/c/1396224Reviewed-by:
-
Xida Chen authored
Test is flaky TBR=maxmorin@chromium.org NOTRY=true Bug: 919096 Change-Id: I90e8113f1e1271ff9faaa6185bb34036916b2f4f Reviewed-on: https://chromium-review.googlesource.com/c/1396222Reviewed-by:
-
Rune Lillesveen authored
The apply code early returns if the type is not a CSSBorderImageSliceValue. Create an initial value which matches the expected type. Bug: 918243 Change-Id: I3228d2410789306d915db892ad54e918631b8864 Reviewed-on: https://chromium-review.googlesource.com/c/1396118Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8743424b5d6d..39a48a8a5d7d git log 8743424b5d6d..39a48a8a5d7d --date=short --no-merges --format='%ad %ae %s' 2019-01-04 dhanyaganesh@chromium.org lib/buildstore.py: Initial BuildStore Created with: gclient setdep -r src/third_party/chromite@39a48a8a5d7d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ia0f4d46ed1a8f8f36207d902b4d481e9951bbe53 Reviewed-on: https://chromium-review.googlesource.com/c/1396178Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619950}
-
Nasko Oskov authored
As of https://crrev.com/617708 the expectation is that all renderer initiated navigations must specify the origin of the document that started the navigation. This CL fixes OpenNewForegroundTab to supply initiator origin for the navigation in the newly opened tab. To achieve that, the initiator origin is exposed through NavigationHandle's public API. TBR=ortuno@chromium.org Bug: 882053 Change-Id: I3867a5579d5dcc954f0759a93cc5c0f431a092b8 Reviewed-on: https://chromium-review.googlesource.com/c/1395418 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#619949}
-
Vadym Doroshenko authored
Along the way the function CanProvisionalManagerSave is renamed to IsReadyForAutomaticSaving because it shows better what this function checks. Bug: 831123 Change-Id: Iabf125fd8b46a15cccbe5e6152e98352e5facde2 Reviewed-on: https://chromium-review.googlesource.com/c/1391685 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#619948}
-
Xida Chen authored
This reverts commit 6d16ec71. Reason for revert: Suspect causing failure to the net_unittests here: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/38075 Original change's description: > Fix incorrect behaviour of settings UI for IP address and name servers. > > * Block IP address and name servers checkboxes and input fields when > corresponding settings are enforced by policy and not recommended. > * Correctly show policy indicators for these settings. > > Bug: 847429 > Change-Id: I3db8ad751ebe44dff487cc01721019738f72c4e5 > Reviewed-on: https://chromium-review.googlesource.com/c/1335487 > Commit-Queue: Zakhar Voit <voit@google.com> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: Alexander Hendrich <hendrich@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619929} TBR=stevenjb@chromium.org,hendrich@chromium.org,voit@google.com Change-Id: I986daf88eb60ac7e1e5113ef9c857b473a7f8d0e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 847429 Reviewed-on: https://chromium-review.googlesource.com/c/1396219Reviewed-by:
-
Biren Roy authored
This CL lands server change 226511201 by birenroy. BUG=488484 Change-Id: I1cc9db648b8cd7f74cae239cd53c684fd24e568e Reviewed-on: https://chromium-review.googlesource.com/c/1394433Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Birendro Roy <birenroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#619946}
-
Xida Chen authored
TBR=maxmorin@chromium.org NOTRY=true Bug: 919090 Change-Id: Ie7e13df26de11ef7183cba9f6f08778e0ab97898 Reviewed-on: https://chromium-review.googlesource.com/c/1396218Reviewed-by:
-
Morten Stenshorne authored
Was failing, but not marked as such. Now it should pass. TBR=atotic@chromium.org,kojii@chromium.org Change-Id: I430859f81ede22e6cb33c724c912250137b71f51 Reviewed-on: https://chromium-review.googlesource.com/c/1396122Reviewed-by:
-
Oleh Prypin authored
https://github.com/webrtc/apprtc/blob/20cdd7652d58c9cf47ef92ba0190a5505760dc05/src/web_app/js/call.js#L159 sends an XHR on page close which is now an error in Chromium. Ignoring the error doesn't cause any problems, especially for the purpose of this test, so until a real fix is made, this is a simple way to un-break tests. (https://ci.chromium.org/p/chromium/g/chromium.webrtc) Bug: 918871 Change-Id: I29497a39424a1c54e7b6875edc0cb896663221ea Reviewed-on: https://chromium-review.googlesource.com/c/1396019Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Oleh Prypin <oprypin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619943}
-
Jérôme Lebel authored
AccountSigninItem uses SettingsImageDetailTextCell to display the UI. Change-Id: I225f1967287ead71297cb9b0873fb7b14552e8d9 Reviewed-on: https://chromium-review.googlesource.com/c/1392962 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#619942}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dd0edf714415..231bbe3a803d Created with: gclient setdep -r src-internal@231bbe3a803d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id86b0a004b50f0710a9cb6ce39037a4685b1250a Reviewed-on: https://chromium-review.googlesource.com/c/1396177Reviewed-by:
-
Gauthier Ambard authored
This CL fixes the frame computation for the NTP, taking into account the BrowserContainerFullscreen experiment. Bug: 918435 Change-Id: I55e31b86262c3b30ae3a51029dba2336929076a5 Reviewed-on: https://chromium-review.googlesource.com/c/1392956 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619940}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c519fed6ddce..5f1692c60a43 git log c519fed6ddce..5f1692c60a43 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 kjlubick@google.com [canvaskit] Allow providing webgl context and canvas element Created with: gclient setdep -r src/third_party/skia@5f1692c60a43 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ibabe7a70a4ce2c43785f2941c06fb38e256901fa Reviewed-on: https://chromium-review.googlesource.com/c/1395736Reviewed-by:
-
Friedrich Horschig authored
This CL is a small step to make chips more reusable. It moves the Chips view as defined for the Downloads Home into a separate View located in ui/. This has very little visible effects: * Chip appearance is now consistent for Downloads on Kitkat and older * The corner radius of chips is variable (important for accessory) * RippleBackgroundHelper allows backgrounds with colored borders Right now, presubmits will complain about the new text style. I'm open for any tips where the TextAppearance should be defined. Bug: 914781 Change-Id: I10b84d933a6e5fc98665e942f75e336bb9cc6bd1 Reviewed-on: https://chromium-review.googlesource.com/c/1380013 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#619938}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a8182ff8..5df21f21 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I31cffc251af7e6554157823294add76067da1c9e Reviewed-on: https://chromium-review.googlesource.com/c/1395987Reviewed-by:
-
Antonio Gomes authored
This CL is step forward to move the test away from SigninManager, PO2TS and AccountTrackerService completely. The CL: 1) removes the knowledge of the tests about internals of SigninManager (eg that SigninManager::OnSignoutDecisionReached is called during the SignOut routine). 2) Removes MockSigninManager class completely, after tests switched away to use ChromeSigninClient::PreSignOut() instead of SigninManager::SignOut(). 3) Calls ChromeSigninClient::AfterCredentialsCopied instead of SigninManager::CopyCredentialsFrom keeping the same behavior. BUG=890787 Change-Id: Ib9dbc5feb073ec7bbda452a680e71de27a361e79 Reviewed-on: https://chromium-review.googlesource.com/c/1394663 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#619936}
-
Frank Kastenholz authored
There were two updates for A) bundling the IETF QUIC STOP_SENDING frame and RST_STREAM frame when closing streams and B) ensuring that both were carried in a single packet. These were manually merged as one merge because the former introduced a number of test issues (sending two packets when one was expected) that the latter then ameliorated. Merging both at one time avoided churn in the tests. This work was done as a part of version-99/IETF-QUIC development. Chromium-specific changes made to expect RST_STREAM + STOP_SENDING frames in various chromium-specific tests. The original change descriptions are Bundle a STOP_SENDING frame with RST_STREAM For IETF QUIC/V99, bundle a STOP_SENDING frame with a RST_STREAM frame whenever a request is made to close/RST a stream. In IETF QUIC, RST_STREAM is one-way. Adding a STOP_SENDING will cause the peer to commence closing for read and to send a RST_STREAM in response. This mimics Google QUIC behavior. This is all version 99 flag protected. Merge internal change: 225555438 Ensure rst_stream + stop_sending frames are sent in a single packet A low-level scoped packet flusher has the undesired side-effect of sending individually queued control frames as separate packets. For the work that bundles RST_STREAM+STOP_SENDING this leads to a bit of network inefficiency (sending two packets when one will do). This work ensures that both frames go out in a single packet. This is all version_99 flag protected. Merge internal change: 226919471 Change-Id: I295974d758fecded42206358a4f11760e6137f97 Reviewed-on: https://chromium-review.googlesource.com/c/1393529 Commit-Queue: Frank Kastenholz <fkastenholz@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
This is to prepare the implementation of AccountSignInItem using UITableViewItem. See: crrev.com/c/1392962 Change-Id: Ie1d6ae2af7189f7e4e68878efb4bfe50b02604bd Reviewed-on: https://chromium-review.googlesource.com/c/1392961Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7172f655e9a4..dd0edf714415 Created with: gclient setdep -r src-internal@dd0edf714415 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ifc58ea62d343df8f3ce417efdd281d7d64e479ff Reviewed-on: https://chromium-review.googlesource.com/c/1395735Reviewed-by:
-
Jérôme Lebel authored
Searching for UITableViewCell instead of UICollectionViewCell. Bug: 918711 Change-Id: If93179ae630a8b6224836955931117fb18d166d7 Reviewed-on: https://chromium-review.googlesource.com/c/1394596 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
Alex Clarke authored
This simplifies the class and hopefully makes minidumps more useful. Bug: 918127 Change-Id: Ife58ceadce1a5f68724e16ffd05a97e4a2ec8911 Reviewed-on: https://chromium-review.googlesource.com/c/1395988Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#619931}
-
Antonio Gomes authored
CL is a (driven-by) clean up pass on dice_response_handler_unittests.cc, where pair calls to AccountTrackerService::SeedAccountInfo and IdentityTestEnvironment::SetRefreshTokenForAccount are replaced by calls to the wrapper IdentityTestEnvironment::MakeAccountAvailable. CL also replaces from the tests the knowledge about the specific refresh token values (eg "refresh_token_for_bleh"), by checks that verify whether the IdentityManager holds a persistent error state or not. BUG=890790 Change-Id: I74215310276023a387854d840a96763545699dfe Reviewed-on: https://chromium-review.googlesource.com/c/1393303Reviewed-by:
-
Zakhar Voit authored
* Block IP address and name servers checkboxes and input fields when corresponding settings are enforced by policy and not recommended. * Correctly show policy indicators for these settings. Bug: 847429 Change-Id: I3db8ad751ebe44dff487cc01721019738f72c4e5 Reviewed-on: https://chromium-review.googlesource.com/c/1335487 Commit-Queue: Zakhar Voit <voit@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#619929}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4f718c120c1e..43f09d829d87 git log 4f718c120c1e..43f09d829d87 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 treehugger-gerrit@google.com Merge "build: Warn to run gn clean after install-build-deps" Created with: gclient setdep -r src/third_party/perfetto@43f09d829d87 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I17ea5c3d4682fb45498f1e6ba969a5090ad6a8ca Reviewed-on: https://chromium-review.googlesource.com/c/1395733Reviewed-by:
-
Mugdha Lakhani authored
Access to active fetches is currently behind a feature flag. This CL takes that out, along with all logic around it. Bug: 875201 Change-Id: I0bf0ca8ec3eae7ddc5206b639e6a10897476838a Reviewed-on: https://chromium-review.googlesource.com/c/1388647Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#619927}
-
Gauthier Ambard authored
This CL puts the caption in a scroll view, allowing it to be scrolled when the font size is big. Bug: 916068 Change-Id: I111e1d4e00ea2949c85964999106248dfebb433c Reviewed-on: https://chromium-review.googlesource.com/c/1392187 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619926}
-
edchin authored
There are two unused notifications: - TabModel's didChangeTabSnapshot - SnapshotGenerator's didUpdateSnapshotForWebState: These were redundant observable events. The preferred object to observe is SnapshotCache since this is the source of all retrievals. Bug: 918032 Change-Id: I5f36aa564bb13238ff25ffda899ed09b194d6cac Reviewed-on: https://chromium-review.googlesource.com/c/1394944 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#619925}
-
Jérôme Lebel authored
Bug: 919040 Change-Id: I47e6303a2fadb5e587fa7cfbf362495931ee3328 Reviewed-on: https://chromium-review.googlesource.com/c/1396137Reviewed-by:
-
Henrik Boström authored
Now that the bugs caused by the Resolver having updated have been fixed in https://bugs.chromium.org/p/chromium/issues/detail?id=919035, these tests are no longer expected to be flaky. TBR=hta@chromium.org Bug: 919035 Change-Id: I60c421759c69f60e620d76e862aaad5d858bc489 Reviewed-on: https://chromium-review.googlesource.com/c/1396024Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#619923}
-
edchin authored
This CL fixes a retain cycle that was caused by using an ivar in an asynchronous block. The block retains self when an ivar is used. This CL also more broadly replaces ivars with properties in the same file. Bug: 918032 Change-Id: I26c867931ad96574f19420f58465e2d14c43ce43 Reviewed-on: https://chromium-review.googlesource.com/c/1393015Reviewed-by:
Eric Noyau <noyau@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4df0aae68faa..7172f655e9a4 Created with: gclient setdep -r src-internal@7172f655e9a4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic58741ea0e9a7b4131018bfc7cbfcd7601ea7770 Reviewed-on: https://chromium-review.googlesource.com/c/1395734Reviewed-by:
-
Dominic Battre authored
This CL introduces a new UMA metric PasswordManager.FirstRendererFillingResult to record cases where the browser process instructed the renderer to fill credentials into a form but the renderer fails to fill the credentials. We record the metrics to understand why we fail to fill and prioritize our efforts. This is currently a blind spot. Bug: 918846 Change-Id: Ia146861e3d0056cff2ced970175ea377b687da61 Reviewed-on: https://chromium-review.googlesource.com/c/1394313 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619920}
-
Max Morin authored
Bug: 622387, 919033 Tbr: dtseng Change-Id: I03834f051d3368d2a6f497e918d20bb3e630301e Reviewed-on: https://chromium-review.googlesource.com/c/1396141Reviewed-by:
-
