GitLab

Calculates the number of columns tiles are layed out in
at initialization and reorders the home page tile so that
it is pinned to the first row.
Follow-up issue: https://crbug.com/746274

BUG=732913

Change-Id: Ieeddf88e8262827c7a22787230c386fe3b43cc17
Reviewed-on: https://chromium-review.googlesource.com/567925
Commit-Queue: Ondrej Škopek <oskopek@google.com>
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488203}

This CL introduces a transition API for animating contained view
controllers. It adds a concrete transitioning context to work with generic
animators.
The new API is used for CSChromium's FindInPage feature, with a new generic
animation controller object.

Bug: none
Change-Id: Ia1bf383a373e13766c4bd966e4ede04778357c9f
Reviewed-on: https://chromium-review.googlesource.com/552937Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488202}

Since PackageFormatOf() only needs the first 4 bytes, just copy them to
a local buffer.

BUG=728627

Change-Id: I19e65c95f4737968967fb63196b8ed6d07fa7fae
Reviewed-on: https://chromium-review.googlesource.com/577673Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488201}

Use a segment iterator insted.

BUG=728627

Change-Id: I6bb88a0696e920f2751181d4c8acc9d790787e26
Reviewed-on: https://chromium-review.googlesource.com/577672Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488200}

The passwords settings EG test uses PasswordStore. PasswordStore works on a
background task runner, and the test needs to ensure that it waits until
PasswordStore is finished.

Unfortunately, the test currently attempts to do this with
[[GREYUIThreadExecutor sharedInstance] drainUntilIdle];

As the name suggests, this waits for the UI thread, not for the background task
runner. There is no synchronisation with the password store currently and the
tests pass just by luck. Indeed, test configurations are possible to write
where PasswordStore is not done on time and the test fails.

Therefore this CL replaces the waiting for UI thread with a combination of
posting tasks to PasswordStore and using WaitUntilConditionOrTimeout to check
their completion. The timeout selected is 1 second. Using the pre-defined value
kSpinDelaySeconds turned out to be too short.

The CL not only replaces GREYUIThreadExecutor with the new synchronisation, it
also checks the state of the PasswordStore in more detail. Furthermore, it also
adds synchronisation with PasswordStore after the password list view loads,
because that view also depends on the response from PasswordStore.

Bug: 744058
Change-Id: I1a86c0cdfa9b60a609505005b7d2df5e1896dd54
Reviewed-on: https://chromium-review.googlesource.com/573540
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488199}

- Implement GetWebsiteSettingLastModified for the
NotificationChannelsAndroidProvider by storing channel creation
timestamp within the channel IDs.

- This also has the beneficial side effect that each time a channel
is created in response to permission grant, it will have a unique ID,
so that channels deleted when site data is cleared will not be
restored the next time permission is granted/blocked.

- Note that NCAP.GetWebsiteSettingLastModified is currently only
called from tests, but in a future patch it will be pulled up to a
new provider interface and called by the HostContentSettingsMap
where it currently only calls the Pref Provider. 

Bug: 700377
Change-Id: I5363ae2baa7e0c92bb7768361d459cd024622b32
Reviewed-on: https://chromium-review.googlesource.com/567153
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488198}

As copied, they are exactly same.

Bug: 739062
Change-Id: I96e564362c50a2519b6a4358b609ea58119c70a0
Reviewed-on: https://chromium-review.googlesource.com/578970
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488197}

The newer CrOS toolchains declare a new use_vaapi argument. Unless this
argument is declared in Chromium as well, gn gen will display this error
message:

ERROR at the command-line "--args":3:13: Build argument has no effect.
use_vaapi = true

The ninja files will be successfully generated nonetheless, but this is
still disturbing, so fix this by declaring this argument.

BUG=742069
TEST=Made sure Chromium was compiling with use_vaapi declared or not.

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib10ac7d0762a09d13ba92391ba55585b786ad3f6
Reviewed-on: https://chromium-review.googlesource.com/579028Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488196}

Revert of Last_n: instrumentation tests to verify timely snapshot deletion. (patchset #7 id:120001 of https://codereview.chromium.org/2833653002/ )

Reason for revert:
Likely cause of https://crbug.com/746699.

testLastNPageIsDeletedUponNavigation is flaky.

Original issue's description:
> Last_n: instrumentation tests to verify timely snapshot deletion.
>
> Adds new tests to RecentTabsTest.java to verify that offline snapshots created
> by last_n are properly deleted when successfully navigating to another page and
> upon tab closure. These actions are important to comply with privacy
> requirements for this feature.
>
> This change re-adds instrumentation tests previously committed along with a
> related bugfix [1] that were reverted due to them being flaky. It seems that the
> underlying issue causing the flakyness has been fixed [2] [3] so these should
> now work as expected.
>
> [1] https://codereview.chromium.org/2824623002/
> [2] https://bugs.chromium.org/p/chromium/issues/detail?id=592961 (restricted)
> [3] https://bugs.chromium.org/p/chromium/issues/detail?id=738490
>
> BUG=711770
>
> Review-Url: https://codereview.chromium.org/2833653002
> Cr-Commit-Position: refs/heads/master@{#487727}
> Committed: https://chromium.googlesource.com/chromium/src/+/f6fd25d5826f1a62010b08037eb50c396b05d7a2

TBR=dewittj@chromium.org,carlosk@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=711770

Review-Url: https://codereview.chromium.org/2983953002
Cr-Commit-Position: refs/heads/master@{#488195}

Bug: None
Change-Id: I967dcf8315ea3f40fc89cb0fe54da83499ab4b52
Reviewed-on: https://chromium-review.googlesource.com/574921Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488194}

Bug: 740821
Change-Id: I4fa17745613ac2c25efe260673dc324cf5f6df3a
Reviewed-on: https://chromium-review.googlesource.com/579249Reviewed-by: Yuki Awano <yawano@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488193}

This CL delays the binding of a ukm::SourceID to a URL in the
PasswordManagerMetricsRecorder until the recorder is destroyed. The reason for
this is that long-lived tabs/WebContents would bind the URL at creation. But by
destruction (i.e. reporting time) the binding is purged and the data is
discarded.

Bug: 732846
Change-Id: I4d20385eb2de80c4ca5e53816d22b9652abb5b61
Reviewed-on: https://chromium-review.googlesource.com/577554Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488192}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/2048bc4..a7461e3

$ git log 2048bc4..a7461e3 --date=short --no-merges --format=%ad %ae %s
2017-07-19 pbos@webrtc.org Move temporal-layer properties to FrameConfig.
2017-07-19 zstein@webrtc.org Introduce RtpTransportInternal and SrtpTransport.
2017-07-19 ehmaldonado@webrtc.org Remove remains of webrtc/base
2017-07-19 tschumim@webrtc.org Disable flaky NoBandwidthDropAfterDtx test.
2017-07-19 sakal@webrtc.org Fix fromAndroidGraphicsMatrix to use column-major order for output.
2017-07-19 saza@webrtc.org Replace WEBRTC_TRACE logging in modules/audio_device/.. mac/ win/
2017-07-19 saza@webrtc.org Adds a histogram metric tracking for how long audio RTP packets are sent through streams related to a call object.
2017-07-18 mellem@webrtc.org Add texture support to HardwareVideoEncoder.
2017-07-18 mellem@webrtc.org Add texture support to HardwareVideoDecoder.
2017-07-17 zijiehe@chromium.org Mapping screen id from DirectX capturer to GDI capturer
2017-07-18 ehmaldonado@webrtc.org Enable tracing on rtcstats_integrationtest.cc
2017-07-18 aleloi@webrtc.org UBSan fuzzer bug in LowCutFilter::BiqueadFilter::Process
2017-07-18 sakal@webrtc.org Fix fullscreen scaling in AppRTCMobile.
2017-07-18 ehmaldonado@webrtc.org Increase the size of the buffer for type.name.id.
2017-07-18 saza@webrtc.org Patch set 1: Run a script to replace occurrences of WEBRTC_TRACE logging with the new style, on webrtc/modules/audio_device/linux/audio_device_alsa_linux.cc.
2017-07-18 ehmaldonado@webrtc.org Trace stats in RTCStatsCollector.
2017-06-28 aleloi@webrtc.org Remove potential left shift of negative value in WebRtcSpl_AnalysisQMF
2017-07-18 gnish@webrtc.org Added implementation of three classes:

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

Bug: 
Change-Id: If229bad76d63d07156f4ce48b707f3159834ec13
Reviewed-on: https://chromium-review.googlesource.com/579047Reviewed-by: Henrik Andreasson <henrika@chromium.org>
Commit-Queue: Henrik Andreasson <henrika@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488191}

Move same conditional expression AdjustSelection{Start,End}ToAvoidCrossingEditingBoundaries() to a function

This patch moves same conditional expression in
|AdjustSelection{Start,End}ToAvoidCrossingEditingBoundaries()| into
|ShouldAdjustPositionToAvoidCrossingEditingBoundaries()| to share code and
simplify if-statement for improving code health.

Change-Id: I05c4324d1758c991b75bf27dac3426479d8e30bb
Reviewed-on: https://chromium-review.googlesource.com/578755Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488190}

We want the initialisation of the home sheet to happen when the bottom
sheet opens and shows the home sheet. However, even though it's the
default sheet, the bottom sheet can also open to show omnibox
suggestions. In that case the home sheet is not shown and should not
be loaded.

This CL makes initialisation happen the first time the sheet is shown
since the opening of the bottom sheet.

Making the home sheet not be selected when the omnibox suggestions are
shown is out of scope and tracked in https://crbug.com/731128

Bug: 735945
Change-Id: I61406ea0ff4207370d86d3fd0712e339813b7ff7
Reviewed-on: https://chromium-review.googlesource.com/563309Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488189}

Follow-up to commit 4a301c5f ("Remove the
--allow-local-commits flag from wpt-import"), which broke wpt imports:

Traceback (most recent call last):
  File "/mnt/data/b/rr/tmpFlAgpq/w/src/third_party/WebKit/Tools/Scripts/wpt-import", line 18, in <module>
    host.exit(importer.main())
  File "/mnt/data/b/rr/tmpFlAgpq/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 55, in main
    if not self.checkout_is_okay():
  File "/mnt/data/b/rr/tmpFlAgpq/w/src/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py", line 230, in checkout_is_okay
    ['git', 'log', '--oneline', 'origin/master..HEAD'])[1]
ValueError: need more than 0 values to unpack

(from https://luci-milo.appspot.com/buildbot/chromium.infra.cron/wpt-importer/346)

Tbr: qyearsley@chromium.org
Change-Id: Ic5849c25add80048d4e1e9f1c573031537243ff0
Reviewed-on: https://chromium-review.googlesource.com/579069
Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Reviewed-by: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#488188}

Also add validation to make sure 'ios' platform does not appear in
policy_templates.json.

Bug: 561499
Change-Id: Ic2c147fe772a1464ea734d12df179b3b1543fb72
Reviewed-on: https://chromium-review.googlesource.com/568148
Commit-Queue: Daria Iakovleva <yakovleva@google.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Reviewed-by: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488187}

This reverts commit d4a5e982.

Reason for revert: regressed performance (crbug.com/739378, crbug.com/736714).

The main cause is that new heap format produces a lot more stack frames in
an attempt to dump all information in contrast with the old format, where
small stack branches are coalesced together. I'll that functionality to
the new format and reland it.

> [tracing] Switch to new heap dump format.
>
> This CL switches tracing to a new heap dump format, that offers the
> following advantages:
>
> 1. Dumps include all the information collected by Chrome's heap profiler.
>
> 2. The format is simpler and more compact.
>
> 3. The format can easily be extended to include additional per-entry data.
>
> 4. The format allows for post-processing (see recategorization from
>    crrev.com/2906413002 as an example).
>
> BUG=708930
>
> Review-Url: https://codereview.chromium.org/2650863003
> Cr-Commit-Position: refs/heads/master@{#480580}

TBR=mark@chromium.org

Bug: 708930, 739378, 736714
Change-Id: Ifc2b647aa1f57f4decae6e593ad032d72208b304
Reviewed-on: https://chromium-review.googlesource.com/575682
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488186}

Bug: 
Change-Id: I72bb8b8b547980e3097c23f1f64fc1da37929774
Reviewed-on: https://chromium-review.googlesource.com/578698
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488185}

For better MD style download notification representation, we're
going to add new attributes to Notification class, and going to
use these strings.

TEST=manual
BUG=740807

Change-Id: I05a5f1a2094814b579aee886297732b0df2c56b5
Reviewed-on: https://chromium-review.googlesource.com/578752Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488184}

On iOS, unlike on Android or desktop platforms, toggling the "Save password"
switch to off hides the stored passwords (including blacklisted entries). Those
are still present in the profile, and are still filled in forms. The user needs
to enable saving to be able to delete them from the passwords settings.

The UI guidance (https://crbug.com/515462#c7) and product guidance
(https://crbug.com/515462#c8) is that iOS should instead mirror the other
platforms here and display the stored entries no matter whether saving is
enabled or disabled. This CL implements that change.

Bug: 515462
Change-Id: Iae1d35fc6b1eda273dc8efa068454462c1649110
Reviewed-on: https://chromium-review.googlesource.com/573381
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488183}

Add "Chrome OS system" string that will be used for system notification
when new-style notification is enabled.

BUG=738779,726241,740807,740813
TEST=manual

Change-Id: I2e4ce586385065752abcc4e38445b7e67c6bb2ef
Reviewed-on: https://chromium-review.googlesource.com/578696Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488182}

The mocks are here:
https://docs.google.com/presentation/d/1GnKn5ca_KrM_BTQB-He9cCmzAQtwVF6JJJ6Lo6i4gqI/edit?ts=596e5846#slide=id.g4af27b4ff_35243

Bug: 746046
Change-Id: Ie2dff5c8913f71db4fd738a04c27fc082db1b803
Reviewed-on: https://chromium-review.googlesource.com/578030Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Gustavo Sacomoto <sacomoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488181}

Bug: 
Change-Id: I026fc3a546afe4699452ced6810b187addeb576b
Reviewed-on: https://chromium-review.googlesource.com/578537Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Austin James Ahlstrom <aahlstrom@google.com>
Cr-Commit-Position: refs/heads/master@{#488180}

Compiling browser code in blink/modules currently use
about 80 CPU minutes. That is about 7% of the total compilation time.
If you use jumbo compilation (merge many files into a single
translation unit) that time drops to about a fifth of that.

There are also unit_tests in modules that will be jumbofied in
a different patch.

Bug: 713137
Change-Id: I9155d2af0c9dce6b3178f77b9366062eb45d4560
Reviewed-on: https://chromium-review.googlesource.com/568302Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#488179}

This is a non-regression test for the linked bug.

BUG=742294

Change-Id: I749e223b831f7558b53039a14704625e52192a15
Reviewed-on: https://chromium-review.googlesource.com/576173
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488178}

As a precursor to changing the implementation of
chrome.identity.getAccounts() to use the Identity Service, this CL
moves that implementation away from using AccountTracker::GetAccounts()
to using OAuth2TokenService::GetAccounts(). The latter is the function
that we intend to back the upcoming Identity Service API.

AccountTracker::GetAccounts() is fundamentally based on
OAuth2TokenService::GetAccounts(): they both have the basic behavior
of returning the informations of all accounts for which a refresh
token is available. However, AccountTracker::GetAccounts() layers
some extra information on top relating to the primary account (a
concept of which the OAuth2TokenService is not aware). (AccountTracker
itself gets this information via IdentityProvider; in the context of
the chrome.identity.getAccounts() impl, this is ProfileIdentityProvider,
which is backed by SigninManager).

To avoid any behavioral changes, this CL ports the particular semantics
of AccountTracker::GetAccounts() to live directly in the implementation
of chrome.identity.getAccounts():
- Returns an empty list if there is no primary account or there is no
  refresh token available for the primary account
- Otherwise, puts the primary account first in the returned list

Bug: 729536
Change-Id: Ib4f6cff0afd2f751ec3a7409d24b797b1be0ec79
Reviewed-on: https://chromium-review.googlesource.com/574709Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488177}

PasswordsSettingsTestCase exposes a number of instance methods to do
instance-independent work. Those should either become class methods or
functions in the anonymous namespace.

Those methods are not related to the PasswordsSettingsTestCase class either,
and there already are helper functions in the anonymous namespace in
passwords_settings_egtest.mm. Therefore this CL moves the mentioned methods to
become functions in the anonymous namespace.

Bug: 744058
Change-Id: I1f8ede1d5bb4ef950f701cdefe407dc2d3bac0dd
Reviewed-on: https://chromium-review.googlesource.com/573025
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488176}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0850262f..3ef78954

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org

Change-Id: Id347d315033198db7404210f5a4c4a368421b448
Reviewed-on: https://chromium-review.googlesource.com/578850Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488175}

Now mojo is fixed to pass unique IDs across processes, Let's enable new
ownership edges for base::SharedMemory and remove old ownership edges.

Perf sheriffs: If you see sharp bumps in metrics like cc/gpu/discardable/
shared_memory this is very likely the culrprit, please revert it.

Bug: 604726
Change-Id: Iad7bf261f3e2c884d60e935cb2635923de46b2e2
Reviewed-on: https://chromium-review.googlesource.com/557741
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488174}

Bug: 732846
Change-Id: I011b4805a15501df0fb32ac3fd6002e44a56d9c2
Reviewed-on: https://chromium-review.googlesource.com/575242
Commit-Queue: Dominic Battré <battre@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488173}

Since the DISALLOW_* macros now use the C++11 syntax "= delete", it
does not matter whether they are used in the public or the private
section of a class definition.
In fact, the style guide recomments putting deleted constructors or
assignment operators in the public section.
Thus, remove the hint to put them in the private: declarations.

Drive-by: Fix the syntax of the deleted copy assignment operator.

R=thakis@chromium.org

Change-Id: I10af0d71c18dc1f3b08e4601ae571ed53d8c71e3
Reviewed-on: https://chromium-review.googlesource.com/578027Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488172}

BUG=742450

Change-Id: Ia767797d89022b862e38b7ae72949bed08d94c09
Reviewed-on: https://chromium-review.googlesource.com/578067Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488171}

This patch renames |FrameSelection::VerticalDirection| to
|SelectionModifyVerticalDirection| since it is used for a parameter of
|SelectionModifier::ModifyWithPageGranularity()| for improving code health.

Change-Id: Ic7c5c53a5b7d6cdb2f4c5350a4b7074d522ef5ef
Reviewed-on: https://chromium-review.googlesource.com/578911
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488170}

This patch implements break-after-space style line breaking. This style
is needed for 'white-space:pre-wrap', and when in editing.

The current layout engine handles this in BreakingContext. This patch
implements the style in LazyTextBreakIterator so that ShapingLineBreaker
can implement the behavior without additional code.

The current layout engine supports 3 modes:
1. break-before-space (most cases)
2. break-after-space (white-space:pre-wrap)
3. break-after-space + hanging space (editing)

This patch does not support 3rd mode yet, and that editing behavior is
slightly different from the current layout engine, closer to Edge. The
editing test failure is caused by this difference. I'll evaluate the
impact and the needs of the 3rd mode later.

There are more tests that actually pass, but they fail for other
reasons, such as the lack of quirks mode support.

BUG=636993

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Iec1b684da4dcf45f10eaa408889ebf77d387e668
Reviewed-on: https://chromium-review.googlesource.com/574903
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488169}

The button matchers in passwords_settings_egtest.mm have currently some
redundant grey_layout()-based sub-matchers. The idea is that when matching for
the buttons, the layout of the detail view page is also checked.

However, these redundant matchers make the button matchers heavy and sometimes
unusable (e.g., in the presence of different layouts for federated or
blacklisted credentials). Therefore this CL removes the layout constraints
from the matchers and instead creates specialised tests dedicated to just
checking the layout.

The past test "testBlacklisted" has been subsumed in the more detailed new
"testLayoutBlacklisted", and hence the former was removed.

Bug: 744058
Change-Id: I5428c9246e5de29f1124788e368550f7e6cfa72b
Reviewed-on: https://chromium-review.googlesource.com/573024Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488168}

The default value of |base| is 10, and only one instance with base=16
exists. This CL adds String::HexToUIntStrict(), and remove |base| arguments of
the following integer parsing functions:

- String::ToIntStrict()
- String::ToUIntStrict()
- String::ToInt64Strict()
- String::ToUInt64Strict()
- StringImpl::ToIntStrict()
- StringImpl::ToUIntStrict()
- StringImpl::ToInt64Strict()
- StringImpl::ToUInt64Strict()
- CharactersToIntStrict()
- CharactersToUIntStrict()
- CharactersToInt64Strict()
- CharactersToUInt64Strict()

Bug: 746157
Change-Id: If269771609e674d9f1baa279c0ed4954a14b7bc6
Reviewed-on: https://chromium-review.googlesource.com/578536
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488167}

Bug: 740842
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia7513ab41b6e684fec446d4f6232b4e29f09b0f5
Reviewed-on: https://chromium-review.googlesource.com/577975
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488166}

Bug: None
Change-Id: I2539556dbeafe0545dfd618ac74f45975e4b8614
Reviewed-on: https://chromium-review.googlesource.com/562819Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488165}

The NetworkChangeNotifier owns an object that checks it is destroyed
on the correct thread (HistogramWatcher). This requires the object
to be destroyed before the thread is stopped, so add helper function
to control when the NetworkChangeNotifier is destroyed.

For the same reason, do it also for MessageLoopForUI.

Call the new function from WebMainLoop destructor. This fixes a new
regression that was introduced during the refactoring of this code
that moved the object destruction till after the "main" function
returns (as they are owned by "static" globals).

To ensure the destruction happens in the same order as before the
refactoring in https://chromium-review.googlesource.com/558268,
use base::ScopedClosureRunner to register in which order the helper
functions are called.

As CroNet code was leaking those objects, do not add a call to the
destroy function there.

Bug: 746478
Change-Id: If2e5d1dea15c73bccd973222f9811660a5687b77
Reviewed-on: https://chromium-review.googlesource.com/577851
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488164}