GitLab

As part of the effort to build in recovery states to the controller, we
need to add a basic state machine so it's possible to control the new
set of states: CREATED, INITIALIZED, READY, RECOVERING, and UNAVAILABLE.

BUG=736222

Change-Id: I22811afece7f7d491c235247c33ba593f142bbc1
Reviewed-on: https://chromium-review.googlesource.com/567652
Commit-Queue: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487564}

This CL adds signin_promo_view and SigninPromoView Java counterpart
that are necessary for new signin promos on Android. This view will
be wired-up in the following CLs.

Bug: 737743
Change-Id: If3c34fc48d6ab91eff5e03ab6de5e1101b3df693
Reviewed-on: https://chromium-review.googlesource.com/566678Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Iulia Harasim <iuliah@google.com>
Cr-Commit-Position: refs/heads/master@{#487563}

TBR=rogerta
NOTRY=true

Bug: 745899
Change-Id: I04c8e24149b278a16e2cf14762ca965c91b8cec3
Reviewed-on: https://chromium-review.googlesource.com/576381
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487562}

Create PDF placeholder in ChromeContentRendererClient when the
enable_plugins build flag is off. Tested manually on mobile.

Bug: 737787
Change-Id: Iddb276b8ce71c92ee7fb626115269f2730b8b943
Reviewed-on: https://chromium-review.googlesource.com/575190
Commit-Queue: Amber Won <amberwon@google.com>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487561}

Bug: 737802
Change-Id: I5b1d11793f4edd19e9cb8b0d3435689b3b77f827
Reviewed-on: https://chromium-review.googlesource.com/574891
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487560}

Historically //ash has been inconsistent in its placement of FooTestApi,
TestFooDelegate, MockFoo, etc.

Top-level ash OWNERS have decided that this sort of test code should
live in the same directory as Foo, not in //ash/test.

Move the files, collapse //ash/test/BUILD.gn into //ash/BUILD.gn and
add a note to //ash/README.md

TBR=reveman@chromium.org

Bug: none
Test: compiles, ash_unittests
Change-Id: I22b556742c37f9a414824d2ce48f3fa261949b71
Reviewed-on: https://chromium-review.googlesource.com/576142
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487559}

* Create NetLog event for sending and receiving an HTTP/2 SETTINGS frame
  with the ACK flag set.
* Make BufferedSpdyFramerVisitorInterface an actual interface:
  all public methods are now pure virtual.
* Remove HostPortPair parameter from HTTP2_SESSION_RECV_SETTINGS event:
  this is leftover from SPDY, but in HTTP/2 it's always the same as the
  one logged from the constructor.

Change-Id: I16b5c226a2e5b167740a8c80f86920647d34c787
Reviewed-on: https://chromium-review.googlesource.com/570620Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487558}

Since r481209, the document creates composited scrolling layers with RLS even if
it doesn't overflow.  But PaintLayer::GetBackgroundPaintLocation didn't get the
memo.

Bug: 741858
Change-Id: I1fe09532eecc2bbd1b71c42e171bf86f4a893382
Reviewed-on: https://chromium-review.googlesource.com/570940Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487557}

The DCHECK is because on observer is being added but not
removed. Specifically exo's WmHelper installs an observer on
WindowTreeHostManager but WmHelper never removes itself (because
WindowTreeHostManager is deleted before WmHelper). This patch makes
WmHelper be destroyed before WindowTreeHostManager by way of making
ChromeBrowserMainExtraPartsAsh create exo related functionality.

BUG=none
TEST=none

Change-Id: I84e7209c817e4687017edbc14db7f75cb1054fbb
Reviewed-on: https://chromium-review.googlesource.com/572427
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487556}

Specifically, --delay-reload-stop-button-change

Bug: 734104
Change-Id: Ie923a0da9511a663c9a63efaf3d8ab01671a768a
Reviewed-on: https://chromium-review.googlesource.com/576250Reviewed-by: Terry Anderson <tdanderson@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487555}

This CL adds support for android_apk targets to post-process a resource
packaged APK.

Bug: 695304
Change-Id: Ic3b58f48fdfdf4e87ebf45546b2ef12369390aaf
Reviewed-on: https://chromium-review.googlesource.com/558427Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487554}

This string is not used anywhere in Chromium codebase.

R=pfeldman@chromium.org

Bug: none
Change-Id: Id3b32083bc7090e66cd3d3930241bf7a2fe86bd7
Reviewed-on: https://chromium-review.googlesource.com/566565Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487553}

BUG=745255

Change-Id: I5f9663a1710b8aac176ac7293eeff87ed4ab5fb7
Reviewed-on: https://chromium-review.googlesource.com/575571Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Vadim Tryshev <vadimt@chromium.org>
Commit-Queue: Jiaquan He <hejq@google.com>
Cr-Commit-Position: refs/heads/master@{#487552}

Following bot results are included.
753 754 755 757 760 761 762 763 765 766 767

41 lines were removed by consecutive passes since 730.

TBR=eae@chromium.org
NOTRY=true

BUG: 591099
Change-Id: Ic324594a8de627cd43e42c4835e9e1283165fabe
Reviewed-on: https://chromium-review.googlesource.com/575314Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487551}

This CL does not display the setting on any UI.
This setting is used to mute websites.

Bug: 742999
Change-Id: I4c15c809795b523b90a26f4b42b3d0b9d612d695
Reviewed-on: https://chromium-review.googlesource.com/570807Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487550}

V8 is starting to use guard regions and a signal handler to do out of bounds
checks for WebAssembly. This means out of bounds accesses will trigger a
segmentation fault, but V8 is able to recover from these and throw a Javascript
exception instead. In order to do this, V8 needs to cooperate with any existing
signal handlers.

This CL modifies Chromium's signal handlers to call V8's TryHandleSignal
function before taking any other actions so that V8 is able to recover from the
faults it expects.

BUG= chromium:722585, v8:5277

Review-Url: https://codereview.chromium.org/2885053005
Cr-Commit-Position: refs/heads/master@{#487549}

This symbol is used very frequently; saving the lookup is likely to be
worthwhile.

Found due to insight from RCS report. This improves a local microbenchmark
that measures adding/removing event listeners from script by about 25%.

Change-Id: I786a94f5bedcf6ea5ec45cf0d1ee19b791e7235d
Reviewed-on: https://chromium-review.googlesource.com/575273Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487548}

IDBRequestTest and IDBTransactionTest both had an identical helper
function CreateIDBValue. In jumbo builds those identical functions
collided so this patch moves the code to a shared helper file.

Bug: 745732

Change-Id: I36c658509c76deca4e03590858140e02a07f38d3
Reviewed-on: https://chromium-review.googlesource.com/575145
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487547}

This patch consolidates a few discardable image related work into fewer
classes in cc. Specifically, it moves all of the generation code into
discardable image map. It also removes display item list functionality
and just exposes discardable image map from there, since most of those
functions were pass-through.

R=enne@chromium.org, khushalsagar@chromium.org

Bug: 741775
Change-Id: I483d4544f35356465c09f9084d9a0ec3ae0a9029
Reviewed-on: https://chromium-review.googlesource.com/575347
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487546}

Bug: 
Change-Id: I616d2f8c72bfd3c871aded779c63e6ed47da7e88
Reviewed-on: https://chromium-review.googlesource.com/575784Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Gauri Manikpure <gmanikpure@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487545}

Converts web_state-related files to ARC.

Notable issues:
 - Had to fix WebUIMojoTest.MessageExchange. See comment.

Bug: 
Change-Id: Ia8a58433ab82d67ebae4f61b8c4ea954f84df202
Reviewed-on: https://chromium-review.googlesource.com/570402
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487544}

This allows to avoid copying text runs character-per-character
for 16bits text.

Also there is no need to hash per character, just hash the
whole string in one go. This also helps to save the construction
of a StringHasher object (as we use the static method to hash
the strings).

Finally, reserve in HashTable space for 500 words (this reduces
the number of rehashes in up to 4x).

Bug: 735674
Change-Id: I4c5e23bb1e21dad995d4948fae0943a2b01309e0
Reviewed-on: https://chromium-review.googlesource.com/564076Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487543}

Wire up the SplitViewController with the overview mode. It's a following
up CL of https://codereview.chromium.org/2960843004/.

Changes in this CL:
1. The split view mode can be initiated by dragging the window in
overview mode to the side of the screen
2. After one window is snapped to one side of the screen, all the other
overview windows will display in the other side of the screen, allowing
the user to select another window to snap. When two windows are snapped
to both sides of the screen, the overview mode will be ended.
3. The first snapped window will remain snapped until the user
explicitly exit the split view mode. All the other windows (incluing
newly created window) will be open in the other side of the screen.
Clicking/Tapping on the overview button also open the overview windows
in the other side of the screen.

Not covered in this CL:
1. The highlighted region showing where split will occur is not
   implemented in this CL.
2. The split divider is not implemented in this CL.

BUG=725683

Review-Url: https://codereview.chromium.org/2955203002
Cr-Commit-Position: refs/heads/master@{#487542}

In this CL, WorkerGlobalScope's |time_origin_| is set to the time of
creation. As a result, many time origins are no longer needed in
constructors.

Bug: chromium:688542
Change-Id: Ie15dccd7c81e6c29ad23244278fb7cc5131bdaf2
Reviewed-on: https://chromium-review.googlesource.com/563957
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487541}

Rename CreateSecureSpdySessionWithIpBasedPoolingDisabled to
CreateSpdySessionWithIpBasedPoolingDisabled (since every SpdySession is
now secure).

BUG=737143

Change-Id: I0882d68eeb6f348da88d1904f04ab2b2748fe007
Reviewed-on: https://chromium-review.googlesource.com/570624Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487540}

A common behavior on Android is for the user to press home or recents
button accidently and get back to the app. This behavior would cause
Chrome to clear the contexts and recreate which is a waste of time. So,
add a 5 second delay before clearing the context.
As a side effect, this delay also considerably lowers the risk of the
renderers initializing the GPU command buffer after clearing since they
usually receive the "not-visible" message within 5 seconds.

BUG=725303

Change-Id: I7d2655c75b66cf073b82c270baa3f1f3b27b3a8a
Reviewed-on: https://chromium-review.googlesource.com/571294
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487539}

TBR=kbr@chromium.org
NOTRY=true

BUG=745888

Change-Id: I74fc63416e07782daa5915fafcdd51fc4d40cb67
Reviewed-on: https://chromium-review.googlesource.com/576081Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487538}

This reverts commit bc12faf7.

Reason for revert:
Broke ash_unittests https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/28275

Original change's description:
> reland: shelf: Add a back button to the shelf.
> 
> This is in preparation for removing title bars work. See mocks in the bug and screenshots for more details.
> This approach of adding a back button expands the current app list button to be modal and have two functionalities
> depending on which side is pressed. The alternative (seperate back button) is IMO very difficult to achieve what
> is shown in the mocks (namely the color in between and animation (not in this CL) of said color in between). The
> exact functionality of the back button is not 100% defined yet, this CL just sends a VKEY_BROWSER_BACK event in the
> meantime.
> 
> Screenshots:
> https://screenshot.googleplex.com/ZVNP0aq0cc3
> https://screenshot.googleplex.com/fDcGTuoyZg5
> https://screenshot.googleplex.com/ZFBzk72LLVt
> 
> Test: ash_unittests --gtest_filter="ShelfViewInkDropTest.*"
> Bug: 721940
> Change-Id: I0b2be5cc66583d521721ec1378a19e0026c5c7e1
> Reviewed-on: https://chromium-review.googlesource.com/572434
> Commit-Queue: Sammie Quon <sammiequon@chromium.org>
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487491}

TBR=msw@chromium.org,oshima@chromium.org,sammiequon@chromium.org,msw@google.com

Change-Id: I24a268a0850db947ffb9674653837fb11ed64621
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 721940
Reviewed-on: https://chromium-review.googlesource.com/576195Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487537}

NOTRY=true
TBR=rogerta

Bug: 745887
Change-Id: Id57a77c44fb2ec0846c2ae179269dd7fbb0db3b5
Reviewed-on: https://chromium-review.googlesource.com/576225Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487536}

Use the flat data accessor instead.

BUG=728627

Change-Id: I0ff48a9e4d1ce60c0fcc822ac6b839f3fb1ad6e0
Reviewed-on: https://chromium-review.googlesource.com/574576Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487535}

+ Infobar secondary text from #646464 to 54% black
+ Infobar big icon control message to 20sp
+ Conneciton info url from bold to medium
+ Conneciton info description line height to 20
+ Page info secure scheme "https" text to medium
+ Page info and connection info link text to #3367D6
+ Bluetooth dialog link text to #3367D6
+ Bluetooth dialog bottom margin to match button right margin

BUG=723044,723054

Change-Id: I2646135c31d3328d0028b831275941ab00278382
Reviewed-on: https://chromium-review.googlesource.com/572545Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487534}

Add a check to SetICUDefault() and fall back to en-US when an incoming
locale id fails to create a valid icu::locale instance.

Roll ICU to b971435d43 to pick up an upstream fix.

icu::Locale::setDefault() can fail when an invalid/too long locale id is
passed. It appears that this might happen when the locale id comes from
GetOverrideLocale() on iOS.

A test added is similar to what the upstream added in the upstream fix (
http://bugs.icu-project.org/trac/changeset/40267 ) which was cherry-picked in
https://chromium-review.googlesource.com/c/574935/ .


BUG=chromium:734093
TEST=base_unittests --gtest_filter=SetICU*

Change-Id: If8d3522b23a257466ca3c31b66089cb415fec3a2
Reviewed-on: https://chromium-review.googlesource.com/574936Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487533}

BUG=

Change-Id: Id1fe889bc5395fc7d4de8911437705e090dbf436
Reviewed-on: https://chromium-review.googlesource.com/576230Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487532}

As we develop the new architecture, some actions/items/flows,etc. will 
be no-op since they are part of a working component, but its functionality 
hasn't been developed yet. (e.g. Some menu items. The Menu itself is working 
and it displays the items, but some of these items are not working yet).

In order to differentiate no-op actions from broken ones, we will display a 
simple alert for no-op actions, this way we'll know if something was/is broken, 
or if it still hasn't been implemented yet. 

This CL implements these alerts for the NTP, Toolbar and ToolsMenu. 

Bug: 740793
Change-Id: I128a289403f3fb20342d451cd15699fbacade2e1
Reviewed-on: https://chromium-review.googlesource.com/570846Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487531}

Specify labels that are referenced using the aria-labelledby attribute to passwords section's searchInputs and passwords. Remove the for attribute, not needed since we are using aria-labelledby instead.

Bug: 737739
Change-Id: Ibdc7d0752d2e1972c8692ca743e39ababc24f868
Reviewed-on: https://chromium-review.googlesource.com/568240Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tina Quach <quacht@google.com>
Cr-Commit-Position: refs/heads/master@{#487530}

Apparently there is still an x11 chromeos bot. This should fix the
build for it.

TBR as this is trivial change to add ifdefs and should fix bot.

BUG=701068
TEST=none
TBR=erg@chromium.org

Change-Id: I55aad4f264ece847338e98eac635262c1583ac26
Reviewed-on: https://chromium-review.googlesource.com/576280Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487529}

https://pdfium.googlesource.com/pdfium.git/+log/61a3cb81a298..fe1c8e616680

$ git log 61a3cb81a..fe1c8e616 --date=short --no-merges --format='%ad %ae %s'
2017-07-18 reed colortables are unused, so remove plumbing
2017-07-18 rharrison Correct lexer handling of FormCalc identifiers
2017-07-18 rharrison Add tools for generating coverage information

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Ibf68e8b115637a659281fdd25fd8c6c8be0987d5
Reviewed-on: https://chromium-review.googlesource.com/576190
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487528}

NOTRY=true
TBR=rogerta

Bug: 713049
Change-Id: I33dbfdd3de58f03472d95f42abd60977f2749a0b
Reviewed-on: https://chromium-review.googlesource.com/576254Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487527}

This CL migrates ArcNotificationManager.

BUG=672829
TEST=Ran try. Ran on DUT.

Change-Id: I4b7283246b9d808fe61a97e20061a4b87c8c0321
Reviewed-on: https://chromium-review.googlesource.com/574890Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487526}

Add ScrollableArea only if the box size is not zero and
there is a horizontal or vertical overflow scroll.

BUG=711474
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2857583007
Cr-Commit-Position: refs/heads/master@{#487525}