- 24 Apr, 2018 40 commits
-
-
Kenichi Ishibashi authored
The current threshold came from my local experiments and it wouldn't be necessarily an appropriate value. Make the threshold configurable so that we can run experiments in the real world. Bug: 776665 Change-Id: I6ae896439eb50985221258b9109f6f06e3aea178 Reviewed-on: https://chromium-review.googlesource.com/1022410 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#552963}
-
Jinsuk Kim authored
Removes API getWebContents/getContainerView from ContentViewCore. ContentViewCore object is passed around in numerous cases just to get WebContents/container view from it. Embedders already has access to its container view (through Tab instance for Chrome, AwContents for WebView). So passing WebContents instead is enough. And content layer gets the active container view through WebContents.getViewAndroidDelegate added by https://crrev.com/c/994500. Bug: 598880 Change-Id: Ic3abd837a8751be6f1aacbe3364901e92db8b1cc Reviewed-on: https://chromium-review.googlesource.com/1015457 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#552962}
-
Wang Qing authored
Fix LayerTreeHostFiltersPixelTest.BackgroundFilterBlurOutsets has 3474 pixel differences on Loongson. Set percentage_pixels_large_error on Loongson. BUG= 819110 R= fsamuel@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I680f9c5f2eb36f8387bf4e5edf5cfe19da2108e3 Reviewed-on: https://chromium-review.googlesource.com/1023710Reviewed-by:
enne <enne@chromium.org> Commit-Queue: 汪 清 <wangqing-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#552961}
-
Wang Qing authored
Set percentage_pixels_large_error on Loongson. BUG= 819075 R= fsamuel@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I684f2aa6c27e521212ca0f4faac3b966bb3064d9 Reviewed-on: https://chromium-review.googlesource.com/1023002Reviewed-by:
-
Xiaocheng Hu authored
This patch removes a leftover "/*" from the copyright header of the file. Notry: True Change-Id: I2d44da15a07e9003756647dfc631a8e813259380 Reviewed-on: https://chromium-review.googlesource.com/1025180Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552959}
-
Xianzhu Wang authored
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib5b868a0a581ad8e66bd49208b3262dc79251b4f Reviewed-on: https://chromium-review.googlesource.com/1023157Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#552958}
-
Christian Fremerey authored
This reverts commit 70038d92. Reason for revert: Flakiness may have been resolved with recent changes on tip of tree. No longer seems to repro on local build. Original change's description: > Reland "Disable WebRtcBrowserTest.NegotiateNonCryptoCall on Mac" > > This reverts commit b909c213. > > Reason for revert: Re-Disable the flaky test until a fix is found > > Original change's description: > > Revert "Disable WebRtcBrowserTest.NegotiateNonCryptoCall on Mac" > > > > This reverts commit cfec3da6. > > > > Reason for revert: Checking if flakiness is still happening on Mac ASAN bot > > > > Original change's description: > > > Disable WebRtcBrowserTest.NegotiateNonCryptoCall on Mac > > > > > > TBR=chfremer@chromium.org > > > > > > Bug: 810321 > > > Change-Id: Ia12ba855ab9fb8e66c9d48c8e66cf91f76f72e08 > > > Reviewed-on: https://chromium-review.googlesource.com/908461 > > > Reviewed-by: Olga Sharonova <olka@chromium.org> > > > Commit-Queue: Olga Sharonova <olka@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#535381} > > > > TBR=olka@chromium.org,chfremer@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 810321 > > Change-Id: I6e021bca934428cf9c94a34d4f0e874c25868033 > > Reviewed-on: https://chromium-review.googlesource.com/1010842 > > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#550380} > > TBR=olka@chromium.org,chfremer@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 810321 > Change-Id: I68a7e09599e1511e8b4c547e7932e874689ab224 > Reviewed-on: https://chromium-review.googlesource.com/1013018 > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550867} TBR=olka@chromium.org,chfremer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 810321 Change-Id: Ie796bb3b206c6855d9859d8f18ec008e7ac4892a Reviewed-on: https://chromium-review.googlesource.com/1024746Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#552957}
-
yoshiki iguchi authored
We need support notification importance so we update the table. And we also support "NONE" priority which is corresponding IMPORTANCE_NONE Bug: b/78328208 Test: None Change-Id: I249f5392adbc8e386b001f5f29e759b7172cadac Reviewed-on: https://chromium-review.googlesource.com/1021005Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#552956}
-
Ehsan Chiniforooshan authored
The GPU process is launched from the IO thread; so, it cannot access BrowserMainLoop (should be accessed from the UI thread) to get the status of startup tracing (crbug.com/828993). This CL simplifies dealing with startup tracing flags by centralizing the logic in TraceStartupConfig. Then, we can get information about startup tracing through TraceStartupConfig, only. Bug: 828993 Change-Id: Ia868fed264b534526ad054414ae2a1e12f5c0ac5 Reviewed-on: https://chromium-review.googlesource.com/1015647 Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#552955}
-
Christopher Cameron authored
When navigating, make the old RHWVMac dump its ui::Compositor in TakeFallbackContentFrom, and have the new RWHVMac pick it up. Ensure that the ui::AcceleratedWidgetMac preserve its contents through this transition. This is not enough to completely eliminate all flashes, because the NSViews in play aren't being atomically swapped. Bug: 829523 Change-Id: Ica6eab8dcea7a7987e8b7f83dbfd24acb2c6f7c4 Reviewed-on: https://chromium-review.googlesource.com/1023653 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#552954}
-
dpapad authored
Last user was old Extensions UI, which was recently removed. Bug: 820187 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I50aeda59349f31b59965437200c6f4cc9eecfca3 Reviewed-on: https://chromium-review.googlesource.com/1025048Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#552953}
-
Tetsui Ohkubo authored
According to UX spec, if a feature pod button is togglable and has a detailed view, the icon click should toggle the feature and the label click should show the detailed view. This CL changes the behavior of Network feature pod button to follow this rule. This CL only supports toggling of WiFi. Supports of other network will be added later. TEST=manual BUG=821671 Change-Id: I052be3b0db647ac88e5c37a9f0fda4fd0187fc39 Reviewed-on: https://chromium-review.googlesource.com/1018261Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#552952}
-
Matt Menke authored
This was broken by https://chromium-review.googlesource.com/c/chromium/src/+/1016707. It was exercising three URLLoader destruction paths, with that CL landed: * Mojo notification that the data pipe was closed. * Mojo notification that the URLLoader pipe was closed. * Noticing the data pipe was closed when trying to write to it. The above CL made the first case fail with ERR_FAILED and the other cases fail by just closing the pipe. This CL fixes that. It also moves the URLLoader pipe closed case to another test, and re-enables a new test I disabled pre-emptively when disabling URLLoaderTest.CloseResponseBodyConsumerBeforeProducer, which was not flaky. Bug: 832600 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I788b8a4d2819d623fc2e46a7a8109f91c32d0fbc Reviewed-on: https://chromium-review.googlesource.com/1017441Reviewed-by:
-
Kevin Marshall authored
Removing the "shell" capability allows packaged apps to load dynamic libraries from the package. In addition, it prevents the app from using any system-provided libraries, in favor of the package supplying all of its data and dynamic library dependencies. This CL includes the system libraries from the SDK's "dist" directory in packages built using the package() GN template. Bug: 823927 Change-Id: Ibc22913658f73d992e563e829a377be66f61f805 Reviewed-on: https://chromium-review.googlesource.com/1025046Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#552950}
-
Lukasz Anforowicz authored
Bug: 835577, 835578 Change-Id: I4461cec21b31ee9945afe4e2b1df7c89d9905168 Reviewed-on: https://chromium-review.googlesource.com/1024401 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#552949}
-
Jun Mukai authored
Bug: 831423 Test: None Change-Id: If8e8a2e88d009dfea258b79f6b914444f28816ee Reviewed-on: https://chromium-review.googlesource.com/1024735Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#552948}
-
erikchen authored
History expiration is very disk intensive. When the machine wakes from sleep, it potentially also needs to read its memory from disk, thus causing heavy contention. Bug: 808031 Change-Id: If9a4cfac8a0b323489364fc5c9ad7d72bafb0333 Reviewed-on: https://chromium-review.googlesource.com/1024290 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/9b20677c4e71..e987f2b76567 $ git log 9b20677c4..e987f2b76 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6778b415d4a9f248847f3dd9c36fb9539c95e125 Reviewed-on: https://chromium-review.googlesource.com/1024636 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552946}
-
Scott Violet authored
The implementation is no longer going to be trivial, so renaming. BUG=none TEST=none TBR=sadrul@chromium.org Change-Id: Icad4e8d85d7b2d87e331223247d596d54732e1dc Reviewed-on: https://chromium-review.googlesource.com/1024635Reviewed-by:
-
Kent Tamura authored
Also, replace WebKit/WebCore in code and file names with "blink." Bug: 829697 Change-Id: Ia2e9a0ad1748a7fbb0d7b4da7d4143bfbc1e5267 Reviewed-on: https://chromium-review.googlesource.com/1023627Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#552944}
-
Kent Tamura authored
The Great Blink mv didn't rename them because they were referred by generated code. This CL fixes the generator code, make_instrumenting_probes.py, and rename the files. Bug: 768828 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6facdf7b6c0bc681c6883dd46dd68c93c6eed737 Reviewed-on: https://chromium-review.googlesource.com/1015458Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#552943}
-
Wez authored
Using whitespace breaks ExtensionUpdater query parameter generation. Bug: 832728 Change-Id: I191d175d623803d4655d22caf422bf7127bdc57c Reviewed-on: https://chromium-review.googlesource.com/1016138Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#552942}
-
Nick Harper authored
Change-Id: I651c9f0527565d7bab66e2e817f957249e28f131 Reviewed-on: https://chromium-review.googlesource.com/1024882Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#552941}
-
Peter Qiu authored
The permission checking will be done using the extension's permissions specified in its manifest data, similar to what is being done in ShellExtensionHostDelegate. Also moved media_capture_util code to extensions/browser for better code sharing and add an API for checking media access permission for a given extension. Bug: b/78193883 Test: Build Change-Id: I7bd9d9a771b5a6d8ca719b5480e42f4624a1bb69 Reviewed-on: https://chromium-review.googlesource.com/1022316 Commit-Queue: Peter Qiu <zqiu@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#552940}
-
Yafei Duan authored
We also need to record the permission denied when asking for storage permission before publishing an offline page for sharing in Download Home. Bug: 836011 Change-Id: Ief294b69a88054a7201ba6d0ecf8bc53d77b7bc7 Reviewed-on: https://chromium-review.googlesource.com/1024741Reviewed-by:
Joy Ming <jming@chromium.org> Commit-Queue: Yafei Duan <romax@chromium.org> Cr-Commit-Position: refs/heads/master@{#552939}
-
Wenzhao Zang authored
Only changed comments. Removed some outdated TODOs by bshe@ or crbug.com/776464. TBR=bshe@chromium.org Bug: None Change-Id: I3a857bd02c5fbf8b9c454d91b030dcb1ebd10eeb Reviewed-on: https://chromium-review.googlesource.com/1024740Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#552938}
-
Scott Chen authored
Bug: None Change-Id: I231cffdd854d5ef3876a170b5c4ec7b70cbbafc1 Reviewed-on: https://chromium-review.googlesource.com/1022509Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552937}
-
Mostyn Bramley-Moore authored
CL https://chromium-review.googlesource.com/c/chromium/src/+/1019885 added another copy of GetUniqueDownloadId(), which causes jumbo builds to fail. Let's move this duplicated code to download_utils.cc instead. Change-Id: I39cbae92f33afc9733a47e376a4f67ce9b088c7b Reviewed-on: https://chromium-review.googlesource.com/1025090Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552936}
-
Scott Violet authored
As part of bug 800358 I moved loading ResourceBundle earlier (specificaly to PreEarlyInitialization()). Unfortunately I missed that OverrideLocaleWithUILanguageList() needs to be called before this. This means the locales were not being picked up correctly for Windows. This patch moves calling OverrideLocaleWithUILanguageList() to before PreEarlyInitialization() so that locales are properly loaded. I tried adding a DCHECK that the locales are set before GetLocaleOverrides() is called, but that appears to break things. BUG=834372 TEST=see bug Change-Id: Idb40ee30761034a6c67ac153da3f9cebc9f7de40 Reviewed-on: https://chromium-review.googlesource.com/1025070Reviewed-by:
-
Michael Thiessen authored
With Quad layers keeping the content quad high-res and crisp, we can lower the buffer size of the rest of our UI which doesn't need to be as high quality as the content quad. The quality decrease is only barely noticeable on an A/B toggle, and the performance win is huge (and necessary to get us back to 60fps on a Pixel XL device). Bug: 714304 Change-Id: I0f352f88789584e51815baafe0f25d69fb7e8780 Reviewed-on: https://chromium-review.googlesource.com/1024881Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#552934}
-
Tommy C. Li authored
For Material Refresh, we want to place the default search provider's favicon into the location bar while the user is typing search queries. This CL adds some scaffolding necessary for OmniboxView to provide the favicon. The actual favicon fetching must be asynchronous, so we need this extra infrastructure. I expect this CL to be Part 1/4 or so of the primary implementation. Bug: 823535 Change-Id: Ia7d6979222fd18e4a34fd1473f00164ecc8a1c7b Reviewed-on: https://chromium-review.googlesource.com/1022500 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#552933}
-
Devlin Cronin authored
The ExtensionFunction::GetAssociatedWebContentsDeprecated() method is unpredictable and can return surprising values in certain circumstances. It is deprecated and should be removed to ensure that callers are using the WebContents they expect. Update the passwordsPrivate API to use GetSenderWebContents() instead. Bug: 461394 Change-Id: I0395f553b3a62b0db843893243e32f727955ab21 Reviewed-on: https://chromium-review.googlesource.com/1022977Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552932}
-
Tetsui Ohkubo authored
This CL fixes keyboard accelerators when UnifiedSystemTray is enabled. Previously, Alt-Shift-S opens old SystemTray, and Alt-Shift-N crashes. Alt-Shift-S should open UnifiedSystemTray. Alt-Shift-N should be no-op. TEST=manual BUG=835750 Change-Id: I42a21f3331719ccd17524658293b0b5ae75d1113 Reviewed-on: https://chromium-review.googlesource.com/1023500Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#552931}
-
Tetsui Ohkubo authored
This CL adds ChromeOS.SystemTray.TimeToClick metrics to both old SystemTray and UnifiedSystemTray. TimeToClick is the amount of time a user took from clicking on the button in status area, to clicking on an item in the system tray bubble. The system tray view installs TimeToClickRecorder as PreTargetHandler, and it calls SystemTray::RecordTimeToClick. TEST=manual(chrome://histograms) BUG=834462 Change-Id: Id7b599faf9bf53279be228816c39b05170db0d90 Reviewed-on: https://chromium-review.googlesource.com/1018120Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#552930}
-
Lei Zhang authored
This reverts commit 6ceb3883. Reason for revert: New tests have memory leaks. https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27171 Original change's description: > Use user preferences for TTS speech rate, pitch and volume if not set. > > Bug: 823359 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I772e1fa78e0f3f7ed3a6ab858f4855f65f18513f > Reviewed-on: https://chromium-review.googlesource.com/1014491 > Commit-Queue: Katie Dektar <katie@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552826} TBR=thakis@chromium.org,dtseng@chromium.org,jochen@chromium.org,katie@chromium.org Change-Id: I8702500882bf4e8a499c7798306976bd18ad260b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 823359 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1025290Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#552929}
-
Patti authored
The erase icon that appears on editing the omnibox in touch mode is too small. Update its size. Bug: 832113 Change-Id: I64768a9e1d6e91eec03a03b22863d1a4d8cf2ff2 Reviewed-on: https://chromium-review.googlesource.com/1023623Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#552928}
-
Peter Boström authored
Previous version had white "=(" which wouldn't work well for incognito after tinting to white (smiley and folder would both be white-ish). With a transparent smiley the underlying dark-grey tab renders through as dark eyes for a light-grey folder. Bug: chromium:834645 Change-Id: I1c4f80004ee7a7227fef231d9b136a4a8c5ee566 Reviewed-on: https://chromium-review.googlesource.com/1022744Reviewed-by:Cait Phillips <caitkp@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#552927}
-
Peter Qiu authored
This provides an ability to programmatically grant media access permission for a guest view, which is a desired feature on certain devices. Bug: b/78193883 Test: Build Change-Id: If733c28125e4228a1c50baf11f9715c7d876da67 Reviewed-on: https://chromium-review.googlesource.com/1021599Reviewed-by:
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=battre@chromium.org Bug: 825327 Change-Id: I09f2ec144a8cd311d705ad3cfe3ac6da75cc4ca8 Reviewed-on: https://chromium-review.googlesource.com/1024319 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#552925}
-
junweifu authored
Original CL got reverted because the num of landmarks aren't updated in services tests that aren't checked on GPU FYI. This is a reland of 5e1aa79b Original change's description: > ShapeDetection: Parse landmarks of the detected face on Mac Vision > > Update the mojom interface definition of landmark to match the Spec, and adjust > the usage in services/blink/LayoutTests. > Export eyes and mouth landmarks that detect with Mac Vision Framework, the points > are normalized to the bounding box of the detected face, with the origin at the > bounding box of the detected face's lower-left corner. > > Link Mac 10.13 build bots [1] and Face Detection demo[2] here. > > [1] https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/ > [2] https://codepen.io/miguelao/pen/PmJWro > > BUG=799319 > > Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng > Change-Id: Id034721a517e4ab2a6b9aa0e3eec9d10997b5b80 > Reviewed-on: https://chromium-review.googlesource.com/982579 > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Junwei Fu <junwei.fu@intel.com> > Cr-Commit-Position: refs/heads/master@{#552217} TBR=mark@chromium.org Bug: 799319 Change-Id: Id521f2a92dd3e1c6d8ac29d571bc1c58cfdb020e Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1023181 Commit-Queue: Junwei Fu <junwei.fu@intel.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#552924}
-
