- 12 Dec, 2017 40 commits
-
-
Tom Sepez authored
The restriction is only required when "temporary file" permissions have been granted, since that is what implies no access to pre-existing files. Fixes the issue hit by https://chromium-review.googlesource.com/c/chromium/src/+/818486 in that the network service may try to ensure a file is present via a single call with O_CREAT without knowing if it pre-exists. Change-Id: I3cf3f2389a78a5a46f43505a64d106614e4dcf90 Reviewed-on: https://chromium-review.googlesource.com/820611 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#523527}
-
Shivani Sharma authored
HttpCache.ParallelWritingPattern histogram's 0 enum value is actually a valid value and not undefined. This CL fixes the description and adds tests for testing the 0 value. Bug: 472740 Change-Id: Iac4cdb38b6141221e901003e3540c60228626400 Reviewed-on: https://chromium-review.googlesource.com/820191Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#523526}
-
Dave Schuyler authored
This CL replaces some examples of using old i18n with new $i18n{} replacements. Bug: 677338 Change-Id: Ibdd8b98bd067262879ea11842b5b20c2c4ac34e7 Reviewed-on: https://chromium-review.googlesource.com/820550 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#523525}
-
Boris Sazonov authored
This CL implements account list filtering when there are multiple accounts on the device and one of these accounts is a child account. In this case AccountManagerFacade will expose the child account only. Bug: 779568 Change-Id: I70fb00fc692e3f54c779ac618167afd9ad728c09 Reviewed-on: https://chromium-review.googlesource.com/819414Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#523524}
-
Maks Orlovich authored
In particular the motivating case was when the partial write was before the bitmap... ... however this is done by rewriting the function entirely to be formulated in terms of net::Interval, since I found the details of the original pretty much inscrutable, but believe to have understood both the data representation and the interface. Bug: 791056 Change-Id: I297ee4cbcfc204df8ccab9c45145eaf0a82eb0b7 Reviewed-on: https://chromium-review.googlesource.com/806687Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#523523}
-
Daniel Hollingshead authored
This cl lands server change 177974921 by dahollings. BUG=488484 Change-Id: Idcfd03b2163aded499ea6858a490f0b80146ba4d Reviewed-on: https://chromium-review.googlesource.com/821092Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Daniel Hollingshead <dahollings@chromium.org> Cr-Commit-Position: refs/heads/master@{#523522}
-
Will Chen authored
Part manual, part automated migration for these tests. Many of these weren't html tests and require special treatment (typically navigating the inspected page to a special resource file). Bug: 667560 Change-Id: I70d5813346e2a59abf1f72390189c76563fbd023 Reviewed-on: https://chromium-review.googlesource.com/820605Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#523521}
-
Randy Smith authored
This refactor is to remove the passed URLRequestContextGetter as an argument, preperatory to shifting cookie deletion in StoragePartitionImpl over to Mojo interfaces. Bug: 721395 Change-Id: I4568cb5ffd98591605a7c5d8b3850c5d8cd5d9b7 Reviewed-on: https://chromium-review.googlesource.com/754518 Commit-Queue: Randy Smith <rdsmith@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#523520}
-
Scott Graham authored
In order to roll GN f3a5b8c1..a37803c9 (r520777:r523254) and pick up the following changes: a37803c9 Don't print warning for unused default args 06ebd496 GN: don't deadlock when encountering import loops e48b26a4 Remove base::Value::IsType 6713d85d Generate relative paths for build.ninja and build.ninja.d TBR=dpranke@chromium.org Change-Id: I1cb88049988dd4c3ccfd858909a31830cd9acb8c Reviewed-on: https://chromium-review.googlesource.com/821210Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523519}
-
Artur Khachatryan authored
Test ChromeLoggingCapabilityTest.testPerformanceLogger is flaky on Android. Disabling for now until the bug is fixed. Bug: chromedriver:2108 Change-Id: I12fabca049de4e5366e426e519ef4e84e1a6c873 Reviewed-on: https://chromium-review.googlesource.com/822918Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#523518}
-
Eric Lawrence authored
TBR=palmer@chromium.org Bug: 794171 Change-Id: I7b418f308affbde0586aca0c15f7578b073ac9d8 Reviewed-on: https://chromium-review.googlesource.com/822292Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#523517}
-
chrome://gpuSunny Sachanandani authored
Relying on "Supports overlays" is misleading because we might be using direct composition surfaces without overlays. R=piman,zmo BUG=776403 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I468e73fb0ec75fb03fe5e5273001c36d548b765b Reviewed-on: https://chromium-review.googlesource.com/820770Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#523516}
-
Abhishek Arya authored
R=dpranke@chromium.org Bug: 783296 Change-Id: Id7331db499a8e448c8e58cabab4e7b170e45db93 Reviewed-on: https://chromium-review.googlesource.com/821853 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/a4789fffa5f9..f7aa204aafe9 $ git log a4789fffa..f7aa204aa --date=short --no-merges --format='%ad %ae %s' 2017-12-12 dsinclair Move Script_Attribute_String to CJX_Object Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iecef075f30b2cef3a6124ee1437bffa36f6011e7 Reviewed-on: https://chromium-review.googlesource.com/822516 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523514}
-
Sunny Sachanandani authored
Worker context is on a different share group from compositor context so worker context lost notification does not propagate to compositor context. This is mostly fine because we restart the gpu process anyway but we don't for synthetic context loss such as out of memory conditions. R=piman,danakj BUG=786570 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I4afda056ba7399806c9dd56d83a2efb208c95847 Reviewed-on: https://chromium-review.googlesource.com/795184 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
-
Vladimir Levin authored
This patch makes it possible for cache entries to specify their own ids namespaced to the type of the entry. This makes it possible for things that already have unique ids to just use those, minimizing the risk of duplicate cache entries. At the same time the old behavior can be reproduced by a static incrementing id counter per cache entry type. R=ericrk@chromium.org, piman@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I76ebaf5650d2f44b1480420bbe7fe3b1726e6b92 Reviewed-on: https://chromium-review.googlesource.com/820600 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
-
Daniele Castagna authored
In order to debug dmabuf mmap failures, we added all parameters to the logs. Since dmabufs mmap issues have been addressed, this CL removes mmap parameters from the ERROR log. Bug: 629521 Change-Id: I09ea05956a60bdac53cd775534c979c5a7f82f95 Reviewed-on: https://chromium-review.googlesource.com/822814Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523511}
-
Egor Pasko authored
Small refactoring to eliminate the warning in Android Studio: "This AsyncTask class should be static or leaks might occur". There is not much benefit, because holding a reference (via the anonymous AsyncTask) to the instance of LibraryLoader won't change the lifetime of this LibraryLoader. There is some additional verbosity as well :/ Given the amount of subtleties around the use of AsyncTask, having uses of it being consistent with the Lint recommendation seems worth it. Bug: None Change-Id: I9e2d8c2c427bb6e565f3b4dc11c59904069c7b36 Reviewed-on: https://chromium-review.googlesource.com/819352 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#523510}
-
Ryan Sturm authored
Bug: 793137 Change-Id: Ifb14055f98fbe75523aaca6d61cf0ed85b9ef70c Reviewed-on: https://chromium-review.googlesource.com/820560 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#523509}
-
Robert Sesek authored
Bug: 598854 Change-Id: I0f2ad410d87e27bac5686091b31fbbab311acf14 Reviewed-on: https://chromium-review.googlesource.com/820855Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#523508}
-
Joshua Bell authored
Avoid key repeat triggering an unintentional commit of the subsequent dialog by launching the picker on the Enter keyup event rather than on keydown. Bug: 637098 Change-Id: Ia327a7a9f92c34fd3fcdf971d8c21a5ce744254b Reviewed-on: https://chromium-review.googlesource.com/814916 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#523507}
-
Thanh Le authored
The map data structure is not really a good fit since we can replace the data holds in the key to an attribute in the value field. Bug: 786996 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib3f62522f2b3ea8a890bc1ba21d56509d5f13e8f Reviewed-on: https://chromium-review.googlesource.com/817517Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
Matt Menke authored
This CL passes in the path for the network service to open. It's an intermediary step towards opening the file in-process and passing the file handle to the service instead. Bug: 746977 Change-Id: Ic432cd2d78027a83e9f63e2bc2a66c0eea51b937 Reviewed-on: https://chromium-review.googlesource.com/811887 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#523505}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/6e64f3089104..c896eddc1cf7 $ git log 6e64f3089..c896eddc1 --date=short --no-merges --format='%ad %ae %s' 2017-12-12 caryclark stabilize catalog 2017-12-12 mtklein a little SkJumper tidy up 2017-12-12 caryclark only read color array if flag is fixed color 2017-12-12 caryclark fix fractured fiddles 2017-12-12 angle-deps-roller Roll skia/third_party/externals/angle2/ feb2c63b7..7f5c3eb76 (1 commit) 2017-12-12 mtklein drop to scalar mode in some armv7 debug builds 2017-12-12 rmistry Use new bookmaker flag to status.json 2017-12-12 angle-deps-roller Roll skia/third_party/externals/angle2/ 629a64498..feb2c63b7 (1 commit) 2017-12-12 ethannicholas converted vertex shaders to device coords 2017-12-11 csmartdalton Prefer fullscreen clears on Qualcomm/GL Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=liyuqian@chromium.org Change-Id: I7309047da1e544139004cf7a89f8a53b50b27b05 Reviewed-on: https://chromium-review.googlesource.com/822913Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523504}
-
Aaron Leventhal authored
The Omnibox provides suggestion text that is friendly to screen reader users. However, it is not possible for users to know where they are in the overall list. Normally, screen reader lists provide "n of m" positional info at the end of each item. Because we are using a bit of a hack so that focus can stay in the edit box, we need to provide this info ourselves. The downside of this approach is that the text will not show up as the shorter n/m on Braille displays, but it's really a minor downside compared with the benefit. Bug: 792954 Change-Id: I3b69bc92ed42c59521ddf80cf932323388f650ab Reviewed-on: https://chromium-review.googlesource.com/817675 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#523503}
-
Jens Widell authored
In jumbo/unity builds it conflicts with syncer::WriteTransaction defined in components/sync/syncable/write_transaction.h. Change-Id: I19a325af6299d955577aec10d36f21b948859035 Reviewed-on: https://chromium-review.googlesource.com/822091Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Jens Widell <jl@opera.com> Cr-Commit-Position: refs/heads/master@{#523502}
-
xlai authored
As a prepartory step to remove ImageBuffer, this CL moves the GetImageData function (which has nothing to do with ImageData) from ImageBuffer to StaticBitmapImage. Some unnecessary checks (e.g., IsSurfaceValid() which has been checked over and over again) in the function have been removed. Bug: 776806 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iab7a346644027901bb10c96cc9c62a0e4336748d Reviewed-on: https://chromium-review.googlesource.com/820016 Commit-Queue: Olivia Lai <xlai@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#523501}
-
Guido Urdaneta authored
A previous CL that moved some of the functionality to Blink missed this, which prevents firing of the devicechange event. Bug: 794177 Change-Id: I5ab74f5605979ec508c0620d75eb41585b32f218 Reviewed-on: https://chromium-review.googlesource.com/822259Reviewed-by:
Chandan Padhi <c.padhi@samsung.com> Reviewed-by:
-
Daniele Castagna authored
We observed AddFramebuffer2 failing with "Invalid argument (22)" in few occasions (crbug.com/789292 and crbug.com/779356). This likely causes pageflip failures. This CL adds logs with all the paramters passed to AddFramebuffer2 to help debuggining these issues. Bug: 789292, 779356 Change-Id: I010986b080ee7b84c3084fe7010483b8f1c0143c Reviewed-on: https://chromium-review.googlesource.com/822273Reviewed-by:
-
Hans Wennborg authored
Recent Clang versions have started to take into account the signedness of enums for the -Wsign-compare warning. TBR=lpromero Bug: 792519 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4e1ab7030fc46690943954229e13246a085136de Reviewed-on: https://chromium-review.googlesource.com/823091Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#523498}
-
Eugene But authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic7c34b7594afea46412b2ac861ced2b60d01d7c7 Reviewed-on: https://chromium-review.googlesource.com/822511Reviewed-by:
-
Kyle Horimoto authored
This remedies the following situation: (1) Host scan discovers a potential Tether host device. (2) User visits the "internet detail page", which displays information about that Tether host. (2b - optional) User opens the tether confirmation dialog. (3) A subsequent host scan can no longer find the device. (4) User can no longer connect to the device, but has no idea why. This CL places a warning in red text on both the internet detail page and the tether confirmation dialog when this situation occurs. Likewise, this CL also adds a warning in the detail page for Wi-Fi networks which have gone out of range. Bug: 750955, 672263 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I75666e25a0df0add94ea469599641b0703b64d76 Reviewed-on: https://chromium-review.googlesource.com/818465 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#523496}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/a31a5a7b4ab3..8cc672aa9c1c $ git log a31a5a7b4..8cc672aa9 --date=short --no-merges --format='%ad %ae %s' 2017-12-12 perezju Revert "[Telemetry] Fix browser_backend.pid for Android" 2017-12-12 nednguyen Remove credentials_path & credentials related code in Telemetry 2017-12-12 perezju [Telemetry] Fix browser_backend.pid for Android Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ic3547fa60988d7d8381ef65d5a55feb0e1e995df Reviewed-on: https://chromium-review.googlesource.com/822912 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523495}
-
Jiaquan He authored
This commit - removes the deprecated laucher page; - removes related codes from app_list; - fixes lint error in affected files. Bug: 731991, 733662 Change-Id: If64f0cdd75d934288f556c2f3a7e2274097aa22d Reviewed-on: https://chromium-review.googlesource.com/809587Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Jiaquan He <hejq@google.com> Cr-Commit-Position: refs/heads/master@{#523494}
-
Reilly Grant authored
With the removal of kLoadingWithMojo some tests are no longer parameterized and so the test filters need to be updated. Bug: 788241 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If11985aff0e666304e8649515ebdb0eede761d8d No-Try: true No-Presubmit: true No-Tree-Checks: true Tbr: jam@chromium.org Reviewed-on: https://chromium-review.googlesource.com/823076Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523493}
-
CJ DiMeglio authored
On destruction, we were deleting the |resource_provider_| before the |resource_updater_|, which depended on it. Now we delete things in the correct order. This change also updates a few classes such that if the flag enable_surfaces_for_video is enabled by default, unit tests do not crash. Bug: 790779 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3ffbac4f4804a755270f19e8bdc78cb14521fb94 Reviewed-on: https://chromium-review.googlesource.com/804534Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#523492}
-
Jens Widell authored
In jumbo/unity builds, it conflicts with syncer::Encryptor defined in components/sync/base/encryptor.h. Change-Id: I0b9c4e6eafd88eae46892ff97f2ade41f8c0b99a Reviewed-on: https://chromium-review.googlesource.com/822090Reviewed-by:
-
Justin Novosad authored
Crash happens when a the frame to be presents fails to be uploaded to a texture (e.g. exceeds max texture size) BUG=793651 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7fd6373cbc6bd4d070de8fd0f4731068846242d1 Reviewed-on: https://chromium-review.googlesource.com/820159Reviewed-by:
Olivia Lai <xlai@chromium.org> Commit-Queue: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#523490}
-
John Abd-El-Malek authored
When there's an ongoing navigation, if the app loada a JavaScript URL we create a temporary NavigationRequest in NavigatorImpl::RequestNavigation. However the call to RenderFrameHostManager::GetFrameHostForNavigation was resetting the speculative RFH of the original NavigationRequest since the site instance of a JavaScript load is always the same as the existing frame. This is a reland of r523264 with an extra fix to ensure that the RFH is initialized. Bug: 793432 Change-Id: I7a029d907f5c133c00ce096d9d733cb8194fcd43 Reviewed-on: https://chromium-review.googlesource.com/822970Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#523489}
-
Evan Stade authored
It's used very rarely and is redundant with the MessageCenterObserver method. To continue to support it would require extra work on many platforms (for native notifications) and some platforms might not be able to support it anyway. TBR=tapted@chromium.org Bug: 783018 Change-Id: Iab3def37e0ee7c7dc56178ccbcc0146d712805ea Reviewed-on: https://chromium-review.googlesource.com/811366Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
