- 23 Nov, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eaff47190b82..33ae0b2d78ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hendrich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: hendrich@google.com Change-Id: Iee8405702d5514d9cf2540f06bc0335035f21621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553898Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830149}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d33d0fe9. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I23c5ca438bfb15628b3f650e13e84a137ee5ae9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551403Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830148}
-
Jan Wilken Dörrie authored
This reverts commit d3d9bac0. Reason for revert: https://bugs.llvm.org/show_bug.cgi?id=48048 got fixed. Original change's description: > Revert "[base] Add NO_UNIQUE_ADDRESS attribute" > > This reverts commit d3742a4b. > > Reason for revert: https://crbug.com/1144431 > Bug: 1144431 > > Original change's description: > > [base] Add NO_UNIQUE_ADDRESS attribute > > > > This change adds the HAS_CPP_ATTRIBUTE and NO_UNIQUE_ADDRESS macros to > > base/compiler_specific.h. This allows using the C++20 no_unique_address > > attribute in prior dialects if the compiler supports it. > > > > Bug: None > > Change-Id: I6aff82e7b195f5eaf93551049c9dfa6a3fd1fbc6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510396 > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#822768} > > TBR=dcheng@chromium.org,jdoerrie@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: None > Change-Id: I375099e835dbc7d4cab98cc15faf66124335bb0e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514208 > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823202} # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1144431 Bug: None Change-Id: Ieffa10dce233eb19f7dbfbcea449ea08e2f2b1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546008Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#830147}
-
Robbie Gibson authored
Before, when switching to incognito using the Thumb Strip, the BVC ended up having a frame.y = 36 (or some other non-zero constant). It looks like the BVC is currently positioned by frame, and my guess is that somehow, the position of some other element + constraints caused the BVC's frame to change after it was set. However, the BVC's frame could be set by constraint, as it should always be that value. Bug: 1094335 Change-Id: Iedeedadf7ac7c7e842ebe4af02d8e62ed3b6a7c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549947 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#830146}
-
Henrik Boström authored
CL 2551665 fixed a bug relating to SampleBufferTransformer's fast path not considering IOSurface-less pixel buffers and added test coverage that the fast path always outputs a pixel buffer with an IOSurface. However, in CL 2551665 these IOSurface-less pixel buffers are created without content; CreateSampleBuffer is ignoring the RGB values. This CL addresses that and improves the test coverage, but because we pass all the tests, this CL won't have to be backmerged to M88. It's a testing-only change. This CL: - Creates IOSuface-less pixel buffers in the specified color. - Verifies that both the "pixel transfer" path and the "libyuv" path are able to scale IOSurface-less pixel buffers and that the color is correct. - Verifies that regardless of technique we output an IOSurface-backed pixel buffer. With this CL, all possible camera output formats are both supported and well tested. Bug: chromium:1148964 Change-Id: Ic016e3109de42d73a39b5a7e0a155b56c87e0cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553551Reviewed-by:
Markus Handell <handellm@google.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#830145}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/805e8b59..847989b5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6c2f527a04f26c52d28d2e5e42f005eefca918d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553871Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830144}
-
Henrik Boström authored
When the M88 cut was made, the kDefaultBufferPoolSize was 10. While investigating https://crbug.com/1148964 we disabled and then re-enabled the InCaptureConvertTnoNv12 feature and along the way changed the pool size to 5 (trying to see if the issue was related to running out of handles, but that wasn't the case). To ensure M88 and Canary uses the same pool size, this CL restores the old pool value to 10. If we decide to change the pool size we should do that in a separate easily back-mergeable CL, but there have been no signs yet that 10 is too many. Bug: chromium:1148964 Change-Id: Ib122ca1ed9ca061951ee5d77dfa3ddbd84d90f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553548 Commit-Queue: Henrik Boström <hbos@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Auto-Submit: Henrik Boström <hbos@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606089386-838f65aaa60be12e40b29c2cb3db20695d2661d9.profdata to chrome-win64-master-1606110698-fe2030373d9d56b0c47d89f10e41d9fcfb737790.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I002d0228f7fdc1cdfd23aeb56767169120d2fda6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554419Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830142}
-
Tanmoy Mollik authored
This reverts commit d26915b9. Reason for revert: Tests still failing Original change's description: > Reland "[Test] Refactor BookmarkPersonalizedSigninPromoDismissTest" > > This is a reland of f4a2ff7e > > The cl was reverted because testPromoNotShownAfterBeingDismissed and > testPromoImpressionCountIncrementAfterDisplayingSigninPromo were flaky. > > After looking into more details about why the tests are flaky it seems > that SyncTestRule calls > NativeLibraryTestUtils.loadNativeLibraryAndInitBrowserProcess() as part > or rule set up. Other tests like BookmarkBridgeTest and BookmarkModelTest > uses ChromeBrowserTestRule which also calls this method during rule > setup. Changing AccountManagerTestRule to ChromeBrowserTestRule should > fix it. > > > Original change's description: > > [Test] Refactor BookmarkPersonalizedSigninPromoDismissTest > > > > Refactor BookmarkPersonalizedSigninPromoDismissTest to use > > AccountManagerTestRule and ChromeActivityTestRule instead of > > SyncTestRule so that it can be batched easily. > > > > Bug: 1145843 > > Change-Id: Ia005508ccd84c439b04b25a65af0930b5a15ee0e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527021 > > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > > Reviewed-by: Marc Treib <treib@chromium.org> > > Reviewed-by: Tanmoy Mollik <triploblastic@chromium.org> > > Reviewed-by: Alice Wang <aliceywang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#827278} > > Bug: 1145843 > Change-Id: I261da247b78cd33d2314be6aa40668a9dcdafa98 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540669 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828412} TBR=treib@chromium.org,triploblastic@chromium.org,aliceywang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1145843 Change-Id: Ifdd6babc6ded7b5f1fc98c07eb0a8f0a17f1189f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553424Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#830141}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a304f111386d..9304577415d5 2020-11-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from bfc1b42f to a41860e8 (83 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ibf4f0af477106361ad3aaebefc8d43ecc21306e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554415Reviewed-by:
-
Kevin McNee authored
g_oom_handling_function is currently declared static in a header file, meaning that each translation unit that includes it gets a separate instance of it. This is set in partition_alloc.cc and called from partition_root.cc, so this function will never actually be called. We make g_oom_handling_function extern so that we read and write the same instance of the variable. Bug: None Change-Id: I92488bb7f9898961d719bb60270bdd9b846cf81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549466 Commit-Queue: Benoit L <lizeb@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#830139}
-
dpapad authored
Also change parse_html_subset.js to initialize the parse-html-subset TrustedTypes policy lazily, only when it is actually used, to avoid having to allow that policy in the CSP configuration on the C++ side for cases where parse_html_subset.js is just a transitive dependency and not actually used (which is the case for chrome;//view-cert). Bug: 1149868 Change-Id: I1a8f32f3289f6068c0eafbb80cdc046451fc028e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544067 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#830138}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cb4bb2088ad7..844c1542a1f4 2020-11-23 landrey@google.com Speed up upload status info requests that require full info If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1122516 Tbr: sadrul@google.com Change-Id: I8d853eacb610155dbc8af2df2631759bd24a46a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553110Reviewed-by:
-
Ian Barkley-Yeung authored
Prevent duplicate and unwanted JavaScript error reports by: * Allowing pages that report errors in other ways -- or that we just don't care about -- to disable WebUI JS Error Reporting. * Blocking reports from other frames. If a WebUI page has an iframe containing another WebUI page, both WebUIMainFrameObservers will see the errors for either page. Only report errors for the main frame of this WebUI. * Blocking non-chrome:// URLs. WebUI pages with chrome-untrusted:// frames may host non-Chrome content which we don't want error reports from. This is the heart of "step 5" in the design document. Remaining work includes calling DisableJavaScriptErrorReporting for the essential apps & essential inputs that would otherwise double-report, and possibly carving out exceptions from these blockers for pages that have a good reason (such as chrome-untrusted:// pages that still expect to only serve up Chrome-owned content.) Bug: chromium:1121816 Change-Id: I57005c9a85b5700ead7d1123627191f1cbfda33f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535490Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: Ian Barkley-Yeung <iby@chromium.org> Cr-Commit-Position: refs/heads/master@{#830136}
-
Henrik Boström authored
In https://crbug.com/1148964 it was discovered that assumptions that SampleBufferTransformer was making did not always hold. For example, SBT assumed that if the camera produced pixel buffers then those pixels buffers would contain IOSurfaces, but this was not always the case. This was fixed so now I'm looking at other assumptions. Similarly, SBT assumes that if the camera produces a SampleBuffer that doesn't have a pixel buffer, this must be the MJPEG case. This CL promotes a DCHECK for this into a CHECK so that we don't run the risk of having hard-to-debug crashes happening if there are any cameras out there in the wild where this does not hold (hopefully not). Bug: chromium:1148964 Change-Id: I3e063dd7ed48962d31c7fd46a9a66de7e8337498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554597 Commit-Queue: Henrik Boström <hbos@chromium.org> Commit-Queue: Markus Handell <handellm@google.com> Auto-Submit: Henrik Boström <hbos@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/34a1660229e0..3583a63a0f86 2020-11-23 mathias@chromium.org TypeScriptify platform/utilities.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie568986f4141eab51af0d63754b1e060e3e81c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553893Reviewed-by:
-
Alexander Hendrich authored
TBR=yukishiino@chromium.org Bug: 1151861 Change-Id: I5ffe50d52c18ba5126ea644d8dd40619ba778405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554562 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#830133}
-
Nazerke authored
This CL updates the switch to the active webstate according to the tapped tab in the TabStrip. This CL doesn't update the tabstrip UI, i.e doesn't highlight the selected tab. Bug: 1128249 Change-Id: I89041c22d27df2d171821c6d5fc7342c99ab06db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550711Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#830132}
-
Fredrik Söderqvist authored
The new class DrawInfo packages the various parameters used when drawing an SVGImage - container size, zoom and URL. The intent is to reduce the amount of arguments that needs to be passed around as well as prepare for better (more centralized) handling of the container size to get better control of the various representations used (FloatSize, LayoutSize, IntSize). Also move DrawNeedsLayer() closer to its user and perform minor tweaks to DrawPatternForContainer() (reorder matrix setup; return PaintRecord directly to MakePaintRecord). Change-Id: Id231682c9d85a322a3c585a75b2793a68628c348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550915Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#830131}
-
Clemens Arbesser authored
Before this change, the progress bar for trigger scripts would flakily not show the progress correctly due to missing change notifications. Bug: b/173790448 Change-Id: I4bb51ceee69f81ad41d69739a20f0c4b1e38d60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550918 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#830130}
-
Denis Kuznetsov authored
This call was only used to update passwords for legacy supervised users. Bug: 1150430 Change-Id: Ib313d42f103aeebbf845570443c8dfaddaf92de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550904 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#830129}
-
Daniel Hosseinian authored
Bug: 1026195 Change-Id: I6bd42a7c4611dac978f812af701317c5f50660f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553870 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#830128}
-
Mirko Bonadei authored
By default, absl/flags are disabled on mobile platforms. This is a problem for some test binaries. The best way to avoid ODR is to define ABSL_FLAGS_STRIP_NAMES=0 at build level. Since Chromium doesn't use absl/flags, this CL just default to flags always ON (they only affect test code). Bug: None Change-Id: Ie51744937125fbb89be39eacf388f43d6054d6b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552391Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#830127}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c5d21335f147..eaff47190b82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hendrich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: hendrich@google.com Change-Id: I2e3203c695c418d022be4ce1a840383cefda4b76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554418Reviewed-by:
-
Alice Wang authored
This CL adds SigninPreferencesManager to the new signin.services target. The old class will be removed after we migrate first the usage of SigninPreferencesManager in clank to avoid build crash. Bug: 1150862 Change-Id: I11285422d0d8b2ee779084c14ad60c9d7a3a6a5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550678 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#830125}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/91c1a7c2dc0a..cb4bb2088ad7 2020-11-23 mbonadei@chromium.org Add .vpython file for histogram_proto.py. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: sadrul@google.com Change-Id: I26a7fbc451a44c9bd74fdfdcdd2ae5f37810a584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554420Reviewed-by:
-
Clemens Arbesser authored
Users may manually disable the proactive help setting while the trigger script is being run. In that case, the trigger script should immediately exit. Bug: b/173786671 Change-Id: Ib6ff4bcb12ccc75f0054bb87098367071346b433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550680Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#830123}
-
Sigurd Schneider authored
Bug: chromium:1011811 Change-Id: I868f1024ca24013817c1039c5bbdd6523750bcca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550916Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#830122}
-
Luciano Pacheco authored
Add group() for Polymer elements JS modules to make easier to refer to them. Run `git cl format --js ui/file_manager` as pointed by presubmit. Bug: 1133186 Change-Id: Ib0f92ec10da1418f2c949f2b82dccdd40b107bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554201 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#830121}
-
Alexander Hendrich authored
failing since https://crrev.com/c/2529950 virtual/controls-refresh-hc/fast/forms/color-scheme/calendar-picker/date-picker-disabled-values.html virtual/controls-refresh-hc/fast/forms/color-scheme/file/file-appearance-basic.html failing since https://crrev.com/c/2509029 virtual/controls-refresh-hc/fast/forms/color-scheme/media/video-overlay-menu.html TBR=almaher@microsoft.com Bug: 1151844 Change-Id: I5cb1d6f6943562f29ef0a8dc57a0b4558f5ae812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553545Reviewed-by:
-
Alexander Hendrich authored
TBR=rogerta@chromium.org, rsorokin@chromium.org Bug: 1151851 Change-Id: I1516aa2ded9edc45e26be8fc54d375cbda840a17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553546Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/854885046bca..34a1660229e0 2020-11-23 aerotwist@chromium.org Bumps bl to 4.0.3, adds karma-spec-reporter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaf3a6fead11c3da8ba7ab4b57ed0b2105efbc90d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554416Reviewed-by:
-
Alexander Hendrich authored
TBR=sammiequon@chromium.org, afakhry@chromium.org Bug: 1151856 Change-Id: Ie131d72ec0f53d26d61aef0f83608fc0990140d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554538Reviewed-by:
-
Henrik Boström authored
This is part of debugging https://crbug.com/1148964. Crashes have been observed when InCaptureConvertToNv12 is enabled, which means we would be using a CVPixelBufferPool in non-passthrough cases (e.g. external webcam capturing in MJPEG or other non-NV12 pixel format). The crash seems to be happening because GpuMemoryBufferImplIOSurface::CreateFromHandle() returns null. But unless the io_surface is missing, the only way this should be possible is if the IOSurface's width or height is less than the size we expect from our handle. How could this be? The test added in this CL demonstrates that if we have a bug with how we handle IOSurface-backed gfx::GpuMemoryBuffer's and don't increment/decrement the IOSurface's use count correctly, we could observe a new IOSurface with a recycled ID. This could also happen if we do use the use counts correctly, but have any assumptions about old and new handles with matching IDs have the same resolution. This could trip us up if our handle thinks that this ID maps to a buffer in one size when in fact the new IOSurface sharing the old ID has a different resolution. Bug: chromium:1148964 Change-Id: Ic909f408d7ea9e443efa45b28b9e7b3a9450d8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550807 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ic32cf98d4ba1c52b193082840dc891ca0c56a888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552819Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830115}
-
Benedikt Meurer authored
Tbr: yangguo@chromium.org Bug: chromium:1151285 Change-Id: Ia5019c6ac2be8a2b908e79ab6d96c2df7dbf8095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553542 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#830114}
-
Alexander Hendrich authored
This reverts commit 40d807ac. Reason for revert: https://crbug.com/1151842 Original change's description: > [Reland] capture_mode: Hook to policy and locked fullscreen mode > > This is a reland of https://crrev.com/c/2548880 which was reverted > due to a flaky test. The flakiness root cause was resolved in > https://crrev.com/c/2552921. Therefore, there're no changes in this > CL from the original. > > TBR=jamescook@chromium.org, poromov@chromium.org, isandrk@chromium.org, bmalcolm@chromium.org > > Original CL description: > Capture Mode should be disabled when the `kDisableScreenshots` policy > is disabled. > It also should be disabled when a tab requests to be in a locked > fullscreen mode, and any on going recording should be interrupted. > > BUG=1150585 > TEST=Existing, and added a new test. > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548880 > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: Ivan Šandrk <isandrk@chromium.org> > Reviewed-by: Brian Malcolm <bmalcolm@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Original-Commit-Position: refs/heads/master@{#829390} > Change-Id: If427589bcaf9837d0def703dbeff6fc03b8167cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552215 > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829927} TBR=jamescook@chromium.org,afakhry@chromium.org,isandrk@chromium.org,poromov@chromium.org,bmalcolm@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1150585 Change-Id: I99f8819ba2534bd8d6510a5091cc6d6b6dee4c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553544Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606089386-260a0b5b2f863e489966f04b1fedc1aa4f716d07.profdata to chrome-mac-master-1606110698-ec2190f26d45d9121b82315791a0ce2334cbfdfd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic6f378e7f5f2efa42dcb3f7c0a8d8c573aaa2eee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554414Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606089386-1100858bd739b2cdd53e6f084f74316be20c2045.profdata to chrome-linux-master-1606110698-4a9b21f116e6eb433edc251fc3084d03e39a6c23.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic82c393eba887ddcb3b726011beeba6b274011c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554413Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/667511e44111..c5d21335f147 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC noel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: noel@google.com Change-Id: Id04b72e38a7cca226363f1b3206b1e6c93f6ed18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553517Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830110}
-
