- 16 Dec, 2016 40 commits
-
-
dtapuska authored
This change is intended to have no behavioural changes. Some of the math is slightly adjusted the root frame coordinates. The root frame coordinates are calculated via: A/scale - B/scale + VO + OO as it was previously (A-B)/scale + VO + OO If this is a problem we can store translateX and translateY as the actual coordinates instead instead a computation. Cleanup proposal: https://docs.google.com/document/d/1s4Lfy22CNU1OZ5Rec6Oano_5BvIhdK6uFVsVe7FphKI/edit BUG=625684 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2539283002 Cr-Commit-Position: refs/heads/master@{#439153}
-
mattreynolds authored
In preparation for making the icon in Physical Web omnibox suggestions tappable, add a highlighted version of the icon. This version will be shown when the icon is tapped. BUG=630769 Review-Url: https://codereview.chromium.org/2578313002 Cr-Commit-Position: refs/heads/master@{#439152}
-
chrishtr authored
BUG=668342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2577123002 Cr-Commit-Position: refs/heads/master@{#439151}
-
agrieve authored
Revert of Support saturation overrides in saturated_cast (patchset #7 id:180001 of https://codereview.chromium.org/2578613002/ ) Reason for revert: Suspect breaking base_unittests (missing test name in unittest macro). https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/38202 Original issue's description: > Support saturation overrides in saturated_cast > > This is a requirement for adding a full saturated type implementation. > > BUG=672489 > NOTRY=true > > Committed: https://crrev.com/186c7dbbea5eef852bf0c4277d1da16f56f9156e > Cr-Commit-Position: refs/heads/master@{#439061} TBR=eae@chromium.org,jschuh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672489,674849 Review-Url: https://codereview.chromium.org/2582063002 Cr-Commit-Position: refs/heads/master@{#439150}
-
rbpotter authored
There is a lot of repeated code in other_options_settings.js. Simplify the code and make it easier to add additional options if needed in future. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2576233003 Cr-Commit-Position: refs/heads/master@{#439149}
-
michaeldo authored
This class was moved to renamed clone of ios/chrome/browser/ui/network_activity_indicator_manager.* since //ios/web should not be managing the system wide network activity indicator’s UI state. BUG=620887 Review-Url: https://codereview.chromium.org/2566493003 Cr-Commit-Position: refs/heads/master@{#439148}
-
olka authored
see https://cs.chromium.org/chromium/src/content/browser/renderer_host/media/media_devices_manager.cc?type=cs&sq=package:chromium&rcl=1481185182&l=68: MediaDevicesManager now first asks AudioManager for device names, and then goes back to AudioManager for group ID of each device. Since AudioManager will be moved to a separate process, we want to minimize the number of roundtrips. BUG=672467 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2563653002 Cr-Commit-Position: refs/heads/master@{#439147}
-
derat authored
Implement HandleIntent() and RequestIntentHandlerList() within FakeIntentHelperInstance. BUG=633243 Review-Url: https://codereview.chromium.org/2579193003 Cr-Commit-Position: refs/heads/master@{#439146}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7a32fcc6a55e..035bbd33b52e $ git log 7a32fcc6a..035bbd33b --date=short --no-merges --format='%ad %ae %s' 2016-12-16 dgozman Do not send null preventFling in SynthesizeScrollGesture. BUG=664683 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2577063004 Cr-Commit-Position: refs/heads/master@{#439145}
-
hidehiko authored
For graceful shutdown, this CL introduces OnShutdown observer callback. Along with the change, EventRouter now properly calls RemoveObserver in the callback. ArcServiceManager::IsInitialized() is now no longer needed. Remove it. BUG=672829 TEST=Ran bots. Review-Url: https://codereview.chromium.org/2581953002 Cr-Commit-Position: refs/heads/master@{#439144}
-
yzshen authored
The arrow operator is not supported on some old IOS versions. BUG=674807 Review-Url: https://codereview.chromium.org/2581223002 Cr-Commit-Position: refs/heads/master@{#439143}
-
rune authored
This method was now empty and has been replaced by asynchronous active stylesheet update in updateActiveStyleSheets(). R=meade@chromium.org BUG=567021 Review-Url: https://codereview.chromium.org/2559613002 Cr-Commit-Position: refs/heads/master@{#439142}
-
anthonyvd authored
This CL adds a mechanism to isolate sheet-specific code previously in PaymentRequestDialog to Controller classes. This will allow for clearer view creation and event handling as the different sheets in the dialog are implemented. BUG=667872 Review-Url: https://codereview.chromium.org/2579513002 Cr-Commit-Position: refs/heads/master@{#439141}
-
guidou authored
BUG=674858 TBR=junov@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2581233002 Cr-Commit-Position: refs/heads/master@{#439140}
-
gab authored
This is part of the migration phase for TaskScheduler, design doc: https://docs.google.com/document/d/1S2AAeoo1xa_vsLbDYBsDHCqhrkfiMgoIPlyRi6kxa5k/edit Also generalizes BrowserThreadImpl away from the underlying thread's MessageLoop and id in favor of TaskRunners and BrowserThreadState. Cool side-effect: BrowserThreadImpl::StartWithOptions() no longer blocks on the underlying thread starting (it used to via GetThreadId()), it now takes a reference to its TaskRunner and lets the thread itself start on its own schedule :). This wasn't previously intended to block (BrowserThreadImpl::StartAndWaitForTesting() is supposed to be used for that) but had unintentionally regressed in http://crrev.com/408295 because GetThreadId() implicitly waits (http://crbug.com/672977). Another nice improvement is that ~BrowserThreadImpl() now cleans the BrowserThreadGlobals associated with it, this has the side-effect to force proper destruction order of TestBrowserThread in tests which brought forth a few precursor cleanups (https://crbug.com/653916#c24) which will from now on be enforced by this CL. When redirection is disabled, the logic should be the exact same as before. - Threads are brought up. - Tasks are posted to their MessageLoop (albeit through their TaskRunner now). - On shutdown, threads are joined one by one. When redirection is enabled, we try to mimic this logic. - Redirection TaskRunners are only live (|accepting_tasks|) for the same period that the matching thread would be. - On shutdown, we block on each TaskRunner's queue being flushed one-by-one in the same order as in the no-redirection case (this almost identical to real threads join % one slight difference documented in detail in BrowserThreadImpl::StopRedirectionOfThreadID()). BUG=653916, 672977 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng TEST= A) "out\Release\chrome.exe" Runs/shuts down the exact same as before. B) "out\Release\chrome.exe --force-fieldtrials=BrowserScheduler/Enabled/ --force-fieldtrial-params=BrowserScheduler.Enabled:Background/3;3;1;0;10000/BackgroundFileIO/3;3;1;0;10000/Foreground/3;3;1;0;10000/ForegroundFileIO/3;3;1;0;10000/RedirectSequencedWorkerPools/true/RedirectNonUINonIOBrowserThreads/true" Runs/shuts down smoothly and chrome://tracing confirms that redirected BrowserThreads are running on TaskSchedulerWorkers. Review-Url: https://codereview.chromium.org/2464233002 Cr-Commit-Position: refs/heads/master@{#439139}
-
treib authored
BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2578153002 Cr-Commit-Position: refs/heads/master@{#439138}
-
asanka authored
Downloads initiated via clicking on an anchor with a 'download' attribute should behave the same way with regard to cookie handling as a download initiated via a top level navigation. This CL adds logic to set the initiator origin for URLRequests initiated in response to such downloads so that the handling of SameSite cookies follows suit with top level navigations. R=mkwst@chromium.org, clamy@chromium.org BUG=648043 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2561903002 Cr-Commit-Position: refs/heads/master@{#439137}
-
lukasza authored
Before this CL, when --all switch was used, then |filenames| 1) wouldn't include any header filenames (which should get rewritten) 2) would include generated files (which shouldn't get rewritten) This would lead to incorrect filtering of edits/files that are passed to _ApplyEdits function. The new filtering behavior helps to ensure that we apply edits to header files that are only included from generated files. Doing this requires 1) running the tool on generated files (this is what --all switch accomplishes even before this CL) and 2) ensuring that edits are applied to the right files (this is what this CL does). Examples of headers that are only included from generated files can be found in https://crbug.com/643779#c11 BUG=643779 Review-Url: https://codereview.chromium.org/2583623002 Cr-Commit-Position: refs/heads/master@{#439136}
-
droger authored
BUG=674181 Review-Url: https://codereview.chromium.org/2580753005 Cr-Commit-Position: refs/heads/master@{#439135}
-
avi authored
BUG=555865 Review-Url: https://codereview.chromium.org/2580793003 Cr-Commit-Position: refs/heads/master@{#439134}
-
csashi authored
""" MasterCard recently updated their logo https://brand.mastercard.com/brandcenter/mastercard-brand-mark/downloads.html with these guidelines https://brand.mastercard.com/brandcenter/mastercard-brand-mark.html """ BUG=None New icons are from https://spec.googleplex.com/payments/resources/icons-logos.html#icons-logos-icons Review-Url: https://codereview.chromium.org/2579623003 Cr-Commit-Position: refs/heads/master@{#439133}
-
sky authored
It was assuming there is always a root window, which isn't the case. GetRootWindow() only returns non-null when attached to a display, so if a window has a parent but isn't yet attached to a display then GetRoot returns null. BUG=674575 TEST=none R=fsamuel@chromium.org Review-Url: https://codereview.chromium.org/2580703005 Cr-Commit-Position: refs/heads/master@{#439132}
-
lizeb authored
This CL adds support for WPR and network throttling (through WPR) for testing the speculative_prefetch_predictor. The modifications are: - Generate a WPR archive in generate_database.py - Use the archive and set up throttling in prefetch_benchmark. Also adds the ability to test several configuration of the predictor in prefetch_benchmark, and make it loop. BUG=655980 Review-Url: https://codereview.chromium.org/2561353002 Cr-Commit-Position: refs/heads/master@{#439131}
-
chongz authored
This is the last sub-patch (3/3) of supporting |EditCommandSource| in |CompositeEditCommand| (https://crrev.com/2574793002). Instead of adding |EditCommandSource| to constructor, this CL: 1. Pass source to |CompositeEditCommand::apply(EditCommandSource)| 2. Pass source to various static methods of |TypingCommand| We don't have to store command source as attribute because we only need it to fire 'beforeinput' in the above locations. This approach also helped avoiding modifying all the |CompositeEditCommand| constructors. This CL shouldn't have any behavior change. To help reviewing, here is a simple doc describing the following plans: https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd4ZkgJs5GPde2ZsDy0/edit?usp=sharing BUG=673789 Review-Url: https://codereview.chromium.org/2579253002 Cr-Commit-Position: refs/heads/master@{#439130}
-
kylechar authored
There is no need to hold onto the SkBitmap object as a member variable in MusDemo. It was originally retained so that the pixel buffer didn't need to be reallocated for each frame (a copy of the pixel buffer was made when submitting the frame). However, the pixel buffer is now locked and ownership is shared with the gfx::ImageSkiaRep, requiring a new pixel buffer to be allocated for each frame regardless. Remove |bitmap_| member variable. BUG=none Review-Url: https://codereview.chromium.org/2581163003 Cr-Commit-Position: refs/heads/master@{#439129}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a95071710cf8..7a32fcc6a55e $ git log a95071710..7a32fcc6a --date=short --no-merges --format='%ad %ae %s' 2016-12-16 dtu [pinpoint] Rename change_unittest.py to change_test.py Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2582803002 Cr-Commit-Position: refs/heads/master@{#439128}
-
kylixrd authored
If a displayed modal dialog is partially or entirely off-screen, the user may be unable to interact with it or even be aware of its presence. This change ensures that the dialog is moved to the nearest display so that it is fully visible to the user. BUG=668734 Review-Url: https://codereview.chromium.org/2549543002 Cr-Commit-Position: refs/heads/master@{#439127}
-
tandrii authored
This has been superseeded by just-in-time determination based on state of gnumbd and git-numberer validation. BUG=644915 R=machenbach@chromium.org,sergiyb@chromium.org NOTRY=True Review-Url: https://codereview.chromium.org/2583903002 Cr-Commit-Position: refs/heads/master@{#439126}
-
rnephew authored
This adds the ability to set --trace-output <dir> and generate a json file that can be opened in the chrome trace viewer that will display timelines of when each test is run on which testing shard. BUG=667470 Review-Url: https://codereview.chromium.org/2583613002 Cr-Commit-Position: refs/heads/master@{#439125}
-
mlippautz authored
BUG=chromium:468240 NOTRY=true Review-Url: https://codereview.chromium.org/2579043002 Cr-Commit-Position: refs/heads/master@{#439124}
-
haraken authored
When the frame is destroyed, ScreenOrientationController needs to stop updating. BUG= Review-Url: https://codereview.chromium.org/2584453005 Cr-Commit-Position: refs/heads/master@{#439123}
-
reed authored
BUG= NOTRY=True Review-Url: https://codereview.chromium.org/2583723003 Cr-Commit-Position: refs/heads/master@{#439122}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/780dad1ab946..99ad164886ba $ git log 780dad1ab..99ad16488 --date=short --no-merges --format='%ad %ae %s' 2016-12-16 bsalomon Rename batch->op and sk_sp in instanced rendering 2016-12-16 bsalomon Rename batch->op and sk_sp for all remaining path renderer classes. 2016-12-15 msarett Fix gray png BRD tests 2016-12-16 msarett Mark CG and WIC images as srgb 2016-12-16 scroggo Revert "Remove all KTX support" 2016-12-16 mtklein Restore fetch-gn instructions. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=msarett@google.com Review-Url: https://codereview.chromium.org/2586473002 Cr-Commit-Position: refs/heads/master@{#439121}
-
sdefresne authored
BUG=666375 Review-Url: https://codereview.chromium.org/2582033002 Cr-Commit-Position: refs/heads/master@{#439120}
-
jam authored
The test was looking for a specific stack trace in the renderer. With PlzNavigate, the stack trace is different. Use a method name that's common to both. BUG=674730 Review-Url: https://codereview.chromium.org/2581833002 Cr-Commit-Position: refs/heads/master@{#439119}
-
guidou authored
The test flakes on that platform. BUG=674782 TBR=xiyuan@chromium.org Review-Url: https://codereview.chromium.org/2577123005 Cr-Commit-Position: refs/heads/master@{#439118}
-
guidou authored
BUG=674858 TBR=junov@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2580013002 Cr-Commit-Position: refs/heads/master@{#439117}
-
dtseng authored
Given events a_1, .., a_n that come in in the same update, where a_i is a blur and a_j is focus (i < j). Then, a_i's update params focused id will point to a_j's node. As a result, we never actually fire a_j properly since it was seen as "already" focused. TEST=navigate context menus in files app. BUG=668775 Review-Url: https://codereview.chromium.org/2575233002 Cr-Commit-Position: refs/heads/master@{#439116}
-
rune authored
With active stylesheets being applied asynchronously, we no longer need to avoid the synchronous stylesheet update during link processing. We can just mark the treeScope dirty to trigger the preferred set to be updated as part of updateActiveStyleSheets(). R=meade@chromium.org BUG=567021 Review-Url: https://codereview.chromium.org/2552353003 Cr-Commit-Position: refs/heads/master@{#439115}
-
olka authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/8dca466..5ea8737 $ git log 8dca466..5ea8737 --date=short --no-merges --format=%ad %ae %s 2016-12-16 kthelgason@webrtc.org Fix wrong log message. 2016-12-16 danilchap@webrtc.org Use NtpTime in RTCPSender::RtcpContext instead of pair of uint32_t 2016-12-16 terelius@webrtc.org Pass arrival time as an int64_t rather than a double to the MedianSlopeEstimator to avoid precision loss. 2016-12-16 kthelgason@webrtc.org Move ios_helpers to sdk folder 2016-12-16 mflodman@webrtc.org Adding Åsa and Erik as video owners. 2016-12-16 stefan@webrtc.org Don't report packets with id -1 to the transport feedback adapter as they provide no value. 2016-12-16 kthelgason@webrtc.org Initialize packetization mode in VideoToolbox 2016-12-15 tkchin@webrtc.org iOS: Add trendline filter to field trials. 2016-12-15 sergeyu@chromium.org Fix integer overflow in ProbeController. 2016-12-15 terelius@webrtc.org Avoid precision loss in TrendlineEstimator by passing the arrival time as an int64_t instead of a double. 2016-12-15 ossu@webrtc.org Add ossu@ to OWNERS of audio/ and modules/audio_coding/ 2016-12-15 mflodman@webrtc.org Fixing loopback video test by reconfiguring the encoder to correct size. 2016-12-15 philipel@webrtc.org Create VideoReceiver with external VCMTiming object. 2016-12-15 henrika@webrtc.org Improves release of allocated audio resources on Android. 2016-12-15 terelius@webrtc.org Revert of Avoid precision loss in TrendlineEstimator from int64_t -> double conversion (patchset #7 id:120001 of https://codereview.webrtc.org/2577463002/ ) 2016-12-15 terelius@webrtc.org Revert of Avoid precision loss in MedianSlopeEstimator from int64_t -> double conversion (patchset #3 id:40001 of https://codereview.webrtc.org/2578543002/ ) 2016-12-15 terelius@webrtc.org Pass arrival time as an int64_t rather than a double to the MedianSlopeEstimator to avoid precision loss. 2016-12-15 nisse@webrtc.org Reland of Delete VideoFrame default constructor, and IsZeroSize method. (patchset #1 id:1 of https://codereview.webrtc.org/2574123002/ ) 2016-12-15 michaelt@webrtc.org Wire-up audio BWE with overhead. 2016-12-15 terelius@webrtc.org Avoid precision loss in TrendlineEstimator by passing the arrival time as an int64_t instead of a double. 2016-12-15 hbos@webrtc.org Rename RTCOutboundRTPStreamStats *_rtt members to *_round_trip_time. 2016-12-15 nisse@webrtc.org Revert of Delete rtc::linked_ptr. Only use, in statstypes.h, replaced bu std::unique_ptr. (patchset #1 id:1 of https://codereview.webrtc.org/2581663002/ ) 2016-12-15 hbos@webrtc.org RTCStatsIntegrationTest: TestMemberIsIDReference on all defined IDs. 2016-12-15 nisse@webrtc.org Reland of Delete rtc::linked_ptr. Only use, in statstypes.h, replaced bu std::unique_ptr. (patchset #1 id:1 of https://codereview.webrtc.org/2576673002/ ) 2016-12-15 kjellander@webrtc.org MB: Enable memcheck for the linux_memcheck trybot. 2016-12-15 hbos@webrtc.org RTCOutboundRTPStreamStats.roundTripTime: Only report non-negative values. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2585763002 Cr-Commit-Position: refs/heads/master@{#439114}
-