GitLab

BUG=None
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/23735004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220574 0039d316-1c4b-4281-b951-d872f2087c98

TCP/IP with no extensions in use.

This CL implements the logic to read and write frames from the stream that is used after connection.

BUG=257680
TEST=net_unittests

Review URL: https://chromiumcodereview.appspot.com/18792002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220573 0039d316-1c4b-4281-b951-d872f2087c98

> Disabling flaky webrtc tests for now.
> 
> BUG=28149
> TBR=tommi@chromium.org
> NOTRY=True
> 
> Review URL: https://chromiumcodereview.appspot.com/23592020

TBR=phoglund@chromium.org

Review URL: https://codereview.chromium.org/23702012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220572 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
CID=15762
R=creis@chromium.org

Review URL: https://codereview.chromium.org/23722002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220571 0039d316-1c4b-4281-b951-d872f2087c98

This is a simple fix for a regression that's affecting PeerConnection based apps that also use WebAudio. A longer term fix is also ready but I'd like to land this shorter term fix so that merging to release branches will be easy and low risk. (the other CL is here: https://codereview.chromium.org/23171026/)

BUG=277134

Review URL: https://chromiumcodereview.appspot.com/23752002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220570 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
CID=108673
R=msarda@chromium.org

Review URL: https://codereview.chromium.org/23511006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220569 0039d316-1c4b-4281-b951-d872f2087c98

This method is used just internally.

BUG=none
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/23819002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220568 0039d316-1c4b-4281-b951-d872f2087c98

This method accepts an ID of an input device and finds an output device belonging to the same hardware (if one exists) and returns its ID.

BUG=276894

Review URL: https://chromiumcodereview.appspot.com/23618015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220566 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/23288007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220565 0039d316-1c4b-4281-b951-d872f2087c98

In case a backend does not support Sparse IO, a failover to network should
happen, it does so via unsuccessful validation of headers, but debug builds have
a DCHECK on this seemingly working path. Remove it.

BUG=263642

Review URL: https://chromiumcodereview.appspot.com/22926031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220564 0039d316-1c4b-4281-b951-d872f2087c98

This reverts https://codereview.chromium.org/20686002/ and partially https://chromiumcodereview.appspot.com/14924002.

BUG=235037

Review URL: https://chromiumcodereview.appspot.com/22887043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220563 0039d316-1c4b-4281-b951-d872f2087c98

Also moved TetheringAdbFilter class declaration into a cc file, preparing for merge
with PortForwardingController::Connection.

TBR=jam (file renamed in chrome.gyp)
BUG=None

Review URL: https://chromiumcodereview.appspot.com/23490021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220560 0039d316-1c4b-4281-b951-d872f2087c98

Adding a check if the type (audio, video) was requested and allowed before adding the device to the list.

BUG=259567

Review URL: https://chromiumcodereview.appspot.com/23453012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220559 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220558 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://chromiumcodereview.appspot.com/23571005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220556 0039d316-1c4b-4281-b951-d872f2087c98

This isn't used any more now and can be deleted. Chrome apps and the
chrome app launcher are now part of the main chrome install, and don't
need a separate executable to shunt control to chrome.

TBR=sky
BUG=279671

Review URL: https://chromiumcodereview.appspot.com/23539002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220555 0039d316-1c4b-4281-b951-d872f2087c98

R=rmistry@google.com

Review URL: https://codereview.chromium.org/23757012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220554 0039d316-1c4b-4281-b951-d872f2087c98

Major changes.
- Add animation on laading
- Add a spinner on loading
- Handle failure of widget loading
- Refine the internal states of SuggestAppDialog

BUG=240152
TEST=manual
R=hirono@chromium.org

Review URL: https://codereview.chromium.org/23717007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220553 0039d316-1c4b-4281-b951-d872f2087c98

Moves initialization part for SyncFileSystemService from SyncFileSystem's API
handling layer (sync_file_system_api.{cc,h}) to SyncFileSystemBackend so that
non-chrome API can start SyncFileSystemService.

This is a preparation patch for supporting window.resolveLocalFileSystemURL()
on SyncFileSystem. See the bug issue for more details.


BUG=177137
TEST=unit_tests
TEST=browser_tests --gtest_filter=SyncFileSystemApiTest.*

Review URL: https://chromiumcodereview.appspot.com/22810002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220552 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a background page to the good2.crx extension used in tests.
This is part of CL 23427003 but had to be committed separately because the
CQ cannot handle binary file changes.

BUG=175701
TEST=None

TBR=kalman

Review URL: https://codereview.chromium.org/23482005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220551 0039d316-1c4b-4281-b951-d872f2087c98

Chrome uses OPUS by default hence it makes sense to force ISAC instead.

BUG=279101
NOTRY=TRUE
TEST=Manual test verifying that iSAC is used instead of OPUS in chrome://webrtc-internals and that the sound is played back OK.

Review URL: https://chromiumcodereview.appspot.com/23460010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220550 0039d316-1c4b-4281-b951-d872f2087c98

If the DevTools window is invoked in-tab, the task manager refused to add it to the list of displayed processes, because there was no tab owning this WebContent. This CL improves the check in FindBrowserWithWebContents to recognise the DevTool's WebContent as valid in this case. To avoid crashing in TabContentsResource::GetIcon(), a FaviconTabHelper::CreateForWebContents() call had to be added.

BUG=237841

Review URL: https://chromiumcodereview.appspot.com/23576007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220549 0039d316-1c4b-4281-b951-d872f2087c98

Remove chromeos/dbus dependency from CandidateWindowController.

BUG=280438

Review URL: https://chromiumcodereview.appspot.com/23680003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220548 0039d316-1c4b-4281-b951-d872f2087c98

The operation is mapped to "Files: trash" on Drive API v2.
To adapt the API more, renames and changes the style.

BUG=277253
TEST=Ran unit_tests and tested manually.

Review URL: https://chromiumcodereview.appspot.com/23514007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220545 0039d316-1c4b-4281-b951-d872f2087c98

These are passed to run_test_cases.py

R=maruel@chromium.org

Review URL: https://codereview.chromium.org/22734004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220544 0039d316-1c4b-4281-b951-d872f2087c98

Now remove the flag and make this settings default.

BUG=243235
TEST=browser_tests --gtest_filter=TranslateManagerBrowserTest.*

Review URL: https://chromiumcodereview.appspot.com/23708004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220543 0039d316-1c4b-4281-b951-d872f2087c98

This just tests the success of the call to window.print(). It does not
test whether the call leads to a print preview window and ultimately to
a printout. It will be extended over time to provide additional coverage
of the print functionality.

BUG=NONE

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220467

Review URL: https://chromiumcodereview.appspot.com/23054002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220542 0039d316-1c4b-4281-b951-d872f2087c98

We were enabling native accessibility if any accessibility service was
running, but many Android users have accessibility services other than
screen readers. Now we only enable native accessibility if
getAccessibilityNodeProvider is called on the web content.
Many popular Android apps that happen to be accessibility services will
no longer trigger Chrome's accessibility mode.

BUG=280717

Review URL: https://chromiumcodereview.appspot.com/23750002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220541 0039d316-1c4b-4281-b951-d872f2087c98

When an app window is focused, a new menu item is created for that app 
and appended to the main menu. All of Chrome's menu items are hidden. 
When a Chrome window is focused, the app's menu item is removed and 
Chrome's menu items are unhidden.

This is a second attempt at https://codereview.chromium.org/18089012/
which had to be reverted because it broke keyboard shortcuts.

This moves all packaged app menu item handling into a new AppShimMenuController.

BUG=168080, 276052
Focus the app window, the only item in the main menu bar should be that app. 
Focus a browser window, the main menu bar returns to normal.

Review URL: https://chromiumcodereview.appspot.com/22867009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220540 0039d316-1c4b-4281-b951-d872f2087c98

This is required to let the auto-generated codes by scheme compiler refer the
API functions.

BUG=253358
TEST=file_manager_browsertests
R=hashimoto@chromium.org, satorux@chromium.org

Review URL: https://codereview.chromium.org/23715003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220539 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True 
BUG=264859
TEST= 
1) Uninstall Google Chrome (if it's installed.)
2) Put mini_installer.exe for Google Chrome in the same folder as test_installer.py.
3) Run "python test_installer.py config\config.config". The test should pass.
4) Uninstall Chromium (if it's installed.)
5) Put mini_installer.exe for Chromium in the same folder as test_installer.py.
6) Run "python test_installer.py config\config.config". The test should pass.

Review URL: https://chromiumcodereview.appspot.com/23757002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220538 0039d316-1c4b-4281-b951-d872f2087c98

I also changed the signature of ui::ThemeProvider::GetDisplayProperty() because most of the callers were ignoring the return value. In some cases we were using uninitialized variables because of this.

BUG=279978
TEST=Manual, see bug
R=erg
TBR=sky (For trivial refactor)

Review URL: https://chromiumcodereview.appspot.com/23614007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220537 0039d316-1c4b-4281-b951-d872f2087c98

When scrolling by page, we just need to set scrollByPage to true.
Multiplying the scroll_delta by pixelsPerLine results in scrolling
much too far.

BUG=279035
TEST=manually tested following steps on the bug

Review URL: https://chromiumcodereview.appspot.com/23532015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220536 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/23441015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220535 0039d316-1c4b-4281-b951-d872f2087c98

R=joi@chromium.org, sievers@chromium.org, skyostil@chromium.org, vsevik@chromium.org

Review URL: https://codereview.chromium.org/23706005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220534 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TESTED=Open NTP, run chrome.embeddedSearch.searchBox.focus() in the DOM inspector.

Review URL: https://chromiumcodereview.appspot.com/23462014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220531 0039d316-1c4b-4281-b951-d872f2087c98

This is in preparation of reworking the default task selection logic.
This function will be needed from a place where FileBrowserHandler
pointers are not present.

BUG=282109
TEST=none
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/23455020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220530 0039d316-1c4b-4281-b951-d872f2087c98

BUG=275270
TEST=unit_tests
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/23565004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220529 0039d316-1c4b-4281-b951-d872f2087c98

Rename ResourceMetadata::GetChildResourceId to GetChildId

BUG=275270
TEST=unit_tests
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/23571006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220528 0039d316-1c4b-4281-b951-d872f2087c98

BUG=282116
TBR=fsamuel@chromium.org

Review URL: https://codereview.chromium.org/23815002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220527 0039d316-1c4b-4281-b951-d872f2087c98