GitLab

Android uses gcc 4.8 for target on arm64, so -Wno-unused-local-typedefs
gets added to the gcc command line; unfortunately the host toolchain on
mac does not support this flag. We have no way to detect the host
toolchain version in the WebView build because we generate makefiles in
advance instead of on the build machine, so just hardcode an exception
until the instances of this warning can be fixed and this entire
conditional section removed.

BUG=321833

Review URL: https://codereview.chromium.org/277983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269766 0039d316-1c4b-4281-b951-d872f2087c98

Fixes an issue where transient untrusted state is reported as permanent.

BUG=362430
TEST=browser_tests

Review URL: https://codereview.chromium.org/271063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269765 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334149
R=haraken@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/273873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269764 0039d316-1c4b-4281-b951-d872f2087c98

Two failures were observed:

1. If the GPU process crashed between EstablishGpuChannel and
   CreateViewCommandBuffer, the channel would never be properly marked
   as lost. Now, if CreateViewCommandBuffer fails, mark the
   GpuChannelHost as lost on the renderer side. The RenderThreadImpl
   will then establish a new connection to the new GPU process.

2. In Issue 308675, support was added to allow Telemetry to navigate
   to about:gpucrash, specifically for this test. It turns out that
   each navigation from Telemetry was provoking *two* GPU process
   crashes. Depending on when they came in, the test would
   intermittently receive two lost context events and fail. Squelch
   the second debug URL handling in NavigationControllerImpl.

These fix the locally reproducible failures of this test.

BUG=365904
TEST=src/content/test/gpu/run_gpu_test.py context_lost --browser=debug --show-stdout -v --page-filter=WebGLContextLostFromGPUProcessExit --page-repeat=30

Review URL: https://codereview.chromium.org/277113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269763 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
This seems to have broken ResetFirstAfterBootTest.SuccessOnRollbackRequested on http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/23801.

Original issue's description:
> Rollback option put behind the flag.
> 
> BUG=368860
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269753

TBR=nkostylev@chromium.org,merkulova@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=368860

Review URL: https://codereview.chromium.org/279203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269762 0039d316-1c4b-4281-b951-d872f2087c98

Now that blink side's landed and rolled we no longer need
HAS_SERVICE_WORKER_CONTEXT_DESTROYED ifdefs

BUG=366617
TEST=no functional changes

Review URL: https://codereview.chromium.org/273423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269761 0039d316-1c4b-4281-b951-d872f2087c98

This is roughly how this works.
- Takes the bounds of the edge indicator in screen coords
  and convert to native coords
- If the location of mouse in native coords moves into this
  bounds, we need to warp the mouse.
- Convert the current mouse location in screen coords to the
  destination window's host coords. Adjust so that the location is inside the host window's bounds.

No flag. I'll simply flip the flag if I need to disable this on branch.

BUG=321699,306632
TEST=TBD

Review URL: https://codereview.chromium.org/270863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269758 0039d316-1c4b-4281-b951-d872f2087c98

To distinguish serious failures from not-found cases.

BUG=None
TEST=unit_tests

Review URL: https://codereview.chromium.org/276313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269757 0039d316-1c4b-4281-b951-d872f2087c98

To abort as soon as possible when encoutering serious errors.

BUG=None
TEST=unit_tests

Review URL: https://codereview.chromium.org/278273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269756 0039d316-1c4b-4281-b951-d872f2087c98

BUG=341353

Review URL: https://codereview.chromium.org/276263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269755 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368860

Review URL: https://codereview.chromium.org/267393011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269753 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a basic version of a start page to the experimental app list.
This page contains a WebView that displays the Google Logo and a grey bar
which are currently only placeholders.

This CL also modifies the StartPage WebUI to have the google logo.

BUG=349727

Review URL: https://codereview.chromium.org/186483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269752 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168147

Review URL: https://codereview.chromium.org/279143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269751 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269750 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=173842:173849&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/277233003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269749 0039d316-1c4b-4281-b951-d872f2087c98

Vp9 codec is supported after KitKat (API level 19)
Expectation values are modifed in the test case based on the Android sdk version

HLS mime types are supported after Ice-cream sandwich (API level 14)
A check for identifying android version is added which decides whether the mime type should be added in the media_map_ or not.

Theora is not supported on Android. This check is also added in the "IsCodecSupportedOnAndroid".

MediaCanPlayType test are re-enabled on android.

BUG=357665

Review URL: https://codereview.chromium.org/230413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269748 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
This broke our app. We do not understand why the breakage happened or
why browser_tests could not catch this yet. However, as our app do not
want this in M36, I'd revert this change without checking.

BUG=372163


Original issue's description:
> Pepper: Clean up ProgressEvent logic.
> 
> This simplifies NexeLoadManager, which is getting pretty big. This also removes
> an unused field from ProgressEvent, and adds a convenience function for posting
> a task to dispatch a progress event from the main thread, which is often
> necessary to ensure that progress events are posted to the DOM after other
> state changes.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269362

TBR=dmichael@chromium.org,teravest@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/275403004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269747 0039d316-1c4b-4281-b951-d872f2087c98

Add null checks where needed and ensure that the right type of entry is used
for each use case.

BUG=370863, 273710
TEST=See bug, comment 3 for repro steps.

Review URL: https://codereview.chromium.org/273163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269746 0039d316-1c4b-4281-b951-d872f2087c98

This CL changes the generation of bookmark apps to create an icon that
consists of the favicon's dominant color as a background with the first
letter of the app's domain painted over it.

The letter is either black or white depending on the luminance of the
background.

This CL also turns on generation of 2x icons for 32 and 48 px icons.

BUG=315632

Review URL: https://codereview.chromium.org/246333006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269745 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371689

Review URL: https://codereview.chromium.org/274633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269744 0039d316-1c4b-4281-b951-d872f2087c98

Crashes on Win7, more info on the bug.
TBRing the expected test owner.
Your friendly tree sheriff.

BUG=372277
TBR=michaelpg@chromium.org

Review URL: https://codereview.chromium.org/281513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269743 0039d316-1c4b-4281-b951-d872f2087c98

This adds the ability to fetch accessibility data from the plugin. It also adds a test for this function.

BUG=303491

Review URL: https://codereview.chromium.org/265283005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269742 0039d316-1c4b-4281-b951-d872f2087c98

Use OutputSurface::DidSwapBuffers() as the source of whether
we swapped or not.

R=brianderson@chromium.org
BUG=363414
TEST=cc_unittests

Review URL: https://codereview.chromium.org/246753008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269738 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/273393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269737 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org
BUG=372254

Review URL: https://codereview.chromium.org/279133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269736 0039d316-1c4b-4281-b951-d872f2087c98

between Protected Preferences and unprotected Preferences.

Migration from unprotected Preferences to Protected Preferences was previously
done after both stores had been initialized. This was inherently incorrect as
some operations (PrefHashFilter::FilterOnLoad) would occur before the values
had been moved to the proper store. It also introduced a weird method in
PrefHashFilter::MigrateValues which required an independent PrefHashFilter
(backed by a copy of the real PrefHashStore). This after-the-fact migration
caused Settings.TrackedPreferenceCleared spikes when changing a value from
being enforced to not being enforced (as we'd have a MAC, but no value yet in
this store when running FilterOnLoad()) and more importantly it also caused
issue 365769 -- both of these issues highlight the incorrectness of the
current approach.

The migration back from Protected Preferences to unprotected Preferences when
enforcement was disabled was using yet another mechanism which would only kick
in when a given pref was written to (ref. old non-const
SegregatedPrefStore::StoreForKey()).

The new framework intercepts PrefFilter::FilterOnLoad() events for both stores
and does the back-and-forth migration in place before it even hands them back
to the PrefFilter::FinalizeFilterOnLoad() which then hands it back to the
JsonPrefStores (so that they are agnostic to the migration; from their point
of view their values were always in their store as they received it).
Furthermore, this new framework will easily allow us to later move MACs out of
Local State into their respective stores (which is a task on our radar which
we currently have no easy way to accomplish).

The new framework also handles read errors better. For example, it was
previously possible for the unprotected->protected migration to result in data
loss if the protected store was somehow read-only from a read error while the
unprotected store wasn't -- resulting in an in-memory migration only flushed
to disk in the store from which the value was deleted... The new framework
handles those cases, preferring temporary data duplication over potential data
loss (duplicated data is cleaned up once confirmation is obtained that the new
authority for this data has been successfully written to disk -- it will even
try again in following Chrome runs if it doesn't succeed in this one).

Note: This CL helped LSAN discover an existing leak in post_task_and_reply_impl.cc, see issue 371974 for details.

BUG=365769, 371974
TEST=
A) Make sure all kTrackedPrefs consistently report
   Settings.TrackedPreferenceUnchanged across changes from various enforcement
   levels (using --force-fieldtrials).
B) Make sure the prefs are properly migrated to their new store (and
   subsequently cleaned up from their old store) when changing the
   enforcement_level across multiple runs.
C) Make sure prefs are properly migrated in a quick startup/shutdown with a
   new enforcement_level and that their old value is properly cleaned up in a
   subsequent startup at the same enforcement_level (or re-migrated at another
   enforcement_level).

R=bauerb@chromium.org, robertshield@chromium.org, stuartmorgan@chromium.org, thakis@chromium.org

Initially Committed in: https://src.chromium.org/viewvc/chrome?view=rev&revision=269346
Reverted in: https://src.chromium.org/viewvc/chrome?view=rev&revision=269367
Committed again: https://src.chromium.org/viewvc/chrome?view=rev&revision=269415
Reverted again: https://src.chromium.org/viewvc/chrome?view=rev&revision=269438

Review URL: https://codereview.chromium.org/257003007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269735 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357776

Review URL: https://codereview.chromium.org/274313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269734 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269727 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=173823:173842&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/276243002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269726 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365762
R=engedy@chromium.org, jochen@chromium.org, pkasting@chromium.org, zea@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269396

Review URL: https://codereview.chromium.org/268643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269725 0039d316-1c4b-4281-b951-d872f2087c98

Added field allows Blink to properly restore pinch-zoomed page
when using new "virtual viewport" mode of pinch.

Dependent Blink patch: https://codereview.chromium.org/263853008

BUG=364112

Review URL: https://codereview.chromium.org/266673014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269724 0039d316-1c4b-4281-b951-d872f2087c98

BUG=365762
R=pkasting@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269310

Review URL: https://codereview.chromium.org/270533007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269723 0039d316-1c4b-4281-b951-d872f2087c98

Disable SigninErrorNotifierTest.AuthStatusEnumerateAllErrors and SigninErrorNotifierTest.ErrorAuthStatusProvider

BUG=372236
TBR=michaelpg@chromium.org

Review URL: https://codereview.chromium.org/279123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269722 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bokan@chromium.org
TEST=waterfall
BUG=372226

Review URL: https://codereview.chromium.org/272403003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269717 0039d316-1c4b-4281-b951-d872f2087c98

Handle TemplateURLService load failure better, and make some test correctness fixes that will be needed later.

This also does a variety of miscellaneous cleanups to the modified files.

BUG=364183
TEST=none
R=jered@chromium.org, pkasting@chromium.org
TBR=engedy

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269329

Review URL: https://codereview.chromium.org/272573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269716 0039d316-1c4b-4281-b951-d872f2087c98

missing from uploaded crashes.

BUG=371817

Review URL: https://codereview.chromium.org/275213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269715 0039d316-1c4b-4281-b951-d872f2087c98

BUG=356791

Review URL: https://codereview.chromium.org/238863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269714 0039d316-1c4b-4281-b951-d872f2087c98

This is already initialized by CocoaProfileTest.

BUG=365762
TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/276063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269713 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269709 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367366

Review URL: https://codereview.chromium.org/263003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269707 0039d316-1c4b-4281-b951-d872f2087c98